RE: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

2018-12-04 Thread PETER CHEN
> On 04.12.18 21:01, Fabio Estevam wrote: > > Hi Frieder, > > > > On Tue, Dec 4, 2018 at 12:31 PM Schrempf Frieder > > wrote: > > > >> There are many other optional properties for this driver and a lot of > >> them are not in the given example. Maybe we should just keep the > >> pinctrls for HSI

Re: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

2018-12-04 Thread Schrempf Frieder
Hi Fabio, On 04.12.18 21:01, Fabio Estevam wrote: > Hi Frieder, > > On Tue, Dec 4, 2018 at 12:31 PM Schrempf Frieder > wrote: > >> There are many other optional properties for this driver and a lot of >> them are not in the given example. Maybe we should just keep the >> pinctrls for HSIC-mode

RE: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-04 Thread Pawel Laszczak
Hi, >> >> >> >> Patch adds core.c and core.h file that implements initialization >> >> of platform driver and adds function responsible for selecting, >> >> switching and running appropriate Device/Host mode. >> >> >> >> Signed-off-by: Pawel Laszczak >> >> --- >> >> drivers/usb/cdns3/Makefile |

Re: [PATCH] USB: qcaux: Add Motorola modem UARTs

2018-12-04 Thread Johan Hovold
On Sun, Dec 02, 2018 at 05:34:24PM -0800, Tony Lindgren wrote: > On Motorola Mapphone devices such as Droid 4 there are five USB ports > that do not use the same layout as Gobi 1K/2K/etc devices listed in > qcserial.c. So we should use qcaux.c or option.c as noted by > Dan Williams . > > The ff/ff

Re: [PATCH 1/2 v4] USB: serial: mos7840: Adjust port settings for read and write registers

2018-12-04 Thread Johan Hovold
On Fri, Nov 30, 2018 at 02:31:21PM +0800, Jackychou wrote: > From: JackyChou > > In the read/write function, set port 2 independently in the 2-port case. > > When setting the offset of port registers, the offset between port 1 and > other ports is different, so port 1 is set independently. > The

Re: [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960

2018-12-04 Thread Chen Yu
Hi, On 2018/12/5 1:47, Andy Shevchenko wrote: > On Tue, Dec 4, 2018 at 3:40 AM Chen Yu wrote: >> On 2018/12/3 17:23, Andy Shevchenko wrote: >>> On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: > + .of_match_table = of_match_ptr(id_table_hisi_hikey_usb), >>> >>> Does it compiles

Re: [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code.

2018-12-04 Thread Chen Yu
On 2018/12/4 18:54, Heikki Krogerus wrote: > On Mon, Dec 03, 2018 at 11:45:12AM +0800, Yu Chen wrote: >> The Type-C drivers use USB role switch API to inform the >> system about the negotiated data role, so registering a role >> switch in the DRD code in order to support platforms with >> USB Ty

[PATCH 2/3] usb: appledisplay: Set urb transfer_flags to URB_NO_TRANSFER_DMA_MAP

2018-12-04 Thread alex . theissen
From: Alexander Theissen The driver does allocate a DMA address with usb_alloc_coherent but did not set the appropriate flag to signal that transfer_dma is set to a valid value. Signed-off-by: Alexander Theissen --- drivers/usb/misc/appledisplay.c | 1 + 1 file changed, 1 insertion(+) diff --

[PATCH 3/3] usb: appledisplay: Remove unnecessary spinlock

2018-12-04 Thread alex . theissen
From: Alexander Theissen The spinlock was inside the urb completion function which is only called once per display and is then resubmitted from this function. There was no other place where this lock was used. Signed-off-by: Alexander Theissen --- drivers/usb/misc/appledisplay.c | 7 --- 1

[PATCH 0/3] Small improvements to the appledisplay driver

2018-12-04 Thread alex . theissen
With the exception of the first patch I am not entirely sure if my changes are correct and justified. This is my first contribution and I am equally satisfied if someone could point out why my changes are not correct. The added display is my own and works well with the driver. drivers/usb/misc/ap

[PATCH 1/3] usb: appledisplay: Add 27" Apple Cinema Display

2018-12-04 Thread alex . theissen
From: Alexander Theissen Add another Apple Cinema Display to the list of supported displays. Signed-off-by: Alexander Theissen --- drivers/usb/misc/appledisplay.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c index 85b48c6

Re: [RFC PATCH v2 03/15] dt-bindings: add binding for USBSS-DRD controller.

2018-12-04 Thread Rob Herring
On Sun, Nov 18, 2018 at 10:08:59AM +, Pawel Laszczak wrote: > Thsi patch aim at documenting USB related dt-bindings for the typo > Cadence USBSS-DRD controller. > > Signed-off-by: Pawel Laszczak > --- > .../devicetree/bindings/usb/cdns3-usb.txt | 17 + > 1 file change

Re: [PATCH] USB: quirks: add NO_LPM quirk for Logitech Flare|Meetup|Brio|Rally

2018-12-04 Thread Alan Stern
On Tue, 4 Dec 2018, Kyle Williams wrote: > Description: Some USB device / host controller combinations seem to have > problems with Link Power management. In particular it is described that > the combination of certain Logitech devices and other powered media > devices such as the Atrus device cau

Re: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

2018-12-04 Thread Fabio Estevam
Hi Frieder, On Tue, Dec 4, 2018 at 12:31 PM Schrempf Frieder wrote: > There are many other optional properties for this driver and a lot of > them are not in the given example. Maybe we should just keep the > pinctrls for HSIC-mode out of the example, too? I am just trying to make life easier f

RE: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2018-12-04 Thread Alan Stern
On Tue, 4 Dec 2018, Anurag Kumar Vulisha wrote: > >Is there any way for the device controller driver to detect the problem > >without relying > >on a timeout? > > > >In fact, is this problem a known bug in the existing device controller > >hardware? Have > >the controller manufacturers publishe

RE: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2018-12-04 Thread Anurag Kumar Vulisha
Hi Alan, >-Original Message- >From: Alan Stern [mailto:st...@rowland.harvard.edu] >Sent: Tuesday, December 04, 2018 10:17 PM >To: Anurag Kumar Vulisha >Cc: Felipe Balbi ; Greg Kroah-Hartman >; Shuah Khan ; Johan Hovold >; Jaejoong Kim ; Benjamin >Herrenschmidt ; Roger Quadros ; Manu >Gaut

dwc2 isochronous transfers issues

2018-12-04 Thread Andrzej Pietrasiewicz
Hi All, I have recently noticed a problem with dwc2 and audio gadget. The expected behavior: The uac2 function acts as a kind of a pass-through. For example to play audio from USB host on an Odroid U3 the following command is issued at the host: aplay -D plughw:CARD=Gadget,DEV=0 /usr/share/soun

Re: [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960

2018-12-04 Thread Andy Shevchenko
On Tue, Dec 4, 2018 at 3:40 AM Chen Yu wrote: > On 2018/12/3 17:23, Andy Shevchenko wrote: > > On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: > >> + .of_match_table = of_match_ptr(id_table_hisi_hikey_usb), > > > > Does it compiles for non-OF case? Why macro is in use? > OK. I will

RE: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2018-12-04 Thread Alan Stern
On Tue, 4 Dec 2018, Anurag Kumar Vulisha wrote: > >> Yes the host can cancel the transfer. This issue originated from the > >> endpoints using > >bulk > >> streaming protocol and may not occur with normal endpoints. AFAIK bulk > >> streaming > >is > >> gadget driven, where the gadget is allowed

RE: scsi_set_medium_removal timeout issue

2018-12-04 Thread Alan Stern
On Thu, 29 Nov 2018, Zengtao (B) wrote: > Ping? > > >-Original Message- > >From: Alan Stern [mailto:st...@rowland.harvard.edu] > >Sent: Wednesday, November 14, 2018 11:35 PM > >To: Martin Petersen ; Zengtao (B) > > > >Cc: j...@linux.vnet.ibm.com; gre...@linuxfoundation.org; > >linux-s...@

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-04 Thread Johan Hovold
On Tue, Dec 04, 2018 at 05:15:18PM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 04, 2018 at 05:00:36PM +0100, Johan Hovold wrote: > > The USB-serial console implementation has never reported the actual > > terminal settings used. Despite storing the corresponding cflags in its > > struct console,

RE: [PATCH v7 01/10] usb: gadget: udc: Add timer support for usb requests

2018-12-04 Thread Anurag Kumar Vulisha
Hi Alan, >-Original Message- >From: Alan Stern [mailto:st...@rowland.harvard.edu] >Sent: Tuesday, December 04, 2018 4:38 AM >To: Anurag Kumar Vulisha >Cc: Felipe Balbi ; Greg Kroah-Hartman >; Shuah Khan ; Johan Hovold >; Jaejoong Kim ; Benjamin >Herrenschmidt ; Roger Quadros ; Manu >Gauta

Re: [PATCH] USB: serial: console: fix reported terminal settings

2018-12-04 Thread Greg Kroah-Hartman
On Tue, Dec 04, 2018 at 05:00:36PM +0100, Johan Hovold wrote: > The USB-serial console implementation has never reported the actual > terminal settings used. Despite storing the corresponding cflags in its > struct console, this was never honoured on later tty open() where the > tty termios would b

[PATCH] USB: serial: console: fix reported terminal settings

2018-12-04 Thread Johan Hovold
The USB-serial console implementation has never reported the actual terminal settings used. Despite storing the corresponding cflags in its struct console, this was never honoured on later tty open() where the tty termios would be left initialised to the driver defaults. Unlike the serial console

Re: pl2303 regression after v4.17. Bisected to 7041d9c3f01b

2018-12-04 Thread Johan Hovold
On Mon, Nov 26, 2018 at 02:29:53PM +0200, Jarkko Nikula wrote: > On 11/24/18 7:32 PM, Florian Zumbiehl wrote: > > Hi, > > > >> Requested baud setting looks odd to me. Maybe related to this > >> --keep-baud flag in "/sbin/agetty -o -p -- \u --keep-baud > >> 115200,38400,9600 ttyUSB0 vt220"? That i

Re: USB driver resets

2018-12-04 Thread Mika Westerberg
On Tue, Dec 04, 2018 at 04:45:33PM +0200, Mathias Nyman wrote: > On 03.12.2018 12:36, Richard van der Hoff wrote: > > Does anybody have any suggestions as to how I could set about debugging > > this? I'm seeing the same symptoms on a 4.19 kernel. > > > > > > On 19/11/2018 15:27, Richard van der

Re: USB driver resets

2018-12-04 Thread Mathias Nyman
On 03.12.2018 12:36, Richard van der Hoff wrote: Does anybody have any suggestions as to how I could set about debugging this? I'm seeing the same symptoms on a 4.19 kernel. On 19/11/2018 15:27, Richard van der Hoff wrote: I have a USB-3.1 dock, which I use for video (via displayport alt mode

[PATCH] usb: core: Remove unnecessary memset()

2018-12-04 Thread Suwan Kim
register_root_hub() calls memset() setting usb_dev->bus->devmap. devicemap to 0 during hcd probe function (usb_hcd_pci_probe). But in previous function which is also the procedure of usb_hcd_pci_probe(), usb_bus_init() already initialized bus->devmap calling memset(). Furthermore, register_root_hub

Re: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

2018-12-04 Thread Schrempf Frieder
Hi Peter, hi Fabio, On 30.11.18 03:33, PETER CHEN wrote: > >> >> On Tue, Nov 27, 2018 at 7:31 AM PETER CHEN wrote: >>> >>> For USB HSIC, the data and strobe pin needs to be pulled down at >>> default, we consider it as "idle" state. When the USB host is ready to >>> be used, the strobe pin nee

Re: [PATCH] usb: dwc2: Disable power down feature on Samsung SoCs

2018-12-04 Thread Artur Petrosyan
Hi Marek, On 11/20/2018 19:38, Marek Szyprowski wrote: > Power down feature of DWC2 module integrated in Samsung SoCs doesn't work > properly or needs some additional handling in PHY or SoC glue layer, so > disable it for now. Without disabling power down, DWC2 causes random memory > trashes and f

Re: [PATCH v3 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-04 Thread Uwe Kleine-König
Hello, On Tue, Dec 04, 2018 at 12:43:21PM +0100, Stefan Wahren wrote: > Am 04.12.18 um 09:52 schrieb Uwe Kleine-König: > > But for the review you are right, I added the dt people to Cc for them > > to comment. In v2 Matthew also noted that he would prefer to handle the > > situation when both over

Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-04 Thread Dan Carpenter
On Tue, Dec 04, 2018 at 12:34:08PM +, Minas Harutyunyan wrote: > @@ -3185,12 +3183,13 @@ void dwc2_hsotg_disconnect(struct dwc2_hsotg *hsotg) > hsotg->connected = 0; > hsotg->test_mode = 0; > > - /* all endpoints should be shutdown */ > for (ep = 0; ep < hsotg-

Re: [PATCH v1 12/12] dts: hi3660: Add support for usb on Hikey960

2018-12-04 Thread Heikki Krogerus
On Mon, Dec 03, 2018 at 11:45:15AM +0800, Yu Chen wrote: > This patch adds support for usb on Hikey960. > > Cc: Wei Xu > Cc: Rob Herring > Cc: Mark Rutland > Cc: linux-arm-ker...@lists.infradead.org > Cc: John Stultz > Cc: Binghui Wang > Signed-off-by: Yu Chen > --- > arch/arm64/boot/dts/hi

Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-04 Thread Minas Harutyunyan
On 11/23/2018 6:43 PM, Dan Carpenter wrote: > Ugh... We also had a long thread about the v2 patch but it turns out > the list was not CC'd. I should have checked for that. > > You have to pass a flag to say if the caller holds the lock or not... > > regards, > dan carpenter > Hi Dan, Marek, M

FROM MISS DIANA HOLLAND

2018-12-04 Thread miss Diana
Attention, Good day to you, how are you? My name is Diana Holland. I am a U.S. Army Specialist, serving here in Afghanistan. I found a box containing the sum of $10,000,000.00 USD (Ten Million United States Dollars) due to my status as a U.S. Army Specialist, i can’t be able to transfer these fu

Re: [PATCH v3 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-04 Thread Stefan Wahren
Am 04.12.18 um 09:52 schrieb Uwe Kleine-König: > Hello Stefan, > > On Tue, Dec 04, 2018 at 09:40:26AM +0100, Stefan Wahren wrote: >> Am 04.12.18 um 09:31 schrieb Uwe Kleine-König: >>> The status quo on i.MX6 is that if "over-current-active-high" is >>> specified in the device tree this is configure

Re: [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code.

2018-12-04 Thread Heikki Krogerus
On Mon, Dec 03, 2018 at 11:45:12AM +0800, Yu Chen wrote: > The Type-C drivers use USB role switch API to inform the > system about the negotiated data role, so registering a role > switch in the DRD code in order to support platforms with > USB Type-C connectors. > > Cc: Felipe Balbi > Cc: Greg K

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-04 Thread Roger Quadros
On 04/12/18 10:50, Peter Chen wrote: >>> + * Cadence USBSS DRD Driver. >>> + * >>> + * Copyright (C) 2018 Cadence. >>> + * >>> + * Author: Peter Chen >>> + * Pawel Laszczak >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>

Re: [RFC PATCH v2 05/15] usb:cdns3: Added DRD support

2018-12-04 Thread Peter Chen
On Sun, Nov 18, 2018 at 6:13 PM Pawel Laszczak wrote: > > Patch adds supports for detecting Host/Device mode. > Controller has additional OTG register that allow > implement even whole OTG functionality. > At this moment patch adds support only for detecting > the appropriate mode based on strap p

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-04 Thread Peter Chen
> Hi Roger > > >On 18/11/18 12:09, Pawel Laszczak wrote: > >> Patch adds core.c and core.h file that implements initialization > >> of platform driver and adds function responsible for selecting, > >> switching and running appropriate Device/Host mode. > >> > >> Signed-off-by: Pawel Laszczak > >>

Re: [PATCH v3 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-04 Thread Uwe Kleine-König
Hello Stefan, On Tue, Dec 04, 2018 at 09:40:26AM +0100, Stefan Wahren wrote: > Am 04.12.18 um 09:31 schrieb Uwe Kleine-König: > > The status quo on i.MX6 is that if "over-current-active-high" is > > specified in the device tree this is configured as expected. If > > the property is missing polarit

Re: [RFC PATCH v2 04/15] usb:cdns3: Driver initialization code.

2018-12-04 Thread Peter Chen
> > + * Cadence USBSS DRD Driver. > > + * > > + * Copyright (C) 2018 Cadence. > > + * > > + * Author: Peter Chen > > + * Pawel Laszczak > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "gadget.h" > > +#include "co

Re: [PATCH v3 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-04 Thread Stefan Wahren
Hi Uwe, Am 04.12.18 um 09:31 schrieb Uwe Kleine-König: > The status quo on i.MX6 is that if "over-current-active-high" is > specified in the device tree this is configured as expected. If > the property is missing polarity isn't changed and so the > polarity is kept as setup by the bootloader. Res

[PATCH v3 2/3] usb: chipidea: imx: Warn if oc polarity isn't specified

2018-12-04 Thread Uwe Kleine-König
The polarity of the over current detection pin isn't configured on i.MX6/7 if it's unspecified in the device tree. So the actual configuration depends on bootloader behavior which is bad. So encourage users to fix their device tree by issuing a warning in this case. Signed-off-by: Uwe Kleine-Köni

[PATCH v3 3/3] usb: chipidea: imx: allow to configure oc polarity on i.MX25

2018-12-04 Thread Uwe Kleine-König
Up to now the polarity of the over current pin was hard coded to active high. Use the already defined device tree properties to configure polarity on i.MX25, too. In difference to i.MX6/7 use active high behavior if the polarity is unspecified to keep compatibility to existing device trees. Signed

[PATCH v3 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-04 Thread Uwe Kleine-König
The status quo on i.MX6 is that if "over-current-active-high" is specified in the device tree this is configured as expected. If the property is missing polarity isn't changed and so the polarity is kept as setup by the bootloader. Reset default is active high, so active low can only be used with h

[PATCH v3 0/3] usb: chipidea: imx: improve oc handling

2018-12-04 Thread Uwe Kleine-König
Hello, compared to v2 (which starts with Message-Id: <20181202213325.26017-1-u.kleine-koe...@pengutronix.de>) I adapted patch 1 that the oc polarity is only determined if oc isn't disabled. This results in the warning that is introduced in patch 2 not to be emitted in this case. Best regards Uwe

Re: [PATCH v2 2/3] usb: chipidea: imx: Warn if oc polarity isn't specified

2018-12-04 Thread Uwe Kleine-König
Hello Peter, On Tue, Dec 04, 2018 at 06:19:11AM +, PETER CHEN wrote: > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c > > b/drivers/usb/chipidea/ci_hdrc_imx.c > > index 80b4e4ef9b68..3dcfd0d97f94 100644 > > --- a/drivers/usb/chipidea/ci_hdrc_imx.c > > +++ b/drivers/usb/chipidea/ci_hdrc_imx