Re: [PATCH v2 net-next 19/21] net: usb: aqc111: Add support for wake on LAN by MAGIC packet

2018-11-13 Thread Igor Russkikh
>> + >> +if (aqc111_data->dpa) { >> +aqc111_set_phy_speed(dev, AUTONEG_ENABLE, SPEED_100); > > So this is better, you leave auto-neg enabled. But you really should > be taking the link partners capabilities into account. We've considered that, but then thought abo

Re: [PATCH v2 net-next 18/21] net: usb: aqc111: Implement get/set_link_ksettings callbacks

2018-11-13 Thread Igor Russkikh
>> +if (usb_speed == USB_SPEED_SUPER) { >> +ethtool_link_ksettings_add_link_mode(elk, supported, >> + 2500baseT_Full); >> +ethtool_link_ksettings_add_link_mode(elk, supported, >> +

Re: [PATCH v2 net-next 06/21] net: usb: aqc111: Introduce link management

2018-11-13 Thread Igor Russkikh
>> >> Add full hardware initialization sequence and link configuration logic > > Hi Igor > > I'm still not convinced the PHY driver should be embedded in the MAC > driver, rather than using phylink. > > If i remember correctly, it was because the MAC is involved in > determining if the link is u

RE: scsi_set_medium_removal timeout issue

2018-11-13 Thread Zengtao (B)
Hi Alan: >-Original Message- >From: Alan Stern [mailto:st...@rowland.harvard.edu] >Sent: Monday, November 12, 2018 11:33 PM >To: Zengtao (B) >Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; >gre...@linuxfoundation.org; linux-s...@vger.kernel.org; >linux-ker...@vger.kernel.org; li

Re: [PATCH v1 1/5] drivercore: Revert "deferral race condition fix"

2018-11-13 Thread Mark Brown
On Mon, Nov 12, 2018 at 06:11:26PM +0200, Peter Ujfalusi wrote: > if we revert the commit then the original issue will re-surfaces. afaik > it was not only audio which hit the 'last driver to be probed from the > deferred list would never probe, unless we provoke the kernel to load > additional mo

Re: [PATCH v1 2/5] extcon: Return -EPROBE_DEFER when extcon device is not found

2018-11-13 Thread Chanwoo Choi
Hi Andy, I was thinking about again to change from NULL to EPROBE_DEFER. extcon_get_extcon_dev() function was almost called in the probe function. But, this function might be called on other position instead of probe. ENODEV is more correct error instead of EPROBE_DEFER. Sorry. I'll withdraw my

Re: [PATCH v2] usb: dwc2: host: use hrtimer for NAK retries

2018-11-13 Thread Doug Anderson
Hi, On Sun, Sep 9, 2018 at 9:24 PM Terin Stock wrote: > > Modify the wait delay utilize the high resolution timer API to allow for > more precisely scheduled callbacks. > > A previous commit added a 1ms retry delay after multiple consecutive > NAKed transactions using jiffies. On systems with a l

Re: [PATCH V3 4/6] usb: ohci-platform: Add support for Broadcom STB SoC's

2018-11-13 Thread Alan Cooper
On Mon, Nov 12, 2018 at 6:37 PM Rob Herring wrote: > > On Wed, Nov 07, 2018 at 10:11:59AM -0800, Florian Fainelli wrote: > > On 11/7/2018 9:40 AM, Al Cooper wrote: > > > On 11/7/18 12:29 PM, Florian Fainelli wrote: > > >> On 11/7/18 8:27 AM, Alan Stern wrote: > > >>> On Wed, 7 Nov 2018, Al Cooper

Re: [PATCH v2 net-next 19/21] net: usb: aqc111: Add support for wake on LAN by MAGIC packet

2018-11-13 Thread Andrew Lunn
> +static int aqc111_suspend(struct usb_interface *intf, pm_message_t message) > +{ > + > + if (aqc111_data->dpa) { > + aqc111_set_phy_speed(dev, AUTONEG_ENABLE, SPEED_100); So this is better, you leave auto-neg enabled. But you really should be taking the link par

Re: [PATCH v2 net-next 06/21] net: usb: aqc111: Introduce link management

2018-11-13 Thread Andrew Lunn
On Tue, Nov 13, 2018 at 02:44:45PM +, Igor Russkikh wrote: > From: Dmitry Bezrukov > > Add full hardware initialization sequence and link configuration logic Hi Igor I'm still not convinced the PHY driver should be embedded in the MAC driver, rather than using phylink. If i remember correc

Re: [PATCH v2 net-next 18/21] net: usb: aqc111: Implement get/set_link_ksettings callbacks

2018-11-13 Thread Andrew Lunn
On Tue, Nov 13, 2018 at 02:45:13PM +, Igor Russkikh wrote: > +static int aqc111_get_link_ksettings(struct net_device *net, > + struct ethtool_link_ksettings *elk) > +{ > + struct usbnet *dev = netdev_priv(net); > + struct aqc111_data *aqc111_data = dev->

Re: WARNING in usb_submit_urb (4)

2018-11-13 Thread Alan Stern
On Mon, 12 Nov 2018, syzbot wrote: > syzbot has found a reproducer for the following crash on: > > HEAD commit:e12e00e388de Merge tag 'kbuild-fixes-v4.20' of git://git.k.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=100e4ef540 > kernel config: h

Re: [PATCH 4/4] arm64: dts: exynos: Update DWC3 modules on Exynos5433 SoCs

2018-11-13 Thread Krzysztof Kozlowski
On Tue, Sep 18, 2018 at 10:16:53AM +0200, Marek Szyprowski wrote: > Update DWC3 hardware modules to Exynos5433 specific variant: change > compatible name and add all required clocks (both to the glue node and > DWC3 core node). > > Signed-off-by: Marek Szyprowski > --- > arch/arm64/boot/dts/exyn

Re: [PATCH] Improve the accuracy of the baud rate generator by using round-to-closest instead of truncating when calculating baud rate divisors.

2018-11-13 Thread Nikolaj Fogh
On 11/12/18 10:54 AM, Johan Hovold wrote: On Wed, Oct 31, 2018 at 09:16:48PM +0100, Nikolaj Fogh wrote: I have experienced that the ftdi_sio driver gives less-than-optimal baud rates as the driver truncates instead of rounds to nearest during baud rate divisor calculation. Please break you

Re: [PATCH v2 2/3] spi: add FTDI MPSSE SPI controller driver

2018-11-13 Thread Anatolij Gustschin
On Tue, 13 Nov 2018 10:11:32 -0800 Mark Brown broo...@kernel.org wrote: >Please don't do this, the numbering for a patch series only makes sense >for ordering the patches within a series. If you're just sending a >single patch then there's no need to number anything, or the patch >series hasn't b

Re: [PATCH v2 2/3] spi: add FTDI MPSSE SPI controller driver

2018-11-13 Thread Mark Brown
On Sat, Nov 10, 2018 at 11:39:58AM +0100, Anatolij Gustschin wrote: > This v2 patch is the only patch of the original series that was > changed, I didn't resend whole series to avoid spamming the lists. Please don't do this, the numbering for a patch series only makes sense for ordering the patch

[PATCH v2 net-next 12/21] net: usb: aqc111: Add support for enable/disable checksum offload

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 45 - drivers/net/usb/aqc111.h | 1 + 2 files changed, 45 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/

[PATCH v2 net-next 18/21] net: usb: aqc111: Implement get/set_link_ksettings callbacks

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 124 +++ 1 file changed, 124 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index b3160b0320eb..80fedf2a

[PATCH v2 net-next 07/21] net: usb: aqc111: Add support for getting and setting of MAC address

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 47 +++ drivers/net/usb/aqc111.h | 1 + 2 files changed, 48 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc11

[PATCH v2 net-next 20/21] net: usb: aqc111: Add ASIX's HW ids

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov It enables driver for ASIX products which are also based on aqc111/112U chips. Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers/n

[PATCH v2 net-next 05/21] net: usb: aqc111: Introduce PHY access

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Add helpers to write 32bit values. Implement PHY power up/down sequences. AQC111, depending on FW used, may has PHY being controlled either directly (dpa = 1) or via vendor command interface (dpa = 0). Drivers supports both themes. We determine this from firmware versioning

[PATCH v2 net-next 17/21] net: usb: aqc111: Initialize ethtool_ops structure

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Implement get_drvinfo, set/get_msglevel, get_link callbacks Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/u

[PATCH v2 net-next 06/21] net: usb: aqc111: Introduce link management

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Add full hardware initialization sequence and link configuration logic Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 312 +++ drivers/net/usb/aqc111.h | 45 +++ 2 files changed,

[PATCH v2 net-next 15/21] net: usb: aqc111: Add support for VLAN_CTAG_TX/RX offload

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 17 + drivers/net/usb/aqc111.h | 12 +++- 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c

[PATCH v2 net-next 08/21] net: usb: aqc111: Implement TX data path

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 72 drivers/net/usb/aqc111.h | 8 ++ 2 files changed, 80 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb

[PATCH v2 net-next 16/21] net: usb: aqc111: Add RX VLAN filtering support

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 89 drivers/net/usb/aqc111.h | 2 +- 2 files changed, 90 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/driv

[PATCH v2 net-next 04/21] net: usb: aqc111: Various callbacks implementation

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Reset, stop callbacks, driver unbind callback. More register defines required for these callbacks. Add helpers to read/write 16bit values Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 76 +++ d

[PATCH v2 net-next 19/21] net: usb: aqc111: Add support for wake on LAN by MAGIC packet

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 215 +++ drivers/net/usb/aqc111.h | 12 +++ 2 files changed, 227 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/

[PATCH v2 net-next 21/21] net: usb: aqc111: Extend cdc_ether blacklist

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Added Aquantia and ASIX device IDs to prevent loading cdc_ether for these devices. Our firmware reports CDC configuration simultaneously with vendor specific. Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/cdc_ether.c | 23 +++

[PATCH v2 net-next 14/21] net: usb: aqc111: Implement set_rx_mode callback

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 72 drivers/net/usb/aqc111.h | 4 +++ 2 files changed, 71 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/aqc111.c b/dr

[PATCH v2 net-next 13/21] net: usb: aqc111: Add support for TSO

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 4 drivers/net/usb/aqc111.h | 8 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index 891d6832b87c

[PATCH v2 net-next 09/21] net: usb: aqc111: Implement RX data path

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 103 +++ drivers/net/usb/aqc111.h | 15 +++ 2 files changed, 118 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/

[PATCH v2 net-next 10/21] net: usb: aqc111: Add checksum offload support

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 38 ++ drivers/net/usb/aqc111.h | 16 ++-- 2 files changed, 52 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/aqc111.c b

[PATCH v2 net-next 11/21] net: usb: aqc111: Add support for changing MTU

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 60 +++- 1 file changed, 59 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index 90061157

[PATCH v2 net-next 00/21] Add support for Aquantia AQtion USB to 5/2.5GbE devices

2018-11-13 Thread Igor Russkikh
This patchset introduces support for new multigig ethernet to USB dongle, developed jointly by Aquantia (Phy) and ASIX (USB MAC). The driver has similar structure with other ASIX MAC drivers (AX88179), but with a number of important differences: - Driver supports both direct Phy and custom firmwar

[PATCH v2 net-next 01/21] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Initialize usb_driver structure skeleton Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/Kconfig | 12 drivers/net/usb/Makefile | 1 + drivers/net/usb/aqc111.c | 41 + 3 files changed,

[PATCH v2 net-next 02/21] net: usb: aqc111: Add bind and empty unbind callbacks

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Initialize net_device_ops structure Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index

[PATCH v2 net-next 03/21] net: usb: aqc111: Add implementation of read and write commands

2018-11-13 Thread Igor Russkikh
From: Dmitry Bezrukov Read/write command register defines and functions Signed-off-by: Dmitry Bezrukov Signed-off-by: Igor Russkikh --- drivers/net/usb/aqc111.c | 92 drivers/net/usb/aqc111.h | 18 ++ 2 files changed, 110 insertions(+)

Re: [PATCH] usb: core: Fix hub port connection events lost

2018-11-13 Thread Mathias Nyman
On 13.11.2018 15:40, Dennis Wassenberg wrote: This will clear the USB_PORT_FEAT_C_CONNECTION bit in case of a hub port reset only if a device is was attached to the hub port before resetting the hub port. Using a Lenovo T480s attached to the ultra dock it was not possible to detect some usb-c de

[PATCH] usb: core: Fix hub port connection events lost

2018-11-13 Thread Dennis Wassenberg
This will clear the USB_PORT_FEAT_C_CONNECTION bit in case of a hub port reset only if a device is was attached to the hub port before resetting the hub port. Using a Lenovo T480s attached to the ultra dock it was not possible to detect some usb-c devices at the dock usb-c ports because the hub_po

Re: USB-C device hotplug issue

2018-11-13 Thread Dennis Wassenberg
On 09.11.18 14:47, Mathias Nyman wrote: > On 07.11.2018 11:08, Dennis Wassenberg wrote: >> >> On 05.11.18 16:35, Mathias Nyman wrote: >>> On 26.10.2018 17:07, Alan Stern wrote: On Fri, 26 Oct 2018, Dennis Wassenberg wrote: >>> --- a/drivers/usb/core/hub.c >>> +++ b/drivers/usb/cor

[PATCHv3] usb: gadget: f_fs: Allow scatter-gather buffers

2018-11-13 Thread Andrzej Pietrasiewicz
Some protocols implemented in userspace with FunctionFS might require large buffers, e.g. 64kB or more. Currently the said memory is allocated with kmalloc, which might fail should system memory be highly fragmented. On the other hand, some UDC hardware allows scatter-gather operation and this pat

Re: [PATCH 0/2] USB: serial: gpio line-name fix and FT232R CBUS gpio support

2018-11-13 Thread Johan Hovold
Hi Linus, Sorry about the late reply, this one got buried in the mailbox during conference travels. On Wed, Oct 10, 2018 at 11:36:28AM +0200, Linus Walleij wrote: > On Fri, Oct 5, 2018 at 3:40 PM Johan Hovold wrote: > > On Mon, Oct 01, 2018 at 11:43:55AM +0200, Linus Walleij wrote: > > > > The