RE: [PATCH v2] usb: chipidea: Always build ULPI code

2018-07-04 Thread Peter Chen
> > void ci_ulpi_exit(struct ci_hdrc *ci) > { > + if (ci->platdata->phy_mode != USBPHY_INTERFACE_MODE_ULPI) > + return; > + Only above line is duplicated, others are ok, I will apply tomorrow, no need to send v3. Peter > if (ci->ulpi) { > ulpi_unregister_

Re: Zero Packets in Isochronous Transfer Reception

2018-07-04 Thread R0b0t1
On Sun, Jul 1, 2018 at 9:12 AM, Alan Stern wrote: > On Sat, 30 Jun 2018, R0b0t1 wrote: > >> The problem seems more noticeable when using the Python libusb >> bindings but it still exists when using libusb directly. Can anyone >> suggest what to look into? > > Have you tried using usbmon to capture

Re: Incorrect PID in drivers/usb/serial/kl5kusb105.h

2018-07-04 Thread Chris Jakob
Thanks. Apologies I may have been a little premature as the device still does not seem to be working (although it is now recognised) dmesg provides: [6.864734] kl5kusb105: loading out-of-tree module taints kernel. [6.864827] kl5kusb105: module verification failed: signature and/or requir

Re: Incorrect PID in drivers/usb/serial/kl5kusb105.h

2018-07-04 Thread Johan Hovold
[ Please avoid using html when posting the lists. Including full mail below in case this did not reach the list. ] On Wed, Jul 04, 2018 at 03:05:24PM +0100, Chris Jakob wrote: > The PID definitions fro VID 05e9 are listed in > http://www.linux-usb.org/usb.ids as: > > > 05e9 Kawasaki LSI >

[PATCH 1/4] USB: serial: keyspan_pda: fix modem-status error handling

2018-07-04 Thread Johan Hovold
Fix broken modem-status error handling which could lead to bits of slab data leaking to user space. Fixes: 3b36a8fd6777 ("usb: fix uninitialized variable warning in keyspan_pda") Cc: stable # 2.6.27 Cc: Benny Halevy Signed-off-by: Johan Hovold --- drivers/usb/serial/keyspan_pda.c | 4 +++-

[PATCH 2/4] USB: serial: mos7840: fix status-register error handling

2018-07-04 Thread Johan Hovold
Add missing transfer-length sanity check to the status-register completion handler to avoid leaking bits of uninitialised slab data to user space. Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver") Cc: stable # 2.6.19 Cc: Paul B Schroeder Signed-off-by: Johan Hovold --- drivers/us

[PATCH 4/4] USB: serial: kobil_sct: add missing version error handling

2018-07-04 Thread Johan Hovold
Add missing version-request error handling and suppress printing of the (zeroed) transfer-buffer content in case of errors. Signed-off-by: Johan Hovold --- drivers/usb/serial/kobil_sct.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/usb/serial/kobil_sct

[PATCH 3/4] USB: serial: kobil_sct: fix modem-status error handling

2018-07-04 Thread Johan Hovold
Make sure to return -EIO in case of a short modem-status read request. While at it, split the debug message to not include the (zeroed) transfer buffer content in case of errors. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Johan Hovold --- drivers/usb/serial/kobil_sct.c | 12 +++

Re: dwc2 (on Meson8b) doesn't detect "hot-plugged" USB devices

2018-07-04 Thread Martin Blumenstingl
On Wed, Jul 4, 2018 at 4:16 PM Martin Blumenstingl wrote: [...] > unfortunately it seems that plugging in seems to fill the kmsg buffer > instantly, so I cannot (at least I don't know how - do you have any > idea how to get around this?) get the information from the second > where I'm plugging in

Re: [PATCH] cp210x: add another USB ID for Qivicon ZigBee stick

2018-07-04 Thread Johan Hovold
On Wed, Jul 04, 2018 at 02:07:42PM +0300, Olli Salonen wrote: > There are two versions of the Qivicon Zigbee stick in circulation. This adds > the second USB ID to the cp210x driver. > > Signed-off-by: Olli Salonen Now applied, thanks. Johan -- To unsubscribe from this list: send the line "unsu

Re: [PATCH] USB: serial: ch341: type promotion bug in ch341_control_in()

2018-07-04 Thread Johan Hovold
On Wed, Jul 04, 2018 at 12:29:38PM +0300, Dan Carpenter wrote: > The "r" variable is an int and "bufsize" is an unsigned int so the > comparison is type promoted to unsigned. If usb_control_msg() returns a > negative that is treated as a high positive value and the error handling > doesn't work. >

Re: dwc2 (on Meson8b) doesn't detect "hot-plugged" USB devices

2018-07-04 Thread Artur Petrosyan
Martin, On 7/4/2018 17:13, Martin Blumenstingl wrote: > Hello Arthur, Hello Minas, > > On Wed, Jul 4, 2018 at 1:43 PM Artur Petrosyan > wrote: >> >> Hello Martin, >> >> On 7/4/2018 01:39, Martin Blumenstingl wrote: >>> Hello Minas, >>> >>> On Thu, May 10, 2018 at 11:44 AM Martin Blumenstingl >>>

Re: dwc2 (on Meson8b) doesn't detect "hot-plugged" USB devices

2018-07-04 Thread Martin Blumenstingl
Hello Arthur, Hello Minas, On Wed, Jul 4, 2018 at 1:43 PM Artur Petrosyan wrote: > > Hello Martin, > > On 7/4/2018 01:39, Martin Blumenstingl wrote: > > Hello Minas, > > > > On Thu, May 10, 2018 at 11:44 AM Martin Blumenstingl > > wrote: > >> > >> Hello Minas, > >> > >> On Mon, May 7, 2018 at 3:

Re: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

2018-07-04 Thread Fabio Estevam
Hi Peter, On Wed, Jul 4, 2018 at 5:24 AM, Peter Chen wrote: > It seems there is no harm if we always include drivers/usb/chipidea/ulpi.c > except increasing > a little code size, how about always build ulpi.c for the whole chipidea at > Makefile, delete > CONFIG_USB_CHIPIDEA_ULPI as well, mean

[PATCH v2] usb: chipidea: Always build ULPI code

2018-07-04 Thread Fabio Estevam
From: Fabio Estevam Commit 03e6275ae381 ("usb: chipidea: Fix ULPI on imx51") causes a kernel hang on imx51 systems that use the ULPI interface and do not select the CONFIG_USB_CHIPIDEA_ULPI option. In order to avoid such potential misuse, let's always build the chipidea ULPI code into the final

Re: [PATCH] usb: quirks: add delay quirks for Corsair Strafe

2018-07-04 Thread Greg KH
On Wed, Jul 04, 2018 at 03:14:17PM +0300, Nico Sneck wrote: > CC Greg in hopes of having someone take a look at this patch before > Monday (when my military service starts). It's in my queue, will probably get to it next week. At first glance looks fine. Good luck on your service! greg k-h -- T

Re: [PATCH] usb: quirks: add delay quirks for Corsair Strafe

2018-07-04 Thread Nico Sneck
CC Greg in hopes of having someone take a look at this patch before Monday (when my military service starts). On 02.07.2018 19:26, Nico Sneck wrote: Corsair Strafe appears to suffer from the same issues as the Corsair Strafe RGB. Apply the same quirks (control message delay and init delay) that

Re: dwc2 (on Meson8b) doesn't detect "hot-plugged" USB devices

2018-07-04 Thread Artur Petrosyan
Hello Martin, On 7/4/2018 01:39, Martin Blumenstingl wrote: > Hello Minas, > > On Thu, May 10, 2018 at 11:44 AM Martin Blumenstingl > wrote: >> >> Hello Minas, >> >> On Mon, May 7, 2018 at 3:27 PM, Minas Harutyunyan >> wrote: >>> Hi Martin, >>> >>> On 5/7/2018 12:28 AM, Martin Blumenstingl wrot

[PATCH] cp210x: add another USB ID for Qivicon ZigBee stick

2018-07-04 Thread Olli Salonen
There are two versions of the Qivicon Zigbee stick in circulation. This adds the second USB ID to the cp210x driver. Signed-off-by: Olli Salonen --- drivers/usb/serial/cp210x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index ee0

[PATCH] xhci: xhci-mem: off by one in xhci_stream_id_to_ring()

2018-07-04 Thread Dan Carpenter
The > should be >= here so that we don't read one element beyond the end of the ep->stream_info->stream_rings[] array. Fixes: e9df17eb1408 ("USB: xhci: Correct assumptions about number of rings per endpoint.") Signed-off-by: Dan Carpenter diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/h

[PATCH] USB: serial: ch341: type promotion bug in ch341_control_in()

2018-07-04 Thread Dan Carpenter
The "r" variable is an int and "bufsize" is an unsigned int so the comparison is type promoted to unsigned. If usb_control_msg() returns a negative that is treated as a high positive value and the error handling doesn't work. Fixes: 2d5a9c72d0c4 ("USB: serial: ch341: fix control-message error han

[PATCH -next] usb: typec: altmodes: Fix missing unlock on error in dp_altmode_activate()

2018-07-04 Thread Wei Yongjun
Add the missing unlock before return from function dp_altmode_activate() in the error handling case. Fixes: 0e3bb7d6894d ("usb: typec: Add driver for DisplayPort alternate mode") Signed-off-by: Wei Yongjun --- drivers/usb/typec/altmodes/displayport.c | 6 -- 1 file changed, 4 insertions(+),

RE: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

2018-07-04 Thread Peter Chen
> On Tue, Jul 3, 2018 at 12:40 AM, Shawn Guo wrote: > > > We can have the options in defconfig, but they can still be turned off > > for whatever reason and we get the hang. Really, missing a user > > selectable option in defconfig shouldn't result in a system hang. > > Yes, 100% agree and th