Re: [PATCH 1/2] usb: gadget: move gadget API functions to udc-core

2016-05-31 Thread Felipe Balbi
Hi, Peter Chen writes: > On Tue, May 31, 2016 at 02:58:33PM +0300, Felipe Balbi wrote: >> instead of defining all functions as static inlines, >> let's move them to udc-core and export them with >> EXPORT_SYMBOL_GPL, that way we can make sure that >> only GPL drivers will use them. >> > > One c

Re: [PATCH 1/2] usb: dwc3: gadget: set xfer resource per endpoint

2016-05-31 Thread Felipe Balbi
Hi, John Youn writes: > On 5/30/2016 7:19 AM, Felipe Balbi wrote: >> Instead of looping through all endpoints when >> enabling ep0, let's allow for each endpoint to set >> its own xfer resource. This solves an issue which >> happens when we issue END_TRANSFER due to a reset >> interrupt. Endpoin

[PATCH v2 2/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

2016-05-31 Thread Yoshihiro Shimoda
Since the commit b1c127ae990b ("usb: host: xhci: plat: make use of new methods in xhci_plat_priv") changed the setting timing of xhci->quirks to xhci_rcar_init_quirk(), the quirks was overwritten by xhci_gen_setup(). So, this patch fixes the issue using a "quirks" of struct xhci_plat_priv. Signed

[PATCH v2 0/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

2016-05-31 Thread Yoshihiro Shimoda
I'm afraid but I found a regression of xhci-rcar in v4.7-rc1. This regression is caused by the following commit: commit b1c127ae990bccf0187d741c1695a61e54de1943 Author: Felipe Balbi Date: Fri Apr 22 13:17:16 2016 +0300 usb: host: xhci: plat: make use of new methods in xhci_plat_priv

[PATCH v2 1/2] usb: host: xhci: plat: add ->quirks value for platform-specific

2016-05-31 Thread Yoshihiro Shimoda
This patch adds quirks in struct xhci_plat_priv to set xhci->quirks for platform-specific. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/host/xhci-plat.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-plat.h b/drivers/usb/host/xhci-plat.h index 9af0cb4..c652f33 1006

Re: [PATCH v2] reset: Return -ENOTSUPP when not configured

2016-05-31 Thread Philipp Zabel
Hi John, Am Dienstag, den 31.05.2016, 16:55 -0700 schrieb John Youn: > Prior to commit 6c96f05c8bb8 ("reset: Make [of_]reset_control_get[_foo] > functions wrappers"), the "optional" functions returned -ENOTSUPP when > CONFIG_RESET_CONTROLLER was not set. > > Revert back to the old behavior by cha

RE: [PATCH 2/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

2016-05-31 Thread Yoshihiro Shimoda
> From: Yoshihiro Shimoda > Sent: Wednesday, June 01, 2016 11:40 AM > > Since the commit b1c127ae (usb: host: xhci: plat: make use of new methods > in xhci_plat_priv) changed the setting timing of xhci->quirks to Oops, checkpatch.pl said this message should be revised. So, I will submit v2 patch

[PATCH v2 2/2] ARM: at91/dt: sama5d2: Use new compatible for ohci node

2016-05-31 Thread Wenyou Yang
Use compatible "atmel,sama5d2-ohci" to be capable of suspending ports while sleep to save the power consumption. Signed-off-by: Wenyou Yang --- Changes in v2: - Use the new compatible for ohci-node. arch/arm/boot/dts/sama5d2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH v2 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

2016-05-31 Thread Wenyou Yang
In order to the save power consumption, as a workaround, suspend forcibly the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI Interrupt Configuration Register in the SFRs while OHCI USB suspend. This suspend operation must be done before the USB clock is disabled, resume after the USB clock i

[PATCH v2 0/2] ARM: ohci-at91: Add support to forcibly suspend ports while sleep

2016-05-31 Thread Wenyou Yang
To save the power consumption, add a new compatible to support forcibly suspend the USB PORTA/B/C via OHCI Interrupt Configuration SFR Register. Changes in v2: - Add compatible to support forcibly suspend the ports. - Add soc/at91/at91_sfr.h to accommodate the defines. - Add error checking for

Re: [PATCH v9 7/7] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers

2016-05-31 Thread Lu Baolu
Hi, On 05/30/2016 08:53 PM, Lu Baolu wrote: > Hi Heikki, > > On 05/30/2016 04:16 PM, Heikki Krogerus wrote: >> Hi Baolu, >> >> On Mon, May 30, 2016 at 01:51:44PM +0800, Lu Baolu wrote: >>> Add a maintainer entry for Intel USB dual role mux drivers and >>> add myself as a maintainer. >>> >>> Signed

[PATCH 0/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

2016-05-31 Thread Yoshihiro Shimoda
I'm afraid but I found a regression of xhci-rcar in v4.7-rc1. This regression is caused by the following commit: commit b1c127ae990bccf0187d741c1695a61e54de1943 Author: Felipe Balbi Date: Fri Apr 22 13:17:16 2016 +0300 usb: host: xhci: plat: make use of new methods in xhci_plat_priv

[PATCH 1/2] usb: host: xhci: plat: add ->quirks value for platform-specific

2016-05-31 Thread Yoshihiro Shimoda
This patch adds quirks in struct xhci_plat_priv to set xhci->quirks for platform-specific. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/host/xhci-plat.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/xhci-plat.h b/drivers/usb/host/xhci-plat.h index 9af0cb4..c652f33 1006

[PATCH 2/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

2016-05-31 Thread Yoshihiro Shimoda
Since the commit b1c127ae (usb: host: xhci: plat: make use of new methods in xhci_plat_priv) changed the setting timing of xhci->quirks to xhci_rcar_init_quirk(), the quirks was overwritten by xhci_gen_setup(). So, this patch fixes the issue using a "quirks" of struct xhci_plat_priv. Signed-off-b

Re: [PATCH 1/2] usb: dwc3: gadget: set xfer resource per endpoint

2016-05-31 Thread John Youn
On 5/30/2016 7:19 AM, Felipe Balbi wrote: > Instead of looping through all endpoints when > enabling ep0, let's allow for each endpoint to set > its own xfer resource. This solves an issue which > happens when we issue END_TRANSFER due to a reset > interrupt. Endpoints will be left without a xfer >

Re: [PATCH 2/2] usb: gadget: add tracepoints to the gadget API

2016-05-31 Thread Peter Chen
On Tue, May 31, 2016 at 02:58:34PM +0300, Felipe Balbi wrote: > This new set of tracepoints will help all gadget > drivers and UDC drivers when problem appears. Note > that, in order to be able to add tracepoints to > udc-core.c we had to rename that to core.c and > statically link it with trace.c

Re: [PATCH 1/2] usb: gadget: move gadget API functions to udc-core

2016-05-31 Thread Peter Chen
On Tue, May 31, 2016 at 02:58:33PM +0300, Felipe Balbi wrote: > instead of defining all functions as static inlines, > let's move them to udc-core and export them with > EXPORT_SYMBOL_GPL, that way we can make sure that > only GPL drivers will use them. > One concern, current some other modules m

[PATCH v3] usb: dwc3: Set the ClearPendIN bit on Clear Stall EP command

2016-05-31 Thread John Youn
As of core revision 2.60a the recommended programming model is to set the ClearPendIN bit when issuing a Clear Stall EP command for IN endpoints. This is to prevent an issue where some (non-compliant) hosts may not send ACK TPs for pending IN transfers due to a mishandled error condition. Synopsys

[PATCH v2] reset: Return -ENOTSUPP when not configured

2016-05-31 Thread John Youn
Prior to commit 6c96f05c8bb8 ("reset: Make [of_]reset_control_get[_foo] functions wrappers"), the "optional" functions returned -ENOTSUPP when CONFIG_RESET_CONTROLLER was not set. Revert back to the old behavior by changing the new __devm_reset_control_get() and __of_reset_control_get() functions

Re: [PATCH] usb: phy-omap-otg: Space required after that ','.

2016-05-31 Thread Aaro Koskinen
Hi, On Tue, May 31, 2016 at 08:59:44AM -0400, Sandhya Bankar wrote: > Space required after that ','. > > Signed-off-by: Sandhya Bankar Reviewed-by: Aaro Koskinen A. > --- > drivers/usb/phy/phy-omap-otg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/p

Re: [PATCH 00/13] usb: dwc2: Fix up gadget isochronous support

2016-05-31 Thread John Youn
On 5/31/2016 12:19 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> The following patch series fixes up isochronous support for the dwc2 >> gadget. The existing isochronous support lacked a few features. Most >> notably it did not properly sync up with the first packet and it >> didn't h

Re: [PATCH v2] usb: dwc3: Set the ClearPendIN bit on Clear Stall EP command

2016-05-31 Thread John Youn
On 5/31/2016 12:09 AM, Felipe Balbi wrote: > > Hi John, > > John Youn writes: >> As of core revision 2.60a the recommended programming model is to set >> the ClearPendIN bit when issuing a Clear Stall EP command for IN >> endpoints. This is to prevent an issue where some (non-compliant) hosts >>

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-05-31 Thread Guenter Roeck
On Tue, May 31, 2016 at 03:43:56PM +0300, Heikki Krogerus wrote: > On Tue, May 31, 2016 at 03:09:01PM +0300, Heikki Krogerus wrote: > > On Tue, May 31, 2016 at 10:48:29AM +0200, Oliver Neukum wrote: > > > On Tue, 2016-05-31 at 11:31 +0300, Heikki Krogerus wrote: > > > > Hi Oliver, > > > > > > > >

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-05-31 Thread Guenter Roeck
On Tue, May 31, 2016 at 11:31:21AM +0300, Heikki Krogerus wrote: > Hi Oliver, > > On Mon, May 30, 2016 at 03:59:27PM +0200, Oliver Neukum wrote: > > On Mon, 2016-05-30 at 16:19 +0300, Heikki Krogerus wrote: > > > Hi guys, > > > > > > I'm attaching a diff instead of full v3. I'm not yet adding att

Re: Unable to safely detach external HDD on USB 3.0

2016-05-31 Thread Alan Stern
On Tue, 31 May 2016, Mathias Nyman wrote: > On 30.05.2016 19:39, Alan Stern wrote: > > On Sun, 29 May 2016, Marco Chiappero wrote: > > > >> Hello, > >> > >> I'm experiencing a problem I'm not able to troubleshoot. > >> > >> I own a WD Elements Portable USB 3.0 HDD (WDBU6Y0020BBK) containing a > >>

Re: USB g_mass_storage weirdness

2016-05-31 Thread Alan Stern
On Tue, 31 May 2016, Felipe Balbi wrote: > I've sprinkled a few trace_printk() around in g_mass_storage and got > some extra info. So here's a good transfer: ... > And here's the bad case (with the last working WRITE_10): > > > irq/17-dwc3-1336 [000] d... 839.825613: fsg_common_set_inquiry_

Re: Slow writes with dd on Lexar JumpDrive P20 64GB flash drives connected via Intel USB 3.0 host controllers

2016-05-31 Thread Alan Stern
On Tue, 31 May 2016, Michael Schaller wrote: > Is there anything else I can do to debug this issue further? > Are there any quirks I could try? You can try capturing a usbmon trace of a test transfer. That might provide a clue about where the bottleneck lies. Also, post the dmesg log showing w

[PATCH 09/25] usb: musb: Update to use PM runtime autosuspend

2016-05-31 Thread Bin Liu
From: Tony Lindgren Let's make the PM runtime use the standard autosuspend calls. Commit 5de85b9d57ab ("PM / runtime: Re-init runtime PM states at probe error and driver unbind") means we must pair use_autosuspend with dont_use_autosuspend and then use put_sync to properly idle the device. Note

[PATCH 00/25] musb fixes for v4.7-rc2

2016-05-31 Thread Bin Liu
Hi Greg, Here are musb fixes, which are ready to get into v4.7-rc2. Please let me know if any change is needed. These are all musb bug fixes and omap2430 glue PM fixes. Regards, -Bin. Andrew Goodbody (2): usb: musb: Ensure rx reinit occurs for shared_fifo endpoints usb: musb: Stop bulk endp

[PATCH 04/25] usb: musb: host: make musb_tx_dma_set_mode_*() *void*

2016-05-31 Thread Bin Liu
From: Sergei Shtylyov Now that the DMA engine check was moved to musb_tx_dma_porgram(), both musb_tx_dma_set_mode_cppi_tusb() and musb_tx_dma_set_mode_mentor() always return 0, so we can make both these functions *void*. Signed-off-by: Sergei Shtylyov [b-...@ti.com: revise subject prefix] Sign

[PATCH 23/25] usb: musb: host: correct cppi dma channel for isoch transfer

2016-05-31 Thread Bin Liu
Incorrect cppi dma channel is referenced in musb_rx_dma_iso_cppi41(), which causes kernel NULL pointer reference oops later when calling cppi41_dma_channel_program(). Fixes: 069a3fd (usb: musb: Remove ifdefs for musb_host_rx in musb_host.c part1) Cc: # v4.2+ Reported-by: Matwey V. Kornilov Acke

[PATCH 21/25] usb: phy: Check initial state for twl6030

2016-05-31 Thread Bin Liu
From: Tony Lindgren We need to check the state for the PHY with delayed_work as otherwise MUSB will get confused and idles immediately. Signed-off-by: Tony Lindgren Signed-off-by: Bin Liu --- drivers/usb/phy/phy-twl6030-usb.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletio

[PATCH 25/25] usb: musb: Stop bulk endpoint while queue is rotated

2016-05-31 Thread Bin Liu
From: Andrew Goodbody Ensure that the endpoint is stopped by clearing REQPKT before clearing DATAERR_NAKTIMEOUT before rotating the queue on the dedicated bulk endpoint. This addresses an issue where a race could result in the endpoint receiving data before it was reprogrammed resulting in a warn

[PATCH 24/25] usb: musb: Ensure rx reinit occurs for shared_fifo endpoints

2016-05-31 Thread Bin Liu
From: Andrew Goodbody shared_fifo endpoints would only get a previous tx state cleared out, the rx state was only cleared for non shared_fifo endpoints Change this so that the rx state is cleared for all endpoints. This addresses an issue that resulted in rx packets being dropped silently. Signe

Re: [PATCH v6] input: tablet: add Pegasus Notetaker tablet driver

2016-05-31 Thread Martin Kepplinger
Am 2016-05-29 um 08:59 schrieb Martin Kepplinger: > This adds a driver for the Pegasus Notetaker Pen. When connected, > this uses the Pen as an input tablet. > Please wait for v7, before you consider merging this. thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

[PATCH 20/25] usb: musb: Use normal module_init for 2430 glue

2016-05-31 Thread Bin Liu
From: Tony Lindgren There's no longer any need for custom initcall level for musb. Signed-off-by: Tony Lindgren Signed-off-by: Bin Liu --- drivers/usb/musb/omap2430.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/

[PATCH 22/25] usb: musb: only restore devctl when session was set in backup

2016-05-31 Thread Bin Liu
If the session bit was not set in the backup of devctl register, restoring devctl would clear the session bit. Therefor, only restore devctl register when the session bit was set in the backup. This solves the device enumeration failure in otg mode exposed by commit 56f487c (PM / Runtime: Update l

[PATCH 17/25] usb: musb: Return error value from musb_mailbox

2016-05-31 Thread Bin Liu
From: Tony Lindgren At least on n900 we have phy-twl4030-usb only generating cable interrupts, and then have a separate USB PHY. In order for musb to know the real cable status, we need to clear any cached state until musb is ready. Otherwise the cable status interrupts will get just ignored if

[PATCH 18/25] usb: musb: Remove extra PM runtime calls from 2430 glue layer

2016-05-31 Thread Bin Liu
From: Tony Lindgren With PM runtime behaving, these are all now unnecessary. Doing pm_runtime_get(musb->controller) will keep the parent glue layer also active. Signed-off-by: Tony Lindgren Signed-off-by: Bin Liu --- drivers/usb/musb/omap2430.c | 28 1 file change

[PATCH 16/25] usb: musb: Don't set d+ high before enable for 2430 glue layer

2016-05-31 Thread Bin Liu
From: Tony Lindgren At least 2430 glue layer pulls d+ high on start up even if there are no gadgets configured. This is bad at least for anything using a separate battery charger chip as it can confuse the charger detection. Let's fix the issue by removing the bogus glue layer code tinkering wit

[PATCH 19/25] usb: musb: Remove pm_runtime_set_irq_safe

2016-05-31 Thread Bin Liu
From: Tony Lindgren With the pull up being handled with delayed work, we can now finally remove pm_runtime_set_irq_safe that blocks the MUSB glue from idling. Signed-off-by: Tony Lindgren Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.c | 6 -- 1 file changed, 6 deletions(-) diff

[PATCH 13/25] usb: musb: Handle cable status better for 2430 glue layer

2016-05-31 Thread Bin Liu
From: Tony Lindgren We may have drivers loaded but no configured gadgets and MUSB may be in host mode. If gadgets are configured during host mode, PM runtime will get confused. Disable PM runtime from gadget state, and do it based on the cable and last state. Note that we may get multiple cable

[PATCH 12/25] usb: musb: Use delayed for musb_gadget_pullup

2016-05-31 Thread Bin Liu
From: Tony Lindgren We have MUSB setting pm_runtime_irq_safe with the following commits: 30a70b026b4c ("usb: musb: fix obex in g_nokia.ko causing kernel panic") 3e43a0725637 ("usb: musb: core: add pm_runtime_irq_safe()") Let's fix things to use delayed work so we can remove the pm_runtime_irq_s

[PATCH 11/25] usb: musb: Remove conditional PM runtime calls for musb_gadget

2016-05-31 Thread Bin Liu
From: Tony Lindgren The conditional use of PM runtime does not work properly for musb gadget. On cable disconnect we may not get any USB_EVENT_NONE leaving the PM runtime call unpaired. Let's fix the issue by making sure the PM runtime calls are paired within the functions. The glue layer will t

[PATCH 10/25] usb: musb: Split PM runtime between wrapper IP and musb core

2016-05-31 Thread Bin Liu
From: Tony Lindgren Let's not tinker with the PM runtime of musb core from the omap2430 wrapper. This allows us to initialize PM runtime for musb core later on instead of doing it in stages. And omap2430 wrapper has no need to for accessing musb core at this point. Note that this does not remove

[PATCH 08/25] usb: musb: Remove unnecessary shutdown function

2016-05-31 Thread Bin Liu
From: Tony Lindgren We have remove() already calling shutdown(), so let's drop it and move the code to remove(). No code changes, we'll drop the the FIXME in the following patch with more clean-up. Signed-off-by: Tony Lindgren Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.c | 39 +

[PATCH 14/25] usb: musb: Improve PM runtime and phy handling for 2430 glue layer

2016-05-31 Thread Bin Liu
From: Tony Lindgren This simplifies things and allows idling both MUSB and PHY when nothing is configured. Let's just return early from PM runtime if musb is not yet initialized. Let's also warn if PHY is not configured. Signed-off-by: Tony Lindgren Signed-off-by: Bin Liu --- drivers/usb/mus

[PATCH 15/25] usb: musb: Remove try_idle for 2430 glue layer

2016-05-31 Thread Bin Liu
From: Tony Lindgren This is no longer needed with PM runtime at least for 2430 glue. We can now rely only on PM runtime and cable detection. The other glue layers can probably remove try_idle too, but that needs to be tested for each platform before doing it. Signed-off-by: Tony Lindgren Signe

[PATCH 02/25] usb: musb: host: don't start next rx urb if current one failed

2016-05-31 Thread Bin Liu
urb->status is set when endpoint csr RXSTALL, H_ERROR, DATAERROR or INCOMPRX bit is set. Those bits mean a broken pipe, so don't start next urb when any of these bits is set by checking urb->status. To minimize the risk of regression, only do so for RX, until we have a test case to understand the

[PATCH 01/25] usb: musb: host: clear rxcsr error bit if set

2016-05-31 Thread Bin Liu
The MUSB Programming Guide states that the driver should clear RXCSR bit2 when the controller sets the bit. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_host.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index 2f8ad7f..93

[PATCH 03/25] usb: musb: host: move DMA engine check from musb_tx_dma_set_mode_cppi_tusb() to its caller

2016-05-31 Thread Bin Liu
From: Sergei Shtylyov Commit 754fe4a92c07 ("usb: musb: Remove ifdefs for TX DMA for musb_host.c") looks incomplete: the DMA engine checks are done outside the Mentor/UX500 handler but inside the CPPI/TUSB handler. Move the checks out of the CPPI/ TUSB handler into its caller, musb_tx_dma_progra

[PATCH 05/25] usb: musb: sunxi: Add set_mode platform function

2016-05-31 Thread Bin Liu
From: Hans de Goede Move the mode handling to the platform_set_mode callback. Signed-off-by: Hans de Goede [b-...@ti.com: revise subject prefix] Signed-off-by: Bin Liu --- drivers/usb/musb/sunxi.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --g

[PATCH 06/25] usb: musb: sunxi: Set state to A_WAIT_VRISE when enabling Vbus

2016-05-31 Thread Bin Liu
From: Hans de Goede When the board is powering attached usb devices via the otg port sometimes / on some devices it takes slightly too long for the Vbus detection code in phy-sun4i-usb.c to signal that Vbus is high after enabling Vbus and the musb hardware signals a MUSB_INTR_VBUSERROR interrupt.

[PATCH 07/25] usb: musb: Fix idling after host mode by increasing autosuspend delay

2016-05-31 Thread Bin Liu
From: Tony Lindgren Looks like at least 2430 glue won't idle reliably with the 200 ms autosuspend delay. This causes deeper idle states being blocked for the whole SoC when disconnecting OTG A cable. Increasing the delay to 500 ms seems to idle both MUSB and the PHY reliably. This is probably be

Re: USB g_mass_storage weirdness

2016-05-31 Thread Felipe Balbi
Hi, Felipe Balbi writes: > [ Unknown signature status ] > > Hi again, > > Felipe Balbi writes: >>> irq/17-dwc3-1336 [000] d... 839.828020: fsg_common_set_inquiry_string: >>> ep1in: 13/13 --> 0 >> >> Our CSW completes fine >> >>> irq/17-dwc3-1336 [000] d... 839.828022: fsg_common_set_in

Re: USB g_mass_storage weirdness

2016-05-31 Thread Felipe Balbi
Hi again, Felipe Balbi writes: >> irq/17-dwc3-1336 [000] d... 839.828020: fsg_common_set_inquiry_string: >> ep1in: 13/13 --> 0 > > Our CSW completes fine > >> irq/17-dwc3-1336 [000] d... 839.828022: fsg_common_set_inquiry_string: >> ep1out: 31/1024 --> 0 > > 2 us later, we receive anot

Re: USB g_mass_storage weirdness

2016-05-31 Thread Felipe Balbi
Hi, Felipe Balbi writes: >> irq/17-dwc3-1253 [000] d..1 315.944886: usb_gadget_vbus_draw: speed 5/5 >> state 7 0mA [sg:out_aligned:self-powered:activated:connected] --> -95 >> file-storage-1252 [003] ...1 315.945556: usb_ep_fifo_flush: ep1in: mps >> 1024/1024 streams 15 mult 0 burst 16

[PATCH] usb: phy-omap-otg: Space required after that ','.

2016-05-31 Thread Sandhya Bankar
Space required after that ','. Signed-off-by: Sandhya Bankar --- drivers/usb/phy/phy-omap-otg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-omap-otg.c b/drivers/usb/phy/phy-omap-otg.c index c4bf2de..6f6d2a7 100644 --- a/drivers/usb/phy/phy-omap-otg.c +

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-05-31 Thread Heikki Krogerus
On Tue, May 31, 2016 at 03:09:01PM +0300, Heikki Krogerus wrote: > On Tue, May 31, 2016 at 10:48:29AM +0200, Oliver Neukum wrote: > > On Tue, 2016-05-31 at 11:31 +0300, Heikki Krogerus wrote: > > > Hi Oliver, > > > > > > On Mon, May 30, 2016 at 03:59:27PM +0200, Oliver Neukum wrote: > > > > On Mon

Re: Unable to safely detach external HDD on USB 3.0

2016-05-31 Thread Mathias Nyman
On 30.05.2016 19:39, Alan Stern wrote: On Sun, 29 May 2016, Marco Chiappero wrote: Hello, I'm experiencing a problem I'm not able to troubleshoot. I own a WD Elements Portable USB 3.0 HDD (WDBU6Y0020BBK) containing a drive model WD20NMVW-11AV3S3. When connected to a USB 3.0 port the drive wor

[PATCH] usb: cdc-acm: Space prohibited before close parenthesis ')'.

2016-05-31 Thread Sandhya Bankar
Space prohibited before close parenthesis ')'. Signed-off-by: Sandhya Bankar --- drivers/usb/class/cdc-acm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 94a14f5..def5a54 100644 --- a/drivers/usb/class/cdc-acm

[PATCHv2 4/4] usb: gadget: mv_u3d: fix unused-but-set-variable warnings

2016-05-31 Thread Michal Nazarewicz
This patch fixes the following (W=1) warnings: drivers/usb/gadget/udc/mv_u3d_core.c: In function ‘mv_u3d_process_ep_req’: drivers/usb/gadget/udc/mv_u3d_core.c:124:6: warning: variable ‘trb_complete’ set but not used [-Wunused-but-set-variable] int trb_complete, actual, remaining_length = 0;

[PATCHv2 3/4] usb: gadget: r8a66597: fix unused-but-set-variable warnings

2016-05-31 Thread Michal Nazarewicz
This patch fixes the following (W=1) warnings: drivers/usb/gadget/udc/r8a66597-udc.c: In function ‘r8a66597_irq’: drivers/usb/gadget/udc/r8a66597-udc.c:1468:15: warning: variable ‘nrdyenb’ set but not used [-Wunused-but-set-variable] u16 brdyenb, nrdyenb, bempenb; ^ drivers/usb/g

[PATCHv2 2/4] usb: gadget: m66592: fix unused-but-set-variable warnings

2016-05-31 Thread Michal Nazarewicz
This patch fixes the following (W=1) warnings: drivers/usb/gadget/udc/m66592-udc.c: In function ‘m66592_irq’: drivers/usb/gadget/udc/m66592-udc.c:1203:15: warning: variable ‘nrdyenb’ set but not used [-Wunused-but-set-variable] u16 brdyenb, nrdyenb, bempenb; ^ drivers/usb/gadget/

Re: [PATCH 0/4] usb: gadget: fix most of W=1 warinngs

2016-05-31 Thread Michal Nazarewicz
On Tue, May 31 2016, Felipe Balbi wrote: > This series doesn't seem to apply to v4.7-rc1. Care to rebase on > testing/fixes? Sure. Only the first patch needs fixing (by skipping failed hunks). Michal Nazarewicz (4): usb: gadget: fix unused-but-set-variale warnings usb: gadget: m66592: fix un

[PATCHv2 1/4] usb: gadget: fix unused-but-set-variale warnings

2016-05-31 Thread Michal Nazarewicz
Those are enabled with W=1 make option. The patch leaves of some type-limits warnings which are caused by generic macros used in a way where they produce always-false conditions. Signed-off-by: Michal Nazarewicz --- drivers/usb/gadget/function/f_fs.c | 3 +-- drivers/usb/gadget/function/u_

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-05-31 Thread Heikki Krogerus
On Tue, May 31, 2016 at 10:48:29AM +0200, Oliver Neukum wrote: > On Tue, 2016-05-31 at 11:31 +0300, Heikki Krogerus wrote: > > Hi Oliver, > > > > On Mon, May 30, 2016 at 03:59:27PM +0200, Oliver Neukum wrote: > > > On Mon, 2016-05-30 at 16:19 +0300, Heikki Krogerus wrote: > > > > Hi guys, > > > >

USB g_mass_storage weirdness

2016-05-31 Thread Felipe Balbi
Hi guys, I'm getting a weird behavior with g_mass_storage which I'm yet to verify if it's a g_mass_storage bug on XHCI bug. So far it points to g_mass_storage. Below you can see a commented set of trace data (see the 2-patch series I just sent): [...] > file-storage-1252 [003] ...1 254.79366

[PATCH 2/2] usb: gadget: add tracepoints to the gadget API

2016-05-31 Thread Felipe Balbi
This new set of tracepoints will help all gadget drivers and UDC drivers when problem appears. Note that, in order to be able to add tracepoints to udc-core.c we had to rename that to core.c and statically link it with trace.c to form udc-core.o. This is to make sure that module name stays the same

[PATCH 1/2] usb: gadget: move gadget API functions to udc-core

2016-05-31 Thread Felipe Balbi
instead of defining all functions as static inlines, let's move them to udc-core and export them with EXPORT_SYMBOL_GPL, that way we can make sure that only GPL drivers will use them. As a side effect, it'll be nicer to add tracepoints to the gadget API. Signed-off-by: Felipe Balbi --- drivers/

[PATCH 1/2] usb: gadget: move gadget API functions to udc-core

2016-05-31 Thread Felipe Balbi
instead of defining all functions as static inlines, let's move them to udc-core and export them with EXPORT_SYMBOL_GPL, that way we can make sure that only GPL drivers will use them. As a side effect, it'll be nicer to add tracepoints to the gadget API. Signed-off-by: Felipe Balbi --- drivers/

Re: PROBLEM: Kernel Bug on USB unplugging (Elo TouchSystems CarrollTouch 4500U)

2016-05-31 Thread Pierre Sauter
Works like a charm, problem fixed! Thanks a lot. I hope you submit the patch. Best Regards -- Pierre Sauter Studentenwerk München IT-Abteilung Leopoldstraße 15 80802 München Tel: +49 89 38196-157 --- Am Dienstag, 31. Mai 2016, 10:13:10 schrieben Sie: > On Mon, 2016-05-30 at 18:47 +0200, Pie

Re: [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting

2016-05-31 Thread Krzysztof Kozlowski
On 05/31/2016 02:58 AM, Peter Chen wrote: > On Sat, May 28, 2016 at 11:36:13AM +0800, Peter Chen wrote: >> All, how we move on for this? >> >> 1. Using a generic driver to manage both mmc and USB (and further >> subsystem), USB and further subsystem do not use pwrseq node in dts. >> 2. USB creates

Re: [PATCH v2,1/5] dt-bindings: mt8173-xhci: support host side of dual-role mode

2016-05-31 Thread Sergei Shtylyov
Hello. On 5/31/2016 8:52 AM, Chunfeng Yun wrote: Some resources, such as IPPC register etc, shared with device driver are moved into common glue layer when xHCI driver is the host side of dual-role mode and they should be changed as optional properties if they are required ones before. For clar

Re: [PATCH 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY

2016-05-31 Thread Heiko Stübner
Hi Frank, Am Dienstag, 31. Mai 2016, 14:40:10 schrieb Frank Wang: > Signed-off-by: Frank Wang > --- > .../bindings/phy/phy-rockchip-inno-usb2.txt| 48 > 1 file changed, 48 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/phy/phy-rockchip-inno-

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-05-31 Thread Oliver Neukum
On Tue, 2016-05-31 at 11:31 +0300, Heikki Krogerus wrote: > Hi Oliver, > > On Mon, May 30, 2016 at 03:59:27PM +0200, Oliver Neukum wrote: > > On Mon, 2016-05-30 at 16:19 +0300, Heikki Krogerus wrote: > > > Hi guys, > > > > > > I'm attaching a diff instead of full v3. I'm not yet adding attributes

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

2016-05-31 Thread Heikki Krogerus
Hi Oliver, On Mon, May 30, 2016 at 03:59:27PM +0200, Oliver Neukum wrote: > On Mon, 2016-05-30 at 16:19 +0300, Heikki Krogerus wrote: > > Hi guys, > > > > I'm attaching a diff instead of full v3. I'm not yet adding attributes > > for the reset and cable_reset. I still don't understand what is the

Re: PROBLEM: Kernel Bug on USB unplugging (Elo TouchSystems CarrollTouch 4500U)

2016-05-31 Thread Oliver Neukum
On Mon, 2016-05-30 at 18:47 +0200, Pierre Sauter wrote: > On unplugging this USB Touchscreen, everytime I get either: > > [ 161.596055] BUG: unable to handle kernel NULL pointer dereference at > 0015 > [ 161.596093] IP: [] get_next_timer_interrupt+0x80/0x270 > or > [ 155.892061] BUG: unabl

Re: [PATCH 00/13] usb: dwc2: Fix up gadget isochronous support

2016-05-31 Thread Felipe Balbi
Hi, John Youn writes: > The following patch series fixes up isochronous support for the dwc2 > gadget. The existing isochronous support lacked a few features. Most > notably it did not properly sync up with the first packet and it > didn't handle the Incomplete ISO IN/OUT interrupts. > > These p

[PATCH resend] USB: uas: Fix slave queue_depth not being set

2016-05-31 Thread Hans de Goede
Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") removed the scsi_change_queue_depth() call from uas_slave_configure() assuming that the slave would inherit the host's queue_depth, which that commit sets to the same value. This is incorrect, without the scsi_change_queue_depth

[PATCH resend 0/1] USB: uas: Fix slave queue_depth not being set

2016-05-31 Thread Hans de Goede
Hi Greg, There was some discussion about this patch during its initial posting, but the concensus seems to be that this patch, which is in essence a partial revert of the patch causing the problem, is the best way to fix this. So I'm resending this to make sure it does not fall through the cracks

Re: [PATCH 0/4] usb: gadget: fix most of W=1 warinngs

2016-05-31 Thread Felipe Balbi
Hi, Michal Nazarewicz writes: > Fixes all of the unused-but-set-variable warnings enabled when > building with W=1. As described in the first patch, some warnings are > left off. See said patch for more description. > > Michal Nazarewicz (4): > usb: gadget: fix unused-but-set-variale warning

Re: [PATCH v2] usb: dwc3: Set the ClearPendIN bit on Clear Stall EP command

2016-05-31 Thread Felipe Balbi
Hi John, John Youn writes: > As of core revision 2.60a the recommended programming model is to set > the ClearPendIN bit when issuing a Clear Stall EP command for IN > endpoints. This is to prevent an issue where some (non-compliant) hosts > may not send ACK TPs for pending IN transfers due to a