drivers/net/usb/cx82310_eth.c:175:2-3: Unneeded semicolon
Removes unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Ondrej Zary
Signed-off-by: Fengguang Wu
---
cx82310_eth.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/usb/cx82310_
Felipe,
> -Original Message-
> From: Balbi, Felipe
> Sent: Monday, March 23, 2015 7:37 PM
> To: Liu, Bin
> Cc: linux-usb@vger.kernel.org; Balbi, Felipe
> Subject: Re: [PATCH] usb: musb: do not backup/restore registers in runtime PM
> callbacks
>
> On Mon, Mar 23, 2015 at 04:52:54PM -0500,
This patch uses the existing CALAO Systems ftdi_8u2232c_probe in order
to avoid attaching a TTY to the JTAG port as this board is based on the
CALAO Systems reference design and needs the same fix up.
Signed-off-by: Doug Goldstein
CC: stable
---
drivers/usb/serial/ftdi_sio.c | 3 ++-
1 file cha
On Mon, Mar 23, 2015 at 04:52:54PM -0500, Bin Liu wrote:
> The MUSB controller does not lost power during runtime suspend/resume,
> so unnecessary to backup/restore its registers.
>
> Signed-off-by: Bin Liu
are you sure this is true for *all* users of musb ?
--
balbi
signature.asc
Descriptio
> Do you really see some udc drivers call it after composite_unbind is
> called? If it is, you may add dump_stack() to track that error.
>
> Besides this, function suspended_show is needed to add cdev NULL pointer
> checking.
We see this happening occasionally in *not yet* upstreamed UDC
code of
The MUSB controller does not lost power during runtime suspend/resume,
so unnecessary to backup/restore its registers.
Signed-off-by: Bin Liu
---
drivers/usb/musb/musb_core.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/mu
On Mon, 23 Mar 2015, Marc Joliet wrote:
> OK, so obviously the drive is doing something wrong. I'm just confused about
> why one way works and not the other:
>
> - Boot up the computer with the drive attached: failure.
>
> - Boot up the computer without the drive attached, load the required ker
> At the moment I only have access to laptops, not a desktop,
> so the EHCI testing was on a different machine, with the Ubuntu
> 3.13 kernel. If you'd like me to test on a more recent kernel,
> please let me know.
Ok. That's a useful data point.
>> It's also worth mentioning that the process y
On Mon, Mar 23, 2015 at 8:22 AM, Mian Yousaf Kaukab
wrote:
> From: Gregory Herrero
>
> Align buffer must be allocated using kmalloc since irqs are disabled.
> Coherency is handled through dma_map_single which can be used with irqs
> disabled.
>
> Signed-off-by: Gregory Herrero
> ---
> drivers/u
Hi Devin,
On Mon, Mar 23, 2015 at 8:16 PM, Devin Heitmueller
wrote:
> Hi Alistair,
>
>> There are some small differences in packet ordering, however the first
>> major difference is an isochronous in packet where the Live2 returns
>> "URB status: No such file or directory (-ENOENT) (-2)".
>>
>> D
Am Mon, 23 Mar 2015 12:07:44 -0700
schrieb Matthew Dharm :
> Marc --
>
> In re: why behavior is different at boot-up vs hotplug -- have you
> considered the possibility that your BIOS sends a READ_CAPACITY
> command to the drive during POST? If you BIOS is enabled for
> boot-from-USB (and most a
Hi Alistair,
> There are some small differences in packet ordering, however the first
> major difference is an isochronous in packet where the Live2 returns
> "URB status: No such file or directory (-ENOENT) (-2)".
>
> Devin, I'm try to learn a bit about USB and the Live2 protocol, however I'm
> n
On Wed, Mar 18, 2015 at 08:52:29 +0100, Oliver Neukum wrote:
> On Tue, 2015-03-17 at 20:49 +0100, Bjørn Mork wrote:
> > Sami Farin writes:
> > > On Mon, Feb 23, 2015 at 11:59:14 +0100, Bjørn Mork wrote:
> > >> So my conclusion is that there is some higher level USB communication
> > >> problem her
Marc --
In re: why behavior is different at boot-up vs hotplug -- have you
considered the possibility that your BIOS sends a READ_CAPACITY
command to the drive during POST? If you BIOS is enabled for
boot-from-USB (and most are), then it likely probes the device to
compile a list of boot targets,
Am Mon, 23 Mar 2015 13:29:02 -0400 (EDT)
schrieb Alan Stern :
> On Mon, 23 Mar 2015, Marc Joliet wrote:
>
> > Am Mon, 23 Mar 2015 11:34:59 +0100
> > schrieb Marc Joliet :
> >
> > [...]
> > > > - Same as above, but this time I load the uas module before plugging in
> > > > the
> > > > drive (I
Hi Mathias & Devin,
I've changed the subject to avoid any confusion with the patch series
that Mathias just posted for inclusion in 4.0-rc.
On Tue, Mar 17, 2015 at 4:21 PM, Alistair Grant wrote:
>>> It looks like I may have signed-off a little too soon. While the patch
>>> is
>>> w
On Mon, 23 Mar 2015, Marc Joliet wrote:
> Am Mon, 23 Mar 2015 11:34:59 +0100
> schrieb Marc Joliet :
>
> [...]
> > > - Same as above, but this time I load the uas module before plugging in
> > > the
> > > drive (I could have used usb-storage, but didn't out of mental habit).
> > > This
> > >
On Mon, 23 Mar 2015, Nicolas Ferre wrote:
> Le 17/03/2015 20:02, Alan Stern a �crit :
> > On Tue, 17 Mar 2015, Boris Brezillon wrote:
> >
> >> Now that the system clock driver is forwarding set_rate request to the
> >> parent clock, we can safely call clk_set_rate on the system clk and get
> >> r
Hi Hans,
On Fri, Mar 20, 2015 at 08:11:09PM +0100, Hans de Goede wrote:
> Hi All,
>
> Here is v2 of my patch-set to add support for the musb variant found on
> Allwinner sunxi SoCs.
>
> Changes since the original posting:
> -Removed the sunxi specific phy functions, instead the id / vbus gpio po
Hi Greg
Any chance you could squeeze two more small patches into 4.0?
Both are small fixes, and solve cases where xhci just gets stuck.
One in case we got multiple isoc transfers filling the event ring,
and the other makes sure we handle config error change event,
which would block all new events
From: Lu Baolu
Linux xHCI driver doesn't report and handle port cofig error change.
If Port Configure Error for root hub port occurs, CEC bit in PORTSC
would be set by xHC and remains 1. This happends when the root port
fails to configure its link partner, e.g. the port fails to exchange
port cap
From: Lu Baolu
When a device with an isochronous endpoint is plugged into the Intel
xHCI host controller, and the driver submits multiple frames per URB,
the xHCI driver will set the Block Event Interrupt (BEI) flag on all
but the last TD for the URB. This causes the host controller to place
an e
Am Mon, 23 Mar 2015 11:34:59 +0100
schrieb Marc Joliet :
[...]
> > - Same as above, but this time I load the uas module before plugging in the
> > drive (I could have used usb-storage, but didn't out of mental habit).
> > This
> > time the sector size is detected correctly. There are almost
Am Mon, 23 Mar 2015 11:39:30 -0400 (EDT)
schrieb Alan Stern :
> On Mon, 23 Mar 2015, Marc Joliet wrote:
>
> > OK, I got it down to 763 lines total because of various kernel messages and
> > I
> > was worried that they might provide important context, so it's not quite
> > down to
> > 200 lines,
Le 17/03/2015 20:02, Alan Stern a écrit :
> On Tue, 17 Mar 2015, Boris Brezillon wrote:
>
>> Now that the system clock driver is forwarding set_rate request to the
>> parent clock, we can safely call clk_set_rate on the system clk and get
>> rid of the uclk field.
>>
>> Signed-off-by: Boris Brezil
On 03/23/15 01:34, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20150320:
>
on x86_64:
drivers/built-in.o: In function `printer_func_unbind':
f_printer.c:(.text+0x56e25f): undefined reference to `usb_free_all_descriptors'
drivers/built-in.o: In function `printer_attr_release':
f_printer
On Mon, 23 Mar 2015, Marc Joliet wrote:
> OK, I got it down to 763 lines total because of various kernel messages and I
> was worried that they might provide important context, so it's not quite down
> to
> 200 lines, but I hope that's close enough. The logs for the reconnect start
> after line 3
Dump all registers to take a complete snapshot of dwc2 state.
Code is inspired by dwc3/debugfs.c
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/core.h| 1 +
drivers/usb/dwc2/debugfs.c | 357 +
2 files changed, 358 insertions(+)
diff --gi
As dwc2 pci module is now exporting dwc2 platform device, include
platform.o in dwc2-y and remove USB_DWC2_PLATFORM configuration
option. Driver will be built as two modules, dwc2.ko and dwc2_pci.ko.
dwc2.ko is the new platform driver.
Remove all EXPORT_SYMBOL_GPL as they are not needed any more.
From: Gregory Herrero
Once hub is runtime suspended, dwc2 must resume it
on port connect event.
Else, roothub will stay in suspended state and will
not resume transfers.
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/hcd_intr.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/driver
From: Gregory Herrero
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/hcd.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 919658e..bc04b3f8 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -2
From: Gregory Herrero
During urb_enqueue, if the urb can't be queued to the endpoint,
the urb is freed without any spinlock protection.
This leads to memory corruption when concurrent urb_dequeue try to free
same urb->hcpriv.
Thus, ensure the whole urb_enqueue in spinlocked.
Signed-off-by: Grego
From: Gregory Herrero
dwc2_hc_nak_intr could be called with a NULL qtd.
Ensure qtd exists before dereferencing it to avoid kernel panic.
This happens when using usb to ethernet adapter.
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/hcd_intr.c | 10 ++
1 file changed, 10 insertion
From: Gregory Herrero
ResetDet interrupt is used to detect a reset of the bus
while the controller is suspended.
This may happens for example when using Command Verifier.
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/gadget.c | 19 ---
1 file changed, 16 insertions(+), 3
Force argument is not used anymore. Clean up leftovers from
https://lkml.org/lkml/2014/12/9/283
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/gadget.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index eb9
From: Gregory Herrero
Nothing to be done in pm suspend/resume when controller is in L2.
Don't disconnect or reset. State is already saved when putting
controller in hibernation and will be restored on USB bus resume.
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/gadget.c | 6 ++
1 fi
So the parameters can be used in both host and gadget modes.
Also consolidate param functions in the core.h
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/core.c | 19 +++
drivers/usb/dwc2/core.h | 13 ++---
drivers/usb/dwc2/hcd.c | 36 +--
From: Gregory Herrero
During suspend, there could a race condition between ep_queue and
suspend interrupt if lx_state is updated after releasing spinlock in
call_gadget(hsotg, suspend).
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/core_intr.c | 11 ---
1 file changed, 8 insertio
From: Gregory Herrero
This is required due to an Intel specific hardware issue. Where id-
pin setup causes glitches on the interrupt line when CONIDSTSCHG
interrupt is enabled.
Specify external_id_pin_ctl when an external driver (for example phy)
can handle id change, so that CONIDSTSCHG interru
From: Jingwu Lin
Add support for SetPortFeature(PORT_TEST) for root port.
Signed-off-by: Jingwu Lin
---
drivers/usb/dwc2/hcd.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index dec97cc..0347d79 100644
--- a/drivers/usb/dwc2/hcd.c
From: Gregory Herrero
If usb controller is in partial power down, any write to registers may
cause unpredictable behavior.
Thus, prevent any new request submission once controller is in partial
power down.
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/gadget.c | 7 +++
1 file changed
From: Gregory Herrero
When suspending usb bus, phy driver may disable controller power.
In this case, registers need to be saved on suspend and restored
on resume.
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/core.c | 377
drivers/usb/dwc
From: Gregory Herrero
Allow controller to enter in hibernation during usb bus suspend and
inform both phy and gadget about the suspended state.
While in hibernation, the controller can't detect the resume condition.
An external mechanism must call usb_phy_set_suspend on resume.
Exit hibernation w
From: Gregory Herrero
Align buffer must be allocated using kmalloc since irqs are disabled.
Coherency is handled through dma_map_single which can be used with irqs
disabled.
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/hcd.c | 16 ++---
drivers/usb/dwc2/hcd_intr.c | 53 ++
From: Gregory Herrero
dwc2 may not be able to exit from hibernation if the hardware
does not provide a way to detect resume signalling in this state.
Thus, add the possibility to disable hibernation feature.
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/core.c | 24 +
If phy driver is present register hcd handle to it.
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/hcd.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 1cca5e0..919658e 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/
From: Gregory Herrero
During vbus session, usb controller needs to exit hibernation if it was
previously in suspend state.
Since controller will be resetted and configured, there is no need
to restore registers.
Moreover, set lx_state to L0 on B session. vbus_session callback may
not be used by
Prepare to add more debug code. Moreover, don't save dentry * for
each file in struct dwc2_hsotg as clean up is done with
debugfs_remove_recursive(). s3c_hsotg_delete_debug() is removed
altogether for the same reason.
Signed-off-by: Mian Yousaf Kaukab
---
drivers/usb/dwc2/Makefile | 4 +
dri
From: Gregory Herrero
Signed-off-by: Gregory Herrero
---
drivers/usb/dwc2/gadget.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 56a08ac..eb906bd 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -3525,6
Hi,
This patchset consists of some bug fixes and feature enhancements for
the dwc2 driver. All the patches are verified on dwc2 v3.0a with
dedicated fifos. Main focus of testing was with dma enabled. Although
basic testing without dma was also done.
This is based on testing/next branch in Felipe's
> -Original Message-
> From: jwer...@google.com [mailto:jwer...@google.com] On Behalf Of Julius
> Werner
> Sent: Friday, March 20, 2015 7:23 PM
> To: Kaukab, Yousaf
> Cc: Julius Werner; linux-usb@vger.kernel.org; Felipe Balbi;
> john.y...@synopsys.com; Herrero, Gregory; r.bald...@samsung.co
Am Mon, 23 Mar 2015 09:50:32 -0400 (EDT)
schrieb Alan Stern :
> On Mon, 23 Mar 2015, Marc Joliet wrote:
>
> > > > > Please capture a couple of usbmon traces showing what happens during
> > > > > a
> > > > > connect when the wrong sector size is detected and a connect when the
> > > > > right s
On Mon, 23 Mar 2015, Peter Chen wrote:
> For going on debugging this problem, we need
I will have the hardware only for one more day, so I may not be able to
get all the information you want.
> - Your bus analyzer file, I think there should be no enough IN/OUT
> tokens within one frame, does the
On Mon, 23 Mar 2015, Marc Joliet wrote:
> > - If I leave the drive unplugged during boot and plug it in without manually
> > loading any modules, nothing happens. That is, the kernel does not log
> > anything about the device being attached, and neither the uas nor the
> > usb-storage modul
On Mon, 23 Mar 2015, Marc Joliet wrote:
> > > > Please capture a couple of usbmon traces showing what happens during a
> > > > connect when the wrong sector size is detected and a connect when the
> > > > right sector size is detected. You can post the traces here (if there
> > > > is a lot of
One more case of error codes not correctly being
correctly returned to user space.
Signed-off-by: Olive Neukum 0
---
drivers/usb/class/cdc-wdm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c
index dc13072..a7b8383 100
Signed-off-by: Peter Chen
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 43391d6..f530e86 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2507,7 +2507,7 @@ F:Documentation/zh_CN/
CHIPIDEA USB HIGH SPEED DUAL ROLE
> >+
> >+/**
> >+ * ulpi_register_driver - unregister a driver with the ULPI bus
> Hi Heikki,
>
> "ulpi_register_driver" should be changed to "ulpi_unregister_driver".
OK,
Thanks,
--
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majo
Am Mon, 23 Mar 2015 11:34:59 +0100
schrieb Marc Joliet :
[...]
> Am Mon, 23 Mar 2015 09:45:07 +0100
> schrieb Marc Joliet :
>
> > Am Sun, 22 Mar 2015 15:55:21 -0400 (EDT)
> > schrieb Alan Stern :
> >
> > [...]
> > > It does not sound like a driver problem.
> > >
> > > Please capture a couple of
Ugh, I'm stupid. I sent the last two emails to linux-usb-owner by mistake
(that's what I get for blindly copy-n-pasting from Alan's email's headers). So
here's my last mail again:
Start weitergeleitete Nachricht:
Datum: Mon, 23 Mar 2015 11:13:25 +0100
Von: Marc Joliet
An: linux-usb-ow...@vger.
> -Original Message-
> From: John Youn [mailto:john.y...@synopsys.com]
> Sent: Saturday, March 21, 2015 1:46 AM
> To: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com;
> john.y...@synopsys.com
> Cc: Herrero, Gregory; r.bald...@samsung.com;
> dingu...@opensource.altera.com; zhangfei..
By pass pullup DP in OTG fsm mode when do gadget connect, to let it handled
by OTG state machine.
Signed-off-by: Li Jun
This patch can fix the problem you found with my HNP polling patchset after
below 3 patches introduced:
467a78c usb: chipidea: udc: apply new usb_udc_vbus_handler interface
628
On Fri, Mar 20, 2015 at 11:07:17AM +0800, Peter Chen wrote:
> On Thu, Mar 19, 2015 at 11:11:17AM +0800, Li Jun wrote:
> > HNP polling is a mechanism which allows the OTG device currently acting as
> > host
> > to determine when the other attached OTG device wishes to take the host
> > role.
> > W
On 03/18/2015 08:40 PM, Heikki Krogerus wrote:
+
+/**
+ * ulpi_register_driver - unregister a driver with the ULPI bus
Hi Heikki,
"ulpi_register_driver" should be changed to "ulpi_unregister_driver".
Thanks,
Baolu
+ * @drv: driver to unregister
+ *
+ * Unregisters a driver with the ULPI bus
64 matches
Mail list logo
