Re: [PATCH v2 2/3] usb: udc: add usb_udc_vbus_handler

2015-03-10 Thread Peter Chen
On Tue, Mar 10, 2015 at 04:26:58PM -0500, Felipe Balbi wrote: > hi, > > On Fri, Mar 06, 2015 at 10:36:03AM +0800, Peter Chen wrote: > > @@ -145,6 +148,34 @@ EXPORT_SYMBOL_GPL(usb_gadget_set_state); > > > > /* > > - */ > >

[PATCH v2 1/1] usb: common: otg-fsm: only signal connect after switching to peripheral

2015-03-10 Thread Peter Chen
We should signal connect (pull up dp) after we have already at peripheral mode, otherwise, the dp may be toggled due to we reset controller or do disconnect during the initialization for peripheral, then, the host may be confused during the enumeration, eg, it finds the reset can't succeed, but the

Re: [PATCH 1/1] usb: common: otg-fsm: only signal connect after switching to peripheral

2015-03-10 Thread Peter Chen
On Tue, Mar 10, 2015 at 04:18:47PM -0500, Felipe Balbi wrote: > On Sun, Feb 15, 2015 at 03:39:48PM +0800, Peter Chen wrote: > > We should signal connect (pull up dp) after we have already > > at peripheral mode, otherwise, the dp may be toggled due to > > we reset controller or do disconnect during

[Samsung NP530U3C-A02CL] usb 1-2: device descriptor read/64, error

2015-03-10 Thread Cristian
Hello Developers of kernel USB, My report: https://bugzilla.kernel.org/show_bug.cgi?id=94691 "Mount Samsung Galaxy Mini S4 + Cyagenmod 4.4.2" "dmesg: [ 92.854737] usb 1-2: device descriptor read/64, error -71 [ 93.126517] usb 1-2: device descriptor read/64, error -71 [ 93.342337] usb 1-2: new lo

[PATCH] usb: phy: Find the right match in devm_usb_phy_match

2015-03-10 Thread Axel Lin
The res parameter passed to devm_usb_phy_match() is the location where the pointer to the usb_phy is stored, hence it needs to be dereferenced before comparing to the match data in order to find the correct match. Signed-off-by: Axel Lin --- drivers/usb/phy/phy.c | 4 +++- 1 file changed, 3 inse

Re: [PATCH 5/7] usb: chipidea: otg_fsm: add HNP polling support

2015-03-10 Thread Li Jun
On Tue, Mar 10, 2015 at 03:46:31PM -0500, Felipe Balbi wrote: > On Mon, Mar 09, 2015 at 10:09:21AM +0800, Li Jun wrote: > > From: Li Jun > > > > Add a dedicataed normal timer for HNP polling since it's cyclical, while > > in peripheral mode, change a/b_bus_req to be 1 will make it response > > to

Re: [PATCH 5/7] usb: chipidea: otg_fsm: add HNP polling support

2015-03-10 Thread Li Jun
On Mon, Mar 09, 2015 at 03:52:35PM +0800, Peter Chen wrote: > On Mon, Mar 09, 2015 at 10:09:21AM +0800, Li Jun wrote: > > From: Li Jun > > > > Add a dedicataed normal timer for HNP polling since it's cyclical, while > > in peripheral mode, change a/b_bus_req to be 1 will make it response > > to h

[PATCH] usb: dwc2: pci: Add device mode to the dwc2-pci driver

2015-03-10 Thread John Youn
The pci driver now registers a platform driver, like in dwc3, and lets its probe function do all the initialization. This allows it to account for changes to the platform driver that were not added to the pci driver. Also future changes to the probe function don't have to be duplicated. This also h

[PATCH v2 1/1] usb: gadget: lpc32xxx_udc: Fix NULL dereference

2015-03-10 Thread Peter Chen
udc is then checked for NULL, if NULL, it is then dereferenced as udc->dev, it is found using Coccinelle. We simplify the code to fix this problem, and we delete some conditions at if {} which will never be met. Reported-by: Tapasweni Pathak Reported-by : Julia Lawall Signed-off-by: Peter Chen

Re: [PATCHv3 5/5] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-03-10 Thread Felipe Balbi
Hi, On Wed, Mar 11, 2015 at 02:21:38AM +0200, Ruslan Bilovol wrote: > >> @@ -469,6 +488,16 @@ int usb_gadget_unregister_driver(struct > >> usb_gadget_driver *driver) > >> break; > >> } > >> > >> + if (ret) { > >> + struct usb_gadget_driver *tmp;

[PATCH] phy: omap-usb2: Fix missing clk_prepare call when using old dt name

2015-03-10 Thread Axel Lin
Current code does not call clk_prepare(phy->optclk) when using the old usb_otg_ss_refclk960m name. Fix it. Signed-off-by: Axel Lin --- drivers/phy/phy-omap-usb2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c in

Re: [PATCHv3 5/5] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-03-10 Thread Alan Stern
On Wed, 11 Mar 2015, Ruslan Bilovol wrote: > Hi Alan, Hello. > > If you add the list_init and list_del_init above, this loop won't be > > needed. You can just call list_del. > > I disagree with this. This function is externally visible and we can't > guarantee that some buggy code will not cal

Re: Control message failures kill entire XHCI stack

2015-03-10 Thread Lu, Baolu
On 03/10/2015 11:10 PM, Devin Heitmueller wrote: Hello Baolu, I'm doing most of my testing on a 2014 Retina Macbook Pro. lsusb output below. I've also seen the issue on an Intel NUC D34010WYKH, which I don't have in front of me or I would provide the lsusb output for that as well. Devin, I

Re: [PATCHv3 1/5] usb: gadget: bind UDC by name passed via usb_gadget_driver structure

2015-03-10 Thread Ruslan Bilovol
Hi Sergei, On Wed, Feb 18, 2015 at 2:05 PM, Sergei Shtylyov wrote: > Hello. > > On 2/18/2015 12:17 AM, Ruslan Bilovol wrote: > >> Introduce new 'udc_name' member to usb_gadget_driver structure. >> The 'udc_name' is a name of UDC that usb_gadget_driver should >> be bound to. If udc_name is NULL, i

Re: [PATCHv3 5/5] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-03-10 Thread Ruslan Bilovol
Hi Alan, On Tue, Feb 17, 2015 at 11:51 PM, Alan Stern wrote: > On Tue, 17 Feb 2015, Ruslan Bilovol wrote: > >> Change behavior during registration of gadgets and >> gadget drivers in udc-core. Instead of previous >> approach when for successful probe of usb gadget driver >> at least one usb gadge

Re: [PATCH 1/2] usb: dwc2: Use platform endianness when accessing registers

2015-03-10 Thread Vincent Pelletier
Hello, On Tue, 10 Mar 2015 16:05:36 -0500, Felipe Balbi wrote: > I don't get it, why is it so that only mips needs this ? What's special > about mips' writel/readl implementation that it can't be used here ? > > This works for everybody else. Would it be a design oddity of this SoC that device

Re: [PATCH 00/15] musb: Add support for the Allwinner sunxi musb controller

2015-03-10 Thread Hans de Goede
Hi, On 03/10/2015 06:41 PM, Maxime Ripard wrote: On Mon, Mar 09, 2015 at 09:40:13PM +0100, Hans de Goede wrote: Hi All, This patch set has been a while in the making, so I'm very happy to present the end result here, and I hope everyone likes it. Before talking about merging this there are 2

Re: USB ID detection interrupt - non OTG PHY

2015-03-10 Thread David Cohen
Hi Anjana, On Tue, Mar 03, 2015 at 09:27:09AM +0800, Peter Chen wrote: > On Mon, Mar 02, 2015 at 11:47:31AM +0530, Anjana V Kumar wrote: > > Hi Peter, > > > > I will need to configure both the phy and the controller. > > > > Thanks > > Anjana > > > > On Mon, Mar 2, 2015 at 11:24 AM, Peter Chen

Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91

2015-03-10 Thread Felipe Balbi
On Tue, Mar 10, 2015 at 10:41:09PM +0100, Alexandre Belloni wrote: > On 10/03/2015 at 16:23:53 -0500, Felipe Balbi wrote : > > > Yeah, let's drop it for now but I have the feeling that this will > > > break (I actually broke it when switching at91 to multiplatform). > > > > aha, that changes it. S

Re: [PATCH v5 0/5] Add support for Fujitsu USB host controller

2015-03-10 Thread Felipe Balbi
On Sun, Feb 22, 2015 at 12:25:35PM +0800, Sneeker Yeh wrote: > These patches add support for XHCI compliant Host controller found > on Fujitsu Socs, and are based on http://lwn.net/Articles/629162/ > The first patch is to add Fujitsu glue layer of Synopsis DesignWare USB3 > driver > and last four

Re: [PATCH v3] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-03-10 Thread Felipe Balbi
On Tue, Mar 10, 2015 at 06:22:17PM -0300, Fabio Estevam wrote: > On Tue, Mar 10, 2015 at 6:20 PM, Felipe Balbi wrote: > > On Tue, Feb 03, 2015 at 07:18:17PM -0200, Fabio Estevam wrote: > >> From: Fabio Estevam > >> > >> Commit 9eb0797722895f4309b4 ("usb: phy: generic: fix the gpios to be > >> op

[PATCH] usb: phy: am335x-control: check return value of bus_find_device

2015-03-10 Thread Felipe Balbi
From: David Dueck This fixes a potential null pointer dereference. Cc: # v3.16+ Fixes: d4332013919a ("driver core: dev_get_drvdata: Don't check for NULL dev") Acked-by: Sebastian Andrzej Siewior Signed-off-by: David Dueck Signed-off-by: Felipe Balbi --- drivers/usb/phy/phy-am335x-control.c

Re: [PATCH v2 3/3] usb: chipidea: udc: apply new usb_udc_vbus_handler interface

2015-03-10 Thread Felipe Balbi
hi, On Fri, Mar 06, 2015 at 10:36:04AM +0800, Peter Chen wrote: > @@ -1574,13 +1574,12 @@ static int ci_udc_pullup(struct usb_gadget *_gadget, > int is_on) > { > struct ci_hdrc *ci = container_of(_gadget, struct ci_hdrc, gadget); > > - if (!ci->vbus_active) > - return -EO

Re: [PATCH v2 2/3] usb: udc: add usb_udc_vbus_handler

2015-03-10 Thread Felipe Balbi
hi, On Fri, Mar 06, 2015 at 10:36:03AM +0800, Peter Chen wrote: > @@ -145,6 +148,34 @@ EXPORT_SYMBOL_GPL(usb_gadget_set_state); > > /* - > */ > > +static void usb_udc_connect_control(struct usb_udc *udc) > +{ > + if

Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91

2015-03-10 Thread Felipe Balbi
On Tue, Mar 10, 2015 at 10:21:22PM +0100, Alexandre Belloni wrote: > On 10/03/2015 at 15:53:12 -0500, Felipe Balbi wrote : > > On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote: > > > On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote : > > > > > config USB_ATMEL_USBA > > > > >

Re: commit ef11982dd7a657512c362242508bb4021e0d67b6 breaks musb

2015-03-10 Thread Felipe Balbi
On Thu, Mar 05, 2015 at 12:25:48PM +0530, Amit Virdi wrote: > +cc Sebastian, Alan Stern > > Hello Felipe, > > On 2/28/2015 3:18 AM, Felipe Balbi wrote: > >Hi Amit, > > > >commit ef11982dd7a657512c362242508bb4021e0d67b6 (Add support for > >interrupt EP) actually broke testusb for MUSB when MUSB is

Re: [PATCH v3] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-03-10 Thread Fabio Estevam
On Tue, Mar 10, 2015 at 6:20 PM, Felipe Balbi wrote: > On Tue, Feb 03, 2015 at 07:18:17PM -0200, Fabio Estevam wrote: >> From: Fabio Estevam >> >> Commit 9eb0797722895f4309b4 ("usb: phy: generic: fix the gpios to be >> optional") >> calls gpiod_direction_output() in the probe function, so there

Re: [PATCH v3] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-03-10 Thread Felipe Balbi
On Tue, Feb 03, 2015 at 07:18:17PM -0200, Fabio Estevam wrote: > From: Fabio Estevam > > Commit 9eb0797722895f4309b4 ("usb: phy: generic: fix the gpios to be > optional") > calls gpiod_direction_output() in the probe function, so there is no need to > call it again, as we can simply call gpiod_s

Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91

2015-03-10 Thread Alexandre Belloni
On 10/03/2015 at 15:53:12 -0500, Felipe Balbi wrote : > On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote: > > On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote : > > > > config USB_ATMEL_USBA > > > > tristate "Atmel USBA" > > > > - depends on AVR32 || ARCH_AT91

Re: [PATCH 1/1] usb: common: otg-fsm: only signal connect after switching to peripheral

2015-03-10 Thread Felipe Balbi
On Sun, Feb 15, 2015 at 03:39:48PM +0800, Peter Chen wrote: > We should signal connect (pull up dp) after we have already > at peripheral mode, otherwise, the dp may be toggled due to > we reset controller or do disconnect during the initialization > for peripheral, then, the host may be confused d

Re: [PATCHv7 3/4] USB: gadget: atmel_usba_udc: Start clocks on rising edge of the Vbus signal, stop clocks on falling edge of the Vbus signal

2015-03-10 Thread Felipe Balbi
Hi, this one became: "usb: gadget: atmel_usba_udc: condition clocks to vbus state" cheers -- balbi signature.asc Description: Digital signature

Re: [PATCHv7 2/4] USB: gadget: atmel_usba_udc: Request an auto disabled Vbus signal IRQ instead of an auto enabled IRQ request followed by IRQ disable

2015-03-10 Thread Felipe Balbi
Hi, (dropping patch, my only context is subject line) "USB: gadget: atmel_usba_udc: Request an auto disabled Vbus signal IRQ instead of an auto enabled IRQ request followed by IRQ disable" Holy crap, that's a pretty long patch *short* description. I'm trimming it to: "usb: gadget: atmel_usba_ud

Re: [PATCHv7 0/4] USB: gadget: atmel_usba_udc: PM driver improvements

2015-03-10 Thread Felipe Balbi
On Wed, Mar 04, 2015 at 02:12:51PM +0100, Nicolas Ferre wrote: > Le 12/02/2015 18:54, Sylvain Rochet a écrit : > > Start clocks on rising edge of the Vbus signal, stop clocks on falling > > edge of the Vbus signal. > > > > Add suspend/resume with wakeup support. > > Hi Felipe, > > I think this s

Re: gadgetfs broken since 7f7f25e8

2015-03-10 Thread Felipe Balbi
On Sun, Mar 08, 2015 at 02:35:25PM -0400, Alan Stern wrote: > On Sun, 8 Mar 2015, Al Viro wrote: > > > On Sat, Mar 07, 2015 at 04:08:49PM -0500, Alan Stern wrote: > > > On Sat, 7 Mar 2015, Alexander Holler wrote: > > > > > > > Am 07.03.2015 um 12:23 schrieb Alexander Holler: > > > > > Am 04.03.20

Re: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91

2015-03-10 Thread Felipe Balbi
On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote: > On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote : > > > config USB_ATMEL_USBA > > > tristate "Atmel USBA" > > > - depends on AVR32 || ARCH_AT91 > > > + depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91 > > > > I guess yo

Re: [PATCH] drivers: usb: gadget: udc: Fix NULL dereference

2015-03-10 Thread Felipe Balbi
On Tue, Mar 10, 2015 at 03:00:49AM +, Peter Chen wrote: > > > On Tue, Mar 10, 2015 at 02:02:44AM +, Peter Chen wrote: > > > > > > > > --- a/drivers/usb/gadget/udc/lpc32xx_udc.c > > > > > +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c > > > > > @@ -1803,7 +1803,7 @@ static int lpc32xx_ep_queue

Re: [PATCH 5/7] usb: chipidea: otg_fsm: add HNP polling support

2015-03-10 Thread Felipe Balbi
On Mon, Mar 09, 2015 at 10:09:21AM +0800, Li Jun wrote: > From: Li Jun > > Add a dedicataed normal timer for HNP polling since it's cyclical, while > in peripheral mode, change a/b_bus_req to be 1 will make it response > to host request flag with 1, then role switch will be started. > > Signed-o

Re: [V4.0.0-rc3] Xhci Regression: ERROR Transfer event TRB DMA ptr not part of current TD

2015-03-10 Thread Alan Stern
On Tue, 10 Mar 2015, Mathias Nyman wrote: > > Mathias: > > > > Your patch description says this: > > > >> The endpoint might already processesed some TRBs on the endpiont ring > >> before we soft reset the endpoint. > >> Make sure we set the dequeue pointer to where we were befere soft reset > >

Re: [PATCH 12/15] ARM: dts: sun4i: Enable USB DRC on Chuwi V7 CW0825

2015-03-10 Thread Maxime Ripard
On Tue, Mar 10, 2015 at 04:23:09PM +0100, Hans de Goede wrote: > Hi, > > On 03/10/2015 04:07 PM, Maxime Ripard wrote: > >Hi Hans, > > > >On Mon, Mar 09, 2015 at 09:40:25PM +0100, Hans de Goede wrote: > >>Enable the otg/drc usb controller on the Chuwi V7 CW0825 tablet. > >> > >>Signed-off-by: Hans

RE: [PATCH 2/8][RESEND]usb:fsl:otg: Add support to add/remove usb host driver

2015-03-10 Thread Ramneek Mehresh
> -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Tuesday, March 10, 2015 7:21 PM > To: Mehresh Ramneek-B31383 > Cc: linux-usb@vger.kernel.org; ba...@ti.com; gre...@linuxfoundation.org; Li > Yang-Leo-R58472 > Subject: Re: [PATCH 2/8][RESEND]usb:fsl:otg: Ad

[PATCH 1/1] Revert "xhci: Clear the host side toggle manually when endpoint is 'soft reset'"

2015-03-10 Thread Mathias Nyman
This reverts commit 27082e2654dc ("xhci: Clear the host side toggle manually") Turns out this fix to enable soft resetting endpoints wasn't mature enough. It caused regression with some usb DVB-T devices and needs some more tuning to get the endpiont ring pointers set correctly. The original comm

[PATCH 0/1] xhci fixes for usb-linus, revert patch that went to 4.0-rc3

2015-03-10 Thread Mathias Nyman
Hi Greg One xhci patch that went to 4.0-rc3 needs to be reverted Turns out the fix for xhci connected scanners cause regression on some DVB-T devices. The bug in the original patch is found, but I need to make sure everything works properly first, so it's better to revert this than try to fix it

[RFC] Warn about resets of active endpoints

2015-03-10 Thread Alan Stern
On Tue, 10 Mar 2015, Alan Stern wrote: > However, if a driver tries to issue an endpoint reset while there are > still some URBs queued, it is a bug. Host controller drivers shouldn't > have to worry about this -- xhci_endpoint_reset() should simply return > an error if the endpoint ring isn't e

Re: [PATCH 00/15] musb: Add support for the Allwinner sunxi musb controller

2015-03-10 Thread Maxime Ripard
On Mon, Mar 09, 2015 at 09:40:13PM +0100, Hans de Goede wrote: > Hi All, > > This patch set has been a while in the making, so I'm very happy to present > the end result here, and I hope everyone likes it. > > Before talking about merging this there are 2 things which I would like to > point out:

Re: [V4.0.0-rc3] Xhci Regression: ERROR Transfer event TRB DMA ptr not part of current TD

2015-03-10 Thread Alan Stern
On Tue, 10 Mar 2015, Mathias Nyman wrote: > Yes, thank you > > Seems that It wasn't mature enough, I'll revert it. > > From your logs I can see what went wrong, > > If you still have some time, could you try out a patch (attached) and see if > it solves the > issue for you. (on top of clean 4

Re: [V4.0.0-rc3] Xhci Regression: ERROR Transfer event TRB DMA ptr not part of current TD

2015-03-10 Thread Mathias Nyman
On 10.03.2015 17:36, Jörg Otte wrote: >>> Any chance you could take a log with xhci debugging enabled before >>> attaching the DVB-T >>> stick? >>> >>> echo -n 'module xhci_hcd =p' > /sys/kernel/debug/dynamic_debug/control >>> >>> >> >> here it comes attached. >> >> >>> I'd suspect one of these t

[PATCH] usb: musb: dsps: don't fake of_node to musb core

2015-03-10 Thread Felipe Balbi
If we pass our own of_node to musb_core, at least pinctrl settings will be duplicated, meaning that pinctrl framework will try to select default pin state for musb_core when they were already requested by musb-dsps. A Warning will be printed however things will still work. Reported-by: Tony Lindg

[PATCH] usbhid: add quirk for a Logitech mouse

2015-03-10 Thread oliver
From: Oliver Neukum This device disconnects every 60s without X Signed-off-by: Oliver Neukum --- drivers/hid/hid-ids.h | 1 + drivers/hid/usbhid/hid-quirks.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 204312b..8a7c347 100

Re: [PATCH 12/15] ARM: dts: sun4i: Enable USB DRC on Chuwi V7 CW0825

2015-03-10 Thread Hans de Goede
Hi, On 03/10/2015 04:07 PM, Maxime Ripard wrote: Hi Hans, On Mon, Mar 09, 2015 at 09:40:25PM +0100, Hans de Goede wrote: Enable the otg/drc usb controller on the Chuwi V7 CW0825 tablet. Signed-off-by: Hans de Goede --- arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts | 31 ++

Re: [PATCH 12/15] ARM: dts: sun4i: Enable USB DRC on Chuwi V7 CW0825

2015-03-10 Thread Maxime Ripard
Hi Hans, On Mon, Mar 09, 2015 at 09:40:25PM +0100, Hans de Goede wrote: > Enable the otg/drc usb controller on the Chuwi V7 CW0825 tablet. > > Signed-off-by: Hans de Goede > --- > arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts | 31 > + > 1 file changed, 31 insertions(

Re: Control message failures kill entire XHCI stack

2015-03-10 Thread Devin Heitmueller
Hello Baolu, I'm doing most of my testing on a 2014 Retina Macbook Pro. lsusb output below. I've also seen the issue on an Intel NUC D34010WYKH, which I don't have in front of me or I would provide the lsusb output for that as well. Apologies to Mathias for not getting back to this sooner. I'v

Re: [PATCH] phy: Add a driver for dm816x USB PHY

2015-03-10 Thread Bin Liu
On Mon, Mar 9, 2015 at 4:41 PM, Tony Lindgren wrote: > * Bin Liu [150309 14:35]: >> On Mon, Mar 9, 2015 at 4:26 PM, Tony Lindgren wrote: >> > * Felipe Balbi [150309 14:21]: >> >> On Mon, Mar 09, 2015 at 04:17:29PM -0500, Bin Liu wrote: >> >> > On Mon, Mar 9, 2015 at 4:13 PM, Felipe Balbi wrote

Re: [V4.0.0-rc3] Xhci Regression: ERROR Transfer event TRB DMA ptr not part of current TD

2015-03-10 Thread Jörg Otte
2015-03-10 14:06 GMT+01:00 Mathias Nyman : > On 10.03.2015 11:40, Jörg Otte wrote: >> If I plug in my USB DVB-T stick I get the following in dmesg: >> >> dvb-usb: found a 'TerraTec/qanu USB2.0 Highspeed DVB-T Receiver' in warm >> state. >> dvb-usb: will pass the complete MPEG2 transport stream to

Re: [PATCH 2/8][RESEND]usb:fsl:otg: Add support to add/remove usb host driver

2015-03-10 Thread Alan Stern
On Tue, 10 Mar 2015, Ramneek Mehresh wrote: > Add workqueue to add/remove host driver (outside interrupt context) > upon each id change > --- a/drivers/usb/host/ehci.h > +++ b/drivers/usb/host/ehci.h > @@ -177,7 +177,9 @@ struct ehci_hcd { /* one per controller */ > unsigned

Re: [PATCH 05/15] musb: Do not use musb_read[b|w] / _write[b|w] wrappers in generic fifo functions

2015-03-10 Thread Arnd Bergmann
On Tuesday 10 March 2015 09:56:52 Hans de Goede wrote: > On 10-03-15 09:50, Arnd Bergmann wrote: > > On Tuesday 10 March 2015 08:43:22 Hans de Goede wrote: > >> On 09-03-15 22:50, Arnd Bergmann wrote: > >>> On Monday 09 March 2015 21:40:18 Hans de Goede wrote: > The generic fifo functions alre

Re: [V4.0.0-rc3] Xhci Regression: ERROR Transfer event TRB DMA ptr not part of current TD

2015-03-10 Thread Mathias Nyman
On 10.03.2015 11:40, Jörg Otte wrote: > If I plug in my USB DVB-T stick I get the following in dmesg: > > dvb-usb: found a 'TerraTec/qanu USB2.0 Highspeed DVB-T Receiver' in warm > state. > dvb-usb: will pass the complete MPEG2 transport stream to the software > demuxer. > DVB: registering new a

[PATCH RESEND] usb: dwc2: rework initialization of host and gadget in dual-role mode

2015-03-10 Thread Marek Szyprowski
If device is configured to work only in HOST or DEVICE mode, there is no point in initializing both subdrivers. This patch also fixes resource leakage if host subdriver fails to initialize. Signed-off-by: Marek Szyprowski --- drivers/usb/dwc2/core.h | 2 ++ drivers/usb/dwc2/platform.c | 29

Re: [PATCH 02/15] phy-sun4i-usb: Add a helper function to update the iscr register

2015-03-10 Thread Hans de Goede
Hi, On 10-03-15 11:53, Kishon Vijay Abraham I wrote: Hi, On Tuesday 10 March 2015 03:43 PM, Hans de Goede wrote: Hi, On 10-03-15 09:57, Arnd Bergmann wrote: On Tuesday 10 March 2015 09:04:43 Hans de Goede wrote: Hi, On 09-03-15 22:47, Arnd Bergmann wrote: On Monday 09 March 2015 21:40:15

Re: [PATCH 02/15] phy-sun4i-usb: Add a helper function to update the iscr register

2015-03-10 Thread Kishon Vijay Abraham I
Hi, On Tuesday 10 March 2015 03:43 PM, Hans de Goede wrote: Hi, On 10-03-15 09:57, Arnd Bergmann wrote: On Tuesday 10 March 2015 09:04:43 Hans de Goede wrote: Hi, On 09-03-15 22:47, Arnd Bergmann wrote: On Monday 09 March 2015 21:40:15 Hans de Goede wrote: +void sun4i_usb_phy_update_iscr(s

cp210x GPIO support

2015-03-10 Thread Grant Likely
Hi Preston, Are you still maintaining GPIO support for the cp210x driver? I'm looking at the last set of patches from 2012 that attempted to mainline it, but it looks like it didn't get anywhere. I'd like to try again. Have you looked at CONFIG_GPIO support in the kernel? I think the biggest comp

[PATCH 8/8] usb:fsl:otg: Make fsl otg driver as tristate

2015-03-10 Thread Ramneek Mehresh
Provide option to load fsl otg driver as loadable module Signed-off-by: Ramneek Mehresh --- drivers/usb/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index 52d3d58..a1637c0 100644 --- a/drivers/usb/phy/Kconfig ++

Re: [PATCH 02/15] phy-sun4i-usb: Add a helper function to update the iscr register

2015-03-10 Thread Hans de Goede
Hi, On 10-03-15 09:57, Arnd Bergmann wrote: On Tuesday 10 March 2015 09:04:43 Hans de Goede wrote: Hi, On 09-03-15 22:47, Arnd Bergmann wrote: On Monday 09 March 2015 21:40:15 Hans de Goede wrote: +void sun4i_usb_phy_update_iscr(struct phy *_phy, u32 clr, u32 set) +{ + struct sun4i_usb

[PATCH 6/8][RESEND]usb:fsl:otg: Add host-gadget drv sync delay

2015-03-10 Thread Ramneek Mehresh
Resolve synchronization issue between host and gadget drivers upon role-reversal Signed-off-by: Ramneek Mehresh Reviewed-by: Li Yang-R58472 Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/phy/phy-fsl-usb.c | 11 ++- 1 file changed, 10 insertions

[PATCH 7/8][RESEND]usb:fsl:otg: Resolve OTG crash issue with another host

2015-03-10 Thread Ramneek Mehresh
Resolves kernel crash issue when a USB flash drive is inserted into USB1 port with USB2 port configured as otg. Removing "else" block so that the controller coming up in "non-otg" mode doesn't return -ENODEV. Returning "ENODEV" results in platform framework unbinding platform-drv from controller re

[PATCH 1/8][RESEND]usb:fsl:otg: Add controller version based ULPI and UTMI phy

2015-03-10 Thread Ramneek Mehresh
Add controller version based ULPI and UTMI phy initialization for otg driver Signed-off-by: Shengzhou Liu Signed-off-by: Ramneek Mehresh Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/phy/phy-fsl-usb.c | 20 drivers/usb/phy/phy-fsl

[PATCH 4/8][RESEND]usb:fsl:otg: Combine host/gadget start/resume for ID change

2015-03-10 Thread Ramneek Mehresh
Make call to fsl_otg_event for each id change even Signed-off-by: Ramneek Mehresh Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/phy/phy-fsl-usb.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/usb/phy/phy-f

[PATCH 3/8][RESEND]usb:fsl:otg: Modify otg_event to start host drv

2015-03-10 Thread Ramneek Mehresh
Add mechanism to start host driver from inside fsl_otg_even upon each id change interrupt Signed-off-by: Ramneek Mehresh Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/phy/phy-fsl-usb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb

[PATCH 2/8][RESEND]usb:fsl:otg: Add support to add/remove usb host driver

2015-03-10 Thread Ramneek Mehresh
Add workqueue to add/remove host driver (outside interrupt context) upon each id change Signed-off-by: Li Yang Signed-off-by: Ramneek Mehresh Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/host/ehci-fsl.c | 102 ++-

Re: Control message failures kill entire XHCI stack

2015-03-10 Thread Lu, Baolu
Hi Devin, Do you mind to post output of "lspci -xv" on the machine where you saw this problem? We are facing the same problems in other cases. I could provide a patch for it later. Thanks, Baolu On 01/19/2015 04:55 AM, Devin Heitmueller wrote: Hello, I'm debugging some issues on a couple

[PATCH 5/8][RESEND]usb:fsl:otg: Remove host drv upon otg bring-up

2015-03-10 Thread Ramneek Mehresh
Change have_hcd variable to remove/suspend host driver on completion of otg initialization for otg auto detect Signed-off-by: Ramneek Mehresh Reviewed-by: Li Yang-R58472 Reviewed-by: Fleming Andrew-AFLEMING Tested-by: Fleming Andrew-AFLEMING --- drivers/usb/host/ehci-fsl.c | 6 ++ 1 file

[V4.0.0-rc3] Xhci Regression: ERROR Transfer event TRB DMA ptr not part of current TD

2015-03-10 Thread Jörg Otte
If I plug in my USB DVB-T stick I get the following in dmesg: dvb-usb: found a 'TerraTec/qanu USB2.0 Highspeed DVB-T Receiver' in warm state. dvb-usb: will pass the complete MPEG2 transport stream to the software demuxer. DVB: registering new adapter (TerraTec/qanu USB2.0 Highspeed DVB-T Receiver)

Re: [linux-sunxi] [PATCH 09/15] ARM: dts: sun4i: Add USB Dual Role Controller

2015-03-10 Thread Hans de Goede
Hi, On 10-03-15 00:31, Julian Calaby wrote: Hi Hans, On Tue, Mar 10, 2015 at 7:40 AM, Hans de Goede wrote: Add a node for the otg/drc usb controller to sun4i-a10.dtsi. Signed-off-by: Hans de Goede --- arch/arm/boot/dts/sun4i-a10.dtsi | 12 drivers/usb/musb/Kconfig |

Re: [PATCH 02/15] phy-sun4i-usb: Add a helper function to update the iscr register

2015-03-10 Thread Arnd Bergmann
On Tuesday 10 March 2015 09:04:43 Hans de Goede wrote: > Hi, > > On 09-03-15 22:47, Arnd Bergmann wrote: > > On Monday 09 March 2015 21:40:15 Hans de Goede wrote: > >> +void sun4i_usb_phy_update_iscr(struct phy *_phy, u32 clr, u32 set) > >> +{ > >> + struct sun4i_usb_phy *phy = phy_get_drvda

Re: [PATCH 05/15] musb: Do not use musb_read[b|w] / _write[b|w] wrappers in generic fifo functions

2015-03-10 Thread Hans de Goede
Hi, On 10-03-15 09:50, Arnd Bergmann wrote: On Tuesday 10 March 2015 08:43:22 Hans de Goede wrote: On 09-03-15 22:50, Arnd Bergmann wrote: On Monday 09 March 2015 21:40:18 Hans de Goede wrote: The generic fifo functions already use non wrapped accesses in various cases through the iowrite#_re

Re: [PATCH 05/15] musb: Do not use musb_read[b|w] / _write[b|w] wrappers in generic fifo functions

2015-03-10 Thread Arnd Bergmann
On Tuesday 10 March 2015 08:43:22 Hans de Goede wrote: > On 09-03-15 22:50, Arnd Bergmann wrote: > > On Monday 09 March 2015 21:40:18 Hans de Goede wrote: > >> The generic fifo functions already use non wrapped accesses in various > >> cases through the iowrite#_rep functions, and all platforms whi

Re: [PATCH 00/15] musb: Add support for the Allwinner sunxi musb controller

2015-03-10 Thread Arnd Bergmann
On Tuesday 10 March 2015 09:46:24 Chen-Yu Tsai wrote: > I believe you are talking about "mmio-sram"? Yes. > The syscon here represents a switch, to toggle whether a block of SRAM is > mapped into the CPU memory space, or to a specific devices private address > space. It is not the actual SRAM. >

Re: [PATCH 02/15] phy-sun4i-usb: Add a helper function to update the iscr register

2015-03-10 Thread Hans de Goede
Hi, On 09-03-15 22:47, Arnd Bergmann wrote: On Monday 09 March 2015 21:40:15 Hans de Goede wrote: +void sun4i_usb_phy_update_iscr(struct phy *_phy, u32 clr, u32 set) +{ + struct sun4i_usb_phy *phy = phy_get_drvdata(_phy); + struct sun4i_usb_phy_data *data = to_sun4i_usb_phy_data(phy

Re: [PATCH 03/19] usb: dwc2: add controller hibernation support

2015-03-10 Thread Robert Baldyga
Hi, On 03/09/2015 04:04 PM, Mian Yousaf Kaukab wrote: > From: Gregory Herrero > > When suspending usb bus, phy driver may disable controller power. > In this case, registers need to be saved on suspend and restored > on resume. > > Signed-off-by: Gregory Herrero > --- > drivers/usb/dwc2/core.

Re: [PATCH 05/15] musb: Do not use musb_read[b|w] / _write[b|w] wrappers in generic fifo functions

2015-03-10 Thread Hans de Goede
Hi, On 09-03-15 22:50, Arnd Bergmann wrote: On Monday 09 March 2015 21:40:18 Hans de Goede wrote: The generic fifo functions already use non wrapped accesses in various cases through the iowrite#_rep functions, and all platforms which override the default musb_read[b|w] / _write[b|w] functions

Re: [PATCH 00/15] musb: Add support for the Allwinner sunxi musb controller

2015-03-10 Thread Hans de Goede
Hi, On 10-03-15 02:46, Chen-Yu Tsai wrote: Hi Arnd, On Tue, Mar 10, 2015 at 5:44 AM, Arnd Bergmann wrote: On Monday 09 March 2015 21:40:13 Hans de Goede wrote: Hi All, This patch set has been a while in the making, so I'm very happy to present the end result here, and I hope everyone likes