[PATCH] snd-usb-audio: Add support for Akai MPC Element MIDI controller

2015-01-05 Thread Paul Bonser
This device incorrectly reports its bInterfaceClass as 255, when it should really be 1 (USB_CLASS_AUDIO). Signed-off-by: Paul Bonser --- diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h index 8590a32..42ccd76 100644 --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h @@

Re: query on DWC3

2015-01-05 Thread sundeep subbaraya
Hi, On Mon, Dec 22, 2014 at 9:42 PM, Felipe Balbi wrote: > Hi again, > > On Mon, Dec 22, 2014 at 10:11:23AM -0600, Felipe Balbi wrote: >> (please don't top-post) Sure. >> >> On Sun, Dec 14, 2014 at 08:39:18AM +0530, sundeep subbaraya wrote: >> > Hi Paul, >> > >> > As per my understanding, for B

Re: [PATCH 2/4] usb: dwc3: gadget: Stop TRB preparation after limit is reached

2015-01-05 Thread Amit Virdi
I can certainly provide the dwc3 specific kernel bootup logs, full regdump and any loglevel you want me to, if that helps Yeah, if you can provide those, then that'll help me verifying. Full logs from boot to failure point with VERBOSE_DEBUG enabled (considering you're not running on anything re

RE: [PATCH v2 00/30] usb: updates for dwc2 gadget driver

2015-01-05 Thread Dinh Nguyen
On Mon, 5 Jan 2015, Paul Zimmerman wrote: > Adding Dinh to CC. > > Robert, Dinh, I would like to have your tested-bys for this series, please. > I'll try to test this by the end of this week. Dinh > > > From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] > > Sent: Friday, January 02, 20

RE: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2015-01-05 Thread Paul Zimmerman
> From: Kever Yang [mailto:kever.y...@rock-chips.com] > Sent: Monday, January 05, 2015 5:42 PM > > Hi Paul, > > I think you need this patch to fix the problem: > > usb: dwc2: resume root hub when device detect with suspend state > https://patchwork.kernel.org/patch/5325111/ > > Thanks, > > - K

[PATCH] xhci: remove unused parameter 'xhci' in function xhci_handshake().

2015-01-05 Thread Lin Wang
Parameter 'xhci' is no longer be used in function xhci_handshake(), just remove it. Signed-off-by: Lin Wang --- drivers/usb/host/xhci-ring.c |2 +- drivers/usb/host/xhci.c | 19 +-- drivers/usb/host/xhci.h |3 +-- 3 files changed, 11 insertions(+), 13 deletion

[PATCH] xhci: clean up work to remove unused parameters for functions in xhci-mem.c

2015-01-05 Thread Lin Wang
Some parameters are not used by functions in xhci-mem.c, just remove it. Signed-off-by: Lin Wang --- drivers/usb/host/xhci-dbg.c |2 +- drivers/usb/host/xhci-mem.c | 21 + drivers/usb/host/xhci-ring.c |6 +++--- drivers/usb/host/xhci.c | 34

[PATCH] xhci: Clean up work to xhci_add_endpoint().

2015-01-05 Thread Lin Wang
This patch removes unused variable "out_ctx" and avoid multiple calls to function xhci_get_endpoint_flag(). Signed-off-by: Lin Wang --- drivers/usb/host/xhci.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index

Re: kernel panic with USB3+DVB+ARM

2015-01-05 Thread Greg KH
On Mon, Jan 05, 2015 at 05:13:48PM +0100, JPT wrote: > Hi, > > would you like to trouble-shoot the kernel USB3/xhci code? > > I had a lot of struggle with the following set up: > - Netgear ReadyNAS rn104 (ARMv7) running plain debian > - Fresco Logic FL1009 USB3 controller > - selfbuilt kernel.org

Re: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2015-01-05 Thread Kever Yang
Hi Paul, I think you need this patch to fix the problem: usb: dwc2: resume root hub when device detect with suspend state https://patchwork.kernel.org/patch/5325111/ Thanks, - Kever On 01/06/2015 09:23 AM, Paul Zimmerman wrote: From: Kever Yang [mailto:kever.y...@rock-chips.com] Sent: Wednesd

RE: [PATCH v3] usb: dwc2: add bus suspend/resume for dwc2

2015-01-05 Thread Paul Zimmerman
> From: Kever Yang [mailto:kever.y...@rock-chips.com] > Sent: Wednesday, November 12, 2014 4:42 PM > > On 11/13/2014 07:22 AM, Doug Anderson wrote: > > Kever, > > > > On Mon, Nov 10, 2014 at 5:09 AM, Kever Yang > > wrote: > >> Hcd controller needs bus_suspend/resume, dwc2 controller make > >> ro

Re: Difference between run time and normal suspend

2015-01-05 Thread vichy
2015-01-05 23:40 GMT+08:00 Alan Stern : > On Mon, 5 Jan 2015, vichy wrote: > >> hi all: >> after tracing and reading kernel usb source code about run time and >> normal suspend. >> 1. how could we check the rum time suspend is work on some device? >> By plugging in devices and check whether >>

Re: [PATCH 3/3] usb: storage: adjust module reference for scsi host

2015-01-05 Thread Akinobu Mita
2015-01-06 0:27 GMT+09:00 Alan Stern : > On Mon, 5 Jan 2015, Akinobu Mita wrote: > >> While accessing a unusual usb storage (ums-alauda, ums-cypress, ...), >> the module reference count is not incremented. Because these drivers >> allocate scsi hosts with usb_stor_host_template defined in usb-stor

Re: qcserial: AT unsolicited response codes missing with Sierra Wireless MC7304

2015-01-05 Thread Reinhard Speyerer
Johan Hovold wrote: > On Sat, Dec 27, 2014 at 10:54:09PM +0100, Reinhard Speyerer wrote: > > Reinhard Speyerer wrote: > > > Johan Hovold wrote: > > > > On Sun, Dec 21, 2014 at 11:25:45PM +0100, Reinhard Speyerer wrote: > > > With the qcserial.c patch below (for Linux kernel 3.16.3) I was able t

Re: Issues with commit 34b48db6 ("block: remove artifical max_hw_sectors cap")

2015-01-05 Thread Kenneth R. Crudup
I will later tonight. For now, I'm using 3.18.x (for another reason), which doesn't have this commit. My Linus-latest tree has a "fix" that imposed a hard limit of 32767, which worked for me then. On January 5, 2015 12:07:56 PM PST, Alan Stern wrote: >On Mon, 5 Jan 2015, Christoph Hellwig wro

Re: Issues with commit 34b48db6 ("block: remove artifical max_hw_sectors cap")

2015-01-05 Thread Alan Stern
On Mon, 5 Jan 2015, Christoph Hellwig wrote: > On Tue, Dec 30, 2014 at 08:36:34AM -0800, Kenneth R. Crudup wrote: > > OP here. FWIW, this is what I get when running that command on the SCSI > > generic device that corresponds to the USB-3 (non-UAS) disk[1] that had the > > issue: > > So it looks

RE: [PATCH] drivers: usb: dwc2: remove 'force' parameter from kill_all_requests()

2015-01-05 Thread Paul Zimmerman
> From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Tuesday, December 16, 2014 2:52 AM > > This patch fixes in simpler way the bug described in [1] and [2]. It > looks like DWC2 is the only UDC driver that doesn't force usb requests > to complete in ep_disable() function. This causes des

RE: [PATCH] usb: dwc2: add support for initial state for dual-role mode

2015-01-05 Thread Paul Zimmerman
> From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] > Sent: Wednesday, December 17, 2014 5:50 AM > > DWC2 module on Exynos SoCs is used only as peripheral controller (UDC), > so add support for selecting default initial state for dual-role mode. The > default init mode can be overridden by

Re: [PATCH] usb: phy: Restore deferred probing path

2015-01-05 Thread Stephen Warren
On 12/23/2014 11:36 AM, Felipe Balbi wrote: On Thu, Dec 04, 2014 at 01:06:07PM +0100, Thierry Reding wrote: From: Thierry Reding Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on failure") broke platforms that rely on deferred probing to order probing of PHY and host con

RE: [PATCH v2 00/30] usb: updates for dwc2 gadget driver

2015-01-05 Thread Paul Zimmerman
Adding Dinh to CC. Robert, Dinh, I would like to have your tested-bys for this series, please. -- Paul > From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] > Sent: Friday, January 02, 2015 6:42 AM > > Hi, > This patchset consists of various bug fixes and feature enhancements for the > d

Re: PROBLEM: USB isochronous urb leak on EHCI driver

2015-01-05 Thread Fabio Estevam
On Mon, Jan 5, 2015 at 1:12 PM, Michael Tessier wrote: > If sound is ok when using only 1 codec and becomes choppy when adding a > second codec, then it means that this issue is still in the 3.x kernel. This > answer will tell me if it is worth working on using a newer kernel or not. > I have to

Re: Issues with commit 34b48db6 ("block: remove artifical max_hw_sectors cap")

2015-01-05 Thread Christoph Hellwig
On Tue, Dec 30, 2014 at 08:36:34AM -0800, Kenneth R. Crudup wrote: > OP here. FWIW, this is what I get when running that command on the SCSI > generic device that corresponds to the USB-3 (non-UAS) disk[1] that had the > issue: So it looks like this one actually provides sane values, but we don't

Re: Issues with commit 34b48db6 ("block: remove artifical max_hw_sectors cap")

2015-01-05 Thread Christoph Hellwig
On Tue, Dec 30, 2014 at 11:19:07AM -0500, Douglas Gilbert wrote: > In SCSI, the VPD page 0xb0 (Block limits) has a "Maximum transfer > length" field (32 bits long). Its units are logical blocks. Useful > if >0 as 0 means "unreported". > > USB to SATA bridges should comply with SAT. However SAT and

Re: [PATCH 3/3] usb: dwc3: add a quirk for device disconnection issue in Synopsis dwc3 core

2015-01-05 Thread Felipe Balbi
Hi, On Sun, Jan 04, 2015 at 08:55:01PM +0800, Sneeker Yeh wrote: > > > So far Fujitsu Semiconductor got Synopsys internal case id , that is " > > > Case: 8000679552". > > > However the contents belongs this id cannot be referred except Fujitsu > > > Semiconductor and Synopsys. > > > Synopsis decid

kernel panic with USB3+DVB+ARM

2015-01-05 Thread JPT
Hi, would you like to trouble-shoot the kernel USB3/xhci code? I had a lot of struggle with the following set up: - Netgear ReadyNAS rn104 (ARMv7) running plain debian - Fresco Logic FL1009 USB3 controller - selfbuilt kernel.org kernel 3.18.1 - Technisat SkyStar USB HD (DVB-S/S2) - USB 2.0 Highs

RE: PROBLEM: USB isochronous urb leak on EHCI driver

2015-01-05 Thread Alan Stern
On Mon, 5 Jan 2015, Michael Tessier wrote: > > > Hi, > > > > > > I am dealing with a USB EHCI driver bug. Here is the info: > > > > > > My configuration: > > > - > > > > > > Host: Freescale i.MX512 with ARM Cortex A8 (USB 2.0 host controller) > > > Linux kernel: 2.6.31, using E

Re: [PATCH 2/3] usb: dwc3: add Fujitsu Specific Glue layer

2015-01-05 Thread Felipe Balbi
Hi, On Sun, Jan 04, 2015 at 09:16:01PM +0800, Sneeker Yeh wrote: > > > Then dwc3 core won't be always created via sub node in platform glue > > node, > > > and vendors like us can just drop platform glue which don't have any > > > specific platform code to wrap dwc3 core, and just directly use dwc

Re: [PATCH 2/3] usb: dwc3: add Fujitsu Specific Glue layer

2015-01-05 Thread Felipe Balbi
Hi, On Mon, Jan 05, 2015 at 04:28:34PM +0100, Arnd Bergmann wrote: > On Friday 02 January 2015 19:21:28 Felipe Balbi wrote: > > > > On Tue, Dec 30, 2014 at 11:12:51AM +0100, Arnd Bergmann wrote: > > > On Monday 29 December 2014 01:52:04 Sneeker Yeh wrote: > > > > > > +static int dwc3_mb86s70_remo

Re: Difference between run time and normal suspend

2015-01-05 Thread Alan Stern
On Mon, 5 Jan 2015, vichy wrote: > hi all: > after tracing and reading kernel usb source code about run time and > normal suspend. > 1. how could we check the rum time suspend is work on some device? > By plugging in devices and check whether > /sys/bus/usb/devices/.../power/ is empty or not?

Re: [PATCH 2/3] usb: dwc3: add Fujitsu Specific Glue layer

2015-01-05 Thread Arnd Bergmann
On Friday 02 January 2015 19:21:28 Felipe Balbi wrote: > > On Tue, Dec 30, 2014 at 11:12:51AM +0100, Arnd Bergmann wrote: > > On Monday 29 December 2014 01:52:04 Sneeker Yeh wrote: > > > > > +static int dwc3_mb86s70_remove_child(struct device *dev, void > > > > > *unused) > > > > > +{ > > > > > +

Re: [PATCH 3/3] usb: storage: adjust module reference for scsi host

2015-01-05 Thread Alan Stern
On Mon, 5 Jan 2015, Akinobu Mita wrote: > While accessing a unusual usb storage (ums-alauda, ums-cypress, ...), > the module reference count is not incremented. Because these drivers > allocate scsi hosts with usb_stor_host_template defined in usb-storage > module. So these drivers always can be

Re: USB-serial console and lockdep

2015-01-05 Thread Peter Hurley
On 01/03/2015 11:26 AM, Johan Hovold wrote: > On Wed, Dec 31, 2014 at 09:07:59PM -0500, Peter Hurley wrote: >> Hi Johan, >> >> On 11/18/2014 11:18 AM, Johan Hovold wrote: >>> I get this missing-lockdep-annotation warning which I haven't seen >>> before when booting with a usb-serial console on 3.18

Re: [PATCH] usb: ehci: fix port power enable when override present

2015-01-05 Thread Alan Stern
On Mon, 5 Jan 2015, Lucas Stach wrote: > Some controllers need to have external power supplied before toggling > the internal PORT_POWER bit. > > Fixes: 11a7e5940514 (usb: ehci: add ehci_port_power interface) on i.MX51 > where the controller would hang the machine when trying to enable PORT_POWER

RE: PROBLEM: USB isochronous urb leak on EHCI driver

2015-01-05 Thread Michael Tessier
> > On Mon, 15 Dec 2014, Michael Tessier wrote: > > > Hi, > > > > I am dealing with a USB EHCI driver bug. Here is the info: > > > > My configuration: > > - > > > > Host: Freescale i.MX512 with ARM Cortex A8 (USB 2.0 host controller) > > Linux kernel: 2.6.31, using EHCI USB driv

[PATCH v2 2/2] USB: console: fix potential use after free

2015-01-05 Thread Johan Hovold
Use tty kref to release the fake tty in usb_console_setup to avoid use after free if the underlying serial driver has acquired a reference. Note that using the tty destructor release_one_tty requires some more state to be initialised. Fixes: 4a90f09b20f4 ("tty: usb-serial krefs") Cc: stable Sign

[PATCH v2 1/2] USB: console: fix uninitialised ldisc semaphore

2015-01-05 Thread Johan Hovold
The USB console currently allocates a temporary fake tty which is used to pass terminal settings to the underlying serial driver. The tty struct is not fully initialised, something which can lead to a lockdep warning (or worse) if a serial driver tries to acquire a line-discipline reference:

[PATCH 1/3] scsi: add ability to adjust module reference for scsi host

2015-01-05 Thread Akinobu Mita
While accessing a scsi_device, the use count of the underlying LLDD module is incremented. The module reference is retrieved through .module field of struct scsi_host_template. This mapping between scsi_device and underlying LLDD module works well except some scsi drivers (ufs and unusual usb sto

[PATCH 3/3] usb: storage: adjust module reference for scsi host

2015-01-05 Thread Akinobu Mita
While accessing a unusual usb storage (ums-alauda, ums-cypress, ...), the module reference count is not incremented. Because these drivers allocate scsi hosts with usb_stor_host_template defined in usb-storage module. So these drivers always can be unloaded. This fixes it by adjusting module ref

[PATCH 0/3] scsi: ufs & ums-*: fix module reference counting

2015-01-05 Thread Akinobu Mita
While accessing a scsi_device, the use count of the underlying LLDD module is incremented. The module reference is retrieved through .module field of struct scsi_host_template. This mapping between scsi_device and underlying LLDD module works well except some scsi drivers (ufs and unusual usb sto

Re: [PATCH] usb: ehci: fix port power enable when override present

2015-01-05 Thread Fabio Estevam
On Mon, Jan 5, 2015 at 9:02 AM, Lucas Stach wrote: > Some controllers need to have external power supplied before toggling > the internal PORT_POWER bit. > > Fixes: 11a7e5940514 (usb: ehci: add ehci_port_power interface) on i.MX51 > where the controller would hang the machine when trying to enable

Re: [PATCH] usb: host: ehci-tegra: request deferred probe when failing to get phy

2015-01-05 Thread Tomeu Vizoso
On 24 December 2014 at 11:16, Vince Hsu wrote: > The commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on > failure") changed the condition to return -EPROBE_DEFER to host driver. > Originally the Tegra host driver depended on the returned -EPROBE_DEFER to > get the phy device

Re: [PATCH] usb: ehci: fix port power enable when override present

2015-01-05 Thread Fabio Estevam
On Mon, Jan 5, 2015 at 11:06 AM, Lucas Stach wrote: > Am Montag, den 05.01.2015, 10:12 -0200 schrieb Fabio Estevam: >> Hi Lucas, >> >> On Mon, Jan 5, 2015 at 9:02 AM, Lucas Stach wrote: >> > Some controllers need to have external power supplied before toggling >> > the internal PORT_POWER bit. >>

Re: [PATCH] usb: ehci: fix port power enable when override present

2015-01-05 Thread Lucas Stach
Am Montag, den 05.01.2015, 10:12 -0200 schrieb Fabio Estevam: > Hi Lucas, > > On Mon, Jan 5, 2015 at 9:02 AM, Lucas Stach wrote: > > Some controllers need to have external power supplied before toggling > > the internal PORT_POWER bit. > > > > Fixes: 11a7e5940514 (usb: ehci: add ehci_port_power i

Difference between run time and normal suspend

2015-01-05 Thread vichy
hi all: after tracing and reading kernel usb source code about run time and normal suspend. 1. how could we check the rum time suspend is work on some device? By plugging in devices and check whether /sys/bus/usb/devices/.../power/ is empty or not? 2. I plug in one mouse and found the device w

Re: [PATCH] usb: ehci: fix port power enable when override present

2015-01-05 Thread Fabio Estevam
Hi Lucas, On Mon, Jan 5, 2015 at 9:02 AM, Lucas Stach wrote: > Some controllers need to have external power supplied before toggling > the internal PORT_POWER bit. > > Fixes: 11a7e5940514 (usb: ehci: add ehci_port_power interface) on i.MX51 > where the controller would hang the machine when tryin

Re: [PATCH v2] renesas_usbhs: fix platform init error message

2015-01-05 Thread Geert Uytterhoeven
Hi Shimoda-san, On Wed, Dec 24, 2014 at 11:02 AM, yoshihiro shimoda wrote: >> > > Er, OK. Could you update MAINTAINERS? >> > there is no entry for renesas driver in MAINTAINERS. >> > Shimoda-san, care to send a patch adding yourself or Morimoto-san as >> > maintainers for Rene

[PATCH] usb: ehci: fix port power enable when override present

2015-01-05 Thread Lucas Stach
Some controllers need to have external power supplied before toggling the internal PORT_POWER bit. Fixes: 11a7e5940514 (usb: ehci: add ehci_port_power interface) on i.MX51 where the controller would hang the machine when trying to enable PORT_POWER. Signed-off-by: Lucas Stach Cc: sta...@vger.ker

Re: [PATCH 1/3] gpio: dln2: fix issue when an IRQ is unmasked then enabled

2015-01-05 Thread Octavian Purdila
On Mon, Jan 5, 2015 at 6:55 PM, Linus Walleij wrote: > > On Wed, Dec 31, 2014 at 9:55 PM, Linus Walleij > wrote: > > On Thu, Dec 11, 2014 at 2:02 PM, Octavian Purdila > > wrote: > > > >> As noticed during suspend/resume operations, the IRQ can be unmasked > >> then disabled in suspend and event

[PATCH] tools: ffs-aio-example: add missing wMaxPacketSize for HS descs

2015-01-05 Thread Robert Baldyga
It's needed, to have more than 64 bytes of maxpacketsize. Signed-off-by: Robert Baldyga --- tools/usb/ffs-aio-example/simple/device_app/aio_simple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/usb/ffs-aio-example/simple/device_app/aio_simple.c b/tools/usb/ffs-aio-example/simple/

[PATCH 0/2] usb: dwc2: fix the uncompleted requests problem

2015-01-05 Thread Robert Baldyga
Hi Felipe, I prepared this patchset in response to our discussion: https://lkml.org/lkml/2014/12/29/193 It reverts of unproper patch and adds working solution of the problem described in commit messages. Best regards, Robert Baldyga Robert Baldyga (2): Revert "usb: dwc2: gadget: kill requests

[PATCH 2/2] drivers: usb: dwc2: remove 'force' parameter from kill_all_requests()

2015-01-05 Thread Robert Baldyga
This patch fixes in simpler way the bug described in [1] and [2]. It looks like DWC2 is the only UDC driver that doesn't force usb requests to complete in ep_disable() function. This causes described problem, because we have no guarantee that all requests will be completed before unbind of usb func

[PATCH 1/2] Revert "usb: dwc2: gadget: kill requests with 'force' in s3c_hsotg_udc_stop()"

2015-01-05 Thread Robert Baldyga
This reverts commit 62f4f0651ce8ef966a0e5b6db6a7a524c268fdd2. This patch is incomplete solution. It won't work without changes in udc-core, which were considered as unacceptable (discussion [1]). [1] https://lkml.org/lkml/2014/12/12/360 Signed-off-by: Robert Baldyga --- drivers/usb/dwc2/gadget

Re: [PATCH 1/3] gpio: dln2: fix issue when an IRQ is unmasked then enabled

2015-01-05 Thread Linus Walleij
On Wed, Dec 31, 2014 at 9:55 PM, Linus Walleij wrote: > On Thu, Dec 11, 2014 at 2:02 PM, Octavian Purdila > wrote: > >> As noticed during suspend/resume operations, the IRQ can be unmasked >> then disabled in suspend and eventually enabled in resume, but without >> being unmasked. >> >> The curre