[PATCH 1/1] usb: gadget: Remove use of PWD in Makefiles

2014-08-27 Thread Shea Levy
Using PWD breaks out-of-tree builds in certain circumstances [1], and other kernel Makefiles use relative paths just fine. [1]: https://bugzilla.kernel.org/show_bug.cgi?id=83251 Signed-off-by: Shea Levy --- drivers/usb/gadget/Makefile | 2 +- drivers/usb/gadget/function/Makefile | 4 ++

Re: [PATCH v5 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-08-27 Thread Vivek Gautam
Hi Jingoo, On Wed, Aug 27, 2014 at 7:28 AM, Jingoo Han wrote: > On Thursday, August 21, 2014 11:55 PM, Vivek Gautam wrote: >> >> Adding phy calibrate callback, which facilitates setting certain >> PHY settings post initialization of the PHY controller. >> Exynos5420 and Exynos5800 have 28nm USB

[xhci] kernel BUG at arch/x86/mm/physaddr.c:26!

2014-08-27 Thread Fengguang Wu
sect good ff0c57ac70434bc936cb0110eaf033a0a1a62e52 # 04:19 60+ 5 Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid git bisect good d05446ae2128064a4bb8f74c84f6901ff

Re: [PATCH v5 3/4] usb: hcd: Caibrate PHY post hcd reset

2014-08-27 Thread Vivek Gautam
Hi, On Fri, Aug 22, 2014 at 4:19 PM, Andreas Färber wrote: > Hi, > > s/Caibrate/Calibrate/ Sure, will rectify the title, thanks for pointing it out. -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

[PATCH net-next v2] r8152: reduce the number of Tx

2014-08-27 Thread Hayes Wang
Because the Tx has the features of stopping queue and aggregation, We don't need many tx buffers. Change the tx number from 10 to 4 to reduce the usage of the memory. This could save 16K * 6 bytes memory. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH 1/5] usb: phy: twl4030-usb: Remove unused irq_enabled

2014-08-27 Thread Felipe Balbi
Hi, On Wed, Aug 27, 2014 at 04:28:07PM -0700, Tony Lindgren wrote: > It's not being used any longer. > > Signed-off-by: Tony Lindgren > --- > drivers/phy/phy-twl4030-usb.c | 2 -- > drivers/usb/phy/phy-twl6030-usb.c | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/phy/phy

[PATCH net-next] r8152: reduce the number of Tx

2014-08-27 Thread Hayes Wang
Because the Tx has the features of stopping queue and aggregation, We don't need many tx buffers. Change the tx number from 10 to 4 to reduce the usage of the memory. This could save 16K * 10 bytes memory. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 2 +- 1 file changed, 1 insertion(

Re: net: Add ops->ndo_xmit_flush()

2014-08-27 Thread David Miller
From: Dan Carpenter Date: Tue, 26 Aug 2014 15:21:37 +0300 > Hello David S. Miller, > > The patch 4798248e4e02: "net: Add ops->ndo_xmit_flush()" from Aug 22, > 2014, leads to the following static checker warning: > > drivers/usb/gadget/function/f_ncm.c:1104 ncm_tx_tasklet() > error:

Re: [PATCH] usb: gadget: net2280: Remove pci_class from PCI_TABLE

2014-08-27 Thread Greg Kroah-Hartman
On Wed, Aug 27, 2014 at 11:09:08PM +0200, Bjørn Mork wrote: > Greg Kroah-Hartman writes: > > On Wed, Aug 27, 2014 at 09:39:43PM +0200, Ricardo Ribalda Delgado wrote: > >> > >> return sprintf(buf, "pci:v%08Xd%08Xsv%08Xsd%08Xbc%02Xsc%02Xi%02x\n", > > That final 'x' does look like a typo, doesn't i

Re: [PATCH v7] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-27 Thread Wang YanQing
On Mon, Aug 18, 2014 at 12:07:20PM +0200, Johan Hovold wrote: > On Sun, Aug 17, 2014 at 10:05:36AM +0800, Wang YanQing wrote: > > Hi Johan Hovold. > > > > Another two questions. > > > > On Tue, Aug 12, 2014 at 04:46:25PM +0200, Johan Hovold wrote: > > > > > > > + int (*gpio_startup)(st

Re: Resend Re: [PATCH v6] usb:serial:pl2303: add GPIOs interface on PL2303

2014-08-27 Thread Wang YanQing
On Tue, Aug 12, 2014 at 04:02:59PM +0200, Johan Hovold wrote: > On Sat, Aug 09, 2014 at 02:46:56AM +0800, Wang YanQing wrote: > > On Fri, Aug 08, 2014 at 09:54:42AM +0200, Johan Hovold wrote: > > > On Fri, Aug 08, 2014 at 03:10:34AM +0800, Wang YanQing wrote: > > > > On Tue, Aug 05, 2014 at 03:54:0

[PATCH 2/5] usb: phy: twl4030-usb: Simplify phy init to use runtime PM

2014-08-27 Thread Tony Lindgren
We can now let the interrupt and delayed work do all that's needed with runtime PM. Signed-off-by: Tony Lindgren --- drivers/phy/phy-twl4030-usb.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb

[PATCH 0/5] Clean-up for twl4030-usb

2014-08-27 Thread Tony Lindgren
Hi, Here are few more patches for v3.18 to clean up twl4030-usb. These are based on the two regression fixes I sent earlier: [PATCH] usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps [PATCH] usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down For testing with v3.17-rc2

[PATCH 1/5] usb: phy: twl4030-usb: Remove unused irq_enabled

2014-08-27 Thread Tony Lindgren
It's not being used any longer. Signed-off-by: Tony Lindgren --- drivers/phy/phy-twl4030-usb.c | 2 -- drivers/usb/phy/phy-twl6030-usb.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c index 9cd33a4..bc28ecc 100644 --- a/dri

[PATCH 4/5] usb: phy: twl4030-usb: Remove asleep and rely on runtime PM

2014-08-27 Thread Tony Lindgren
There's no longer need for tracking the phy state in the driver with asleep, we can now rely on runtime PM. Signed-off-by: Tony Lindgren --- drivers/phy/phy-twl4030-usb.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/ph

[PATCH 3/5] usb: phy: twl4030-usb: Move code from twl4030_phy_power to the runtime PM calls

2014-08-27 Thread Tony Lindgren
We don't need twl4030_phy_power() any longer now that we have the runtime PM calls. Let's get rid of it as it's confusing. No functional changes, just move the code and use res instead of ret as we are not returning that value. Signed-off-by: Tony Lindgren --- drivers/phy/phy-twl4030-usb.c | 72

[PATCH 5/5] usb: phy: twl4030-usb: Use mutex instead of spinlock for protecting the data

2014-08-27 Thread Tony Lindgren
We're using threaded irq on a I2C bus and we're sleeping in twl4030_usb_irq() as it calls twl4030_usb_linkstat() which calls the i2c functions. If we ever need to lock for longer I2C transaction sequences a mutex will allow us to do that easily. Signed-off-by: Tony Lindgren --- drivers/phy/phy-t

Re: [PATCH net-next] r8152: replace strncpy with strlcpy

2014-08-27 Thread David Miller
From: Hayes Wang Date: Tue, 26 Aug 2014 10:08:23 +0800 > Replace the strncpy with strlcpy, and use sizeof to determine the > length. > > Signed-off-by: Hayes Wang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Stephen Warren
On 08/27/2014 03:56 PM, Andrew Bresticker wrote: On Wed, Aug 27, 2014 at 11:19 AM, Stephen Warren wrote: On 08/27/2014 12:13 PM, Andrew Bresticker wrote: On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren wrote: On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:0

Re: [PATCH] usb: host: xhci: fix compliance mode workaround

2014-08-27 Thread Greg KH
On Wed, Aug 27, 2014 at 04:38:04PM -0500, Felipe Balbi wrote: > Commit 71c731a (usb: host: xhci: Fix Compliance Mode > on SN65LVP3502CP Hardware) implemented a workaround > for a known issue with Texas Instruments' USB 3.0 > redriver IC but it left a condition where any xHCI > host would be taken o

Re: [RFC 1/2] USB: OTG: Hold wakeupsource when VBUS present

2014-08-27 Thread Todd Poynor
On Fri, Aug 22, 2014 at 10:12 AM, Felipe Balbi wrote: ... > you never explain why this is needed and you have also added some > information to commit log which shouldn't be here. Android uses this to prevent suspend from interfering with USB peripheral traffic, notably adb. The wakeup source is

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Andrew Bresticker
On Wed, Aug 27, 2014 at 11:19 AM, Stephen Warren wrote: > On 08/27/2014 12:13 PM, Andrew Bresticker wrote: >> >> On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren >> wrote: >>> >>> On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren >>>

[PATCH] usb: host: xhci: fix compliance mode workaround

2014-08-27 Thread Felipe Balbi
Commit 71c731a (usb: host: xhci: Fix Compliance Mode on SN65LVP3502CP Hardware) implemented a workaround for a known issue with Texas Instruments' USB 3.0 redriver IC but it left a condition where any xHCI host would be taken out of reset if port was placed in compliance mode and there was no devic

Re: [PATCH] usb: gadget: net2280: Remove pci_class from PCI_TABLE

2014-08-27 Thread Greg Kroah-Hartman
On Wed, Aug 27, 2014 at 11:03:00PM +0200, Ricardo Ribalda Delgado wrote: > Hello Greg > > >> > >> Not many drivers define the pci interface and there is no other driver > >> that has the same vendor and product id. Therefore I see no hurt in > >> adding both patches, one to make the driver broade

Re: [PATCH] usb: gadget: net2280: Remove pci_class from PCI_TABLE

2014-08-27 Thread Bjørn Mork
Greg Kroah-Hartman writes: > On Wed, Aug 27, 2014 at 09:39:43PM +0200, Ricardo Ribalda Delgado wrote: >> >> return sprintf(buf, "pci:v%08Xd%08Xsv%08Xsd%08Xbc%02Xsc%02Xi%02x\n", That final 'x' does look like a typo, doesn't it? We are otherwise consistently using upper-case hex digits for field

Re: [PATCH v4 1/3] usb: gadget: Refactor request completion

2014-08-27 Thread Greg Kroah-Hartman
On Wed, Aug 27, 2014 at 10:57:58PM +0200, Michal Sojka wrote: > All USB peripheral controller drivers called completion routines > directly. This patch moves the completion call from drivers to > usb_gadget_giveback_request(), in order to have a place where common > functionality can be added. > >

Re: [PATCH v4 3/3] usb: Add LED triggers for USB activity

2014-08-27 Thread Greg Kroah-Hartman
On Wed, Aug 27, 2014 at 10:58:00PM +0200, Michal Sojka wrote: > With this patch, USB activity can be signaled by blinking a LED. There > are two triggers, one for activity on USB host and one for USB gadget. > > Both trigger should work with all host/device controllers. Tested only > with musb. >

[PATCH 3/5] tools: ffs-test: add compatibility code for old kernels

2014-08-27 Thread Michal Nazarewicz
If ffs-test is used with a kernel prior to 3.14, which do not support the new descriptors format, it will fail when trying to write the descriptors. Add a function that converts the new descriptors to the legacy ones and use it to retry writing the descriptors using the legacy format. Also add “-

[PATCH 0/5] Small USB fixes/improvements

2014-08-27 Thread Michal Nazarewicz
Apparently I've slept over 3.17 merge window, so I guess this is for 3.18. Rebased on top of balbi/usb.git next. Michal Nazarewicz (4): usb: gadget: f_fs: add usb_functionfs_descs_head_v2 structure tools: ffs-test: convert to new descriptor format tools: ffs-test: add compatibility code for

[PATCH 4/5] usb: gadget: f_mass_storage: simplify start_transfer slightly

2014-08-27 Thread Michal Nazarewicz
Flatten the start_transfer function by reversing the if condition and returning early out of the function if everything went fine. It makes the function look less complicated, at least to me, and easier to understand. Signed-off-by: Michal Nazarewicz --- drivers/usb/gadget/function/f_mass_stora

[PATCH 1/5] usb: gadget: f_fs: add usb_functionfs_descs_head_v2 structure

2014-08-27 Thread Michal Nazarewicz
The structure can be used with user space tools that use the new functionfs description format, for example as follows: static const struct { struct usb_functionfs_descs_head_v2 header; __le32 fs_count; __le32 hs_count; struct { … } fs_desc;

[PATCH 5/5] USB:gadget: Fix a warning while loading g_mass_storage

2014-08-27 Thread Michal Nazarewicz
From: Yang Wei While loading g_mass_storage module, the following warning is triggered. WARNING: at drivers/usb/gadget/composite.c: usb_composite_setup_continue: Unexpected call Modules linked in: fat vfat minix nls_cp437 nls_iso8859_1 g_mass_storage [<800179cc>] (unwind_backtrace+0x0/0x104) fro

[PATCH 2/5] tools: ffs-test: convert to new descriptor format

2014-08-27 Thread Michal Nazarewicz
Since commit [ac8dde11: “Add flags to descriptors block”] functionfs supports a new, more powerful and extensible, descriptor format. Since ffs-test is probably the first thing users of the functionfs interface see when they start writing functionfs user space daemons, convert it to use the new for

Re: [PATCH] usb: gadget: net2280: Remove pci_class from PCI_TABLE

2014-08-27 Thread Ricardo Ribalda Delgado
Hello Greg >> >> Not many drivers define the pci interface and there is no other driver >> that has the same vendor and product id. Therefore I see no hurt in >> adding both patches, one to make the driver broader, and another to >> fix pci-sysfs. >> >> Also, the change on pci-sysfs might affect

Re: [PATCH v4 1/3] usb: gadget: Refactor request completion

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Michal Sojka wrote: > +/** > + * usb_gadget_giveback_request - give the request back to the gadget layer > + * Context: in_interrupt() > + * > + * This is called by device controller drivers in order to return the > + * completed request back to the gadget layer. > + */ > +voi

Re: [PATCH v2] usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1

2014-08-27 Thread Greg KH
On Wed, Aug 27, 2014 at 12:23:39PM -0700, Greg KH wrote: > On Wed, Aug 27, 2014 at 03:11:10PM +0300, Roger Quadros wrote: > > If user specifies that USB autosuspend must be disabled by module > > parameter "usbcore.autosuspend=-1" then we must prevent > > autosuspend of USB hub devices as well. > >

[PATCH v4 0/3] LED triggers for USB host and device

2014-08-27 Thread Michal Sojka
This adds LED triggers for USB host and device. First patch refactors UDC drivers as requested by Felipe Balbi, second is a preparation for the third, which adds the LED triggers. Changes from v3: - usb_gadget_giveback_request() moved outside of CONFIG_HAS_DMA conditioned block. - Added kernel-d

[PATCH v4 3/3] usb: Add LED triggers for USB activity

2014-08-27 Thread Michal Sojka
With this patch, USB activity can be signaled by blinking a LED. There are two triggers, one for activity on USB host and one for USB gadget. Both trigger should work with all host/device controllers. Tested only with musb. Signed-off-by: Michal Sojka --- drivers/usb/Kconfig | 11

[PATCH v4 1/3] usb: gadget: Refactor request completion

2014-08-27 Thread Michal Sojka
All USB peripheral controller drivers called completion routines directly. This patch moves the completion call from drivers to usb_gadget_giveback_request(), in order to have a place where common functionality can be added. All places in drivers/usb/ matching "[-.]complete(" were replaced with a

[PATCH v4 2/3] usb: Rename usb-common.c

2014-08-27 Thread Michal Sojka
In the next commit, we will want the usb-common module to be composed of two object files. Since Kbuild cannot "append" another object to an existing one, we need to rename usb-common.c to something else (common.c) and create usb-common.o by linking the wanted objects together. Currently, usb-commo

Re: [RFC PATCH 0/7] usb: gadget: add reset API at usb_gadget_driver

2014-08-27 Thread Felipe Balbi
On Wed, Aug 27, 2014 at 04:20:25PM -0400, Alan Stern wrote: > On Wed, 27 Aug 2014, Felipe Balbi wrote: > > > > Hi Alan & Felipe, > > > > > > During the changing UDC drivers process, I find we can't simply move > > > usb_gadget_disconnect to usb_gadget_driver.disconnect, some UDC > > > drivers (li

Re: [PATCH] usb: gadget: net2280: Remove pci_class from PCI_TABLE

2014-08-27 Thread Greg Kroah-Hartman
On Wed, Aug 27, 2014 at 09:39:43PM +0200, Ricardo Ribalda Delgado wrote: > Hello Greg > > > > > > On Wed, Aug 27, 2014 at 9:25 PM, Greg Kroah-Hartman > wrote: > > On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote: > >> Defining the vendor and the product id should be eno

Re: [RFC PATCH 0/7] usb: gadget: add reset API at usb_gadget_driver

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Felipe Balbi wrote: > > Hi Alan & Felipe, > > > > During the changing UDC drivers process, I find we can't simply move > > usb_gadget_disconnect to usb_gadget_driver.disconnect, some UDC > > drivers (like dwc3) will be no chance to set software pullup bit > > (dp control alwa

Re: [PATCH v3 1/2] usb: gadget: Refactor request completion

2014-08-27 Thread Felipe Balbi
On Wed, Aug 27, 2014 at 03:03:44PM +0200, Michal Sojka wrote: > All USB peripheral controller drivers called completion routines > directly. This patch moves the completion call from drivers to > usb_gadget_giveback_request(), in order to have a place where common > functionality can be added. > >

Re: [PATCH v3 1/2] usb: gadget: Refactor request completion

2014-08-27 Thread Michal Sojka
On Wed, Aug 27 2014, Michal Sojka wrote: > All USB peripheral controller drivers called completion routines > directly. This patch moves the completion call from drivers to > usb_gadget_giveback_request(), in order to have a place where common > functionality can be added. > > All places in drivers

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with >2TB HDDs)

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Dale R. Worley wrote: > What I find interesting is that Windows (at least, Windows 7 > Professional) seems to be able to handle the deficient adapter. So does Linux. The difference is that Windows believes the values in the partition table in preference to what the hardware

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with >2TB HDDs)

2014-08-27 Thread James Bottomley
On Wed, 2014-08-27 at 15:21 -0400, Dale R. Worley wrote: > > From: James Bottomley > > > Did you try read capacity 16 on it? What happened? (the AS2105 rejects > > read capacity 16, so there's no reliable way to deduce the capacity of > > drives over 2TB). > > OK, I had to track down which pac

Re: [PATCH] usb: gadget: net2280: Remove pci_class from PCI_TABLE

2014-08-27 Thread Ricardo Ribalda Delgado
Hello Greg On Wed, Aug 27, 2014 at 9:25 PM, Greg Kroah-Hartman wrote: > On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote: >> Defining the vendor and the product id should be enough to discriminate >> the device. >> >> The reason for this patch is that there is a missmat

Re: [RFC PATCH 0/7] usb: gadget: add reset API at usb_gadget_driver

2014-08-27 Thread Felipe Balbi
Hi, On Tue, Aug 26, 2014 at 03:30:32PM +0800, Peter Chen wrote: > On Mon, Aug 25, 2014 at 11:27:47AM -0400, Alan Stern wrote: > > On Mon, 25 Aug 2014, Peter Chen wrote: > > > > > Hi Felipe & Alan, > > > > > > It is the follow-up for: > > > http://www.spinics.net/lists/linux-usb/msg112193.html >

Re: [PATCH v3 2/2] usb: Add LED triggers for USB activity

2014-08-27 Thread Felipe Balbi
On Wed, Aug 27, 2014 at 12:27:51PM -0700, Greg Kroah-Hartman wrote: > On Wed, Aug 27, 2014 at 03:03:45PM +0200, Michal Sojka wrote: > > With this patch, USB activity can be signaled by blinking a LED. There > > are two triggers, one for activity on USB host and one for USB gadget. > > > > Both tri

Re: [PATCH] usb: dwc3: exynos: remove usb_phy_generic support

2014-08-27 Thread Felipe Balbi
Hi, On Wed, Aug 27, 2014 at 11:42:25PM +0530, Vivek Gautam wrote: > On Wed, Aug 27, 2014 at 1:22 PM, Bartlomiej Zolnierkiewicz > wrote: > > dwc3 driver is using the new Exynos5 SoC series USB DRD PHY driver > > (PHY_EXYNOS5_USBDRD which selects GENERIC_PHY) as can be seen by > > looking at the fo

Re: [PATCH v3 2/2] usb: Add LED triggers for USB activity

2014-08-27 Thread Greg Kroah-Hartman
On Wed, Aug 27, 2014 at 03:03:45PM +0200, Michal Sojka wrote: > With this patch, USB activity can be signaled by blinking a LED. There > are two triggers, one for activity on USB host and one for USB gadget. > > Both trigger should work with all host/device controllers. Tested only > with musb. >

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Jassi Brar
On 27 August 2014 23:08, Andrew Bresticker wrote: > On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren > wrote: >> I'm not even sure if it's appropriate for the low-level mailbox driver to >> know about the semantics of the message, rather than simply sending them on >> to the client driver? Perh

Re: [PATCH] usb: gadget: net2280: Remove pci_class from PCI_TABLE

2014-08-27 Thread Greg Kroah-Hartman
On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote: > Defining the vendor and the product id should be enough to discriminate > the device. > > The reason for this patch is that there is a missmatch betweed the > modalias showed by sysfs and the modalias generated by file2alia

Re: [PATCH v2 5/5] usb: phy: samsung: remove old common USB PHY code

2014-08-27 Thread Felipe Balbi
Hi, On Fri, Aug 22, 2014 at 06:59:05PM +0200, Bartlomiej Zolnierkiewicz wrote: > drivers/usb/phy/phy-samsung-usb[2,3] drivers got replaced by > drivers/phy/phy-samsung-usb[2,3] ones and the old common Samsung > USB PHY code is no longer used. > > Signed-off-by: Bartlomiej Zolnierkiewicz > Acked-

Re: [PATCH v2] usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1

2014-08-27 Thread Greg KH
On Wed, Aug 27, 2014 at 03:11:10PM +0300, Roger Quadros wrote: > If user specifies that USB autosuspend must be disabled by module > parameter "usbcore.autosuspend=-1" then we must prevent > autosuspend of USB hub devices as well. > > commit 596d789a211d introduced in v3.8 changed the original beh

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with >2TB HDDs)

2014-08-27 Thread Dale R. Worley
What I find interesting is that Windows (at least, Windows 7 Professional) seems to be able to handle the deficient adapter. What I'd like to do is log the disk commands during the mounting sequence, preferably at both the SCSI and USB layers. Then at least we'll know exactly what the driver is d

Re: [PATCH v2 0/5] usb: phy: samsung: remove old USB PHY code

2014-08-27 Thread Felipe Balbi
Hi, On Fri, Aug 22, 2014 at 06:59:00PM +0200, Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patch series removes the old Samsung USB PHY drivers that > got replaced by the new ones using the generic PHY layer. > > Depends on: > - v3.17-rc1 branch of Linus' kernel > > Changes since v1 (https:/

Re: [PATCH 02/13] usb: udc: set the udc is ready to pullup dp when it needs

2014-08-27 Thread Felipe Balbi
On Wed, Aug 20, 2014 at 01:30:40PM +0800, Peter Chen wrote: > On Tue, Aug 19, 2014 at 09:02:54PM +, Paul Zimmerman wrote: > > > From: linux-usb-ow...@vger.kernel.org > > > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Peter Chen > > > Sent: Tuesday, August 19, 2014 7:26 AM > > > > > >

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with >2TB HDDs)

2014-08-27 Thread Dale R. Worley
> From: James Bottomley > Did you try read capacity 16 on it? What happened? (the AS2105 rejects > read capacity 16, so there's no reliable way to deduce the capacity of > drives over 2TB). OK, I had to track down which package contains sg_readcap. The adapter that fails gives this output:

Re: [PATCH] usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1

2014-08-27 Thread Greg KH
On Wed, Aug 27, 2014 at 01:31:24PM +0300, Roger Quadros wrote: > On 08/04/2014 05:07 PM, Alan Stern wrote: > > On Mon, 4 Aug 2014, Roger Quadros wrote: > > > >> If user specifies that USB autosuspend must be disabled by module > >> parameter "usbcore.autosuspend=-1" then we must prevent > >> autos

Re: [PATCH v6 2/3] usb: gadget: f_fs: add ioctl returning ep descriptor

2014-08-27 Thread Felipe Balbi
Hi, On Mon, Aug 25, 2014 at 11:16:28AM +0200, Robert Baldyga wrote: > This patch introduces ioctl named FUNCTIONFS_ENDPOINT_DESC, which > returns endpoint descriptor to userspace. It works only if function > is active. > > Signed-off-by: Robert Baldyga > Acked-by: Michal Nazarewicz > --- > dri

Re: [RFC 2/2] usb: otg: Temporarily hold wakeupsource on charger and disconnect events

2014-08-27 Thread Felipe Balbi
On Fri, Aug 22, 2014 at 03:20:00PM +0530, Kiran Kumar Raparthy wrote: > From: Todd Poynor > > usb: otg: Temporarily hold wakeupsource on charger and disconnect events > > Allow other parts of the system to react to the charger connect/disconnect > event without allowing the system to suspend bef

Re: [PATCH 2/2] doc: dt: mxs-phy: add compatible string for imx6sx-usbphy

2014-08-27 Thread Felipe Balbi
On Tue, Aug 26, 2014 at 10:55:18AM +0800, Peter Chen wrote: > Add compatible string for imx6sx-usbphy. > > Signed-off-by: Peter Chen do I need to take this one as well or will DT folks take care of patch 2 ? -- balbi signature.asc Description: Digital signature

Re: [PATCH] usb: gadget: composite: dequeue cdev->req before free its buffer

2014-08-27 Thread Felipe Balbi
Hi, On Mon, Aug 25, 2014 at 04:49:12PM +0800, Li Jun wrote: > As Felipe suggested, dequeue the cdev->req before free its buffer. > > Suggested-by: Felipe Balbi > Signed-off-by: Li Jun please read Documentation/SubmittingPatches. Your commit log does not make sense. You need to explain why the

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Stephen Warren
On 08/27/2014 12:13 PM, Andrew Bresticker wrote: On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren wrote: On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: +static int tegra_xusb_mbox_p

Re: [PATCH] usb: dwc3: exynos: remove usb_phy_generic support

2014-08-27 Thread Vivek Gautam
Hi Baltlomiej, On Wed, Aug 27, 2014 at 1:22 PM, Bartlomiej Zolnierkiewicz wrote: > dwc3 driver is using the new Exynos5 SoC series USB DRD PHY driver > (PHY_EXYNOS5_USBDRD which selects GENERIC_PHY) as can be seen by > looking at the following commits: > > 7a4cf0fde054 ("ARM: dts: Update DWC3

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Andrew Bresticker
On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren wrote: > On 08/27/2014 11:38 AM, Andrew Bresticker wrote: >> >> On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren >> wrote: >>> >>> On 08/18/2014 11:08 AM, Andrew Bresticker wrote: +static int tegra_xusb_mbox_probe(struct platform_device *

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Stephen Warren
On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a single

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Andrew Bresticker
On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren wrote: > On 08/18/2014 11:08 AM, Andrew Bresticker wrote: >> >> The Tegra xHCI controller's firmware communicates requests to the host >> processor through a mailbox interface. While there is only a single >> communication channel, messages sent by

Re: [xhci] BUG: unable to handle kernel NULL pointer dereference at (null)

2014-08-27 Thread Dan Williams
2cab81d794db4e5fe919c4e1d624ea7] xhci: unit > test ring enqueue/dequeue routines > git bisect good fb6fa3e625e1e453aea9eeb97d58bee30e1c0781 # 00:00 60+ > 0 xhci: v1.0 scatterlist enqueue support (td-fragment rework) > git bisect bad 66e8dfa4e0d9600dedc08adcaac83c378b65351b # 00:00 0- > 1

[PATCH v6 1/5] usb: gadget: f_uac2: restructure some code in afunc_set_alt()

2014-08-27 Thread Daniel Mack
Restructure some code to make it easier to read. While at it, return -ENOMEM instead of -EINVAL if usb_ep_alloc_request() fails, and omit the logging in such cases (the mm core will complain loud enough). Signed-off-by: Daniel Mack --- drivers/usb/gadget/function/f_uac2.c | 39 +++--

[PATCH v6 4/5] usb: gadget: f_uac2: handle partial dma area wrap

2014-08-27 Thread Daniel Mack
With packet sizes other than 512, payloads in the packets may wrap around the ALSA dma buffer partially, which leads to memory corruption and audible clicks and pops in the audio stream at the moment, because there is no boundary check before the memcpy(). In preparation to an implementation for s

[PATCH v6 0/5] usb: gadget: f_uac2: cleanups and capture timing

2014-08-27 Thread Daniel Mack
Hi, this is v6 of the f_uac2 timing fixup series. Changes from v5: * Pre-calculate some more variables so we have to do their computation at runtime for each frame Changes from v4: * Fix buffer setup in afunc_set_alt() Changes from v3: * add another patch (3

[PATCH v6 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Daniel Mack
The UAC2 function driver currently responds to all packets at all times with wMaxPacketSize packets. That results in way too fast audio playback as the function driver (which is in fact supposed to define the audio stream pace) delivers as fast as it can. Fix this by sizing each packet correctly w

[PATCH v6 2/5] usb: gadget: f_uac2: add short-hand for 'dev'

2014-08-27 Thread Daniel Mack
In afunc_bind() and afunc_set_alt(), &uac2->pdev.dev are used multiple times. Adding a short-hand for them makes lines shorter so we can remove some line wraps. No functional change. Signed-off-by: Daniel Mack --- drivers/usb/gadget/function/f_uac2.c | 29 +++-- 1 file c

[PATCH v6 3/5] usb: gadget: f_uac2: introduce agdev_to_uac2_opts

2014-08-27 Thread Daniel Mack
Add a simple container_of() wrapper to get a struct f_uac2_opts from a struct struct audio_dev. Use it in two places where it is currently open-coded. Signed-off-by: Daniel Mack --- drivers/usb/gadget/function/f_uac2.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

Re: About the reboot hang issue with EHCI driver on the Baytrail platform

2014-08-27 Thread Gavin Guo
Hi Alan, On Wed, Aug 27, 2014 at 10:38 PM, Alan Stern wrote: > On Wed, 27 Aug 2014, Gavin Guo wrote: > >> > Still, why not use the BIOS setting to disable EHCI? >> >> It's hardware enablement policy. By default, we can't change the BIOS >> setting to make the bug disappear until we find out the b

Re: [PATCH v5 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Daniel Mack
On 08/27/2014 04:18 PM, Alan Stern wrote: > On Wed, 27 Aug 2014, Daniel Mack wrote: >> +/* >> + * Whenever there are more bytes in the accumulator than we >> + * need to add one more sample frame, increase this packet's >> + * size and decrease the a

Re: [PATCH v2 3/9] of: Update Tegra XUSB pad controller binding for USB

2014-08-27 Thread Andrew Bresticker
On Mon, Aug 25, 2014 at 12:12 PM, Stephen Warren wrote: > On 08/18/2014 11:08 AM, Andrew Bresticker wrote: >> - #phy-cells: Should be 1. The specifier is the index of the PHY to >> reference. >> See for the list of valid >> values. >> +- mboxes: Must contain an entry for the XUSB PHY mailbo

Re: [PATCH v2 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-08-27 Thread Andrew Bresticker
On Mon, Aug 25, 2014 at 12:22 PM, Stephen Warren wrote: > On 08/18/2014 11:08 AM, Andrew Bresticker wrote: >> >> In addition to the PCIe and SATA PHYs, the XUSB pad controller also >> supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single >> PCIe or SATA lane and is mapped to one o

Re: [PATCH v2 3/9] of: Update Tegra XUSB pad controller binding for USB

2014-08-27 Thread Stephen Warren
On 08/27/2014 10:36 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:12 PM, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: - #phy-cells: Should be 1. The specifier is the index of the PHY to reference. See for the list of valid values. +- mboxes: Must co

Re: [PATCH v2 1/9] of: Add NVIDIA Tegra XUSB mailbox binding

2014-08-27 Thread Andrew Bresticker
On Mon, Aug 25, 2014 at 11:48 AM, Stephen Warren wrote: > On 08/18/2014 11:08 AM, Andrew Bresticker wrote: > >> diff --git a/include/dt-bindings/mailbox/tegra-xusb-mailbox.h >> b/include/dt-bindings/mailbox/tegra-xusb-mailbox.h > > >> +#define TEGRA_XUSB_MBOX_CHAN_HOST 0 >> +#define TEGRA_XUS

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-27 Thread Ricardo Ribalda Delgado
Perhaps we could apply both patches to current tree and backport mine to older kernels? On Wed, Aug 27, 2014 at 5:27 PM, Mathias Nyman wrote: > On 08/27/2014 05:14 PM, Ricardo Ribalda Delgado wrote: >> At least I have seen the issue on Debian 3.14 and 3.16. Is your patch >> going to be backported

Status of g_webcam uvc-gadget

2014-08-27 Thread Ricardo Ribalda Delgado
Hello Is somebody using/supporting g_webcam? The only reference userland server is uvc-gadget from http://git.ideasonboard.org/?p=uvc-gadget.git;a=summary ? I have an industrial fpga camera that speaks v4l2, my plan is to export it as an uvc camera via usb3380 as a debug interface. Thanks! --

Re: [PATCH 0/7] g_webcam: Preparation for configfs

2014-08-27 Thread Andrzej Pietrasiewicz
W dniu 18.08.2014 o 21:45, Laurent Pinchart pisze: Hi Andrzej, Thank you for the patches. The series looks good, I only had a few comments. I have rebased the patches on top of my UVC gadget branch, addressed my comments (the modified patches are marked as such in the commit message) and pushed

Re: [PATCH v3 0/4] usb: gadget: f_uac2: cleanups and capture timing

2014-08-27 Thread Sebastian Reimers
Hi Xuebing, > Would you mind to share how did you run the test for both > Playback/Capture? What host version are you using, as different Host > enumerates (sends sequences of USB_REQ_SET_INTERFACE request differently)? sure, on client side (BBB) I have a jackd on top alsa running and connected

[PATCH] usb: gadget: f_uvc fix transition to video_ioctl2

2014-08-27 Thread Andrzej Pietrasiewicz
UVC video node is a TX device from the point of view of the gadget, so we cannot rely on the video struct being filled with zeros, because VFL_DIR_TX is actually 1. Suggested-by: Sylwester Nawrocki Signed-off-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_uvc.c | 1 + 1 file change

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-27 Thread Mathias Nyman
On 08/27/2014 05:14 PM, Ricardo Ribalda Delgado wrote: > At least I have seen the issue on Debian 3.14 and 3.16. Is your patch > going to be backported to linux-stable? The computer crashes very very > badly > Yes, it is, but it might need some additional work as it won't apply cleanly on older

Re: [PATCH v3 1/2] usb: gadget: Refactor request completion

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Michal Sojka wrote: > All USB peripheral controller drivers called completion routines > directly. This patch moves the completion call from drivers to > usb_gadget_giveback_request(), in order to have a place where common > functionality can be added. > > All places in drive

Re: Buffer I/O error after s2ram with usb storage

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Douglas Gilbert wrote: > The unit attention doesn't look like a problem, it > looks correct. If the system is unable to detect > removable media being changed while the system is > suspended, then > > If the media has a unique identifier, then this unit > attention at wa

Re: Buffer I/O error after s2ram with usb storage

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Matthieu CASTET wrote: > Ping > > I have got also a problem with a usb sdcard reader (without power cut > during suspend) > > > The usb storage driver call scsi_report_bus_reset after device reset, > > > but because of commit dfcf7775 <4>, we don't ignore unit attention if >

Re: RES: RES: AS2105-based enclosure size issues with >2TB HDDs

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Oliver Neukum wrote: > > I don't think we want to add another SCSI flag to say that READ > > CAPACITY(10) is unreliable. > > Why not? It would only be friendly to tell the upper layer > of a malfunction if we know about it. To what end? What will the upper layer do with thi

Re: About the reboot hang issue with EHCI driver on the Baytrail platform

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Gavin Guo wrote: > > Still, why not use the BIOS setting to disable EHCI? > > It's hardware enablement policy. By default, we can't change the BIOS > setting to make the bug disappear until we find out the bug is due to > BIOS's bug. Add kernel parameters is the temporary sol

Re: [PATCH v5 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Daniel Mack wrote: > The UAC2 function driver currently responds to all packets at all times > with wMaxPacketSize packets. That results in way too fast audio > playback as the function driver (which is in fact supposed to define > the audio stream pace) delivers as fast as it

Re: [PATCH 3/3] xhci: rework cycle bit checking for new dequeue pointers

2014-08-27 Thread Joseph Salisbury
On 08/27/2014 07:07 AM, Mathias Nyman wrote: > On 08/21/2014 01:06 AM, Joseph Salisbury wrote: >> On 08/19/2014 08:17 AM, Mathias Nyman wrote: >>> When we manually need to move the TR dequeue pointer we need to set the >>> correct cycle bit as well. Previously we used the trb pointer from the >>> l

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-27 Thread Ricardo Ribalda Delgado
At least I have seen the issue on Debian 3.14 and 3.16. Is your patch going to be backported to linux-stable? The computer crashes very very badly On Wed, Aug 27, 2014 at 4:25 PM, Mathias Nyman wrote: > On 08/26/2014 06:47 PM, Ricardo Ribalda Delgado wrote: >> While testing a usb gadget I managed

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-27 Thread Mathias Nyman
On 08/26/2014 06:47 PM, Ricardo Ribalda Delgado wrote: > While testing a usb gadget I managed to crash completely the host > computer. This was due to a NULL pointer derefence. > > This patch avoids the crash although the kernel still outputs some > warnings. > > Without this patch, kernels from

Re: Buffer I/O error after s2ram with usb storage

2014-08-27 Thread Douglas Gilbert
On 14-08-27 04:40 AM, Matthieu CASTET wrote: Ping I have got also a problem with a usb sdcard reader (without power cut during suspend) [ 1073.606668] PM: Entering mem sleep [ 1073.606742] Suspending console(s) (use no_console_suspend to debug) [ 1073.607146] sd 1:0:0:0: [sda] Synchronizing SCS

[PATCH v3 0/2] LED triggers for USB host and device

2014-08-27 Thread Michal Sojka
This adds LED triggers for USB host and device. First patch refactors UDC drivers as requested by Felipe Balbi, second patch adds the LED triggers. Changes from v2: - host/gadget triggers merged to a single file in usb/common/ - udc drivers refactored so that LED trigger works for all of them Cha

  1   2   >