Re: [PATCH] staging: usbip: fixed a coding-style warning

2014-06-17 Thread Alexey Tulia
On Tue, Jun 17, 2014 at 03:44:58PM -0700, Greg Kroah-Hartman wrote: > On Fri, Jun 13, 2014 at 11:35:13AM +0300, Alexey Tulia wrote: > > This fixes the following warning: > > - WARNING: __constant_cpu_to_le32 should be cpu_to_le32 > > What produces this warning? > This warning was found by ch

[PATCH v1 0/9] Tegra XHCI support

2014-06-17 Thread Andrew Bresticker
This series adds support for XHCI on NVIDIA Tegra SoCs. This includes: - extending the XUSB pad controller driver to support the USB PHY types (UTMI, HSIC, and USB3), - adding a driver for the mailbox used to communicate with the XHCI controller's firmware, and - adding a XHCI host-contro

[PATCH v1 1/9] of: Add NVIDIA Tegra XUSB mailbox binding

2014-06-17 Thread Andrew Bresticker
Add device-tree bindings for the Tegra XUSB mailbox which will be used for communication between the Tegra XHCI controller and the host. Signed-off-by: Andrew Bresticker --- .../bindings/mailbox/nvidia,tegra124-xusb-mbox.txt | 25 ++ 1 file changed, 25 insertions(+) create m

[PATCH v1 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-06-17 Thread Andrew Bresticker
The Tegra XHCI controller communicates requests to the host through a mailbox interface. Host drivers which can handle these requests, such as the Tegra XUSB pad controller driver and upcoming Tegra XHCI host controller driver, can send messages and register to be notified of incoming messages. S

[PATCH v1 3/9] of: Update Tegra XUSB pad controller binding for USB

2014-06-17 Thread Andrew Bresticker
Add new bindings used for USB support by the Tegra XUSB pad controller. This includes additional PHY types, USB-specific pinconfig properties, etc. Signed-off-by: Andrew Bresticker --- .../pinctrl/nvidia,tegra124-xusb-padctl.txt| 53 -- include/dt-bindings/pinctrl/pin

[PATCH v1 5/9] of: Add NVIDIA Tegra XHCI controller binding

2014-06-17 Thread Andrew Bresticker
Add device-tree binding documentation for the XHCI controller present on Tegra124 and later SoCs. Signed-off-by: Andrew Bresticker --- .../bindings/usb/nvidia,tegra124-xhci.txt | 76 ++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/devicetree/bi

[PATCH v1 6/9] usb: xhci: Add NVIDIA Tegra XHCI host-controller driver

2014-06-17 Thread Andrew Bresticker
Add support for the on-chip XHCI host controller present on Tegra SoCs. The driver is currently very basic: it loads the controller with its firmware, starts the controller, and is able to service messages sent by the controller's firmware. The hardware supports device mode as well as runtime pow

[PATCH v1 7/9] ARM: tegra: Add Tegra124 XUSB mailbox and XHCI controller

2014-06-17 Thread Andrew Bresticker
Add nodes for the Tegra XUSB mailbox and Tegra XHCI controller. Update the XUSB pad controller node with a phandle to the XUSB mailbox. Signed-off-by: Andrew Bresticker --- arch/arm/boot/dts/tegra124.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/a

[PATCH v1 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-06-17 Thread Andrew Bresticker
In addition to the PCIe and SATA PHYs, the XUSB pad controller also supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single PCIe or SATA lane and is mapped to one of the three UTMI ports. Signed-off-by: Andrew Bresticker --- drivers/pinctrl/pinctrl-tegra-xusb.c | 1106

[PATCH v1 8/9] ARM: tegra: jetson-tk1: Add XHCI support

2014-06-17 Thread Andrew Bresticker
Assign USB ports previously owned by the EHCI controllers to the XHCI controller. There is a mini-PCIe USB port (UTMI port 1) and a USB A connector (UTMI port 2, USB3 port 0). PCIe lane 0 is used for USB3 port 0. Signed-off-by: Andrew Bresticker --- arch/arm/boot/dts/tegra124-jetson-tk1.dts |

[PATCH v1 9/9] ARM: tegra: venice2: Add XHCI support

2014-06-17 Thread Andrew Bresticker
Assign ports previously owned by the EHCI controllers to the XHCI controller. There are two external USB ports (UTMI ports 0/2 and USB3 ports 0/1) and an internal USB port (UTMI port 1). PCIe lanes 0 and 1 are used by the USB3 ports. Signed-off-by: Andrew Bresticker --- arch/arm/boot/dts/tegra

Re: [PATCH v6 1/1] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-06-17 Thread Magnus Damm
Hi Felipe, On Fri, Jun 13, 2014 at 11:25 PM, Felipe Balbi wrote: > Hi, > > On Fri, Jun 13, 2014 at 09:20:31PM +0900, Yoshihiro Shimoda wrote: >> The R-Car H2 and M2 SoCs come with an xHCI controller that requires >> some specific initializations related to the firmware downloading and >> some spe

[PATCH 2/2] usb: phy: tegra: Make of_device_id array const

2014-06-17 Thread Jingoo Han
Make of_device_id array const, because all OF functions handle it as const. Signed-off-by: Jingoo Han --- drivers/usb/phy/phy-tegra-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c index bbe4f8e..cd36cb

[PATCH 1/2] usb: phy: msm: Make of_device_id array const

2014-06-17 Thread Jingoo Han
Make of_device_id array const, because all OF functions handle it as const. Signed-off-by: Jingoo Han --- drivers/usb/phy/phy-msm-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index ced34f3..625c144 1006

[PATCH 2/2] usb: gadget: lpc32xx_udc: Make of_device_id array const

2014-06-17 Thread Jingoo Han
Make of_device_id array const, because all OF functions handle it as const. Signed-off-by: Jingoo Han --- drivers/usb/gadget/lpc32xx_udc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c index e471580..c77

[PATCH 1/2] usb: gadget: gr_udc: Make of_device_id array const

2014-06-17 Thread Jingoo Han
Make of_device_id array const, because all OF functions handle it as const. Signed-off-by: Jingoo Han --- drivers/usb/gadget/gr_udc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/gr_udc.c b/drivers/usb/gadget/gr_udc.c index 99a37ed..5d93f2b 100644 ---

[PATCH 4/4] USB: ohci-spear: Make of_device_id array const

2014-06-17 Thread Jingoo Han
Make of_device_id array const, because all OF functions handle it as const. Signed-off-by: Jingoo Han --- drivers/usb/host/ohci-spear.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-spear.c b/drivers/usb/host/ohci-spear.c index 8b29a0c..8d58766 1006

[PATCH 3/4] USB: ehci-tegra: Make of_device_id array const

2014-06-17 Thread Jingoo Han
Make of_device_id array const, because all OF functions handle it as const. Signed-off-by: Jingoo Han --- drivers/usb/host/ehci-tegra.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index 6fdcb8a..c303371 1006

[PATCH 2/4] USB: ehci-spear: Make of_device_id array const

2014-06-17 Thread Jingoo Han
Make of_device_id array const, because all OF functions handle it as const. Signed-off-by: Jingoo Han --- drivers/usb/host/ehci-spear.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c index 1d59958..1355ff0 1006

[PATCH 1/4] USB: ehci-msm: Make of_device_id array const

2014-06-17 Thread Jingoo Han
Make of_device_id array const, because all OF functions handle it as const. Signed-off-by: Jingoo Han --- drivers/usb/host/ehci-msm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index 982c09b..934b39d 100644 ---

Re: [bisected][regression] USB Ethernet Gadget Support - Freescale 8308

2014-06-17 Thread Felipe Balbi
Hi, On Tue, Jun 17, 2014 at 04:04:04PM -0700, Barry G wrote: > Hi all, > > We have a custom board that has been running on the v3.0 kernel > for a while. Since that kernel version is deprecated we are working > on upgrading to the 3.10 kernel (some products are 3.10-ltsi so trying 3.10 is a pre

Re: [PATCH] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-17 Thread Yang,Wei
On 06/17/2014 10:18 PM, Alan Stern wrote: That is a strange question to ask. If you did not know that I approved the patch, why did you insert my Acked-By:? I added your Acked-By, as when you reviewed V3, you mentioned that I *may* add your Acked-by in this patch. If I misunderstood your poin

Re: [PATCH 0/3] port power control fixes for 3.16-rc2

2014-06-17 Thread Dan Williams
On Tue, Jun 17, 2014 at 5:06 PM, Greg KH wrote: > On Tue, Jun 17, 2014 at 04:16:16PM -0700, Dan Williams wrote: >> Fallout / regression fixes for the port power control rework that landed >> in 3.16-rc1. >> >> 1/ Cosmetic fix to an error message >> >> 2/ Handle ACPI port-location-data conflicts by

Re: [PATCH v3 0/2] Fix subject line

2014-06-17 Thread Davidlohr Bueso
On Mon, 2014-06-16 at 00:28 +0400, Wahib wrote: > Hi Davidlohr! > > Don't worry. I am not discouraged. :) > > I understand your concern that the patch feels superficial. It's what the task > asked us to do. I suspect the author(s) of the Eudyptula Challenge designed > this task to get us involved

Re: [PATCH 0/3] port power control fixes for 3.16-rc2

2014-06-17 Thread Greg KH
On Tue, Jun 17, 2014 at 04:16:16PM -0700, Dan Williams wrote: > Fallout / regression fixes for the port power control rework that landed > in 3.16-rc1. > > 1/ Cosmetic fix to an error message > > 2/ Handle ACPI port-location-data conflicts by disabling port power off >rather than spewing a ba

[PATCH 3/3] usb: fix hub-port pm_runtime_enable() vs runtime pm transitions

2014-06-17 Thread Dan Williams
Commit 9262c19d14c4 "usb: disable port power control if not supported in wHubCharacteristics" gated enabling runtime pm for usb_port devices on whether the parent hub supports power control, which causes a regression. The port must still be allowed to carry out runtime pm callbacks and receive a -

[PATCH 1/3] usb: improve "not suspended yet" message in hub_suspend()

2014-06-17 Thread Dan Williams
Reading through a recent bug report [1], Alan notes: "Dan, the warning message in hub_suspend() should mention that the child device isn't suspended yet." ...update the warning from: "usb usb3-port4: not suspended yet" ...to: "usb usb3-port4: device 3-4: not suspended yet" [1]: http

[PATCH 2/3] usb: quiet peer failure warning, disable poweroff

2014-06-17 Thread Dan Williams
In the case where platform firmware has specified conflicting values for port locations it is confusing and otherwise not helpful to throw a backtrace. Instead, include enough information to determine that firmware has done something wrong and globally disable port poweroff. Signed-off-by: Dan Wi

[PATCH 0/3] port power control fixes for 3.16-rc2

2014-06-17 Thread Dan Williams
Fallout / regression fixes for the port power control rework that landed in 3.16-rc1. 1/ Cosmetic fix to an error message 2/ Handle ACPI port-location-data conflicts by disabling port power off rather than spewing a backtrace and trying to continue. 3/ Handle hubs that do not support port pow

[bisected][regression] USB Ethernet Gadget Support - Freescale 8308

2014-06-17 Thread Barry G
Hi all, We have a custom board that has been running on the v3.0 kernel for a while. Since that kernel version is deprecated we are working on upgrading to the 3.10 kernel (some products are 3.10-ltsi so trying to be common). Everything is now working except the USB gadget support. This is a Fr

Re: [PATCH] staging: usbip: fixed a coding-style warning

2014-06-17 Thread Greg Kroah-Hartman
On Fri, Jun 13, 2014 at 11:35:13AM +0300, Alexey Tulia wrote: > This fixes the following warning: > - WARNING: __constant_cpu_to_le32 should be cpu_to_le32 What produces this warning? > > Signed-off-by: Alexey Tulia > --- > drivers/staging/usbip/vhci_hcd.c | 2 +- > 1 file changed, 1 ins

usb/gadget/gr_udc.c:1528: possible bad test ?

2014-06-17 Thread David Binderman
Hello there, [linux-3.16-rc1/drivers/usb/gadget/gr_udc.c:1528] -> [linux-3.16-rc1/drivers/usb/gadget/gr_udc.c:1535]: (style) Mismatching assignment and comparison, comparison 'nt==17' is always false. Source code is nt = 0x3 & (usb_endpoint_maxp(desc)>> 11); buffer_size = GR_BUFFER_SI

Re: [PATCH] USB: EHCI: tegra: Fix use-after-free in .remove()

2014-06-17 Thread Alan Stern
On Tue, 17 Jun 2014, Stephen Warren wrote: > On 06/17/2014 08:17 AM, Tuomas Tynkkynen wrote: > > The tegra_ehci_hcd structure is located in the private space allocated > > by the core USB code so it must not be accessed after the HCD is > > freed. > > > diff --git a/drivers/usb/host/ehci-tegra.c

Support for URB_ZERO_PACKET flag in XHCI

2014-06-17 Thread hemantk
Hi Sarah, Looks like XHCI is not honoring URB_ZERO_PACKET flag set by class drivers. I came across a patch from David Laight dated Nov 2013. But i couldn't find it in latest kernel tree. Are you planning to add support using David's patch (or any other patch) in near future? From current implement

Re: [PATCH] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-17 Thread Michal Nazarewicz
On Sun, Jun 15 2014, wei.y...@windriver.com wrote: > From: Yang Wei > > While loading g_mass_storage module, the following warning > is triggered. > > WARNING: at drivers/usb/gadget/composite.c: > usb_composite_setup_continue: Unexpected call > Modules linked in: fat vfat minix nls_cp437 nls_iso88

Re: xhci handling ring expansion

2014-06-17 Thread vichy
hi david: 2014-06-17 23:50 GMT+08:00 David Laight : > From: vichy >> hi david: >> >> >> platform-xhci platform-xhci.0: ERROR no room on ep ring, try ring >> >> expansion >> >> platform-xhci platform-xhci.0: ring expansion succeed, now has 4 segments >> >> platform-xhci platform-xhci.0: ERROR Tra

[PATCH v8] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-17 Thread Janne Kanniainen
This driver adds support for USB controlled led panels that exists in MSI GT683R laptop Changes in v2: - sorted headers to alphabetic order - using devm_kzalloc - using BIT(n) - using usb_control_msg instead of usb_submit_urb - removing unneeded code Changes

Re: usb audio breaks ohci-pci

2014-06-17 Thread Dennis New
On Thu, 12 Jun 2014 10:20:54 -0400 (EDT), Alan Stern wrote: > Dennis and Matteo: > > I promised to send both of you a patch changing the way ohci-hcd > handles hardware bugs. Well, it's finally ready for testing. There's > only a limited amount I can do on my own machine, so now it's up to > you

Re: [PATCH] USB: EHCI: tegra: Fix use-after-free in .remove()

2014-06-17 Thread Stephen Warren
On 06/17/2014 08:17 AM, Tuomas Tynkkynen wrote: > The tegra_ehci_hcd structure is located in the private space allocated > by the core USB code so it must not be accessed after the HCD is > freed. > diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c This seems to be a pers

RE: xhci handling ring expansion

2014-06-17 Thread David Laight
From: vichy > hi david: > > >> platform-xhci platform-xhci.0: ERROR no room on ep ring, try ring expansion > >> platform-xhci platform-xhci.0: ring expansion succeed, now has 4 segments > >> platform-xhci platform-xhci.0: ERROR Transfer event TRB DMA ptr not > >> part of current TD > >> > >> und

[PATCH] usb: gadget: f_fs: fix NULL pointer dereference when there are no strings

2014-06-17 Thread Michal Nazarewicz
If the descriptors do not need any strings and user space sends empty set of strings, the ffs->stringtabs field remains NULL. Thus *ffs->stringtabs in functionfs_bind leads to a NULL pointer dereferenece. The bug was introduced by commit [fd7c9a007f: “use usb_string_ids_n()”]. While at it, remov

Re: [PATCH v2 1/1] xhci: clear root port wake on bits if controller isn't wake-up capable

2014-06-17 Thread Mathias Nyman
On 06/13/2014 03:06 AM, Lu Baolu wrote: > When xHCI PCI host is suspended, if do_wakeup is false in xhci_pci_suspend, > xhci_bus_suspend needs to clear all root port wake on bits. Otherwise some > Intel > platforms may get a spurious wakeup, even if PCI PME# is disabled. > > This patch should be

Re: xhci handling ring expansion

2014-06-17 Thread vichy
hi david: >> platform-xhci platform-xhci.0: ERROR no room on ep ring, try ring expansion >> platform-xhci platform-xhci.0: ring expansion succeed, now has 4 segments >> platform-xhci platform-xhci.0: ERROR Transfer event TRB DMA ptr not >> part of current TD >> >> under what circumstance the cont

[PATCH 1/8] r8a66597-udc: use devm_request_and_ioremap() for registers

2014-06-17 Thread Ben Dooks
--- drivers/usb/gadget/r8a66597-udc.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66597-udc.c index aff0a67..7f3af74 100644 --- a/drivers/usb/gadget/r8a66597-udc.c +++ b/drivers/usb/gadget/r8a665

linux-usb@vger.kernel.org

2014-06-17 Thread Ben Dooks
Remove usages of &pdev->dev in the driver probe function with just dev to make the references to it easier to write. Convert all the current users of it to use it. Signed-off-by: Ben Dooks --- drivers/usb/gadget/r8a66597-udc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions

linux-usb@vger.kernel.org

2014-06-17 Thread Sergei Shtylyov
hello. On 06/17/2014 07:14 PM, Ben Dooks wrote: Remove usages of &pdev->dev in the driver probe function s/Remove/Replace/? with just dev to make the references to it easier to write. Convert all the current users of it to use it. Signed-off-by: Ben Dooks WBR, Sergei -- To unsubs

[PATCH 8/8] r8a66597-udc: remove now unused clean_up and clean_up3 label.

2014-06-17 Thread Ben Dooks
With the devm additions, the clean_up and clean_up3 are now not needed or used. Change clean_up3 and make everything use clean_up2 and just remove clean_up. Signed-off-by: Ben Dooks --- drivers/usb/gadget/r8a66597-udc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dri

[PATCH 7/8] r8a66597-udc: use devm_request_irq() to get device irq

2014-06-17 Thread Ben Dooks
Use the devm_request_irq() call to get the interrupt for the device and have it automatically free on exit. Signed-off-by: Ben Dooks --- drivers/usb/gadget/r8a66597-udc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/ga

[PATCH 6/8] r8a66597-udc: use devm_clk_get() to get clock

2014-06-17 Thread Ben Dooks
Change to using the devm_clk_get() to get the clock and have it automatically freed on exit. Signed-off-by: Ben Dooks --- drivers/usb/gadget/r8a66597-udc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66

[PATCH 5/8] r8a66597-udc: cleanup error path

2014-06-17 Thread Ben Dooks
With the updates for devm, the cleanup path no longer needs to check for NULL device state, so remove it and return directly if the irq resource missing Signed-off-by: Ben Dooks --- drivers/usb/gadget/r8a66597-udc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/d

[PATCH 4/8] r8a66597-udc: handle sudmac registers with devm_ioremap_resource()

2014-06-17 Thread Ben Dooks
Change the sudmac register handling in the devm_ioremap_resource to use the devm variant. Signed-off-by: Ben Dooks --- drivers/usb/gadget/r8a66597-udc.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8

[PATCH 3/8] r8a66597-udc: use devm_kzalloc() to allocate driver state

2014-06-17 Thread Ben Dooks
Update driver to use devm_kzalloc() to make tracking of resources easier. Also remove the exit point via cleanup as there's no cleanup necessary from this point now. As a note, also removes the error print as the allocation calls produce errors if they do not return memory. Signed-off-by: Ben Doo

r8a66597-udc: use devm functions

2014-06-17 Thread Ben Dooks
Change r8a66597-udc to use devm functions and cleanup the result. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: xhci handling ring expansion

2014-06-17 Thread David Laight
From: vichy > hi all: > I use kernel 3.8.0 > And when I plug in webcam in my platform xhci host, I get below message: > > platform-xhci platform-xhci.0: ERROR no room on ep ring, try ring expansion > platform-xhci platform-xhci.0: ring expansion succeed, now has 4 segments > platform-xhci platfor

Re: xhci handling ring expansion

2014-06-17 Thread vichy
hi Greg: 2014-06-17 22:25 GMT+08:00 Greg KH : > On Tue, Jun 17, 2014 at 10:07:38PM +0800, vichy wrote: >> hi all: >> I use kernel 3.8.0 > > That's a very old, and unsupported kernel version. I suggest you update Yes. it is pretty old kernel. But i have git diff the xhci-mem.c there is no log abo

Re: [PATCH] USB: EHCI: tegra: Fix use-after-free in .remove()

2014-06-17 Thread Alan Stern
On Tue, 17 Jun 2014, Tuomas Tynkkynen wrote: > The tegra_ehci_hcd structure is located in the private space allocated > by the core USB code so it must not be accessed after the HCD is > freed. > > Signed-off-by: Tuomas Tynkkynen > --- > drivers/usb/host/ehci-tegra.c | 3 ++- > 1 file changed,

Re: Probe function question

2014-06-17 Thread Oliver Neukum
On Tue, 2014-06-17 at 10:22 -0400, Alan Stern wrote: > On Tue, 17 Jun 2014, Vlad Ungureanu wrote: > > > To go into ADK mode the host needs to send the Android device a series of > > usb > > control messages with different data. This yes can be done from userspace > > but > > when the device goes

Re: xhci handling ring expansion

2014-06-17 Thread Greg KH
On Tue, Jun 17, 2014 at 10:07:38PM +0800, vichy wrote: > hi all: > I use kernel 3.8.0 That's a very old, and unsupported kernel version. I suggest you update to something more "modern", especially for xhci issues as loads of them have been fixed since 3.8 was released. If you are stuck with 3.8

Re: Probe function question

2014-06-17 Thread Alan Stern
On Tue, 17 Jun 2014, Vlad Ungureanu wrote: > To go into ADK mode the host needs to send the Android device a series of usb > control messages with different data. This yes can be done from userspace but > when the device goes into the ADK mode I need to handle it into Kernel space. > The end goal

[PATCH] USB: EHCI: tegra: Fix use-after-free in .remove()

2014-06-17 Thread Tuomas Tynkkynen
The tegra_ehci_hcd structure is located in the private space allocated by the core USB code so it must not be accessed after the HCD is freed. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/host/ehci-tegra.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/

Re: [PATCH] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-17 Thread Alan Stern
On Tue, 17 Jun 2014, Yang,Wei wrote: > On 06/15/2014 10:42 AM, Yang,Wei wrote: > > Its v4, sorry for missing it in subject. > > Alan, How about this version? > > Cheers > Wei ... > >> Signed-off-by: Yang Wei > >> Acked-by: Alan Stern That is a strange question to ask. If you did not know t

xhci handling ring expansion

2014-06-17 Thread vichy
hi all: I use kernel 3.8.0 And when I plug in webcam in my platform xhci host, I get below message: platform-xhci platform-xhci.0: ERROR no room on ep ring, try ring expansion platform-xhci platform-xhci.0: ring expansion succeed, now has 4 segments platform-xhci platform-xhci.0: ERROR Transfer e

Re: [PATCH v6] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-17 Thread Johan Hovold
On Tue, Jun 17, 2014 at 01:01:55AM +0300, Janne Kanniainen wrote: > This driver adds support for USB controlled led panels that exists in > MSI GT683R laptop > > Signed-off-by: Janne Kanniainen > --- > Changes in v2: > - sorted headers to alphabetic order > - using devm_kzalloc >

[PATCH v2][for 3.16 1/3] usb: gadget: Gadget directory cleanup - group legacy gadgets

2014-06-17 Thread Andrzej Pietrasiewicz
The drivers/usb/gadget directory contains many files. Files which are related can be distributed into separate directories. This patch moves the legacy gadgets (i.e. those not using configfs) into a separate directory. Signed-off-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/Kconfig

[PATCH v2][for 3.16 2/3] usb: gadget: Gadget directory cleanup - group UDC drivers

2014-06-17 Thread Andrzej Pietrasiewicz
The drivers/usb/gadget directory contains many files. Files which are related can be distributed into separate directories. This patch moves the UDC drivers into a separate directory. Signed-off-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/Kconfig| 363 +--

[PATCH v2][for 3.16 3/3] usb: gadget: Gadget directory cleanup - group usb functions

2014-06-17 Thread Andrzej Pietrasiewicz
The drivers/usb/gadget directory contains many files. Files which are related can be distributed into separate directories. This patch moves the USB functions implementations into a separate directory. Signed-off-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/Makefile|

[PATCH v2][for 3.16 0/3] Gadget directory cleanup

2014-06-17 Thread Andrzej Pietrasiewicz
This is a follow-up to this thread: http://www.spinics.net/lists/linux-usb/msg107611.html This refactoring has been accepted well, so I am sending it once 3.16-rc1 is out in order to make it easy to apply it. The cleanup rearranges the way source code files are located in the drivers/usb/gadget

Re: Probe function question

2014-06-17 Thread Vlad Ungureanu
> On Tue, 2014-06-17 at 12:19 +0200, Vlad Ungureanu wrote: > > > On Tue, 2014-06-17 at 11:18 +0200, Vlad Ungureanu wrote: > > > > > > > > > > > > > If that is not your intention, then you need to be more specific in > > > > > the match table. > > > > Yes, it matches the whole device so that is w

Re: [PATCH] usb: misc: usb3503: Update error code in print message

2014-06-17 Thread Marek Szyprowski
Hello, On 2014-06-17 13:08, Tushar Behera wrote: 'err' is uninitialized, rather print the error code directly. This also fixes following warning. drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’: drivers/usb/misc/usb3503.c:195:11: warning: ‘err’ may be used uninitialized in this function

[PATCH] usb: misc: usb3503: Update error code in print message

2014-06-17 Thread Tushar Behera
'err' is uninitialized, rather print the error code directly. This also fixes following warning. drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’: drivers/usb/misc/usb3503.c:195:11: warning: ‘err’ may be used uninitialized in this function [-Wmaybe-uninitialized] dev_err(dev, "unable to

Re: Probe function question

2014-06-17 Thread Bjørn Mork
Vlad Ungureanu writes: >> On Tue, 2014-06-17 at 11:18 +0200, Vlad Ungureanu wrote: >> > > >> >> > > If that is not your intention, then you need to be more specific in the >> > > match table. >> > Yes, it matches the whole device so that is why every interface gets >> > probed. I >> > will cha

Re: Probe function question

2014-06-17 Thread Oliver Neukum
On Tue, 2014-06-17 at 12:19 +0200, Vlad Ungureanu wrote: > > On Tue, 2014-06-17 at 11:18 +0200, Vlad Ungureanu wrote: > > > > > > > > > > If that is not your intention, then you need to be more specific in the > > > > match table. > > > Yes, it matches the whole device so that is why every inter

WARNING: CPU: 1 PID: 479 at drivers/usb/core/port.c:197 ... failed to peer

2014-06-17 Thread Borislav Petkov
Hi, I get the splat below on latest linus/master + tip/master, i.e. 3.16-rc1+. More info available upon request: ... [3.366557] xhci_hcd :00:14.0: xHCI Host Controller [3.367225] xhci_hcd :00:14.0: new USB bus registered, assigned bus number 2 [3.368064] usb usb2: New USB de

Re-Validate Your Mailbox

2014-06-17 Thread radio
You have exceeded the limit of your mailbox set by our IT Service, and from now you cannot be receiving all incoming emails and also some of your outgoing emails will not be delivered and LASTLY, your account will be 'DE-ACTIVATED' within 24 hours from now. To prevent , you are advised to click on

Re: Probe function question

2014-06-17 Thread Vlad Ungureanu
> On Tue, 2014-06-17 at 11:18 +0200, Vlad Ungureanu wrote: > > > > > > > If that is not your intention, then you need to be more specific in the > > > match table. > > Yes, it matches the whole device so that is why every interface gets > > probed. I > > will change that. > > That's problemati

Re: Probe function question

2014-06-17 Thread Oliver Neukum
On Tue, 2014-06-17 at 11:18 +0200, Vlad Ungureanu wrote: > > > > If that is not your intention, then you need to be more specific in the > > match table. > Yes, it matches the whole device so that is why every interface gets probed. I > will change that. That's problematic. You need to find out

Re: Probe function question

2014-06-17 Thread Vlad Ungureanu
> On Tue, 2014-06-17 at 09:31 +0200, Vlad Ungureanu wrote: > > Hello, > > > > I recently started to develop a USB kernel driver for a GoogleSummer Of Code > > project and I'm running in some small issues. The source code is available > > at > > https://github.com/ungureanuvladvictor/ADK-Driver/bl

Re: Probe function question

2014-06-17 Thread Vlad Ungureanu
> > > On 17 June 2014 09:31:07 CEST, Vlad Ungureanu wrote: > > >The driver matches the VID/PID of a LG Nexus5 and tries in the probe > >function > >to switch it to ADK Mode *Accessory Development Kit Mode*. > > This sounds like something you'd normally do from userspace. We are trying to use

Re: Probe function question

2014-06-17 Thread Oliver Neukum
On Tue, 2014-06-17 at 09:31 +0200, Vlad Ungureanu wrote: > Hello, > > I recently started to develop a USB kernel driver for a GoogleSummer Of Code > project and I'm running in some small issues. The source code is available at > https://github.com/ungureanuvladvictor/ADK-Driver/blob/master/adk-dri

Re: Probe function question

2014-06-17 Thread Bjørn Mork
On 17 June 2014 09:31:07 CEST, Vlad Ungureanu wrote: >The driver matches the VID/PID of a LG Nexus5 and tries in the probe >function >to switch it to ADK Mode *Accessory Development Kit Mode*. This sounds like something you'd normally do from userspace. >The problem is that my probe callbac

Re: [RFC 8/8] usb/gadget: f_uvc: add configfs support

2014-06-17 Thread Andrzej Pietrasiewicz
Hi Laurent, Thank you for a thorough review of the whole series. W dniu 16.06.2014 19:39, Laurent Pinchart pisze: Hi Andrzej, Thank you for the patch. git am complains with Applying: usb/gadget: f_uvc: add configfs support /home/laurent/src/kernel/media.git/.git/rebase-apply/patch:40: traili

Probe function question

2014-06-17 Thread Vlad Ungureanu
Hello, I recently started to develop a USB kernel driver for a GoogleSummer Of Code project and I'm running in some small issues. The source code is available at https://github.com/ungureanuvladvictor/ADK-Driver/blob/master/adk-driver.c . The driver matches the VID/PID of a LG Nexus5 and tries in