Re: [PATCH V3 4/5] dwc3: host: Enable USB3 LPM capability

2014-05-14 Thread Pratyush Anand
On Wed, May 14, 2014 at 10:45:55PM +0800, Felipe Balbi wrote: > On Wed, May 14, 2014 at 12:13:08PM +0530, Pratyush Anand wrote: > > Hi Paul/Felip, > > > > On Wed, May 07, 2014 at 11:15:33AM +0530, Pratyush Anand wrote: > > > Hi Paul, > > > > > > On Tue, May 06, 2014 at 11:54:19AM +0800, Pratyush

[PATCHv2] usb: gadget: s3c-hsotg/dwc2: Fix comment text

2014-05-14 Thread Andrzej Pietrasiewicz
Adjust the debug text to the name of the printed variable. Signed-off-by: Andrzej Pietrasiewicz --- v1..v2: - rebased onto Greg's usb-next drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 2

Re: [PATCH v3 0/5] Add support for SW babble Control

2014-05-14 Thread George Cherian
Hi Bin, On 5/14/2014 10:13 PM, Bin Liu wrote: George, On Wed, May 14, 2014 at 9:34 AM, Bin Liu wrote: George, On Wed, May 14, 2014 at 12:37 AM, George Cherian wrote: On 5/14/2014 12:07 AM, Bin Liu wrote: Hi, On Tue, May 13, 2014 at 8:24 AM, George Cherian wrote: Hi Daniel, On 5/13/20

Re: [PATCH] USB: Add LVS Test device driver

2014-05-14 Thread Pratyush Anand
On Thu, May 15, 2014 at 12:07:19AM +0800, Greg KH wrote: > On Mon, May 12, 2014 at 11:45:23AM +0530, Pratyush Anand wrote: > > +static DEVICE_ATTR(u3_entry, S_IWUSR, NULL, issue_u3_entry); > > For this, and the other DEVICE_ATTR() entries, please use > DEVICE_ATTR_RO() or _RW(), or _WO(), dependin

[RFC PATCH 01/10] clk: tegra: Enable hardware control of PLLE

2014-05-14 Thread Andrew Bresticker
From: Jim Lin Enable hardware control of PLLE spread-spectrum, IDDQ, and enable controls when enabling PLLE. The hardware (e.g. XUSB) using PLLE will use these controls for power-saving optimizations. Signed-off-by: Jim Lin Signed-off-by: Andrew Bresticker --- drivers/clk/tegra/clk-pll.c | 3

[RFC PATCH 02/10] clk: tegra: Fix xusb_fs_src mux

2014-05-14 Thread Andrew Bresticker
From: Jim Lin The parent-to-index mapping for xusb_fs_src is incorrect. Fix it by adding a mux table. Signed-off-by: Jim Lin Signed-off-by: Andrew Bresticker --- drivers/clk/tegra/clk-tegra-periph.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-t

[RFC PATCH 04/10] clk: tegra: Initialize xusb clocks

2014-05-14 Thread Andrew Bresticker
Initialize the XUSB-related clocks with appropriate parents and rates for both Tegra114 and Tegra124. Signed-off-by: Jim Lin Signed-off-by: Andrew Bresticker --- drivers/clk/tegra/clk-tegra114.c | 7 ++- drivers/clk/tegra/clk-tegra124.c | 6 ++ 2 files changed, 12 insertions(+), 1 delet

[RFC PATCH 03/10] clk: tegra: Fix xusb_hs_src clock hierarchy

2014-05-14 Thread Andrew Bresticker
Currently the Tegra1x4 clock init code hard-codes the mux setting for xusb_hs_src and treats it as a fixed-factor clock. It is, however, a mux which can be parented by either xusb_ss_src/2 or pll_u_60M. Add the fixed-factor clock xusb_ss_div2 and put an entry in periph_clks[] for the xusb_hs_src

[RFC PATCH 00/10] Tegra XHCI support

2014-05-14 Thread Andrew Bresticker
This is a first pass at the host and PHY drivers necessary for USB3.0 support on Tegra114 and Tegra124. The Tegra XHCI host controller requires external firmware [1] which must be loaded before using any USB ports owned by the controller. The XUSB PHY driver handles mapping and enabling of the UT

[RFC PATCH 05/10] ARM: tegra: Export function to read USB calibration data

2014-05-14 Thread Andrew Bresticker
Board-specific USB configuration data is stored in FUSE_SKU_CALIB_0. Export a function to read it so the PHY can be properly configured. Signed-off-by: Andrew Bresticker --- arch/arm/mach-tegra/fuse.c | 13 + include/linux/tegra-soc.h | 1 + 2 files changed, 14 insertions(+) diff

[RFC PATCH 09/10] ARM: tegra124: Add XHCI controller and PHY

2014-05-14 Thread Andrew Bresticker
And nodes for the XHCI host controller and XUSB PHY present on Tegra124. Signed-off-by: Andrew Bresticker --- arch/arm/boot/dts/tegra124.dtsi | 37 + 1 file changed, 37 insertions(+) diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dt

[RFC PATCH 10/10] ARM: tegra124: Enable XHCI on Venice2

2014-05-14 Thread Andrew Bresticker
Enable the XHCI host controller and XUSB PHY on Venice2. All three USB2.0 ports are owned by the XHCI controller and the two SuperSpeed ports are mapped to the external USB2.0 ports. Signed-off-by: Andrew Bresticker --- arch/arm/boot/dts/tegra124-venice2.dts | 46 ++-

[RFC PATCH 08/10] ARM: tegra124: Bind CAR to syscon device

2014-05-14 Thread Andrew Bresticker
The XUSB PHY driver will be accessing the CAR registers through the syscon interface. Signed-off-by: Andrew Bresticker --- arch/arm/boot/dts/tegra124.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi index 1

[RFC PATCH 07/10] phy: Add Tegra XUSB PHY driver

2014-05-14 Thread Andrew Bresticker
Add support for the Tegra XUSB PHY present on Tegra114 and Tegra124 SoCs. This provides all PHY functionality for the Tegra XHCI host-controller driver and supports UTMI, HSIC, and SuperSpeed interfaces. While this PHY driver currently only handles USB, the SATA and PCIe PHYs are programmed in a s

[RFC PATCH 06/10] usb: xhci: Add Tegra XHCI host-controller driver

2014-05-14 Thread Andrew Bresticker
Add support for the on-chip XHCI host controller present on NVIDIA Tegra114 and later SoCs. The driver is currently very basic: it loads the controller with its firmware, starts the controller, and is able to service messages sent by the controller's firmware. The hardware supports device mode as

Re: [PATCH v4 7/7] dts: dra7-evm: add USB support

2014-05-14 Thread Tony Lindgren
* Roger Quadros [140514 00:59]: > From: Roger Quadros > > Add USB pinmux information and USB modes > for the USB controllers. Thanks, applying all the .dts changes in this series into omap-for-v3.16/dt. Using the non-irqbar versions. Tony -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH] separate usb_address0 mutexes for each host

2014-05-14 Thread Todd E Brandt
On Tue, May 13, 2014 at 03:55:30PM -0700, Greg KH wrote: > On Tue, May 13, 2014 at 12:58:23PM -0700, Todd E Brandt wrote: > > This patch creates a separate instance of the usb_address0 mutex for each > > host > > controller, and attaches it to the host controller device struct. This > > allows >

Re: [PATCH] separate usb_address0 mutexes for each host

2014-05-14 Thread Todd E Brandt
On Wed, May 14, 2014 at 10:27:20AM -0400, Alan Stern wrote: > On Tue, 13 May 2014, Todd E Brandt wrote: > > > This patch creates a separate instance of the usb_address0 mutex for each > > host > > controller, and attaches it to the host controller device struct. This > > allows > > devices on se

[PATCH] usb: phy: Add SMSC USB334x PHY ID

2014-05-14 Thread Mark Brown
From: Liviu Dudau Signed-off-by: Liviu Dudau Signed-off-by: Ryan Harkin Signed-off-by: Mark Brown --- drivers/usb/phy/phy-ulpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/phy/phy-ulpi.c b/drivers/usb/phy/phy-ulpi.c index 17ea3f271bd8..4e3877c329f2 100644 --- a/drivers/us

[PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-14 Thread Mark Brown
From: Liviu Dudau arm64 architecture handles correctly 64bit DMAs and can enable support for 64bit EHCI host controllers. Signed-off-by: Liviu Dudau Signed-off-by: Ryan Harkin Signed-off-by: Mark Brown --- drivers/usb/host/ehci-hcd.c | 12 +--- 1 file changed, 9 insertions(+), 3 dele

Re: [PATCH 2/2 v2] usb: gadget: net2280: Add support for PLX USB338X

2014-05-14 Thread Ricardo Ribalda Delgado
Hello Joe Thanks for your comments. I have already prepared a v3 with your comments. I wait some hours for more comments and then I resubmit the patch to avoid spamming the list. Thanks for your time! On Wed, May 14, 2014 at 7:59 PM, Joe Perches wrote: > On Wed, 2014-05-14 at 19:39 +0200, Rica

[PATCH] phy: Enable USB PHY support for arm64

2014-05-14 Thread Mark Brown
From: Liviu Dudau Signed-off-by: Liviu Dudau Signed-off-by: Ryan Harkin Signed-off-by: Mark Brown --- drivers/usb/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index bbe8f15ac014..2a7f6ea1ccfe 100644 --- a/dri

Re: [PATCH 2/2 v2] usb: gadget: net2280: Add support for PLX USB338X

2014-05-14 Thread Joe Perches
On Wed, 2014-05-14 at 19:39 +0200, Ricardo Ribalda Delgado wrote: > This patch adds support for the PLX USB3380 and USB3382. > > This driver is based on the driver from the manufacturer. > > Since USB338X is register compatible with NET2280, I thought that it > would be better to include this har

[PATCH 1/2] usb: gadget: net2280: Fix NULL pointer dereference

2014-05-14 Thread Ricardo Ribalda Delgado
When DEBUG is enabled driver->driver.name is accessed, but driver can be NULL [ 174.411689] BUG: unable to handle kernel NULL pointer dereference at 0040 [ 174.429043] RIP: 0010:[] [] net2280_stop+0xa3/0x100 [net2280] [ 174.457910] Call Trace: [ 174.459503] [] usb_gadget_remove

Re: Driver probing defaults (was: Re: [PATCH] USB: Add LVS Test device driver)

2014-05-14 Thread Greg KH
On Wed, May 14, 2014 at 12:41:44PM -0400, Alan Stern wrote: > On Wed, 14 May 2014, Greg KH wrote: > > > > > Or just make the lvstest driver have to be "manually" bound to the > > > > device through the bind file in sysfs, don't let the driver > > > > automatically bind to anything. > > > > > > Ho

Re: [PATCH v3 0/5] Add support for SW babble Control

2014-05-14 Thread Bin Liu
George, On Wed, May 14, 2014 at 9:34 AM, Bin Liu wrote: > George, > > On Wed, May 14, 2014 at 12:37 AM, George Cherian > wrote: >> On 5/14/2014 12:07 AM, Bin Liu wrote: >>> >>> Hi, >>> >>> On Tue, May 13, 2014 at 8:24 AM, George Cherian >>> wrote: Hi Daniel, On 5/13/20

Re: Driver probing defaults (was: Re: [PATCH] USB: Add LVS Test device driver)

2014-05-14 Thread Alan Stern
On Wed, 14 May 2014, Greg KH wrote: > > > Or just make the lvstest driver have to be "manually" bound to the > > > device through the bind file in sysfs, don't let the driver > > > automatically bind to anything. > > > > How can we do that? The probe routine doesn't know whether it was > > calle

Re: Driver probing defaults (was: Re: [PATCH] USB: Add LVS Test device driver)

2014-05-14 Thread Greg KH
On Wed, May 14, 2014 at 12:06:40PM -0400, Alan Stern wrote: > On Wed, 14 May 2014, Greg KH wrote: > > > > Is it really safe to rely on the device core always probing drivers in > > > order of driver registration? > > > > Yes it is. > > Okay, good. Do you know if this is documented anywhere? No

Re: [PATCH] USB: Add LVS Test device driver

2014-05-14 Thread Greg KH
On Mon, May 12, 2014 at 11:45:23AM +0530, Pratyush Anand wrote: > +static DEVICE_ATTR(u3_entry, S_IWUSR, NULL, issue_u3_entry); For this, and the other DEVICE_ATTR() entries, please use DEVICE_ATTR_RO() or _RW(), or _WO(), depending on what you are wanting the permissions to be. I'm trying to get

Re: Driver probing defaults (was: Re: [PATCH] USB: Add LVS Test device driver)

2014-05-14 Thread Alan Stern
On Wed, 14 May 2014, Greg KH wrote: > > Is it really safe to rely on the device core always probing drivers in > > order of driver registration? > > Yes it is. Okay, good. Do you know if this is documented anywhere? > > If it is then we are okay (at least in this particular case), because > >

Re: [PATCH RESEND v4 0/8] Add Allwinner A31 USB support

2014-05-14 Thread Greg Kroah-Hartman
On Wed, May 14, 2014 at 02:34:19PM +0200, Maxime Ripard wrote: > On Tue, May 13, 2014 at 05:44:14PM +0200, Maxime Ripard wrote: > > Hi everyone, > > > > This patchset adds support for the USB controllers found in the > > Allwinner A31. > > > > While the design is similar to the earlier Allwinner

Re: Driver probing defaults (was: Re: [PATCH] USB: Add LVS Test device driver)

2014-05-14 Thread Greg KH
On Wed, May 14, 2014 at 11:05:44AM -0400, Alan Stern wrote: > On Wed, 14 May 2014, Pratyush Anand wrote: > > If that is not true, may be I can do what Bj?rn Mork is suggesting. > > But that would require change in drivers/base/bus.c:driver_(un)bind. > > > > -- Add a new field manual_binding in str

Re: [PATCHv5 10/20] phy: add support for USB cluster on the Armada 375 SoC

2014-05-14 Thread Gregory CLEMENT
On 14/05/2014 16:27, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 13 May 2014 03:11 PM, Gregory CLEMENT wrote: >> On 13/05/2014 10:06, Gregory CLEMENT wrote: >>> On 13/05/2014 07:53, Kishon Vijay Abraham I wrote: Hi, On Sunday 11 May 2014 11:47 PM, Thomas Petazzoni wrote:

Re: [PATCH] ax88179_178a: don't send commands to detached device

2014-05-14 Thread Alan Stern
On Wed, 14 May 2014, Emil Goode wrote: > The .stop and .unbind callbacks of struct driver_info are > called even after a DETACH hot-plug event. In the case of > the ax88179_178a minidriver we need to make sure we are not > trying to send commands to a device that has been detached. > This leads to

Driver probing defaults (was: Re: [PATCH] USB: Add LVS Test device driver)

2014-05-14 Thread Alan Stern
On Wed, 14 May 2014, Pratyush Anand wrote: > I see some references on different mailing lists that "probe will be > executed according to object link order which is decided by Makefile". > > http://comments.gmane.org/gmane.linux.usb.general/98616 I believe that refers to probing during driver re

[PATCH] ax88179_178a: don't send commands to detached device

2014-05-14 Thread Emil Goode
The .stop and .unbind callbacks of struct driver_info are called even after a DETACH hot-plug event. In the case of the ax88179_178a minidriver we need to make sure we are not trying to send commands to a device that has been detached. This leads to failure messages like below. ax88179_178a 1-1.3:

Re: [PATCH V3 4/5] dwc3: host: Enable USB3 LPM capability

2014-05-14 Thread Felipe Balbi
On Wed, May 14, 2014 at 12:13:08PM +0530, Pratyush Anand wrote: > Hi Paul/Felip, > > On Wed, May 07, 2014 at 11:15:33AM +0530, Pratyush Anand wrote: > > Hi Paul, > > > > On Tue, May 06, 2014 at 11:54:19AM +0800, Pratyush ANAND wrote: > > > All dwc3 based xhci host controller supports USB3.0 LPM f

Re: [PATCH 1/1] usb: core: Kconfig: refine the description for CONFIG_USB_OTG

2014-05-14 Thread Felipe Balbi
On Wed, May 14, 2014 at 04:08:30PM +0200, Greg KH wrote: > On Wed, May 14, 2014 at 06:24:51AM +, Peter Chen wrote: > > > > > > > > On Tue, May 13, 2014 at 01:11:44PM +0200, Greg KH wrote: > > > > On Tue, May 13, 2014 at 10:19:27AM +0800, Peter Chen wrote: > > > > > the user should only selec

Re: [PATCH v3 0/5] Add support for SW babble Control

2014-05-14 Thread Bin Liu
George, On Wed, May 14, 2014 at 12:37 AM, George Cherian wrote: > On 5/14/2014 12:07 AM, Bin Liu wrote: >> >> Hi, >> >> On Tue, May 13, 2014 at 8:24 AM, George Cherian >> wrote: >>> >>> Hi Daniel, >>> >>> >>> On 5/13/2014 6:44 PM, Daniel Mack wrote: Hi George, On 05/13/2014 0

Re: [PATCH] USB: Add LVS Test device driver

2014-05-14 Thread Greg KH
On Wed, May 14, 2014 at 09:56:02AM +0530, Pratyush Anand wrote: > Hi Alan, > > PS: For all other comments, will do as you suggested. > On Tue, May 13, 2014 at 10:28:11PM +0800, Alan Stern wrote: > > On Tue, 13 May 2014, Pratyush Anand wrote: > > > > > > The biggest bug may not be an obvious one.

Re: ehci-hcd.c causes: irq : nobody cared

2014-05-14 Thread Alan Stern
On Tue, 13 May 2014, Dr. Werner Fink wrote: > On Tue, May 13, 2014 at 06:10:46PM +0200, Dr. Werner Fink wrote: > > On Tue, May 13, 2014 at 11:59:38AM -0400, Alan Stern wrote: > > > > > > What about something like this instead? > > > > > > masked_status = status & (INTR_MASK | STS_FLR); > > >

Re: [PATCH 1/1] usb: core: Kconfig: refine the description for CONFIG_USB_OTG

2014-05-14 Thread Greg KH
On Wed, May 14, 2014 at 06:24:51AM +, Peter Chen wrote: > > > > > On Tue, May 13, 2014 at 01:11:44PM +0200, Greg KH wrote: > > > On Tue, May 13, 2014 at 10:19:27AM +0800, Peter Chen wrote: > > > > the user should only select it when the board supports HNP and SRP, > > > > it should NOT be se

Re: [PATCHv5 10/20] phy: add support for USB cluster on the Armada 375 SoC

2014-05-14 Thread Kishon Vijay Abraham I
Hi, On Tuesday 13 May 2014 03:11 PM, Gregory CLEMENT wrote: > On 13/05/2014 10:06, Gregory CLEMENT wrote: >> On 13/05/2014 07:53, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Sunday 11 May 2014 11:47 PM, Thomas Petazzoni wrote: From: Gregory CLEMENT The Armada 375 SoC comes wit

Re: [PATCH] usb: gadget: s3c-hsotg: Fix comment text

2014-05-14 Thread Felipe Balbi
On Wed, May 14, 2014 at 02:42:16PM +0200, Andrzej Pietrasiewicz wrote: > Adjust the debug text to the name of the printed variable. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/usb/gadget/s3c-hsotg.c | 2 +- please rebase this on top of greg/usb-next, that file doesn' exist in this l

Re: [PATCH] separate usb_address0 mutexes for each host

2014-05-14 Thread Alan Stern
On Tue, 13 May 2014, Todd E Brandt wrote: > This patch creates a separate instance of the usb_address0 mutex for each host > controller, and attaches it to the host controller device struct. This allows > devices on separate hosts to be enumerated in parallel; saving time. > > In the current code

Re: disable VBUS?

2014-05-14 Thread Alan Stern
On Wed, 14 May 2014, Grant wrote: > >> Can I disable VBUS while keeping the rest of USB functional for a > >> device that does not require bus power? > > > > unfortunately not, your device would see a disconnection. The reason is > > that even though you don't really put any load on the bus, the P

Re: [PATCHv5 10/20] phy: add support for USB cluster on the Armada 375 SoC

2014-05-14 Thread Gregory CLEMENT
Hi Kishon, Given the answers I provided to your concerns. I don't see any modification to do to this driver. Do you agree? If not which change is mandatory from your point of view? Thanks, Gregory On 13/05/2014 11:41, Gregory CLEMENT wrote: > On 13/05/2014 10:06, Gregory CLEMENT wrote: >> On

[PATCH v6 0/8] Enable USB 3.0 support on Exynos5 systems

2014-05-14 Thread Vivek Gautam
From: Vivek gautam Based on 'for-next' branch of Kgene's linux-samsung tree; along with dts patches for USB 2.0 phy[1], and Exynos5800 [2]. Also based on the latest USB 3.0 DRD phy driver patches posted [3]. Changes from v5: - Added node reference names for new boards. - Removed 'samsung,pmu-o

[PATCH v6 1/8] ARM: dts: exynos5420: Enable support for USB 3.0 PHY controller

2014-05-14 Thread Vivek Gautam
Add device tree nodes for USB 3.0 PHY present alongwith USB 3.0 controller Exynos 5420 SoC. This phy driver is based on generic phy framework. Signed-off-by: Vivek Gautam Reviewed-by: Tomasz Figa --- arch/arm/boot/dts/exynos5420.dtsi | 20 1 file changed, 20 insertions(+)

[PATCH v6 5/8] ARM: dts: exynos5250-snow: Add Vbus regulator for USB 3.0

2014-05-14 Thread Vivek Gautam
Add required fixed-regulator for VBUS supply for USB 3.0 controller phy. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250-snow.dts | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.

[PATCH v6 2/8] ARM: dts: exynos5420: Enable support for DWC3 controller

2014-05-14 Thread Vivek Gautam
Add device tree nodes for DWC3 controller present on Exynos 5420 SoC, to enable support for USB 3.0. Signed-off-by: Vivek Gautam Reviewed-by: Tomasz Figa --- arch/arm/boot/dts/exynos5420.dtsi | 34 ++ 1 file changed, 34 insertions(+) diff --git a/arch/arm/boot

[PATCH v6 3/8] ARM: dts: exynos5250: Enable support for generic USB DRD phy

2014-05-14 Thread Vivek Gautam
Add device tree node for new usbdrd-phy driver, which is based on generic phy framework. Signed-off-by: Vivek Gautam Reviewed-by: Tomasz Figa --- arch/arm/boot/dts/exynos5250.dtsi |9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/

[PATCH v6 4/8] ARM: dts: exynos5250: Update DWC3 usb controller to use new phy driver

2014-05-14 Thread Vivek Gautam
Removing the dt node for older usb3 phy driver from Exynos5250 device tree and updating the dt node for DWC3 controller to use new phy driver based on generic phy framework. Signed-off-by: Vivek Gautam Reviewed-by: Tomasz Figa --- arch/arm/boot/dts/exynos5250.dtsi | 17 ++--- 1 fi

[PATCH v6 7/8] ARM: dts: exynos5420-smdk5420: Add Vbus regulator for USB 3.0

2014-05-14 Thread Vivek Gautam
Add required fixed-regulator for VBUS supply for USB 3.0 controller phy. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5420-smdk5420.dts | 46 + 1 file changed, 46 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/e

[PATCH v6 8/8] ARM: dts: exynos5800-peach-pi: Add Vbus regulator for USB 3.0

2014-05-14 Thread Vivek Gautam
From: Vivek gautam Add required fixed-regulator for VBUS supply for USB 3.0 controller phy. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 46 + 1 file changed, 46 insertions(+) diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts

[PATCH v6 6/8] ARM: dts: exynos5420-peach-pit: Add Vbus regulator for USB 3.0

2014-05-14 Thread Vivek Gautam
Add required fixed-regulator for VBUS supply for USB 3.0 controller phy. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 46 1 file changed, 46 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/

[patch v2] usb: phy: msm: change devm_ioremap() to devm_ioremap_resource()

2014-05-14 Thread Dan Carpenter
There are several issues here: 1) platform_get_resource() can return NULL and that wasn't handled. 2) We should request the memory before we remap it, and devm_ioremap_resource() does that. 3) devm_ioremap() returns a NULL but we were checking for IS_ERR(). Fixes: 6b99c68ec1f9 ('usb: phy: msm:

Re: [patch] usb: phy: msm: devm_ioremap() doesn't return ERR_PTRs

2014-05-14 Thread Dan Carpenter
On Wed, May 14, 2014 at 05:24:52PM +0400, Sergei Shtylyov wrote: > Hello. > > On 14-05-2014 16:55, Dan Carpenter wrote: > > >devm_ioremap() returns a NULL on error so the IS_ERR() check needs to be > >updated. > > >Fixes: 6b99c68ec1f9 ('usb: phy: msm: Migrate to Managed Device Resource > >alloc

Re: [patch] usb: phy: msm: devm_ioremap() doesn't return ERR_PTRs

2014-05-14 Thread Sergei Shtylyov
Hello. On 14-05-2014 16:55, Dan Carpenter wrote: devm_ioremap() returns a NULL on error so the IS_ERR() check needs to be updated. Fixes: 6b99c68ec1f9 ('usb: phy: msm: Migrate to Managed Device Resource allocation') Signed-off-by: Dan Carpenter diff --git a/drivers/usb/phy/phy-msm-usb.c

Re: [patch] usb: phy: msm: devm_ioremap() doesn't return ERR_PTRs

2014-05-14 Thread Fabio Estevam
On Wed, May 14, 2014 at 9:55 AM, Dan Carpenter wrote: > devm_ioremap() returns a NULL on error so the IS_ERR() check needs to be > updated. > > Fixes: 6b99c68ec1f9 ('usb: phy: msm: Migrate to Managed Device Resource > allocation') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/usb/phy/p

[PATCH 3/3] usb: dwc2: gadget: move phy bus legth initialization

2014-05-14 Thread Kamil Debski
This patch moves the part of code that initializes the PHY bus width. This results in simpler code and removes the need to check whether the Generic PHY Framework is used. Signed-off-by: Kamil Debski --- drivers/usb/dwc2/gadget.c | 22 +++--- 1 file changed, 11 insertions(+), 1

[PATCH 2/3] usb: dwc2: gadget: fix phy initialization sequence

2014-05-14 Thread Kamil Debski
In the Generic PHY Framework a NULL phy is considered to be a valid phy thus the "if (hsotg->phy)" check does not give us the information whether the Generic PHY Framework is used. In addition to the above this patch also removes phy_init from probe and phy_exit from remove. This is not necessary

[PATCH v2 1/3] usb: dwc2: gadget: fix phy disable sequence

2014-05-14 Thread Kamil Debski
When the driver is removed s3c_hsotg_phy_disable is called three times instead of once. This results in decreasing of the phy reference counter below zero and thus consecutive inserts of the module fails. This patch removes calls to s3c_hsotg_phy_disable from s3c_hsotg_remove and s3c_hsotg_udc_sto

[patch] usb: phy: msm: devm_ioremap() doesn't return ERR_PTRs

2014-05-14 Thread Dan Carpenter
devm_ioremap() returns a NULL on error so the IS_ERR() check needs to be updated. Fixes: 6b99c68ec1f9 ('usb: phy: msm: Migrate to Managed Device Resource allocation') Signed-off-by: Dan Carpenter diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index c522c4f..bd32257 1

[PATCH] usb: gadget: s3c-hsotg: Fix comment text

2014-05-14 Thread Andrzej Pietrasiewicz
Adjust the debug text to the name of the printed variable. Signed-off-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/s3c-hsotg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index 2a9cb67..bbb7f3f 100644 ---

Re: [PATCH RESEND v4 0/8] Add Allwinner A31 USB support

2014-05-14 Thread Maxime Ripard
On Tue, May 13, 2014 at 05:44:14PM +0200, Maxime Ripard wrote: > Hi everyone, > > This patchset adds support for the USB controllers found in the > Allwinner A31. > > While the design is similar to the earlier Allwinner SoCs that are > already supported, a few details here and there change, like

Re: [PATCH RESEND v4 4/8] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support

2014-05-14 Thread Maxime Ripard
Hi, On Wed, May 14, 2014 at 02:09:37PM +0530, Kishon Vijay Abraham I wrote: > > @@ -305,6 +315,7 @@ static int sun4i_usb_phy_probe(struct platform_device > > *pdev) > > static const struct of_device_id sun4i_usb_phy_of_match[] = { > > { .compatible = "allwinner,sun4i-a10-usb-phy" }, > >

Re: disable VBUS?

2014-05-14 Thread Grant
>> Can I disable VBUS while keeping the rest of USB functional for a >> device that does not require bus power? > > > Can you please elaborate the question of why VBus should go off ? Is this > question in the context of any new USB specification ? It's not related to a USB spec, it's just part of

Re: disable VBUS?

2014-05-14 Thread Grant
>> Can I disable VBUS while keeping the rest of USB functional for a >> device that does not require bus power? > > unfortunately not, your device would see a disconnection. The reason is > that even though you don't really put any load on the bus, the PHY still > samples VBUS levels to know when t

[PATCH] xhci: unified loggig of RESET_ON_RESUME

2014-05-14 Thread oliver
From: Oliver Neukum Either we log for all chips we set the quirk for or for none. This patch reports it for all chips. Signed-off-by: Oliver Neukum --- drivers/usb/host/xhci-pci.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/us

Re: [Patch V2 1/2] usb: gadget: zero: Add support for interrupt EP

2014-05-14 Thread Amit Virdi
On 5/10/2014 1:04 AM, Alan Stern wrote: On Mon, 5 May 2014, Amit Virdi wrote: Interrupt endpoints behave quite similar to the bulk endpoints with the difference that the endpoints expect data sending/reception request at particular intervals till the whole data has not been transmitted. The in

Re: Unknown USB IDs of Intenso Memory Box

2014-05-14 Thread Richard Hartmann
On Wed, May 14, 2014 at 10:58 AM, Clemens Ladisch wrote: > The device has clear-text names: > > idVendor 0x2109 > idProduct 0x0701 > iManufacturer 1 Intenso > iProduct2 External USB 3.0 I ran `update-usbids` and didn't get any names via `lsusb

Re: [PATCH v2] u_ether: move hardware transmit to RX NAPI

2014-05-14 Thread Andrzej Pietrasiewicz
W dniu 13.05.2014 17:57, Weinn Jheng pisze: --- Changes for v2: - Trying to fix the plug/unplug problem which cause KE. I tested it. I'm sorry, no improvement here. :( Please see the log below: 33.737909] [ cut here ] [ 33.742365] kernel BUG at include/linux/netd

Re: [PATCH] usb: gadget: s3c-hsotg: fix phy disable sequence

2014-05-14 Thread Kishon Vijay Abraham I
Hi, On Wednesday 14 May 2014 02:51 PM, Kamil Debski wrote: > Hi Vivek, Kishon, > >> From: gautamvivek1...@gmail.com [mailto:gautamvivek1...@gmail.com] On >> Behalf Of Vivek Gautam >> Sent: Tuesday, May 13, 2014 12:08 PM >> To: Marek Szyprowski >> Cc: Kamil Debski; Linux USB Mailing List; r.bald..

RE: [PATCH] usb: gadget: s3c-hsotg: fix phy disable sequence

2014-05-14 Thread Kamil Debski
Hi Vivek, Kishon, > From: gautamvivek1...@gmail.com [mailto:gautamvivek1...@gmail.com] On > Behalf Of Vivek Gautam > Sent: Tuesday, May 13, 2014 12:08 PM > To: Marek Szyprowski > Cc: Kamil Debski; Linux USB Mailing List; r.bald...@samsung.com > Subject: Re: [PATCH] usb: gadget: s3c-hsotg: fix phy

Re: Unknown USB IDs of Intenso Memory Box

2014-05-14 Thread Clemens Ladisch
Richard Hartmann wrote: > On Wed, May 14, 2014 at 10:14 AM, Clemens Ladisch wrote: >> Why? Is there a problem? > > No; it's working as expected. The implied statement was "the ids > should receive clear-text names". The device has clear-text names: idVendor 0x2109 idProduct

Re: Unknown USB IDs of Intenso Memory Box

2014-05-14 Thread Richard Hartmann
On Wed, May 14, 2014 at 10:14 AM, Clemens Ladisch wrote: > Why? Is there a problem? No; it's working as expected. The implied statement was "the ids should receive clear-text names". I don't know the exact chip name though, only the model; should I submit a patch with a generic name? >> smar

Re: [PATCH RESEND v4 4/8] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support

2014-05-14 Thread Kishon Vijay Abraham I
Hi, On Tuesday 13 May 2014 09:14 PM, Maxime Ripard wrote: > The USB phy controller in the A31 differs mostly from the older controllers > because it has a clock dedicated for each phy, while the older ones were > having > a single clock for all the phys. > > Signed-off-by: Maxime Ripard > Revie

[PATCH 3/3] usb: gadget: Gadget directory cleanup - group usb functions

2014-05-14 Thread Andrzej Pietrasiewicz
The drivers/usb/gadget directory contains many files. Files which are related can be distributed into separate directories. This patch moves the USB functions implementations into a separate directory. Signed-off-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/Makefile|

[PATCH 0/3] Gadget directory cleanup

2014-05-14 Thread Andrzej Pietrasiewicz
The cleanup rearranges the way source code files are located in the drivers/usb/gadget directory. New subdirectories are introduced: - "udc" for UDC chip drivers - "function" for actual usb functions' implementations - "legacy" for gadgets compiled as statically composed modules while at the gadg

[PATCH 1/3] usb: gadget: Gadget directory cleanup - group legacy gadgets

2014-05-14 Thread Andrzej Pietrasiewicz
The drivers/usb/gadget directory contains many files. Files which are related can be distributed into separate directories. This patch moves the legacy gadgets (i.e. those not using configfs) into a separate directory. Signed-off-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/Kconfig

[PATCH 2/3] usb: gadget: Gadget directory cleanup - group UDC drivers

2014-05-14 Thread Andrzej Pietrasiewicz
The drivers/usb/gadget directory contains many files. Files which are related can be distributed into separate directories. This patch moves the UDC drivers into a separate directory. Signed-off-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/Kconfig| 369 +--

Re: [RFC 0/3] Gadget directory cleanup

2014-05-14 Thread Andrzej Pietrasiewicz
W dniu 13.05.2014 21:55, Paul Zimmerman pisze: From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi Sent: Tuesday, May 13, 2014 8:08 AM Hi Andrzej, I thinks it's pretty ugly that you added "../", "../udc/" to a lot of the #include stateme

Re: [RFC 0/3] Gadget directory cleanup

2014-05-14 Thread Andrzej Pietrasiewicz
Hi Felipe, W dniu 13.05.2014 17:08, Felipe Balbi pisze: Hi, 1) Do you find the idea useful? sure, but please regerenate the patches with rename detection (-C -M)... that'll be a lot easier to review. Yeah, I noticed what I had done only after I sent the patches. And the corrected version

Re: Unknown USB IDs of Intenso Memory Box

2014-05-14 Thread Clemens Ladisch
Richard Hartmann wrote: > I got two new Intenso 3.5" Memory Box with 3TB in the metallic edition > with USB 3.0 interface. > > Please see the attached output of `lsusb -vvv -d 2109:0701` Why? Is there a problem? > smartmontools doesn't seem to know that controller either It does not need to kno

[PATCH v4 7/7] dts: dra7-evm: add USB support

2014-05-14 Thread Roger Quadros
From: Roger Quadros Add USB pinmux information and USB modes for the USB controllers. CC: Benoît Cousson Reviewed-by: Felipe Balbi Signed-off-by: Roger Quadros --- arch/arm/boot/dts/dra7-evm.dts | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/d

Re: usb: phy: msm: Migrate to Managed Device Resource allocation

2014-05-14 Thread Dan Carpenter
On Wed, May 14, 2014 at 10:01:17AM +0300, Ivan T. Ivanov wrote: > On Tue, 2014-05-13 at 23:20 +0300, Dan Carpenter wrote: > > Hello Ivan T. Ivanov, > > > > The patch 6b99c68ec1f9: "usb: phy: msm: Migrate to Managed Device > > Resource allocation" from Apr 28, 2014, leads to the following static >

Re: [PATCH v3 7/7] dts: dra7-evm: add USB support

2014-05-14 Thread Roger Quadros
On 05/13/2014 08:18 PM, Tony Lindgren wrote: > * Roger Quadros [140505 02:55]: >> Add USB pinmux information and USB modes >> for the USB controllers. >> >> CC: Benoît Cousson >> Reviewed-by: Felipe Balbi >> Signed-off-by: Roger Quadros >> --- >> arch/arm/boot/dts/dra7-evm.dts | 24 +++

Re: [PATCH v2] usb: phy: msm: reset controller is mandatory now

2014-05-14 Thread Ivan T. Ivanov
On Tue, 2014-05-13 at 21:46 +0200, Arnd Bergmann wrote: > Commit a27345434134 "usb: phy: msm: Use reset framework for LINK > and PHY resets" introduced a mandatory call to reset_control_get > into the msm usb phy driver, which means we have to add a Kconfig > dependency on the API to avoid this bui

Re: usb: phy: msm: Migrate to Managed Device Resource allocation

2014-05-14 Thread Ivan T. Ivanov
On Tue, 2014-05-13 at 23:20 +0300, Dan Carpenter wrote: > Hello Ivan T. Ivanov, > > The patch 6b99c68ec1f9: "usb: phy: msm: Migrate to Managed Device > Resource allocation" from Apr 28, 2014, leads to the following static > checker warning: > > drivers/usb/phy/phy-msm-usb.c:1590 msm_otg_pro