Re: XHCI issues: WD MyBook 1230 - reset SuperSpeed USB device

2013-12-29 Thread AndrejP
Same problem here. HP elitebook 8560w. Running on Arch linux, kernel: 3.12.5. Attaching WD Elements 1TB.no -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.

[PATCH] usb: ehci: Cleanup usb-ehci-orion.h header

2013-12-29 Thread Sachin Kamat
Commit c02cecb92ed4 ("ARM: orion: move platform_data definitions") moved the file to the current location but forgot to remove the pointer to its previous location. Clean it up. While at it also change the header file protection macros appropriately. Signed-off-by: Sachin Kamat --- include/linux

[PATCH 0/25] fix error return code

2013-12-29 Thread Julia Lawall
These patches fix cases where the return variable is not set to an error code in an error case. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 10/25] usb: gadget: fix error return code

2013-12-29 Thread Julia Lawall
From: Julia Lawall Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret =

Re: [PATCH v8 2/2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-12-29 Thread Andrew Lunn
> I hope it's OK that I submit the patch with the below changes to Greg > for inclusion in v3.14. Let me know if you prefer to respin yourself. Hi Johan The patch looks good. Acked-by: Andrew Lunn > Thanks for all your work with fixing up and mainlining this driver! And thanks for all the rev

[PATCH 18/26] USB: pl2303: rename pl2303_encode_baud_rate

2013-12-29 Thread Johan Hovold
Rename baud-rate encoding function to match tty naming. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 35aa4973a137..8d792afbe27f 100644 --- a/dr

[PATCH 23/26] USB: pl2303: use direct baud-rate encoding when possible

2013-12-29 Thread Johan Hovold
Use direct baud-rate encoding rather than divisors for supported baud rates. This restores the way baud rates were set prior to commit 8d48fdf689fe ("USB: PL2303: correctly handle baudrates above 115200") which added divisor encoding, but also switched to the new encoding method for all baudrates

[PATCH 25/26] USB: serial: add Moxa UPORT 12XX/14XX/16XX driver

2013-12-29 Thread Johan Hovold
From: Andrew Lunn Add a driver which supports the following Moxa USB to serial converters: * 2 ports : UPort 1250, UPort 1250I * 4 ports : UPort 1410, UPort 1450, UPort 1450I * 8 ports : UPort 1610-8, UPort 1650-8 * 16 ports : UPort 1610-16, UPort 1650-16 The UPORT devices

[PATCH 06/26] USB: f81232: switch to generic tiocmiwait

2013-12-29 Thread Johan Hovold
Switch to generic tiocmiwait rather than rely on a custom implementation using racy interruptible_sleep_on(). Note that this driver is mostly stubbed out so neither version of tiocmiwait will actually work until someone implements f81232_update_line_status(). Signed-off-by: Johan Hovold --- dri

[PATCH 24/26] tty: Add C_CMSPAR(tty)

2013-12-29 Thread Johan Hovold
From: Andrew Lunn Add the missing C_CMSPAR(tty) macro. Signed-off-by: Andrew Lunn Signed-off-by: Johan Hovold --- include/linux/tty.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/tty.h b/include/linux/tty.h index 97d660ed70c1..e53e90ed3f19 100644 --- a/include/linux/tty.h

[PATCH 14/26] USB: pl2303: use speed_t for baud rates

2013-12-29 Thread Johan Hovold
Use speed_t for baud rates throughout. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 8dd1c4a0aefd..40f7b80b3601 100644 --- a/drivers/usb/se

[PATCH 16/26] USB: pl2303: add quirk for legacy devices

2013-12-29 Thread Johan Hovold
Add quirk for legacy devices (type 0 and 1) rather than testing on device type throughout the driver. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c

[PATCH 22/26] USB: pl2303: add helper function for direct baud-rate encoding

2013-12-29 Thread Johan Hovold
Add helper function for direct baud-rate encoding. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 44f4b546adeb..b4e72979def7 10

[PATCH 21/26] USB: pl2303: refactor baud-rate divisor handling

2013-12-29 Thread Johan Hovold
Refactor baud-rate divisor handling. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 41 + 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 394903b4ecb7..44f4b546a

[PATCH 10/26] USB: pl2303: add error handling to set_control_lines

2013-12-29 Thread Johan Hovold
Add error handling to set_control_lines. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 4058ceec884d..1fe8545e9926 100644 --- a/drivers/usb/seri

[PATCH 15/26] USB: pl2303: clean up type handling

2013-12-29 Thread Johan Hovold
Merge types 0 and 1, whose differences are unknown and have always been treated the same. Add TYPE_-prefix to both types. Test for TYPE_01 (rather than !TYPE_HX) for legacy device quirks. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 31 +++ 1 file cha

[PATCH 12/26] USB: pl2303: remove redundant line-request call

2013-12-29 Thread Johan Hovold
Remove redundant get_line_request (the read back settings are never used). Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 28b10cfcb4d3..440b99c15435 100644 --- a/dri

[PATCH 07/26] USB: pl2303: remove bogus delta_msr_wait wake up

2013-12-29 Thread Johan Hovold
Remove bogus MSR wait-queue wake up from process_read_urb which never updates the MSR flags. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 3dd5398174c1..6234d55372cb 1

[PATCH 26/26] USB: pl2303: use C_CMSPAR macro

2013-12-29 Thread Johan Hovold
Use the new C_CMSPAR macro for consistency. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 28e598638e0a..253cc9c367c1 100644 --- a/drivers/usb/seri

[PATCH 04/26] USB: serial: remove redundant OOM messages

2013-12-29 Thread Johan Hovold
Remove redundant error messages on allocation failures, which have already been logged. Cc: Joe Perches Signed-off-by: Johan Hovold --- drivers/usb/serial/ch341.c| 4 +-- drivers/usb/serial/console.c | 2 -- drivers/usb/serial/cp210x.c | 8 ++--- drivers/usb/se

[PATCH 00/26] USB: serial: patches for v3.14

2013-12-29 Thread Johan Hovold
Hi Greg, Here are a few patches for v3.14 (if it's not to late) including a new driver by Andrew Lunn (and Moxa) for MOXA UPort devices, some subsystem wide cleanups, and some pl2303 driver improvements. The pl2303 patches fix one low-priority bug (still marked for stable) and add some device-typ

[PATCH 17/26] USB: pl2303: add device-type abstraction

2013-12-29 Thread Johan Hovold
Encode all device-type specifics in a struct rather than testing for device type and spreading such information throughout the driver. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/driver

[PATCH 05/26] USB: f81232: remove bogus call to wake up MSR queue

2013-12-29 Thread Johan Hovold
Remove bogus call to wake up delta_msr_wait from process_read_urb where the MSR status is never updated (only the LSR bits are masked out). Comment that the wake-up call should made in f81232_update_line_status when the MSR status changes. Note that this driver is still mostly stubbed out. Signe

[PATCH 11/26] USB: pl2303: add error handling to line requests

2013-12-29 Thread Johan Hovold
Refactor and add error handling to line requests. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 68 + 1 file changed, 51 insertions(+), 17 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 1fe854

[PATCH 20/26] USB: pl2303: enforce baud-rate limits before lookup

2013-12-29 Thread Johan Hovold
Enforce any baud-rate limits before doing table lookup. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 9a95b92310f2..394903b4ecb7 100644 --- a/dr

[PATCH 01/26] USB: pl2303: fix data corruption on termios updates

2013-12-29 Thread Johan Hovold
Some PL2303 devices are known to lose bytes if you change serial settings even to the same values as before. Avoid this by comparing the encoded settings with the previsouly used ones before configuring the device. The common case was fixed by commit bf5e5834bffc6 ("pl2303: Fix mode switching regr

[PATCH 02/26] USB: serial: constify device-id tables

2013-12-29 Thread Johan Hovold
Declare device-id tables as const where possible. Signed-off-by: Johan Hovold --- drivers/usb/serial/ftdi_sio.c | 2 +- drivers/usb/serial/ipaq.c | 2 +- drivers/usb/serial/metro-usb.c| 2 +- drivers/usb/serial/qcaux.c| 2 +- drivers/usb/serial/safe_serial

[PATCH 08/26] USB: pl2303: clean up driver somewhat

2013-12-29 Thread Johan Hovold
Use u16 rather than __u16. Fix multi-line comment style. Remove some comments. Remove unnecessary whitespace and add some where appropriate. Drop DRIVER_DESC define. Merge and simplify multi-line error message. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 61

[PATCH 03/26] USB: serial: clean up ioctl debugging

2013-12-29 Thread Johan Hovold
Remove redundant ioctl debugging from subdrivers. The ioctl request code has already been logged by usb-serial core. Signed-off-by: Johan Hovold --- drivers/usb/serial/f81232.c | 4 drivers/usb/serial/ftdi_sio.c | 8 +--- drivers/usb/serial/io_edgeport.c | 2 -- d

[PATCH 19/26] USB: pl2303: refactor baud-rate table lookup

2013-12-29 Thread Johan Hovold
Refactor supported baud-rate table lookup. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 55 +++-- 1 file changed, 33 insertions(+), 22 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 8d792afbe27f.

[PATCH 13/26] USB: pl2303: add line-status quirk for Siemens phones

2013-12-29 Thread Johan Hovold
Implement line-status handling for Siemens phones as a quirk rather than spreading such information all over the driver by matching on vendor and and product ids. Note that the SIEMENS_PRODUCT_ID_EF81, which was added after the line-status handling for the other Siemens phones was fixed, might als

[PATCH 09/26] USB: pl2303: add error handling to vendor read and write functions

2013-12-29 Thread Johan Hovold
Add error handling and clean up vendor read and write functions. Signed-off-by: Johan Hovold --- drivers/usb/serial/pl2303.c | 73 ++--- 1 file changed, 42 insertions(+), 31 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303

Re: [PATCH v8 2/2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-12-29 Thread Johan Hovold
On Sat, Dec 21, 2013 at 05:57:41PM +0100, Andrew Lunn wrote: > +/* Get the version of the firmware currently running. */ > +static int mxuport_get_fw_version(struct usb_serial *serial, u32 *version) > +{ > + u8 *ver_buf; > + int err; > + > + ver_buf = kzalloc(4, GFP_KERNEL); > + if

iBall 3.5G usb modem

2013-12-29 Thread Rahul Bedarkar
Hi, I am using iBall 3.5G usb modem. When I connected it to my laptop first time, it was detected by kernel but got segfault in usb_modeswitch. [ 104.856039] usb 1-1: new high-speed USB device number 4 using ehci-pci [ 104.990867] usb 1-1: New USB device found, idVendor=1c9e, idProduct=f000 [

Re: Alcatel usb modem

2013-12-29 Thread Lars Melin
On 2013-12-29 00:55, Greg KH wrote: On Sat, Dec 28, 2013 at 02:13:08PM +, thomas.takacs.a...@gmail.com wrote: Hi, I've seen this message: tell linux-usb... to add your device to a proper device. My USB modem is Alcatel One Touch X080C. Please kindly add it or inform me how can I fix it. Wha