Same problem here. HP elitebook 8560w. Running on Arch linux, kernel:
3.12.5. Attaching WD Elements 1TB.no
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.
Commit c02cecb92ed4 ("ARM: orion: move platform_data definitions")
moved the file to the current location but forgot to remove the pointer
to its previous location. Clean it up. While at it also change the header
file protection macros appropriately.
Signed-off-by: Sachin Kamat
---
include/linux
These patches fix cases where the return variable is not set to an error
code in an error case.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Julia Lawall
Set the return variable to an error code as done elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret =
> I hope it's OK that I submit the patch with the below changes to Greg
> for inclusion in v3.14. Let me know if you prefer to respin yourself.
Hi Johan
The patch looks good.
Acked-by: Andrew Lunn
> Thanks for all your work with fixing up and mainlining this driver!
And thanks for all the rev
Rename baud-rate encoding function to match tty naming.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 35aa4973a137..8d792afbe27f 100644
--- a/dr
Use direct baud-rate encoding rather than divisors for supported baud
rates.
This restores the way baud rates were set prior to commit 8d48fdf689fe
("USB: PL2303: correctly handle baudrates above 115200") which added
divisor encoding, but also switched to the new encoding method for all
baudrates
From: Andrew Lunn
Add a driver which supports the following Moxa USB to serial converters:
* 2 ports : UPort 1250, UPort 1250I
* 4 ports : UPort 1410, UPort 1450, UPort 1450I
* 8 ports : UPort 1610-8, UPort 1650-8
* 16 ports : UPort 1610-16, UPort 1650-16
The UPORT devices
Switch to generic tiocmiwait rather than rely on a custom implementation
using racy interruptible_sleep_on().
Note that this driver is mostly stubbed out so neither version of
tiocmiwait will actually work until someone implements
f81232_update_line_status().
Signed-off-by: Johan Hovold
---
dri
From: Andrew Lunn
Add the missing C_CMSPAR(tty) macro.
Signed-off-by: Andrew Lunn
Signed-off-by: Johan Hovold
---
include/linux/tty.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/tty.h b/include/linux/tty.h
index 97d660ed70c1..e53e90ed3f19 100644
--- a/include/linux/tty.h
Use speed_t for baud rates throughout.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 8dd1c4a0aefd..40f7b80b3601 100644
--- a/drivers/usb/se
Add quirk for legacy devices (type 0 and 1) rather than testing on
device type throughout the driver.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
Add helper function for direct baud-rate encoding.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 44f4b546adeb..b4e72979def7 10
Refactor baud-rate divisor handling.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 41 +
1 file changed, 25 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 394903b4ecb7..44f4b546a
Add error handling to set_control_lines.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 4058ceec884d..1fe8545e9926 100644
--- a/drivers/usb/seri
Merge types 0 and 1, whose differences are unknown and have always been
treated the same.
Add TYPE_-prefix to both types.
Test for TYPE_01 (rather than !TYPE_HX) for legacy device quirks.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 31 +++
1 file cha
Remove redundant get_line_request (the read back settings are never
used).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 28b10cfcb4d3..440b99c15435 100644
--- a/dri
Remove bogus MSR wait-queue wake up from process_read_urb which never
updates the MSR flags.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 3dd5398174c1..6234d55372cb 1
Use the new C_CMSPAR macro for consistency.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 28e598638e0a..253cc9c367c1 100644
--- a/drivers/usb/seri
Remove redundant error messages on allocation failures, which have
already been logged.
Cc: Joe Perches
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c| 4 +--
drivers/usb/serial/console.c | 2 --
drivers/usb/serial/cp210x.c | 8 ++---
drivers/usb/se
Hi Greg,
Here are a few patches for v3.14 (if it's not to late) including a new
driver by Andrew Lunn (and Moxa) for MOXA UPort devices, some subsystem
wide cleanups, and some pl2303 driver improvements.
The pl2303 patches fix one low-priority bug (still marked for stable)
and add some device-typ
Encode all device-type specifics in a struct rather than testing for
device type and spreading such information throughout the driver.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/driver
Remove bogus call to wake up delta_msr_wait from process_read_urb where
the MSR status is never updated (only the LSR bits are masked out).
Comment that the wake-up call should made in f81232_update_line_status
when the MSR status changes.
Note that this driver is still mostly stubbed out.
Signe
Refactor and add error handling to line requests.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 68 +
1 file changed, 51 insertions(+), 17 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 1fe854
Enforce any baud-rate limits before doing table lookup.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 9a95b92310f2..394903b4ecb7 100644
--- a/dr
Some PL2303 devices are known to lose bytes if you change serial
settings even to the same values as before. Avoid this by comparing the
encoded settings with the previsouly used ones before configuring the
device.
The common case was fixed by commit bf5e5834bffc6 ("pl2303: Fix mode
switching regr
Declare device-id tables as const where possible.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 2 +-
drivers/usb/serial/ipaq.c | 2 +-
drivers/usb/serial/metro-usb.c| 2 +-
drivers/usb/serial/qcaux.c| 2 +-
drivers/usb/serial/safe_serial
Use u16 rather than __u16.
Fix multi-line comment style.
Remove some comments.
Remove unnecessary whitespace and add some where appropriate.
Drop DRIVER_DESC define.
Merge and simplify multi-line error message.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 61
Remove redundant ioctl debugging from subdrivers. The ioctl request code
has already been logged by usb-serial core.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/f81232.c | 4
drivers/usb/serial/ftdi_sio.c | 8 +---
drivers/usb/serial/io_edgeport.c | 2 --
d
Refactor supported baud-rate table lookup.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 55 +++--
1 file changed, 33 insertions(+), 22 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 8d792afbe27f.
Implement line-status handling for Siemens phones as a quirk rather than
spreading such information all over the driver by matching on vendor and
and product ids.
Note that the SIEMENS_PRODUCT_ID_EF81, which was added after the
line-status handling for the other Siemens phones was fixed, might als
Add error handling and clean up vendor read and write functions.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 73 ++---
1 file changed, 42 insertions(+), 31 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303
On Sat, Dec 21, 2013 at 05:57:41PM +0100, Andrew Lunn wrote:
> +/* Get the version of the firmware currently running. */
> +static int mxuport_get_fw_version(struct usb_serial *serial, u32 *version)
> +{
> + u8 *ver_buf;
> + int err;
> +
> + ver_buf = kzalloc(4, GFP_KERNEL);
> + if
Hi,
I am using iBall 3.5G usb modem. When I connected it to my laptop
first time, it was detected by kernel but got segfault in
usb_modeswitch.
[ 104.856039] usb 1-1: new high-speed USB device number 4 using ehci-pci
[ 104.990867] usb 1-1: New USB device found, idVendor=1c9e, idProduct=f000
[
On 2013-12-29 00:55, Greg KH wrote:
On Sat, Dec 28, 2013 at 02:13:08PM +, thomas.takacs.a...@gmail.com wrote:
Hi,
I've seen this message: tell linux-usb... to add your device to a proper device.
My USB modem is Alcatel One Touch X080C.
Please kindly add it or inform me how can I fix it.
Wha
35 matches
Mail list logo