Hi Greg,
On Friday 27 September 2013 12:21 AM, Greg KH wrote:
> On Wed, Aug 21, 2013 at 11:16:07AM +0530, Kishon Vijay Abraham I wrote:
>> Used the generic PHY framework API to create the PHY. Now the power off and
>> power on are done in omap_usb_power_off and omap_usb_power_on respectively.
>> T
Used the generic PHY framework API to create the PHY. Now the power off and
power on are done in omap_usb_power_off and omap_usb_power_on respectively.
The omap-usb2 driver is also moved to driver/phy.
However using the old USB PHY library cannot be completely removed
because OTG is intertwined wi
Use the generic PHY framework API to get the PHY. The usb_phy_set_resume
and usb_phy_set_suspend is replaced with power_on and
power_off to align with the new PHY framework.
musb->xceiv can't be removed as of now because musb core uses xceiv.state and
xceiv.otg. Once there is a separate state mach
Now that twl4030-usb is adapted to the new generic PHY framework,
*set_suspend* and *phy_init* ops can be removed from twl4030-usb driver.
Signed-off-by: Kishon Vijay Abraham I
Acked-by: Felipe Balbi
Reviewed-by: Sylwester Nawrocki
---
drivers/phy/phy-twl4030-usb.c | 57 ++---
Used the generic PHY framework API to create the PHY. For powering on
and powering off the PHY, power_on and power_off ops are used. Once the
MUSB OMAP glue is adapted to the new framework, the suspend and resume
ops of usb phy library will be removed. Also twl4030-usb driver is moved
to drivers/ph
The PHY framework uses the phy consumer data populated in platform data in the
case of non-dt boot to return the reference to the PHY when the controller
(PHY consumer) requests for it. So populated the phy consumer data in the
platform
data of twl usb.
Signed-off-by: Kishon Vijay Abraham I
---
Added a generic PHY framework that provides a set of APIs for the PHY drivers
to create/destroy a PHY and APIs for the PHY users to obtain a reference to
the PHY with or without using phandle.
This framework will be of use only to devices that uses external PHY (PHY
functionality is not embedded w
The PHY framework provides a set of APIs for the PHY drivers to
create/destroy a PHY and APIs for the PHY users to obtain a reference to the
PHY with or without using phandle. For dt-boot, the PHY drivers should
also register *PHY provider* with the framework.
PHY drivers should create the PHY by
Updated the usb_otg_hs dt data to include the *phy* and *phy-names*
binding in order for the driver to use the new generic PHY framework.
Also updated the Documentation to include the binding information.
The PHY binding information can be found at
Documentation/devicetree/bindings/phy/phy-bindings
Hi Russell,
Thank you for the patch.
On Thursday 19 September 2013 22:56:02 Russell King wrote:
> The code sequence:
> isp->raw_dmamask = DMA_BIT_MASK(32);
> isp->dev->dma_mask = &isp->raw_dmamask;
> isp->dev->coherent_dma_mask = DMA_BIT_MASK(32);
> bypasses the architectures ch
Hi,
Sorry if I missed any previous discussion on this topic.
The msdn link [1] says that
The host does not continuously poll the USB Control endpoint for input
control messages. Upon placing a control message on its Control
endpoint, the device must return a notification on the Communication
Cla
> That behavior was seen on the Synopsys host, not the Intel host,
> correct?
Yes. Looks like the L1 transitions that are not fatal on the Intel
host are much longer in my trace, usually above 100ms. This would be
another indication that in the Synopsys case the L1 resume is
host-triggered.
> Ok.
On Tue, Sep 24, 2013 at 08:22:31PM -0700, Julius Werner wrote:
> > My hypothesis is that the Synopsys host doesn't go into L1 if the device
> > NAKs a transfer, only when the bus is idle. That way, it doesn't have
> > to depend on L1 remote wakeup, which is broken for these devices. I
> > don't h
Dear Alan,
thank you very much for your reply. It was very encouraging. I am
totally new to kernel development and it took me quite some time to
gather all the bits needed for this simple glue driver.
On Tue, Sep 24, 2013 at 5:22 PM, Alan Stern wrote:
> On Mon, 23 Sep 2013, Arokux X wrote:
>
>>
On Thu, 26 Sep 2013, Bjorn Helgaas wrote:
> On Thu, Sep 26, 2013 at 10:45 AM, Greg Kroah-Hartman
> wrote:
> > On Fri, Sep 13, 2013 at 01:57:42PM -0600, Bjorn Helgaas wrote:
> >> usb_bus_list_lock is used by usbfs, but that's in the same module as
> >> hcd.c, so there's no need to export it. Upda
On Thu, Sep 26, 2013 at 01:39:04PM -0700, David Cohen wrote:
> Hi Greg,
>
> On 09/26/2013 01:14 PM, Greg KH wrote:
> >On Thu, Sep 26, 2013 at 01:01:44PM -0700, David Cohen wrote:
> >>Add PCI id for Intel Merrifield
> >>
> >>Signed-off-by: David Cohen
> >>---
> >> drivers/usb/dwc3/dwc3-pci.c | 2
Hi Greg,
On 09/26/2013 01:14 PM, Greg KH wrote:
On Thu, Sep 26, 2013 at 01:01:44PM -0700, David Cohen wrote:
Add PCI id for Intel Merrifield
Signed-off-by: David Cohen
---
drivers/usb/dwc3/dwc3-pci.c | 2 ++
1 file changed, 2 insertions(+)
Nice, Felipe, mind if I just pick this up now, a
2013/9/19 Russell King - ARM Linux :
> This email is only being sent to the mailing lists in question, not to
> anyone personally. The list of individuals is far to great to do that.
> I'm hoping no mailing lists reject the patches based on the number of
> recipients.
Huh, I think it was enough t
On Thu, Sep 26, 2013 at 01:01:44PM -0700, David Cohen wrote:
> Add PCI id for Intel Merrifield
>
> Signed-off-by: David Cohen
> ---
> drivers/usb/dwc3/dwc3-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
Nice, Felipe, mind if I just pick this up now, as I'm applying USB
patches at the moment...
Add PCI id for Intel Merrifield
Signed-off-by: David Cohen
---
drivers/usb/dwc3/dwc3-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 997ebe4..2e252aa 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-p
This patch updates __wa_xfer_setup_segs error path to only clean up the
xfer->seg entry that it failed to create and then set that entry to
NULL. wa_xfer_destroy will clean up the remaining xfer->segs that were
fully created. It also moves the code to create the dto sg list to an
out of line func
This set of patches fixes a few cases where objects were being
incompletely cleaned up by error handlers which could cause double free
conditions or NULL dereferences in those cases. There is also a memory
leak fix for out transfers on the HWA.
These should be applied after the struct field re
If __wa_xfer_setup fails, it can leave a partially constructed wa_xfer
object. The error handling code eventually calls wa_xfer_destroy which
does not check for NULL before dereferencing xfer->seg which could cause
a kernel panic. This change also makes sure to free xfer->seg which was
being leak
This patch fixes two cases where error handling code was freeing memory
but not setting the pointer to NULL. This could lead to a double free
in the HWA shutdown code.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/driv
Clean up the SG list after transfer completetion for out transfers if one
was created by the HWA.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c
index 453
On Wed, Aug 21, 2013 at 11:16:07AM +0530, Kishon Vijay Abraham I wrote:
> Used the generic PHY framework API to create the PHY. Now the power off and
> power on are done in omap_usb_power_off and omap_usb_power_on respectively.
> The omap-usb2 driver is also moved to driver/phy.
>
> However using
On Thu, Sep 26, 2013 at 10:45 AM, Greg Kroah-Hartman
wrote:
> On Fri, Sep 13, 2013 at 01:57:42PM -0600, Bjorn Helgaas wrote:
>> usb_bus_list_lock is used by usbfs, but that's in the same module as
>> hcd.c, so there's no need to export it. Update the comment to show
>> that it protects the set of
On Sat, Sep 21, 2013 at 04:38:38PM +0530, Manjunath Goudar wrote:
> Separate the Samsung OHCI EXYNOS host controller driver from ohci-hcd
> host code so that it can be built as a separate driver module.
> This work is part of enabling multi-platform kernels on ARM.
>
> Signed-off-by: Manjunath Go
On Fri, Sep 13, 2013 at 01:57:42PM -0600, Bjorn Helgaas wrote:
> usb_bus_list_lock is used by usbfs, but that's in the same module as
> hcd.c, so there's no need to export it. Update the comment to show
> that it protects the set of root hubs as well as the list of buses.
usbmon also uses this, s
Hi,
Le Thu, 26 Sep 2013 17:59:39 +0200,
Christoph Fritz a écrit :
> On Wed, 2013-09-25 at 16:00 +0200, Eric Bénard wrote:
> > Le Wed, 25 Sep 2013 12:17:40 +0200,
> > Christoph Fritz a écrit :
> >
> > > On Tue, 2013-04-09 at 14:28 -0300, Fabio Estevam wrote:
> > > > On Mon, Apr 8, 2013 at 9:09
Rename xfer_result to dti_buf and xfer_result_size to dti_buf_size in
struct wahc. The dti buffer will also be used for isochronous status
packets once isochronous transfers are supported.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-hc.c | 14 +++---
drivers/usb/wu
Hi,
This set of patches renames various data fields in wa_seg and wahc
to more clearly specify their purpose. I plan to add isochronous
support to wusbcore soon and these changes will make that patch easier
to comprehend.
Thomas Pugliese (2):
usb: wusbcore: rename urb to tr_urb in struct w
Rename urb to tr_urb in struct wa_seg to make it clear that the urb is
used for the transfer request.
Signed-off-by: Thomas Pugliese
---
drivers/usb/wusbcore/wa-xfer.c | 30 --
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/wusbcore/wa
On Wed, 2013-09-25 at 16:00 +0200, Eric Bénard wrote:
> Le Wed, 25 Sep 2013 12:17:40 +0200,
> Christoph Fritz a écrit :
>
> > On Tue, 2013-04-09 at 14:28 -0300, Fabio Estevam wrote:
> > > On Mon, Apr 8, 2013 at 9:09 PM, Fabio Estevam wrote:
> > >
> > > >> I know that I have to use the driver UL
On Tue, Sep 24, 2013 at 03:19:24PM -0400, Alex MacPherson wrote:
> Hello,
>
> Can you add the startech.com usb to serial adapter to a proper
> driver. I am using the command
>
> sudo modprobe usbserial vendor=0x14b0 product=0x3410
>
> It works on my ubuntu 12.04 AMD 64 desktop system but my
Suspend and resume of cards are handled by the protocol layer and
consequently the mmc_suspend|resume_host APIs are marked as deprecated.
While moving away from using the deprecated APIs, there are nothing
left to be done for the suspend and resume callbacks, so remove them.
Cc: Tony Olech
Cc: l
Aleksander Morgado writes:
> Cinterion PLXX LTE devices have a 0x0060 product ID, not 0x12d1.
>
> The blacklisting in the serial/option driver does actually use the
> correct PID, as per commit 8ff10bdb14a52e3f25d4ce09e0582a8684c1a6db
> ('USB: Blacklisted Cinterion's PLxx WWAN Interface').
Thank
> > In this logging I plugged-in the device and waited for it to disconnect
> > and reconnect again.
> > I googled but did not find something that translates this logging into
> > human readable format. Are there any that you know of?
>
> No. But I can interpret it for you.
thanks!
> Almost 7 s
The dsps platform needs to save save some registers at suspend time and
restore them after resume. This patch adds a struct for these registers,
and also lets the musb core know that the core registers need to be
saved as well.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_dsps.c | 54 +++
I've been working on some patches that allow suspending and resuming
the musb-dsps platform. This was tested for host mode only.
With these patches applied, I can successfully bring an AM335x board
to suspend with a USB media connected, and access it again after
resume. Note that this currently on
Make musb_port_suspend() externally available, and call it when to host
goes into suspend. This allows the core to go into suspend while a
device is connected.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_host.c| 2 ++
drivers/usb/musb/musb_host.h| 2 ++
drivers/usb/musb/musb_vir
musb_port_reset() sleeps, so we can't call it from atomic context. It
is, however, called from places inside musb_hub_control() while
&musb->lock is held, which leads to a "scheduling while atomic" warning.
Fix this by moving the logic into a worker, and call it where the
function was previously c
It appears not all platforms featuring a musb core need to save the musb
core registers at suspend time and restore them on resume.
The dsps platform does, however. So add a bit in struct
musb_hdrc_platform_data to let platforms specify their need of such
action being taken.
Signed-off-by: Daniel
Convert the legacy multi gadget to the new interface of f_ecm,
so that later the compatibility layer in f_ecm can be removed.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/multi.c | 68
Convert the legacy multi gadget to the new interface of f_rndis,
so that later the compatibility layer in f_rndis can be removed.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/Kconfig |3 +-
drivers/usb/gadget/multi.c | 73 +++
There are no more old interface users left. Remove it.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/f_mass_storage.c | 154 +--
drivers/usb/gadget/f_mass_storage.h | 21 -
2 files changed, 1 insertions(+), 174 de
u_ms.ko is needed only together with usb_f_mass_storage.ko. Merge them.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/Kconfig |7 ---
drivers/usb/gadget/Makefile |4 +---
2 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/driv
Convert the legacy multi gadget to the new interface of f_mass_storage,
so that later the compatibility layer in f_mass_storage can be removed.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/multi.c | 112 ++
Here I present the conversion of everything that is required to provide
the equivalent of g_multi.ko with configfs.
v1..v2:
- removed the cause of Felipe returning -ENOLOG
- moved fsg_common_set_sysfs invocation after the lun number is set, so that
the latter operation does not try freeing nonexi
Convert the legacy acm_ms gadget to use the new function interface
of f_mass_storage, so that later the compatibility layer in
f_mass_storage can be removed.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/acm_ms.c |
Here I present the conversion of everything that is required to provide
the equivalent of g_acm_ms.ko with configfs.
In fact this series consists of just one patch; everything required to provide
the equivalent of g_acm_ms.ko with configfs has been done in the series related
to the g_mass_storage.
When configfs is in place, the things related to intialization
of struct fsg_common will be split over a number of places.
This patch adds several functions which together cover the former
intialization routine fsg_common_init.
When configfs is in place, the luns will not be represented in sysfs,
Converting to configfs requires making the f_mass_storage.c a module.
But first we need to get rid of "#include "storage_common.c".
This patch makes storage_common.c a separately compiled file, which is
built as a utility module named u_ms.ko. After all mass storage users are
converted to the new f
This will be required by configfs integration.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungin Park
---
drivers/usb/gadget/storage_common.c | 42 +++
drivers/usb/gadget/storage_common.h |5
2 files changed, 47 insertions(+), 0 deletions(-)
Prepare for handling with configfs.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/f_mass_storage.c | 25 -
1 files changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/gadget/f_mass_storage.c
b/drivers/usb/gad
>From this commit on f_mass_storage is available through configfs.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
.../ABI/testing/configfs-usb-gadget-mass-storage | 31 ++
drivers/usb/gadget/Kconfig | 11 +
drivers/usb/gadget/f_mass_storage.c
Converting mass storage to the new function interface requires converting
the USB mass storage's function code and its users.
This patch converts the f_mass_storage.c to the new function interface.
The file is now compiled into a separate usb_f_mass_storage.ko module.
The old function interface is
fsg_common_init is a lengthy function. Now there are helper functions
which cover all parts of it. Use them.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/f_mass_storage.c | 23 ++-
1 files changed, 2 insertions(+), 21 deletions(-
Show/store methods for sysfs attributes contain code which can be used
also by configfs. Make them abstract the source the lun and rw_semaphore
are taken from.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/f_mass_storage.c | 27 +-
fsg_common_init is a lengthy function. Now there are helper functions
which cover all parts of it. Use them.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/f_mass_storage.c | 22 +-
1 files changed, 5 insertions(+), 17 deletions(-)
fsg_common_init is a lengthy function. Now there are helper functions
which cover all parts of it. Use them.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/f_mass_storage.c | 14 +++---
1 files changed, 3 insertions(+), 11 deletions(-)
diff -
fsg_common_init is a lengthy function. Now there are helper functions
which cover all parts of it. Use them.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/f_mass_storage.c | 101 ++-
1 files changed, 4 insertions(+), 97
fsg_common_init is a lengthy function. Now there are helper functions
which cover all parts of it. Use them.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/f_mass_storage.c | 13 +++--
1 files changed, 3 insertions(+), 10 deletions(-)
diff --
fsg_common_init is a lengthy function. Now there are helper functions
which cover all parts of it. Use them.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/f_mass_storage.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/dri
fsg_common_init is a lengthy function. Now there are helper functions
which cover all parts of it. Use them.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/f_mass_storage.c | 29 +++--
1 files changed, 3 insertions(+), 26 delet
fsg_common_init is a lengthy function. Now there are helper functions
which cover all parts of it. Use them.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/f_mass_storage.c | 19 +++
1 files changed, 3 insertions(+), 16 deletions(-)
d
Convert old mass_storage gadget to use the new interface of f_mass_storage
so that later the compatibility layer in f_mass_storage can be removed.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/Kconfig|1 +
drivers/usb/gadget/mass_storage.c
In order to prepare for the new function interface the f_mass_storage.c
needs to be compiled as a module, and so a header file will be required.
This patch factors out some code to a new f_mass_storage.h.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/f
This is needed to prepare for configfs integration.
So far the luns have been allocated during gadget's initialization, based
on the nluns module parameter's value; the exact number is known when the
gadget is initialized and that number of luns is allocated in one go; they
all will be used.
When
This series aims at integrating configfs into mass storage, the way
it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex and phonet.
It contains everything that is required to provide the equivalent of
g_mass_storage.ko with configfs.
Mass storage itself is quite large, so the resultin
Add a method to unregister the gadget using its config_item.
There can be functions (e.g. mass storage), which in some circumstances
need the gadget stopped. Add a method of stopping the gadget.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/configfs.c
Hi,
On 09/24/2013 09:43 PM, Alan Stern wrote:
This patch straightens out some locking issues in the USB sysfs
interface:
Deauthorization will destroy existing configurations.
Attributes that read from udev->actconfig need to lock the
device to prevent races. Likewise fo
On Thu, Sep 26, 2013 at 12:18:34PM +0200, Dominik Paulus wrote:
> > I think a return of zero should mean total = -EBADMSG;. In other words
> > this check should be "if (ret < 0) {" and we hit the next else if.
> > Same below again.
>
> As we are wrapping kernel_recvmsg here, we wanted to leave th
> Anything that breaks a previously unbroken argument list will reduce the
> readability in my opinion. The lines can of course not be unlimited,
> but there is no need to set the limit as low as 80 columns. Feedback
> I've got from developers using e.g. 80 column braille devices is that
> longer
On 21 September 2013 12:30, Valentin Ilie wrote:
> When trb_hw is NULL, trb should be free'd before return.
>
> Signed-off-by: Valentin Ilie
> ---
> drivers/usb/gadget/mv_u3d_core.c |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/gadget/mv_u3d_core.c
> b/drivers/usb/ga
Hi,
On Friday 20 September 2013 04:41 AM, Russell King wrote:
The correct way for a driver to specify the coherent DMA mask is
not to directly access the field in the struct device, but to use
dma_set_coherent_mask(). Only arch and bus code should access this
member directly.
Convert all direc
Fabio Porcedda writes:
> Hi Bjørn,
> thanks for reviewing.
>
> On Wed, Sep 25, 2013 at 3:31 PM, Bjørn Mork wrote:
>> Sorry, I really don't see the point of this. Yes, the lines are longer
>> than 80 columns, but breaking them don't improve the readability at
>> all. On the contrary, IMHO.
>>
>
Hi,
thank you very much for your feedback!
On Mon, Sep 23, 2013 at 12:59:29PM +0300, Dan Carpenter wrote:
> > + while (total < size) {
> > + uint32_t packetsize;
> > + struct kvec recvvec;
> > +
> > + /*
> > +* We use a global kfifo to buffer unrequeste
On Mon, Sep 23, 2013 at 08:31:48PM +0100, Felipe Balbi wrote:
> Hi,
>
> On Tue, Aug 20, 2013 at 12:56:03PM +0300, Ivan T. Ivanov wrote:
> > From: "Ivan T. Ivanov"
> >
> > MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys
> > (SNPS) and HS, SS PHY's control and configuration registers.
>
Hi folks,
On Tue, Sep 24, 2013 at 11:08:53AM -0500, Felipe Balbi wrote:
> > > On Mon, Sep 23, 2013 at 02:23:33PM -0700, Paul Zimmerman wrote:
> > > > + if ((urb->actual_length < 0 || urb->actual_length >
> > > > urb->length) &&
> > > > + !dwc2_hcd_is_pipe_in(&urb->pipe_info))
> >
Hi Bjørn,
thanks for reviewing.
On Wed, Sep 25, 2013 at 3:31 PM, Bjørn Mork wrote:
> Sorry, I really don't see the point of this. Yes, the lines are longer
> than 80 columns, but breaking them don't improve the readability at
> all. On the contrary, IMHO.
>
> So NAK from me for this part.
Whic
At Mon, 23 Sep 2013 16:41:07 -0700,
Sarah Sharp wrote:
>
> The snd-usb-audio driver no longer loads properly on 3.12-rc2 when I
> plug in my USB headset. It worked fine on 3.11-rc4 (not sure about
> vanilla 3.11).
>
> Trying to manually load the driver fails:
>
> sarah@xanatos:~$ sudo modprobe
* Daniel Mack | 2013-09-22 16:50:03 [+0200]:
>cdd->cd and cdd->descs_phys are allocated DESCS_AREAS times from
>init_descs() and freed as often from purge_descs(). This leads to both
>memory leaks and double-frees.
>
>Fix this by pulling the calls to dma_{alloc,free}_coherent() out of the
>loops.
On 09/24/2013 05:52 PM, Daniel Mack wrote:
> Hi Sarah,
>
> On 24.09.2013 01:41, Sarah Sharp wrote:
>> The snd-usb-audio driver no longer loads properly on 3.12-rc2 when I
>> plug in my USB headset. It worked fine on 3.11-rc4 (not sure about
>> vanilla 3.11).
>>
>> Trying to manually load the driv
Signed-off-by: Duan Jiong
---
drivers/usb/gadget/configfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
index 8f0d614..1bfacbf 100644
--- a/drivers/usb/gadget/configfs.c
+++ b/drivers/usb/gadget/configfs.c
@@
On 9/26/2013 2:10 AM, Felipe Balbi wrote:
Hi,
(please avoid top-posting)
On Tue, Sep 24, 2013 at 03:00:20PM +0530, Manu Gautam wrote:
Hi Felipe,
I wanted to mention one point with respect to this patch: Below
changes in the functionfs.h to add ss_count (super speed descriptors
count) in desc_
86 matches
Mail list logo
