Re: Audio I/O parameters

2013-07-25 Thread Clemens Ladisch
Alan Stern wrote: > On Thu, 25 Jul 2013, James Stone wrote: >> The only slight difference I can see is that maybe the 3.10 uses >> slightly higher CPU load than 3.5 at the ridiculously low latency of >> 64 frames/period duplex. > > With the new patch, what you actually get is 44.1 frames/period (on

RE: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Ivan T. Ivanov
Hi, On Fri, 2013-07-26 at 02:06 +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Thursday, July 25, 2013 1:52 PM > > > > On Thu, Jul 25, 2013 at 07:46:58PM +, Paul Zimmerman wrote: > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > >

Re: [PATCH] usb: udc: add gadget state kobject uevent

2013-07-25 Thread Barry Song
2013/7/18 Felipe Balbi : > On Thu, Jul 18, 2013 at 05:28:19PM +0800, Rong Wang wrote: >> Hi Felipe, >> >> Thanks, I'll test the patch. >> >> But sysfs_notify(&gadget->dev.kobj, NULL, "status"), status or state ? >> I notice that DEVICE_ATTR(state, S_IRUGO, usb_gadget_state_show, NULL) > > good eyes

[PATCH] USB: serial: add driver for Suunto ANT+ USB device

2013-07-25 Thread Greg Kroah-Hartman
Steinar, I've tested the driver below with my device and it seems to work. If you have any problems with it, please let me know, otherwise I'll queue it up to get into the 3.11 kernel release soon. thanks, greg k-h - From: Greg Kroah-Hartman This adds a driver

Re: [PATCH] chipidea: ci_hdrc_imx: Remove unused variable 'res'

2013-07-25 Thread Peter Chen
On Thu, Jul 25, 2013 at 12:55:28AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > 'res' is not used anywhere, so let's get rid of it. > > Signed-off-by: Fabio Estevam > --- > drivers/usb/chipidea/ci_hdrc_imx.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/usb/c

Re: [PATCH] chipidea: core: Move hw_phymode_configure() into probe

2013-07-25 Thread Peter Chen
On Thu, Jul 25, 2013 at 06:20:34PM -0300, Fabio Estevam wrote: > Currently hw_phymode_configure() is located inside hw_device_reset(), which is > only called by chipidea udc driver. > > When operating in host mode, we also need to call hw_phymode_configure() in > order to properly configure the P

RE: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Thursday, July 25, 2013 1:52 PM > > On Thu, Jul 25, 2013 at 07:46:58PM +, Paul Zimmerman wrote: > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > index 607bef8..50c833f 100644 > > > --- a/drivers/usb/dwc3/core.c > > >

Re: Suunto ANT+ stick

2013-07-25 Thread Greg KH
On Thu, Jul 25, 2013 at 01:23:54PM +0200, Steinar H. Gunderson wrote: > Hi, > > I have a Suunto ANT+ stick (designed to communicate with various training > equipment) that works as a USB serial device. Unfortunately, it seems like > its PCI IDs are missing; it doesn't come up unless I add vendor=

Re: Audio I/O parameters

2013-07-25 Thread James Stone
On Thu, Jul 25, 2013 at 10:24 PM, Alan Stern wrote: > On Thu, 25 Jul 2013, James Stone wrote: > >> On Thu, Jul 25, 2013 at 7:26 PM, Alan Stern >> wrote: >> > On Thu, 25 Jul 2013, James Stone wrote: >> > >> >> > Please try the patch from here: >> >> > >> >> > http://marc.info/?l=linux-usb

[PATCH V5] usb: Add Device Tree support to XHCI Platform driver

2013-07-25 Thread Al Cooper
Add Device Tree match table to xhci-plat.c. Add DT bindings document. Signed-off-by: Al Cooper --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 14 ++ drivers/usb/host/xhci-plat.c | 10 ++ 2 files changed, 24 insertions(+), 0 deletions(-) cr

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Jack Pham
On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > The USB Embedded High-speed Host Electrical Test (EHSET) defines the > SINGLE_STEP_SET_FEATURE test as follows: > diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c > index 2b70277..8e6dc09 100644 > --- a/drivers/usb/

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, Felipe Balbi wrote: > On Thu, Jul 25, 2013 at 03:44:20PM -0400, Alan Stern wrote: > > On Thu, 25 Jul 2013, Greg KH wrote: > > > > > On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > > > > From: Manu Gautam > > > > > > > > The USB Embedded High-speed Host Electric

Re: Audio I/O parameters

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, James Stone wrote: > On Thu, Jul 25, 2013 at 7:26 PM, Alan Stern wrote: > > On Thu, 25 Jul 2013, James Stone wrote: > > > >> > Please try the patch from here: > >> > > >> > http://marc.info/?l=linux-usb&m=137476385206265&w=2 > >> > > >> > instead of the one I sent to

[PATCH] chipidea: core: Move hw_phymode_configure() into probe

2013-07-25 Thread Fabio Estevam
Currently hw_phymode_configure() is located inside hw_device_reset(), which is only called by chipidea udc driver. When operating in host mode, we also need to call hw_phymode_configure() in order to properly configure the PHY mode, so move this function into probe. After this change, USB Host1

Re: [PATCH v5 3/5] USB: EHCI: improve ehci_endpoint_disable

2013-07-25 Thread Ming Lei
On Fri, Jul 26, 2013 at 4:55 AM, Greg Kroah-Hartman wrote: > On Fri, Jul 26, 2013 at 04:52:36AM +0800, Ming Lei wrote: >> Hi Greg, >> >> On Fri, Jul 26, 2013 at 3:48 AM, Alan Stern >> wrote: >> > On Thu, 25 Jul 2013, Greg Kroah-Hartman wrote: >> > >> >> On Wed, Jul 03, 2013 at 10:53:09PM +0800,

Re: [PATCH V4] usb: Add Device Tree support to XHCI Platform driver

2013-07-25 Thread Sergei Shtylyov
On 07/25/2013 11:51 PM, Alan Cooper wrote: The node should be named just "usb", not "xhci" (no programming interface specific names), according to the ePAPR spec [1]. What about the existing node names "ohci@" and "ehci@"? Unfortunately, they are all wrong, as many others. It se

Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-25 Thread Olof Johansson
On Thu, Jul 25, 2013 at 10:19 AM, Felipe Balbi wrote: > On Thu, Jul 25, 2013 at 09:18:39AM -0700, Olof Johansson wrote: >> That's what the code does today, and I wasn't trying to second-guess >> their decisions on that. Chances are firmware, in some instances, have >> left power on so continuing m

Re: [PATCH v5 3/5] USB: EHCI: improve ehci_endpoint_disable

2013-07-25 Thread Greg Kroah-Hartman
On Fri, Jul 26, 2013 at 04:52:36AM +0800, Ming Lei wrote: > Hi Greg, > > On Fri, Jul 26, 2013 at 3:48 AM, Alan Stern wrote: > > On Thu, 25 Jul 2013, Greg Kroah-Hartman wrote: > > > >> On Wed, Jul 03, 2013 at 10:53:09PM +0800, Ming Lei wrote: > >> > The patch does the below improvement: > >> > > >

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Felipe Balbi
On Thu, Jul 25, 2013 at 03:44:20PM -0400, Alan Stern wrote: > On Thu, 25 Jul 2013, Greg KH wrote: > > > On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > > > From: Manu Gautam > > > > > > The USB Embedded High-speed Host Electrical Test (EHSET) defines the > > > SINGLE_STEP_SET_FEATUR

Re: [PATCH v5 3/5] USB: EHCI: improve ehci_endpoint_disable

2013-07-25 Thread Ming Lei
Hi Greg, On Fri, Jul 26, 2013 at 3:48 AM, Alan Stern wrote: > On Thu, 25 Jul 2013, Greg Kroah-Hartman wrote: > >> On Wed, Jul 03, 2013 at 10:53:09PM +0800, Ming Lei wrote: >> > The patch does the below improvement: >> > >> > - think QH_STATE_COMPLETING as unlinking state since all URBs on the >>

Re: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 07:46:58PM +, Paul Zimmerman wrote: > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > index 607bef8..50c833f 100644 > > --- a/drivers/usb/dwc3/core.c > > +++ b/drivers/usb/dwc3/core.c > > @@ -384,21 +384,6 @@ static int dwc3_probe(struct platfor

Re: [PATCH] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-07-25 Thread Matthijs Kooijman
Hi Paul, > > Furthermore, I wonder about how this scheduler works exactly. What I see > > is: > > - the number usecs needed for a single transfer in a periodic qh is > >calculated > > - When the qh is scheduled, the first of the 8 microframes with enough > >usecs available is picked for

Re: [PATCH V4] usb: Add Device Tree support to XHCI Platform driver

2013-07-25 Thread Alan Cooper
On Thu, Jul 25, 2013 at 1:10 PM, Sergei Shtylyov wrote: > The node should be named just "usb", not "xhci" (no programming > interface > specific names), according to the ePAPR spec [1]. > > > What about the existing node names "ohci@" and "ehci@"? > > >>> Unfortunately,

Re: [PATCH v5 3/5] USB: EHCI: improve ehci_endpoint_disable

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, Greg Kroah-Hartman wrote: > On Wed, Jul 03, 2013 at 10:53:09PM +0800, Ming Lei wrote: > > The patch does the below improvement: > > > > - think QH_STATE_COMPLETING as unlinking state since all URBs on the > > endpoint should be in unlinking or unlinked when doing endpoint_dis

RE: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Paul Zimmerman
> From: Ivan T. Ivanov > Sent: Thursday, July 25, 2013 9:27 AM > > When deferred probe happens driver will try to ioremap multiple times > and will fail. Memory resource.start variable is a global variable, > modifications in this field will be accumulated on every probe. > Fix this by moving the

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, Greg KH wrote: > On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > > From: Manu Gautam > > > > The USB Embedded High-speed Host Electrical Test (EHSET) defines the > > SINGLE_STEP_SET_FEATURE test as follows: > > > > 1) The host enumerates the test device with VI

[PATCH] usb: phy: tegra: Use switch instead of if-else

2013-07-25 Thread Tuomas Tynkkynen
Use switch() instead of if-else when checking for the PHY type. Signed-off-by: Tuomas Tynkkynen --- Ah :). Here. drivers/usb/phy/phy-tegra-usb.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c inde

Re: [PATCH v3 8/9] usb: phy: tegra: Use DT helpers for phy_type

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 10:11:16PM +0300, Tuomas Tynkkynen wrote: > Use the new of_usb_get_phy_mode helper function for parsing phy_type > from the device tree. > > Signed-off-by: Tuomas Tynkkynen > Reviewed-by: Stephen Warren > Tested-by: Stephen Warren > --- > Here's the version with swi

Re: [PATCH v3 8/9] usb: phy: tegra: Use DT helpers for phy_type

2013-07-25 Thread Tuomas Tynkkynen
Use the new of_usb_get_phy_mode helper function for parsing phy_type from the device tree. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- Here's the version with switch(). drivers/usb/phy/phy-tegra-usb.c | 17 + 1 file changed, 13 ins

Re: Audio I/O parameters

2013-07-25 Thread James Stone
On Thu, Jul 25, 2013 at 7:26 PM, Alan Stern wrote: > On Thu, 25 Jul 2013, James Stone wrote: > >> > Please try the patch from here: >> > >> > http://marc.info/?l=linux-usb&m=137476385206265&w=2 >> > >> > instead of the one I sent to you yesterday. I think it will fix this >> > problem. >>

Re: [PATCH v5 3/5] USB: EHCI: improve ehci_endpoint_disable

2013-07-25 Thread Greg Kroah-Hartman
On Wed, Jul 03, 2013 at 10:53:09PM +0800, Ming Lei wrote: > The patch does the below improvement: > > - think QH_STATE_COMPLETING as unlinking state since all URBs on the > endpoint should be in unlinking or unlinked when doing endpoint_disable() > > - add "WARN_ON(!list_empty(&qh->qtd_list));" i

Re: [PATCH v3 8/9] usb: phy: tegra: Use DT helpers for phy_type

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 09:38:08PM +0300, Tuomas Tynkkynen wrote: > Use the new of_usb_get_phy_mode helper function for parsing phy_type > from the device tree. > > Signed-off-by: Tuomas Tynkkynen > Reviewed-by: Stephen Warren > Tested-by: Stephen Warren > --- > drivers/usb/phy/phy-tegra-

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Greg KH
On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: > From: Manu Gautam > > The USB Embedded High-speed Host Electrical Test (EHSET) defines the > SINGLE_STEP_SET_FEATURE test as follows: > > 1) The host enumerates the test device with VID:0x1A0A, PID:0x0108 > 2) The host sends the SETUP

[PATCH v3 5/9] usb: phy: tegra: Register as an USB PHY.

2013-07-25 Thread Tuomas Tynkkynen
Register the Tegra PHY device instances with the PHY subsystem so that the Tegra EHCI driver can locate a PHY via the standard APIs. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- v2 diff: Do the usb_add_phy_dev as the very last thing in .probe driver

[PATCH v3 2/9] usb: host: tegra: Remove leftover code

2013-07-25 Thread Tuomas Tynkkynen
ehci-tegra calls devm_usb_get_phy, which will never succeed since the Tegra PHY does not register itself with the PHY subsystem. It is also completely redundant since the code has already located a PHY via an internal API. Call otg_set_host unconditionally to simplify the code since it should be s

[PATCH v3 1/9] usb: phy: tegra: Remove unnecessary 'dev' field

2013-07-25 Thread Tuomas Tynkkynen
struct usb_phy already has a field for the device pointer, so this unnecessary field can be removed. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- v3 diff: A whitespace change in v3 of Mikko's regulator patch drivers/usb/phy/phy-tegra-usb.c | 27 ++

[PATCH v3 0/9] Tegra USB cleanup series

2013-07-25 Thread Tuomas Tynkkynen
Hi, Here's a V3 of the few cleanup patches for the Tegra USB drivers, to be applied on top of Mikko's two patch sets. It mostly deals with removing all usage of platform data and using standard helpers and enums instead of Tegra-specific ones. v3 diff: Rebased on v3 of Mikko's regulator patch

[PATCH v3 8/9] usb: phy: tegra: Use DT helpers for phy_type

2013-07-25 Thread Tuomas Tynkkynen
Use the new of_usb_get_phy_mode helper function for parsing phy_type from the device tree. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- drivers/usb/phy/phy-tegra-usb.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/

[PATCH v3 4/9] ARM: tegra: Remove USB platform data

2013-07-25 Thread Tuomas Tynkkynen
USB-related platform data is not used anymore in the Tegra USB drivers, so remove all of it. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren Acked-by: Stephen Warren --- arch/arm/mach-tegra/tegra.c | 38 + inclu

Re: usbtmc / 3.9.x: Reading from Siglent SDS1xxx returned random host memory

2013-07-25 Thread Greg KH
On Sun, Jul 14, 2013 at 11:32:13PM +0200, Florian Knodt wrote: > Hello, > > Am 14.07.2013 23:04, schrieb Greg KH: > > So does 3.10.1 work properly for you? > > No, with the latest kernel it does no longer return any data for larger > requests on this scope, but it thus also stopped leaking random

[PATCH v3 7/9] usb: phy: tegra: Remove custom PHY locating APIs

2013-07-25 Thread Tuomas Tynkkynen
The Tegra EHCI driver is no longer using these custom functions, so they can be removed. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- drivers/usb/phy/phy-tegra-usb.c | 24 include/linux/usb/tegra_usb_phy.h | 2 -- 2 files

[PATCH v3 6/9] usb: host: tegra: Locate a PHY via standard API

2013-07-25 Thread Tuomas Tynkkynen
Use devm_get_phy_by_phandle to get a PHY device instead of the custom Tegra functions. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- drivers/usb/host/ehci-tegra.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/usb

[PATCH v3 3/9] usb: tegra: host: Remove references to plat data

2013-07-25 Thread Tuomas Tynkkynen
Platform data is not used in tegra-ehci anymore, so remove all references to it. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- drivers/usb/host/ehci-tegra.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/dr

[PATCH v3 9/9] usb: phy: tegra: Use DT helpers for dr_mode

2013-07-25 Thread Tuomas Tynkkynen
Use the new of_usb_get_dr_mode helper function for parsing dr_mode from the device tree. Also replace the usage of the custom tegra_usb_phy_mode enum with the standard enum. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- v2 diff: Default to host mode i

Re: [PATCH 1/3] USB: mos7840: fix race in register handling

2013-07-25 Thread Greg KH
On Sun, Jun 30, 2013 at 08:42:07PM +0200, Johan Hovold wrote: > Fix race in mos7840_get_reg which unconditionally manipulated the > control urb (which may already be in use) by adding a control-urb busy > flag. > > Cc: sta...@vger.kernel.org > Signed-off-by: Johan Hovold > --- > drivers/usb/seri

Re: Audio I/O parameters

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, James Stone wrote: > > Please try the patch from here: > > > > http://marc.info/?l=linux-usb&m=137476385206265&w=2 > > > > instead of the one I sent to you yesterday. I think it will fix this > > problem. > > > > Alan Stern > > > > Perfect! All fixed! Can you provid

Re: [PATCH v2 0/9] Tegra USB cleanup series

2013-07-25 Thread Tuomas Tynkkynen
On 07/25/2013 08:51 PM, Felipe Balbi wrote: > > series doesn't apply on top of Mikko's patches. Please rebase on my > testing branch on kernel.org. Ah, the regulator patch got a v3 after I sent out these. Will do. > > When resending, please put Stephen's reviewed-by, tested-by and acked-by > i

Re: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Ivan T. Ivanov
On Thu, 2013-07-25 at 21:21 +0400, Sergei Shtylyov wrote: > On 07/25/2013 08:26 PM, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > When deferred probe happens driver will try to ioremap multiple times > > and will fail. Memory resource.start variable is a global variable, > > modificat

Re: Audio I/O parameters

2013-07-25 Thread James Stone
On Thu, Jul 25, 2013 at 4:29 PM, Alan Stern wrote: > On Thu, 25 Jul 2013, James Stone wrote: > >> On Thu, Jul 25, 2013 at 2:12 PM, Clemens Ladisch wrote: >> > James Stone wrote: >> >> Ok -from the bisect, the problem of not being able to get to sub >> >> 64-frames per period starts with: >> >> >>

Re: [PATCH v2 0/9] Tegra USB cleanup series

2013-07-25 Thread Felipe Balbi
Hi, On Mon, Jul 15, 2013 at 05:28:56PM -0600, Stephen Warren wrote: > On 07/15/2013 01:53 PM, Tuomas Tynkkynen wrote: > > Hi, > > > > Here's a V2 of the few cleanup patches for the Tegra USB drivers, to be > > applied > > on top of Mikko's two patch sets. It mostly deals with removing all usage

Re: [PATCH v2 01/21] usb/gadget: multi: fix error return code in cdc_do_config()

2013-07-25 Thread Felipe Balbi
On Fri, Jul 19, 2013 at 12:28:13PM +0200, Andrzej Pietrasiewicz wrote: > Fix to return a negative error code from the error handling > case instead of 0, as returned elsewhere in this function. > > Introduced by commit 59835a (usb: gadget: multi: use > function framework for ACM.) > > Signed-off-

Re: [PATCH] usb: gadget: mv_u3d_core: fix violation of locking discipline in mv_u3d_ep_disable()

2013-07-25 Thread Felipe Balbi
Hi, On Wed, Jul 24, 2013 at 12:20:17AM +0400, Alexey Khoroshilov wrote: > mv_u3d_nuke() expects to be calles with ep->u3d->lock held, > because mv_u3d_done() does. But mv_u3d_ep_disable() calls it > without lock that can lead to unpleasant consequences. > > Found by Linux Driver Verification proj

Re: [PATCH 1/6] usb: phy-nop: Use RESET Controller for managing the reset line

2013-07-25 Thread Felipe Balbi
On Thu, Jul 18, 2013 at 11:53:05AM +0300, Roger Quadros wrote: > Till now we were modelling the RESET line as a voltage regulator and > using the regulator framework to manage it. > > [1] introduces a GPIO based reset controller driver. We use that > to manage the PHY reset line, at least for DT b

Re: [PATCH 5/5] usb/gadget: mass_storage: merge usb_f_mass_storage module with u_ms module

2013-07-25 Thread Felipe Balbi
On Tue, Jul 16, 2013 at 02:21:27PM +0200, Andrzej Pietrasiewicz wrote: > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park return -ENOLOG -- balbi signature.asc Description: Digital signature

Re: [PATCH 3/5] usb/gadget: multi: convert to new interface of f_mass_storage

2013-07-25 Thread Felipe Balbi
On Tue, Jul 16, 2013 at 02:21:25PM +0200, Andrzej Pietrasiewicz wrote: > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park return -ENOLOG; -- balbi signature.asc Description: Digital signature

Re: [PATCH 2/5] usb/gadget: multi: convert to new interface of f_rndis

2013-07-25 Thread Felipe Balbi
On Tue, Jul 16, 2013 at 02:21:24PM +0200, Andrzej Pietrasiewicz wrote: > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park return -ENOLOG; -- balbi signature.asc Description: Digital signature

Re: [PATCH 1/1] usb/gadget: acm_ms: convert to new interface of f_mass_storage

2013-07-25 Thread Felipe Balbi
On Tue, Jul 16, 2013 at 02:20:51PM +0200, Andrzej Pietrasiewicz wrote: > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park return -ENOLOG; -- balbi signature.asc Description: Digital signature

Re: [PATCH 1/5] usb/gadget: multi: convert to new interface of f_ecm

2013-07-25 Thread Felipe Balbi
On Tue, Jul 16, 2013 at 02:21:23PM +0200, Andrzej Pietrasiewicz wrote: > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park return -ENOLOG; -- balbi signature.asc Description: Digital signature

Re: [PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Sergei Shtylyov
On 07/25/2013 08:26 PM, Ivan T. Ivanov wrote: From: "Ivan T. Ivanov" When deferred probe happens driver will try to ioremap multiple times and will fail. Memory resource.start variable is a global variable, modifications in this field will be accumulated on every probe. Fix this by moving th

Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-25 Thread Felipe Balbi
On Thu, Jul 25, 2013 at 09:18:39AM -0700, Olof Johansson wrote: > On Thu, Jul 25, 2013 at 9:14 AM, Felipe Balbi wrote: > > Hi, > > > > On Tue, Jul 23, 2013 at 11:55:50AM -0700, Olof Johansson wrote: > >> This resolves the following valid build warning: > >> > >> drivers/usb/gadget/at91_udc.c:1685:

Re: [Pull Request] xhci: Bug fixes, now with more tags!

2013-07-25 Thread Greg Kroah-Hartman
On Thu, Jul 25, 2013 at 08:16:03AM -0700, Sarah Sharp wrote: > The following changes since commit 94190301ffa059c2d127b3a67ec5d161d5c62681: > > usb: option: add TP-LINK MA260 (2013-07-23 16:07:51 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel

Re: Patch queue status?

2013-07-25 Thread Greg KH
On Thu, Jul 25, 2013 at 12:44:29PM -0400, Alan Stern wrote: > On Thu, 25 Jul 2013, Greg KH wrote: > > > On Thu, Jul 25, 2013 at 11:34:22AM -0400, Alan Stern wrote: > > > Greg: > > > > > > What's the status of your USB patch queue? I've seen a bunch of > > > notices about patches being applied -

Re: Patch queue status?

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, Greg KH wrote: > On Thu, Jul 25, 2013 at 11:34:22AM -0400, Alan Stern wrote: > > Greg: > > > > What's the status of your USB patch queue? I've seen a bunch of > > notices about patches being applied -- is the queue empty yet? > > No it isn't empty yet, I tried to pick out

[PATCH] usb: dwc3: core: modify IO memory resource after deferred probe completes

2013-07-25 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" When deferred probe happens driver will try to ioremap multiple times and will fail. Memory resource.start variable is a global variable, modifications in this field will be accumulated on every probe. Fix this by moving the above operations after driver hold all required P

Re: Patch queue status?

2013-07-25 Thread Greg KH
On Thu, Jul 25, 2013 at 11:34:22AM -0400, Alan Stern wrote: > Greg: > > What's the status of your USB patch queue? I've seen a bunch of > notices about patches being applied -- is the queue empty yet? No it isn't empty yet, I tried to pick out most of the 3.11 patches from it for USB already, b

Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-25 Thread Olof Johansson
On Thu, Jul 25, 2013 at 9:14 AM, Felipe Balbi wrote: > Hi, > > On Tue, Jul 23, 2013 at 11:55:50AM -0700, Olof Johansson wrote: >> This resolves the following valid build warning: >> >> drivers/usb/gadget/at91_udc.c:1685:34: warning: 'flags' may be used >> uninitialized in this function [-Wmaybe-u

Re: [PATCH] usb: gadget: at91_udc: Check gpio lookup results

2013-07-25 Thread Felipe Balbi
Hi, On Tue, Jul 23, 2013 at 11:55:50AM -0700, Olof Johansson wrote: > This resolves the following valid build warning: > > drivers/usb/gadget/at91_udc.c:1685:34: warning: 'flags' may be used > uninitialized in this function [-Wmaybe-uninitialized] > > I switched from ? : to !! mostly to save fr

Re: [PATCH 06/16] usb: musb: dsps: rename ti81xx_driver_data to am33xx_driver_data

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 10:28:37AM -0500, Bin Liu wrote: > Sebastian, > > On Thu, Jul 25, 2013 at 10:16 AM, Sebastian Andrzej Siewior > wrote: > > On 07/25/2013 05:12 PM, Bin Liu wrote: > >> Sebastian, > > > > Hi Bin, > > > >>> Is it really there or was it never there and it has been added t

Re: [PATCH v2 16/21] usb/gadget: f_mass_storage: use fsg_common_run_thread in fsg_common_init

2013-07-25 Thread Michal Nazarewicz
On Fri, Jul 19 2013, Andrzej Pietrasiewicz wrote: > fsg_common_init is a lengthy function. Now there are helper functions > which cover all parts of it. Use them. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_m

Re: [PATCH v2 15/21] usb/gadget: f_mass_storage: use fsg_common_set_inquiry_string in fsg_common_init

2013-07-25 Thread Michal Nazarewicz
On Fri, Jul 19 2013, Andrzej Pietrasiewicz wrote: > fsg_common_init is a lengthy function. Now there are helper functions > which cover all parts of it. Use them. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_m

Re: [PATCH v2 14/21] usb/gadget: f_mass_storage: use fsg_common_create_luns in fsg_common_init

2013-07-25 Thread Michal Nazarewicz
On Fri, Jul 19 2013, Andrzej Pietrasiewicz wrote: > fsg_common_init is a lengthy function. Now there are helper functions > which cover all parts of it. Use them. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_m

Re: [PATCH v2 12/21] usb/gadget: f_mass_storage: use fsg_common_set_ops/_private_data in fsg_common_init

2013-07-25 Thread Michal Nazarewicz
On Fri, Jul 19 2013, Andrzej Pietrasiewicz wrote: > fsg_common_init is a lengthy function. Now there are helper functions > which cover all parts of it. Use them. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_m

Re: [PATCH v2 11/21] usb/gadget: f_mass_storage: use fsg_common_set_nluns in fsg_common_init

2013-07-25 Thread Michal Nazarewicz
On Fri, Jul 19 2013, Andrzej Pietrasiewicz wrote: > fsg_common_init is a lengthy function. Now there are helper functions > which cover all parts of it. Use them. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_m

Re: [PATCH v2 13/21] usb/gadget: f_mass_storage: use fsg_common_set_cdev in fsg_common_init

2013-07-25 Thread Michal Nazarewicz
On Fri, Jul 19 2013, Andrzej Pietrasiewicz wrote: > fsg_common_init is a lengthy function. Now there are helper functions > which cover all parts of it. Use them. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_m

Re: [xhci] null pointer dereference on ring_doorbell_for_active_rings

2013-07-25 Thread Mathias Nyman
Hi I just started looking at this issue as well from xhci perspective. From your Oops backtrace I can see that ring_doorbell_for_active_rings() was called from handle_cmd_completion() This should only happend if XHCI_RESET_EP_QUIRK is set, i.e. you have a Fresco Logic host controller. In

Re: [PATCH v2 10/21] usb/gadget: f_mass_storage: use fsg_common_set_num_buffers in fsg_common_init

2013-07-25 Thread Michal Nazarewicz
On Fri, Jul 19 2013, Andrzej Pietrasiewicz wrote: > fsg_common_init is a lengthy function. Now there are helper functions > which cover all parts of it. Use them. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_m

Re: [PATCH v2 09/21] usb/gadget: f_mass_storage: use fsg_common_setup in fsg_common_init

2013-07-25 Thread Michal Nazarewicz
On Fri, Jul 19 2013, Andrzej Pietrasiewicz wrote: > fsg_common_init is a lengthy function. Now there are helper functions > which cover all parts of it. Use them. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_m

Re: [PATCH v2 08/21] usb/gadget: f_mass_storage: split fsg_common initialization into a number of functions

2013-07-25 Thread Michal Nazarewicz
On Fri, Jul 19 2013, Andrzej Pietrasiewicz wrote: > When configfs is in place, the things related to intialization > of struct fsg_common will be split over a number of places. > This patch adds several functions which together cover the former > intialization routine fsg_common_init. > > When conf

Re: [PATCH v2] usb: host: Faraday fotg210-hcd driver

2013-07-25 Thread Yuan-Hsin Chen
Hi, On Thu, Jul 25, 2013 at 7:10 AM, Greg KH wrote: > > On Wed, Jun 19, 2013 at 07:53:04PM +, Yuan-Hsin Chen wrote: > > FOTG210 is an OTG controller which can be configured as an > > USB2.0 host. FOTG210 host is an ehci-like controller with > > some differences. First, register layout of FOT

Re: After entering D3 cold: URB ffff88020ea41000 submitted while active

2013-07-25 Thread Oleksii Shevchuk
lsusb -s 001:004 Bus 001 Device 004: ID 1199:9013 Sierra Wireless, Inc. - Hardware | manufacturer: 'Sierra Wireless Inc' | model: 'Sierra Wireless MC8355 - Gobi 3000(TM) Module' | revision: 'D3200-STSUGN-1580 1 [Jul 08 2011 18:

Re: After entering D3 cold: URB ffff88020ea41000 submitted while active

2013-07-25 Thread Oliver Neukum
On Thu, 2013-07-25 at 18:45 +0300, Oleksii Shevchuk wrote: > > lspci -s 00:14.0 -vvv No. It happens with the wdm driver. What net device are you using? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majo

Re: After entering D3 cold: URB ffff88020ea41000 submitted while active

2013-07-25 Thread Oleksii Shevchuk
> lspci -s 00:14.0 -vvv 00:14.0 USB controller: Intel Corporation 7 Series/C210 Series Chipset Family USB xHCI Host Controller (rev 04) (prog-if 30 [XHCI]) Subsystem: Lenovo Device 21fa Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- D

Patch queue status?

2013-07-25 Thread Alan Stern
Greg: What's the status of your USB patch queue? I've seen a bunch of notices about patches being applied -- is the queue empty yet? I ask because of this: http://marc.info/?l=linux-usb&m=137356910824266&w=2 which hasn't been merged yet. Alan Stern -- To unsubscribe from this list:

Re: [PATCH 06/16] usb: musb: dsps: rename ti81xx_driver_data to am33xx_driver_data

2013-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 25, 2013 at 05:16:53PM +0200, Sebastian Andrzej Siewior wrote: > On 07/25/2013 05:12 PM, Bin Liu wrote: > > Sebastian, > > Hi Bin, > > >> Is it really there or was it never there and it has been added to TRM by > >> accident? > > The EOI register IS in the USB subsystem of AM33xx

Re: [PATCH v2 07/21] usb/gadget: f_mass_storage: use usb_gstrings_attach

2013-07-25 Thread Michal Nazarewicz
On Fri, Jul 19 2013, Andrzej Pietrasiewicz wrote: > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_mass_storage.c | 25 - > 1 files changed, 12 insertions(+), 13 deletions(-) > > diff --git

Re: [PATCH 15/16] dmaengine: add transfered member to dma_async_tx_descriptor

2013-07-25 Thread Lars-Peter Clausen
On 07/25/2013 05:12 PM, Sebastian Andrzej Siewior wrote: > On 07/25/2013 04:57 PM, Lars-Peter Clausen wrote: >> I'm not sure that this will work. Once you've submitted the descriptor it is >> owned by the dmaengine driver and you are not allowed to dereference it >> anymore since the dmaengine driv

Re: [PATCH v2 06/21] usb/gadget: f_mass_storage: add a level of indirection for luns storage

2013-07-25 Thread Michal Nazarewicz
On Fri, Jul 19 2013, Andrzej Pietrasiewicz wrote: > This is needed to prepare for configfs integration. > > So far the luns have been allocated during gadget's initialization, based > on the nluns module parameter's value; the exact number is known when the > gadget is initialized and that number o

Re: Audio I/O parameters

2013-07-25 Thread Alan Stern
On Thu, 25 Jul 2013, James Stone wrote: > On Thu, Jul 25, 2013 at 2:12 PM, Clemens Ladisch wrote: > > James Stone wrote: > >> Ok -from the bisect, the problem of not being able to get to sub > >> 64-frames per period starts with: > >> > >> http://git.kernel.org/cgit/linux/kernel/git/stable/linux-

Re: [PATCH 06/16] usb: musb: dsps: rename ti81xx_driver_data to am33xx_driver_data

2013-07-25 Thread Bin Liu
Sebastian, On Thu, Jul 25, 2013 at 10:16 AM, Sebastian Andrzej Siewior wrote: > On 07/25/2013 05:12 PM, Bin Liu wrote: >> Sebastian, > > Hi Bin, > >>> Is it really there or was it never there and it has been added to TRM by >>> accident? >> The EOI register IS in the USB subsystem of AM33xx, but

Re: [PATCH v2 05/21] usb/gadget: f_mass_storage: factor out a header file

2013-07-25 Thread Michal Nazarewicz
On Fri, Jul 19 2013, Andrzej Pietrasiewicz wrote: > In order to prepare for the new function interface the f_mass_storage.c > needs to be compiled as a module, and so a header file will be required. > This patch factors out some code to a new f_mass_storage.h. > > Signed-off-by: Andrzej Pietrasiewi

[PATCH 4/5] usb: host: xhci: Enable XHCI_SPURIOUS_SUCCESS for all controllers with xhci 1.0

2013-07-25 Thread Sarah Sharp
From: George Cherian Xhci controllers with hci_version > 0.96 gives spurious success events on short packet completion. During webcam capture the "ERROR Transfer event TRB DMA ptr not part of current TD" was observed. The same application works fine with synopsis controllers hci_version 0.96. The

[PATCH 2/5] usb: xhci: Mark two functions __maybe_unused

2013-07-25 Thread Sarah Sharp
From: Olof Johansson Resolves the following build warnings: drivers/usb/host/xhci.c:332:13: warning: 'xhci_msix_sync_irqs' defined but not used [-Wunused-function] drivers/usb/host/xhci.c:3901:12: warning: 'xhci_change_max_exit_latency' defined but not used [-Wunused-function] These functions

[PATCH 3/5] usb: fix build warning in pci-quirks.h when CONFIG_PCI is not enabled

2013-07-25 Thread Sarah Sharp
From: Randy Dunlap Fix warning when CONFIG_PCI is not enabled (from commit 296365781903226a3fb8758901eaeec09d2798e4). drivers/usb/host/pci-quirks.h: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] Signed-off-by: Randy Dunlap

[PATCH 1/5] xhci: Avoid NULL pointer deref when host dies.

2013-07-25 Thread Sarah Sharp
When the host controller fails to respond to an Enable Slot command, and the host fails to respond to the register write to abort the command ring, the xHCI driver will assume the host is dead, and call usb_hc_died(). The USB device's slot_id is still set to zero, and the pointer stored at xhci->d

Re: [PATCH v2 04/21] usb/gadget: create a utility module for mass_storage

2013-07-25 Thread Michal Nazarewicz
On Fri, Jul 19 2013, Andrzej Pietrasiewicz wrote: > Converting to configfs requires making the f_mass_storage.c a module. > But first we need to get rid of "#include "storage_common.c". > This patch makes storage_common.c a separately compiled file, which is > built as a utility module named u_ms.k

[PATCH 5/5] xhci: fix null pointer dereference on ring_doorbell_for_active_rings

2013-07-25 Thread Sarah Sharp
From: Oleksij Rempel in some cases where device is attched to xhci port and do not responding, for example ath9k_htc with stalled firmware, kernel will crash on ring_doorbell_for_active_rings. This patch check if pointer exist before it is used. This patch should be backported to kernels as old

Re: Audio I/O parameters

2013-07-25 Thread Clemens Ladisch
James Stone wrote: > On Thu, Jul 25, 2013 at 2:12 PM, Clemens Ladisch wrote: >> The commit that you found by bisection got reverted later: >> >> >> Please check that the code of "Fix URB cancellation at stream start" is >> in your current kernel. > > well,

Re: [PATCH 06/16] usb: musb: dsps: rename ti81xx_driver_data to am33xx_driver_data

2013-07-25 Thread Sebastian Andrzej Siewior
On 07/25/2013 05:12 PM, Bin Liu wrote: > Sebastian, Hi Bin, >> Is it really there or was it never there and it has been added to TRM by >> accident? > The EOI register IS in the USB subsystem of AM33xx, but the SoC does > not use it because it uses level triggering for USB interrupt. I see. >>>

Re: After entering D3 cold: URB ffff88020ea41000 submitted while active

2013-07-25 Thread Oliver Neukum
On Thu, 2013-07-25 at 17:30 +0300, Oleksii Shevchuk wrote: > Randomly after returning from S3 or enabling powersaving this trace > goes to dmesg: > [13115.552920] [] usb_submit_urb+0x360/0x370 > [usbcore] > [13115.552922] [] wdm_int_callback+0x1c6/0x200 > [cdc_wdm] > [13115.552927] [] usb_hcd_g

[Pull Request] xhci: Bug fixes, now with more tags!

2013-07-25 Thread Sarah Sharp
The following changes since commit 94190301ffa059c2d127b3a67ec5d161d5c62681: usb: option: add TP-LINK MA260 (2013-07-23 16:07:51 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git tags/for-usb-linus-2013-07-25 for you to fetch change

  1   2   >