Re: [PATCH 0/6] staging: dwc2: fixes and cleanups for dwc2

2013-07-13 Thread Stephen Warren
On 07/13/2013 03:53 PM, Paul Zimmerman wrote: > This is a series of fixes and cleanups for the dwc2 driver. It > fixes some occasional crashes I had been seeing, and also makes > the driver work on the Raspberry Pi with the mainline kernel, > once some additional DT support is added (not upstream y

Re: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame()

2013-07-13 Thread Stephen Warren
On 07/13/2013 04:34 PM, Paul Zimmerman wrote: >> From: Stephen Warren [mailto:swar...@wwwdotorg.org] >> Sent: Monday, July 08, 2013 8:41 PM >> >> On 07/08/2013 03:40 PM, Paul Zimmerman wrote: From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Tuesday, July 02, 2013 7:41 PM >>>

RE: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame()

2013-07-13 Thread Paul Zimmerman
Forgot to mention, on the Pi it is probably a good idea to disable the dwc2 debug messages in your kernel .config if you are going to beat on the driver heavily. It takes enough CPU cycles already, adding more overhead is probably not a good idea (might cause an interrupt to be missed or the like).

RE: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame()

2013-07-13 Thread Paul Zimmerman
> From: Stephen Warren [mailto:swar...@wwwdotorg.org] > Sent: Monday, July 08, 2013 8:41 PM > > On 07/08/2013 03:40 PM, Paul Zimmerman wrote: > >> From: Stephen Warren [mailto:swar...@wwwdotorg.org] > >> Sent: Tuesday, July 02, 2013 7:41 PM > >> > >> On 07/02/2013 07:47 PM, Stephen Warren wrote: >

[PATCH 6/6] staging: dwc2: remove use of bus_to_virt()

2013-07-13 Thread Paul Zimmerman
Remove the use of bus_to_virt() and just fail the transfer if an unaligned buffer with no virtual address is found. AFAIK that can't happen anyway. Also change setting of coherent DMA mask to the normal 32 bits. 31 bits was only needed when calling bus_to_virt() AFAICR. Signed-off-by: Paul Zimmer

[PATCH 5/6] staging: dwc2: reduce noisy debug messages

2013-07-13 Thread Paul Zimmerman
Change the non-aligned buffer debug messages to dev_vdbg(). Also remove some duplicated debug output when the driver is loaded. Signed-off-by: Paul Zimmerman --- drivers/staging/dwc2/hcd.c | 2 -- drivers/staging/dwc2/hcd_intr.c | 14 +++--- 2 files changed, 7 insertions(+), 9 dele

[PATCH 3/6] staging: dwc2: optimize dwc2_hc_handle_tt_clear() a bit

2013-07-13 Thread Paul Zimmerman
Make dwc2_hc_handle_tt_clear() return early if the device is hi-speed. Signed-off-by: Paul Zimmerman --- drivers/staging/dwc2/hcd_intr.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dwc2/hcd_intr.c b/drivers/staging/dwc2/hcd_intr.c index 22836

[PATCH 4/6] staging: dwc2: fix dwc2_hcd_qtd_add()

2013-07-13 Thread Paul Zimmerman
The logic in dwc2_hcd_qtd_add() was a bit messy, and one of the error exit paths was broken. Fix it up. Signed-off-by: Paul Zimmerman --- drivers/staging/dwc2/hcd_queue.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dwc2/hcd_queue.c b/

[PATCH 2/6] staging: dwc2: add calls to usb_hcd_link_urb_to_ep() and friends

2013-07-13 Thread Paul Zimmerman
The driver was lacking calls to usb_hcd_link_urb_to_ep(), usb_hcd_unlink_urb_from_ep(), and usb_hcd_check_unlink_urb(). Add those now. Signed-off-by: Paul Zimmerman --- drivers/staging/dwc2/hcd.c | 52 +- 1 file changed, 37 insertions(+), 15 deletions(

[PATCH 0/6] staging: dwc2: fixes and cleanups for dwc2

2013-07-13 Thread Paul Zimmerman
This is a series of fixes and cleanups for the dwc2 driver. It fixes some occasional crashes I had been seeing, and also makes the driver work on the Raspberry Pi with the mainline kernel, once some additional DT support is added (not upstream yet). I think this should make the driver pretty close

[PATCH 1/6] staging: dwc2: refactor dwc2_host_complete()

2013-07-13 Thread Paul Zimmerman
The parameters to dwc2_host_complete() didn't make much sense. The 'context' parameter always came from the ->priv member of the 'dwc2_urb' parameter, and both of those always came from a struct dwc2_qtd. So just pass in the struct dwc2_qtd instead. This also allows us to null out the dwc2_qtd->ur

Re: Audio I/O parameters

2013-07-13 Thread Alan Stern
On Sat, 13 Jul 2013, Clemens Ladisch wrote: > James Stone wrote: > > On Mon, Jul 8, 2013 at 2:12 PM, James Stone wrote: > >>> configuring for 44100Hz, period = 64 frames (1.5 ms), buffer = 2 periods > >>> JackAudioDriver::ProcessAsync: read error, stopping... > >> > >> Some further info - on 3.5.

Re: Audio I/O parameters

2013-07-13 Thread Clemens Ladisch
James Stone wrote: > On Mon, Jul 8, 2013 at 2:12 PM, James Stone wrote: >>> configuring for 44100Hz, period = 64 frames (1.5 ms), buffer = 2 periods >>> JackAudioDriver::ProcessAsync: read error, stopping... >> >> Some further info - on 3.5.0-28, I can start jackd in playback only >> with 8 frames

Re: Proposed modification to PL2303 driver

2013-07-13 Thread Mastro Gippo
- Sorry, it looks like I'm having difficulties with the mailing list - please be patient, I'm mostly an hardware guy - > The thread opener said he can set the non-standard rate of 250kBaud > under Windows, so either that rate got added to the standard list or > the driver nowadays also supports

Followup

2013-07-13 Thread Mastro Gippo
Hi guys, I'm the OP and I'm really sorry that I didn't partecipate in that discussion but since I didn't subscribe to the mailing list I only saw Greg's replies and thought that the thread was abandoned until someone sent me the link of the thread on StackExchange. I was going to reply to Greg but

Re: [PATCH] usb: serial: option.c: remove ONDA MT825UP product ID fromdriver

2013-07-13 Thread Greg KH
On Sat, Jul 13, 2013 at 06:54:14PM +0200, Enrico Mioso wrote: > Some (very few) early devices like mine, where not exposting a > proper CDC descriptor. This was fixed with an immediate firmware > update from the vendor, and pre-installed on newer devices. > So actual devices can be driven by cdc_ac

[PATCH] usb: serial: option.c: remove ONDA MT825UP product ID fromdriver

2013-07-13 Thread Enrico Mioso
Some (very few) early devices like mine, where not exposting a proper CDC descriptor. This was fixed with an immediate firmware update from the vendor, and pre-installed on newer devices. So actual devices can be driven by cdc_acm.c + cdc_ether.c. Signed-off-by: Enrico Mioso --- drivers/usb/

Re: lsusb doesn't handle 32 bits Usage tags.

2013-07-13 Thread pchavent
On Sun, 7 Jul 2013 10:37:59 -0700, Greg KH wrote: On Sun, Jul 07, 2013 at 07:17:40PM +0200, pchavent wrote: Hi. lsusb doesn't handle 32 bits Usage tags. I've tried to do a patch but i'm not confident in its implementation. Do you have a HID descriptor with a 32bit usage tag? I don't think