Re: usb sysfs file handling functions don't take

2013-05-19 Thread Hans de Goede
Hi, On 05/18/2013 06:03 PM, Alan Stern wrote: On Sat, 18 May 2013, Hans de Goede wrote: Hi, As written in my mail titled: "Linux sysfs usb descriptors file has broken configuration length handling" I've been taking a close look at the usb sysfs handling code, specifically for the descriptors

Re: [PATCH 2/2] usb: host: fusbh200-hcd: Staticize local symbols

2013-05-19 Thread Sachin Kamat
Hi, On 20 May 2013 12:13, Yuan-Hsin Chen wrote: > Hi, > > On Mon, May 20, 2013 at 1:51 PM, Sachin Kamat wrote: >> Local symbols referenced only in this file are made static. >> >> Signed-off-by: Sachin Kamat > > Thank you. I believe you probably meant to add your Ack to this series? > >> ---

Re: [PATCH 2/2] usb: host: fusbh200-hcd: Staticize local symbols

2013-05-19 Thread Yuan-Hsin Chen
Hi, On Mon, May 20, 2013 at 1:51 PM, Sachin Kamat wrote: > Local symbols referenced only in this file are made static. > > Signed-off-by: Sachin Kamat Thank you. > --- > drivers/usb/host/fusbh200-hcd.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/u

[PATCH 2/2] usb: host: fusbh200-hcd: Staticize local symbols

2013-05-19 Thread Sachin Kamat
Local symbols referenced only in this file are made static. Signed-off-by: Sachin Kamat --- drivers/usb/host/fusbh200-hcd.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200-hcd.c index b17dd3f..0855ca4 100644

[PATCH 1/2] usb: host: fusbh200-hcd: Remove redundant platform_set_drvdata()

2013-05-19 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Yuan-Hsin Chen --- drivers/usb/host/fusbh200-hcd.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/fusbh200-hc

Re: Linux USB file storage gadget with new UDC

2013-05-19 Thread victor yeo
Hi, >> Another question from the bulk_out_complete() printout which is shown >> below. The req->actual is 512 byte. The bh->bulk_out_intended_length >> is 31. Is this a bug? >> >> g_file_storage gadget: get_next_command >> [start_transfer] 6f007442 7000 >> ept1 out queue len 0x200, buffer 0xc13300

usb:is that a bug?

2013-05-19 Thread linux fddl
Hi, When I used mass_storage as a gadget(use a linux-3.0.77 kernel), After the following operations: 1.Turn my board into hibernation. 2.Plug the usb into host before resume. 3.Resume my board. I saw some dump message like this, after some digging, I think the other devices' retore time is too l

RE: Regression in 3735ba8db8e6ea22ad3ff524328926d8d780a884 with Freescale P1020

2013-05-19 Thread Mehresh Ramneek-B31383
Hi Shengzhou/Braun, We changed the controller init sequence to make this work. I'll submit the patch upstream soon. Regards, Ramneek -Original Message- From: Liu Shengzhou-B36685 Sent: Monday, May 20, 2013 9:07 AM To: Michael Braun; Mehresh Ramneek-B31383 Cc: projekt-w...@fem.tu-ilmena

RE: Regression in 3735ba8db8e6ea22ad3ff524328926d8d780a884 with Freescale P1020

2013-05-19 Thread Liu Shengzhou-B36685
Hi Braun, At that time I had an P4080DS board which had the same issue and had been fixed with this patch. I didn't test it on P1020 due to the absence of P1020. I think P1020 will need a new patch besides this one. Later Ramneek took this issue on P1020 for more investigation. Hello Ramneek, a

Re: [PATCH 1/5] usb: add Atmel USBA UDC DT support

2013-05-19 Thread Bo Shen
Hi Jean-Christophe, On 5/17/2013 22:42, Jean-Christophe PLAGNIOL-VILLARD wrote: Allow to compile the driver all the time if AT91 enabled. Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD Cc: Nicolas Ferre Cc: linux-usb@vger.kernel.org --- .../devicetree/bindings/usb/atmel-usb.txt |

Re: Crash in dwc3 driver on module unload

2013-05-19 Thread Peter Chen
On Fri, May 17, 2013 at 10:27 PM, Alan Stern wrote: > On Fri, 17 May 2013, Peter Chen wrote: > >> > I found out a couple more things about this. >> > >> > If I do "rmmod dwc3" first, and then do "rmmod dwc3-pci", it doesn't >> > crash. >> > >> >> dwc3-pci will release dwc3 and its resources at its

[PATCH 2/2] usb: dwc3: exynos: PHY should be deleted later than dwc3 core

2013-05-19 Thread Peter Chen
If the glue layer is removed first (core layer later), it deletes the phy device first, then the core device. But at core's removal, it still uses PHY's resources, it may cause kernel's oops. It is much like the problem Paul Zimmerman reported at: http://marc.info/?l=linux-usb&m=136547502011472&w=2

[PATCH 1/2] usb: dwc3: pci: PHY should be deleted later than dwc3 core

2013-05-19 Thread Peter Chen
If the glue layer is removed first (core layer later), it deletes the phy device first, then the core device. But at core's removal, it still uses PHY's resources, it may cause kernel's oops. It is much like the problem Paul Zimmerman reported at: http://marc.info/?l=linux-usb&m=136547502011472&w=2

[patch] USB: cxacru: potential underflow in cxacru_cm_get_array()

2013-05-19 Thread Dan Carpenter
The value of "offd" comes off the instance->rcv_buf[] and we used it as the offset into an array. The problem is that we check the upper bound but not for negative values. Signed-off-by: Dan Carpenter diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c index b7eb86a..8a7eb77 100644

Re: [Libusbx-devel] Linux sysfs usb descriptors file has broken configuration length handling

2013-05-19 Thread Greg KH
On Sun, May 19, 2013 at 11:20:59AM -0400, Alan Stern wrote: > By the way, Greg, at what point does it make sense to move things from > Documenation/ABI/testing to Documentation/ABI/stable? I get the > impression that nothing ever makes this jump. One people start relying on the file, it should

Re: Regression in 3735ba8db8e6ea22ad3ff524328926d8d780a884 with Freescale P1020

2013-05-19 Thread Michael Braun
Hi, I've got hardware here to test with, so if there any changes to test, I'm willing to support. Meanwhile, might it be a good idea to make that check optional - i.e. add a module parameter or something like this around it? Regards, M. Braun On Thu, Apr 18, 2013 at 05:13:39PM +0200, michael-

Re: [Libusbx-devel] Linux sysfs usb descriptors file has broken configuration length handling

2013-05-19 Thread Alan Stern
On Sun, 19 May 2013, Hans de Goede wrote: > Hi, Greg, Alan, All, > > On 05/18/2013 06:17 PM, Greg KH wrote: > > On Sat, May 18, 2013 at 12:14:08PM -0400, Alan Stern wrote: > >> On Sat, 18 May 2013, Hans de Goede wrote: > >>> But the sysfs descriptors file will just packs the > >>> rawdescriptors

Re: Question about "generic" HID devices

2013-05-19 Thread Alan Stern
On Sat, 18 May 2013, Daniel Santos wrote: > Yes, my apologies, I didn't state that very clearly. I meant that I > submit a "request" URB to the in interrupt endpoint as well a "response" > URB to the out interrupt endpoint.This is where I'm currently submitting > these (for now just assume can