Re: [PATCH] pci: do not try to assign irq 255

2013-02-28 Thread Hannes Reinecke
On 02/27/2013 10:13 PM, Bjorn Helgaas wrote: [+cc Andy] On Wed, Feb 20, 2013 at 11:53 PM, Hannes Reinecke wrote: On 02/20/2013 05:57 PM, Yinghai Lu wrote: On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke wrote: Apparently this device is meant to use MSI _only_ so the BIOS developer did

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-02-28 Thread Felipe Balbi
Hi, On Thu, Feb 28, 2013 at 08:09:33PM +0530, Vivek Gautam wrote: > On Thu, Jan 31, 2013 at 9:08 PM, Felipe Balbi wrote: > > On Thu, Jan 31, 2013 at 09:00:37PM +0530, Vivek Gautam wrote: > >> Hi Felipe, > >> > >> > >> On Thu, Jan 31, 2013 at 8:55 PM, Felipe Balbi wrote: > >> > Hi, > >> > > >> >

Re: [PATCH] usb: dwc3: fix EP_BUSY in case of dequeue

2013-02-28 Thread Felipe Balbi
Hi, On Thu, Feb 28, 2013 at 04:51:29PM +0530, Pratyush Anand wrote: > On 2/28/2013 4:18 PM, Felipe Balbi wrote: > >>+ if (list_empty(&dep->req_queued)) > >>>+ dep->flags &= ~DWC3_EP_BUSY; > >not sure this is correct. Whenever req_queue isn't empty, we call > >dwc3_stop_active_transfer()

Re: [PATCH v9 8/9] usb: chipidea: tell platform layer the ci core probe's result

2013-02-28 Thread Felipe Balbi
Hi, On Thu, Feb 28, 2013 at 01:55:30PM +0200, Alexander Shishkin wrote: > >> >> > > > > > > If the probe fails, the ci13xxx_add_device will not return > >> >> > > > > > > error, > >> >> > > > > > > (bus_probe_device doesn't has return value) > >> >> > > > > > > therefore, the platform layer can't

Re: [PATCH v9 8/9] usb: chipidea: tell platform layer the ci core probe's result

2013-02-28 Thread Felipe Balbi
On Fri, Mar 01, 2013 at 09:45:51AM +0800, Peter Chen wrote: > On Thu, Feb 28, 2013 at 12:45:59PM +0200, Felipe Balbi wrote: > > Hi, > > > > On Thu, Feb 28, 2013 at 06:06:55PM +0800, Peter Chen wrote: > > > > > For runtime pm disabled, we may had to add some ugly things, like > > > notify core pro

[patch] usb: storage: onetouch: tighten a range check

2013-02-28 Thread Dan Carpenter
Smatch complains because we only allocate ONETOUCH_PKT_LEN (2) bytes but later when we call usb_fill_int_urb() we assume maxp can be up to 8 bytes. I talked to the maintainer and maxp should be capped at ONETOUCH_PKT_LEN. Signed-off-by: Dan Carpenter diff --git a/drivers/usb/storage/onetouch.c

Re: [PATCH 1/2] ACPI / glue: Add .match() callback to struct acpi_bus_type

2013-02-28 Thread Greg Kroah-Hartman
On Thu, Feb 28, 2013 at 10:53:21PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > USB uses the .find_bridge() callback from struct acpi_bus_type > incorrectly, because as a result of the way it is used by USB every > device in the system that doesn't have a bus type or parent is >

[PATCH 4/5 V3] usb: call pm_runtime_put_noidle in pm_runtime_get_sync failed case

2013-02-28 Thread Li Fei
Even in failed case of pm_runtime_get_sync, the usage_count is incremented. In order to keep the usage_count with correct value and runtime power management to behave correctly, call pm_runtime_put(_sync/noidle) in such case. Signed-off-by Liu Chuansheng Signed-off-by: Li Fei --- drivers/usb/co

[PATCH 4/5 V3] usb: call pm_runtime_put_noidle in pm_runtime_get_sync failed case

2013-02-28 Thread Li Fei
Even in failed case of pm_runtime_get_sync, the usage_count is incremented. In order to keep the usage_count with correct value and runtime power management to behave correctly, call pm_runtime_put(_sync/noidle) in such case. Signed-off-by Liu Chuansheng Signed-off-by: Li Fei --- drivers/usb/c

RE: [PATCH 4/5 V2] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Liu, Chuansheng
> -Original Message- > From: Rafael J. Wysocki [mailto:r...@sisk.pl] > Sent: Friday, March 01, 2013 10:22 AM > To: Liu, Chuansheng > Cc: Li, Fei; gre...@linuxfoundation.org; Lan, Tianyu; > st...@rowland.harvard.edu; sarah.a.sh...@linux.intel.com; > linux-usb@vger.kernel.org; linux-ker...@

Re: [PATCH 4/5 V2] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Rafael J. Wysocki
On Friday, March 01, 2013 02:07:54 AM Liu, Chuansheng wrote: > > > -Original Message- > > From: Li, Fei > > Sent: Thursday, February 28, 2013 5:06 PM > > To: gre...@linuxfoundation.org; Lan, Tianyu; st...@rowland.harvard.edu; > > sarah.a.sh...@linux.intel.com > > Cc: r...@sisk.pl; linux-us

Re: [PATCH 4/5 V2] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Rafael J. Wysocki
On Friday, March 01, 2013 12:59:23 AM Liu, Chuansheng wrote: > > > -Original Message- > > From: Rafael J. Wysocki [mailto:r...@sisk.pl] > > Sent: Friday, March 01, 2013 8:51 AM > > To: Liu, Chuansheng > > Cc: Alan Stern; Li, Fei; gre...@linuxfoundation.org; Lan, Tianyu; > > sarah.a.sh...@l

RE: [PATCH 4/5 V2] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Liu, Chuansheng
> -Original Message- > From: Li, Fei > Sent: Thursday, February 28, 2013 5:06 PM > To: gre...@linuxfoundation.org; Lan, Tianyu; st...@rowland.harvard.edu; > sarah.a.sh...@linux.intel.com > Cc: r...@sisk.pl; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; > Liu, > Chuansheng; Li,

Re: [PATCH v9 8/9] usb: chipidea: tell platform layer the ci core probe's result

2013-02-28 Thread Peter Chen
On Thu, Feb 28, 2013 at 12:45:59PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Feb 28, 2013 at 06:06:55PM +0800, Peter Chen wrote: > > > For runtime pm disabled, we may had to add some ugly things, like > > notify core probe fail, and platform layer needs to handle this failed > > notify. > > P

Re: About chipidea tree

2013-02-28 Thread Peter Chen
On Thu, Feb 28, 2013 at 01:16:04PM +0200, Alexander Shishkin wrote: > Peter Chen writes: > > > On Tue, Feb 26, 2013 at 02:47:34PM +0100, Marc Kleine-Budde wrote: > >> On 02/26/2013 02:25 PM, Alexander Shishkin wrote: > >> > Marc Kleine-Budde writes: > >> > > >> >> On 02/26/2013 11:56 AM, Alexan

RE: [PATCH 4/5 V2] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Liu, Chuansheng
> -Original Message- > From: Rafael J. Wysocki [mailto:r...@sisk.pl] > Sent: Friday, March 01, 2013 8:51 AM > To: Liu, Chuansheng > Cc: Alan Stern; Li, Fei; gre...@linuxfoundation.org; Lan, Tianyu; > sarah.a.sh...@linux.intel.com; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org

Re: [PATCH 4/5 V2] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Rafael J. Wysocki
On Friday, March 01, 2013 12:38:07 AM Liu, Chuansheng wrote: > > > -Original Message- > > From: Alan Stern [mailto:st...@rowland.harvard.edu] > > Sent: Thursday, February 28, 2013 11:17 PM > > To: Li, Fei > > Cc: gre...@linuxfoundation.org; Lan, Tianyu; sarah.a.sh...@linux.intel.com; > > r

RE: [PATCH 4/5 V2] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Liu, Chuansheng
> -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Thursday, February 28, 2013 11:17 PM > To: Li, Fei > Cc: gre...@linuxfoundation.org; Lan, Tianyu; sarah.a.sh...@linux.intel.com; > r...@sisk.pl; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Liu,

Re: [PATCH 2/2] ACPI / glue: Drop .find_bridge() callback from struct acpi_bus_type

2013-02-28 Thread Rafael J. Wysocki
On Thursday, February 28, 2013 05:13:27 PM Jeff Garzik wrote: > On 02/28/2013 04:53 PM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > After PCI and USB have stopped using the .find_bridge() callback in > > struct acpi_bus_type, the only remaining user of it is SATA, but SATA > > onl

Re: [PATCH 1/2] ACPI / glue: Add .match() callback to struct acpi_bus_type

2013-02-28 Thread Rafael J. Wysocki
On Thursday, February 28, 2013 02:29:56 PM Yinghai Lu wrote: > On Thu, Feb 28, 2013 at 1:53 PM, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > USB uses the .find_bridge() callback from struct acpi_bus_type > > incorrectly, because as a result of the way it is used by USB every > > d

Re: [PATCH 1/2] ACPI / glue: Add .match() callback to struct acpi_bus_type

2013-02-28 Thread Yinghai Lu
On Thu, Feb 28, 2013 at 1:53 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > USB uses the .find_bridge() callback from struct acpi_bus_type > incorrectly, because as a result of the way it is used by USB every > device in the system that doesn't have a bus type or parent is > passed to

Re: [PATCH 2/2] ACPI / glue: Drop .find_bridge() callback from struct acpi_bus_type

2013-02-28 Thread Jeff Garzik
On 02/28/2013 04:53 PM, Rafael J. Wysocki wrote: From: Rafael J. Wysocki After PCI and USB have stopped using the .find_bridge() callback in struct acpi_bus_type, the only remaining user of it is SATA, but SATA only pretends to be a user, because it points that callback to a stub always returni

Re: [Resend][PATCH] ACPI / glue: Drop .find_bridge() callback from struct acpi_bus_type

2013-02-28 Thread Rafael J. Wysocki
On Wednesday, February 27, 2013 06:33:13 PM Greg Kroah-Hartman wrote: > On Thu, Feb 28, 2013 at 02:11:58AM +0100, Rafael J. Wysocki wrote: > > On Wednesday, February 27, 2013 02:20:32 PM Greg Kroah-Hartman wrote: > > > On Wed, Feb 27, 2013 at 11:06:52PM +0100, Rafael J. Wysocki wrote: > > > > From:

[PATCH 1/2] ACPI / glue: Add .match() callback to struct acpi_bus_type

2013-02-28 Thread Rafael J. Wysocki
From: Rafael J. Wysocki USB uses the .find_bridge() callback from struct acpi_bus_type incorrectly, because as a result of the way it is used by USB every device in the system that doesn't have a bus type or parent is passed to usb_acpi_find_device() for inspection. What USB actually needs, thou

[PATCH 2/2] ACPI / glue: Drop .find_bridge() callback from struct acpi_bus_type

2013-02-28 Thread Rafael J. Wysocki
From: Rafael J. Wysocki After PCI and USB have stopped using the .find_bridge() callback in struct acpi_bus_type, the only remaining user of it is SATA, but SATA only pretends to be a user, because it points that callback to a stub always returning -ENODEV. For this reason, drop the SATA's dummy

RE: Problem with linux-3.7.7 (Stern - d01875f11f05f76fc471cec94d701201c1b34389)

2013-02-28 Thread Alan Stern
On Thu, 28 Feb 2013, Adrian Bassett wrote: > > First, things will be a lot easier if you do your testing with a 3.8 > > kernel rather than 3.7.7. > > Ok. using 3.8 checked out from the linux-stable git tree from kernel.org. I > built three test kernels - 1/ vanilla, 2/ 640c3339 reverted, 3/ no

[PATCH 3/3] usb: Make sure each c67x00 TD has been executed

2013-02-28 Thread Dave Tubbs
From: Dave Tubbs Make sure each c67x00 TD has been executed or retry using the existing retry mechanism. Reference Cypress Semiconductor BIOS User's Manual 1.2, page 3-16 Signed-off-by: Dave Tubbs --- drivers/usb/c67x00/c67x00-sched.c |6 ++ 1 files changed, 6 insertions(+), 0 deletion

Re: [PATCH 3/3] usb: Make sure each c67x00 TD has been executed

2013-02-28 Thread Sergei Shtylyov
Hello. On 02/28/2013 09:39 PM, Dave Tubbs wrote: From: Dave Tubbs Make sure each c67x00 TD has been executed or retry using the existing retry mechanism. Reference Cypress Semiconductor BIOS User's Manual 1.2, page 3-16 Signed-off-by: Dave Tubbs --- drivers/usb/c67x00/c67x00-sched.c |6

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Stephen Warren
On 02/28/2013 11:52 AM, Alan Stern wrote: > On Thu, 28 Feb 2013, Stephen Warren wrote: > >> I think this patch might cause unintended consequences. >> >> When the Tegra PHY code is converted to a driver (i.e. has its own >> probe), the initial order of execution of the PHY and EHCI driver probes >

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Alan Stern
On Thu, 28 Feb 2013, Stephen Warren wrote: > I think this patch might cause unintended consequences. > > When the Tegra PHY code is converted to a driver (i.e. has its own > probe), the initial order of execution of the PHY and EHCI driver probes > will not be guaranteed. > > In particular, sinc

[PATCH 3/3] usb: Make sure each c67x00 TD has been executed

2013-02-28 Thread Dave Tubbs
From: Dave Tubbs Make sure each c67x00 TD has been executed or retry using the existing retry mechanism. Reference Cypress Semiconductor BIOS User's Manual 1.2, page 3-16 Signed-off-by: Dave Tubbs --- drivers/usb/c67x00/c67x00-sched.c |6 ++ 1 files changed, 6 insertions(+), 0 deletion

Re: [PATCH 3/3] usb: Make sure each c67x00 TD has been executed

2013-02-28 Thread Peter Korsgaard
> "Dave" == Dave Tubbs writes: Dave> From: Dave Tubbs Dave> Make sure each c67x00 TD has been executed or retry using the existing Dave> retry mechanism. Reference Cypress Semiconductor BIOS User's Manual 1.2, Dave> page 3-16 Dave> Signed-off-by: Dave Tubbs Dave> --- Dave> drivers/

[PATCH 3/3] usb: Make sure each c67x00 TD has been executed

2013-02-28 Thread Dave Tubbs
From: Dave Tubbs Make sure each c67x00 TD has been executed or retry using the existing retry mechanism. Reference Cypress Semiconductor BIOS User's Manual 1.2, page 3-16 Signed-off-by: Dave Tubbs --- drivers/usb/c67x00/c67x00-sched.c |6 ++ 1 files changed, 6 insertions(+), 0 deletion

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Stephen Warren
On 02/27/2013 11:36 PM, Venu Byravarasu wrote: > To clear any configurations made by U-Boot on Tegra USB controller, > reset it before init in probe. > diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c > @@ -691,6 +692,10 @@ static int tegra_ehci_probe(struct platform_dev

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Stephen Warren
On 02/28/2013 08:09 AM, Alan Stern wrote: > On Thu, 28 Feb 2013, Venu Byravarasu wrote: > >> To clear any configurations made by U-Boot on Tegra USB controller, >> reset it before init in probe. >> >> Signed-off-by: Venu Byravarasu >> --- >> When U-Boot configures a Tegra USB controller in device

Re: [PATCH v4] xhci - correct comp_mode_recovery_timer on return from hibernate

2013-02-28 Thread Tony Camuso
On 02/27/2013 07:20 PM, Sarah Sharp wrote: Basically, I'd like Tony to make his first patch work, rather than pursuing moving the timer manipulation to xhci_bus_suspend/resume. Not to add confusion, but here is a less intrusive patch that simply checks to see if the Compliance Mode Recovery T

Re: [PATCH] pci: do not try to assign irq 255

2013-02-28 Thread Hannes Reinecke
On 02/27/2013 10:13 PM, Bjorn Helgaas wrote: [+cc Andy] On Wed, Feb 20, 2013 at 11:53 PM, Hannes Reinecke wrote: On 02/20/2013 05:57 PM, Yinghai Lu wrote: On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke wrote: Apparently this device is meant to use MSI _only_ so the BIOS developer did

RE: [PATCH v4] xhci - correct comp_mode_recovery_timer on return from hibernate

2013-02-28 Thread Cortes, Alexis
Hi Sarah, Tony, On 2/27/2013 6:20 PM, Sarah Sharp wrote:> On Wed, Feb 27, 2013 at 04:41:45PM -0500, Alan Stern wrote: > Well, at this point, I have to say that Alex knows more about the quirk > than I do. However, my gut feeling is that bus_suspend/resume is not > the right place to stop the com

Re: [PATCH 4/5 V2] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Alan Stern
On Thu, 28 Feb 2013, Li Fei wrote: > > Even in failed case of pm_runtime_get_sync, the usage_count > is incremented. In order to keep the usage_count with correct > value and runtime power management to behave correctly, call > pm_runtime_put(_sync) in such case. > > Signed-off-by Liu Chuansheng

Re: [PATCH 4/5] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Alan Stern
On Thu, 28 Feb 2013, Lan Tianyu wrote: > Hi Alan: > Further thinking, the device should be disconnected since the port > can't be resumed and the device will not work normally. Something like > following. Does this make sense? > --- > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hu

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-02-28 Thread Alan Stern
On Thu, 28 Feb 2013, Venu Byravarasu wrote: > To clear any configurations made by U-Boot on Tegra USB controller, > reset it before init in probe. > > Signed-off-by: Venu Byravarasu > --- > When U-Boot configures a Tegra USB controller in device mode and if the EHCI > driver of kernel tries to s

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-02-28 Thread Vivek Gautam
Hi, On Thu, Jan 31, 2013 at 9:08 PM, Felipe Balbi wrote: > On Thu, Jan 31, 2013 at 09:00:37PM +0530, Vivek Gautam wrote: >> Hi Felipe, >> >> >> On Thu, Jan 31, 2013 at 8:55 PM, Felipe Balbi wrote: >> > Hi, >> > >> > On Thu, Jan 31, 2013 at 08:53:27PM +0530, Vivek Gautam wrote: >> >> >> Moreover,

Re: [PATCH 3/3] usb: Make sure each c67x00 TD has been executed

2013-02-28 Thread Sergei Shtylyov
Hello. On 28-02-2013 13:59, Peter Korsgaard wrote: Dave> From: Dave Tubbs Dave> Make sure each c67x00 TD has been executed or retry using the existing Dave> retry mechanism. Reference Cypress Semiconductor BIOS User's Manual 1.2, Dave> page 3-16 Dave> Signed-off-by: Dave Tubbs

Re: About chipidea tree

2013-02-28 Thread Marc Kleine-Budde
On 02/28/2013 12:16 PM, Alexander Shishkin wrote: > Peter Chen writes: > >> On Tue, Feb 26, 2013 at 02:47:34PM +0100, Marc Kleine-Budde wrote: >>> On 02/26/2013 02:25 PM, Alexander Shishkin wrote: Marc Kleine-Budde writes: > On 02/26/2013 11:56 AM, Alexander Shishkin wrote: >>

Re: [PATCH v9 8/9] usb: chipidea: tell platform layer the ci core probe's result

2013-02-28 Thread Alexander Shishkin
Felipe Balbi writes: > Hi, > > On Thu, Feb 28, 2013 at 11:32:09AM +0200, Alexander Shishkin wrote: >> >> > > > > > > If the probe fails, the ci13xxx_add_device will not return >> >> > > > > > > error, >> >> > > > > > > (bus_probe_device doesn't has return value) >> >> > > > > > > therefore, the

Re: [PATCH 3/4] USB mxs-phy: use readl(), writel() instead of the _relaxed() versions

2013-02-28 Thread Alexander Shishkin
Marc Kleine-Budde writes: > This patch converts the mxs-phy driver from readl_relaxed(), writel_relaxed() > to the plain readl(), writel() functions, which are available on all > platforms. > This is done to enable compile time testing on non ARM platforms. > > Reported-by: Alexander Shishkin

Re: [PATCH] usb: dwc3: fix EP_BUSY in case of dequeue

2013-02-28 Thread Pratyush Anand
On 2/28/2013 4:18 PM, Felipe Balbi wrote: + if (list_empty(&dep->req_queued)) >+ dep->flags &= ~DWC3_EP_BUSY; not sure this is correct. Whenever req_queue isn't empty, we call dwc3_stop_active_transfer() which will clear DWC3_EP_BUSY flag. Yes, if we clear DWC3_EP_BUSY in dwc3

Re: [PATCH 2/3] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-28 Thread Felipe Balbi
On Thu, Feb 28, 2013 at 10:23:03AM +0100, Marc Kleine-Budde wrote: > On 02/28/2013 08:57 AM, Felipe Balbi wrote: > > On Wed, Feb 27, 2013 at 03:16:29PM +0100, Marc Kleine-Budde wrote: > >> From: Michael Grzeschik > >> > >> This adds two little devicetree helper functions for determining the > >>

Re: About chipidea tree

2013-02-28 Thread Alexander Shishkin
Peter Chen writes: > On Tue, Feb 26, 2013 at 02:47:34PM +0100, Marc Kleine-Budde wrote: >> On 02/26/2013 02:25 PM, Alexander Shishkin wrote: >> > Marc Kleine-Budde writes: >> > >> >> On 02/26/2013 11:56 AM, Alexander Shishkin wrote: >> >>> Peter Chen writes: >> >>> >> Hi Alex, >> >>> >> >

[PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-02-28 Thread Marc Kleine-Budde
From: Sascha Hauer Even if a chipidea core is otg capable the board may not. This allows to explicitly set the core to host/peripheral mode. Without these flags the driver falls back to the old behaviour. Signed-off-by: Sascha Hauer Signed-off-by: Marc Kleine-Budde --- drivers/usb/chipidea/co

[PATCH 2/5] USB chipidea: add PTW and PTS handling

2013-02-28 Thread Marc Kleine-Budde
From: Michael Grzeschik This patch makes it possible to configure the PTW and PTS bits inside the portsc register for host and device mode before the driver starts and the phy can be addressed as hardware implementation is designed. Signed-off-by: Michael Grzeschik Signed-off-by: Sascha Hauer

[PATCH 1/5] USB chipidea: ci13xxx-imx: create dynamic platformdata

2013-02-28 Thread Marc Kleine-Budde
From: Michael Grzeschik This patch removes the limitation of having only one instance of the ci13xxx-imx platformdata and makes different configurations possible. Reviewed-by: Peter Chen Signed-off-by: Michael Grzeschik Signed-off-by: Sascha Hauer Signed-off-by: Marc Kleine-Budde --- driver

[PATCH 4/5] USB chipidea i.MX: introduce dr_mode property

2013-02-28 Thread Marc Kleine-Budde
From: Sascha Hauer The dr_mode devicetree property allows to explicitly specify the host/peripheral/otg mode. This is necessary for boards without proper ID pin handling. Reviewed-by: Peter Chen Signed-off-by: Sascha Hauer Signed-off-by: Marc Kleine-Budde --- Documentation/devicetree/binding

[PATCH 5/5] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-02-28 Thread Marc Kleine-Budde
From: Sascha Hauer This patch replaces the hand crafted code to retrieve the phy's phandle from the DT by the helper function devm_usb_get_phy_by_phandle() which has been added in commit: "5d3c28b usb: otg: add device tree support to otg library" Reviewed-by: Kishon Vijay Abraham I Reviewe

[PATCH 0/5] chipidea-for-v3.10-v2: USB chipidea: make use of DT helpers in chipidea driver improve driver

2013-02-28 Thread Marc Kleine-Budde
Hello, this series depends on the series "[PATCH 0/3] otg-for-v3.10-v2: separate phy code and add DT helper" (a.k.a. tags/otg-for-v3.10-v2) posted earlier and is intended for v3.10. The chipidea driver is converted to make use of the DT helper functions. No changes since v1, just rebased to otg-f

Re: [PATCH 3/3] USB mxs-phy: Register phy with framework

2013-02-28 Thread Marc Kleine-Budde
On 02/28/2013 10:40 AM, Alexander Shishkin wrote: > Marc Kleine-Budde writes: > >> On 02/28/2013 09:01 AM, Felipe Balbi wrote: >>> hi, >>> >>> On Wed, Feb 27, 2013 at 03:16:30PM +0100, Marc Kleine-Budde wrote: From: Sascha Hauer We now have usb_add_phy_dev(), so use it to register

[PATCH 0/4] otg-for-v3.10-v2: separate phy code and add DT helper

2013-02-28 Thread Marc Kleine-Budde
Hello, this series depends on the bugfix patch "USB otg: use try_module_get in all usb_get_phy functions and add missing module_put" (a.k.a tags/otg-for-v3.9-v1) posted earlier and is inteded for v3.10. It separates the phy from the otg code and adds DT helper functions. In mxs-phy the {read,write

[PATCH 1/4] USB: move bulk of otg/otg.c to phy/phy.c

2013-02-28 Thread Marc Kleine-Budde
From: Sascha Hauer Most of otg/otg.c is not otg specific, but phy specific, so move it to the phy directory. Cc: Felipe Balbi Reported-by: Kishon Vijay Abraham I Signed-off-by: Sascha Hauer Signed-off-by: Marc Kleine-Budde --- drivers/usb/otg/otg.c| 427

[PATCH 4/4] USB mxs-phy: Register phy with framework

2013-02-28 Thread Marc Kleine-Budde
From: Sascha Hauer We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver. Reviewed-by: Kishon Vijay Abraham I Reviewed-by: Peter Chen Acked-by: Felipe Balbi Signed-off-by: Sascha Hauer Signed-off-by: Marc Kleine-Budde --- dri

[PATCH 3/4] USB mxs-phy: use readl(), writel() instead of the _relaxed() versions

2013-02-28 Thread Marc Kleine-Budde
This patch converts the mxs-phy driver from readl_relaxed(), writel_relaxed() to the plain readl(), writel() functions, which are available on all platforms. This is done to enable compile time testing on non ARM platforms. Reported-by: Alexander Shishkin Signed-off-by: Marc Kleine-Budde --- dr

[PATCH 2/4] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-28 Thread Marc Kleine-Budde
From: Michael Grzeschik This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg, dual-role) and phy_type (utmi, ulpi,...) from the devicetree. Cc: Felipe Balbi Signed-off-by: Michael Grzeschik Signed-off-by: Sascha Hauer Signed-off-by: Marc Kleine-B

Re: [PATCH] usb: dwc3: fix EP_BUSY in case of dequeue

2013-02-28 Thread Felipe Balbi
Hi, On Thu, Feb 28, 2013 at 04:05:31PM +0530, Pratyush Anand wrote: > To reproduce the issue: > > -- Gadget dequeues all submitted requests to the endpoint. > -- Some of them was not even queued to the dwc3 core. > -- Such requests will never complete and a transfer completion interrupt > for the

Re: [PATCH v9 8/9] usb: chipidea: tell platform layer the ci core probe's result

2013-02-28 Thread Felipe Balbi
Hi, On Thu, Feb 28, 2013 at 06:06:55PM +0800, Peter Chen wrote: > > >> > > > > > > If the probe fails, the ci13xxx_add_device will not return > > >> > > > > > > error, > > >> > > > > > > (bus_probe_device doesn't has return value) > > >> > > > > > > therefore, the platform layer can't know whethe

Re: [PATCH v9 8/9] usb: chipidea: tell platform layer the ci core probe's result

2013-02-28 Thread Felipe Balbi
Hi, On Thu, Feb 28, 2013 at 11:32:09AM +0200, Alexander Shishkin wrote: > >> > > > > > > If the probe fails, the ci13xxx_add_device will not return > >> > > > > > > error, > >> > > > > > > (bus_probe_device doesn't has return value) > >> > > > > > > therefore, the platform layer can't know whethe

[PATCH 4/5] usb: otg: ab8500-usb: drop support for ab8500 pre v2.0

2013-02-28 Thread Fabio Baltieri
AB8500 versions preceding 2.0 were only used internally by ST-Ericsson and are not supported anymore. This patch drops all v1.0 and v1.1 support code. Acked-by: Linus Walleij Signed-off-by: Fabio Baltieri --- drivers/usb/otg/ab8500-usb.c | 139 --- 1 fil

[PATCH 1/5] usb: musb: ux500_dma: add missing MEM resource check

2013-02-28 Thread Fabio Baltieri
From: Virupax Sadashivpetimath Fix dma_controller_create() fail path in case memory resource is missing. Acked-by: Linus Walleij Signed-off-by: Virupax Sadashivpetimath Signed-off-by: Fabio Baltieri --- drivers/usb/musb/ux500_dma.c | 12 +++- 1 file changed, 11 insertions(+), 1 dele

[PATCH 3/5] usb: musb: ux500: add otg notifier support

2013-02-28 Thread Fabio Baltieri
Add transceiver notifier event handling to the ux500 driver to set vbus on specific transceiver events. Acked-by: Linus Walleij Signed-off-by: Fabio Baltieri --- drivers/usb/musb/ux500.c | 41 + 1 file changed, 41 insertions(+) diff --git a/drivers/usb/m

[PATCH 5/5] usb: otg: ab8500-usb: update irq handling code

2013-02-28 Thread Fabio Baltieri
Update irq handling code to notify all possible link status changes of AB8500 and AB8505 to the ux500-musb glue driver. The additional event codes will be used for pm-runtime implementation, and are defined in a separate ux500-specific header. This also modify the irq registration code to use dev

[PATCH 2/5] usb: musb: ux500: implement musb_set_vbus

2013-02-28 Thread Fabio Baltieri
Add ux500_musb_set_vbus() implementation for ux500. This is based on the version originally developed inside ST-Ericsson. Acked-by: Linus Walleij Signed-off-by: Fabio Baltieri --- drivers/usb/musb/ux500.c | 64 1 file changed, 64 insertions(+)

[PATCH 0/5] musb-ux500 and ab8500-usb updates

2013-02-28 Thread Fabio Baltieri
Hello Felipe, This series is an initial effort to update current UX500 specific MUSB/OTG drivers with the various improvements and fixes developed internally by ST-Ericsson since the driver was initially merged. The driver currently deployed by STE includes many updates such as runtime PM support

[PATCH] usb: dwc3: fix EP_BUSY in case of dequeue

2013-02-28 Thread Pratyush Anand
To reproduce the issue: -- Gadget dequeues all submitted requests to the endpoint. -- Some of them was not even queued to the dwc3 core. -- Such requests will never complete and a transfer completion interrupt for them will never be received. -- In such situation, we will not be clearing DWC3_EP_B

Re: [PATCH v9 8/9] usb: chipidea: tell platform layer the ci core probe's result

2013-02-28 Thread Peter Chen
On Thu, Feb 28, 2013 at 11:32:09AM +0200, Alexander Shishkin wrote: > Felipe Balbi writes: > > > Hi, > > > > On Thu, Feb 28, 2013 at 04:31:44PM +0800, Peter Chen wrote: > >> > > > > > > If the probe fails, the ci13xxx_add_device will not return > >> > > > > > > error, > >> > > > > > > (bus_probe

Re: [PATCH 3/3] usb: Make sure each c67x00 TD has been executed

2013-02-28 Thread Peter Korsgaard
> "Dave" == Dave Tubbs writes: Dave> From: Dave Tubbs Dave> Make sure each c67x00 TD has been executed or retry using the existing Dave> retry mechanism. Reference Cypress Semiconductor BIOS User's Manual 1.2, Dave> page 3-16 Dave> Signed-off-by: Dave Tubbs Dave> --- Dave> drivers/

Re: [PATCH 2/3] usb: c67x00 RetryCnt value in c67x00 TD should be 3

2013-02-28 Thread Peter Korsgaard
> "Dave" == Dave Tubbs writes: Dave> From: Dave Tubbs Dave> RetryCnt value in c67x00 TD should be 3 (both bits set to 1). Reference Dave> Cypress Semiconductor BIOS User's Manual 1.2, page 3-14 Acked-by: Peter Korsgaard Dave> Signed-off-by: Dave Tubbs Dave> --- Dave> drivers/usb/c

Re: [PATCH 1/3] usb: Correction to c67x00 TD data length mask

2013-02-28 Thread Peter Korsgaard
> "Dave" == Dave Tubbs writes: Dave> From: Dave Tubbs Dave> TD data length is 10 bits, correct TD_PORTLENMASK_DL. Reference Dave> Cypress Semiconductor BIOS User's Manual 1.2, page 3-10 Dave> Signed-off-by: Dave Tubbs Acked-by: Peter Korsgaard Dave> --- Dave> drivers/usb/c67x00/c

Re: [PATCH 3/3] USB mxs-phy: Register phy with framework

2013-02-28 Thread Alexander Shishkin
Marc Kleine-Budde writes: > On 02/28/2013 09:01 AM, Felipe Balbi wrote: >> hi, >> >> On Wed, Feb 27, 2013 at 03:16:30PM +0100, Marc Kleine-Budde wrote: >>> From: Sascha Hauer >>> >>> We now have usb_add_phy_dev(), so use it to register with the framework >>> to be able to find the phy from the

Re: [PATCH v9 8/9] usb: chipidea: tell platform layer the ci core probe's result

2013-02-28 Thread Alexander Shishkin
Felipe Balbi writes: > Hi, > > On Thu, Feb 28, 2013 at 04:31:44PM +0800, Peter Chen wrote: >> > > > > > > If the probe fails, the ci13xxx_add_device will not return error, >> > > > > > > (bus_probe_device doesn't has return value) >> > > > > > > therefore, the platform layer can't know whether co

Re: [PATCH 2/3] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-28 Thread Marc Kleine-Budde
On 02/28/2013 08:57 AM, Felipe Balbi wrote: > On Wed, Feb 27, 2013 at 03:16:29PM +0100, Marc Kleine-Budde wrote: >> From: Michael Grzeschik >> >> This adds two little devicetree helper functions for determining the dr_mode >> (host, peripheral, otg, dual-role) and phy_type (utmi, ulpi,...) from th

Re: [PATCH 3/3] USB mxs-phy: Register phy with framework

2013-02-28 Thread Marc Kleine-Budde
On 02/28/2013 09:01 AM, Felipe Balbi wrote: > hi, > > On Wed, Feb 27, 2013 at 03:16:30PM +0100, Marc Kleine-Budde wrote: >> From: Sascha Hauer >> >> We now have usb_add_phy_dev(), so use it to register with the framework >> to be able to find the phy from the USB driver. >> >> Reviewed-by: Kishon

[PATCH 4/5 V2] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Li Fei
Even in failed case of pm_runtime_get_sync, the usage_count is incremented. In order to keep the usage_count with correct value and runtime power management to behave correctly, call pm_runtime_put(_sync) in such case. Signed-off-by Liu Chuansheng Signed-off-by: Li Fei --- drivers/usb/core/hub

RE: [PATCH 4/5] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Li, Fei
> -Original Message- > From: Lan, Tianyu > Sent: Thursday, February 28, 2013 4:37 PM > To: Li, Fei; st...@rowland.harvard.edu > Cc: gre...@linuxfoundation.org; sarah.a.sh...@linux.intel.com; r...@sisk.pl; > linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Liu, Chuansheng > Subject:

Re: [PATCH v9 8/9] usb: chipidea: tell platform layer the ci core probe's result

2013-02-28 Thread Felipe Balbi
Hi, On Thu, Feb 28, 2013 at 04:31:44PM +0800, Peter Chen wrote: > > > > > > > If the probe fails, the ci13xxx_add_device will not return error, > > > > > > > (bus_probe_device doesn't has return value) > > > > > > > therefore, the platform layer can't know whether core's probe > > > > > > > is suc

Re: [PATCH 4/5] usb: call pm_runtime_put_sync in pm_runtime_get_sync failed case

2013-02-28 Thread Lan Tianyu
On 2013年02月28日 15:57, Li Fei wrote: > > Even in failed case of pm_runtime_get_sync, the usage_count > is incremented. In order to keep the usage_count with correct > value and runtime power management to behave correctly, call > pm_runtime_put(_sync) in such case. Hi Fei: It's not necessa

Re: [PATCH v9 8/9] usb: chipidea: tell platform layer the ci core probe's result

2013-02-28 Thread Peter Chen
On Thu, Feb 28, 2013 at 09:26:17AM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Feb 28, 2013 at 11:11:20AM +0800, Peter Chen wrote: > > On Wed, Feb 27, 2013 at 02:12:38PM +0200, Felipe Balbi wrote: > > > Hi, > > > > > > On Wed, Feb 27, 2013 at 10:22:03AM +0800, Peter Chen wrote: > > > > On Tue, F

Re: [PATCH v10 6/8] usb: chipidea: imx: add internal vbus regulator control

2013-02-28 Thread Peter Chen
On Thu, Feb 28, 2013 at 09:29:46AM +0200, Felipe Balbi wrote: > On Thu, Feb 28, 2013 at 02:06:09PM +0800, Peter Chen wrote: > > On Wed, Feb 27, 2013 at 09:08:11PM +0200, Alexander Shishkin wrote: > > >On Feb 27, 2013 8:34 AM, "Peter Chen" wrote: > > >> > > >> - For host, the vbus shoul

[PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-02-28 Thread Chen Gang
originally, when deleted the relative code, left some 'another'. need delete 'another', too. the relative patches are: commit 96f8db6a77e3490608e5b5b3f57e7201f8c85496 Author: Felipe Balbi Date: Mon Oct 10 10:33:47 2011 +0300 usb: gadget: net2272: convert to new style

[PATCH v2 corrected] usb/gadget: f_rndis: convert to new function interface with backward compatibility

2013-02-28 Thread Andrzej Pietrasiewicz
Converting rndis to the new function interface requires converting the USB rndis' function code and its users. This patch converts the f_rndis.c to the new function interface. The file is now compiled into a separate f_rndis_usb.ko module. The old function interface is provided by means of a prepro

Re: [PATCH 3/3] USB mxs-phy: Register phy with framework

2013-02-28 Thread Felipe Balbi
hi, On Wed, Feb 27, 2013 at 03:16:30PM +0100, Marc Kleine-Budde wrote: > From: Sascha Hauer > > We now have usb_add_phy_dev(), so use it to register with the framework > to be able to find the phy from the USB driver. > > Reviewed-by: Kishon Vijay Abraham I > Reviewed-by: Peter Chen > Acked-b