[PATCH] usb: host: tegra: fix potential NULL pointer dereference

2012-10-31 Thread Wei Yongjun
From: Wei Yongjun The dereference should be moved below the NULL test. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun --- drivers/usb/host/ehci-tegra.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 07:33:44PM +, Paul Zimmerman wrote: > > From: linux-usb-ow...@vger.kernel.org > > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > > Sent: Wednesday, October 31, 2012 8:07 AM > > On Wed, Oct 31, 2012 at 11:07:44AM -0400, Alan Stern wrote: > > >

[PATCH 4/4] usb: chipidea: imx: add internal vbus regulator control

2012-10-31 Thread Peter Chen
- For host, the vbus should always be on. - For otg, the vbus is off defaultly, the vbus needs to be turned on/off when usb role switches. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci.h |2 + drivers/usb/chipidea/ci13xxx_imx.c | 67 ++-- 2

[PATCH 3/4] usb: chipidea: udc: add pullup/pulldown dp at hw_device_state

2012-10-31 Thread Peter Chen
- During the connect/disconnect host, we need to pullup and pulldown dp - Make sure the dp is not pullup until the vbus is on when flag CI13XXX_PULLUP_ON_VBUS is set Signed-off-by: Peter Chen --- drivers/usb/chipidea/udc.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --g

[PATCH 2/4] usb: chipidea: add otg id switch and vbus connect/disconnect detect

2012-10-31 Thread Peter Chen
The main design flow is the same with msm otg driver, that is the id and vbus interrupt are handled at core driver, others are handled by individual drivers. - At former design, when switch usb role from device->host, it will call udc_stop, it will remove the gadget driver, so when switch role fro

[PATCH 1/4] Revert "USB: chipidea: add vbus detect for udc"

2012-10-31 Thread Peter Chen
vbus register is at otgsc, and vbus detect does not belong to device function. Revert this patch, and will move vbus detect function to drivers/usb/chipidea/udc.c This reverts commit 8c4fc031954b4eb72daf13d3c907a985a3eee208. --- drivers/usb/chipidea/ci.h |1 - drivers/usb/chipidea/udc.c |

[PATCH 0/4] Add fully tested id switch and vbus connect detect support for Chipidea

2012-10-31 Thread Peter Chen
This patchset adds fully tested otg id switch function and vbus connect/disconnect detection for chipidea driver. The mainly design of id/vbus handling follows msm otg driver. I hope the msm usb maintainer can have a look of this patchset, and give some comments, and move the whole msm usb driver t

RE: Linux USB gadget mass storage

2012-10-31 Thread victor
>> In file_storage.c, send_status(), if (transport_is_bbb()), I add the >> line >> bh->inreq->buf = bh -> buf, >> >> and in get_next_command(), if (transport_is_bbb()), I add the line >> bh->outreq->context = bh, to make the bh address to be the same. >> >> Is this patch ok? > What patch? You

[PATCH v6] usb: phy: add R-Car USB phy driver

2012-10-31 Thread Kuninori Morimoto
This patch adds Renesas R-Car USB phy driver. It supports R8A7779 chip at this point. R-Car has some USB controllers, but has only one phy-initializer. So, this driver is counting users. Signed-off-by: Kuninori Morimoto --- v5 -> v6 - used if (priv->counter++ == 0) - used if (priv->counter--

Re: [PATCH v3 2/6] PM / Runtime: introduce pm_runtime_set[get]_memalloc_noio()

2012-10-31 Thread Ming Lei
On Wed, Oct 31, 2012 at 11:41 PM, Alan Stern wrote: > > Sorry, I misread your message. You are setting the device's flag, not > the thread's flag. Never mind. > > This still doesn't help in this case where CONFIG_PM_RUNTIME is > disabled. I think it will be simpler to set the noio flag during

RE: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Paul Zimmerman
> From: Michal Nazarewicz [mailto:m...@google.com] On Behalf Of Michal > Nazarewicz > Sent: Wednesday, October 31, 2012 1:10 PM > > On Wed, Oct 31 2012, Paul Zimmerman wrote: > > Regarding that, would you guys accept a patch that adds the "buflen" > > module parameter to the mass-storage gadget?

Can't use "gpio = <&gpio1 0 0>" in reg_usb_otg_vbus: usb_otg_vbus

2012-10-31 Thread Rick Bronson
Hi, You can't seem to use: gpio = <&gpio1 0 0>; inside of: reg_usb_otg_vbus: usb_otg_vbus { because that equates to a value of zero in config->ena_gpio in drivers/regulator/core.c: if (config->ena_gpio && gpio_is_valid(config->ena_gpio)) { which means it won't drop into

[PATCH 6/6] usb: gadget: Remove reference to is_dualspeed from sysfs.

2012-10-31 Thread Michal Nazarewicz
From: Michal Nazarewicz This commit removes the /sys/devices/platform//udc//is_dualspeed file and is_dualspeeed line from /sys/devices/platform/ci13xxx_*/udc/device file. The is_dualspeed file is superseded by maximum_speed in the same directory and is_dualspeed line in device file is superseded

[PATCH 3/6] usb: gadget: storage_common: Remove FSG specific definitions.

2012-10-31 Thread Michal Nazarewicz
From: Michal Nazarewicz Since g_file_storage has been removed, this commit removes code from the storage_common.c file which has been used by file_storage.c only (and not by f_mass_storage.c). Signed-off-by: Michal Nazarewicz --- drivers/usb/gadget/storage_common.c | 28 -

[PATCH 5/6] usb: gadget: storage_common: Make fsg_lun_is_open() a function.

2012-10-31 Thread Michal Nazarewicz
From: Michal Nazarewicz Since function-line macros are to be avoided, this commit replaces the fsg_lun_is_open() macro with a static inline function. While at it, this commit also adds “inline” modifier to the fsg_lun_from_dev() function. Signed-off-by: Michal Nazarewicz --- drivers/usb/gadge

[PATCH 4/6] usb: gadget: storage_common: Drop #ifdefs used for the sake of FSG.

2012-10-31 Thread Michal Nazarewicz
From: Michal Nazarewicz storage_common.c has been used by both file_storage.c and f_mass_storage.c which had some different requirements in a few places. To accomodate for that, storage_common.c provided configuratian macros which were to be defined (or not) prior to the file #inclusion. Becaus

[PATCH 1/6] arch: Change defconfigs to point to g_mass_storage.

2012-10-31 Thread Michal Nazarewicz
From: Michal Nazarewicz The File-backed Storage Gadget (g_file_storage) is being removed, since it has been replaced by Mass Storage Gadget (g_mass_storage). This commit changes defconfigs point to the new gadget. Signed-off-by: Michal Nazarewicz --- arch/arm/configs/afeb9260_defconfig

[PATCH 0/6] Some USB gadget cleanups

2012-10-31 Thread Michal Nazarewicz
From: Michal Nazarewicz This patchset remove the following: - the File-backed Storage Gadget (g_file_storage), and - is_dualspeed file and line referenced in sysfs. Once g_file_storage is removed, it also does some cleanup inside of the storage_common.c file. Based on top of felipe/master (4274

RE: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Michal Nazarewicz
On Wed, Oct 31 2012, Paul Zimmerman wrote: > Regarding that, would you guys accept a patch that adds the "buflen" > module parameter to the mass-storage gadget? Without increasing the > buffer length above 16K, it's impossible to approach the max throughput > allowed by SuperSpeed hosts. I have no

Re: HDD spins up to slow for USB and/or Mass-Storage Driver

2012-10-31 Thread Alan Stern
On Fri, 26 Oct 2012, Sarah Sharp wrote: > On Fri, Oct 26, 2012 at 03:01:32PM -0700, Sarah Sharp wrote: > > The USB core isn't dropping the endpoints before it calls > > xhci_check_bandwidth. I remember running into this bug a while back, > > and I even started on a fix, but then couldn't reproduc

[PATCH] USB: mos7840: fix port-data memory leak

2012-10-31 Thread Johan Hovold
commit 80c00750f0c9867a65b30a17880939b6bc660a77 upstream. Fix port-data memory leak by moving port data allocation and deallocation to port_probe and port_remove. Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no driver is bound) the port private data is no longer freed at

[PATCH] USB: iuu_phoenix: fix backported patches

2012-10-31 Thread Johan Hovold
Fix two memory leaks involving dbgbuf that were introduced in port-probe error paths when backporting the following port-data fixes from v3.7 (which doesn't have dbgbuf): 0978c94 USB: iuu_phoenix: fix sysfs-attribute creation 5363655 USB: iuu_phoenix: fix port-data memory leak Reported-by: Fenggu

RE: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Wednesday, October 31, 2012 8:07 AM > On Wed, Oct 31, 2012 at 11:07:44AM -0400, Alan Stern wrote: > > On Wed, 31 Oct 2012, Michal Nazarewicz wrote: > > > > > On Wed, Oct 31 2012, Fe

Re: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation

2012-10-31 Thread Tony Lindgren
* Keshava Munegowda [121031 07:29]: > The USB2 Host device node is extracted and used in the probe > of the driver to initialize the usb ports and controller. The > platform specific initialization is also performed. > > Signed-off-by: Keshava Munegowda > --- > arch/arm/mach-omap2/usb-host.c

[PATCH] USB: EHCI: remove ehci_port_power() routine

2012-10-31 Thread Alan Stern
This patch (as1623) removes the ehci_port_power() routine and all the places that call it. There's no reason for ehci-hcd to change the port power settings; the hub driver takes care of all that stuff. There is one exception: When the controller is resumed from hibernation or following a loss of

Re: Endpoint is not halted

2012-10-31 Thread Sarah Sharp
On Wed, Oct 31, 2012 at 07:33:17PM +0530, Bhavik Kothari wrote: > Hi Sarah, > > Thanks Sarah, for your TD-size patch. > > We have tried with your given driver. > At first time, USB device gets successfully mounted, however after removing > USB device, once again if we insert the USB device, it do

[PATCH] USB: EHCI: remove unused Link Power Management code

2012-10-31 Thread Alan Stern
This patch (as1622) removes the USB-2.1 Link Power Management code from the ehci-hcd driver. This code was never integrated with usbcore, it is full of bugs, and it was not getting used by anybody. However, the debugging code for dumping the LPM-related fields in the EHCI registers is left in pla

[PATCH] USB: remove iteration limit in hub_tt_work()

2012-10-31 Thread Alan Stern
This patch (as1621) removes the limit on the number of loops allowed in hub_tt_work(). The value is arbitrary, and it's silly to have a limit in the first place -- anything beyond the limit would not get handled. Besides, it's most unlikely that we'll ever need to clear more than a couple of TT b

Re: [PATCH V2 0/3] Removing the use of VLAIS from USB Gadget and netfilter

2012-10-31 Thread David Miller
I'm not pulling this crap into my tree to deal with limitations of a non-gcc compiler. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH REPOST] usb: host: tegra remove include of

2012-10-31 Thread Stephen Warren
On 10/31/2012 06:51 AM, Felipe Balbi wrote: > Hi, > > On Mon, Oct 29, 2012 at 11:01:08AM -0600, Stephen Warren wrote: >> On 10/24/2012 01:29 PM, Stephen Warren wrote: >>> Almost nothing from this file is used, and the file will >>> hopefully be deleted soon. Copy the tiny portions that are used >>

Re: [PATCH/Ver2] [trivial] usb: Fix typo in drivers/usb

2012-10-31 Thread Greg KH
On Wed, Oct 31, 2012 at 05:06:54PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Nov 01, 2012 at 12:03:51AM +0900, Masanari Iida wrote: > > Correct spelling typo in debug messages within drivers/usb. > > > > Signed-off-by: Masanari Iida > > Acked-by: Felipe Balbi > > Greg, since now this only t

Re: [RESEND PATCH 07/11] ARM: OMAP: USB: Host: Ehci driver uses the usbhs port data

2012-10-31 Thread Keshava Munegowda
On Wednesday 31 October 2012 09:13 PM, Alan Stern wrote: On Wed, 31 Oct 2012, Keshava Munegowda wrote: The usbhs core driver data is used by the ehci driver, because the ehci driver is child of usbhs core. The unused ehci, ohci and tll specific structures are removed. platform device creation o

Re: [RESEND PATCH 07/11] ARM: OMAP: USB: Host: Ehci driver uses the usbhs port data

2012-10-31 Thread Alan Stern
On Wed, 31 Oct 2012, Keshava Munegowda wrote: > The usbhs core driver data is used by the ehci driver, because > the ehci driver is child of usbhs core. The unused ehci, ohci > and tll specific structures are removed. > platform device creation of usbhs and tll using hwmod is > removed. > > Signe

Re: [PATCH v3 2/6] PM / Runtime: introduce pm_runtime_set[get]_memalloc_noio()

2012-10-31 Thread Alan Stern
On Wed, 31 Oct 2012, Alan Stern wrote: > On Wed, 31 Oct 2012, Ming Lei wrote: > > > The below idea may help the problem which 'memalloc_noio' flag isn't set > > during > > usb_reset_device(). > > > > - for usb mass storage device, call pm_runtime_set_memalloc_noio(true) > > inside usb_stor_pr

RE: Linux USB gadget mass storage

2012-10-31 Thread Alan Stern
On Wed, 31 Oct 2012, victor wrote: > Hi, > > In usb gadget file_storage.c, check_command(), the part "Check that only > command bytes listed in the mask are non-zero" cannot handle the > SCSI_INQUIRY command of 12 01 80 00 FF 00 > > The code will return EINVAL. > > Is this a bug? No. Alan S

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-10-31 Thread Behan Webster
On 12-10-31 09:28 AM, Felipe Balbi wrote: hi, On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote: The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This patch ins

RE: Linux USB gadget mass storage

2012-10-31 Thread Alan Stern
On Wed, 31 Oct 2012, victor wrote: > Hi, > > In file_storage.c, send_status(), if (transport_is_bbb()), I add the line > bh->inreq->buf = bh -> buf, > > and in get_next_command(), if (transport_is_bbb()), I add the line > bh->outreq->context = bh, to make the bh address to be the same. > > Is t

Re: During xHC Initialization (device is not connected), when HC-RESET is asserted, software is not expecting WRC or PRC bit set

2012-10-31 Thread Alan Stern
On Wed, 31 Oct 2012, Bhavik Kothari wrote: > Hi Alan, > > Thanks for your inputs. > > As per your given instruction, we have modified a code and below is a patch, > > > --- a/linux-3.6.1/drivers/usb/core/hub.c2012-10-07 21:11:28.0 > +0530 > +++ b/linux-3.6.1/drivers/usb/core/hub.c

Re: [PATCH] usb: musb: ux500: fix 'musbid' undeclared error in ux500_remove()

2012-10-31 Thread Rajaram R
On Wed, Oct 31, 2012 at 8:00 PM, Felipe Balbi wrote: > Hi, > > On Wed, Oct 31, 2012 at 07:45:53PM +0530, Rajaram R wrote: >> On Tue, Oct 23, 2012 at 11:42 AM, Wei Yongjun wrote: >> > commit 65b3d52d02a558fbfe08e43688e15390c5ab3067 >> > (usb: musb: add musb_ida for multi instance support) >> > use

Re: [PATCH v3 2/6] PM / Runtime: introduce pm_runtime_set[get]_memalloc_noio()

2012-10-31 Thread Alan Stern
On Wed, 31 Oct 2012, Ming Lei wrote: > The below idea may help the problem which 'memalloc_noio' flag isn't set > during > usb_reset_device(). > > - for usb mass storage device, call pm_runtime_set_memalloc_noio(true) > inside usb_stor_probe2() and uas_probe(), and call > pm_runtime_set_mema

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 11:07:44AM -0400, Alan Stern wrote: > On Wed, 31 Oct 2012, Michal Nazarewicz wrote: > > > On Wed, Oct 31 2012, Felipe Balbi wrote: > > > nevertheless, I should be receiving a patch right about now removing > > > that file. Alan, care to send a patch for that ? > > >

[PATCH v2] usb/musb: remove hand-crafted id handling

2012-10-31 Thread Sebastian Andrzej Siewior
This replaced the handcrafted id handling by the PLATFORM_DEVID_AUTO value which should do the same thing. This patch probably also fixes ux500 because I did not find the "musbid" variable to remove. And we close a tiny-unlikely race window becuase the old code gave the id back before device was de

Re: [PATCH/Ver2] [trivial] usb: Fix typo in drivers/usb

2012-10-31 Thread Felipe Balbi
Hi, On Thu, Nov 01, 2012 at 12:03:51AM +0900, Masanari Iida wrote: > Correct spelling typo in debug messages within drivers/usb. > > Signed-off-by: Masanari Iida > Acked-by: Felipe Balbi Greg, since now this only touches the stuff I handle, I can apply this myself. whatever works best for you

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Alan Stern
On Wed, 31 Oct 2012, Michal Nazarewicz wrote: > On Wed, Oct 31 2012, Felipe Balbi wrote: > > nevertheless, I should be receiving a patch right about now removing > > that file. Alan, care to send a patch for that ? > > I have some other stuff to remove as well, so I can take care of it, so > Ala

[PATCH/Ver2] [trivial] usb: Fix typo in drivers/usb

2012-10-31 Thread Masanari Iida
Correct spelling typo in debug messages within drivers/usb. Signed-off-by: Masanari Iida Acked-by: Felipe Balbi --- drivers/usb/gadget/fsl_udc_core.c | 2 +- drivers/usb/gadget/tcm_usb_gadget.c | 2 +- drivers/usb/musb/musb_dsps.c| 2 +- drivers/usb/renesas_usbhs/fifo.c| 2 +- 4 f

Re: [PATCH v7 2/5] usb: s3c-hsotg: Adding phy driver support

2012-10-31 Thread Lukasz Majewski
Hi Felipe, > Hi, > > On Tue, Oct 30, 2012 at 10:27:34AM +0530, Praveen Paneri wrote: > > @@ -3501,20 +3511,27 @@ static int __devinit s3c_hsotg_probe(struct > > platform_device *pdev) int ret; > > int i; > > > > - plat = pdev->dev.platform_data; > > - if (!plat) { > > - dev_er

Re: [PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 10:35:37PM +0800, Li Yang wrote: > On Wed, Oct 31, 2012 at 9:26 PM, Felipe Balbi wrote: > > On Wed, Oct 31, 2012 at 04:06:00PM +0800, Xiaotian Feng wrote: > >> If tasklet_disable() is called before related tasklet handled, > >> tasklet_kill will never be finished. task

Re: [PATCH] usb: musb: ux500: fix 'musbid' undeclared error in ux500_remove()

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 07:45:53PM +0530, Rajaram R wrote: > On Tue, Oct 23, 2012 at 11:42 AM, Wei Yongjun wrote: > > commit 65b3d52d02a558fbfe08e43688e15390c5ab3067 > > (usb: musb: add musb_ida for multi instance support) > > used musbid in ux500_remove() but nerver declared it. > > The abo

Re: [PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Li Yang
On Wed, Oct 31, 2012 at 9:26 PM, Felipe Balbi wrote: > On Wed, Oct 31, 2012 at 04:06:00PM +0800, Xiaotian Feng wrote: >> If tasklet_disable() is called before related tasklet handled, >> tasklet_kill will never be finished. tasklet_kill is enough. > > how did you test this ? Why changing FSL drive

Re: [PATCH v3 0/4] Adding usb2.0 host-phy support for exynos5250

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 04:07:23PM +0200, Felipe Balbi wrote: > Hi, > > On Mon, Oct 29, 2012 at 07:12:36PM +0530, Vivek Gautam wrote: > > This patchset is based on the work by Praveen Paneri for > > samsung-usbphy driver: > > http://comments.gmane.org/gmane.linux.kernel.samsung-soc/12653 > >

Re: [GIT PULL] USB fixes for v3.7-rc4

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 07:50:11PM +0530, Rajaram R wrote: > Hi Felipie/Greg > > On Tue, Oct 30, 2012 at 6:17 PM, Felipe Balbi wrote: > > Hi Greg, > > > > Judging by how things are going, this is likely to be my last pull request > > for v3.7-rc cycle, unless someone finds a big regression w

Re: [PATCH v2 1/2] USB: dwc3-exynos: Add support for device tree

2012-10-31 Thread Vivek Gautam
Hi Felipe, On Wed, Oct 31, 2012 at 7:08 PM, Felipe Balbi wrote: > Hi, > On Tue, Oct 16, 2012 at 02:15:56PM +0530, Vivek Gautam wrote: >> This patch adds support to parse probe data for >> dwc3-exynos driver using device tree. >> >> Signed-off-by: Vivek Gautam > > does not apply to my dwc3 branch

Re: [PATCH 1/3] usb: otg: nop: add dt support

2012-10-31 Thread Afzal Mohammed
Hi Balbi, On Thursday 27 September 2012 11:15 AM, Afzal Mohammed wrote: This series is made over over Balbi's usb "master" branch. It applies cleanly over "musb" branch too. Please ignore this series, a new series has been posted, "usb: musb: dsps: fixes for -rc". Regards Afzal -- To unsubs

[RESEND PATCH 04/11] ARM: OMAP3: USB: Host: Beagle-XM board specific device tree node

2012-10-31 Thread Keshava Munegowda
OMAP3 Beagle-XM board specific data for usb2 host device tree node is included. In Beagle XM board , the port 2 of usb host is connected to a hub with ethernet interface. Signed-off-by: Keshava Munegowda --- arch/arm/boot/dts/omap3-beagle-xm.dts | 32 1 file ch

[RESEND PATCH 11/11] ARM: OMAP3: USB: Add pin mux configuration for beagle-xm board

2012-10-31 Thread Keshava Munegowda
The port2 of omap4 panda board is used in ULPI PHY mode. The pin mux of usbhs (usbb2) port 2 is configured accordingly. Signed-off-by: Keshava Munegowda --- arch/arm/boot/dts/omap3-beagle-xm.dts | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/oma

[RESEND PATCH 09/11] ARM: OMAP: USB: Remove the device name for TLL channel clocks for OMAP3

2012-10-31 Thread Keshava Munegowda
Since TLL channels clocks are dummy(virtual) nodes for OMAP3. The device names for these clocks are set to NULL. Signed-off-by: Keshava Munegowda --- arch/arm/mach-omap2/clock3xxx_data.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/clock3xxx_da

[RESEND PATCH 00/11] ARM: OMAP: USB: Host: Device tree Adaptation

2012-10-31 Thread Keshava Munegowda
The USB2 Host driver of OMAP3/OMAP4 are device tree complaiant with this patch series. The device tree data of UHH, EHCI, OHCI and TLL are included. The drivers are updated to extract and use the register set and interrupt numbers delivered by these device tree structures. Keshava Munegowda (11):

[RESEND PATCH 03/11] ARM: OMAP3: USB: Add USB2 Host Device Tree Node

2012-10-31 Thread Keshava Munegowda
The device tree node details of usb2 host and tll components are included for OMAP3 Signed-off-by: Keshava Munegowda --- arch/arm/boot/dts/omap3.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index 69

[RESEND PATCH 06/11] ARM: OMAP: USB: Host: USB TLL Device tree node Adaptation

2012-10-31 Thread Keshava Munegowda
The USB TLL device node is extracted and used in the probe of the driver to initialize the driver data. This TLL driver exports an API to usbhs driver to perform the port configuration. The usb2 hs driver invoke the same API in its driver probe to initialize the ports. Signed-off-by: Keshava Muneg

[RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation

2012-10-31 Thread Keshava Munegowda
The USB2 Host device node is extracted and used in the probe of the driver to initialize the usb ports and controller. The platform specific initialization is also performed. Signed-off-by: Keshava Munegowda --- arch/arm/mach-omap2/usb-host.c |2 - drivers/mfd/omap-usb-host.c

[RESEND PATCH 07/11] ARM: OMAP: USB: Host: Ehci driver uses the usbhs port data

2012-10-31 Thread Keshava Munegowda
The usbhs core driver data is used by the ehci driver, because the ehci driver is child of usbhs core. The unused ehci, ohci and tll specific structures are removed. platform device creation of usbhs and tll using hwmod is removed. Signed-off-by: Keshava Munegowda --- arch/arm/mach-omap2/usb-hos

[RESEND PATCH 02/11] ARM: OMAP4: USB: Host: Panda board specific device tree node

2012-10-31 Thread Keshava Munegowda
OMAP4 panda board specific device tree node is included. In OMAP4 panda board, the port 1 is used in ULPI PHY mode. The port 1 is connected to a on board hub with ethernet interface. TODO: The clock bindings are not yet avilable for OMAP4. hence , USB hub specific clocks are exported as dev

[RESEND PATCH 01/11] ARM: OMAP4: USB: Host: Add USB2 Host Device Tree Node

2012-10-31 Thread Keshava Munegowda
The device tree node details of usb2 host and tll components are included for OMAP4 SOC Signed-off-by: Keshava Munegowda --- .../devicetree/bindings/usb/omap-usb-host.txt | 24 .../devicetree/bindings/usb/omap-usb-tll.txt | 21 + arch/arm/boot/

[RESEND PATCH 08/11] ARM: OMAP: USB: Change the TLL clock names

2012-10-31 Thread Keshava Munegowda
The tll ports clock names are renamed as channel clocks. This is change is just adhere to TRM words Signed-off-by: Keshava Munegowda --- drivers/mfd/omap-usb-tll.c | 46 ++-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/mfd/oma

[RESEND PATCH 10/11] ARM: OMAP4: USB: Add pin mux configuration for panda board

2012-10-31 Thread Keshava Munegowda
The port1 of omap4 panda board is used in ULPI PHY mode. The pin mux of usbhs (usbb1) port 1 is configured accordingly. Signed-off-by: Keshava Munegowda --- arch/arm/boot/dts/omap4-panda.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/omap4-panda.d

[PATCH 2/2] usb: musb: dsps: document dt bindings properly

2012-10-31 Thread Afzal Mohammed
DT bindings normally use '-' (hyphens) instead of '_' (underscore), driver has it the proper way, but binding documentation does not reflect it, fix it. Signed-off-by: Afzal Mohammed --- Documentation/devicetree/bindings/usb/am33xx-usb.txt | 8 1 file changed, 4 insertions(+), 4 deletio

[PATCH 1/2] Revert "usb: musb: dsps: remove explicit NOP device creation"

2012-10-31 Thread Afzal Mohammed
This reverts commit d8c3ef256f88b7c6ecd673d03073b5645be9c5e4. Above mentioned change was made along with multi usb phy change and adding DT support for nop transceiver. But other two changes did not make it to mainline. This in effect makes dsps musb wrapper unusable even for single instance. Hen

[PATCH 0/2] usb: musb: dsps: fixes for -rc

2012-10-31 Thread Afzal Mohammed
Hi Balbi, This series contains a couple of fixes for musb dsps wrapper. First one restores capability to support at least one instance of musb. Without it, even a single instance can't be supported as change which is reverted by it was made along with multi phy changes and nop transciever dt supp

Re: [GIT PULL] USB fixes for v3.7-rc4

2012-10-31 Thread Rajaram R
Hi Felipie/Greg On Tue, Oct 30, 2012 at 6:17 PM, Felipe Balbi wrote: > Hi Greg, > > Judging by how things are going, this is likely to be my last pull request > for v3.7-rc cycle, unless someone finds a big regression which we really must > fix during v3.7-rc. > > It's rather small; just a revert

Re: [PATCH] usb: musb: ux500: fix 'musbid' undeclared error in ux500_remove()

2012-10-31 Thread Rajaram R
Hi On Tue, Oct 23, 2012 at 11:42 AM, Wei Yongjun wrote: > commit 65b3d52d02a558fbfe08e43688e15390c5ab3067 > (usb: musb: add musb_ida for multi instance support) > used musbid in ux500_remove() but nerver declared it. The above message doesnot match with your fix. You say ux500_remove is using m

Re: [PATCH v3 0/4] Adding usb2.0 host-phy support for exynos5250

2012-10-31 Thread Felipe Balbi
Hi, On Mon, Oct 29, 2012 at 07:12:36PM +0530, Vivek Gautam wrote: > This patchset is based on the work by Praveen Paneri for > samsung-usbphy driver: > http://comments.gmane.org/gmane.linux.kernel.samsung-soc/12653 > > Changes from v2: > - Using "EXYNOS5_PHY_" as common prefix along with exact n

Re: [PATCH v7 2/5] usb: s3c-hsotg: Adding phy driver support

2012-10-31 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 10:27:34AM +0530, Praveen Paneri wrote: > @@ -3501,20 +3511,27 @@ static int __devinit s3c_hsotg_probe(struct > platform_device *pdev) > int ret; > int i; > > - plat = pdev->dev.platform_data; > - if (!plat) { > - dev_err(&pdev->dev, "

Re: [PATCH] usb/musb: remove hand-crafted id handling

2012-10-31 Thread Felipe Balbi
On Wed, Oct 31, 2012 at 02:45:55PM +0100, Sebastian Andrzej Siewior wrote: > On 10/31/2012 02:24 PM, Felipe Balbi wrote: > >unfortunately doesn't apply to my musb branch. Care to respin this > >patch ? > > Let me wait a bit until your tree makes it to k.o and then I rebase on > top of it. cool, t

Re: [PATCH] usb/musb: remove hand-crafted id handling

2012-10-31 Thread Sebastian Andrzej Siewior
On 10/31/2012 02:24 PM, Felipe Balbi wrote: unfortunately doesn't apply to my musb branch. Care to respin this patch ? Let me wait a bit until your tree makes it to k.o and then I rebase on top of it. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

Re: dummy_hcd: try to add qh

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 02:44:22PM +0100, Sebastian Andrzej Siewior wrote: > On 10/31/2012 02:15 PM, Felipe Balbi wrote: > >Hi, > Hi, > > >On Sat, Oct 27, 2012 at 12:53:49AM +0200, Sebastian Andrzej Siewior wrote: > >>I tried to add the qh structure. It is likely that patch #1 isn't 100% > >>

Re: [PATCH v2 1/2] USB: dwc3-exynos: Add support for device tree

2012-10-31 Thread Felipe Balbi
Hi, On Tue, Oct 16, 2012 at 02:15:56PM +0530, Vivek Gautam wrote: > This patch adds support to parse probe data for > dwc3-exynos driver using device tree. > > Signed-off-by: Vivek Gautam does not apply to my dwc3 branch. Care to respin ? -- balbi signature.asc Description: Digital signature

Re: dummy_hcd: try to add qh

2012-10-31 Thread Sebastian Andrzej Siewior
On 10/31/2012 02:15 PM, Felipe Balbi wrote: Hi, Hi, On Sat, Oct 27, 2012 at 12:53:49AM +0200, Sebastian Andrzej Siewior wrote: I tried to add the qh structure. It is likely that patch #1 isn't 100% checkpatch clear. If we agree on #3 then I go and clean it up. I wonder what I should do with

Re: [PATCH 00/11] ARM: OMAP: USB: Host: Device tree Adaptation

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 05:46:38PM +0530, Keshava Munegowda wrote: > The USB2 Host driver of OMAP3/OMAP4 are device tree complaiant with > this patch series. > The device tree data of UHH, EHCI, OHCI and TLL are included. > The drivers are updated to extract and use the register set and > inte

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-31 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 10:44:27AM +0100, Dmytro Milinevskyy wrote: > Convert USB descriptor's fields to CPU byte order before using locally in USB > NCM gadget driver. > Tested on MIPS32 big-endian device. > > Signed-off-by: Dmytro Milinevskyy > --- > drivers/usb/gadget/f_ncm.c | 12 +

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-31 Thread Felipe Balbi
On Sun, Oct 28, 2012 at 06:48:29PM +0100, Sebastian Andrzej Siewior wrote: > On Sun, Oct 28, 2012 at 06:30:02PM +0100, Dmytro Milinevskyy wrote: > > I was trying to keep 2 tabs but checkpatch didn't accept long line > > that's why I killed extra tab. > > Then move them to the code section instead

Re: [PATCH] usb:musb: Dequeue urbs on device unplug

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 10, 2012 at 10:06:03AM +0530, Virupax Sadashivpetimath wrote: > Flush queued urbs on receiving device disconnect > interrupt. This is required for successful disconnect > and successive enumeration of the device. > > In a failure case khubd hangs on usb-storage thread > for comple

Re: [PATCH] usb:musb: Dequeue urbs on device unplug

2012-10-31 Thread Felipe Balbi
hi, On Mon, Oct 22, 2012 at 06:51:39AM +0200, Virupax SADASHIVPETIMATH wrote: > > -Original Message- > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Monday, October 15, 2012 5:49 PM > > To: Virupax SADASHIVPETIMATH > > Cc: ba...@ti.com; st...@rowland.harvard.edu; linux-usb@vger.kern

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-10-31 Thread Felipe Balbi
hi, On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote: > The use of variable length arrays in structs (VLAIS) in the Linux Kernel code > precludes the use of compilers which don't implement VLAIS (for instance the > Clang compiler). This patch instead calculates offsets into the kmallo

Re: [PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Felipe Balbi
On Wed, Oct 31, 2012 at 04:06:00PM +0800, Xiaotian Feng wrote: > If tasklet_disable() is called before related tasklet handled, > tasklet_kill will never be finished. tasklet_kill is enough. how did you test this ? Why changing FSL driver instead of switching over to chipidea which is supposed to

Re: [PATCH] usb/musb: remove hand-crafted id handling

2012-10-31 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 12:43:02PM +0100, Sebastian Andrzej Siewior wrote: > This replaced the handcrafted id handling by the PLATFORM_DEVID_AUTO > value which should do the same thing. > This patch probably also fixes ux500 because I did not find the "musbid" > variable to remove. And we clos

Re: dummy_hcd: try to add qh

2012-10-31 Thread Felipe Balbi
Hi, On Sat, Oct 27, 2012 at 12:53:49AM +0200, Sebastian Andrzej Siewior wrote: > I tried to add the qh structure. It is likely that patch #1 isn't 100% > checkpatch clear. If we agree on #3 then I go and clean it up. I wonder what I should do with this series... -- balbi signature.asc Descrip

Re: [PATCH 11/16] usb/gadget: fix error path in uvc_function_bind()

2012-10-31 Thread Felipe Balbi
Hi, On Mon, Oct 22, 2012 at 10:15:05PM +0200, Sebastian Andrzej Siewior wrote: > The "video->minor = -1" assigment is done in V4L2 by > video_register_device() so it is removed here. > Now. uvc_function_bind() calls in error case uvc_function_unbind() for > cleanup. The problem is that uvc_functio

Re: [PATCH 05/16] usb/gadget: add some error recovery in afunc_bind()

2012-10-31 Thread Felipe Balbi
On Wed, Oct 24, 2012 at 02:20:02PM +0200, Sebastian Andrzej Siewior wrote: > On 10/24/2012 12:25 PM, Sergei Shtylyov wrote: > >Hello. > > Hi, > > >On 23-10-2012 0:14, Sebastian Andrzej Siewior wrote: > > > >>In case something goes wrong here, don't leak memory / endpoints. > > > >>Cc: jassisinghb

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 01:55:03PM +0100, Michal Nazarewicz wrote: > On Wed, Oct 31 2012, Felipe Balbi wrote: > > nevertheless, I should be receiving a patch right about now removing > > that file. Alan, care to send a patch for that ? > > I have some other stuff to remove as well, so I can

Re: [PATCH REPOST] usb: host: tegra remove include of

2012-10-31 Thread Felipe Balbi
Hi, On Mon, Oct 29, 2012 at 11:01:08AM -0600, Stephen Warren wrote: > On 10/24/2012 01:29 PM, Stephen Warren wrote: > > Almost nothing from this file is used, and the file will hopefully be > > deleted soon. Copy the tiny portions that are used directly into > > ehci-tegra.c. I believe that Venu B

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Michal Nazarewicz
On Wed, Oct 31 2012, Felipe Balbi wrote: > nevertheless, I should be receiving a patch right about now removing > that file. Alan, care to send a patch for that ? I have some other stuff to remove as well, so I can take care of it, so Alan can spend his time on something more important. -- Best

Re: [PATCH 1/4 v5] usb: phy: add R-Car USB phy driver

2012-10-31 Thread Felipe Balbi
On Mon, Oct 29, 2012 at 12:44:16AM -0700, Kuninori Morimoto wrote: > This patch adds Renesas R-Car USB phy driver. > It supports R8A7779 chip at this point. > > R-Car has some USB controllers, but has only one phy-initializer. > So, this driver is counting users. > > Signed-off-by: Kuninori Morim

Re: [PATCH] [trivial] usb: Fix typo in drivers/usb

2012-10-31 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 12:30:59PM -0700, Greg KH wrote: > On Fri, Oct 26, 2012 at 11:43:19PM +0900, Masanari Iida wrote: > > Correct spelling typo in debug message within drivers/usb. > > > > Signed-off-by: Masanari Iida > > This no longer applies, please redo it against the latest linux-n

Re: [PATCH v5 1/4] Revert "usb: otg: mxs-phy: Fix mx23 operation"

2012-10-31 Thread Fabio Estevam
On Mon, Oct 22, 2012 at 5:13 AM, Peter Chen wrote: > The real reason causes mx23 fail are: > > - Calling mxs_phy_hw_init(mxs_phy) again at connection > - Error connect/disconnect nodity at hub.c > > The coming patch will fix above two problems, Mike Thompson So shouldn't this patch be the last on

Re: [PATCH v5 2/4] usb: mxs-phy: re-init phy during the connection is useless

2012-10-31 Thread Felipe Balbi
On Mon, Oct 22, 2012 at 03:13:10PM +0800, Peter Chen wrote: > As phy is working, re-init phy may cause unexpected results > > Signed-off-by: Peter Chen Acked-by: Felipe Balbi > --- > drivers/usb/otg/mxs-phy.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drive

Re: [PATCH v5 1/4] Revert "usb: otg: mxs-phy: Fix mx23 operation"

2012-10-31 Thread Felipe Balbi
Hi, On Mon, Oct 22, 2012 at 03:13:09PM +0800, Peter Chen wrote: > The real reason causes mx23 fail are: > > - Calling mxs_phy_hw_init(mxs_phy) again at connection > - Error connect/disconnect nodity at hub.c > > The coming patch will fix above two problems, Mike Thompson > tested his hardware wo

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 24, 2012 at 08:47:04PM +0200, Michal Nazarewicz wrote: > > On Wed, Oct 24, 2012 at 07:30:42PM +0200, Michal Nazarewicz wrote: > >> At first it looks strange as FSG does not use composite, but yeah: > > On Wed, Oct 24 2012, Sebastian Andrzej Siewior wrote: > > Yeah. However, it sho

[PATCH 07/11] ARM: OMAP: USB: Host: Ehci driver uses the usbhs port data

2012-10-31 Thread Keshava Munegowda
The usbhs core driver data is used by the ehci driver, because the ehci driver is child of usbhs core. The unused ehci, ohci and tll specific structures are removed. platform device creation of usbhs and tll using hwmod is removed. Signed-off-by: Keshava Munegowda --- arch/arm/mach-omap2/usb-hos

[PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation

2012-10-31 Thread Keshava Munegowda
The USB2 Host device node is extracted and used in the probe of the driver to initialize the usb ports and controller. The platform specific initialization is also performed. Signed-off-by: Keshava Munegowda --- arch/arm/mach-omap2/usb-host.c |2 - drivers/mfd/omap-usb-host.c

[PATCH 10/11] ARM: OMAP4: USB: Add pin mux configuration for panda board

2012-10-31 Thread Keshava Munegowda
The port1 of omap4 panda board is used in ULPI PHY mode. The pin mux of usbhs (usbb1) port 1 is configured accordingly. Signed-off-by: Keshava Munegowda --- arch/arm/boot/dts/omap4-panda.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/omap4-panda.d

  1   2   >