Sarah,
We've found the TD_size issue when developing a new XHCI host controller also:
1. need fix xhci_td_remainder() and xhci_v1_0_td_remainder()
2. we need to use DIV_ROUND_UP() instead of roundup() when we
calculating total_packet_count .
As in recent kernel versions, roundup() is defined as f
Hi,
On Fri, Oct 26, 2012 at 12:32:46AM +0100, Grant Likely wrote:
> On Thu, Oct 25, 2012 at 11:58 AM, Felipe Balbi wrote:
> > Hi,
> >
> > On Thu, Oct 25, 2012 at 10:19:19AM +, Grant Likely wrote:
> >> Felipe Balbi writes:
> >>
> >> >
> >> > we are compiling the driver always with full OTG
>
it seems that data are interpreted differently. While the host is
getting tons of -71 errors, data is passed to vmware correctly.
I've attached two traces that I ran simultaneously on the host and the
guest. One thing that I noticed is that the same camera is setting
different video standards
From: Tilman Schmidt
Date: Wed, 24 Oct 2012 20:44:32 +0200
> The delayed work function int_in_work() may call usb_reset_device()
> and thus, indirectly, the driver's pre_reset method. Trying to
> cancel the work synchronously in that situation would deadlock.
> Fix by avoiding cancel_work_sync()
"Shawn J. Goff" writes:
> On 10/25/2012 03:40 AM, Bjørn Mork wrote:
>
>> Which IMHO points to the firmware implementation as the major
>> difference.
> Just to be sure: are you talking about the modem's firmware?
Yes
> After the failure happens, I can see from USB traces (and this is with
> an e
Hi Felipe,
On 18 October 2012 22:59, Felipe Balbi wrote:
> Hi,
>
> On Thu, Oct 18, 2012 at 12:44:50PM -0400, Alan Stern wrote:
>> On Thu, 18 Oct 2012, Sarah Sharp wrote:
>>
>> > For system suspend while the DW3 hardware is in host mode, doesn't the
>> > USB core prevent drivers from submitting UR
Driver anchors the tx urbs and defers the urb submission if
a transmit request comes when the interface is suspended.
Anchoring urb increments the urb reference count. These
deferred urbs are later accessed by calling usb_get_from_anchor()
for submission during interface resume. usb_get_from_anchor
Hi guys,
I have the same problem with this xHCI controller. However my setup is
a little bit different - I have a USB 2.0 hub attached to the root
port, then a mouse attached to the USB 2.0 hub port. The hub is a MTT
hub with 7 ports (other hubs have the same problem, so I don't think
it is the hu
Sarah Sharp wrote:
> On Thu, Oct 25, 2012 at 06:06:53PM -0400, cov...@ccs.covici.com wrote:
> > Sarah Sharp wrote:
> > > On Thu, Oct 25, 2012 at 12:53:52PM -0400, cov...@ccs.covici.com wrote:
> > > > Sarah Sharp wrote:
> > > > > On Wed, Oct 24, 2012 at 12:52:18PM -0400, cov...@ccs.covici.com wr
On Thu, Oct 25, 2012 at 11:58 AM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Oct 25, 2012 at 10:19:19AM +, Grant Likely wrote:
>> Felipe Balbi writes:
>>
>> >
>> > we are compiling the driver always with full OTG
>> > capabilities, so that board_mode trick becomes
>> > useless.
>> >
>> > Signed-of
On Thu, Oct 25, 2012 at 06:06:53PM -0400, cov...@ccs.covici.com wrote:
> Sarah Sharp wrote:
> > On Thu, Oct 25, 2012 at 12:53:52PM -0400, cov...@ccs.covici.com wrote:
> > > Sarah Sharp wrote:
> > > > On Wed, Oct 24, 2012 at 12:52:18PM -0400, cov...@ccs.covici.com wrote:
> > > How do I get those k
Hi Chintan,
I think I have a fix for the TD size issue. Can you install a custom
kernel and test it out on your host controller?
The directions for building a custom kernel are here:
http://kernelnewbies.org/KernelBuild
Instead of running any of the commands in "Which kernel to build?"
Sarah Sharp wrote:
> I'm not sure, since I've never attempted to memory map PCI registers
> from userspace. I was under the impression that you just can't do that.
Need root, and the kernel still gets a say, but yes, you can just do that.
http://stuge.se/physrd.c
//Peter
--
To unsubscribe from
Going back over your example, it does look there is a couple bugs in the
Linux xHCI TD size calculations. Notes are below, I'll send you a patch
to test out on your host controller shortly.
Thanks for catching this!
Sarah Sharp
On Thu, Oct 25, 2012 at 02:24:04PM -0700, Sarah Sharp wrote:
> On F
Sarah Sharp wrote:
> On Thu, Oct 25, 2012 at 12:53:52PM -0400, cov...@ccs.covici.com wrote:
> > Sarah Sharp wrote:
> >
> > > On Wed, Oct 24, 2012 at 12:52:18PM -0400, cov...@ccs.covici.com wrote:
> > > > Sebastian Andrzej Siewior wrote:
> > > >
> > > > > On Wed, Oct 24, 2012 at 11:13:51AM -04
Oliver Neukum writes:
> On Thursday 25 October 2012 21:58:37 Bjørn Mork wrote:
>> No need for a vendor specific probe exception just to
>> match on the interface class.
>
> No need for a private macro. It already exists.
>
> /**
> * USB_DEVICE_AND_INTERFACE_INFO - describe a specific usb device
Ah, ok, I thought your host was a 0.96 host. I see that the xHCI driver
does handle the TD size field differently, based on whether the host is
a 1.0 host or not (see xhci_td_remainder and xhci_v1_0_td_remainder).
I'll have to take a look at that code again to see if it's compliant
with the xHCI 1
On 10/25/2012 03:40 AM, Bjørn Mork wrote:
"Shawn J. Goff" writes:
On 10/24/2012 05:19 PM, Bjørn Mork wrote:
"Shawn J. Goff" wrote:
I've only made it happen on my kernel - I
tried
on 3.6.2, but it seems to not happen there.
Good. But I have a feeling that you switched more than just the
ker
Hi all,
I've caught up on my big pile of USB patches that were sent to me during
the merge window (and a bit before). So if I haven't applied a patch
that you sent me, consider it lost, so please resend.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
On Thu, Oct 25, 2012 at 01:21:16PM -0700, Sarah Sharp wrote:
> The following changes since commit 8daf8b6086f9d575200cd0aa3797e26137255609:
>
> ehci: Add yet-another Lucid nohandoff pci quirk (2012-10-25 11:43:44 -0700)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub
On Thursday 25 October 2012 21:58:37 Bjørn Mork wrote:
> No need for a vendor specific probe exception just to
> match on the interface class.
No need for a private macro. It already exists.
/**
* USB_DEVICE_AND_INTERFACE_INFO - describe a specific usb device with a class
of usb interfaces
* @
Remove the variable ep_ctx from xhci_add_endpoint(), since it is
assigned but unused. Caught by Coverity.
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index ffe2
Coverity complains that xhci_evaluate_context_result() is missing a
break statement after the COMP_EBADSLT switch case. It's not a big
deal, since we wanted to return the same error code as the case
statement below it does. The end result would be one that a Slot
Disabled error completion code wo
The following changes since commit 8daf8b6086f9d575200cd0aa3797e26137255609:
ehci: Add yet-another Lucid nohandoff pci quirk (2012-10-25 11:43:44 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
for-usb-linus-2012-10-25
for you to
Remove the variable slot_ctx from xhci_dbg_ctx(), since it is assigned
but unused. Caught by Coverity.
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-dbg.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-dbg.c b/drivers/usb/host/xhci-dbg.c
i
The command cancellation code doesn't check whether find_trb_seg()
couldn't find the segment that contains the TRB to be canceled. This
could cause a NULL pointer deference later in the function when next_trb
is called. It's unlikely to happen unless something is wrong with the
command ring point
On Thursday, October 25, 2012 07:15:58 PM Ulrich Eckhardt wrote:
> Am 24.10.2012 23:13, schrieb Bjorn Helgaas:
> > On Wed, Oct 24, 2012 at 3:10 PM, Rafael J. Wysocki wrote:
> >
> >> It can be disabled by writing "on" to the controller's
> >> /sys/devices/.../power/control file.
> >
> > Ulrich, if
On Wednesday, October 24, 2012 02:18:40 PM Bjorn Helgaas wrote:
> On Tue, Oct 23, 2012 at 11:14 AM, Ulrich Eckhardt
> wrote:
> > Am 23.10.2012 01:40, schrieb Sarah Sharp:
> >> On Sun, Oct 21, 2012 at 06:03:24PM +0200, Ulrich Eckhardt wrote:
> >
> >>> I have tested it with Kernel 3.6.2. The USB3 p
No need for a vendor specific probe exception just to
match on the interface class.
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c | 79 ++-
1 file changed, 41 insertions(+), 38 deletions(-)
diff --git a/drivers/usb/serial/option.c b/drivers/
Bjørn Mork (3):
USB: option: never bind to a usb-storage interface
USB: option: replace vendor probe rule with match flags
USB: option: idVendor and idProduct are __le16
drivers/usb/serial/option.c | 94 +--
1 file changed, 46 insertions(+), 48 dele
There are many modems in addition to the D-Link DWM 652
exposing the CD interface in modem mode, and some expose
an integrated card reader as well. Always ignore these
interfaces.
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c |9 ++---
1 file changed, 2 insertions(+), 7 delet
The exception is needed on big endian systems too.
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index eb20acf..c14def3 100644
--- a/drivers/usb/seri
On Thu, Oct 25, 2012 at 12:53:52PM -0400, cov...@ccs.covici.com wrote:
> Sarah Sharp wrote:
>
> > On Wed, Oct 24, 2012 at 12:52:18PM -0400, cov...@ccs.covici.com wrote:
> > > Sebastian Andrzej Siewior wrote:
> > >
> > > > On Wed, Oct 24, 2012 at 11:13:51AM -0400, cov...@ccs.covici.com wrote:
>
On Mon, Oct 15, 2012 at 05:39:28PM +0200, Anisse Astier wrote:
> On Tue, 9 Oct 2012 13:00:23 -0400 (EDT), Alan Stern
> wrote :
>
> > On Tue, 9 Oct 2012, Anisse Astier wrote:
> >
> > > > How about matching any BIOS from Lucid, regardless of the board name?
> > >
> > > I was just being conservat
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Oct 25, 2012 at 06:34:21PM +, Avner Flesch wrote:
> Hi,
>
> Thanks for the reply.
> Right now I am working kernel 3.5.
> I want to connect USB to Serial device (FDTI FT232R base) and be ab
Hi,
Thanks for the reply.
Right now I am working kernel 3.5.
I want to connect USB to Serial device (FDTI FT232R base) and be able to use
/dev/ttyUSB. (I can mknod manualy). In fact I am going to connect hub, and I
will need
up to 4 serial ports.
I used make menuconfig - and I marked all the req
On Thu, 25 Oct 2012, Ulrich Eckhardt wrote:
> Am 25.10.2012 03:24, schrieb Ming Lei:
> >> Lei, do you have any doc describing how to use those tracepoints?
> >
> > Hi Bjorn Helgaas,
> >
> > Firstly, please enable these tracepoints via below
> >
> >echo 1 > /sys/kernel/debug/tracing/eve
On Thu, Oct 25, 2012 at 07:05:04PM +0200, Johan Hovold wrote:
> On Thu, Oct 25, 2012 at 09:40:03AM -0700, Greg KH wrote:
> > On Thu, Oct 25, 2012 at 03:42:38PM +0200, Johan Hovold wrote:
> > > This is the third and hopefully last set of fixes for v3.7 this time
> > > around.
> > >
> > > Turns out
Am 25.10.2012 03:24, schrieb Ming Lei:
Lei, do you have any doc describing how to use those tracepoints?
Hi Bjorn Helgaas,
Firstly, please enable these tracepoints via below
echo 1 > /sys/kernel/debug/tracing/events/rpm/enable
then store the trace event result by below once you ma
On Thu, Oct 25, 2012 at 04:42:09PM +, Avner Flesch wrote:
> Hi,
>
> I have Freescale's MPC8308RDB board, and I would like to activate the USB as
> host and use it as Serial port.
How do you want to use it as a serial port? In what manner?
> I think I configured the kernel properly, and I w
Am 24.10.2012 23:13, schrieb Bjorn Helgaas:
On Wed, Oct 24, 2012 at 3:10 PM, Rafael J. Wysocki wrote:
It can be disabled by writing "on" to the controller's
/sys/devices/.../power/control file.
Ulrich, if you boot in the working situation and write "on" to the
control file as above, can you
Am 24.10.2012 22:18, schrieb Bjorn Helgaas:
On Tue, Oct 23, 2012 at 11:14 AM, Ulrich Eckhardt wrote:
Am 23.10.2012 01:40, schrieb Sarah Sharp:
On Sun, Oct 21, 2012 at 06:03:24PM +0200, Ulrich Eckhardt wrote:
I have tested it with Kernel 3.6.2. The USB3 port is the one built
in the Mainboard
Hi Alan,
Yes, I saw that too.
Acked-by: Benjamin Tissoires
On Thu, Oct 25, 2012 at 4:35 PM, Alan Cox wrote:
> From: Alan Cox
>
> Signed-off-by: Alan Cox
> ---
>
> drivers/hid/hid-multitouch.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-multito
On Thu, Oct 25, 2012 at 09:40:03AM -0700, Greg KH wrote:
> On Thu, Oct 25, 2012 at 03:42:38PM +0200, Johan Hovold wrote:
> > This is the third and hopefully last set of fixes for v3.7 this time around.
> >
> > Turns out that the three usb_wwan driver all allocated interface private
> > data
> > i
The private int_urb is never allocated so the submission from the
control completion handler will always fail. Remove this odd piece of
broken code.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mos7840.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/dri
Remove temporary do-while(0) loop used to keep changes minimal.
Fixup indentation, remove some line breaks, and replace break with goto
to maintain flow.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mos7840.c | 349 ---
1 file changed, 166 insertion
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that the inden
Remove private zombie flag used to signal disconnect and to prevent
control urb from being submitted from interrupt urb completion handler.
The control urb will not be re-submitted as both the control urb and the
interrupt urb is killed on disconnect.
Signed-off-by: Johan Hovold
---
drivers/usb
Sarah Sharp wrote:
> On Wed, Oct 24, 2012 at 12:52:18PM -0400, cov...@ccs.covici.com wrote:
> > Sebastian Andrzej Siewior wrote:
> >
> > > On Wed, Oct 24, 2012 at 11:13:51AM -0400, cov...@ccs.covici.com wrote:
> > > > I cannot post dmesg output befcause it starts spewing messages before
> > > >
On Wed, Oct 24, 2012 at 08:55:09PM +, David Binderman wrote:
>
>
> Hello there,
>
> The source code is from the subject line is
>
> static bool xhci_is_sync_in_ep(unsigned int ep_type)
> {
> return (ep_type == ISOC_IN_EP || ep_type != INT_IN_EP);
> }
>
> The static analyser cppcheck sa
On Thu, Oct 25, 2012 at 9:36 AM, Sarah Sharp
wrote:
> On Thu, Oct 25, 2012 at 12:31:09PM +0530, shashank chaturvedi wrote:
>> Hi sarah,
>> I am using Ubuntu 11.04 OS and NEC USB3.0 Host controller.
>> I want to write the PLS [8:5] field in the PORTSC register through C
>> program ,as
Hi,
I have Freescale's MPC8308RDB board, and I would like to activate the USB as
host and use it as Serial port.
I think I configured the kernel properly, and I would like the drivers to be
initialized (not hot module load)
I believe that should be in the .dts file.
I don't want to dive into USB
On Thu, Oct 25, 2012 at 01:49:58PM +0200, Johan Hovold wrote:
> The first two patches remove som legacy broken code, and the second two
> replaces attach and release with port_probe and remove so that port data is
> freed on relase after commit 0998d06310 ("device-core: Ensure drvdata = NULL
> when
On Thu, Oct 25, 2012 at 03:42:38PM +0200, Johan Hovold wrote:
> This is the third and hopefully last set of fixes for v3.7 this time around.
>
> Turns out that the three usb_wwan driver all allocated interface private data
> in probe rather than attach, which is a bug as that memory will not be fr
On Thu, Oct 25, 2012 at 10:28:58AM +0200, Johan Hovold wrote:
> Here's a resend of the fixes I've posted the last week. Against usb-linus of
> today d7870af7e2e3a9 ("usb-storage: add unusual_devs entry for Casio EX-N1
> digital camera").
All applied, thanks.
greg k-h
--
To unsubscribe from this l
On 10/25/2012 04:23 AM, Sebastian Andrzej Siewior wrote:
> On Wed, Oct 24, 2012 at 08:55:27AM -1000, Mitch Bradley wrote:
So by listing "usb-ehci" in its device ID table, a driver would
essentially be saying that it can handle _all_ USB EHCI controllers.
>>
>>
>> Actually, it means that
On Wed, Oct 24, 2012 at 12:52:18PM -0400, cov...@ccs.covici.com wrote:
> Sebastian Andrzej Siewior wrote:
>
> > On Wed, Oct 24, 2012 at 11:13:51AM -0400, cov...@ccs.covici.com wrote:
> > > I cannot post dmesg output befcause it starts spewing messages before
> > > any disk is mounted -- I have to
On Thu, Oct 25, 2012 at 12:31:09PM +0530, shashank chaturvedi wrote:
> Hi sarah,
> I am using Ubuntu 11.04 OS and NEC USB3.0 Host controller.
> I want to write the PLS [8:5] field in the PORTSC register through C
> program ,as per xhci spec first we have to write the LWS field
> I am d
Dear Alan,
thank you for your answer. I recorded the trace within the guest.
Tonight, I record it for the host too in order to see, if that change
happens.
Very best,
Stefan May
Am 25.10.2012 17:01, schrieb Alan Stern:
On Thu, 25 Oct 2012, Stefan May wrote:
Dear USB-Developers,
I am
On Thu, 25 Oct 2012, Stefan May wrote:
> Dear USB-Developers,
>
> I am having a strange Problem on Ubuntu Linux (11.10 and 12.04) using a
> thermal camera (Cypress FX2 chip) in isochronous mode. The transmission
> of data breaks with the error code -EPROTO. The curious thing is, that
> it runs
Hi Benoit,
On Thursday 25 October 2012 07:11 PM, Benoit Cousson wrote:
Hi Kishon,
On 10/15/2012 03:27 PM, Kishon Vijay Abraham I wrote:
Includes few minor fixes in dwc3-omap like populating the compatible
string in a correct way, extracting the utmi-mode property properly and
changing the inde
On Thu, 25 Oct 2012, Sebastian Andrzej Siewior wrote:
> On Wed, Oct 24, 2012 at 08:55:27AM -1000, Mitch Bradley wrote:
> > >> So by listing "usb-ehci" in its device ID table, a driver would
> > >> essentially be saying that it can handle _all_ USB EHCI controllers.
> >
> >
> > Actually, it mea
On Thu, 25 Oct 2012, Ankit wrote:
> Hi Alan,
>
> Thanks for your response.
>
> Yes, there is a handling of PRC bit in xhci-hub.c
>
> Our query is, at the time of XHCI initialization (inserting xhci-hcd.ko and
> no USB device is attached), is there PRC and CSC bits should be set?
>
> Our host c
From: Alan Cox
Signed-off-by: Alan Cox
---
drivers/hid/hid-multitouch.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 3eb02b9..c97011c 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-mult
On Thu, Oct 25, 2012 at 04:04:44PM +0200, Benoit Cousson wrote:
> On 10/15/2012 03:27 PM, Kishon Vijay Abraham I wrote:
> > Used of_platform_populate() to populate dwc3 core platform_device
> > from device tree data. Since now the allocation of unique device id is
> > handled by of_*, removed the c
On 10/15/2012 03:27 PM, Kishon Vijay Abraham I wrote:
> Used of_platform_populate() to populate dwc3 core platform_device
> from device tree data. Since now the allocation of unique device id is
> handled by of_*, removed the call to dwc3_get_device_id.
Just for my understanding: How are these dev
Move interface data allocation to attach so that it is deallocated
should usb-serial probe fail.
Note that the usb device id is stored at probe so that it can be used
in attach to determine send-setup blacklisting.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/option.c | 21 +++
This is the third and hopefully last set of fixes for v3.7 this time around.
Turns out that the three usb_wwan driver all allocated interface private data
in probe rather than attach, which is a bug as that memory will not be freed if
usb-serial probe fails (before the serial->attached flag is set
Move interface data allocation to attach so that it is deallocated
should usb-serial probe fail.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ipw.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/ipw.c b/drivers/usb/serial/ipw.c
index add45b7..42
Move interface data allocation to attach so that it is deallocated
should usb-serial probe fail.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/qcserial.c | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/serial/qcserial.c b/dri
Hi Kishon,
On 10/15/2012 03:27 PM, Kishon Vijay Abraham I wrote:
> Includes few minor fixes in dwc3-omap like populating the compatible
> string in a correct way, extracting the utmi-mode property properly and
> changing the index of get_irq since irq of core is removed from hwmod
> entry.
> Also
On Wed, Oct 24, 2012 at 7:24 PM, Ming Lei wrote:
> On Thu, Oct 25, 2012 at 5:31 AM, Rafael J. Wysocki wrote:
>
>>> I don't know how to use those. Is there a doc somewhere?
>>
>> I'm not sure, but let's ask the developer who added them.
>>
>> Lei, do you have any doc describing how to use those t
The private int_urb is never allocated so the submission from the
control completion handler will always fail. Remove this odd piece of
broken code.
---
drivers/usb/serial/mos7840.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/usb/serial/mos7840.c b/dr
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that the inden
Remove temporary do-while(0) loop used to keep changes minimal.
Fixup indentation, remove some line breaks, and replace break with goto
to maintain flow.
---
drivers/usb/serial/mos7840.c | 349 ---
1 file changed, 166 insertions(+), 183 deletions(-)
diff -
The first two patches remove som legacy broken code, and the second two
replaces attach and release with port_probe and remove so that port data is
freed on relase after commit 0998d06310 ("device-core: Ensure drvdata = NULL
when no driver is bound").
Applies to v3.7-rc2 with the following two fix
Remove private zombie flag used to signal disconnect and to prevent
control urb from being submitted from interrupt urb completion handler.
The control urb will not be re-submitted as both the control urb and the
interrupt urb is killed on disconnect.
---
drivers/usb/serial/mos7840.c | 13 +--
The driver set the usb-serial port pointers to NULL on errors in attach,
effectively preventing usb-serial core from decrementing the port ref
counters and releasing the port devices and associated data.
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mos7840.c | 1 -
1 file changed, 1 d
Here are two additional fixes for v3.7.
I'm sending the port-data fix and some cleanup as a separate RFC/RFT.
Johan Hovold (2):
USB: mos7840: fix urb leak at release
USB: mos7840: fix port-device leak in error path
drivers/usb/serial/mos7840.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
Make sure control urb is freed at release.
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mos7840.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index d6d4eec..35ad3f5 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/driv
Hi,
On Thu, Oct 25, 2012 at 10:19:19AM +, Grant Likely wrote:
> Felipe Balbi writes:
>
> >
> > we are compiling the driver always with full OTG
> > capabilities, so that board_mode trick becomes
> > useless.
> >
> > Signed-off-by: Felipe Balbi
>
> This patch breaks ti816x/am3894 support
Felipe Balbi writes:
>
> we are compiling the driver always with full OTG
> capabilities, so that board_mode trick becomes
> useless.
>
> Signed-off-by: Felipe Balbi
This patch breaks ti816x/am3894 support for the MUSB device because the
hardware
doesn't support OTG mode. The driver needs t
On Wed, Oct 24, 2012 at 08:55:27AM -1000, Mitch Bradley wrote:
> >> So by listing "usb-ehci" in its device ID table, a driver would
> >> essentially be saying that it can handle _all_ USB EHCI controllers.
>
>
> Actually, it means that the driver can handle at least USB EHCI
> controllers that
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note also that urb-
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that the oob p
Fix port-data memory leak in usb-serial probe error path by moving port
data allocation to port_probe.
Since commit a1028f0abf ("usb: usb_wwan: replace release and disconnect
with a port_remove hook") port data is deallocated in port_remove. This
leaves a possibility for memory leaks if usb-serial
Make sure no control urb is submitted during close after a disconnect by
checking the disconnected flag.
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/metro-usb.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/serial/metro-usb.c b/driver
Fix port-data memory leak by moving port data allocation to port_probe
and actually implementing deallocation.
Note that this driver has never even bothered to try to deallocate it's
port data...
Compile-only tested.
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 23
Make sure generic close is called at close.
The driver relies on the generic write implementation but did not call
generic close.
Note that the call to kill the read urb is not redundant, as mct_u232
uses an interrupt urb from the second port as the read urb and that
generic close therefore fails
Fix memory leak in attach error path where the read urb was never freed.
Cc: Bill Pemberton
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/quatech2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c
index 2cdfdcc..5adb742
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that this patc
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that this also
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that the fifth
Fix port-data memory leak by replacing attach and release with
port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Compile-only tested.
Cc:
Signed
Fix NULL-pointer dereference at release by moving port data allocation
and deallocation to port_probe and port_remove.
Fix NULL-pointer dereference at disconnect by stopping port urbs at
port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the por
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that the call
Move interface data allocation to attach so that it is deallocated on
errors in usb-serial probe.
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/sierra.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/seria
Make sure command buffer is deallocated in case of errors during attach.
Cc:
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/whiteheat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/whiteheat.c b/drivers/usb/serial/whiteheat.c
index 346c7ef..cfd155e 100644
---
Kill urbs unconditionally at close and disconnect.
Note that URB status is not valid outside of completion handler.
Cc:
Signed-off-by: Johan Hovold
---
drivers/usb/serial/quatech2.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/serial/quatech2.c b/driver
Fix port-data memory leak by moving port data allocation and
deallocation to port_probe and port_remove.
Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no
driver is bound) the port private data is no longer freed at release as
it is no longer accessible.
Note that the write
1 - 100 of 107 matches
Mail list logo
