As otg.h is containing lots of phy interface related
stuff, moving all phy interface related stuff to new
file named phy.h
Signed-off-by: Venu Byravarasu
---
delta from v1:
Removed notifier.h inclusion from otg.h, as it was
already included in phy.h
include/linux/usb/otg.h | 212 +
> -Original Message-
> From: Peter Chen [mailto:hzpeterc...@gmail.com]
> Sent: Wednesday, August 29, 2012 7:30 AM
> To: Venu Byravarasu
> Cc: gre...@linuxfoundation.org; ba...@ti.com; linux-
> ker...@vger.kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH] usb: otg: Move phy interf
> There are two ways: targetcli (userland package from linux-iscsi.org)
> or manual. With targetcli you should be able to setup "disk" device and
> add this to the gadget.
>
> This is part of a script I use for testing (the manual way):
>
> |modprobe dummy_hcd
> |modprobe target_core_mod
> |modprob
I am hitting a dead end at the rpm_resume function as opposed to
rpm_suspend in the commit ID specified.Below is a diff of the
file,wherein I have moved the wake_up_all() location,just above the
failure case (schedule()) and this solves the issue.I would like to
know if this is the right place to a
> -Original Message-
> From: Stephen Warren [mailto:swar...@wwwdotorg.org]
> Sent: Tuesday, August 28, 2012 7:37 PM
> To: Venu Byravarasu
> Cc: ccr...@android.com; o...@lixom.net; li...@arm.linux.org.uk;
> st...@rowland.harvard.edu; gre...@linuxfoundation.org; ba...@ti.com;
> linux-ker...@
On Tue, Aug 28, 2012 at 03:42:07PM +0200, Marc Kleine-Budde wrote:
> On 08/27/2012 12:36 PM, Marc Kleine-Budde wrote:
> [...]
>
> +return usb_add_phy(&mxs_phy->phy, USB_PHY_TYPE_USB2);
> >>> Why is it usb2? It's kind of USB_PHY_TYPE_DT.
> >>
> >> For now there is USB_PHY_T
On Tue, Aug 21, 2012 at 1:04 AM, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Differently from mx28 and mx6q, the mx23 SoC has the following description
> about ENHOSTDISCONDETECT bit in its Reference Manual:
>
> "Due to a on chip issue (Errata #2791), software must pay attention to when
> to a
On Tue, Aug 28, 2012 at 07:43:11PM +0530, ABRAHAM, KISHON VIJAY wrote:
> Hi,
>
> On Tue, Aug 28, 2012 at 7:11 PM, Marc Kleine-Budde
> wrote:
> > On 08/24/2012 08:46 AM, Richard Zhao wrote:
> > [...]
> >>> /**
> >>> + * devm_usb_get_phy_by_phandle - find the USB PHY by phandle
> >>> + * @dev - d
On Tue, Aug 28, 2012 at 04:51:51PM +0200, Michael Grzeschik wrote:
> Hi,
>
> On Tue, Aug 28, 2012 at 02:58:27PM +0800, Richard Zhao wrote:
> > i.MX usb controllers shares non-core registers, which may include
> > SoC specific controls. We take it as a usbmisc device and usbmisc
> > driver set oper
>
> #include
> +#include
>
one small thing: is only needed at phy.h.
> /* OTG defines lots of enumeration states before device reset */
> enum usb_otg_state {
> @@ -35,31 +36,6 @@ enum usb_otg_state {
> OTG_STATE_A_VBUS_ERR,
> };
>
> -enum usb_phy_events {
> - USB_EVENT_NONE,
This patch changes default value of maxburst to 1. When a connection is
established to highspeed, the maxburst is set to 0. So, we need to check and
change default value of the maxburst before setting up burst size of ep.
Signed-off-by: Chanho Park
Signed-off-by: Kyungmin Park
---
drivers/usb/d
Yo Alan!
On Tue, 28 Aug 2012 14:56:49 -0400 (EDT)
Alan Stern wrote:
> On Tue, 28 Aug 2012, Gary E. Miller wrote:
> > I am now getting a lot of these in my logs:
> > ehci_hcd :00:12.2: detected XactErr len 0/6 retry 28
> They mean that the computer was unable to communicate with a USB
> dev
Sebastian Andrzej Siewior writes:
> Signed-off-by: Sebastian Andrzej Siewior
Acked-by: Michal Nazarewicz
> diff --git a/include/linux/usb/composite.h b/include/linux/usb/composite.h
> index 367bbb6..35e8c87 100644
> --- a/include/linux/usb/composite.h
> +++ b/include/linux/usb/composite.h
> @@
Sebastian Andrzej Siewior writes:
> The index in usb_string array is defined by the gadget. The gadget can
> choose which index entry it assigns for the serial number and which the
> product name. The gadget has just to ensure that the descriptor contains
> the proper string id which is assigned b
Sebastian Andrzej Siewior writes:
> This patch moves the module options idVendor, idProduct and bcdDevice
> from composite.c into each gadgets. This ensures compatibility with
> current gadgets and removes the global variable which brings me step
> closer towards composite.c in libcomposite
>
> Si
The "Low Performance USB Block driver" has been removed which a user of
libusual. Now we have only the usb-storage driver as the only driver in
tree. This makes libusual needless.
This patch removes libusal, fixes up all users. The usual-table is now
linked into usb-storage.
usb_usual.h remains in
The index in usb_string array is defined by the gadget. The gadget can
choose which index entry it assigns for the serial number and which the
product name. The gadget has just to ensure that the descriptor contains
the proper string id which is assigned by composite.
If the composite layer knows t
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/composite.c | 16 +---
drivers/usb/gadget/printer.c |6 +-
include/linux/usb/composite.h |7 ++-
3 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/gadget/composite.c b/drive
This patch moves the module options idVendor, idProduct and bcdDevice
from composite.c into each gadgets. This ensures compatibility with
current gadgets and removes the global variable which brings me step
closer towards composite.c in libcomposite
Signed-off-by: Sebastian Andrzej Siewior
---
d
Hi Michał,
this is only a small part of the series, just the important piece so I
don't spam the whole list. This contains the reworked patches
- usb/gadget: push VID/PID/USB BCD module option into
- usb/gadget: make sure each gadget is using same i
*new*
- usb/gadgets: push iSerialNumber into
On Tue, 28 Aug 2012, Gary E. Miller wrote:
> Yo USB folks!
>
> I have the latest kernel 3.5.3. The xHCI patches seem to be helping, I'll
> report back later on that after more testing.
>
> I am now getting a lot of these in my logs:
>
> ehci_hcd :00:12.2: detected XactErr len 0/6 retry 28
Yo USB folks!
I have the latest kernel 3.5.3. The xHCI patches seem to be helping, I'll
report back later on that after more testing.
I am now getting a lot of these in my logs:
ehci_hcd :00:12.2: detected XactErr len 0/6 retry 28
ehci_hcd :00:12.2: detected XactErr len 0/6 retry 29
ehc
Hi,
On Tue, Aug 28, 2012 at 02:58:27PM +0800, Richard Zhao wrote:
> i.MX usb controllers shares non-core registers, which may include
> SoC specific controls. We take it as a usbmisc device and usbmisc
> driver set operations needed by ci13xxx_imx driver.
>
> For example, Sabrelite board has bad
On Tue, 28 Aug 2012, [ISO-8859-1] Bo Brant�n wrote:
>
> On a new computer only one of the USB connectors in the front of the
> chassi work, below is output from dmesg, and I would like to know if you
> have any advice if the fault is on the motherboard or in the cable and
> connector. The two
On Tue, 28 Aug 2012, megha dey wrote:
> In host mode,while continuously connecting and disconnecting a USB
> device,sometimes enumeration does not happen(kernel 3.0.31).We see
> that the hub_thread is blocked in the schedule() function.The
> following is the function trace:
...
> This happens in
Hi,
On Tue, Aug 28, 2012 at 7:11 PM, Marc Kleine-Budde wrote:
> On 08/24/2012 08:46 AM, Richard Zhao wrote:
> [...]
>>> /**
>>> + * devm_usb_get_phy_by_phandle - find the USB PHY by phandle
>>> + * @dev - device that requests this phy
>>> + * @phandle - name of the property holding the phy phand
Hi Felipe,
Any comments on this series?
On 22 August 2012 15:48, Sachin Kamat wrote:
> This patch series fixes several errors and warnings related to coding style
> and compilation in s3c2410_udc driver.
> It is compile tested using s3c2410_defconfig based on linux-next tree.
>
> Changes since v
On 08/28/2012 02:32 AM, Venu Byravarasu wrote:
> In order to keep up with the USB driver files organization,
> moving USB phy driver from mach-tegra to drivers/USB directory.
>
> Signed-off-by: Venu Byravarasu
> diff --git a/arch/arm/mach-tegra/devices.c b/arch/arm/mach-tegra/devices.c
> -struc
Hi,
On Tue, Aug 28, 2012 at 05:50:11PM +0530, Venu Byravarasu wrote:
> As otg.h is containing lots of phy interface related
> stuff, moving all phy interface related stuff to new
> file named phy.h
>
> Signed-off-by: Venu Byravarasu
this should be ok.. I'll apply it once v3.6-rc4 is out unless
Hello,
this is a series fixes several problems in the chipidea udc driver. this
applies to v3.6-rc3.
These patches have been tested on mx28, mx53 and mx6q.
Changes since v1:
- reworded patch description for "fix setup of endpoint maxpacket size"
- added Acked-by and Reviewed-by
- added "cleanup
This patch fixes the error path of udc_start(). Now NULL is used to
unset the peripheral with otg_set_peripheral().
Signed-off-by: Marc Kleine-Budde
Reviewed-by: Richard Zhao
---
drivers/usb/chipidea/udc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/chipid
From: Michael Grzeschik
This patch changes the setup of the endpoint maxpacket size. All non control
endpoints are initialized with an undefined ((unsigned short)~0) maxpacket
size. The maxpacket size of Endpoint 0 will be kept at CTRL_PAYLOAD_MAX.
Some gadget drivers check for the maxpacket siz
If udc_start() fails the qh_pool dma-pool cannot be closed because
it's still in use. This patch factors out the dma_pool_free() loop
into destroy_eps() and calls it in the error path of udc_start(),
too.
Cc: Richard Zhao
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/udc.c | 23 ++
From: Michael Grzeschik
Add function to physicaly enable or disable of pullup connection on the USB-D+
line. The uvc gaget will fail, if this function is not implemented.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
Acked-by: Felipe Balbi
---
drivers/usb/chipidea/udc.c |
From: Michael Grzeschik
When attaching an imx28 or imx53 in USB gadget mode to a Windows host and
starting a rndis connection we see this message every 4-10 seconds:
g_ether gadget: high speed config #2: RNDIS
Analysis shows that each time this message is printed, the rndis connection is
re
On 08/27/2012 12:36 PM, Marc Kleine-Budde wrote:
[...]
+return usb_add_phy(&mxs_phy->phy, USB_PHY_TYPE_USB2);
>>> Why is it usb2? It's kind of USB_PHY_TYPE_DT.
>>
>> For now there is USB_PHY_TYPE_USB2, USB_PHY_TYPE_USB3 and undefined. On
>> the one hand it's an USB2 ty
On 08/24/2012 08:46 AM, Richard Zhao wrote:
[...]
>> /**
>> + * devm_usb_get_phy_by_phandle - find the USB PHY by phandle
>> + * @dev - device that requests this phy
>> + * @phandle - name of the property holding the phy phandle value
>> + *
>> + * Returns the phy driver associated with the given
On Mon, Aug 27, 2012 at 04:33:05PM +0200, Michal Nazarewicz wrote:
> PS. It just struck me, is there a reason for
> USB_GADGET_COMPOSITE_OVERWRITE_OPTIONS to be a macro? It could be just
> an exported function. I'm thinking something along the lines of:
>
>
> struct usb_composite_overwrites {
>
Foxconn-branded Novatel E396, Gobi3k modem.
Cc: Dan Williams
Cc: Bjørn Mork
Cc: Ben Chan
Signed-off-by: Aleksander Morgado
---
drivers/net/usb/qmi_wwan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 328397c..189e52d 100644
-
> -Original Message-
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Tuesday, August 28, 2012 3:19 PM
> To: Venu Byravarasu
> Cc: ccr...@android.com; o...@lixom.net; swar...@wwwdotorg.org;
> li...@arm.linux.org.uk; st...@rowland.harvard.edu;
> gre...@linuxfoundation.org; ba...@ti.com; l
As otg.h is containing lots of phy interface related
stuff, moving all phy interface related stuff to new
file named phy.h
Signed-off-by: Venu Byravarasu
---
include/linux/usb/otg.h | 211 +
include/linux/usb/phy.h | 222 +
On Tue, Aug 28, 2012 at 12:52:19PM +0200, Marc Kleine-Budde wrote:
> On 08/28/2012 12:46 PM, Richard Zhao wrote:
> > On Tue, Aug 28, 2012 at 12:31:25PM +0200, Marc Kleine-Budde wrote:
> >> If udc_start() fails the qh_pool dma-pool cannot be closed because
> >> it's still in use. This patch factors
On 08/28/2012 12:46 PM, Richard Zhao wrote:
> On Tue, Aug 28, 2012 at 12:31:25PM +0200, Marc Kleine-Budde wrote:
>> If udc_start() fails the qh_pool dma-pool cannot be closed because
>> it's still in use. This patch factors out the dma_pool_free() loop
>> into destroy_eps() and calls it in the erro
On Tue, Aug 28, 2012 at 12:31:25PM +0200, Marc Kleine-Budde wrote:
> If udc_start() fails the qh_pool dma-pool cannot be closed because
> it's still in use. This patch factors out the dma_pool_free() loop
> into destroy_eps() and calls it in the error path of udc_start(),
> too.
>
> Cc: Richard Zh
If udc_start() fails the qh_pool dma-pool cannot be closed because
it's still in use. This patch factors out the dma_pool_free() loop
into destroy_eps() and calls it in the error path of udc_start(),
too.
Cc: Richard Zhao
Signed-off-by: Marc Kleine-Budde
---
Hello,
Richard, can you please inclu
On 08/27/2012 06:15 PM, Thomas Knauth wrote:
Hi Sebastian,
Hi Thomas,
today I came across your recent work to bring USB-attached-SCSI to the
USB gadget framework; at least this is how I would interpret it.
It brings USB Attached SCSI (UAS) and Bulk Only transport (BOT). The
latter is the sa
Hi,
On Tue, Aug 28, 2012 at 03:02:18PM +0530, Venu Byravarasu wrote:
> In order to keep up with the USB driver files organization,
> moving USB phy driver from mach-tegra to drivers/USB directory.
>
> Signed-off-by: Venu Byravarasu
> ---
> arch/arm/mach-tegra/Makefile |
In order to keep up with the USB driver files organization,
moving USB phy driver from mach-tegra to drivers/USB directory.
Signed-off-by: Venu Byravarasu
---
arch/arm/mach-tegra/Makefile |1 -
arch/arm/mach-tegra/devices.c |8 +---
arch/arm
On Tue, Aug 28, 2012 at 11:38:23AM +0300, Alexander Shishkin wrote:
> Richard Zhao writes:
>
> > One role failed, but the other role will possiblly still work.
> > For example, when udc start failed, if plug in a host device,
> > it works.
>
> If you're a host device, ci->role should be HOST at
On Tue, Aug 28, 2012 at 11:29:35AM +0300, Alexander Shishkin wrote:
> Richard Zhao writes:
>
> > States in gadget are not needed any more, set it to zero.
>
> It's generally a good practice to mention in the commit message what is
> it that you are fixing with this patch.
It fixes the following
Richard Zhao writes:
> One role failed, but the other role will possiblly still work.
> For example, when udc start failed, if plug in a host device,
> it works.
If you're a host device, ci->role should be HOST at this point and
ci_role_start() shouldn't fail. If ci->role is detected wrongly, th
Richard Zhao writes:
> States in gadget are not needed any more, set it to zero.
It's generally a good practice to mention in the commit message what is
it that you are fixing with this patch.
> Signed-off-by: Richard Zhao
> ---
> drivers/usb/chipidea/udc.c |1 +
> 1 file changed, 1 inser
- let role driver handle irq before ID change check. It give the
role driver a chance to handle disconnect.
- disable irq during switch role. No role driver to handle irq in
the period.
Signed-off-by: Richard Zhao
---
drivers/usb/chipidea/core.c | 21 +
1 file changed,
set_vbus_power is used to enable or disable vbus power for usb host.
[Marc Kleine-Budde : fix regulator unbalance disable]
Signed-off-by: Richard Zhao
---
drivers/usb/chipidea/ci13xxx_imx.c | 44 +---
drivers/usb/chipidea/host.c|8 +++
include/l
Signed-off-by: Richard Zhao
---
drivers/usb/chipidea/Makefile |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile
index 57e510f..d92ca32 100644
--- a/drivers/usb/chipidea/Makefile
+++ b/drivers/usb/chipidea/Makefile
@@ -1,3 +1,5 @
Signed-off-by: Richard Zhao
---
drivers/usb/chipidea/core.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 8fd390a..7485c84 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -4
Using vbus valid interrupt to detect vbus.
Signed-off-by: Richard Zhao
---
drivers/usb/chipidea/ci.h |1 +
drivers/usb/chipidea/udc.c | 39 ++-
2 files changed, 39 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipid
Signed-off-by: Richard Zhao
---
drivers/usb/otg/mxs-phy.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c
index c1a67cb..6a03e97 100644
--- a/drivers/usb/otg/mxs-phy.c
+++ b/drivers/usb/otg/mxs-phy.c
@@ -97,12 +97,
One role failed, but the other role will possiblly still work.
For example, when udc start failed, if plug in a host device,
it works.
Signed-off-by: Richard Zhao
---
drivers/usb/chipidea/core.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/chipidea/co
States in gadget are not needed any more, set it to zero.
Signed-off-by: Richard Zhao
---
drivers/usb/chipidea/udc.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index c7a032a..9fb6394 100644
--- a/drivers/usb/chipidea/udc.c
+++ b
OTGSC_IDIS must be cleared in irq handler to avoid re-queue the work.
Signed-off-by: Richard Zhao
---
drivers/usb/chipidea/core.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 3c3ed77..19ef324 100644
--- a
The ID pin needs 1ms debounce time, event at probe time. We delay 2ms
for safe.
Signed-off-by: Richard Zhao
---
drivers/usb/chipidea/core.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 1083585..3c3ed77 100644
--- a/drive
Some controllers may not need to setup pinctrl, so we don't fail the
probe if pinctrl get/select failed.
Signed-off-by: Richard Zhao
---
drivers/usb/chipidea/ci13xxx_imx.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/chipidea/ci13xxx_imx.c
b/drivers/usb/chipidea/ci1
The patch set is tested on imx6q_sabrelite board.
The patch can also be found at
https://github.com/riczhao/kernel-imx/commits/topics/usb-driver
For test which merged platform patches:
https://github.com/riczhao/kernel-imx/commits/topics/usb-test
Changes since v1:
- move usbmisc as the other pa
64 matches
Mail list logo
