[PATCH v6 2/3] ARM: imx6q: clk_register_clkdev usbmisc clock

2012-08-27 Thread Richard Zhao
Signed-off-by: Richard Zhao Acked-by: Sascha Hauer --- arch/arm/mach-imx/clk-imx6q.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c index ea89520..660fcbb 100644 --- a/arch/arm/mach-imx/clk-imx6q.c +++ b/arch/arm/mach-imx/clk-

[PATCH v6 3/3] ARM: dts: imx6q-sabrelite: add usbmisc device

2012-08-27 Thread Richard Zhao
- add usbmisc device - set property fsl,usbmisc for usb controllers - set disable-over-current for imx6q-sabrelite usb otg Signed-off-by: Richard Zhao Acked-by: Sascha Hauer --- arch/arm/boot/dts/imx6q-sabrelite.dts |1 + arch/arm/boot/dts/imx6q.dtsi | 10 ++ 2 files chan

[PATCH v6 1/3] USB: chipidea: add imx usbmisc support

2012-08-27 Thread Richard Zhao
i.MX usb controllers shares non-core registers, which may include SoC specific controls. We take it as a usbmisc device and usbmisc driver set operations needed by ci13xxx_imx driver. For example, Sabrelite board has bad over-current design, we can usbmisc to disable over-current detect. Signed-o

[PATCH v6 0/3] imx: add usbmisc support

2012-08-27 Thread Richard Zhao
usbmisc driver handles the SoC specific non-core usb registers. Changes since last version: goto err when usbmisc_ops->init failed rather than return directly. Richard Zhao (3): USB: chipidea: add imx usbmisc support ARM: imx6q: clk_register_clkdev usbmisc clock ARM: dts: imx6q-sabrelite:

Re: USB device fails to enumerate after multiple connect and disconnect in host mode

2012-08-27 Thread megha dey
I have a setup with the older kernel3.0.31,and was hoping to get some suggestion or direction towards resolving this issue on that particular kernel. On Tue, Aug 28, 2012 at 11:21 AM, Greg KH wrote: > On Tue, Aug 28, 2012 at 11:10:45AM +0530, megha dey wrote: >> In host mode,while continuously co

Re: SECURITY ERASE UNIT gets IDNF instead of ABRT?

2012-08-27 Thread Norman Diamond
Sorry. I'll try to post it to the correct mailing list this time. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

SECURITY ERASE UNIT gets IDNF instead of ABRT?

2012-08-27 Thread Norman Diamond
If I understand the standard correctly, if SECURITY ERASE UNIT fails to erase a bad block then the result should have the ABRT bit set. There are some kinds of operations where a drive might set IDNF instead of ABRT, but if I understand correctly, SECURITY ERASE UNIT is not one of them. In one

Re: USB device fails to enumerate after multiple connect and disconnect in host mode

2012-08-27 Thread Greg KH
On Tue, Aug 28, 2012 at 11:10:45AM +0530, megha dey wrote: > In host mode,while continuously connecting and disconnecting a USB > device,sometimes enumeration does not happen(kernel 3.0.31).We see > that the hub_thread is blocked in the schedule() function.The > following is the function trace: >

USB device fails to enumerate after multiple connect and disconnect in host mode

2012-08-27 Thread megha dey
In host mode,while continuously connecting and disconnecting a USB device,sometimes enumeration does not happen(kernel 3.0.31).We see that the hub_thread is blocked in the schedule() function.The following is the function trace: [ 34.859924] taskPC stack pid father [ 34.865

Re: [PATCH] usb: chipidea: ci13xxx_imx: fix regulator unbalance disable

2012-08-27 Thread Richard Zhao
Hi Marc, Thanks. I'll merge the fix when I send out my v4 patch. Thanks Richard On Mon, Aug 27, 2012 at 09:56:06PM +0200, Marc Kleine-Budde wrote: > This patch applies to Richard's tree at > https://github.com/riczhao/kernel-imx/commits/topics/usb-driver. It fixes an > issue introduced with commi

Re: chipidea driver

2012-08-27 Thread Richard Zhao
On Fri, Aug 24, 2012 at 10:34:37AM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > On Thu, Aug 23, 2012 at 06:57:03PM +0200, Marc Kleine-Budde wrote: > >> Hello, > > Hi, > > >> Michael and I have a bunch of updates and improvement for the chipidea > >> driver. They apply to Richar

advice on hardware error

2012-08-27 Thread Bo Brantén
On a new computer only one of the USB connectors in the front of the chassi work, below is output from dmesg, and I would like to know if you have any advice if the fault is on the motherboard or in the cable and connector. The two USB ports uses the same cable and the same connector to the m

Re: [PATCH V4] usb: gadget: bcm63xx UDC driver

2012-08-27 Thread Kevin Cernekee
On Mon, Aug 27, 2012 at 1:46 PM, Sebastian Andrzej Siewior > One little question: Felipe suggested to replace the workqueue by a threaded > interrupt. You schedule the workqueue in interrupt context and once in ep0 > enqueue. The enqueue should be fine by executing one round and waiting for the > i

Re: [PATCH V4] usb: gadget: bcm63xx UDC driver

2012-08-27 Thread Sebastian Andrzej Siewior
On Sat, Aug 25, 2012 at 12:38:52PM -0700, Kevin Cernekee wrote: > Driver for the "USB20D" / "USBD" block on BCM6328, BCM6368, BCM6816, > BCM6362, BCM3383, and others. I don't see anything worth to object. Acked-by: Sebastian Andrzej Siewior One little question: Felipe suggested to replace the wo

[PATCH] usb: chipidea: ci13xxx_imx: fix regulator unbalance disable

2012-08-27 Thread Marc Kleine-Budde
This patch applies to Richard's tree at https://github.com/riczhao/kernel-imx/commits/topics/usb-driver. It fixes an issue introduced with commit: acfc0b8 USB: chipidea: add set_vbus_power support That commit switches form a permanent vbus enable to set_vbus_power(), the permanent regulator_e

Re: [Patch v2] block: remove the deprecated ub driver

2012-08-27 Thread Pete Zaitcev
On Sun, 26 Aug 2012 14:12:17 -0700 Greg Kroah-Hartman wrote: > > Unless you have other plans, I would take this and send it you together > > with the > > removal of libusual as you asked. > > Why not just send a follow-on patch to do the libusual fixups instead? Sending it in one go seems more

Re: Virtualbox/Vmware usb device is working but on installed linux not.

2012-08-27 Thread adam ?
Thanks! I will soon check if it wokrs. And I will test another device with linux(maybe my device is damaged, but on windows and as i wrote on vmware/vritualbox linux works). Thanks for help. Dnia 26-08-2012 o godz. 17:08 Alan Stern napisał(a): > Please use Reply-To-All so that your messages go t

Re: [RFC PATCH 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

2012-08-27 Thread Lan Tianyu
于 2012/8/27 22:20, Alan Stern 写道: On Mon, 27 Aug 2012, Lan Tianyu wrote: Now I see the problem. The code you're adding to ehci-hub.c relies on the hub driver knowing about the root hub's ports beforehand. So you've got a circular dependency: ehci-hub.c depends on the hub driver knowi

Re: [PATCH] usbhid: add NOGET quirk for Eaton Ellipse MAX UPS

2012-08-27 Thread Jiri Kosina
On Thu, 23 Aug 2012, Alan Stern wrote: > This patch (as1603) adds a NOGET quirk for the Eaton Ellipse MAX UPS > device. (The USB IDs were already present in hid-ids.h, apparently > under a different name.) > > Signed-off-by: Alan Stern > Reported-by: Laurent Bigonville > CC: Applied, thank y

Re: [PATCH 14/20] usb/gadget: push iSerialNumber into gadgets

2012-08-27 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > On 08/27/2012 03:51 PM, Michal Nazarewicz wrote: >>> And how do you achieve the "" initialization? This macro is >>> evaluated after the id has been assigned. >> Ah, right, I've forgotten that usb_string_ids_tab iterates till it finds >> a NULL pointer. > not

Re: [PATCH 4/6] drivers/usb/host/ohci-nxp.c: adjust inconsistent IS_ERR and PTR_ERR

2012-08-27 Thread Alan Stern
On Sat, 25 Aug 2012, Julia Lawall wrote: > From: Julia Lawall > > Change the call to PTR_ERR to access the value just tested by IS_ERR. > Signed-off-by: Julia Lawall > > --- > drivers/usb/host/ohci-nxp.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb

Re: [PATCH 15/20] usb/gadget: push iManufacturer into gadgets

2012-08-27 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > On 08/25/2012 12:11 AM, Michal Nazarewicz wrote: >> Sebastian Andrzej Siewior writes: >>> This patch pushes the iManufacturer module argument from composite into >>> each gadget. Once the user uses the module paramter, the string is >>> overwritten with the f

Re: [RFC PATCH 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

2012-08-27 Thread Alan Stern
On Mon, 27 Aug 2012, Lan Tianyu wrote: > > Now I see the problem. The code you're adding to ehci-hub.c relies on > > the hub driver knowing about the root hub's ports beforehand. So > > you've got a circular dependency: > > > > ehci-hub.c depends on the hub driver knowing about the > >

Re: Potential fsg->state problem at file_storage.c

2012-08-27 Thread Alan Stern
On Mon, 27 Aug 2012, Felipe Balbi wrote: > On Sat, Aug 25, 2012 at 07:44:09PM +0200, Sebastian Andrzej Siewior wrote: > > On Sat, Aug 25, 2012 at 10:35:34AM -0400, Alan Stern wrote: > > > For safety's sake, it would be a good idea to flush the dirty pages > > > when a disconnect occurs. > > > >

Re: [PATCH 14/20] usb/gadget: push iSerialNumber into gadgets

2012-08-27 Thread Sebastian Andrzej Siewior
On 08/27/2012 03:51 PM, Michal Nazarewicz wrote: And how do you achieve the "" initialization? This macro is evaluated after the id has been assigned. Ah, right, I've forgotten that usb_string_ids_tab iterates till it finds a NULL pointer. not only usb_string_ids_tab iterates() but also the l

Re: how important is usb_gadget_controller_number() (WAS: Re: [PATCH 13/20] usb/gadget: move usb_gadget_controller_number() into a .c file and libcomposite)

2012-08-27 Thread Sebastian Andrzej Siewior
On 08/27/2012 03:50 PM, Felipe Balbi wrote: yeah, but that doesn't get changed anyway. When you ship a cellphone you want your iManufacturer to read as "My Awesome Company, inc." and not "dwc3 running on Linux v3.5-rc4-dirty-ga05832scg" or whatever :-p You forgot the number of patches on top of

Re: how important is usb_gadget_controller_number() (WAS: Re: [PATCH 13/20] usb/gadget: move usb_gadget_controller_number() into a .c file and libcomposite)

2012-08-27 Thread Felipe Balbi
On Mon, Aug 27, 2012 at 03:52:46PM +0200, Sebastian Andrzej Siewior wrote: > On 08/27/2012 03:43 PM, Felipe Balbi wrote: > >>>Using here something like 0x305 for kernel version 3.5 would be a > >>>little more useful. We would know that the kernel on this device is > >>>based on v3.5 (pl

Re: how important is usb_gadget_controller_number() (WAS: Re: [PATCH 13/20] usb/gadget: move usb_gadget_controller_number() into a .c file and libcomposite)

2012-08-27 Thread Sebastian Andrzej Siewior
On 08/27/2012 03:43 PM, Felipe Balbi wrote: Using here something like 0x305 for kernel version 3.5 would be a little more useful. We would know that the kernel on this device is based on v3.5 (plus a big number of patches on top). Worth noting that version is also included in the de

Re: [PATCH 14/20] usb/gadget: push iSerialNumber into gadgets

2012-08-27 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > On 08/25/2012 12:07 AM, Michal Nazarewicz wrote: >>> --- a/drivers/usb/gadget/acm_ms.c >>> +++ b/drivers/usb/gadget/acm_ms.c >>> @@ -92,12 +92,14 @@ static const struct usb_descriptor_header *otg_desc[] = >>> { >>> >>> #define STRING_MANUFACTURER_IDX

Re: how important is usb_gadget_controller_number() (WAS: Re: [PATCH 13/20] usb/gadget: move usb_gadget_controller_number() into a .c file and libcomposite)

2012-08-27 Thread Felipe Balbi
On Mon, Aug 27, 2012 at 03:34:21PM +0200, Michal Nazarewicz wrote: > > Sebastian Andrzej Siewior writes: > > > On 08/24/2012 11:53 PM, Michal Nazarewicz wrote: > >> I wouldn't duplicate the documentation. One in header file should be > >> enough. > > > > I think I go for the .c file where this

Re: [PATCH] usb: dwc3: memory ordering fix in close

2012-08-27 Thread Oliver Neukum
On Monday 27 August 2012 10:10:37 Sebastian Andrzej Siewior wrote: > On 08/26/2012 09:34 PM, oli...@neukum.org wrote: > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > index c34452a..dcc10ac 100644 > > --- a/drivers/usb/dwc3/core.c > > +++ b/drivers/usb/dwc3/core.c > > @@ -99,6

Re: how important is usb_gadget_controller_number() (WAS: Re: [PATCH 13/20] usb/gadget: move usb_gadget_controller_number() into a .c file and libcomposite)

2012-08-27 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > On 08/24/2012 11:53 PM, Michal Nazarewicz wrote: >> I wouldn't duplicate the documentation. One in header file should be >> enough. > > I think I go for the .c file where this is implemented. If you change > the .c file most people don't care about the header

Re: [PATCH 09/20] usb/gadget: push VID/PID/USB BCD module option into gadgets

2012-08-27 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > On 08/24/2012 11:34 PM, Michal Nazarewicz wrote: >>> diff --git a/drivers/usb/gadget/audio.c b/drivers/usb/gadget/audio.c >>> index 689d142..a9c687a 100644 >>> --- a/drivers/usb/gadget/audio.c >>> +++ b/drivers/usb/gadget/audio.c >>> @@ -13,6 +13,7 @@ >>> >>>

Re: [BUG] - USB3 bluetooth device not working properly?

2012-08-27 Thread Miroslav Sabljic
On 08/22/2012 05:39 PM, Miroslav Sabljic wrote: If the device is working properly on boot up and fails after suspend/resume, you can try the patch attached to see if it helps on the failure after system resume. Unfortunately it look like it doesn't change anything. Patched, rebuilt, installed

Re: [PATCH] usb/dwc3: Fix Pedning isoc

2012-08-27 Thread Pratyush Anand
On 8/27/2012 5:30 PM, Sergei Shtylyov wrote: Hello. On 25-08-2012 6:54, Pratyush Anand wrote: There are several typos here and there... First, s/Pedning/pending/ in the subject. Ohh.. I will correct all these while sending V2. I am doing some more test with other gadgets and then wi

Re: [PATCH] usb/dwc3: Fix Pedning isoc

2012-08-27 Thread Sergei Shtylyov
Hello. On 25-08-2012 6:54, Pratyush Anand wrote: There are several typos here and there... First, s/Pedning/pending/ in the subject. If xfernotready is received and there is no request in request_list then PENDING flag must be set, so that next request in ep queue is executed. In case

Re: [PATCH 15/20] usb/gadget: push iManufacturer into gadgets

2012-08-27 Thread Sebastian Andrzej Siewior
On 08/25/2012 12:11 AM, Michal Nazarewicz wrote: Sebastian Andrzej Siewior writes: This patch pushes the iManufacturer module argument from composite into each gadget. Once the user uses the module paramter, the string is overwritten with the final value. Why to remove the generation of the s

Re: [PATCH 14/20] usb/gadget: push iSerialNumber into gadgets

2012-08-27 Thread Sebastian Andrzej Siewior
On 08/25/2012 12:07 AM, Michal Nazarewicz wrote: --- a/drivers/usb/gadget/acm_ms.c +++ b/drivers/usb/gadget/acm_ms.c @@ -92,12 +92,14 @@ static const struct usb_descriptor_header *otg_desc[] = { #define STRING_MANUFACTURER_IDX 0 #define STRING_PRODUCT_IDX1 +#define

how important is usb_gadget_controller_number() (WAS: Re: [PATCH 13/20] usb/gadget: move usb_gadget_controller_number() into a .c file and libcomposite)

2012-08-27 Thread Sebastian Andrzej Siewior
On 08/24/2012 11:53 PM, Michal Nazarewicz wrote: I wouldn't duplicate the documentation. One in header file should be enough. I think I go for the .c file where this is implemented. If you change the .c file most people don't care about the header file. +int usb_gadget_controller_number(stru

Re: [PATCH 3/3] usb: mxs-phy: register phy as USB_PHY_TYPE_USB2

2012-08-27 Thread Marc Kleine-Budde
On 08/27/2012 12:27 PM, Richard Zhao wrote: > On Mon, Aug 27, 2012 at 03:01:43PM +0530, ABRAHAM, KISHON VIJAY wrote: >> Hi, >> >> On Mon, Aug 27, 2012 at 12:55 PM, Richard Zhao >> wrote: >>> On Mon, Aug 27, 2012 at 11:04:58AM +0530, ABRAHAM, KISHON VIJAY wrote: Hi, On Sat, Aug 25, 2

Re: [PATCH 3/3] usb: mxs-phy: register phy as USB_PHY_TYPE_USB2

2012-08-27 Thread Richard Zhao
On Mon, Aug 27, 2012 at 03:01:43PM +0530, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Mon, Aug 27, 2012 at 12:55 PM, Richard Zhao > wrote: > > On Mon, Aug 27, 2012 at 11:04:58AM +0530, ABRAHAM, KISHON VIJAY wrote: > >> Hi, > >> > >> On Sat, Aug 25, 2012 at 3:33 PM, Marc Kleine-Budde > >> wrote: >

Re: [PATCH 09/20] usb/gadget: push VID/PID/USB BCD module option into gadgets

2012-08-27 Thread Sebastian Andrzej Siewior
On 08/24/2012 11:34 PM, Michal Nazarewicz wrote: diff --git a/drivers/usb/gadget/audio.c b/drivers/usb/gadget/audio.c index 689d142..a9c687a 100644 --- a/drivers/usb/gadget/audio.c +++ b/drivers/usb/gadget/audio.c @@ -13,6 +13,7 @@ #include #include +#include Why is this needed in this pat

Re: [PATCH 05/20] staging/ccg: make composite.c function static and remove unsused

2012-08-27 Thread Sebastian Andrzej Siewior
On 08/24/2012 10:58 PM, Michal Nazarewicz wrote: Sebastian Andrzej Siewior writes: The next step is to move composite.c into the library. Since the Android gadget has its composite.c copy Silly question, what branch is the patchset based on? I checkout Linus's last rc tree, merged Greg's fi

Re: [PATCH 3/3] usb: mxs-phy: register phy as USB_PHY_TYPE_USB2

2012-08-27 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Aug 27, 2012 at 12:55 PM, Richard Zhao wrote: > On Mon, Aug 27, 2012 at 11:04:58AM +0530, ABRAHAM, KISHON VIJAY wrote: >> Hi, >> >> On Sat, Aug 25, 2012 at 3:33 PM, Marc Kleine-Budde >> wrote: >> > On 08/24/2012 08:51 AM, Richard Zhao wrote: >> >> On Thu, Aug 23, 2012 at 07:22:54PM

Re: [PATCH] usb: dwc3: memory ordering fix in close

2012-08-27 Thread Sebastian Andrzej Siewior
On 08/26/2012 09:34 PM, oli...@neukum.org wrote: diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index c34452a..dcc10ac 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -99,6 +99,7 @@ void dwc3_put_device_id(int id) ret = test_bit(id, dwc3_devs);

Re: Potential fsg->state problem at file_storage.c

2012-08-27 Thread Felipe Balbi
On Sat, Aug 25, 2012 at 07:44:09PM +0200, Sebastian Andrzej Siewior wrote: > On Sat, Aug 25, 2012 at 10:35:34AM -0400, Alan Stern wrote: > > For safety's sake, it would be a good idea to flush the dirty pages > > when a disconnect occurs. > > It does not look like there is an API for this (yet).

Re: [PATCH 3/3] usb: mxs-phy: register phy as USB_PHY_TYPE_USB2

2012-08-27 Thread Richard Zhao
On Mon, Aug 27, 2012 at 11:04:58AM +0530, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Sat, Aug 25, 2012 at 3:33 PM, Marc Kleine-Budde > wrote: > > On 08/24/2012 08:51 AM, Richard Zhao wrote: > >> On Thu, Aug 23, 2012 at 07:22:54PM +0200, Marc Kleine-Budde wrote: > >>> This patch registers the msx-

[RFT] testers for CDC-EEM devices wanted

2012-08-27 Thread Oliver Neukum
Hi, I am looking for people who have a cdc-eem device that emits power management hints and would be willig to test this patch. Regards Oliver >From 499bcc977f13b899cd49a6474843ed3c9086cc0b Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Sun, 26 Aug 2012 17:12:06 +020

[PATCH] USB: cp210x: remove useless set memory to zero use memset()

2012-08-27 Thread Wei Yongjun
From: Wei Yongjun The memory return by kzalloc() or kmem_cache_zalloc() has already be set to zero, so remove useless memset(0). spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun --- drivers/usb/serial/cp210x.c | 1 - 1 file ch

Re: [RFC PATCH 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

2012-08-27 Thread Lan Tianyu
On 2012年08月27日 14:57, Lan Tianyu wrote: > On 2012年08月27日 03:18, Alan Stern wrote: >> On Sun, 26 Aug 2012, Lan Tianyu wrote: >> >>> �� 2012/8/24 22:45, Alan Stern д��: On Fri, 24 Aug 2012, Lan Tianyu wrote: >>> But if other places got hub descriptor, they can't get DeviceRemovable