Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-26 Thread Guenter Roeck
On Tue, Jun 06, 2023 at 09:39:25AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- $ git grep cdrom_release Documentation/cdrom/cdrom-standard.rst: cdrom_release, /* release */ Documentation/cdrom/cdrom-standard.rst:the door, should be left over to the

Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-08 Thread Phillip Potter
On Thu, Jun 08, 2023 at 11:04:44AM +0200, Christoph Hellwig wrote: > On Thu, Jun 08, 2023 at 09:47:27AM +0100, Phillip Potter wrote: > > Yes indeed - I was under the impression it was appropriate for a > > maintainer to signal their approval of a patch to maintained code using > > a Signed-off-by t

Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-08 Thread Christoph Hellwig
On Thu, Jun 08, 2023 at 09:47:27AM +0100, Phillip Potter wrote: > Yes indeed - I was under the impression it was appropriate for a > maintainer to signal their approval of a patch to maintained code using > a Signed-off-by tag due to their involvement in the submission process? > Apologies if I've

Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-08 Thread Phillip Potter
On Thu, Jun 08, 2023 at 10:41:29AM +0200, Christoph Hellwig wrote: > On Wed, Jun 07, 2023 at 12:00:57AM +0100, Phillip Potter wrote: > > Looks good, thanks. > > > > Signed-off-by: Phillip Potter > > Hmm, these signoffs don't really make sense here. Were they intended > as Reviewed-bys? > Hi Ch

Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-08 Thread Christoph Hellwig
On Wed, Jun 07, 2023 at 12:00:57AM +0100, Phillip Potter wrote: > Looks good, thanks. > > Signed-off-by: Phillip Potter Hmm, these signoffs don't really make sense here. Were they intended as Reviewed-bys? ___ linux-um mailing list linux-um@lists.in

Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-07 Thread Hannes Reinecke
On 6/6/23 09:39, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig --- drivers/cdrom/cdrom.c | 2 +- drivers/cdrom/gdrom.c | 2 +- drivers/scsi/sr.c | 2 +- include/linux/cdrom.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Hannes Reinecke Cheers,

Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:25AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinf

Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-06 Thread Phillip Potter
On Tue, Jun 06, 2023 at 09:39:25AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > drivers/cdrom/cdrom.c | 2 +- > drivers/cdrom/gdrom.c | 2 +- > drivers/scsi/sr.c | 2 +- > include/linux/cdrom.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff

[PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

2023-06-06 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- drivers/cdrom/cdrom.c | 2 +- drivers/cdrom/gdrom.c | 2 +- drivers/scsi/sr.c | 2 +- include/linux/cdrom.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index adebac1bd210d9..998b03fe9