[GIT PULL] UML fixes for v6.14-rc3

2025-02-15 Thread Richard Weinberger
Linus, The following changes since commit a64dcfb451e254085a7daee5fe51bf22959d52d3: Linux 6.14-rc2 (2025-02-09 12:45:03 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git tags/uml-for-linus-6.14-rc3 for you to fetch changes up to 961

[GIT PULL] UML changes for v6.14

2025-01-30 Thread Richard Weinberger
Linus, The following changes since commit fc033cf25e612e840e545f8d5ad2edd6ba613ed5: Linux 6.13-rc5 (2024-12-29 13:15:45 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git tags/uml-for-linus-6.14-rc1 for you to fetch changes up to 2d2

Re: [PATCH] hostfs: fix string handling in __dentry_name()

2025-01-19 Thread Richard Weinberger
2 "hostfs: Remove open coded strcpy()" Hmm, AFAICT the open coded strcpy() was also never safe wrt. overlapping strings. Beside of that: Acked-by: Richard Weinberger Thanks, //richard

[GIT PULL] UML changes for v6.13-rc1

2024-11-29 Thread Richard Weinberger
Linus, The following changes since commit 8cf0b93919e13d1e8d4466eb4080a4c4d9d66d7b: Linux 6.12-rc2 (2024-10-06 15:32:27 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git tags/uml-for-linus-6.13-rc1 for you to fetch changes up to bed

[GIT PULL] UML updates for v6.12-rc1

2024-09-27 Thread Richard Weinberger
Linus, The following changes since commit 431c1646e1f86b949fa3685efc50b660a364c2b6: Linux 6.11-rc6 (2024-09-01 19:46:02 +1200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git tags/uml-for-linus-6.12-rc1 for you to fetch changes up to 381

Re: [PATCH] um: add RCU syscall hack for time-travel

2024-09-13 Thread Richard Weinberger
fferently. > > So now I am wondering if I can come up with a hack that works for both. Ok! > On Fri, 2024-09-13 at 13:47 +0200, Richard Weinberger wrote: >> - Ursprüngliche Mail - >> > Von: "Benjamin Berg" >> > > While I acknowledge that

Re: [PATCH] um: add RCU syscall hack for time-travel

2024-09-13 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Benjamin Berg" >> While I acknowledge that time-travel itself is a beautiful hack, I'd >> like to keep the hacks >> to keep it working minimal. >> So, the problem here is that RCU callbacks never run and just pile up? > > Yes. A simple example of this is doi

Re: [PATCH -next] hostfs: Convert hostfs_writepage to use folio

2024-09-12 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Matthew Wilcox" >> > - buffer = kmap_local_page(page); >> > + buffer = kmap_local_folio(folio, 0); > > These two lines assume that hostfs remains a non-large-folio filesystem. > I'm not sure what the plans are for hostfs. Somewhere deep on my TODO are pla

Re: [PATCH] um: add RCU syscall hack for time-travel

2024-09-12 Thread Richard Weinberger
On Fri, Aug 30, 2024 at 5:38 PM Benjamin Berg wrote: > > From: Benjamin Berg > > In time-travel mode userspace can do a lot of work without any time > passing. Unfortunately, this can result in OOM situations as the RCU > core code will never be run. > > Work around that by kicking the RCU using

Re: [PATCH] um: Fix the return value of elf_core_copy_task_fpregs

2024-09-12 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Tiwei Bie" > An: "richard" , "anton ivanov" > , "Johannes Berg" > > CC: "linux-um" , "linux-kernel" > , "Tiwei Bie" > > Gesendet: Mittwoch, 28. August 2024 15:51:40 > Betreff: [PATCH] um: Fix the return value of elf_core_copy_task_fpregs > This function

Re: [PATCH -next] hostfs: Convert hostfs_writepage to use folio

2024-09-12 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Li Zetao" > An: "richard" , "anton ivanov" > , "Johannes Berg" > > CC: lizet...@huawei.com, "linux-um" , > "linux-kernel" > Gesendet: Dienstag, 20. August 2024 04:50:45 > Betreff: [PATCH -next] hostfs: Convert hostfs_writepage to use folio > convert to u

[GIT PULL] UML Changes for v6.11-rc1

2024-07-24 Thread Richard Weinberger
Linus, The following changes since commit 22a40d14b572deb80c0648557f4bd502d7e83826: Linux 6.10-rc6 (2024-06-30 14:40:44 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git tags/uml-for-linus-6.11-rc1 for you to fetch changes up to 98f

Re: [PATCH] arch: um: rust: Use the generated target.json again

2024-06-13 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Miguel Ojeda" >> Fixes: f82811e22b48 ("rust: Refactor the build target to allow the use of >> builtin targets") >> Signed-off-by: David Gow > > I guess this should go through UML, but please let me know otherwise Yeah, that's the plan. > Tested-by: Miguel

Re: [PATCH] hostfs: Add const qualifier to host_root in hostfs_fill_super()

2024-06-11 Thread Richard Weinberger
*host_root = fc->source; >| ^~ > > Add the 'const' qualifier, as host_root will not be modified after its > assignment. Move the assignment to keep the existing reverse Christmas > tree order intact. > > Fixes: cd140ce9f611 ("hostfs: convert hostfs to use the new mount API") > Signed-off-by: Nathan Chancellor Acked-by: Richard Weinberger Thanks, //richard

[GIT PULL] UML changes for v6.10-rc1

2024-05-24 Thread Richard Weinberger
Linus, The following changes since commit ed30a4a51bb196781c8058073ea720133a65596f: Linux 6.9-rc5 (2024-04-21 12:35:54 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git tags/uml-for-linus-6.10-rc1 for you to fetch changes up to 919e

Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

2024-05-20 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "hch" > An: "Dr. David Alan Gilbert" > CC: "hch" , "richard" , "linux-um" > , "linux-kernel" > > Gesendet: Montag, 20. Mai 2024 17:20:49 > Betreff: Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex' > On Mon, May 20, 2024 at 03:12:20PM +, Dr. David Alan

Re: [PATCH 0/2] um: Convert to platform remove callback returning void

2024-04-30 Thread Richard Weinberger
Uwe, - Ursprüngliche Mail - > Von: "Uwe Kleine-König" > An: "richard" , "anton ivanov" > , "Johannes Berg" > > CC: "linux-um" , "kernel" > > Gesendet: Montag, 29. April 2024 09:35:49 > Betreff: Re: [PATCH 0/2] um: Convert to platform remove callback returning > void > Hello Richard,

Re: [PATCH] um: Add winch to winch_handlers before registering winch IRQ

2024-04-23 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Roberto Sassu" > An: "Johannes Berg" , "richard" , > "anton ivanov" > > CC: "linux-kernel" , "linux-um" > , "Roberto Sassu" > > Gesendet: Dienstag, 23. April 2024 09:22:31 > Betreff: Re: [PATCH] um: Add winch to winch_handlers before registering winch >

Re: [PATCH 1/1] arch/um: fix forward declaration for vmalloc

2024-04-22 Thread Richard Weinberger
5633bda1e5b7844478dd13b4326a3d5d09 now. I think Andrew placed > this fix right after the change it fixes with intention to merge them > together later on. Ah, the patch itself goes via Andrew's tree, works for me! Let me note this in the uml patchwork system. Acked-by: Richard Weinberger Thanks, //richard

Re: -Wmissing-prototypes warnings in user-mode linux

2024-04-22 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Jani Nikula" > An: "Johannes Berg" , "richard" , > "anton ivanov" >> I think this series addressed most already? >> >> https://patchwork.ozlabs.org/project/linux-um/list/?series=393619 >> >> But I haven't checked myself yet. > > Oh, nice, it certainly helps

Re: [PATCH 1/1] arch/um: fix forward declaration for vmalloc

2024-04-22 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Suren Baghdasaryan" >> > Fixes: 576477564ede ("mm: vmalloc: enable memory allocation profiling") >> >> This commit id is not in Linus tree. >> Do I miss something? > > It's in mm-unstable under dc26c7e79daf2fc11169b23c150862f0e878ee5a. I > think it just didn

Re: [PATCH 1/1] arch/um: fix forward declaration for vmalloc

2024-04-22 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Suren Baghdasaryan" > Betreff: [PATCH 1/1] arch/um: fix forward declaration for vmalloc > Patch [1] replaced vmalloc() function with a new definition but it did > not adjust the forward declaration used in UML architecture. Change it > to act as before. > No

Re: [PATCH RESEND 1/1] um: oops on accessing a non-present page in the vmalloc area

2024-03-20 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Petr Tesarik" >> Yes. I'm just way behind my maintainer schedule. :-/ > > Understood. Thank you for your reply. > > By the way, are you looking for more people to help with the amount of work? Yes, help is always welcome! Johannes and Anton do already a gr

Re: [PATCH RESEND 1/1] um: oops on accessing a non-present page in the vmalloc area

2024-03-19 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Petr Tesarik" > An: "richard" , "anton ivanov" > , "Johannes Berg" > , "linux-um" , > "linux-kernel" > CC: "Roberto Sassu" , "petr" > Gesendet: Montag, 18. März 2024 14:09:07 > Betreff: Re: [PATCH RESEND 1/1] um: oops on accessing a non-present page in >

Re: [PATCH 7/7] ubd: open the backing files in ubd_add

2024-02-27 Thread Richard Weinberger
v->file, -err); > - goto out; > - } > - } > - ubd_dev->count++; > -out: > - mutex_unlock(&ubd_mutex); > - return err; > -} > - > -static void ubd_release(struct gendisk *disk) > -{ > - struct ubd *ubd_dev = disk->private_data; > - > - mutex_lock(&ubd_mutex); > - if(--ubd_dev->count == 0) > - ubd_close_dev(ubd_dev); > - mutex_unlock(&ubd_mutex); > -} > - > static void cowify_bitmap(__u64 io_offset, int length, unsigned long > *cow_mask, > __u64 *cow_offset, unsigned long *bitmap, > __u64 bitmap_offset, unsigned long *bitmap_words, > -- > 2.39.2 Reviewed-by: Richard Weinberger Thanks, //richard

Re: [PATCH 6/7] ubd: remove the queue pointer in struct ubd

2024-02-27 Thread Richard Weinberger
} > - ubd_dev->queue = disk->queue; > > blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue); > - blk_queue_write_cache(ubd_dev->queue, true, false); > + blk_queue_write_cache(disk->queue, true, false); > disk->major = UBD_MAJOR; > disk->first_minor = n << UBD_SHIFT; > disk->minors = 1 << UBD_SHIFT; > -- > 2.39.2 Reviewed-by: Richard Weinberger Thanks, //richard

Re: [PATCH 5/7] ubd: move set_disk_ro to ubd_add

2024-02-27 Thread Richard Weinberger
ndisk *disk, blk_mode_t > mode) > } > } > ubd_dev->count++; > - set_disk_ro(disk, !ubd_dev->openflags.w); > out: > mutex_unlock(&ubd_mutex); > return err; > -- > 2.39.2 Reviewed-by: Richard Weinberger Thanks, //richard

Re: [PATCH 4/7] ubd: move setting the variable queue limits to ubd_add

2024-02-27 Thread Richard Weinberger
(ubd_dev->file == NULL) > goto out; > > + if (ubd_dev->cow.file) > + lim.max_hw_sectors = 8 * sizeof(long); > + if (!ubd_dev->no_trim) { > + lim.max_hw_discard_sectors = UBD_MAX_REQUEST; > + lim.max_write_zeroes_sectors = UBD_MAX_REQUEST; > + } > + > err = ubd_file_size(ubd_dev, &ubd_dev->size); > if(err < 0){ > *error_out = "Couldn't determine size of device's file"; > -- > 2.39.2 Reviewed-by: Richard Weinberger Thanks, //richard

Re: [PATCH 3/7] ubd: move setting the nonrot flag to ubd_add

2024-02-27 Thread Richard Weinberger
-894,6 +893,7 @@ static int ubd_add(int n, char **error_out) > } > ubd_dev->queue = disk->queue; > > + blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue); > blk_queue_write_cache(ubd_dev->queue, true, false); > disk->major = UBD_MAJOR; > disk->first_minor = n << UBD_SHIFT; > -- > 2.39.2 Reviewed-by: Richard Weinberger Thanks, //richard

Re: [PATCH 2/7] ubd: remove ubd_disk_register

2024-02-27 Thread Richard Weinberger
n << UBD_SHIFT; > + disk->minors = 1 << UBD_SHIFT; > + disk->fops = &ubd_blops; > + set_capacity(disk, ubd_dev->size / 512); > + sprintf(disk->disk_name, "ubd%c", 'a' + n); > + disk->private_data = ubd_dev; >

Re: [PATCH 1/7] ubd: remove the ubd_gendisk array

2024-02-27 Thread Richard Weinberger
d_dev->count > 0) > goto out; > > - ubd_gendisk[n] = NULL; > - if(disk != NULL){ > - del_gendisk(disk); > - put_disk(disk); > + if (ubd_dev->disk) { > + del_gendisk(ubd_dev->disk); > + put_disk(ubd_dev->disk); > } Reviewed-by: Richard Weinberger Thanks, //richard

[GIT PULL] UML updates for v6.8-rc1

2024-01-13 Thread Richard Weinberger
Linus, The following changes since commit 861deac3b092f37b2c5e6871732f3e11486f7082: Linux 6.7-rc7 (2023-12-23 16:25:56 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git tags/uml-for-linus-6.8-rc1 for you to fetch changes up to 83aec

Re: [PATCH v3 09/11] um: Rely on PTRACE_SETREGSET to set FS/GS base registers

2024-01-05 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Benjamin Berg" > On Fri, 2024-01-05 at 00:05 +0100, Richard Weinberger wrote: >> On Fri, Nov 10, 2023 at 12:03 PM wrote: >> > >> > From: Benjamin Berg >> > >> > These registers are saved/res

Re: [PATCH v3 04/11] um: Don't use vfprintf() for os_info()

2024-01-05 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Johannes Berg" > An: "Benjamin Berg" , "Richard Weinberger" > > CC: "linux-um" > Gesendet: Freitag, 5. Januar 2024 09:56:11 > Betreff: Re: [PATCH v3 04/11] um: Don't use vfprintf() for os_i

Re: [PATCH] um: vector: fix return value check in vector_legacy_rx

2024-01-05 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Johannes Berg" > An: "Richard Weinberger" , "Ma Ke" > > CC: "richard" , "anton ivanov" > , xiangya...@huawei.com, "linux-um" > , "linux-kernel" > Gesendet: Fr

Re: [PATCH v3 09/11] um: Rely on PTRACE_SETREGSET to set FS/GS base registers

2024-01-04 Thread Richard Weinberger
On Fri, Jan 5, 2024 at 12:05 AM Richard Weinberger wrote: > > Most of this logic was introduced in commit f39cf7845 ("[PATCH] uml: > > x86_64 thread fixes"). However, at least today we can rely on ptrace to > > Do you know since when exactly? I don't want to

Re: [PATCH 0/2] um: improve UML page fault handling

2024-01-04 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Petr Tesarik" > An: "richard" , "anton ivanov" > , "Johannes Berg" > , "linux-um" , > "linux-kernel" > CC: "Roberto Sassu" , p...@tesarici.cz, "Petr > Tesarik" > > Gesendet: Freitag, 15. Dezember 2023 13:14:29 > Betreff: [PATCH 0/2] um: improve UML page

Re: [PATCH v3 09/11] um: Rely on PTRACE_SETREGSET to set FS/GS base registers

2024-01-04 Thread Richard Weinberger
On Fri, Nov 10, 2023 at 12:03 PM wrote: > > From: Benjamin Berg > > These registers are saved/restored together with the other general > registers using ptrace. In arch_set_tls we then just need to set the > register and it will be synced back normally. > > Most of this logic was introduced in co

Re: [PATCH v3 04/11] um: Don't use vfprintf() for os_info()

2024-01-04 Thread Richard Weinberger
On Fri, Nov 10, 2023 at 12:03 PM wrote: > > From: Benjamin Berg > > The threads allocated inside the kernel have only a single page of > stack. Unfortunately, the vfprintf function in standard glibc may use > too much stack-space, overflowing it. Another option is giving the helper threads more

Re: [PATCH] um: hostfs: catch EINTR and partial read/write

2024-01-04 Thread Richard Weinberger
On Fri, Nov 10, 2023 at 10:44 AM wrote: > > From: Benjamin Berg > > The UM kernel uses signals for various purposes (SIGALRM for scheduling > for example). These signals are interrupts for the UM kernel, which > should not affect file system operations from userspace processes. > > Said different

Re: [PATCH] um: vector: fix return value check in vector_legacy_rx

2024-01-04 Thread Richard Weinberger
On Fri, Oct 6, 2023 at 2:28 PM Ma Ke wrote: > > In vector_legacy_rx, to avoid an unexpected result returned by > pskb_trim, we should check the return value of pskb_trim(). > > Signed-off-by: Ma Ke > --- > arch/um/drivers/vector_kern.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >

Re: [PATCH 4/9] ubd: use the default discard granularity

2023-12-28 Thread Richard Weinberger
gt;no_trim == 0) { > - ubd_dev->queue->limits.discard_granularity = SECTOR_SIZE; > blk_queue_max_discard_sectors(ubd_dev->queue, UBD_MAX_REQUEST); > blk_queue_max_write_zeroes_sectors(ubd_dev->queue, > UBD_MAX_REQUEST); > } Acked-by: Richard Weinberger Thanks, //richard

Re: [PATCH 9/9] mtd_blkdevs: use the default discard granularity

2023-12-28 Thread Richard Weinberger
G_NONROT, new->rq); > blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, new->rq); > > - if (tr->discard) { > + if (tr->discard) > blk_queue_max_discard_sectors(new->rq, UINT_MAX); > - new->rq->limits.discard_granularity = tr->blksize; > - } Acked-by: Richard Weinberger Thanks, //richard

Re: [PATCH 2/5] UML: remove unused cmd_vdso_install

2023-10-09 Thread Richard Weinberger
; , "richard" , > "tglx" > Gesendet: Montag, 9. Oktober 2023 14:42:07 > Betreff: [PATCH 2/5] UML: remove unused cmd_vdso_install > You cannot run this code because arch/um/Makefile does not define the > vdso_install target. > > It appears that this c

Re: [PATCH v6] um: Enable preemption in UML

2023-09-22 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Johannes Berg" >> -mmap_read_lock(mm); >> +/* We use a RCU lock instead of a mm lock, because >> + * this can be invoked out of critical/atomic sections >> + * and that does not agree with the sleepable semantics >> + * of the standard sem

Re: [PATCH v5] um: Enable preemption in UML

2023-09-22 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "anton ivanov" > An: "linux-um" > CC: "Johannes Berg" , "richard" , > "anton ivanov" > > Gesendet: Freitag, 22. September 2023 08:52:12 > Betreff: [PATCH v5] um: Enable preemption in UML > From: Anton Ivanov > > Preemption requires saving/restoring FPU s

Re: [PATCH v4] um: Enable preemption in UML

2023-09-21 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "anton ivanov" > An: "richard" > CC: "linux-um" , "Johannes Berg" > > Gesendet: Donnerstag, 21. September 2023 23:41:16 > Betreff: Re: [PATCH v4] um: Enable preemption in UML > On 21/09/2023

Re: [PATCH v4] um: Enable preemption in UML

2023-09-21 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "anton ivanov" > An: "linux-um" > CC: "Johannes Berg" , "richard" , > "anton ivanov" > > Gesendet: Donnerstag, 21. September 2023 17:55:22 > Betreff: [PATCH v4] um: Enable preemption in UML > From: Anton Ivanov > > Preemption requires saving/restoring FP

Re: [PATCH] um: Enable preemption in UML

2023-09-21 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "anton ivanov" > An: "Peter Lafreniere" > CC: "Johannes Berg" , "linux-um" > , "richard" > Gesendet: Donnerstag, 21. September 2023 09:12:33 > Betreff: Re: [PATCH] um: Enable preemption in UML > On 20/09/2023 15:49, Peter Lafreniere wrote: >> On Wed, Sep 2

Re: Arches that don't support PREEMPT

2023-09-19 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "anton ivanov" > It's been a while. I remember that I dropped it at the time, but do not > remember > the full details. > > There was some stuff related to FP state and a few other issues I ran into > while > rewriting the interrupt controller. Some of it m

Re: [PATCH RESEND] um: Remove CONFIG_REISERFS_FS from defconfig

2023-09-18 Thread Richard Weinberger
; CONFIG_REISERFS_FS in their defconfig (sh, powerpc, mips, m68k, ia64, arm, > alpha). So perhaps we should do this for all of them when we are at it? Yes, a combined patch makes in this case more sense. >> >> arch/um/configs/i386_defconfig | 1 - >> arch/um/configs/x

Re: [PATCH] x86: Fix build of UML with KASAN

2023-09-11 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Vincent Whitchurch" >> Thanks: I stumbled into this the other day and ran out of time to debug it. >> >> I've tested that it works here. >> >> Tested-by: David Gow > > Thanks. Perhaps someone could pick this up? It's been a few months, > and the build p

[GIT PULL] UML Changes for v6.6-rc1

2023-09-03 Thread Richard Weinberger
Linus, The following changes since commit 2ccdd1b13c591d306f0401d98dedc4bdcd02b421: Linux 6.5-rc6 (2023-08-13 11:29:55 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git tags/uml-for-linus-6.6-rc1 for you to fetch changes up to 974b8

Re: [PATCH v3 2/2] hostfs: store permissions in extended attributes

2023-08-28 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Marko Petrović" > An: "linux-um" > CC: "richard" , "anton ivanov" > , "Johannes Berg" > , "Marko Petrović" > Gesendet: Samstag, 15. April 2023 18:48:21 > Betreff: [PATCH v3 2/2] hostfs: store permissions in extended attributes > This patch adds support fo

Re: [PATCH 1/2] asm-generic: current: Don't include thread-info.h if building asm

2023-08-19 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "davidgow" > asm/current.h is included by some assembly files (either directly, or > indirectly). This works on some architectures (such as x86), as their > implementation of current.h is careful to not include any C, but the > asm-generic version includes lin

Re: [PATCH v2 1/2] UML: hard-code the result of 'uname -s'

2023-08-19 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "masahiroy" > We rely on 'uname -s' returning 'Linux' because there are os-Linux/ > directories, but no other os-*/. > > Supporting a non-Linux host is unlikely to happen. > > Let's hard-code 'Linux'. While I agree that a non-Linux version is unlikely I'd l

Re: [PATCH v4] um: vector: Fix exception handling in vector_eth_configure()

2023-08-19 Thread Richard Weinberger
- Ursprüngliche Mail - > The resource cleanup was incomplete in the implementation > of the function "vector_eth_configure". > Thus replace the jump target > "out_undo_user_init" by "out_free_netdev". > Delate the orphan function "out_undo_user_init" > > PATCH v1-v3: Modify the patch forma

Re: [PATCH v3] um/drivers: fix hostaudio build errors

2023-07-30 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Randy Dunlap" > Oh, good point, and one that I agree with. > > I'll send a v4. Ok! >> >> Reviewed-by: Masahiro Yamada > > Takashi, I don't know who will merge the patch, but I would expect > that one of the UML maintainers to merge it FWIW. Yep. I

Re: UML for arm64

2023-06-22 Thread Richard Weinberger
[CC'ing Al] - Ursprüngliche Mail - > Von: "Benjamin Berg" > An: "Johannes Berg" , "robh" , > "richard" , "anton ivanov" > > CC: "linux-um" > Gesendet: Donnerstag, 22. Juni 2023 22:13:56 > Betreff: Re: UML for arm64 > Hi, > > On Thu, 2023-06-22 at 21:41 +0200, Johannes Berg wrote: >>

Re: [patch 10/17] um/cpu: Switch to arch_cpu_finalize_init()

2023-06-13 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "tglx" > check_bugs() is about to be phased out. Switch over to the new > arch_cpu_finalize_init() implementation. > > No functional change. Confirmed. :-) > Signed-off-by: Thomas Gleixner > Cc: Richard Weinberger > Cc:

Re: Reported-by/Closes tag for uncommitted issues (was: Re: [PATCH v2] uml: Replace strlcpy with strscpy)

2023-06-07 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Johannes Berg" > On Tue, 2023-06-06 at 21:23 -0700, Eric Biggers wrote: >> >> > > > Reported-by: kernel test robot >> > > > Closes: >> > > > https://lore.kernel.org/oe-kbuild-all/202305311135.zgmt1gyr-...@intel.com/ >> > > >> > > Are you sure Reported-by a

Re: [PATCH v2] uml: Replace strlcpy with strscpy

2023-06-06 Thread Richard Weinberger
ing this in the updated patch is in vain. Other than that, Acked-by: Richard Weinberger Thanks, //richard ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [PATCH 23/31] mtd: block: use a simple bool to track open for write

2023-06-06 Thread Richard Weinberger
,7 @@ struct mtd_blktrans_dev { > struct blk_mq_tag_set *tag_set; > spinlock_t queue_lock; > void *priv; > - fmode_t file_mode; > + bool writable; > }; Acked-by: Richard Weinberger Thanks, //richard ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [PATCH 25/31] ubd: remove commented out code in ubd_open

2023-06-06 Thread Richard Weinberger
flags.w){ > - if(--ubd_dev->count == 0) ubd_close_dev(ubd_dev); > - err = -EROFS; > - }*/ Acked-by: Richard Weinberger Thanks, //richard ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [PATCH] uml: Replace all non-returning strlcpy with strscpy

2023-06-05 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Azeem Shaikh" > Planning to send out v2 with the fixup from Richard applied. Let me > know if that's ok. Fine by me. :-) Thanks, //richard ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infra

Re: [PATCH] uml: Replace all non-returning strlcpy with strscpy

2023-05-30 Thread Richard Weinberger
- Ursprüngliche Mail - >> Ah, yeah, this is another "not actually in the kernel" cases. Let's ignore >> this >> strlcpy for now. >> > > Well, strlcpy() isn't part of libc either, so all this would need is to > add it to user.h just like strlcpy() is now? I think so. Azeem, can you pleas

Re: [PATCH] uml: Replace all non-returning strlcpy with strscpy

2023-05-30 Thread Richard Weinberger
- Ursprüngliche Mail - arch/um/os-Linux/drivers/tuntap_user.c:149:17: error: implicit declaration of function 'strscpy'; did you mean 'strncpy'? [-Werror=implicit-function-declaration] >> 149 | strscpy(ifr.ifr_name, pri->dev_name, >> sizeof(ifr.i

[GIT PULL] UML fix for v6.4-rc3

2023-05-21 Thread Richard Weinberger
Linus, The following changes since commit ac9a78681b921877518763ba0e89202254349d1b: Linux 6.4-rc1 (2023-05-07 13:34:35 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git tags/uml-for-linus-6.4-rc3 for you to fetch changes up to 73a23

[GIT PULL] UML changes for v6.4

2023-05-03 Thread Richard Weinberger
Linus, The following changes since commit 7e364e56293bb98cae1b55fd835f5991c4e96e7d: Linux 6.3-rc5 (2023-04-02 14:29:29 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git tags/uml-for-linus-6.4-rc1 for you to fetch changes up to 6032a

Re: [PATCH v2 2/2] hostfs: store permissions in extended attributes

2023-04-14 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Marko Petrović" > About using -1 for uid and gid, in documentation for chown it is stated > that -1 shall be used if the desired value should not be changed, since > normally chown(2) accepts both uid and gid for changing in one system > call. > In the concre

Re: [PATCH v2 2/2] hostfs: store permissions in extended attributes

2023-04-14 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Marko Petrović" > +static int uml_chown(const char *pathname, unsigned int owner, unsigned int > group) Is there a specific reason why you are not using uid_t and gid_t? > +{ > + int status; > + > + if (use_xattr) { > + if (owner != -1)

[GIT PULL] UML fix for v6.3-rc7

2023-04-09 Thread Richard Weinberger
Linus, The following changes since commit 7e364e56293bb98cae1b55fd835f5991c4e96e7d: Linux 6.3-rc5 (2023-04-02 14:29:29 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git tags/uml-for-linus-6.3-rc7 for you to fetch changes up to a3046

Re: [PATCH] arch:um: Only disable SSE on clang to work around old GCC bugs

2023-04-04 Thread Richard Weinberger
- Ursprüngliche Mail - >> Von: "davidgow" >> An: "richard" , "anton ivanov" >> , "Johannes Berg" >> Any chance we could get this picked up as a fix for 6.3? The UML build >> is still broken with older gcc versions. > > Sure. Just got flooded with other stuff. :-S Patch applied to fixes b

Re: [PATCH] arch:um: Only disable SSE on clang to work around old GCC bugs

2023-03-31 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "davidgow" > An: "richard" , "anton ivanov" > , "Johannes Berg" > Any chance we could get this picked up as a fix for 6.3? The UML build > is still broken with older gcc versions. Sure. Just got flooded with other stuff. :-S Thanks, //richard _

[GIT PULL] UML changes for v6.3-rc1

2023-03-01 Thread Richard Weinberger
Linus, The following changes since commit 2241ab53cbb5cdb08a6b2d4688feb13971058f65: Linux 6.2-rc5 (2023-01-21 16:27:01 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git tags/uml-for-linus-6.3-rc1 for you to fetch changes up to 04df9

Re: [PATCH v2 0/2] GDB: Support getting current task struct in UML

2023-02-16 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Andrew Morton" > Thanks, but I'm not subscribed to linux-um and my usual > get-it-from-lkml didn't work. > > Could we please have a resend, with a cc to linux-kernel? You can also get the patches in mbox format from: https://patchwork.ozlabs.org/project/lin

Re: [PATCH V1] um: Fix compilation warnings

2023-02-14 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Srinivasarao Pathipati" > static void sig_handler_common(int sig, struct siginfo *si, mcontext_t *mc) > { > - struct uml_pt_regs r; > + struct uml_pt_regs *r; > int save_errno = errno; > > - r.is_user = 0; > + r = malloc(sizeof(struct u

Re: [PATCH] virt-pci: add platform bus support

2023-02-13 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Johannes Berg" > An: "Vincent Whitchurch" , "richard" > , "anton ivanov" > > CC: r...@kernel.org, devicet...@lists.infradead.org, "linux-um" > , "linux-kernel" > , "kernel" > Gesendet: Montag, 13. Februar 2023 18:54:49 > Betreff: Re: [PATCH] virt-pci: add

Re: Add linux-um archives to lore.kernel.org?

2023-02-11 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Konstantin Ryabitsev" > Better late than never -- this is now done. > > Sorry about the wait. No need to worry, thanks a lot! :-) Thanks, //richard ___ linux-um mailing list linux-um@lists.infradead.org http://l

Re: Using ftrace

2023-01-30 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Anton Ivanov" > On 31/01/2023 04:17, Glenn Washburn wrote: >> I'm trying to use the ftrace facility within UML. It appears as though >> it exists in the menuconfig, but I can't seem to get the kernel to >> recognize the tracefs filesystem. I'm wondering if so

Re: [PATCH 1/2 v2] IB/qib: don't use qib_wc_x86_64 for UML

2022-12-01 Thread Richard Weinberger
- Ursprüngliche Mail - > I would advocate to add this line to whole drivers/infiniband. > None of RDMA code makes sense for UML. Yes. Makes sense. Thanks, //richard ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.o

Re: [PATCH V3 04/11] um: Improve panic notifiers consistency and ordering

2022-10-17 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Guilherme G. Piccoli" > Hi Richard / Johannes, is there any news on this one? > Thanks in advance, It's upstream: git.kernel.org/linus/758dfdb9185cf94160f20e85bbe05583e3cd4ff4 Thanks, //richard ___ linux-um maili

[GIT PULL] UML updates for 6.1-rc1

2022-10-14 Thread Richard Weinberger
Linus, The following changes since commit 521a547ced6477c54b4b0cc206000406c221b4d6: Linux 6.0-rc6 (2022-09-18 13:44:14 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git tags/for-linus-6.1-rc1 for you to fetch changes up to 193cb8372

Re: Add linux-um archives to lore.kernel.org?

2022-10-13 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "anton ivanov" > On 12/10/2022 20:15, Johannes Berg wrote: >> On Wed, 2022-10-12 at 14:11 -0500, Bjorn Helgaas wrote: >>> The linux-um@lists.infradead.org mailing list is listed in MAINTAINERS >>> and is quite active [1]. Once in a while a commit links to the

[GIT PULL] UML fixes for 6.0-rc7

2022-09-21 Thread Richard Weinberger
Linus, The following changes since commit 521a547ced6477c54b4b0cc206000406c221b4d6: Linux 6.0-rc6 (2022-09-18 13:44:14 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git tags/for-linus-6.0-rc7 for you to fetch changes up to bd71558d5

Re: [PATCH v2] arch: um: Mark the stack non-executable to fix a binutils warning

2022-09-21 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "davidgow" > > Changes since v1: > http://lists.infradead.org/pipermail/linux-um/2022-August/004234.html > - Pass the -z noexecstack and --no-warn-rwx-segments flags as LDFLAGS, > rather than as CFLAGS via -Wl > - Check that --no-warn-rwx-segments exists wit

Re: [PATCH] arch: um: Mark the stack non-executable to fix a binutils warning

2022-09-19 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Randy Dunlap" >> Link: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ffcf9c5700e49c0aee42dcba9a12ba21338e8136 >> Link: >> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=ba951afb99912da01a6e8434126b8fac7aa75107 >>

UML next tree update

2022-09-19 Thread Richard Weinberger
Stephen, please set the UML next trees to: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git next git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux.git fixes git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git will be no longer used. Thanks, //richard __

Re: [PATCH V3 04/11] um: Improve panic notifiers consistency and ordering

2022-09-18 Thread Richard Weinberger
ring among the mconsole and arch notifier is important, >> given that the arch one effectively triggers a core dump. >> >> Fix that by running the mconsole notifier as the first panic >> notifier, followed by the architecture one (that coredumps). >> >> Cc: Ant

[GIT PULL] UML changes for v5.20-rc1

2022-08-05 Thread Richard Weinberger
Linus, The following changes since commit 32346491ddf24599decca06190ebca03ff9de7f8: Linux 5.19-rc6 (2022-07-10 14:40:51 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git tags/for-linus-5.20-rc1 for you to fetch changes up to af3e16101c

Re: [PATCH v2] um: read multiple msg from virtio slave request fd

2022-07-28 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Benjamin Beichler" > Are there any issues with that patch? > I would be happy to receive any comments or an acceptance :-D Johannes, can you please have a look? Thanks, //richard ___ linux-um mailing list linux-u

[GIT PULL] UML updates for v5.19-rc1

2022-06-03 Thread Richard Weinberger
Linus, The following changes since commit 42226c989789d8da4af1de0c31070c96726d990c: Linux 5.18-rc7 (2022-05-15 18:08:58 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git tags/for-linus-5.19-rc1 for you to fetch changes up to 2a4a62a14b

Re: [PATCH v2] um: x86: print RIP with symbol

2022-05-27 Thread Richard Weinberger
On Fri, Apr 22, 2022 at 2:06 PM Johannes Berg wrote: > > From: Johannes Berg > > This is not only nicer to read by default, but also lets > decode_stacktrace.sh work on it, rather than removing it. > > Signed-off-by: Johannes Berg > --- > v2: put back %lx I accidentally dropped looking at x86 >

Re: [PATCH 1/1] um: fix error return code in winch_tramp()

2022-04-11 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Nathan Chancellor" > I attempted to print out the error code but it seems like there is no > output in the console after "reboot: System halted". If I add an > unconditional print right before the call to os_set_fd_block(), I see it > during start up but I do

Re: [PATCH 1/1] um: fix error return code in winch_tramp()

2022-04-10 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Thorsten Leemhuis" > Hi, this is your Linux kernel regression tracker. Top-posting for once, > to make this easily accessible to everyone. > > Zhen Lei, Richard, what's up here? Below regression report is more than > two weeks old now and afaics didn't even

Re: [PATCH 0/4] um: Assorted console related fixes

2022-04-04 Thread Richard Weinberger
Glenn, On Thu, Mar 10, 2022 at 7:22 PM Glenn Washburn wrote: > > On Wed, 9 Mar 2022 09:35:02 +0100 (CET) > Richard Weinberger wrote: > > > - Ursprüngliche Mail - > > >> This series fixes the console exit code to make sure UML > > >> und

[GIT PULL] UML updates for 5.18

2022-03-31 Thread Richard Weinberger
: Write error message to kernel log on exec failure on host Johannes Berg (2): lib/logic_iomem: correct fallback config references uml: net: vector: fix const issue Richard Weinberger (1): MAINTAINERS: Update UserModeLinux entry Vincent Whitchurch (2): um: Fix order of dtb

Re: [PATCH 0/4] um: Assorted console related fixes

2022-03-09 Thread Richard Weinberger
Randy, - Ursprüngliche Mail - > Von: "Randy Dunlap" > Uh, where are the patches? > >> http://lists.infradead.org/mailman/listinfo/linux-um > > not in that archive ^^^ https://lore.kernel.org/lkml/20220101215810.13260-1-rich...@nod.at/T/ Thanks, //richar

Re: [PATCH 0/4] um: Assorted console related fixes

2022-03-09 Thread Richard Weinberger
- Ursprüngliche Mail - >> This series fixes the console exit code to make sure UML >> undoes everything it changed on the host side. > > I gave this a run hoping it would fix the issues I'm seeing with the console > getting messed up when UML exits via halt in the guest. Echo is turned off