Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

On Thu, Jun 08, 2023 at 11:04:44AM +0200, Christoph Hellwig wrote: > On Thu, Jun 08, 2023 at 09:47:27AM +0100, Phillip Potter wrote: > > Yes indeed - I was under the impression it was appropriate for a > > maintainer to signal their approval of a patch to maintained code using >

Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

On Thu, Jun 08, 2023 at 10:41:29AM +0200, Christoph Hellwig wrote: > On Wed, Jun 07, 2023 at 12:00:57AM +0100, Phillip Potter wrote: > > Looks good, thanks. > > > > Signed-off-by: Phillip Potter > > Hmm, these signoffs don't really make sense here. Were they i

Re: [PATCH 06/31] cdrom: remove the unused mode argument to cdrom_release

om_release(struct cdrom_device_info *cdi); > int cdrom_ioctl(struct cdrom_device_info *cdi, struct block_device *bdev, > unsigned int cmd, unsigned long arg); > extern unsigned int cdrom_check_events(struct cdrom_device_info *cdi, > -- > 2.39.2 > Looks good, thanks. Signed-off-by: Phillip Potter Regards, Phil ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [PATCH 05/31] cdrom: track if a cdrom_device_info was opened for data

+ b/include/linux/cdrom.h > @@ -64,6 +64,7 @@ struct cdrom_device_info { > int (*exit)(struct cdrom_device_info *); > int mrw_mode_page; > __s64 last_media_change_ms; > + bool opened_for_data; > }; > > struct cdrom_device_ops { > -- > 2.39.2 > Looks good, thanks. Signed-off-by: Phillip Potter Regards, Phil ___ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um

Re: [PATCH 04/31] cdrom: remove the unused cdrom_close_write release code

lude/linux/cdrom.h > +++ b/include/linux/cdrom.h > @@ -61,7 +61,6 @@ struct cdrom_device_info { > __u8 last_sense; > __u8 media_written; /* dirty flag, DVD+RW bookkeeping */ > unsigned short mmc3_profile;/* current MMC3 profile */ > - in

Re: [PATCH 03/31] cdrom: remove the unused mode argument to cdrom_ioctl

*bdev, > -fmode_t mode, unsigned int cmd, unsigned long arg); > +int cdrom_ioctl(struct cdrom_device_info *cdi, struct block_device *bdev, > + unsigned int cmd, unsigned long arg); > extern unsigned int cdrom_check_events(struct cdrom_device_info *cdi, >

Re: [PATCH 02/31] cdrom: remove the unused bdev argument to cdrom_open

rom_device_info *cdi, struct block_device > *bdev, > - fmode_t mode); > +int cdrom_open(struct cdrom_device_info *cdi, fmode_t mode); > extern void cdrom_release(struct cdrom_device_info *cdi, fmode_t mode); > extern int cdrom_ioctl(struct cdrom_