On Tue, Jun 17, 2025 at 03:05:59PM +0100, David Howells wrote:
> Lorenzo Stoakes wrote:
>
> > This is preferred to the existing f_op->mmap() hook as it does require a
> > VMA to be established yet,
>
> Did you mean ".. doesn't require a VMA to be established
On Tue, Jun 17, 2025 at 09:45:32AM -0400, Jeff Layton wrote:
> On Mon, 2025-06-16 at 21:41 +0100, Al Viro wrote:
> > On Mon, Jun 16, 2025 at 08:33:19PM +0100, Lorenzo Stoakes wrote:
> > > REVIEWER'S NOTES
> > >
> > >
> > > I am bas
On Mon, Jun 16, 2025 at 10:10:30PM -0700, Christoph Hellwig wrote:
> On Mon, Jun 16, 2025 at 08:33:20PM +0100, Lorenzo Stoakes wrote:
> > The call_mmap() function violates the existing convention in
> > include/linux/fs.h whereby invocations of virtual file system hooks is
&
On Mon, Jun 16, 2025 at 10:11:28PM -0700, Christoph Hellwig wrote:
> On Mon, Jun 16, 2025 at 08:33:22PM +0100, Lorenzo Stoakes wrote:
> > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file
> > callback"), the f_op->mmap() hook has been deprecated in favo
which checks for either
f_op->mmap or f_op->mmap_prepare rather than checking only for f_op->mmap
directly.
Signed-off-by: Lorenzo Stoakes
---
mm/nommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/nommu.c b/mm/nommu.c
index b624acec6d2e..38c22ea0a95c 100644
are may be invoked here.
Also rename __call_mmap_prepare() function to vfs_mmap_prepare() and adjust
to accept a file parameter, this is useful later for nested file systems.
Finally, fix up the VMA userland tests and ensure the mmap_prepare -> mmap
shim is implemented there.
Signed-off-by: L
use them.
This patch does so.
Signed-off-by: Lorenzo Stoakes
---
include/linux/fs.h | 6 --
mm/filemap.c | 29 +
2 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 7120f80255b3..65cffc445fcc 1006
ing file systems which use generic hooks in a less direct
way which we address in a subsequent commit.
Signed-off-by: Lorenzo Stoakes
---
fs/9p/vfs_file.c| 2 +-
fs/adfs/file.c | 2 +-
fs/affs/file.c | 2 +-
fs/bfs/file.c | 2 +-
fs/fat/file.c | 2 +-
-off-by: Lorenzo Stoakes
---
block/fops.c | 9 +
fs/9p/vfs_file.c | 11 ++-
fs/afs/file.c | 11 ++-
fs/erofs/data.c| 16 +---
fs/ext2/file.c | 12 +++-
fs/nfs/file.c | 13 +++--
fs/nfs/internal.h
7;ing hook code).
Signed-off-by: Lorenzo Stoakes
---
fs/ext4/file.c | 2 +-
fs/xfs/xfs_file.c | 3 ++-
include/linux/dax.h | 16 +---
3 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index 21df81347147..08a814fcd956 100644
---
layer for nested file systems").
Signed-off-by: Lorenzo Stoakes
---
fs/ext4/file.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index 08a814fcd956..38180e527dbe 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -804,9 +804
he elf logic to allow for the ability to
execute binaries on filesystems which have the .mmap_prepare hook, but
additionally we update nested filesystems.
Signed-off-by: Lorenzo Stoakes
---
fs/backing-file.c | 2 +-
fs/binfmt_elf.c | 4 ++--
fs/binfmt_elf_fdpic.c | 2 +-
fs/coda/file
layer for nested file systems").
In this patch we apply this change to file systems with relatively simple
mmap() hook logic - exfat, ceph, f2fs, bcachefs, zonefs, btrfs, ocfs2,
orangefs, nilfs2, romfs, ramfs and aio.
Signed-off-by: Lorenzo Stoakes
---
fs/aio.c | 8
layer for nested file systems").
Signed-off-by: Lorenzo Stoakes
---
fs/xfs/xfs_file.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index ab97ce1f9087..f7b76647d675 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_f
e cramfs which needs a mixed mapping
insertion with the same issue, nor do we update procfs, hugetlbfs, syfs or
kernfs all of which require VMAs for internal state and hooks. We shall
return to all of these later.
Lorenzo Stoakes (10):
mm: rename call_mmap/mmap_prepare to vfs_mmap/mmap_prepare
m
On Wed, Apr 30, 2025 at 11:51:47AM +0200, Johannes Berg wrote:
> On Tue, 2025-04-29 at 14:23 +0100, Lorenzo Stoakes wrote:
> > Thanks, appreciate the response. I would say send a v8 that's rebased to
> > make life easier for maintainers :) if you already have it ready to go th
On Sun, Apr 27, 2025 at 12:49:36PM +0900, Hajime Tazaki wrote:
>
> Hello Lorenzo,
>
> On Fri, 25 Apr 2025 22:49:31 +0900,
> Lorenzo Stoakes wrote:
>
> > It seemed this series died, which is a pity, i'd be very useful to have
> > this functionality to aid
+cc current UML maintainers as per- current MAINTAINERS file, mm + kernel
lists.
Hi,
It seemed this series died, which is a pity, i'd be very useful to have
this functionality to aid in easily testing nommu in mm code.
I know that I pushed back a little (or rather - wondering about the status
of
Hi Mike,
I bisected issues with the kernel booting correctly to an earlier revision
of this series [2]. I have now tested this series in the same environment
and found that it functions correctly with no issues, so feel free to add:
Tested-by: Lorenzo Stoakes
Cheers, Lorenzo
[2]:https
Hi Mike,
This commit is making my intel box not boot in mm-unstable :>) I bisected it to
this commit.
It seems to be having an unhandled kernel page fault on exec, so I guess not
actually making it exec somehow?
It is a pretty standard intel machine (arch linux config, slightly scaled down
via m
On Fri, Nov 22, 2024 at 12:49:45PM +, Damien Le Moal wrote:
> On 11/22/24 21:38, Christoph Hellwig wrote:
> > On Fri, Nov 22, 2024 at 12:25:19PM +, Lorenzo Stoakes wrote:
> >> It's an ongoing maintenance burden, discussions about seeing whether it's
> >>
On Fri, Nov 22, 2024 at 01:18:26PM +0100, Christoph Hellwig wrote:
> Maybe I'm missing something, but where does this discussion about
> killing nommu even come from? Nommu is a long standing and reasonable
> well maintained part of the kernel, why would anyone want to kill it
> for no good reason
On Fri, Nov 22, 2024 at 10:53:18AM +0100, Johannes Berg wrote:
> On Fri, 2024-11-22 at 09:33 +0000, Lorenzo Stoakes wrote:
> >
> > In general, while I appreciate your work and don't mean to be negative, we
> > in mm consistently have problems with nommu as it is a rare
+ VMA people, mm list
On Mon, Nov 11, 2024 at 03:27:00PM +0900, Hajime Tazaki wrote:
> This is a series of patches of nommu arch addition to UML. It would
> be nice to ask comments/opinions on this.
In general, while I appreciate your work and don't mean to be negative, we
in mm consistently hav
On Fri, May 05, 2023 at 10:47:58AM +0800, kernel test robot wrote:
> tree/branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> branch HEAD: 145e5cddfe8b4bf607510b2dcf630d95f4db420f Add linux-next
> specific files for 20230504
>
> Error/Warning reports:
>
> https
25 matches
Mail list logo
