Re: [PATCH v4 27/34] nios2: Convert __pte_free_tlb() to use ptdescs

On 6/14/23 04:30, Geert Uytterhoeven wrote: Hi Dinh, On Wed, Jun 14, 2023 at 12:17 AM Dinh Nguyen wrote: On 6/12/23 16:04, Vishal Moola (Oracle) wrote: Part of the conversions to replace pgtable constructor/destructors with ptdesc equivalents. Signed-off-by: Vishal Moola (Oracle) --- a

Re: [patch 09/17] sparc/cpu: Switch to arch_cpu_finalize_init()

On Wed, Jun 14, 2023 at 01:39:35AM +0200, Thomas Gleixner wrote: > check_bugs() is about to be phased out. Switch over to the new > arch_cpu_finalize_init() implementation. > > No functional change. > > Signed-off-by: Thomas Gleixner > Cc: "David S. Miller" > Cc: sparcli...@vger.kernel.org Revi

Re: [PATCH v4 21/34] arm64: Convert various functions to use ptdescs

On Mon, Jun 12, 2023 at 02:04:10PM -0700, Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Catalin Marinas

Re: [PATCH v4 34/34] mm: Remove pgtable_{pmd, pte}_page_{ctor, dtor}() wrappers

On Mon, Jun 12, 2023 at 02:04:23PM -0700, Vishal Moola (Oracle) wrote: > These functions are no longer necessary. Remove them and cleanup > Documentation referencing them. > > Signed-off-by: Vishal Moola (Oracle) I've found one stale reference in riscv: $ git grep -n pgtable_pmd_page_ctor arch/

Re: [PATCH v4 33/34] um: Convert {pmd, pte}_free_tlb() to use ptdescs

On Mon, Jun 12, 2023 at 02:04:22PM -0700, Vishal Moola (Oracle) wrote: > Part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents. Also cleans up some spacing issues. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > arch/um/inc

Re: [PATCH v4 32/34] sparc: Convert pgtable_pte_page_{ctor, dtor}() to ptdesc equivalents

On Mon, Jun 12, 2023 at 02:04:21PM -0700, Vishal Moola (Oracle) wrote: > Part of the conversions to replace pgtable pte constructor/destructors with > ptdesc equivalents. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > arch/sparc/mm/srmmu.c | 5 +++-- > 1 file c

Re: [PATCH v4 31/34] sparc64: Convert various functions to use ptdescs

On Mon, Jun 12, 2023 at 02:04:20PM -0700, Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM)

Re: [PATCH v4 30/34] sh: Convert pte_free_tlb() to use ptdescs

On Mon, Jun 12, 2023 at 02:04:19PM -0700, Vishal Moola (Oracle) wrote: > Part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents. Also cleans up some spacing issues. > > Signed-off-by: Vishal Moola (Oracle) > Reviewed-by: Geert Uytterhoeven > Acked-by: John P

Re: [PATCH v4 29/34] riscv: Convert alloc_{pmd, pte}_late() to use ptdescs

On Mon, Jun 12, 2023 at 02:04:18PM -0700, Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert >

Re: [PATCH v4 28/34] openrisc: Convert __pte_free_tlb() to use ptdescs

On Mon, Jun 12, 2023 at 02:04:17PM -0700, Vishal Moola (Oracle) wrote: > Part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > arch/openrisc/include/asm/pgalloc.h | 8 ---

Re: [PATCH v4 27/34] nios2: Convert __pte_free_tlb() to use ptdescs

On Mon, Jun 12, 2023 at 02:04:16PM -0700, Vishal Moola (Oracle) wrote: > Part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > arch/nios2/include/asm/pgalloc.h | 8 >

Re: [PATCH v4 26/34] mips: Convert various functions to use ptdescs

On Mon, Jun 12, 2023 at 02:04:15PM -0700, Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert >

Re: [PATCH v4 25/34] m68k: Convert various functions to use ptdescs

On Mon, Jun 12, 2023 at 02:04:14PM -0700, Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert >

Re: [PATCH v4 24/34] loongarch: Convert various functions to use ptdescs

On Mon, Jun 12, 2023 at 02:04:13PM -0700, Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert >

Re: [PATCH v4 23/34] hexagon: Convert __pte_free_tlb() to use ptdescs

On Mon, Jun 12, 2023 at 02:04:12PM -0700, Vishal Moola (Oracle) wrote: > Part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > arch/hexagon/include/asm/pgalloc.h | 8

Re: [PATCH v4 22/34] csky: Convert __pte_free_tlb() to use ptdescs

On Mon, Jun 12, 2023 at 02:04:11PM -0700, Vishal Moola (Oracle) wrote: > Part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents. > > Signed-off-by: Vishal Moola (Oracle) > Acked-by: Guo Ren Acked-by: Mike Rapoport (IBM) > --- > arch/csky/include/asm/pgal

Re: [PATCH v4 21/34] arm64: Convert various functions to use ptdescs

On Mon, Jun 12, 2023 at 02:04:10PM -0700, Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM)

Re: [PATCH v4 20/34] arm: Convert various functions to use ptdescs

On Mon, Jun 12, 2023 at 02:04:09PM -0700, Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > late_alloc() also uses the __get_free_pages() helper function. Convert

Re: [PATCH v4 19/34] pgalloc: Convert various functions to use ptdescs

On Mon, Jun 12, 2023 at 02:04:08PM -0700, Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert >

Re: [PATCH v4 18/34] mm: Remove page table members from struct page

On Mon, Jun 12, 2023 at 02:04:07PM -0700, Vishal Moola (Oracle) wrote: > The page table members are now split out into their own ptdesc struct. > Remove them from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm_types.h | 14

Re: [PATCH v4 17/34] s390: Convert various pgalloc functions to use ptdescs

On Mon, Jun 12, 2023 at 02:04:06PM -0700, Vishal Moola (Oracle) wrote: > As part of the conversions to replace pgtable constructor/destructors with > ptdesc equivalents, convert various page table functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert >

Re: [PATCH v4 16/34] s390: Convert various gmap functions to use ptdescs

On Mon, Jun 12, 2023 at 02:04:05PM -0700, Vishal Moola (Oracle) wrote: > In order to split struct ptdesc from struct page, convert various > functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert > these to use pagetable_alloc() and ptdesc_address() inst

Re: [PATCH v4 15/34] x86: Convert various functions to use ptdescs

On Mon, Jun 12, 2023 at 02:04:04PM -0700, Vishal Moola (Oracle) wrote: > In order to split struct ptdesc from struct page, convert various > functions to use ptdescs. > > Some of the functions use the *get*page*() helper functions. Convert Nit: *get_free_page*() > these

Re: [PATCH v4 14/34] powerpc: Convert various functions to use ptdescs

On Mon, Jun 12, 2023 at 02:04:03PM -0700, Vishal Moola (Oracle) wrote: > In order to split struct ptdesc from struct page, convert various > functions to use ptdescs. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > arch/powerpc/mm/book3s64/mmu_context.c | 10 +++

Re: [PATCH v4 13/34] mm: Create ptdesc equivalents for pgtable_{pte,pmd}_page_{ctor,dtor}

On Mon, Jun 12, 2023 at 02:04:02PM -0700, Vishal Moola (Oracle) wrote: > Creates pagetable_pte_ctor(), pagetable_pmd_ctor(), pagetable_pte_dtor(), > and pagetable_pmd_dtor() and make the original pgtable > constructor/destructors wrappers. Nit: either "creates ... makes" or "create ... make" I lik

Re: [PATCH v4 12/34] mm: Convert ptlock_free() to use ptdescs

On Mon, Jun 12, 2023 at 02:04:01PM -0700, Vishal Moola (Oracle) wrote: > This removes some direct accesses to struct page, working towards > splitting out struct ptdesc from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm.h | 10 +++

Re: [PATCH v4 11/34] mm: Convert pmd_ptlock_free() to use ptdescs

On Mon, Jun 12, 2023 at 02:04:00PM -0700, Vishal Moola (Oracle) wrote: > This removes some direct accesses to struct page, working towards > splitting out struct ptdesc from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm.h | 10 +++

Re: [PATCH v4 10/34] mm: Convert ptlock_init() to use ptdescs

On Mon, Jun 12, 2023 at 02:03:59PM -0700, Vishal Moola (Oracle) wrote: > This removes some direct accesses to struct page, working towards > splitting out struct ptdesc from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm.h | 14 +++

Re: [PATCH v4 09/34] mm: Convert pmd_ptlock_init() to use ptdescs

On Mon, Jun 12, 2023 at 02:03:58PM -0700, Vishal Moola (Oracle) wrote: > This removes some direct accesses to struct page, working towards > splitting out struct ptdesc from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm.h | 10 +++

Re: [PATCH v4 08/34] mm: Convert ptlock_ptr() to use ptdescs

On Mon, Jun 12, 2023 at 02:03:57PM -0700, Vishal Moola (Oracle) wrote: > This removes some direct accesses to struct page, working towards > splitting out struct ptdesc from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > arch/x86/xen/mmu_pv.c | 2

Re: [PATCH v4 07/34] mm: Convert ptlock_alloc() to use ptdescs

On Mon, Jun 12, 2023 at 02:03:56PM -0700, Vishal Moola (Oracle) wrote: > This removes some direct accesses to struct page, working towards > splitting out struct ptdesc from struct page. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm.h | 6 +++-

Re: [PATCH v4 06/34] mm: Convert pmd_pgtable_page() to pmd_ptdesc()

On Mon, Jun 12, 2023 at 02:03:55PM -0700, Vishal Moola (Oracle) wrote: > Converts pmd_pgtable_page() to pmd_ptdesc() and all its callers. This > removes some direct accesses to struct page, working towards splitting > out struct ptdesc from struct page. > > Signed-off-by: Vishal Moola (Oracle) A

Re: [PATCH v4 05/34] mm: add utility functions for ptdesc

On Mon, Jun 12, 2023 at 02:03:54PM -0700, Vishal Moola (Oracle) wrote: > Introduce utility functions setting the foundation for ptdescs. These > will also assist in the splitting out of ptdesc from struct page. > > Functions that focus on the descriptor are prefixed with ptdesc_* while > functions

Re: [PATCH v4 04/34] pgtable: Create struct ptdesc

On Mon, Jun 12, 2023 at 02:03:53PM -0700, Vishal Moola (Oracle) wrote: > Currently, page table information is stored within struct page. As part > of simplifying struct page, create struct ptdesc for page table > information. > > Signed-off-by: Vishal Moola (Oracle) Acked-by: Mike Rapoport (IBM)

Re: [PATCH v4 03/34] s390: Use pt_frag_refcount for pagetables

On Mon, Jun 12, 2023 at 02:03:52PM -0700, Vishal Moola (Oracle) wrote: > s390 currently uses _refcount to identify fragmented page tables. > The page table struct already has a member pt_frag_refcount used by > powerpc, so have s390 use that instead of the _refcount field as well. > This improves t

Re: [PATCH v4 02/34] s390: Use _pt_s390_gaddr for gmap address tracking

On Mon, Jun 12, 2023 at 02:03:51PM -0700, Vishal Moola (Oracle) wrote: > s390 uses page->index to keep track of page tables for the guest address > space. In an attempt to consolidate the usage of page fields in s390, > replace _pt_pad_2 with _pt_s390_gaddr to replace page->index in gmap. > > This

Re: [PATCH v4 01/34] mm: Add PAGE_TYPE_OP folio functions

On Mon, Jun 12, 2023 at 02:03:50PM -0700, Vishal Moola (Oracle) wrote: > No folio equivalents for page type operations have been defined, so > define them for later folio conversions. > > Also changes the Page##uname macros to take in const struct page* since > we only read the memory here. > > S

Re: [patch 02/17] x86/cpu: Switch to arch_cpu_finalize_init()

On Wed, Jun 14, 2023 at 11:53:50AM +0200, Thomas Gleixner wrote: > That's the wrong order. mitigations must come before the smt > update. Thanks to Boris for spotting it. Right, with that fixed the ordering looks good now. Reviewed-by: Borislav Petkov (AMD) -- Regards/Gruss, Boris. https:

Re: [patch 02/17] x86/cpu: Switch to arch_cpu_finalize_init()

On Wed, Jun 14 2023 at 01:39, Thomas Gleixner wrote: > + /* > + * identify_boot_cpu() initialized SMT support information, let the > + * core code know. > + */ > + cpu_smt_check_topology(); > + > + if (!IS_ENABLED(CONFIG_SMP)) { > + pr_info("CPU: "); > +

Re: [patch 17/17] x86/fpu: Move FPU initialization into arch_cpu_finalize_init()

On Tue, Jun 13 2023 at 22:03, Chang S. Bae wrote: > On 6/13/2023 4:39 PM, Thomas Gleixner wrote: >> >> @@ -2396,6 +2393,13 @@ void __init arch_cpu_finalize_init(void) >> '0' + (boot_cpu_data.x86 > 6 ? 6 : boot_cpu_data.x86); >> } >> >> +/* >> + * Must be bef

Re: [PATCH v4 27/34] nios2: Convert __pte_free_tlb() to use ptdescs

Hi Dinh, On Wed, Jun 14, 2023 at 12:17 AM Dinh Nguyen wrote: > On 6/12/23 16:04, Vishal Moola (Oracle) wrote: > > Part of the conversions to replace pgtable constructor/destructors with > > ptdesc equivalents. > > > > Signed-off-by: Vishal Moola (Oracle) > > --- > > arch/nios2/include/asm/pgal

Re: [patch 01/17] init: Provide arch_cpu_finalize_init()

Just typos: On Wed, Jun 14, 2023 at 01:39:22AM +0200, Thomas Gleixner wrote: > check_bugs() has become a dump ground for all sorts of activities to "dumping ground" > finalize the CPU initialization before running the rest of the init code. > > Most are empty, a few do actual bug checks, some d

Re: [patch 06/17] m68k/cpu: Switch to arch_cpu_finalize_init()

On Wed, Jun 14, 2023 at 1:39 AM Thomas Gleixner wrote: > check_bugs() is about to be phased out. Switch over to the new > arch_cpu_finalize_init() implementation. > > No functional change. > > Signed-off-by: Thomas Gleixner Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s,