[PATCH] [8/2many] MAINTAINERS - 53C700 AND 53C700-66 SCSI DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 1275844..ad55112 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -133,6 +133,7 @@ P: James E.J. Bottomley M: [EMAIL PROTECTED] L: linux-scsi@vger.kern

[PATCH] [20/2many] MAINTAINERS - DPT_I2O SCSI RAID DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 71e09b7..7d58f6b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -232,6 +232,8 @@ M: [EMAIL PROTECTED] L: linux-scsi@vger.kernel.org W: http://www.adapt

[PATCH] [21/2many] MAINTAINERS - AACRAID SCSI RAID DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 7d58f6b..1162fb7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -241,6 +241,7 @@ M: [EMAIL PROTECTED] L: linux-scsi@vger.kernel.org W: http://www.adapt

[PATCH] [35/2many] MAINTAINERS - AHA152X SCSI DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index c35092f..b6827c1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -343,9 +343,11 @@ F: drivers/char/agp/ AHA152X SCSI DRIVER P: Juergen E. Fischer -M: J

[PATCH] [19/2many] MAINTAINERS - IPS SCSI RAID DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 141b08a..71e09b7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -224,6 +224,7 @@ M: [EMAIL PROTECTED] L: linux-scsi@vger.kernel.org W: http://www.adapt

[PATCH] [115/2many] MAINTAINERS - BSG (block layer generic sg v4 driver)

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 0ee8069..4ad8cd5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1118,6 +1118,8 @@ P:FUJITA Tomonori M: [EMAIL PROTECTED] L: linu

[PATCH] [167/2many] MAINTAINERS - EATA ISA/EISA/PCI SCSI DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index a8b11ba..144c052 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1626,6 +1626,7 @@ P:Dario Ballabio M: [EMAIL PROTECTED] L: linux-scsi@vger.kern

[PATCH] [182/2many] MAINTAINERS - EMULEX LPFC FC SCSI DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index d5bceb3..6da519c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1759,6 +1759,7 @@ M:[EMAIL PROTECTED] L: linux-scsi@vger.kernel.org W:

[PATCH] [205/2many] MAINTAINERS - GDT SCSI DISK ARRAY CONTROLLER DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 770b0d8..6597718 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1961,6 +1961,7 @@ M:[EMAIL PROTECTED] L: linux-scsi@vger.kernel.org W: http://w

[PATCH] [204/2many] MAINTAINERS - FUTURE DOMAIN TMC-16x0 SCSI DRIVER (16-bit)

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 3bea26f..770b0d8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1952,6 +1952,8 @@ P:Rik Faith M: [EMAIL PROTECTED] L: linux-scsi@vger.kernel.

[PATCH] [284/2many] MAINTAINERS - LASI 53c700 driver for PARISC

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 5c4d564..f8a3640 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2731,6 +2731,8 @@ P:James E.J. Bottomley M: [EMAIL PROTECTED] L: linu

[PATCH] [303/2many] MAINTAINERS - LSILOGIC/SYMBIOS/NCR 53C8XX and 53C1010 PCI-SCSI drivers

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 0046cbd..c90c64d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2909,6 +2909,7 @@ P:Matthew Wilcox M: [EMAIL PROTECTED] L: linux-scsi@vger.kern

[PATCH] [302/2many] MAINTAINERS - LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 8ae4d49..0046cbd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2902,6 +2902,7 @@ L:[EMAIL PROTECTED] L: linux-scsi@vger.kernel.org W:

[PATCH] [332/2many] MAINTAINERS - NCR DUAL 700 SCSI DRIVER (MICROCHANNEL)

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index e372aeb..493de7a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3177,6 +3177,7 @@ P:James E.J. Bottomley M: [EMAIL PROTECTED] L: linu

[PATCH] [358/2many] MAINTAINERS - ONSTREAM SCSI TAPE DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 17970b0..89a586a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3441,6 +3441,8 @@ M:[EMAIL PROTECTED] L: [EMAIL PROTECTED] L: linu

[PATCH] [418/2many] MAINTAINERS - SCSI CDROM DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index c08c8af..d7a1c74 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3981,6 +3981,7 @@ M:[EMAIL PROTECTED] L: linux-scsi@vger.kernel.org W:

[PATCH] [419/2many] MAINTAINERS - SCSI SG DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index d7a1c74..c156f9f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3989,6 +3989,8 @@ M:[EMAIL PROTECTED] L: linux-scsi@vger.kernel.org W:

[PATCH] [420/2many] MAINTAINERS - SCSI SUBSYSTEM

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index c156f9f..c4d29d9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3998,6 +3998,8 @@ M:[EMAIL PROTECTED] L: linux-scsi@vger.kernel.org T: git kern

[PATCH] [421/2many] MAINTAINERS - SCSI TAPE DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index c4d29d9..2e15975 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4006,6 +4006,7 @@ P:Kai Mäkisara M: [EMAIL PROTECTED] L: linux-scsi@vger.kern

[PATCH] [486/2many] MAINTAINERS - U14-34F SCSI DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 374ee9b..e28c8d4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4609,6 +4609,7 @@ P:Dario Ballabio M: [EMAIL PROTECTED] L: linux-scsi@vger.kern

[PATCH] [541/2many] MAINTAINERS - WD7000 SCSI DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index d8ee850..4172b36 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5112,12 +5112,15 @@ M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] W: http://www.hpl.

[PATCH] [166/2many] MAINTAINERS - EATA-DMA SCSI DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 8c79559..a8b11ba 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1616,8 +1616,10 @@ F: include/linux/dvb/ EATA-DMA SCSI DRIVER P: Michael Neuf

[PATCH] [168/2many] MAINTAINERS - EATA-PIO SCSI DRIVER

Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 144c052..45ce2d4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1631,8 +1631,10 @@ F: drivers/scsi/eata* EATA-PIO SCSI DRIVER P: Michael Neuf

[PATCH 00/12] treewide: Use DECLARE_BITMAP

Use the standard method to declare a bitmap array. Joe Perches (12): ARM: mach-imx: iomux-imx31: Use DECLARE_BITMAP dmaengine: rcar-dmac: Use DECLARE_BITMAP drm/amdkfd: Use DECLARE_BITMAP drm/radeon: Use DECLARE_BITMAP IB/ehca: Use DECLARE_BITMAP bcache: Use DECLARE_BITMAP

RE: [BUG] hpsa: Controller lockup detected: 0x00150028

No, the problem here (iirc) actually dealt with buffers in the firmware. Don or Mark, agree? Joe -Original Message- From: Peter Zijlstra [mailto:pet...@infradead.org] Sent: Friday, May 22, 2015 11:40 AM To: Tomas Henzl Cc: Oelke, Mark; don.br...@pmcs.com; ISS StorageDev; storage

Re: [PATCH v2 1/3] megaraid : use dev_printk when possible

On Mon, 2015-06-01 at 10:40 -0500, Bjorn Helgaas wrote: > Use dev_printk() when possible to make messages more useful. [] > diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c [] > @@ -268,7 +268,7 @@ mega_query_adapter(adapter_t *adapter) > raw_mbox[2] = NC_SUBOP_PRODUCT_I

Re: [PATCH v2 1/3] megaraid : use dev_printk when possible

On Mon, 2015-06-01 at 11:40 -0500, Bjorn Helgaas wrote: > On Mon, Jun 1, 2015 at 11:10 AM, Joe Perches wrote: > > On Mon, 2015-06-01 at 10:40 -0500, Bjorn Helgaas wrote: > >> Use dev_printk() when possible to make messages more useful. > > [] > >> diff --git a/

RE: bisected regression: qla2xxx endianness on sparc64

Meelis, Yes, please revert that patch (it should never have deleted the calls to __constant_cpu_to_le16 (those fields are all LE in the HW/nvram)). -Joe -Original Message- From: mr...@math.ut.ee [mailto:mr...@math.ut.ee] On Behalf Of Meelis Roos Sent: Wednesday, June 03, 2015 1:21 AM

Re: [PATCH 17/20] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API

e_singlethread_workqueue( > ioc->firmware_event_name); > +#endif Hi Sreekanth, I think the upstream version of this code can safely assume alloc_ordered_workqueue is defined, no? Regards, -- Joe -- To unsubscribe from this list: send the line "unsubscribe linux-sc

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

by the patch insufficient? That loop block sets memap_sz when it finds an IORESOURCE_MEM so that it only sets ioc->chip once. I wonder if the fix might be simpler if the existing ioc->chip check relocated entirely to where you put it (maybe also pulling the entire error text onto one line for easier grepping). Regards, -- Joe -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 17/20 v1] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API

apply __WQ_ORDERED to create_singlethread_workqueue() ? (3.17+) In upstream, this change looks cosmetic (unless Tejun has a preference for one over the other), but maybe converting to alloc_ordered_workqueue keeps your in house version in closer sync? Thanks, -- Joe -- To unsubscribe from t

Re: [PATCH 17/20 v1] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API

On 06/18/2015 09:06 AM, Sreekanth Reddy wrote: > On Thu, Jun 18, 2015 at 5:40 PM, Joe Lawrence > wrote: >> On 06/16/2015 01:37 AM, Sreekanth Reddy wrote: >>> Created a thread using alloc_ordered_workqueue() API in order to process >>> the works from firmware Work

Re: OOPS: unplugging western digital passport drive

Hi Alan -- last I heard from Stan on this bug was April 14 -- he was on "long holidays" at that time :) -- Joe On 06/17/2015 03:09 PM, Alan Stern wrote: > Joe or Stanisﾅ^ﾂaw: > > I never heard anything back about this. Does the patch fix the crash? > > Alan Stern &g

Re: [PATCH] mpt2sas: Abort initialization if no memory I/O resources, detected

On 06/21/2015 02:46 PM, Timothy Pearson wrote: > On 06/16/2015 01:49 PM, Timothy Pearson wrote: >> On 06/16/2015 12:42 PM, Joe Lawrence wrote: >>> On 06/16/2015 12:28 PM, Timothy Pearson wrote: >>>> On 06/12/2015 05:05 PM, Timothy Pearson wrote: >>>>>

Re: [PATCH] [RESEND] qla2xxx: prevent board_disable from running during EEH

de Oliveira " tag below Thadeu's since the patch has passed through you. Re: the patch -- I did some work last year to harden board_disable against various races, but without having EEH hardware available, I was uncertain about EEH behavior. For example: pci_read EEH -> marks chan

Re: [PATCH 1/2] mpt2sas: Refcount sas_device objects and fix unsafe list usage

} > + > + sas_device_put(sas_device); > return 0; > } Hi Calvin, Any reason why this sas_device_put is placed outside the sas_device lock? Most other instances in this patch were called just before unlocking. BTW I attempted testing, but needed to port to mpt3 and ended up with

[PATCH] scsi: pmcraid: trivial typo in printk

Trivial typo fixes: o \b should be \n o coalesce format to avoid excess spaces Signed-off-by: Joe Perches --- And another here: drivers/scsi/pmcraid.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index ed31d8c

[TRIVIAL PATCH] block: Correct misuses of 0x%

Correct misuse of 0x%d in logging messages. Signed-off-by: Joe Perches --- drivers/block/DAC960.c | 4 ++-- drivers/block/cciss.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c index 811e11c..d9b32f2 100644 --- a/drivers

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%

On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: > > On Aug 3, 2015, at 04:25, Joe Perches wrote: > > > > Correct misuse of 0x%d in logging messages. > > [] > why not use like this : dev_dbg(&h->pdev->dev, " Max outstanding > commands = %#x\

Re: [TRIVIAL PATCH] block: Correct misuses of 0x%

On Tue, 2015-08-04 at 10:19 +0800, yalin wang wrote: > Ping ? > > On Aug 3, 2015, at 16:56, yalin wang wrote: > > > > > >> On Aug 3, 2015, at 16:03, Joe Perches wrote: > >> > >> On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote: >

Re: [PATCH] sd: assign appropriate log level

On Mon, 2016-10-17 at 09:51 -0700, David Singleton wrote: > From: Shikhar Dogra > > Reduce chatter on console for usb hotplug. > KERN_ERR is too high severity for these messages, moving them > to KERN_WARNING Perhaps KERN_NOTICE is more appropriate. That's the level for most of these sd_first_pr

Re: [PATCH] scsi/qla2xxx: label endian-ness for many fields

On Fri, 2016-12-09 at 22:45 +0200, Michael S. Tsirkin wrote: > This adds endian-ness labels for lots of qla structs. > Doing this cuts down number of sparse warnings from ~1700 to ~1400. > Will help find and resolve some of real issues down the road. > > Signed-off-by: Michael S. Tsirkin > > ---

Re: [PATCH v1 12/12] scsi: ufs: Improve fatal error logs

On Mon, 2016-12-12 at 16:56 -0800, Subhash Jadavani wrote: > Errors such as UIC error, illegal OCS values, and others may require > more information for debugging. Such information could be hibern8 events, > events sequences, recoverable errors, error history, and more. [] > diff --git a/drivers/sc

Re: [PATCH v2 1/4] mpt3sas: Added print to notify cable running at a degraded speed.

On Fri, 2017-01-20 at 20:12 +0530, Chaitra P B wrote: > Driver processes the event MPI26_EVENT_ACTIVE_CABLE_DEGRADED > when a cable is present and is running at a degraded speed > (below the SAS3 12 Gb/s rate). Prints added > to inform the user that the cable is not running at > optimal speed. [] >

Re: [PATCH v2 1/4] mpt3sas: Added print to notify cable running at a degraded speed.

On Fri, 2017-01-20 at 09:55 -0800, Joe Perches wrote: > I believe MPT3SAS_FMT is unnecessary obfuscation and > it should just be replaced by "%s: " everywhere. Here's a trivial command that could be used one day: $ git grep --name-only MPT3SAS_FMT -- "*.c" |

Re: [PATCH] net-next: treewide use is_vlan_dev() helper function.

On Fri, 2017-02-03 at 22:26 -0600, Parav Pandit wrote: > This patch makes use of is_vlan_dev() function instead of flag > comparison which is exactly done by is_vlan_dev() helper function. Thanks. btw: after applying this patch, there is one left $ git grep -E -n "&\s*IFF_802_1Q_VLAN\b" -- "*.c

Re: [RFC 19/19] checkpatch: warn for use of old PCI pool API

On Wed, 2017-02-08 at 19:55 +0100, Peter Senna Tschudin wrote: > On Wed, Feb 08, 2017 at 05:34:57PM +0100, Romain Perier wrote: > > pci_pool_*() functions should be replaced by the corresponding functions > > in the DMA pool API. This adds support to check for use of these pci > > functions and dis

[PATCH 29/35] drivers/scsi: Convert remaining use of pr_warning to pr_warn

To enable eventual removal of pr_warning This makes pr_warn use consistent for drivers/scsi Prior to this patch, there was 1 use of pr_warning and 96 uses of pr_warn in drivers/scsi Signed-off-by: Joe Perches --- drivers/scsi/a3000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. Miscellanea: o Coalesce formats and realign arguments Some files not compiled - no cross-compilers Joe Perches (35): alpha: Convert remaining uses of pr_warning to pr_warn ARM: ep93xx: Convert remaining uses of pr_warning

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > > There are ~4300 uses of pr_warn and ~250 uses of the older > > pr_warning in the kernel source tree. > > > > Make the use of pr_warn consistent across all

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

On Thu, 2017-02-23 at 17:41 +, Emil Velikov wrote: > On 23 February 2017 at 17:18, Joe Perches wrote: > > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: > > > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > > > > There are ~4300 uses of pr_w

Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API

t; > functions and display a warning when it is the case. > > > > I guess Joe Perches did sent some comments for this one, did you address > them? > Reviewed-by: Peter Senna Tschudin > > Signed-off-by: Romain Perier > > --- > > scripts/checkpatch.pl | 9 +

Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API

s > > > in the DMA pool API. This adds support to check for use of these pci > > > functions and display a warning when it is the case. > > > > > > > I guess Joe Perches did sent some comments for this one, did you address > > them? > > See the

Re: [PATCH v3 20/20] checkpatch: warn for use of old PCI pool API

On Mon, 2017-02-27 at 13:52 +0100, Romain Perier wrote: > > I also wonder if you've in fact converted all of the > > pci_pool struct and function uses why a new checkpatch > > test is needed at all. > > That's just to avoid futures mistakes/uses. When all instances and macro definitions are remo

Re: [PATCH v4 00/19] Replace PCI pool by DMA pool API

On Wed, 2017-03-01 at 16:55 +0100, Romain Perier wrote: > support to warn about this old API in checkpath.pl checkpatch This part isn't true anymore, but it seems sensible enough, thanks.

[PATCH] qla2xxx: Fix ql_dump_buffer

/qla2xxx/qla_dbg.o.new 39164 0 0 3916498fc drivers/scsi/qla2xxx/qla_dbg.o.old Signed-off-by: Joe Perches --- drivers/scsi/qla2xxx/qla_dbg.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx

[PATCH] scsi: qedf: Fix defective logging format and argument mismatches

Add __printf compiler verification of format and arguments. Fix fallout. Signed-off-by: Joe Perches --- drivers/scsi/qedf/qedf_dbg.h | 13 - drivers/scsi/qedf/qedf_fip.c | 2 +- drivers/scsi/qedf/qedf_io.c | 4 ++-- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a

Re: [PATCH] scsi: qedf: Fix defective logging format and argument mismatches

On Tue, 2017-03-07 at 02:03 +0800, kbuild test robot wrote: > Hi Joe, Hi again Fengguang's robot. > [auto build test WARNING on scsi/for-next] > [also build test WARNING on v4.11-rc1 next-20170306] > [if your patch is applied to the wrong git tree, please drop us a note to &

[PATCH] scsi: qedf: Use vsprintf extension %pad

Using %llx for a dma_addr_t can lead to format/argument mismatches. Use %pad and the address of the dma_addr_t instead. Signed-off-by: Joe Perches --- drivers/scsi/qedf/qedf_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers

Re: [PATCH] scsi: qedf: Fix defective logging format and argument mismatches

On Mon, 2017-03-06 at 10:17 -0800, Joe Perches wrote: > On Tue, 2017-03-07 at 02:03 +0800, kbuild test robot wrote: > > Hi Joe, > > Hi again Fengguang's robot. Rehi. OK, it is a new message. Patch sent.

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > > > We should prefer `const struct pci_device_id` over > > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding styl

Re: [PATCH 5/6] qla2xxx: Prevent removal and board_disable race

On Fri, 25 Jul 2014 11:23:02 -0400 Chad Dupuis wrote: > > > On Wed, 18 Jun 2014, Joe Lawrence wrote: > > > Introduce mutual exclusion between the qla2xxx_remove_one PCI driver > > callback and qla2x00_disable_board_on_pci_error, which is scheduled as &

RE: Bad tag value in scsi-mq.4

nce either way. -Original Message- From: h...@infradead.org [mailto:h...@infradead.org] Sent: Tuesday, August 05, 2014 2:28 PM To: Handzik, Joe Cc: h...@infradead.org; linux-scsi@vger.kernel.org; scame...@beardog.cce.hp.com; Scales, Webb; Teel, Scott Stacy Subject: Re: Bad tag value in

Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

On Tue, 2014-08-12 at 14:54 +0530, Sreekanth Reddy wrote: > So, the proposal is to allocate memory independently for each > Reply Queue and pass down all of the addresses to the firmware. > Then the firmware will just take each address and program the value > into the correct register. trivial not

RE: Bad tag value in scsi-mq.4

?) or found some strange bug. I'm not too concerned, since other members of the team haven't had problems and have been using the SCSI mq code more than I have. Sorry for the false alarm! Joe -Original Message- From: h...@infradead.org [mailto:h...@infradead.org] Sent: Tuesday,

Re: [PATCH 0/6] qla2xxx device removal fixups

On Wed, 18 Jun 2014 10:02:13 -0400 Joe Lawrence wrote: > Hi Chad, Giri, et al. > > Stratus has been testing the upstream qla2xxx driver against surprise > device removal and has found a few minor issues along the way. With > this patchset, results have been good. Althoug

[PATCH RESEND 0/6] qla2xxx device removal fixups

Resending patchset against scsi-queue/drivers-for-3.18 with Acked-by and Cc stable annotations. Joe Lawrence (6): qla2xxx: Fix shost use-after-free on device removal qla2xxx: Use qla2x00_clear_drv_active on probe failure qla2xxx: Collect PCI register checks and board_disable scheduling

[PATCH RESEND 1/6] qla2xxx: Fix shost use-after-free on device removal

Cc: sta...@vger.kernel.org # 3.14, 3.15, 3.16 Signed-off-by: Joe Lawrence Acked-by: Chad Dupuis --- drivers/scsi/qla2xxx/qla_os.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index be9698d..8252

[PATCH RESEND 2/6] qla2xxx: Use qla2x00_clear_drv_active on probe failure

Take advantage of commit fe1b806f4f71 ("qla2xxx: Refactor shutdown code so some functionality can be reused") to remove an inlined copy of qla2x00_clear_drv_active in the driver's probe hardware error path. Signed-off-by: Joe Lawrence Acked-by: Chad Dupuis --- drivers/scsi/q

[PATCH RESEND 5/6] qla2xxx: Prevent removal and board_disable race

PCI device enable count check in qla2x00_remove_one to determine if board_disable has occured. The original purpose of this check was unnecessary since the driver remove function wasn't called when the probe fails. Signed-off-by: Joe Lawrence Acked-by: Chad Dupuis --- drivers/scsi/ql

[PATCH RESEND 4/6] qla2xxx: Schedule board_disable only once

There are various callers of qla2x00_check_reg{32,16}_for_disconnect that may schedule board removal on PCI-disconnect. Test-and-set a dedicated flag before scheduling board_disable so it is invoked only once. Signed-off-by: Joe Lawrence Acked-by: Chad Dupuis --- drivers/scsi/qla2xxx/qla_def.h

[PATCH RESEND 3/6] qla2xxx: Collect PCI register checks and board_disable scheduling

Add an uint16_t variant of qla2x00_check_reg_for_disconnect and use these routines to check and schedule a PCI-disconnected board from a centralized place. Signed-off-by: Joe Lawrence Acked-by: Chad Dupuis --- drivers/scsi/qla2xxx/qla_gbl.h |3 ++- drivers/scsi/qla2xxx/qla_isr.c | 28

[PATCH RESEND 6/6] qla2xxx: Prevent probe and board_disable race

ructure is initialized and more importantly, avoids racing qla2x00_probe_one. Signed-off-by: Joe Lawrence Acked-by: Chad Dupuis --- drivers/scsi/qla2xxx/qla_def.h |1 + drivers/scsi/qla2xxx/qla_isr.c |3 ++- drivers/scsi/qla2xxx/qla_os.c |2 ++ 3 files changed, 5 insertions(+), 1 deletio

[PATCH] mpt2sas: remove duplicate disable_discovery MODULE_PARAM

The disable_discovery module parameter is declared and only used by mpt2sas_scsih.c. Remove the extra copy in mpt2sas_base.c. Signed-off-by: Joe Lawrence --- drivers/scsi/mpt2sas/mpt2sas_base.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b

[PATCH] scsi: sas_ata: change ata__printk routines to return void

The return value is not used by callers of this function so change the function to return void. Signed-off-by: Joe Perches --- This change is associated to a desire to eventually change printk to return void. drivers/scsi/libsas/sas_ata.c | 11 --- 1 file changed, 4 insertions(+), 7

Re: [PATCH 20/35] qla2xxx: Unload of qla2xxx driver crashes the machine.

r stable as the bug was introduced by fe1b806f4f71 ("qla2xxx: Refactor shutdown code so some functionality can be reused") in previous releases. Regards, -- Joe [1] http://thread.gmane.org/gmane.linux.scsi/93859 [2] http://git.infradead.org/users/hch/

Re: [PATCH 31/35] qla2xxx: Disable PCI device in shutdown handler.

ts for a given ha */ Hi Saurav, Just curious if there were any bug report instances to go along with this patch? (Or a short explanation of the race.) Thanks, -- Joe -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 31/35] qla2xxx: Disable PCI device in shutdown handler.

On Wed, 24 Sep 2014 11:37:55 -0400 Chad Dupuis wrote: > > > On Wed, 24 Sep 2014, Joe Lawrence wrote: > > > On Wed, 24 Sep 2014 03:08:34 -0400 > > Saurav Kashyap wrote: > > > >> From: Chad Dupuis > >> > >> Disable the PCI device duri

Re: [PATCH] cxgbit: fix dma_addr_t printk format

On Sat, 2016-03-05 at 01:04 +0100, Arnd Bergmann wrote: > The newly added driver prints a dma_addr_t using the %llx format string, > but that is wrong on most 32-bit architectures: > > drivers/target/iscsi/cxgbit/cxgbit_ddp.c: In function 'cxgbit_dump_sgl': > drivers/target/iscsi/cxgbit/cxgbit_ddp

Re: [PATCH] cxgbit: fix dma_addr_t printk format

On Sat, 2016-03-05 at 01:34 +0100, Arnd Bergmann wrote: > On Friday 04 March 2016 16:25:07 Joe Perches wrote: > > > diff --git a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c > > > b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c [] > > > @@ -179,7 +179,7 @@ cxgbit_du

[PATCH] mpt3sas - remove unused fw_event_work delayed_work

Remove it and update _scsih_fw_event_cleanup_queue accordingly. Signed-off-by: Joe Lawrence --- I think this goes all the way back to the introduction of the mpt3sas driver. The previous generation mpt2sas driver uses delayed_work, so perhaps it was simply copied and pasted into the mpt3sas but never upd

Re: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

On 04/01/2016 02:51 PM, Ewan D. Milne wrote: > On Fri, 2016-04-01 at 13:56 -0400, Joe Lawrence wrote: >> @@ -2804,12 +2803,12 @@ _scsih_fw_event_cleanup_queue(struct MPT3SAS_ADAPTER >> *ioc) >> /* >> * Wait on the fw_event to comple

Re: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

t3 version? If that is interesting, that info could be added to v2 commit message as well. Thanks, -- Joe On 04/11/2016 07:13 AM, Chaitra Basappa wrote: Hi, Please consider this patch as Ack-by: Chaitra P B Thanks, Chaitra -Original Message- From: Sathya Prakash [mailto:s

[PATCH v2] mpt3sas - remove unused fw_event_work elements

es: 146b16c8071f (mpt3sas: Refcount fw_events and fix unsafe list usage) Signed-off-by: Joe Lawrence --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c inde

Re: [PATCH] megaraid_sas: trivial fix, add missing space in dev_err message

On Mon, 2016-04-25 at 22:58 +0100, Colin King wrote: > From: Colin Ian King > > Add a missing space in dev_err message, missed because the string > spans a few lines. This is a dev_notice() not dev_err(). > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c > b/drivers/scsi/megaraid/megara

Re: [PATCH] Fix a bdi reregistration race, v3

able. sd 1:0:0:2: [sds] Write Protect is off sd 1:0:0:2: [sds] Mode Sense: 00 00 00 60 sd 1:0:0:2: [sds] Asking for cache data failed sd 1:0:0:2: [sds] Assuming drive cache: write through Regards, -- Joe -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in t

Re: [PATCH] Fix a bdi reregistration race, v3

On 05/05/2016 04:40 PM, Joe Lawrence wrote: > On 05/05/2016 03:58 PM, Bart Van Assche wrote: >> On 03/28/2016 02:29 PM, Bart Van Assche wrote: >>> Avoid that the sd driver registers a BDI device with a name that >>> is still in use. This patch avoids that the following

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On Tue, 2016-05-24 at 08:52 -0500, Bryant G. Ly wrote: > From: bgly > > This initial commit contains WIP of the IBM VSCSI Target Fabric > Module. It currently supports read/writes, and I have tested > the ability to create a file backstore with the driver and install > RHEL VIA NIM and then boot

Re: [PATCH 3/3] ibmvscsis: clean up functions

On Wed, 2016-05-25 at 09:17 -0500, Bryant G. Ly wrote: > From: bryantly Please use your whole name here and for your sign-off like: From: Bryant G. Ly Signed-off-by: Bryant G. Ly > This patch removes forward declarations and re-organizes the > functions within the driver. This patch also fixe

[PATCH 2/2] mpt3sas - avoid mpt3sas_transport_port_add NULL parent_dev

If _scsih_sas_host_add's call to mpt3sas_config_get_sas_iounit_pg0 fails, ioc->sas_hba.parent_dev may be left uninitialized. A later device probe could invoke mpt3sas_transport_port_add which will call sas_port_alloc_num [scsi_transport_sas] with a NULL parent_dev pointer. Signed-off

[PATCH 1/2] mpt3sas - set num_phys after allocating phy[] space

>sas_hba is left in a dangerous state: all readers of ioc->sas_hba.phy[] do so by indexing it from 0..ioc->sas_hba.num_phys without checking that the space was ever allocated. Modify _scsih_sas_host_add to set ioc->sas_hba.num_phys only after successfully allocating ioc->sas_hba.

[PATCH 0/2] _scsih_sas_host_add early exits can crash system

Note: these changes don't improve or retry adapter initialization, but only try to prevent the system from crashing Joe Lawrence (2): mpt3sas - set num_phys after allocating phy[] space mpt3sas - avoid mpt3sas_transport_port_add NULL parent_dev drivers/scsi/mpt3sas/mpt3sas_scsi

Re: [PATCH] Use the correct size to set block max sectors

dOn Thu, 2016-05-26 at 17:08 -0700, Long Li wrote: > The block sector size should be in unit of 512 bytes, not in bytes. Thanks. The patch subject should use something like: [PATCH] sd: Use the correct size to set block max sectors to show what subsystem is being modified. > diff --git a/drive

[PATCH 0/3] BusLogic: Message logging neatening

If you're going through the trouble to fix this CamelCase stuff and make it work on 64 bit, how about a little more cleanup? Joe Perches (3): BusLogic: Add __printf verification, fix fallout BusLogic: Coalesce formats with multiple string fragments BusLogic: Use more conventional arg

[PATCH 1/3] BusLogic: Add __printf verification, fix fallout

Make format and arguments match. Signed-off-by: Joe Perches --- drivers/scsi/BusLogic.c | 50 - drivers/scsi/BusLogic.h | 1 + 2 files changed, 26 insertions(+), 25 deletions(-) diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c

[PATCH 2/3] BusLogic: Coalesce formats with multiple string fragments

Strings fragments coalesced by the compiler are difficult to grep. Coalesce them instead. Signed-off-by: Joe Perches --- drivers/scsi/BusLogic.c | 66 - 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/scsi/BusLogic.c b

[PATCH 3/3] BusLogic: Use more conventional argument order for logging

Subsystem specific logging messages generally use subsystem_(struct subsystem *, fmt, ...) not subsystem_(fmt, struct subsystem *, ...) Convert to use the more generally used kernel style. Signed-off-by: Joe Perches --- drivers/scsi/BusLogic.c | 304

Re: [PATCH 0/3] BusLogic: Message logging neatening

On Fri, 2013-05-17 at 14:18 -0600, Khalid Aziz wrote: > On Thu, 2013-05-16 at 21:58 -0700, Joe Perches wrote: > > If you're going through the trouble to fix this CamelCase stuff > > and make it work on 64 bit, how about a little more cleanup? > > Sounds good to me.

Re: mpt2sas,mpt3sas watchdog device removal

On Fri, 17 May 2013 09:29:06 -0600 Bjorn Helgaas wrote: > [+cc linux-pci] > > On Wed, May 15, 2013 at 11:29 AM, Joe Lawrence > wrote: > > From 84ac7a35ebd61e84d4254eae78bb967de17254c2 Mon Sep 17 00:00:00 > > 2001 From: Joe Lawrence > > Date: Wed, 15 May 2013 12:5

[PATCH v4] block: handle pointer error from blk_get_request

branch it needs to be based on. It appears to apply cleanly to for-3.10 and for-3.11. Let me know what you prefer. Changes from v3: - Fix memory leak introduced in previous patch versions of sg_scsi_ioctl error path Regards, -- Joe >From 07293e4ce42dfc9a2688fac1ce62a32853348fc3 Mon Sep 17

  1   2   3   4   5   >