Re: [PATCH v2] [SCSI] sg: Fix user memory corruption when SG_IO is interrupted by a signal

2013-08-07 Thread David Milburn
I was able to succesfully test this patch overnight, I had been experimenting with the sg driver setting the BIO_NULL_MAPPED flag in sg_rq_end_io_usercontext for a orphan process which prevented the corruption, but your solution seems much better. Thanks, David -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] [SCSI] sg: Fix user memory corruption when SG_IO is interrupted by a signal

2013-08-07 Thread David Milburn
Roland Dreier wrote: On Wed, Aug 7, 2013 at 7:38 AM, David Milburn wrote: I was able to succesfully test this patch overnight, I had been experimenting with the sg driver setting the BIO_NULL_MAPPED flag in sg_rq_end_io_usercontext for a orphan process which prevented the corruption, but

[PATCH]scsi disk: disk offline prematurely from medium access timeout

2013-08-29 Thread David Jeffery
sense data. Signed-off-by: David Jeffery --- To reproduce using scsi_debug, use SCSI_DEBUG_OPT_TIMEOUT or SCSI_DEBUG_OPT_MAC_TIMEOUT to force an I/O command to timeout. Then, remove the opt value so the I/O will succeed on retry. Perform more I/O as desired. Finally, repeat the process to mak

Re: [PATCH 0/8] IB SRP initiator patches for kernel 3.12

2013-09-09 Thread David Dillow
amp; >dev_loss_tmo < 0) is now rejected as requested by Dave Dillow. > - Fixed a race between transport layer failure handling and device >removal. This issue was reported by Vu Pham. For patches 1-6, Acked-by: David Dillow -- Dave Dillow National Center for Computational Scienc

[PATCH RESEND] sd: disk offlined prematurely from media access timeout

2013-09-24 Thread David Jeffery
sense data. Signed-off-by: David Jeffery --- It can be reproduced using scsi_debug and using SCSI_DEBUG_OPT_MAC_TIMEOUT to force some I/O to timeout once. This small script assumes /dev/sdb as scsi_debug's disk, causes a timeout, completes 2MB of I/O successfully including the timed out I

RE: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-04 Thread David Laight
r on. That would make it less likely that none will be available for devices/drivers that need them but are initialised later. David -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] Remove T4 FCoE support

2015-01-15 Thread David Miller
From: Praveen Madhavan Date: Thu, 15 Jan 2015 19:15:50 +0530 > These patches removes FCoE support for chelsio T4 adapter. > Please apply on net-next since depends on previous commits. Why is it being removed? You have to state this in the commit log messages at a minimum. -- To unsubscribe from

Re: [PATCH v2 0/2] csiostor:Remove T4 FCoE support

2015-01-19 Thread David Miller
From: Praveen Madhavan Date: Fri, 16 Jan 2015 21:30:18 +0530 > We found a subtle issue with FCoE on T4 very late in the game > and decided not to productize FCoE on T4 and therefore there > are no customers that will be impacted by this change. FCoE is > supported on T5 cards. > > Please apply o

Re: [PATCH] csiostor:T5 Firmware fix and cleanup.

2015-01-27 Thread David Miller
From: Praveen Madhavan Date: Tue, 27 Jan 2015 19:46:37 +0530 > This patch fix is to use default firmware configuration files > present in the adapter incase if not available in standard > /lib/firmware/* dir. Additional cleanup is done to reuse flash > related defines from cxgb4 header file. > >

Re: [PATCH] csiostor:Use firmware version from cxgb4/t4fw_version.h

2015-02-04 Thread David Miller
From: Praveen Madhavan Date: Tue, 3 Feb 2015 17:18:26 +0530 > This patch is to use firmware version macros from t4fw_version.h > and also enables 40g T5 adapter. > > Signed-off-by: Praveen Madhavan Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body o

Re: BUG v3.19: reference count warning when removing scsi_debug device

2015-02-18 Thread David Milburn
ate: Fri Jan 23 13:22:47 2015 +1030 scsi: always increment reference count Thanks, David -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Xen-devel] [PATCH] xen-scsiback: some modifications about code comment

2015-02-19 Thread David Vrabel
On 09/02/15 07:08, Juergen Gross wrote: > On 02/07/2015 04:31 AM, Rudy Zhang wrote: >> From: Tao Chen >> >> Signed-off-by: Tao Chen > > Are some white space fixes in comments really worth a patch? No. David -- To unsubscribe from this list: send the line "uns

Re: [Xen-devel] [PATCH] xen-scsiback: use DRV_PFX in the pr macros

2015-03-03 Thread David Vrabel
ack_tpg *tpg; /* translate to */ > + struct scsiback_tpg *tpg; /* translate to */ Please don't make unrelated whitespace changes. David -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.or

Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-04 Thread David Vrabel
lready said you needed to use: #define pr_fmt(fmt) to do this. David -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Xen-devel] [PATCH v4] xen-scsiback: define a pr_fmt macro with xen-pvscsi

2015-03-16 Thread David Vrabel
ad. Applied to devel/for-linus-4.1, thanks. David -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] FCoE support in cxgb4 driver

2015-03-24 Thread David Miller
From: Varun Prakash Date: Tue, 24 Mar 2015 19:14:44 +0530 > This patch series enables FCoE support in cxgb4 driver, it enables > FCOE_CRC and FCOE_MTU net device features. > > This series is created against net-next tree. Series applied, thank you. -- To unsubscribe from this list: send the lin

Re: [PATCH net-next 0/3] cxgb4: add FCoE DDP and RSS

2015-03-31 Thread David Miller
From: Varun Prakash Date: Fri, 27 Mar 2015 20:29:36 +0530 > This patch series enables RSS for FCoE frames and adds > DDP support for FCoE target. Series applied, thanks Varun. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kern

Re: [PATCH net-next 0/3] cxgb4: add FCoE DDP and RSS

2015-03-31 Thread David Miller
From: David Miller Date: Tue, 31 Mar 2015 12:04:13 -0400 (EDT) > From: Varun Prakash > Date: Fri, 27 Mar 2015 20:29:36 +0530 > >> This patch series enables RSS for FCoE frames and adds >> DDP support for FCoE target. > > Series applied, thanks Varun. I have to rev

Re: [PATCH net-next v2 3/4] cxgb4: add DDP support for FCoE target

2015-04-13 Thread David Miller
From: Varun Prakash Date: Mon, 13 Apr 2015 19:34:25 +0530 > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c > b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c > index 6c8a62e..f78d632 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c > +++ b/drivers/net/ethernet/chelsi

Re: [PATCH 04/11] IB/srp: keep processing commands during host removal

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 10:43 +0100, Bart Van Assche wrote: > On 11/26/12 05:44, David Dillow wrote: > > From: Bart Van Assche > > > > Some SCSI upper layer drivers, e.g. sd, issue SCSI commands from > > inside scsi_remove_host() (see also the sd_shutdown() call in >

Re: [PATCH 03/11] IB/srp: don't send anything on a bad QP

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 10:17 +0100, Bart Van Assche wrote: > On 11/26/12 05:44, David Dillow wrote: > > Once we know we have an issue with the QP, there is no point trying to > > send anything else down the pipe. This also allows us to consolidate > > code in the SCSI EH path.

Re: [PATCH 02/11] IB/srp: simplify state tracking

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 10:46 +0100, Bart Van Assche wrote: > On 11/26/12 05:44, David Dillow wrote: > > The state of the target has several conditions that overlap, making it > > easier to model as a bit-field of exceptional conditions rather than an > > enum of all possible

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 23:15 +0400, James Bottomley wrote: > On Mon, 2012-11-26 at 10:50 -0800, Roland Dreier wrote: > > - I think the srp_transport stuff should go through linux-scsi / > > James B. > >instead of my tree, esp. since it's shared with the IBM vscsi stuff > > (I think) > > - I se

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 09:57 +0200, Or Gerlitz wrote: > On Mon, Nov 26, 2012 at 6:44 AM, David Dillow wrote: > > One may also pull this series from github: > > git pull git://github.com/dillow/srp-initiator.git ha-merge-v1 > > Hi Dave, > > The kernel mai

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-29 Thread David Dillow
On Thu, 2012-11-29 at 12:21 -0800, Roland Dreier wrote: > On Mon, Nov 26, 2012 at 8:04 PM, David Dillow wrote: > > We can push it through James's tree if need be, but Bart's code is > > pretty self-contained, and going through the SCSI tree will introduce > > m

[PATCH] scsi: remove device when state is changed to deleted thru sysfs

2012-12-17 Thread David Milburn
20/0x30 [] sysfs_write_file+0xef/0x170 [] vfs_write+0xc8/0x190 [] sys_write+0x5f/0xa0 [] system_call_fastpath+0x16/0x1b ---[ end trace d8c5fd627d86780c ]--- scsi 10:0:0:0: failed to add device: -17 Signed-off-by: David Milburn --- drivers/scsi/scsi_sysfs.c |8 ++-- 1 files changed, 6 inser

Re: [PATCH] scsi: remove device when state is changed to deleted thru sysfs

2012-12-18 Thread David Milburn
Bart Van Assche wrote: On 12/18/12 00:26, David Milburn wrote: diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index ce5224c..6d72abb 100644 --- a/drivers/scsi/scsi_sysfs.c +++ b/drivers/scsi/scsi_sysfs.c @@ -596,7 +596,7 @@ static ssize_t store_state_field(struct device

UAPI: What remains to be pulled: SCSI and FCoE

2012-12-20 Thread David Howells
ists if need be. Merry Christmas! David --- The following changes since commit 752451f01c4567b506bf4343082682dbb8fb30dd: Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux (2012-12-18 16:51:10 -0800) are available in the git repository at: git://git.infradead

Re: Issue with mini-SaS to eSATA to USB 3.0 setup

2013-02-22 Thread Fabio David
I know it is a weird setup... > On Tue, Jan 29, 2013 at 12:56:02PM -0200, Fabio David wrote: > > Hi Sarah, > > > > My name is Fabio David and I am from Brazil. I've seen your posts on > > several forums and read articles about you. I really admire your work. > &g

Re: Issue with mini-SaS to eSATA to USB 3.0 setup

2013-02-22 Thread Fabio David
RESENT -- Forwarded message -- From: Fabio David Date: Thu, Feb 21, 2013 at 5:42 PM Subject: Re: [usb-storage] Issue with mini-SaS to eSATA to USB 3.0 setup Thanks for your reply, Matt. But it works! Only sometimes the OS doesnt "see" hot-insertion / hot-remove

Re: [PATCH net-next 05/22] cxgb4: Add T5 write combining support

2013-03-12 Thread David Miller
From: Vipul Pandya Date: Tue, 12 Mar 2013 17:16:17 +0530 > + writel(n, adap->bar2 + q->udb + 8); > +#if defined(CONFIG_X86_32) || defined(CONFIG_X86_64) > + asm volatile("sfence" : : : "memory"); > +#endif There is absolutely no way I'm letting an

RE: [PATCH net-next 05/22] cxgb4: Add T5 write combining support

2013-03-13 Thread David Laight
e fence instructions are needed are in relation to write combining accesses. In particular I don't believe they are ever needed to synchronise uncached accesses with each other, or with cached accesses (which are snooped). David -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 net-next 00/22] Add support for Chelsio T5 adapter

2013-03-14 Thread David Miller
From: Vipul Pandya Date: Thu, 14 Mar 2013 20:38:46 +0530 > We request to merge this patch series via David Miller's net-next tree. We are > copying respective maintainers of all the drivers for reviewing the changes. > Kindly let us know in case of any review comments. All appli

RE: [PATCH v2 net-next 05/22] cxgb4: Add T5 write combining support

2013-03-14 Thread David Laight
nverted to wmb() in a local header file). Thinking further, for portability you might want to find some way of abstracting the multi-word writes somehow. For example, some of the ppc have a dma engine associated with the PCIe master interface that can be used to generate large TLP. The code would

Re: [PATCH 5/6] scsi: replace obsolete NLMSG_* with type safe nlmsg_*

2013-03-28 Thread David Miller
From: Thomas Graf Date: Thu, 28 Mar 2013 14:45:02 + > On 03/28/13 at 12:53am, Hong Zhiguo wrote: >> Signed-off-by: Hong Zhiguo > > There are some formatting errors but the Netlink bits themselves > look good. > I'll fix these up too when I commit. -- To unsubscribe from this list: send th

Re: [PATCH 5/6] scsi: replace obsolete NLMSG_* with type safe nlmsg_*

2013-03-28 Thread David Miller
From: Hong Zhiguo Date: Thu, 28 Mar 2013 00:53:15 +0800 > Signed-off-by: Hong Zhiguo Applied with formatting fixed up. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/ma

[PATCH 18/26] megaraid: Don't use create_proc_read_entry() [RFC]

2013-04-11 Thread David Howells
Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Neela Syam Kolli cc: James E.J. Bottomley cc: linux-scsi@vger.kernel.org --- drivers/scsi/megaraid.c |

[PATCH 10/28] proc: Add proc_mkdir_data() [RFC]

2013-04-16 Thread David Howells
Add proc_mkdir_data() to allow procfs directories to be created that are annotated at the time of creation with private data rather than doing this post-creation. This means no access is then required to the proc_dir_entry struct to set this. Signed-off-by: David Howells cc: Neela Syam Kolli

[PATCH 14/28] proc: Supply an accessor for getting the data from a PDE's parent [RFC]

2013-04-16 Thread David Howells
this has no release function). Signed-off-by: David Howells cc: Jerry Chuang cc: Mauro Carvalho Chehab cc: Maxim Mikityanskiy cc: YAMANE Toshiaki cc: linux-wirel...@vger.kernel.org cc: linux-scsi@vger.kernel.org cc: de...@driverdev.osuosl.org --- drivers/scsi/megaraid.c|2

RE: T10 WCE interpretation in Linux & device level access

2013-04-24 Thread Black, David
n be removed cleanly. To oversimplify, it's not enough to flush data to the drive; the array or controller is stateful, and hence has to be told to "forget" the drive, where "forget" involves things that are rather implementation-specific. Thanks, --David

Re: [PATCH] ibmvsci: make parameters max_id and max_channel read-only

2015-09-09 Thread David Gibson
On Wed, 9 Sep 2015 17:21:00 +0200 Laurent Vivier wrote: > The value of the parameter is never re-read by the driver, > so a new value is ignored. Let know the user he > can't modify it by removing writable attribute. > > Signed-off-by: Laurent Vivier Reviewed-by: Davi

Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only

2015-09-10 Thread David Gibson
On Thu, 10 Sep 2015 11:23:12 +0200 Laurent Vivier wrote: > The value of the parameter is never re-read by the driver, > so a new value is ignored. Let know the user he > can't modify it by removing writable attribute. > > Signed-off-by: Laurent Vivier Reviewed-by: Davi

Re: [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max_channel.

2015-09-10 Thread David Gibson
On Thu, 10 Sep 2015 11:23:13 +0200 Laurent Vivier wrote: > As devices with values greater than that are silently ignored, > this gives some hints to the sys admin to know why he doesn't see > his devices... > > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson &

Re: [PATCH 3/3] ibmvsci: Allow to configure maximum LUN

2015-09-10 Thread David Gibson
On Thu, 10 Sep 2015 11:23:14 +0200 Laurent Vivier wrote: > QEMU allows until 32 LUNs. > > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > drivers/scsi/ibmvscsi/ibmvscsi.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

RE: [PATCH v2 09/30] cxlflash: Fix to stop interrupt processing on remove

2015-09-17 Thread David Laight
removed) and is then (say) interrupted by a higher priority interrupt that takes longer to execute than the remove code? You've still got an interrupt routine accessing freed memory. David

RE: [PATCH v2 12/30] cxlflash: Refine host/device attributes

2015-09-21 Thread David Laight
bytes += scnprintf(buf + bytes, PAGE_SIZE - bytes, You need to check scnprintf()'s return value though. The above is wrong for libc's snprintf(). David N�r��yb�X��ǧv�^�)޺{.n�+{���"�{ay�ʇڙ�,j��f���h���z��w��� ���j:+v���w�j�mzZ+�ݢj"��!�i

RE: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread David Laight
t those old Alphas? The x86 cpus will also do 32bit wide rmw cycles for the 'bit' operations. > OK, thanks! You still have to ensure the compiler doesn't do wider rmw cycles. I believe the recent versions of gcc won't do wider accesses for volatile data. David N�r��yb�X��ǧv�^�)޺{.n�+{���"�{ay�ʇڙ�,j��f���h���z��w��� ���j:+v���w�j�mzZ+�ݢj"��!�i

RE: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread David Laight
From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: 28 September 2015 15:27 > On Mon, 2015-09-28 at 08:58 +, David Laight wrote: > > From: Rafael J. Wysocki > > > Sent: 27 September 2015 15:09 > > ... > > > > > Say you have thr

RE: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread David Laight
hey tend to split 32 bit loads into a left and right part > (first the top then the offset). This (and other things) are mostly > what you see in code. However, 32 bit register stores are still atomic, > which is all we require. It's not really the compiler's fault, it's > mostly an architectural limitation. No, I'm not talking about how 32bit constants are generated. I'm talking about structure offsets. David N�r��yb�X��ǧv�^�)޺{.n�+{���"�{ay�ʇڙ�,j��f���h���z��w��� ���j:+v���w�j�mzZ+�ݢj"��!�i

Re: [PATCH net-next] cxgb4i: Increased the value of MAX_IMM_TX_PKT_LEN from 128 to 256 bytes

2015-10-14 Thread David Miller
From: Karen Xie Date: Tue, 13 Oct 2015 17:13:59 -0700 > This helps improving the latency of small packets. > > Signed-off-by: Rakesh Ranjan > Signed-off-by: Karen Xie Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord..

Re: why disk info gets printk'ed twice?

2007-10-22 Thread David Miller
From: Michael Tokarev <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 01:37:28 +0400 > So it seems to me that scsi_driver.probe() method gets called > twice for some reason... > > This question has been asked several times, but I don't recall > any answers to it. I seem to remember that this happens

Re: Add ACCUSYS RAID driver for Linux i386/x86-64

2007-10-22 Thread David Miller
From: "Peter Chan" <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 09:45:48 +0800 > Add linux-scsi and linux-kernel in mail group. Please do not post your driver as a "RAR" attachment, not only are most Linux folks not familiar with this archive format, it is also an attachment type rejected by just a

Re: [GIT PATCH] final SCSI pieces for the merge window

2007-10-23 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 23 Oct 2007 18:06:51 -0400 > James Bottomley wrote: > > On Tue, 2007-10-23 at 17:09 -0400, Jeff Garzik wrote: > >> James Bottomley wrote: > >>> This should be the final SCSI updates; it's mainly just a few accessor > >>> completion updates and two d

Re: [BUG] New Kernel Bugs

2007-11-13 Thread David Miller
From: "Martin Bligh" <[EMAIL PROTECTED]> Date: Tue, 13 Nov 2007 09:46:08 -0800 > This is a technical issue with vger.kernel.org mailing lists that I've tried > addressing before - maybe davem can help fix it? I think the problem is that certain mail headers show up multiple times and this makes i

Re: SCSI breakage on non-cache coherent architectures

2007-11-19 Thread David Miller
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 16:35:23 +1100 > I'm not sure what is the best way to fix that. Internally, I've done > some test whacking some cacheline_aligned in the scsi_cmnd data > structure to verify I no longer get random SLAB corruption when usin

Re: SCSI breakage on non-cache coherent architectures

2007-11-19 Thread David Miller
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Date: Tue, 20 Nov 2007 06:51:14 +1100 > On Mon, 2007-11-19 at 00:38 -0800, David Miller wrote: > > From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > > Date: Mon, 19 Nov 2007 16:35:23 +1100 > > > > You cou

Re: SCSI breakage on non-cache coherent architectures

2007-11-19 Thread David Miller
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Date: Tue, 20 Nov 2007 11:34:24 +1100 > Do you still think we should introduce this __dma_cacheline_aligned ? Do > you see other cases of drivers where it would be useful ? It tend to > agree with your earlier statement that drivers doing that are b

Re: SCSI breakage on non-cache coherent architectures

2007-11-19 Thread David Miller
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Date: Tue, 20 Nov 2007 11:55:01 +1100 > BTW. What is the status nowadays with skb's ? Good question. Some drivers are problematic (or were) because they put DMA descriptor chaining information at the head of the buffer, but those have been fixed e

Re: [PATCH] esp_scsi: Fix reset cleanup spinlock recursion

2007-12-05 Thread David Miller
ut for now it > fixes a bug that causes the spinlock debugger to fire. > > While at it, it fixes a small number of cosmetic problems with > starget_for_each_device() too. > > Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> Acked-by: David S. Miller <[EMAIL PRO

Re: [PATCH] REQ-flags to/from BIO-flags bugfix

2007-12-12 Thread David Chinner
On Wed, Dec 12, 2007 at 08:54:07AM -0700, Matthew Wilcox wrote: > On Wed, Dec 12, 2007 at 08:18:14AM -0700, Matthew Wilcox wrote: > > I don't know whether BIO_RW_BARRIER is __REQ_SOFTBARRIER or > > __REQ_HARDBARRIER, so I didn't include that in this patch. There also > > doesn't seem to be a __REQ

Re: [PATCH 2/5] dma_map_sg_ring() helper

2007-12-19 Thread David Miller
From: FUJITA Tomonori <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 16:06:31 +0900 > On Thu, 20 Dec 2007 16:49:30 +1100 > Rusty Russell <[EMAIL PROTECTED]> wrote: > > > +/** > > + * dma_map_sg_ring - Map an entire sg ring > > + * @dev: Device to free noncoherent memory for > > + * @sg: The sg_ring >

Re: [PATCH 0/5] sg_ring for scsi

2007-12-19 Thread David Miller
From: Rusty Russell <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 18:53:48 +1100 > Manipulating the magic chains is horrible; it looks simple to the > places which simply want to iterate through it, but it's awful for > code which wants to create them. I'm not saying complexity is inherent in this s

Re: [PATCH 0/5] sg_ring for scsi

2007-12-20 Thread David Miller
From: Rusty Russell <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 10:13:38 +1100 > But, as demonstrated, there are real benefits of having an explicit header: > > 1) It removes the chain-end/explicit count ambiguity (see > http://lkml.org/lkml/2007/10/25/209 & thread) > 2) It allows others to manip

Re: [PATCH 2/5] dma_map_sg_ring() helper

2007-12-20 Thread David Miller
From: Rusty Russell <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 11:35:12 +1100 > On Friday 21 December 2007 11:00:27 FUJITA Tomonori wrote: > > We need to pass the whole sg entries to the IOMMUs at a time. > > Hi Fujita, > > OK, it's certainly possible to have an arch override. For which >

RE: [PATCH 2/2] qla4xxx: Add target reset functionality

2007-12-21 Thread David Somayajulu
vice), > +"WARM TARGET RESET FAILED.\n"); > + return FAILED; > + } > + > + /* Send marker. */ > + ha->marker_needed = 1; > + > + /* > + * If we are coming down the EH path, wait for all > commands to complete >

Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers

2008-01-03 Thread David Miller
ing these drivers, since there is a much simpler > > > and modern esp infrastructure with David Miller's esp_scsi > > > > > > - Remove all driver files dependent on NCR53C9x.c > > > deleted:drivers/scsi/NCR53C9x.c > > > d

Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers

2008-01-04 Thread David Miller
From: Finn Thain <[EMAIL PROTECTED]> Date: Fri, 4 Jan 2008 22:05:20 +1100 (EST) > I have a partially written replacement for mac_esp. Unlike the other > NCR53C9x drivers it needs PIO or pseudo DMA depending on the machine -- so > it is not as straight-forward as jazz_esp. The new esp_scsi core a

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread David Brownell
On Monday 07 January 2008, Greg KH wrote: > Most of the non-driver core code should be converted to not use the > lock in the class at all.  They should use a local lock instead. Or better yet, that yet-to-be-written class_for_each_instance() iterator ... :) - To unsubscribe from this list: send

Re: Buggy Firewire bridge 'Prolific PL3507'

2008-01-08 Thread David Zeuthen
mmands for optical drives. Also, keep in mind that we do a lot of IO to probe for the file system on the actual disc including trying to get e.g. the iso9660 file system label of the latest session. Maybe this trivial IO is what is causing the hiccups? (Notably udev doesn't do this for opti

Re: Buggy Firewire bridge 'Prolific PL3507'

2008-01-08 Thread David Zeuthen
On Tue, 2008-01-08 at 15:10 -0500, David Zeuthen wrote: > Perhaps if you can point to what SCSI commands hald are sending it would > be easier to debug. Any other ideas? Also, if you can identify the name of the process image doing this it would be helpful. I know both libipoddevice and l

[RFC] aic7xxx - ahc_done check SCB_ACTIVE for tagged transactions

2008-01-25 Thread David Milburn
one'd twice This patch is included in Adaptec's 6.3.11 driver on their website. Thank you, David --- scsi-misc-2.6.git/drivers/scsi/aic7xxx/aic7xxx_osm.c.abort +++ scsi-misc-2.6.git/drivers/scsi/aic7xxx/aic7xxx_osm.c @@ -1658,9 +1658,12 @@ ahc_done(struct ahc_softc

Re: [RFC] aic7xxx - ahc_done check SCB_ACTIVE for tagged transactions

2008-01-29 Thread David Milburn
Hannes Reinecke wrote: David Milburn wrote: Hannes, Does ahc_done need to check the SCB_ACTIVE flag only if the SCB is not in the untagged queue before panic? If the driver is in error recovery, you may end panic'ing on a TUR that is in the untagged queue. Attempting to queue an

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-01-31 Thread David Dillow
On Thu, 2008-01-31 at 18:08 +0100, Bart Van Assche wrote: > If anyone has a suggestion for a better test than dd to compare the > performance of SCSI storage protocols, please let it know. xdd on /dev/sda, sdb, etc. using -dio to do direct IO seems to work decently, though it is hard (ie, impossi

Re: [Bug 9880] dma_free_coherent in arcmsr when calling areca tools

2008-02-03 Thread David Brownell
On Sunday 03 February 2008, James Bottomley wrote: > That's caused by this commit: > > commit aa24886e379d2b641c5117e178b15ce1d5d366ba > Author: David Brownell <[EMAIL PROTECTED]> > Date:   Fri Aug 10 13:10:27 2007 -0700 > >     dma_free_coherent() needs irqs e

RE: [PATCH 07/12] qla4xxx: add qla4xxx async scan support

2008-02-04 Thread David Somayajulu
qla4xxx_version_str, ha->pdev->device, > pci_name(ha->pdev), > ha->host_no, ha->firmware_version[0], > ha->firmware_version[1], > ha->patch_number, ha->build_number); > - > + scsi_scan_host(host); > return 0; > >

RE: [PATCH 03/12] qla4xxx: have qla4xxx use iscsi class session state check ready

2008-02-04 Thread David Somayajulu
+ cmd->result = rval; > + goto qc_fail_command; > + } > + > if (atomic_read(&ddb_entry->state) != DDB_STATE_ONLINE) { > if (atomic_read(&ddb_entry->state) == DDB_STATE_DEAD) { > cmd->result = DID_NO

Re: Integration of SCST in the mainstream Linux kernel

2008-02-04 Thread David Dillow
On Mon, 2008-02-04 at 14:53 +0100, Bart Van Assche wrote: > Another issue I have to look further into is that dd and xdd report > different results for very large block sizes (> 1 MB). Be aware that xdd reports 1 MB as 100, not 1048576. Though, it looks like dd is the same, so that's probably

RE: [PATCH 02/12] qla4xxx: have qla4xxx directly call iscsi recovery functions

2008-02-04 Thread David Somayajulu
; { > @@ -308,6 +272,9 @@ int qla4xxx_add_sess(struct ddb_entry *ddb_entry) > DEBUG2(printk(KERN_ERR "Could not add connection.\n")); > return -ENOMEM; > } > + > + /* finally ready to go */ > + iscsi_unblock_session(ddb_entry-&

RE: [PATCH 05/12] qla4xxx: fix recovery timer and session unblock race

2008-02-04 Thread David Somayajulu
c > routine - dpc " > + "flags = 0x%lx\n", > + ha->host_no, __func__, ha->dpc_flags)); > + queue_work(ha->dpc_thread, &ha->dpc_work); > + } > } > > static int qla4xxx_host_get_param(struct Scsi_Host *shost, > -- > 1.5.2.1 Acked by David Somayajulu <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] eisa: standardize on eisa_register_driver like similar bus registrations

2013-10-07 Thread David Miller
y. > > This affects the EISA bus, SCSI, and networking subsystems so only one should > ultimately merge the patch if it is accepted. > > Signed-off-by: Matthew Whitehead I'm fine with someone else taking this, for networking parts: Acked-by: David S. Miller -- To unsubscri

Re: [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table

2013-10-22 Thread David Daney
ctl_table security:keys: Convert use of typedef ctl_table to struct ctl_table After all this work, why not go ahead and remove the typedef? That way people won't add more users of this abomination. David Daney arch/arm/kernel/isa.c | 6 ++--- arch/ia64/kernel/cr

Re: [PATCH 0/10] IB SRP initiator patches for kernel 3.12

2013-10-25 Thread David Dillow
queue size configurable. > - Make it possible to figure out which SCSI host corresponds to which >SRP initiator port by making the SGID (source GID) available in sysfs. Many of these already have it, but for patches 1-10: Acked-by: David Dillow -- Dave Dillow National Center for Computatio

Re: [PATCH 03/10] scsi_transport_srp: Add transport layer error handling

2013-10-25 Thread David Dillow
On Sat, 2013-10-19 at 18:13 +0200, Bart Van Assche wrote: > Since it takes some work to figure out the state transitions from the > source code, I have tried to draw a diagram representing all state > transitions. I have attached that diagram to this e-mail. That diagram > probably will make it

Re: [PATCH v2 0/10] IB SRP initiator patches for kernel 3.13

2013-10-26 Thread David Dillow
On Sat, 2013-10-26 at 14:29 +0200, Bart Van Assche wrote: > The changes since the previous version of this patch series are as follows > (see also http://thread.gmane.org/gmane.linux.drivers.rdma/17693): > - Renamed the "can_queue" parameter into "queue_size". > - Corrected the title of the introdu

[PATCH] scsi: avoid use of reclaimed reference

2013-11-12 Thread David Decotigny
This patch avoids to use an object after it was potentially reclaimed by scsi_device_put(). Signed-off-by: David Decotigny --- drivers/scsi/scsi_scan.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 307a811

Re: [PATCH] scsi: avoid use of reclaimed reference

2013-11-12 Thread David Decotigny
csi_device_put(sdev); // -> reclaimed if (scsi_device_created(sdev)) // test on garbage or unmapped data (#PF) ... On Tue, Nov 12, 2013 at 5:57 PM, James Bottomley wrote: > On Tue, 2013-11-12 at 17:10 -0800, David Decotigny wrote: >> This patch avoids to use an object after it

Re: [PATCH] scsi: avoid use of reclaimed reference

2013-11-13 Thread David Decotigny
lowed, then I'd argue that the "if (scsi_device_created(sdev))" on the potentially reclaimed sdev is not right, that's why I was proposing this patch. Regards, On Wed, Nov 13, 2013 at 4:06 AM, Bart Van Assche wrote: > On 11/13/13 02:10, David Decotigny wrote: >> >>

Re: [PATCH 3.13] genetlink/pmcraid: use proper genetlink multicast API

2013-11-28 Thread David Miller
From: Johannes Berg Date: Sun, 24 Nov 2013 21:09:26 +0100 > From: Johannes Berg > > The pmcraid driver is abusing the genetlink API and is using its > family ID as the multicast group ID, which is invalid and may > belong to somebody else (and likely will.) > > Make it use the correct API, but

Re: [PATCH 0/3] SCSI SRP transport layer patches for kernel 3.14

2013-12-30 Thread David Dillow
e consistent with that of the FC > transport layer. > * Fix a rare race condition triggered by path failover. > * Document the rport state transitions. For all three, Acked-by: David Dillow Thanks Bart! -- Dave Dillow National Center for Computational Science Oak Ridge National Labo

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-06 Thread David Laight
he one that crosses the ring end can be split in two. A quick 'fix' would be to assume that anything with too many fragments is probably ok - maybe check the first fragment is suitably aligned. That would recover the old behaviour for usb disk transfers with a lot of fragments - yes it is a hack... David

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-07 Thread David Laight
o do it. > > As you suspected, the patches didn't fix the problem, sorry. I think Sarah will want the traces of the transfer being setup (ie just before the error). Some 'normal' completing transfers are also useful. You might also find the full trace output in one of the files in /var/log. David

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-07 Thread David Laight
the patch that increases the ring size from 64 to 256? David

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-08 Thread David Laight
out and it had the > cycle bit set correctly, etc. Perhaps the no-op TRBs are really the > issue. > > I'll have to take a look at the log again tomorrow. I posted the dmesg > on pastebin if David wants to check it out as well: > http://pastebin.com/a4AUpsL1 I can't

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-08 Thread David Laight
code used a 'ring end pointer' then a link TRB could be used instead. David -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-08 Thread David Laight
> From: Alan Stern > On Wed, 8 Jan 2014, David Laight wrote: > > > > From: Alan Stern > > > > > > This may be a foolish question, but why is xhci-hcd using no-op TRBs in > > > the first place? > > > > Because it can't write in a link T

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-09 Thread David Laight
ome kind of PCIe card ? > e.g. I boot the machine with the docking station powered-off, and then > later I power it on, the usb3 disk is not detected at all -- until I > reboot the machine with the docking station still powered on. That will be something completely different to failures when run

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-10 Thread David Laight
same change would help. > Does lspci provide that information? I'm not seeing anything obvious. I've only seen it in the diagnostic prints (that aren't normally output). David

Re: [PATCH v8 3/4] ata: Add APM X-Gene SoC SATA host controller driver

2014-01-10 Thread David Milburn
clk_disable_unprepare(hpriv->hpriv.clk); + rc = clk_prepare_enable(hpriv->hpriv.clk); + if (rc) { + dev_err(dev, "clock prepare enable failed\n"); + goto error; + } + } + + /* Configure t

Re: [PATCH v8 3/4] ata: Add APM X-Gene SoC SATA host controller driver

2014-01-10 Thread David Milburn
_active) { + qc_active = readl(port_mmio + PORT_SCR_ACT); + qc_active |= readl(port_mmio + PORT_CMD_ISSUE); + } + } else { + /* pp->active_link is valid iff any command is in flight */ + if (ap->qc_act

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE]

2014-01-14 Thread David Laight
0 USB 3.0 Host Controller > (rev 03) Do you know which version of the xhci spec it conforms to? (Will probably be 0.96 or 1.00). Of course, ASMedia will probably change the silicon they are using without changing anything on the packaging. David

<    1   2   3   4   5   6   7   >