Re: Delivery Status Notification for linuxr...@lsi.com

2016-11-10 Thread adam radford
On Thu, Nov 10, 2016 at 6:07 AM, Martin K. Petersen wrote: > Ownership of these products is now with Broadcom. To my knowledge the > 3ware product lines have been discontinued. That is true. I am still lurking on this list, if you want to update the email address to: aradf...@gmail.com, I'm fin

Re: Delivery Status Notification for linuxr...@lsi.com

2016-11-10 Thread adam radford
On Thu, Nov 10, 2016 at 10:42 AM, James Bottomley wrote: > It would look a lot better if you submitted the patch to change this > rather than having git history show someone else dumping it on you ... Sure, I will do that. -Aadm -- To unsubscribe from this list: send the line "unsubscribe linux-

[PATCH] Update 3ware driver email addresses

2016-11-10 Thread adam radford
This change updates the 3ware drivers (3w-, 3w-9xxx, 3w-sas) email addresses from linuxr...@lsi.com to aradf...@gmail.com, since the old email address doesn't exist. Signed-off-by: Adam Radford --- MAINTAINERS| 2 +- drivers/scsi/3w-9xxx.c | 6 +++--- drivers/scsi/3w-9xxx.

Re: [PATCH] Update 3ware driver email addresses

2016-12-07 Thread adam radford
On Thu, Nov 10, 2016 at 4:23 PM, adam radford wrote: > This change updates the 3ware drivers (3w-, 3w-9xxx, 3w-sas) email > addresses from linuxr...@lsi.com to aradf...@gmail.com, since the old > email address doesn't exist. > > Signed-off-by: Adam Radford > --- >

[PATCH RESEND] Update 3ware driver email addresses

2016-12-09 Thread adam radford
This change updates the 3ware drivers (3w-, 3w-9xxx, 3w-sas) email addresses from linuxr...@lsi.com to aradf...@gmail.com, since the old email address doesn't exist. This patch was updated to remove www.lsi.com text. Signed-off-by: Adam Radford --- MAINTAINERS| 2 +- dr

Re: [PATCH] scsi: 3w-9xxx.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-31 Thread adam radford
er_build_high = TW_CURRENT_DRIVER_BUILD; > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html &

Re: [ANNOUNCE] scsi patch queue tree updated

2014-08-21 Thread adam radford
On Fri, Aug 1, 2014 at 5:20 AM, Christoph Hellwig wrote: > I've pushed out updates to both the core-for-3.17 and drivers-for-3.17 > branches. I think we're in a good shape for the merge window, but > I'd still like to get reviewers attention for a few driver updates that > I'd love to get in stil

Re: "WRITE SAME failed. Manually zeroing" with 3w-xxxx driver

2013-05-21 Thread adam radford
ed > operation is queued. This will cause the SCSI layer to stop issuing the > offending command. > > Reported-by: Florian Westphal > CC: adam radford > Signed-off-by: Martin K. Petersen > > diff --git a/drivers/scsi/3w-.c b/drivers/scsi/3w-.c > index 56662ae..b927

Re: [PATCH 0/3] [SCSI] megaraid: Remove local (struct pci_dev) pdev's

2013-07-09 Thread adam radford
On Tue, Jul 9, 2013 at 2:18 PM, James Bottomley wrote: > On Tue, 2013-07-09 at 14:39 -0600, Myron Stowe wrote: >> Is the "megaraid" driver still actively used and maintained? I originally >> posted this series on 06.07.2013 and after receiving no comments, pinged >> the list again on 06.17.2013 a

Re: [PATCH 0/3] [SCSI] megaraid: Remove local (struct pci_dev) pdev's

2013-07-22 Thread adam radford
On Tue, Jul 9, 2013 at 11:10 PM, James Bottomley wrote: > On Tue, 2013-07-09 at 15:12 -0700, adam radford wrote: >> On Tue, Jul 9, 2013 at 2:18 PM, James Bottomley >> > Adam, you do drive by coding on this for LSI ... ack or reject, please. > >> I have just now located

[PATCH 1/2] megaraid_sas: Add High Availability clustering support using shared Logical Disks

2013-08-31 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas will add support for High Availability (HA)/clustering using shared Logical Disks. Signed-off-by: Adam Radford diff -Naur scsi-misc.old/drivers/scsi/megaraid/megaraid_sas_base.c scsi-misc.new/drivers/scsi/megaraid/megaraid_sas_base.c

[PATCH 0/2] megaraid_sas: Updates for scsi-misc

2013-08-31 Thread adam radford
James/linux-scsi, The following small patch series for megaraid_sas brings the driver up to v06.700.06.00-rc1: 1. Add High Availability clustering support using shared Logical Disks. 2. Version and Changelog update. -Adam -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i

[PATCH 2/2] megaraid_sas: Version and Changelog update

2013-08-31 Thread adam radford
James/linux-scsi, This patch updates the megaraid_sas driver version and updates Documentation/ChangeLog.megaraid_sas Signed-off-by: Adam Radford diff -Naur scsi-misc.old/Documentation/scsi/ChangeLog.megaraid_sas scsi-misc.new/Documentation/scsi/ChangeLog.megaraid_sas --- scsi-misc.old

Re: [PATCH 1/2] megaraid_sas: Add High Availability clustering support using shared Logical Disks

2013-09-06 Thread adam radford
ected patch is in-line below and also attached to this reply. Signed-off-by: Adam Radford diff -Naur scsi-misc.old/drivers/scsi/megaraid/megaraid_sas_base.c scsi-misc.new/drivers/scsi/megaraid/megaraid_sas_base.c --- scsi-misc.old/drivers/scsi/megaraid/megaraid_sas_base.c 2013-08-31 16

Re: [PATCH 1/3] 3w-sas: fix command completion race

2015-04-23 Thread adam radford
t; +++ b/drivers/scsi/3w-sas.h > @@ -103,10 +103,6 @@ static char *twl_aen_severity_table[] = > #define TW_CURRENT_DRIVER_BUILD 0 > #define TW_CURRENT_DRIVER_BRANCH 0 > > -/* Phase defines */ > -#define TW_PHASE_INITIAL 0 > -#define TW_PHASE_SGLIST 2 > - > /* Misc

Re: [PATCH 3/3] 3w-9xxx: fix command completion race

2015-04-23 Thread adam radford
ine */ > static int twa_slave_configure(struct scsi_device *sdev) > { > diff --git a/drivers/scsi/3w-9xxx.h b/drivers/scsi/3w-9xxx.h > index 040f721..0fdc83c 100644 > --- a/drivers/scsi/3w-9xxx.h > +++ b/drivers/scsi/3w-9xxx.h > @@ -324,11 +324,6 @@ static twa_messag

Re: [PATCH 2/3] 3w-xxxx: fix command completion race

2015-04-23 Thread adam radford
t; -/* Phase defines */ > -#define TW_PHASE_INITIAL 0 > -#define TW_PHASE_SINGLE 1 > -#define TW_PHASE_SGLIST 2 > - > /* Misc defines */ > #define TW_ALIGNMENT_600064 /* 64 bytes */ > #define TW_ALIGNMENT_7000 4 /* 4 bytes */ > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Adam Radford -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/6] scsi: megaraid: remove a useless call to memset().

2012-12-03 Thread adam radford
>sense_buffer, 0, > - SCSI_SENSE_BUFFERSIZE); > memcpy(cmd->scmd->sense_buffer, cmd->sense, >SCSI_SENSE_BUFFERSIZE); > cmd->scmd->result |= DRIVER_SENSE << 24; > --

Re: [patch,v3,repost 07/10] megaraid_sas: use scsi_host_alloc_node

2012-12-03 Thread adam radford
; + sizeof(struct megasas_instance), > + dev_to_node(&pdev->dev)); > > if (!host) { > printk(KERN_DEBUG "megasas: scsi_host_alloc failed\n"); Acked-by: Adam Radford -- To unsubscribe from this list: send the l

Re: [PATCH] megaraid_sas: fix memory leak if SGL has zero length entries

2012-12-03 Thread adam radford
gth, > + kbuff_arr[i], > + kern_sge32[i].phys_addr); > } > > megasas_return_cmd(instance, cmd); Acked-by: Adam Radford -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/3] megaraid_sas: Updates for scsi-misc

2013-02-09 Thread adam radford
James/linux-scsi, The following small patch series for megaraid_sas brings the driver up to v06.506.00.00-rc1: 1. Add 4k FastPath DIF support. 2. Dont load DevHandle unless FastPath enabled. 3. Version and Changelog update. -Adam -- To unsubscribe from this list: send the line "unsubscribe linux

[PATCH 1/3] megaraid_sas: Add 4k FastPath DIF support

2013-02-09 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas will allow Fastpath T10PI/DIF frame builds to work with 4k sector size. Signed-off-by: Adam Radford diff -Naur scsi-misc.old/drivers/scsi/megaraid/megaraid_sas_fusion.c scsi-misc.new/drivers/scsi/megaraid/megaraid_sas_fusion.c --- scsi

[PATCH 2/3] megaraid_sas: Dont load DevHandle unless FastPath enabled

2013-02-09 Thread adam radford
the DevHandle could be invalid. Signed-off-by: Adam Radford diff -Naur scsi-misc.old/drivers/scsi/megaraid/megaraid_sas_fusion.c scsi-misc.new/drivers/scsi/megaraid/megaraid_sas_fusion.c --- scsi-misc.old/drivers/scsi/megaraid/megaraid_sas_fusion.c 2013-02-09 22:44:15.625191018 -0800 +++ scsi

[PATCH 3/3] megaraid_sas: Version and Changelog update

2013-02-09 Thread adam radford
James/linux-scsi, This patch updates the megaraid_sas driver version and updates Documentation/scsi/ChangeLog.megaraid_sas. Signed-off-by: Adam Radford diff -Naur scsi-misc.old/Documentation/scsi/ChangeLog.megaraid_sas scsi-misc.new/Documentation/scsi/ChangeLog.megaraid_sas --- scsi-misc.old

Re: [patch] [SCSI] megaraid_sas: release lock on error path

2013-04-16 Thread adam radford
t_fw_ioctl(instance, user_ioc, ioc); > + out_up: > up(&instance->ioctl_sem); > >out_kfree_ioc: > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More m

Re: [PATCH v4 01/22] [SCSI] megaraid_sas: Use correct #define for MSI-X capability

2013-04-22 Thread adam radford
~PCI_MSIX_FLAGS_ENABLE); > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Adam Radford -Adam -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: twa generates WARNING upon boot

2015-09-27 Thread adam radford
On Sun, Sep 27, 2015 at 4:56 AM, "Tóth Attila" wrote: > After an unsuccessful attempt to contact linuxr...@lsi.com, I'm trying to > seek assistance on this list. > > I've been seeing WARNINGs upon boot for a while now, without any obvious > symptoms. I got some advice to report it upstream on the

Re: [PATCH] 3w-9xxx: don't unmap bounce buffered commands

2015-10-05 Thread adam radford
t; scsi_sg_copy_to_buffer(srb, > @@ -1905,7 +1919,7 @@ static void > twa_scsiop_execute_scsi_complete(TW_Device_Extension *tw_dev, int re > { > struct scsi_cmnd *cmd = tw_dev->srb[request_id]; > > - if (scsi_bufflen(cmd) <

Re: [PATCH] 3w-9xxx: fix abysmal write performance on some motherboards

2007-11-09 Thread adam radford
On Nov 9, 2007 10:04 AM, Tony Battersby <[EMAIL PROTECTED]> wrote: > The 3ware 9500S-8 SATA RAID controller exhibits terrible write > performance when PCI memory-write-and-invalidate is disabled. This is > easy to demonstrate by replacing pci_try_set_mwi() in the patch below > with pci_clear_mwi()

Re: Patch submission question [not in the FAQ]

2007-12-06 Thread adam radford
On Dec 5, 2007 3:36 AM, Gabriele Gorla <[EMAIL PROTECTED]> wrote: > Hello, > I have submitted a patch for the 3x- driver on > alpha several months ago to both the driver maintainer > and the linux-scsi mailing list. > I have read all the FAQ and I tried to stick to the > instructions to the let

Re: [PATCH 2.6.23] 3w-xxxx: Fix bad unaligned accesses on alpha SMP

2007-12-07 Thread adam radford
On Dec 6, 2007 6:07 PM, Gabriele Gorla <[EMAIL PROTECTED]> wrote: > disable packing of the TAG_TW_Device_Extension > structure to prevent kernel unaligned accesses when > accessing the spinlock inside the ioctl_wqueue structure. > Fixes smartmontools kernel panic on alpha SMP > > Signed-off-by: Gab

Re: Dell Shared PERC8 RAID Controller

2014-03-03 Thread adam radford
Istvan/Emmanuel, >> 08:00.0 RAID bus controller [0104]: LSI Logic / Symbios Logic MegaRAID SAS 2208 IOV [Thunderbolt] [1000:002f] (rev 05) I will be sending a driver patch for megaraid_sas to support the Dell PowerEdge VRTX/Shared PERC8 device later this week. This will allow you to run Linux wi

[PATCH 1/1] 3ware 9000 add support for 9690SA

2007-07-20 Thread adam radford
The attached patch for scsi-misc-2.6 updates the 3ware 9000 driver: - Fix dma mask setting to fallback to 32-bit if 64-bit fails. - Add support for 9690SA controllers. Signed-off-by: Adam Radford <[EMAIL PROTECTED]> James, Please apply Thanks! -Adam Note: The patch is attached

[PATCH 0/5] megaraid_sas: Updates for scsi-misc

2014-03-10 Thread adam radford
James/linux-scsi, The following patch series for megaraid_sas brings the driver up to v06.803.01.00-rc1: 1. Load correct raid context timeout value for multipathing and clustering. 2. Fix megasas_ioc_init_fusion to use local stack variable. 3. Return leaked MPT frames to MPT command pool. 4. Add

[PATCH 2/5] megaraid_sas: Fix megasas_ioc_init_fusion

2014-03-10 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas fixes the megasas_ioc_init_fusion function to use a local stack variable for the IOCinit frame physical address instead of clobbering the first request descriptor. Signed-off-by: Adam Radford diff -Naur scsi-misc.old/drivers/scsi/megaraid

[PATCH 3/5] megaraid_sas: Return leaked MPT frames to MPT frame pool

2014-03-10 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas will return leaked MPT frames from any polled DCMD's that timeout to the MPT frame pool. Signed-off-by: Adam Radford diff -Naur scsi-misc.old/drivers/scsi/megaraid/megaraid_sas_fusion.c scsi-misc.new/drivers/scsi/meg

[PATCH 1/5] megaraid_sas: Load correct raid context timeout

2014-03-10 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas loads the correct raid context timeout value for multpathing and clustering. Signed-off-by: Adam Radford diff -Naur scsi-misc.old/drivers/scsi/megaraid/megaraid_sas_fp.c scsi-misc.new/drivers/scsi/megaraid/megaraid_sas_fp.c --- scsi

[PATCH 5/5] megaraid_sas: Version and Changelog update

2014-03-10 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas updates the driver version to v06.803.01.00-rc1, and updates Documentation/scsi/ChangeLog.megaraid_sas. Signed-off-by: Adam Radford diff -Naur scsi-misc.old/Documentation/scsi/ChangeLog.megaraid_sas scsi-misc.new/Documentation/scsi

Re: [PATCH 0/5] megaraid_sas: Updates for scsi-misc

2014-03-11 Thread adam radford
st patch, here: http://marc.info/?l=linux-scsi&m=139444512512929&w=2 -Adam On Mon, Mar 10, 2014 at 4:13 AM, Hannes Reinecke wrote: > On 03/10/2014 10:51 AM, adam radford wrote: >> James/linux-scsi, >> >> The following patch series for megaraid_sas brings the drive

Re: [PATCH 13/39] megaraid: simplify internal command handling

2014-03-20 Thread adam radford
lled twice; once to release the > -* reference we took above, and once to release the reference > -* originally taken by scsi_allocate_command > -*/ > - scsi_put_host_cmd_pool(gfp_mask); > - scsi_put_host_cmd_pool(gfp_mask); > -} > -EXPORT_SYMBOL

[PATCH 2/4] megaraid_sas: Remove unused variables in megasas_instance

2014-06-19 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas removes some unused variables from the megasas_instance structure. Signed-off-by: Adam Radford diff -Naur scsi-for-next.old/drivers/scsi/megaraid/megaraid_sas.h scsi-for-next.new/drivers/scsi/megaraid/megaraid_sas.h --- scsi-for-next.old

[PATCH 0/4] megaraid_sas: Updates for scsi for-next

2014-06-19 Thread adam radford
James/linux-scsi, The following patch series for megaraid_sas brings the driver up to v06.803.02.00-rc1. 1. Fix reset_mutex leak in megasas_reset_fusion(). 2. Remove unused variables in megasas_instance. 3. Fix LD/VF affiliation parsing. 4. Version and Changelog update. -Adam -- To unsubscribe f

[PATCH 1/4] megaraid_sas: Fix reset_mutex leak

2014-06-19 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas fixes a reset_mutex leak in megasas_reset_fusion(). Signed-off-by: Adam Radford diff -Naur scsi-for-next.old/drivers/scsi/megaraid/megaraid_sas_fusion.c scsi-for-next.new/drivers/scsi/megaraid/megaraid_sas_fusion.c --- scsi-for-next.old

[PATCH 4/4] megaraid_sas: Version and Changelog update

2014-06-19 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas updates the driver version and Documentation/scsi/ChangeLog.megaraid_sas. Signed-off-by: Adam Radford diff -Naur scsi-for-next.old/Documentation/scsi/ChangeLog.megaraid_sas scsi-for-next.new/Documentation/scsi/ChangeLog.megaraid_sas

[PATCH 3/4] megaraid_sas: Fix LD/VF affiliation parsing

2014-06-19 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas fixes the LD/VF affiliation policy parsing code to account for LD targetId's and Hidden LD's (not yet affiliated with any Virtual Functions). Signed-off-by: Adam Radford diff -Naur scsi-for-next.old/drivers/scs

Re: [PATCH] [scsi] 3w-xxxx: fix mis-aligned struct accesses

2014-06-27 Thread adam radford
so it only covers > hardware structures. > > Signed-off-by: Arnd Bergmann > Cc: Adam Radford > --- > diff --git a/drivers/scsi/3w-.h b/drivers/scsi/3w-.h > index 49dcf03..29b0b84e 100644 > --- a/drivers/scsi/3w-.h > +++ b/drivers/scsi/3w-.h > @

[PATCH 2/4] megaraid_sas: Removed unused variables in megasas_instance

2014-06-30 Thread Adam Radford
James/linux-scsi, The following patch for megaraid_sas removes some unused variables from the megasas_instance structure. Signed-off-by: Adam Radford --- drivers/scsi/megaraid/megaraid_sas.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers

[PATCH 0/4] megaraid_sas: Update for scsi for-next

2014-06-30 Thread Adam Radford
affiliation parsing. 4. Version and Changelog update. Adam Radford (4): megaraid_sas: Fix reset_mutex leak megaraid_sas: Removed unused variables in megasas_instance megaraid_sas: Fix LD/VF affiliation parsing megaraid_sas: Version and Changelog update Documentation/scsi/ChangeLog.megaraid_sas

[PATCH 1/4] megaraid_sas: Fix reset_mutex leak

2014-06-30 Thread Adam Radford
James/linux-scsi, The following patch for megaraid_sas fixes a reset_mutex leak in megasas_reset_fusion(). Signed-off-by: Adam Radford --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers

[PATCH 3/4] megaraid_sas: Fix LD/VF affiliation parsing

2014-06-30 Thread Adam Radford
James/linux-scsi, The following patch for megaraid_sas fixes the LD/VF affiliation policy parsing code to account for LD targetId's and Hidden LD's (not yet affiliated with any Virtual Functions). Signed-off-by: Adam Radford --- drivers/scsi/megaraid/megaraid_sas.h | 1 + dr

[PATCH 4/4] megaraid_sas: Version and Changelog update

2014-06-30 Thread Adam Radford
James/linux-scsi, The following patch for megaraid_sas updates the driver version and Documentation/scsi/ChangeLog.megaraid_sas. Signed-off-by: Adam Radford --- Documentation/scsi/ChangeLog.megaraid_sas | 13 + drivers/scsi/megaraid/megaraid_sas.h | 6 +++--- drivers/scsi

Re: [PATCH 3/4] megaraid_sas: Fix LD/VF affiliation parsing

2014-07-03 Thread adam radford
On Thu, Jul 3, 2014 at 1:18 AM, Christoph Hellwig wrote: > On Mon, Jun 30, 2014 at 05:19:57PM -0700, Adam Radford wrote: >> James/linux-scsi, >> >> The following patch for megaraid_sas fixes the LD/VF affiliation policy >> parsing code to account for LD targetId

[PATCH 4/5] megaraid_sas: Add missing initial call to megasas_get_ld_vf_affiliation().

2014-07-09 Thread Adam Radford
The following patch for megaraid_sas adds a missing initial call to megasas_get_ld_vf_affiliation() at the end of megasas_probe_one(). Signed-off-by: Adam Radford --- drivers/scsi/megaraid/megaraid_sas_base.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/megaraid

[PATCH 2/5] megaraid_sas: Remove unused variables in megasas_instance

2014-07-09 Thread Adam Radford
The following patch for megaraid_sas removes some unused variables from the megasas_instance structure. Reviewed-by: Martin K. Petersen Signed-off-by: Adam Radford --- drivers/scsi/megaraid/megaraid_sas.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/megaraid

[PATCH 0/5] megaraid_sas: Update for scsi for-next

2014-07-09 Thread Adam Radford
sing. 4. Add missing initial call to megasas_get_ld_vf_affiliation(). 5. Version and Changelog update. Adam Radford (5): megaraid_sas: Fix reset_mutex leak megaraid_sas: Remove unused variables in megasas_instance megaraid_sas: Fix LD/VF affiliation parsing megaraid_sas: Add missing ini

[PATCH 3/5] megaraid_sas: Fix LD/VF affiliation parsing

2014-07-09 Thread Adam Radford
_111() and megasas_get_ld_Vf_affiliation_12() to reduce indentation levels. Signed-off-by: Adam Radford --- drivers/scsi/megaraid/megaraid_sas.h | 1 + drivers/scsi/megaraid/megaraid_sas_base.c | 318 +++--- 2 files changed, 208 insertions(+), 111 deletions(-) di

[PATCH 1/5] megaraid_sas: Fix reset_mutex leak

2014-07-09 Thread Adam Radford
The following patch for megaraid_sas fixes a reset_mutex leak in megasas_reset_fusion(). Reviewed-by: Martin K. Petersen Signed-off-by: Adam Radford --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c

[PATCH 5/5] megaraid_sas: Version and Changelog update

2014-07-09 Thread Adam Radford
The following patch for megaraid_sas updates the driver version and Documentation/scsi/ChangeLog.megaraid_sas. Reviewed-by: Martin K. Petersen Signed-off-by: Adam Radford --- Documentation/scsi/ChangeLog.megaraid_sas | 14 ++ drivers/scsi/megaraid/megaraid_sas.h | 6

[PATCH 1/1] 3ware 8000 serialize reset code

2007-01-04 Thread adam radford
The attached patch for scsi-misc-2.6 updates the 3ware 8000 driver: - Free irq handler in __tw_shutdown(). - Turn on RCD bit for caching mode page. - Serialize reset code. Signed-off-by: Adam Radford <[EMAIL PROTECTED]> James, Please apply Thanks! -Adam Note: The patch is attached

Re: [PATCH] 3w-xxxx: Add tw_sysfs_init() so udev will create /dev/twe* devices.

2007-07-06 Thread adam radford
On 7/6/07, Joshua Daniel Franklin <[EMAIL PROTECTED]> wrote: Add tw_sysfs_init() to register 3w- driver with sysfs. This also causes udev to create /dev/twe* devices with the correct SELinux security context. Signed-off-by: Joshua Daniel Franklin <[EMAIL PROTECTED]> Thanks for the patch.

Re: [PATCH 03/28] 3w-xxx: fully convert to the generic DMA API

2018-10-12 Thread adam radford
/3w-.h > index 69e80c1ed1ca..bd87fbacfbc7 100644 > --- a/drivers/scsi/3w-.h > +++ b/drivers/scsi/3w-.h > @@ -230,7 +230,6 @@ static unsigned char tw_sense_table[][4] = > #define TW_IOCTL_TIMEOUT 25 /* 25 seconds */ > #define TW_IOCTL_CHRDEV_TIMEOUT 60 /* 60 seconds */ > #define TW_IOCTL_CHRDEV_FREE -1 > -#define TW_DMA_MASK DMA_BIT_MASK(32) > #define TW_MAX_CDB_LEN 16 > > /* Bitmask macros to eliminate bitfields */ > -- > 2.19.1 > Acked-by: Adam Radford

Re: [PATCH 02/28] 3w-9xxx: fully convert to the generic DMA API

2018-10-12 Thread adam radford
gt; mask during resume"); > - retval = -ENODEV; > - goto out_disable_device; > - } > + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)) || > + dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32))) { > + TW_PRINTK(host, TW_DRIVER, 0x40, "Failed to set dma mask > during resume"); > + retval = -ENODEV; > + goto out_disable_device; > + } > > /* Initialize the card */ > if (twa_reset_sequence(tw_dev, 0)) { > -- > 2.19.1 > Acked-by: Adam Radford

Re: [PATCH 04/28] 3w-sas: fully convert to the generic DMA API

2018-10-12 Thread adam radford
> - } > + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)) || > + dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32))) { > + TW_PRINTK(host, TW_DRIVER, 0x25, "Failed to set dma mask > during resume"); > + retval = -ENODEV; > + goto out_disable_device; > + } > > /* Initialize the card */ > if (twl_reset_sequence(tw_dev, 0)) { > -- > 2.19.1 > Acked-by: Adam Radford

Re: [PATCH] scsi: 3w-{sas,9xxx}: Use unsigned char for cdb

2018-10-19 Thread adam radford
> TW_Command_Full *full_command_packet; > int retval = 1; > @@ -554,7 +556,7 @@ static int twl_poll_response(TW_Device_Extension *tw_dev, > int request_id, int se > static int twl_aen_drain_queue(TW_Device_Extension *tw_dev, int > no_check_reset) > { > int request_id = 0; > - char cdb[TW_MAX_CDB_LEN]; > + unsigned char cdb[TW_MAX_CDB_LEN]; > TW_SG_Entry_ISO sglist[1]; > int finished = 0, count = 0; > TW_Command_Full *full_command_packet; > -- > 2.19.1 > Looks ok. Signed-off-by: Adam Radford -Adam

Re: [PATCH] scsi: 3w-{sas,9xxx}: Use unsigned char for cdb

2018-10-19 Thread adam radford
> TW_Command_Full *full_command_packet; > int retval = 1; > @@ -554,7 +556,7 @@ static int twl_poll_response(TW_Device_Extension *tw_dev, > int request_id, int se > static int twl_aen_drain_queue(TW_Device_Extension *tw_dev, int > no_check_reset) > { > int request_id = 0; > - char cdb[TW_MAX_CDB_LEN]; > + unsigned char cdb[TW_MAX_CDB_LEN]; > TW_SG_Entry_ISO sglist[1]; > int finished = 0, count = 0; > TW_Command_Full *full_command_packet; > -- > 2.19.1 > Looks ok. Acked-by: Adam Radford -Adam

[PATCH 0/5] megaraid_sas: Updates for scsi for-next

2012-07-17 Thread adam radford
James/linux-scsi, The following patch series for megaraid_sas brings the driver up to v6.18-rc1: 1. Fix Copyright dates. 2. Add throttlequeuedepth module parameter. 3. Add resetwaittime module parameter. 4. Move poll_aen_lock initializer. 5. Version and Changelog update. -Adam -- To unsubscribe

[PATCH 1/5] megaraid_sas: Fix Copyright dates

2012-07-17 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas fixes the Copyright dates. Signed-off-by: Adam Radford diff -Naur scsi/drivers/scsi/megaraid/megaraid_sas_base.c scsi.new/drivers/scsi/megaraid/megaraid_sas_base.c --- scsi/drivers/scsi/megaraid/megaraid_sas_base.c 2012-07-17 14:06

[PATCH 2/5] megaraid_sas: Add throttlequeuedepth module parameter

2012-07-17 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas adds a throttlequeuedepth module parameter. This allows a user to adjust the queue depth of the adapter when throttled due to I/O timeout. Signed-off-by: Adam Radford diff -Naur scsi/drivers/scsi/megaraid/megaraid_sas_base.c scsi.new

[PATCH 3/5] megaraid_sas: Add resetwaittime module parameter

2012-07-17 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas adds support for a resetwaittime module parameter. This allows a user to adjust the wait time in seconds after I/O timeout before resetting the adapter. Signed-off-by: Adam Radford diff -Naur scsi/drivers/scsi/megaraid/megaraid_sas_base.c

[PATCH 4/5] megaraid_sas: Move poll_aen_lock initializer

2012-07-17 Thread adam radford
present. Signed-off-by: Kashyap Desai Signed-off-by: Adam Radford diff -Naur scsi/drivers/scsi/megaraid/megaraid_sas_base.c scsi.new/drivers/scsi/megaraid/megaraid_sas_base.c --- scsi/drivers/scsi/megaraid/megaraid_sas_base.c 2012-07-17 14:57:32.890231627 -0700 +++ scsi.new/drivers/scsi

[PATCH 5/5] megaraid_sas: Version and Changelog update

2012-07-17 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas updates the driver version and Documentation/scsi/ChangeLog.megaraid_sas files. Signed-off-by: Adam Radford diff -Naur scsi/Documentation/scsi/ChangeLog.megaraid_sas scsi.new/Documentation/scsi/ChangeLog.megaraid_sas --- scsi/Documentation

Re: [PATCH] [RFC] [SCSI] mpt fusion: add support for 0x1000/0x0055

2012-07-27 Thread adam radford
On 7/27/12, Jiri Kosina wrote: > On Sat, 21 Jul 2012, Jiri Kosina wrote: > >> The device identifies itself as >> >> 0d:05.0 SCSI storage controller: LSI Logic / Symbios Logic SAS1068 PCI-X >> Fusion-MPT SAS (rev 01) Subsystem: NEC Corporation SAS1068 >> >> and seems to be functionally compatible w

Re: [PATCH] [RFC] [SCSI] mpt fusion: add support for 0x1000/0x0055

2012-07-27 Thread adam radford
On 7/27/12, Jiri Kosina wrote: ... > > So, what is the alternative? > > The only thing I know is that it works at least in basic mode (haven't > tested performance at all). The driver for your card is a closed source driver called 'megasr'. Here is a link to the LSI download page for this card/dr

Re: [PATCH] megaraid_sas: combine kmalloc+memset into kzalloc

2012-08-24 Thread adam radford
(i = 0; i < max_cmd; i++) { > fusion->cmd_list[i] = kmalloc(sizeof(struct > megasas_cmd_fusion), Acked-by: Adam Radford -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/7] megaraid_sas: Updates for scsi for-next

2012-10-01 Thread adam radford
James/linux-scsi, The following patch series for megaraid_sas brings the driver up to v06.504.01.00-rc1: 1. Remove un-needed completion_lock spinlock calls. 2. Add module param for configurable MSI-X vector count. 3. Load io_request DataLength in bytes. 4. Add array boundary check for SystemPD. 5

[PATCH 1/7] megaraid_sas: Remove un-needed completion_lock spinlock calls

2012-10-01 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas removes some un-needed completion_lock spinlock calls. Signed-off-by: Adam Radford diff -Naur scsi-misc/drivers/scsi/megaraid/megaraid_sas_fusion.c scsi-misc.new/drivers/scsi/megaraid/megaraid_sas_fusion.c --- scsi-misc/drivers/scsi

[PATCH 2/7] megaraid_sas: Add module param for configurable MSI-X vector count

2012-10-01 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas adds a module parameter for configurable MSI-X vector count. Signed-off-by: Adam Radford diff -Naur scsi-misc/drivers/scsi/megaraid/megaraid_sas_base.c scsi-misc.new/drivers/scsi/megaraid/megaraid_sas_base.c --- scsi-misc/drivers/scsi

[PATCH 3/7] megaraid_sas: Load io_request DataLength in bytes

2012-10-01 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas loads io_request->DataLength in bytes for newer firmware that supports high availability. Signed-off-by: Adam Radford diff -Naur scsi-misc/drivers/scsi/megaraid/megaraid_sas_fusion.c scsi-misc.new/drivers/scsi/megar

[PATCH 4/7] megaraid_sas: Add array boundary check for SystemPD

2012-10-01 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas adds an array boundary check for the SystemPD build path. Signed-off-by: Adam Radford diff -Naur scsi-misc/drivers/scsi/megaraid/megaraid_sas_fusion.c scsi-misc.new/drivers/scsi/megaraid/megaraid_sas_fusion.c --- scsi-misc/drivers/scsi

[PATCH 5/7] megaraid_sas: Add SystemPD FastPath support

2012-10-01 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas adds SystemPD FastPath support. Signed-off-by: Adam Radford diff -Naur scsi-misc/drivers/scsi/megaraid/megaraid_sas_fusion.c scsi-misc.new/drivers/scsi/megaraid/megaraid_sas_fusion.c --- scsi-misc/drivers/scsi/megaraid

[PATCH 6/7] megaraid_sas: Remove duplicate code

2012-10-01 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas removes some duplicate code. Signed-off-by: Adam Radford diff -Naur scsi-misc/drivers/scsi/megaraid/megaraid_sas_base.c scsi-misc.new/drivers/scsi/megaraid/megaraid_sas_base.c --- scsi-misc/drivers/scsi/megaraid/megaraid_sas_base.c 2012-10

[PATCH 7/7] megaraid_sas: Version, Changelog, Copyright update

2012-10-01 Thread adam radford
James/linux-scsi, The following patch for megaraid_sas updates the driver version, Changelog.megaraid_sas, and Copyright dates. Signed-off-by: Adam Radford diff -Naur scsi-misc/Documentation/scsi/ChangeLog.megaraid_sas scsi-misc.new/Documentation/scsi/ChangeLog.megaraid_sas --- scsi-misc

Re: [Linux Megaraid SAS driver] bug report

2012-11-02 Thread adam radford
On Fri, Nov 2, 2012 at 3:06 AM, Jérémie GUILLAUME wrote: ... > with 3.2.x kernels > -- > - no problem occurs ; we have good data transfers , even in 64 Gb High > Memory mode. Jeremie, The megaraid_sas driver changes from 3.2 kernel, version 6.12-rc1, to 3.3 kernel, version 6.14

Re: [PATCH] scsi: 3w-9xxx.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-12-22 Thread adam radford
On Mon, Dec 22, 2014 at 2:52 PM, Rickard Strandqvist wrote: > 2014-08-01 0:19 GMT+02:00 adam radford : >> On Sun, Jul 27, 2014 at 8:11 AM, Rickard Strandqvist >> wrote: >>> Replacing strncpy with strlcpy to avoid strings that lacks null terminate. >>> And use t

Re: [PATCH] scsi: 3ware: fix a missing-check bug

2018-05-07 Thread adam radford
On Sat, May 5, 2018 at 10:50 PM, Wenwen Wang wrote: > In twl_chrdev_ioctl(), the ioctl driver command is firstly copied from the > userspace pointer 'argp' and saved to the kernel object 'driver_command'. > Then a security check is performed on the data buffer size indicated by > 'driver_command',

Re: [PATCH] scsi: 3w-9xxx: fix a missing-check bug

2018-05-07 Thread adam radford
On Sat, May 5, 2018 at 8:43 PM, Wenwen Wang wrote: > In twa_chrdev_ioctl(), the ioctl driver command is firstly copied from the > userspace pointer 'argp' and saved to the kernel object 'driver_command'. > Then a security check is performed on the data buffer size indicated by > 'driver_command',

Re: [PATCH] scsi: 3w-xxxx: fix a missing-check bug

2018-05-07 Thread adam radford
On Sat, May 5, 2018 at 10:48 PM, Wenwen Wang wrote: > In tw_chrdev_ioctl(), the length of the data buffer is firstly copied from > the userspace pointer 'argp' and saved to the kernel object > 'data_buffer_length'. Then a security check is performed on it to make sure > that the length is not more

Re: [PATCH v2] scsi: 3w-9xxx: fix a missing-check bug

2018-05-07 Thread adam radford
ile) > unsigned int minor_number; > int retval = TW_IOCTL_ERROR_OS_ENODEV; > > + if (!capable(CAP_SYS_ADMIN)) { > + retval = -EACCES; > + goto out; > + } > + > minor_number = iminor(inode); > if (minor_number >= twa_device_extension_count) > goto out; > -- > 2.7.4 > Acked-by: Adam Radford

Re: [PATCH v2] scsi: 3w-xxxx: fix a missing-check bug

2018-05-07 Thread adam radford
_chrdev_open(struct inode *inode, struct > file *file) > > dprintk(KERN_WARNING "3w-: tw_ioctl_open()\n"); > > + if (!capable(CAP_SYS_ADMIN)) > + return -EACCES; > + > minor_number = iminor(inode); > if (minor_number >= tw_device_extension_count) > return -ENODEV; > -- > 2.7.4 > Acked-by: Adam Radford

Re: [PATCH 3/3] scsi: 3w-9xxx: rework lock timeouts

2017-11-10 Thread adam radford
ct TAG_TW_Device_Extension { > unsigned char event_queue_wrapped; > unsigned interror_sequence_id; > int ioctl_sem_lock; > - u32 ioctl_msec; > + ktime_t ioctl_time; > int chrdev_request_id; > wait_queue_head_t ioctl_wqueue; > struct mutexioctl_lock; > -- > 2.9.0 > Looks good... Thanks for this fix! Acked-by: Adam Radford

Re: [PATCH 1/3] scsi: 3ware: fix 32-bit time calculations

2017-11-10 Thread adam radford
p_sec overflows in y2106 */ > + local_time = (u32)(ktime_get_real_seconds() - (sys_tz.tz_minuteswest > * 60)); > event->time_stamp_sec = local_time; > event->aen_code = aen; > event->retrieved = TW_AEN_NOT_RETRIEVED; > -- > 2.9.0 > Acked-by: Adam Radford

Re: [PATCH 2/3] scsi: 3ware: use 64-bit times for FW time sync

2017-11-10 Thread adam radford
; > + local_time = (ktime_get_real_seconds() - (sys_tz.tz_minuteswest * > 60)); > + div_u64_rem(local_time - (3 * 86400), 604800, &schedulertime); > + schedulertime = cpu_to_le32(schedulertime); > > memcpy(param->data, &schedulertime, sizeof(u32)); > > -- > 2.9.0 > Acked-by: Adam Radford

3ware driver update for 2.6.11-rc2-mm2

2005-01-26 Thread adam radford
James, Here is a patch to update a few bugs in the 3ware driver for 5/6/7/8000 controllers. -Adam diff -Naur linux-2.6.11-rc2-mm1/drivers/scsi/3w-.c linux-2.6.11-rc2-mm2/driv ers/scsi/3w-.c --- linux-2.6.11-rc2-mm1/drivers/scsi/3w-.c 2004-12-24 13:35:28.0 -0 800 +++ linux-2.6

Re: [BK PATCH] SCSI updates for 2.6.11

2005-03-21 Thread adam radford
, Jeff Garzik wrote: > > More info? Were they dropped on purpose, or just never arrived? > > If dropped on purpose, what was the reason? > > You posted substantive updates to a maintained driver. Adam Radford is > the maintainer, but I haven't heard anything from him (neither AC

[PATCH 1/1] 3ware driver update for linux-2.6.12-rc1-bk2

2005-03-21 Thread adam radford
nge to new 'change_queue_depth' api (from James). - Fix 'handled=1' ISR usage, remove bogus IRQ check (from Jeff). A smiliar patch for the 9000 series driver will follow shortly, including a PAE fix, and a few other things (that is why I want it to be a separate patch). Signe

[PATCH 1/1] 3ware driver update for linux-2.6.12-rc1-bk2

2005-03-23 Thread adam radford
tch for the 9000 series driver will follow shortly, including a PAE fix, and a few other things (that is why I want it to be a separate patch). Signed-off-by: Adam Radford <[EMAIL PROTECTED]> James, Please apply 3ware_linux_2.6.12-rc1-bk2.patch Description: Binary data

[PATCH 1/1] 3ware 9000 driver update for linux-2.6.12-rc1-mm4

2005-03-28 Thread adam radford
'handled=1' ISR usage, remove bogus IRQ check (from Jeff Garzik) - Remove un-needed eh_abort handler. - Add support for embedded firmware error strings. Signed-off-by: Adam Radford <[EMAIL PROTECTED]> James, Please apply 3ware_linux_2.6.12-rc1-mm4.patch Description: Binary data

[PATCH 1/1] 3ware 9000 driver update for 2.6.13-rc6-git10

2005-08-17 Thread adam radford
The attached patch updates the driver for the 3ware 9000 series to do the following: - Add support for 9550SX controllers. Signed-off-by: Adam Radford <[EMAIL PROTECTED]> James, Please apply diff -Naur linux-2.6.13-rc6-git9/drivers/scsi/3w-9xxx.c linux-2.6.13-rc6-git10/drivers/scsi/3w-

[PATCH 1/1] 3ware 9000 driver update for 2.6.13-git10

2005-09-09 Thread adam radford
, and it had a bug where the request_buffer was accessed in twa_scsiop_execute_scsi_complete() when it was invalid. This is a corrected variation of that patch. Signed-off-by: Adam Radford <[EMAIL PROTECTED]> James, Please apply Thanks! Note: The patch is attached as an attachment, and al