Thanks Johannes for the review, please see comments below,
On 19/10/16 3:32 PM, "Johannes Thumshirn" wrote:
>On Wed, Oct 19, 2016 at 01:01:10AM -0400, manish.rangan...@cavium.com
>wrote:
>> From: Manish Rangankar
>>
>> The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module
>
Thanks Hannes for the review, please see my comments below,
On 19/10/16 1:15 PM, "Hannes Reinecke" wrote:
>On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote:
>> From: Manish Rangankar
>>
>> The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module
>> for 41000 Series Con
On 19/10/16 6:58 PM, "Johannes Thumshirn" wrote:
>On Wed, Oct 19, 2016 at 01:01:12AM -0400, manish.rangan...@cavium.com
>wrote:
>> From: Manish Rangankar
>>
>> This patch adds support for iscsi_transport LLD Login,
>> Logout, NOP-IN/NOP-OUT, Async, Reject PDU processing
>> and Firmware async
On 19/10/16 1:33 PM, "Hannes Reinecke" wrote:
>On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote:
>> From: Manish Rangankar
>>
>> This patch adds support for iscsi_transport LLD Login,
>> Logout, NOP-IN/NOP-OUT, Async, Reject PDU processing
>> and Firmware async event handling support
On 19/10/16 3:54 PM, "Hannes Reinecke" wrote:
>On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote:
>> From: Manish Rangankar
>>
>> This patch adds support for data path and TMF handling.
>>
>> Signed-off-by: Nilesh Javali
>> Signed-off-by: Adheer Chandravanshi
>> Signed-off-by: Chad
On 19/10/16 3:32 PM, "Johannes Thumshirn" wrote:
>On Wed, Oct 19, 2016 at 01:01:10AM -0400, manish.rangan...@cavium.com
>wrote:
>> From: Manish Rangankar
>>
>> The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module
>> for 41000 Series Converged Network Adapters by QLogic.
>>
Hi Hannes,
Please find the response below,
On 11/11/16 10:13 PM, "Hannes Reinecke" wrote:
>On 11/08/2016 07:57 AM, Manish Rangankar wrote:
>> The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module
>> for 41000 Series Converged Network Adapters by QLogic.
>>
>> This patch consi
Hi Dave,
Please consider applying the qed patches 1 & 2 to net-next.
Patch 3, qedi, goes to SCSI. Martin P. is ok to have you take qedi
(already Acked) through your tree. Please let us know which way you
prefer.
Thanks,
Manish
On 01/12/16 1:51 PM, "Rangankar, Manish"
wrote:
On 16/12/16 7:40 PM, "Colin King" wrote:
>From: Colin Ian King
>
>Although on most systems va_end is a no-op, it is good practice
>to use va_end on the function return path, especially since the
>va_start documenation states:
>
> "Each invocation of va_start() must be matched by a correspondi
On 11/01/17 9:40 AM, "Martin K. Petersen"
wrote:
>> "Ewan" == Ewan D Milne writes:
>
>Ewan> Randy posted a similar patch back in December but I don't think
>Ewan> there was ever a reply to Christoph's question about why qedi
>Ewan> depends on uio.
>
>I did queue up Randy's patch to shut up
On 07/02/17 8:22 PM, "Wei Yongjun" wrote:
>From: Wei Yongjun
>
>'conn_info' is malloced in qedi_iscsi_update_conn() and should be
>freed before leaving from the error handling cases, otherwise it
>will cause memory leak.
>
>Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI
>dr
On 28/02/17 4:32 PM, "Colin King" wrote:
>From: Colin Ian King
>
>The call to qedi_setup_int is not updating the return code rc yet rc
>is being checked for an error. Fix this by assigning rc to the return
>code from the call to qedi_setup_int.
>
>Signed-off-by: Colin Ian King
>---
> drivers/s
On 02/03/17 8:28 PM, "Arnd Bergmann" wrote:
>Without CONFIG_DEBUG_FS, we run into a link error:
>
>drivers/scsi/qedi/qedi_iscsi.o: In function `qedi_ep_poll':
>qedi_iscsi.c:(.text.qedi_ep_poll+0x134): undefined reference to
>`do_not_recover'
>drivers/scsi/qedi/qedi_iscsi.o: In function `qedi_ep_
On 30/12/17 8:58 PM, "Himanshu Jha" wrote:
>Use dma_zalloc_coherent instead of dma_alloc_coherent followed by memset
>0.
>
>Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
>
>Suggested-by: Luis R. Rodriguez
>Signed-off-by: Himanshu Jha
>---
> drivers/scsi/qla4xxx/ql4_init.c |
On 30/12/17 8:58 PM, "Himanshu Jha" wrote:
>Use dma_zalloc_coherent instead of dma_alloc_coherent followed by memset
>0.
>
>Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
>
>Suggested-by: Luis R. Rodriguez
>Signed-off-by: Himanshu Jha
>---
> drivers/scsi/qedi/qedi_main.c | 42
On 30/12/17 8:58 PM, "Himanshu Jha" wrote:
>Use dma_zalloc_coherent instead of dma_alloc_coherent followed by
>memset 0.
>
>Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
>
>Suggested-by: Luis R. Rodriguez
>Signed-off-by: Himanshu Jha
>---
> drivers/scsi/bnx2i/bnx2i_hwi.c | 1
On 09/01/18 2:36 PM, "Himanshu Jha" wrote:
>Use dma_zalloc_coherent instead of dma_alloc_coherent followed by memset
>0.
>
>Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
>
>Suggested-by: Luis R. Rodriguez
>Signed-off-by: Himanshu Jha
>---
> drivers/scsi/qedi/qedi_main.c | 42
On 02/02/18 6:42 PM, "Arnd Bergmann" wrote:
>When link-time optimizations are enabled, qedi fails to build because
>of mismatched prototypes:
>
>drivers/scsi/qedi/qedi_gbl.h:27:37: error: type of 'qedi_dbg_fops' does
>not match original declaration [-Werror=lto-type-mismatch]
> extern const str
On 15/02/18 12:30 AM, "Souptick Joarder" wrote:
>Use dma_pool_zalloc() instead of dma_pool_alloc + memset
>
>Signed-off-by: Souptick Joarder
>---
> drivers/scsi/qla4xxx/ql4_mbx.c | 6 ++
> drivers/scsi/qla4xxx/ql4_os.c | 4 +---
> 2 files changed, 3 insertions(+), 7 deletions(-)
>
>diff --g
On 13/06/17 10:19 PM, "Robert LeBlanc" wrote:
>On Wed, Jun 7, 2017 at 12:30 PM, Robert LeBlanc
>wrote:
>> On Wed, Jun 7, 2017 at 10:28 AM, Chris Leech wrote:
>>> On Tue, Jun 06, 2017 at 12:07:10PM -0600, Robert LeBlanc wrote:
This patchset enables iSCSI offload drivers to have access to t
On 24/06/17 9:54 PM, "Christos Gkekas" wrote:
>Variable idx is defined as u16 thus statement (idx < 0) is
>always false and should be removed.
>
>Signed-off-by: Christos Gkekas
>---
> drivers/scsi/qedi/qedi_fw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers
On 03/07/17 3:54 PM, "Colin King" wrote:
>From: Colin Ian King
>
>Trivial fix to spelling mistake in QEDF_ERR message. I should have
>also included this in a previous fix, but I only just spotted this one.
>
>Signed-off-by: Colin Ian King
>---
> drivers/scsi/qedi/qedi_fw.c | 2 +-
> 1 file cha
On 25/08/17 4:06 PM, "Dan Carpenter" wrote:
>The > here should be >= or we end up reading one element beyond the end
>of the qedi->itt_map[] array. The qedi->itt_map[] array is allocated in
>qedi_alloc_itt().
>
>Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI
>driver framew
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org On
> Behalf Of Christoph Hellwig
> Sent: Sunday, October 14, 2018 9:30 PM
> To: linux-scsi@vger.kernel.org
> Subject: [PATCH 20/28] qedi: fully convert to the generic DMA API
>
> External Email
>
> The driver is currently us
> -Original Message-
> From: Chengguang Xu
> Sent: Sunday, November 4, 2018 7:28 PM
> To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com
> Cc: Dept-Eng QLogic Storage Upstream upstr...@cavium.com>; linux-scsi@vger.kernel.org; Chengguang Xu
>
> Subject: [PATCH 1/2] scsi: qla4xxx: r
> -Original Message-
> From: Chengguang Xu
> Sent: Sunday, November 4, 2018 7:28 PM
> To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com
> Cc: Dept-Eng QLogic Storage Upstream upstr...@cavium.com>; linux-scsi@vger.kernel.org; Chengguang Xu
>
> Subject: [PATCH 2/2] scsi: qla4xxx: r
> -Original Message-
> From: Thomas Meyer
> Sent: Monday, December 3, 2018 2:22 AM
> To: Dept-Eng QLogic Storage Upstream upstr...@cavium.com>; j...@linux.vnet.ibm.com;
> martin.peter...@oracle.com; linux-scsi@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: [PATCH] scsi: qla4
> -Original Message-
> From: Thomas Meyer
> Sent: Monday, December 3, 2018 2:22 AM
> To: Dept-Eng QLogic Storage Upstream upstr...@cavium.com>; j...@linux.vnet.ibm.com;
> martin.peter...@oracle.com; linux-scsi@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: [PATCH] scsi: qedf
On 26/04/17 3:07 AM, "Colin King" wrote:
>From: Colin Ian King
>
>trivial fix to spelling mistake in DEBUG2 debug message
>
>Signed-off-by: Colin Ian King
>---
> drivers/scsi/qla4xxx/ql4_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/qla4xxx/ql4_init
On 10/04/17 10:42 PM, "Sebastian Andrzej Siewior"
wrote:
>The driver creates its own per-CPU threads which are updated based on CPU
>hotplug events. It is also possible to use kworkers and remove some of the
>infrastructure get the same job done while saving a few lines of code.
>
>The DECLARE_P
> -Original Message-
> From: Dan Carpenter
> Sent: Thursday, June 28, 2018 2:53 PM
> To: Dept-Eng QLogic Storage Upstream upstr...@cavium.com>; Rangankar, Manish
>
> Cc: James E.J. Bottomley ; Martin K. Petersen
> ; linux-scsi@vger.kernel.org; kernel-
&g
> -Original Message-
> From: Colin King
> Sent: Wednesday, September 26, 2018 6:39 PM
> To: Dept-Eng QLogic Storage Upstream upstr...@cavium.com>; James E . J . Bottomley ;
> Martin K . Petersen ; linux-scsi@vger.kernel.org
> Cc: kernel-janit...@vger.kernel.org; linux-ker...@vger.kernel.
On 10/09/17 5:48 PM, "Christos Gkekas" wrote:
>Pointers bnx2i_cmd are set but never used, so they can be removed.
>
>Signed-off-by: Christos Gkekas
>---
> drivers/scsi/bnx2i/bnx2i_hwi.c | 10 --
> 1 file changed, 10 deletions(-)
>
>diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c
>b/drivers/s
On 14/10/17 5:47 PM, "Christos Gkekas" wrote:
>Remove redundant variables in quedi_fw.c that are set but not used.
>
>Signed-off-by: Christos Gkekas
>---
> drivers/scsi/qedi/qedi_fw.c | 17 +
> 1 file changed, 1 insertion(+), 16 deletions(-)
>
>diff --git a/drivers/scsi/qedi/qed
On 25/10/17 3:37 PM, "Kees Cook" wrote:
>In preparation for unconditionally passing the struct timer_list pointer
>to
>all timer callbacks, switch to using the new timer_setup() and
>from_timer()
>to pass the timer pointer explicitly.
>
>Cc: qlogic-storage-upstr...@qlogic.com
>Cc: "James E.J. Bo
On 04/11/17 1:28 AM, "Gustavo A. R. Silva" wrote:
>Make use of the swap macro and remove unnecessary variable tmp.
>This makes the code easier to read and maintain.
>
>This code was detected with the help of Coccinelle.
>
>Signed-off-by: Gustavo A. R. Silva
>---
> drivers/scsi/bnx2i/bnx2i_hwi.c
On 13/12/17 2:41 PM, "Jia-Ju Bai" wrote:
>The driver may sleep under a spinlock.
>The function call path is:
>qedi_cpu_offline (acquire the spinlock)
> qedi_fp_process_cqes
>qedi_mtask_completion
> qedi_process_tmf_resp
>kzalloc(GFP_KERNEL) --> may sleep
>
>To fix it, GFP_KERN
37 matches
Mail list logo
