e to use "mpt3sas: foo bar" in the patch
descriptions. You had used "mpt3sas - foo bar".
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.ker
>>>>> "Long" == Long Li writes:
Long,
Long> Yes, this has been fixed in that patch.
I'd like to get my patch into scsi-fixes but it needs another set of
eyes. Would you mind either testing or reviewing it?
Thanks!
--
Martin K. Petersen Oracle Linux E
>>>>> "Maurizio" == Maurizio Lombardi writes:
Maurizio> The "fcp_rsp_code = %d" message isn't an error, it's meant to
Maurizio> be informative only. This patch prevents a flood of such
Maurizio> messages in some situations.
Applied to 4.8
; commands. Thoughts?
That's correct.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "Cathy" == Cathy Avery writes:
Cathy> When a virtual scsi DVD device is present with no image file
Cathy> attached the storvsc driver logs all resulting unnecessary sense
Cathy> errors whenever IO is issued to the device.
Tweaked whitespace and applie
pplied to 4.8/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
oc(). Instead of
Doug> using kzalloc() which reviewers didn't like, use a bucket system
Doug> (64 bytes on the stack) and potentially multiple calls to
Doug> sg_pcopy_from_buffer() to construct the 'data-in' buffer for the
Doug> SCSI REPORT LUNS command.
It would be great t
>>>>> "Wei" == Wei Fang writes:
Wei,
Wei> Update the new rules of ->host_failed.
Are you going to incorporate the amendment from James?
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsu
have the luxury of being able to generate VPDs for
their attached target devices :)
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "Colin" == Colin King writes:
Colin> trivial fix to spelling mistake in printk message
Applied to 4.8/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu
PUs. In this case, ->host_failed will be decreased
Wei> simultaneously in scsi_eh_finish_cmd() on different CPUs, and
Wei> become abnormal.
Applied to 4.7/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubsc
ower layer driver implements this
Long> function in its template and it can change this value there.
Those cause limits to be set for the controller. We won't know the
device limits until we hit revalidate.
blk_queue_max_hw_sectors() will also clamp the R/W max at
BLK_DEF_MAX_SECTORS, thoug
in libata's
SCSI-ATA translation.
- if (!scsi_get_vpd_page(sdev, 0x89, buffer, vpd_buf_len))
+ if (!scsi_get_vpd_page(sdev, 0x89, buffer, SD_BUF_SIZE))
That vpd_buf_len is intentional.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from th
ot.
Why is the number of sectors in the request bigger than the queue limit?
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ors() is checking limits.max_sectors(),
Hannes> but the requests are already fully formed and can extend up to
Hannes> limits.max_hw_sectors().
We should not be issuing REQ_TYPE_FS requests larger than max_sectors.
How did we get here?
--
Martin K. Petersen Oracle Linux Engineering
--
To
tants at device discovery time.
Did you remember to include the Block Device Characteristics VPD page in
your page 0?
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.
ace totally wrong. cat iso.img > /dev/sr0
would have been much more in line with how Unix works...
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
f my next DIF/DIX update that makes
some of these things more palatable at the block/SCSI level. Akinobu
voiced interest in finishing the scsi_debug work on top of my code.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linu
mal applications.
That does not preclude special cases where it may make sense to poke at
the device directly. For testing purposes, for instance. But I consider
it a failure when we start having applications that know about hardware
intricacies, cylinders/heads/sectors, etc. That road leads strai
unfortunately a block
count of 0 means "write entire device".
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
commit adds a test for WRITE_SAME_10.
No go. That'll disable WRITE SAME for drives which don't support
RSOC. Which means almost all of them.
I propose the following...
--
Martin K. Petersen Oracle Linux Engineering
[PATCH] sd: Update WRITE SAME heuristics
SATA drives located be
ng a few specimens that report MAX WRITE SAME BLOCKS.
--
Martin K. Petersen Oracle Linux Engineering
[PATCH] sd: Update WRITE SAME heuristics
SATA drives located behind a SAS controller would incorrectly receive
WRITE SAME commands. Tweak the heuristics so that:
- If REPORT SUPPORTED O
ormation. That seems a bit
excessive.
However, I personally don't care too much about 32-bit platforms, so...
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message
028] scsi0 : Areca SATA Host Adapter RAID
Nick> Controller
Nick> Driver Version 1.20.00.15 2010/08/05
Nick> [...]
Interesting. Please provide the output of:
# sg_inq /dev/sdd
# sg_vpd /dev/sdd
# sg_vpd -p ai /dev/sdd
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscrib
>>>>> "Bernd" == Bernd Schubert writes:
Bernd> I tested this patch with ARC-1260 and F/W V1.49, no issues.
It could be due to the firmware version discrepancy.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line &qu
read_write_same() function. But
how about we do the following instead?
--
Martin K. Petersen Oracle Linux Engineering
SCSI: Don't attempt to send extended INQUIRY command if skip_vpd_pages is set
If a device has the skip_vpd_pages flag set we should simply fail the
scsi_get_vpd_page() call
>>>>> "Alan" == Alan Stern writes:
Alan> In the case of these bug reports, the scsi_report_opcode() call
Alan> returns -EINVAL.
Oh, right. Because I actually do an explicit SCSI version check in
scsi_report_opcode(). That's OK, then...
--
Martin K. Petersen
erted next.
Doesn't matter as far as the sg commands are concerned...
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
boot but we're trying to find a good
blacklist trigger. And that's tricky given that Areca allows you
manually specify the SCSI model string for each volume...
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe
nn.
Alan> Martin, please submit your patch for inclusion in the stable
Alan> kernels as soon as possible.
James?
[PATCH] SCSI: Don't attempt to send extended INQUIRY command if skip_vpd_pages
is set
If a device has the skip_vpd_pages flag set we should simply fail the
scsi_get_vpd_pa
is to tweak the driver so that I can set
skip_vpd_pages for the ATA models. Under the assumption that the SAS
controllers actually feature the ATA Information VPD...
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi
een. I can try to
Bernd> confirm that tomorrow, I just need the system as it is till
Bernd> tomorrow noon.
That would be a great data point. I don't have any Areca boards.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line &
I-ATA Translation
layer. The controller firmware in this case.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ify it also works for you?
Do we get an appropriate error back when we try to issue WRITE SAME
10/16? If so, I'm OK with this fix.
And thanks for looking into this!
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe
scsi&m=137523956310061&w=2
http://marc.info/?l=linux-scsi&m=137536767805820&w=2
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
tree attached. Happy to forward port if there's
interest?
--
Martin K. Petersen Oracle Linux Engineering
commit 906b6af65cde77a13641a476b55879424bfaae24
Author: Martin K. Petersen
Date: Sat Aug 10 17:55:58 2013 -0400
megaraid_sas: Big endian support
This driver only
>>>>> "Martin" == Martin K Petersen writes:
And against upstream...
--
Martin K. Petersen Oracle Linux Engineering
commit 6d6db0df277b46ea538be5c70e89347436a8a114
Author: Martin K. Petersen
Date: Sat Aug 10 17:55:58 2013 -0400
megarai
reason I did cpu_to_le16(0) etc. was mostly to annotate the
endian-sensitive parameters in case somebody changes them in the future.
--
Martin K. Petersen Oracle Linux Engineering
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers/scsi/megaraid/megaraid_sas_base.c
index 7bf9c5
>>>>> "Kamaljit" == Kamaljit Singh writes:
Kamaljit> Did you get a chance to merge your changes into mainline? I'm
Kamaljit> using 3.10.4 and am still seeing this issue.
Thanks for the reminder. No, I'm still sitting on some PI patches that
need to be
gets rid
of the 32-bit DMA limitations on large systems. But I didn't want to
clutter the initial submission.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kern
algorithm used.
Also, I believe Akinobu's recent reorganization of this code in question
fixed the warning.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.ker
>>>>> "Doug" == Douglas Gilbert writes:
Doug> This is Martin's area of expertise so I hope he also acks it.
Doug> Acked-by: Douglas Gilbert
I believe I already did, but:
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
is UNMAP all over again, just 100 times worse :(
Anyway. Excited to see nab posting the patches! My copy offload code
from the spring has been getting stale both in the T10 and the kernel
sense. But at least we know what I'll be working on next week :)
--
Martin K. Petersen Oracle Linux
patch does not have few changes needed in function
Sumit> "megasas_init_fw()"(inside file: megaraid_sas_base.c),
Patches welcome!
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the bo
ort is missing from a later
version of the driver...
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
SAME and a block count of one. But it's really icky. And I don't like
the notion of actually writing things during discovery.
As far as being able to trigger a restacking of the queue limits I think
it's inevitable. We see more and more devices that change properties
after a firm
onding wrap around addresses.
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
copies protection info to prot_sglist.
Akinobu> This factors out the portion of copying protection info into a
Akinobu> separate function. It will also be reused in the next change
Akinobu> after supporting the opposite direction (copying prot_sglist to
Akinobu> dif_storep).
Acke
bu> This fixes it by changing the type of scsi_debug_guard to
Akinobu> 'unsigned int' instead of adding extra check for a negative
Akinobu> value.
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line &q
>>>>> "Akinobu" == Akinobu Mita writes:
Akinobu> Each member in data integrity field tuple is big-endian. But
Akinobu> the endianness of the values being compared with these members
Akinobu> are not annotated. So this fixes these sparse warnings.
Acked-by:
>>>>> "Keith" == Keith Busch writes:
Keith> The ref tag should be the device's physical LBA rather than the
Keith> 512 byte bio sector.
The bip sector is just a seed value set by the application. It is not
correct to scale it based on sector size or
if_storep is done after all blocks are successfully verified.
Akinobu> Reusing dif_copy_prot() with supporting the opposite direction
Akinobu> simplifies this fix.
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list
lacklisting a specific Seagate drive. However, skip_vpd_pages
is also set by USB.
I'm still completely in favor of your patch to reduce the VPD buffer
size. Please resubmit and feel free to add my Acked-by:.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list:
ENDED COPY, etc. The
advantage being that we do the matching at discovery time instead of
once a WRITE SAME is issued.
This would also permit HBA drivers to toggle the feature on a per
instance basis. I.e. if "RAID controller firmware rev is lower than XYZ,
do not support WRITE SAME".
g to fix
with his patch. Maybe it would make sense for us to use -EINVAL or
something similar to single out the ILLEGAL REQUEST case. While
-EREMOTEIO specifically calls out for "no retry" it might be helpful to
indicate that we're dealing with an unsupported command. That way
EGAL
REQUEST when you send down a command that can't be handled.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
unmap bug - I cannot
Bernd> unmap the last sector:
Yes, it appears there's an off-by-one bug in the UNMAP translation.
Sumit, is this something you guys can look into?
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe
that to avoid crashing.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Now that we sanity check the optimal I/O size reported by the device we
no longer need to blacklist the VPD pages on certain Seagate drives.
Signed-off-by: Martin K. Petersen
Cc: sta...@vger.kernel.org
---
drivers/scsi/scsi_devinfo.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
.
Reported-by: Chris Friesen
Signed-off-by: Martin K. Petersen
Cc: sta...@vger.kernel.org
---
drivers/scsi/sd.c | 3 ++-
drivers/scsi/sd.h | 9 +
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index ebf35cb64216..faf3725492ce 100644
--- a
Commit 4089b71cc820 blacklisted WRITE SAME for all VMware disks.
However, the WRITE SAME commands are supported for passthrough
disks. Change the heuristic so we only blacklist virtual disks.
Signed-off-by: Martin K. Petersen
Reported-by: Petr Vandrovec
Tested-by: Chris J Arges
Cc: sta
if the discard
request fails we will fall back to first REQ_WRITE_SAME and then a
regular REQ_WRITE.
Also update the callers of blkdev_issue_zero() to reflect the new flag
and make sb_issue_zeroout() prefer the discard approach.
Signed-off-by: Martin K. Petersen
Reviewed-by: Christoph Hellwig
t;max_xfer_blocks.
*blush*
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "Tapasweni" == Tapasweni Pathak writes:
Tapasweni> Remove null check on sdkp as it won't be null at this line.
Thanks for the heads up. It's actually a merge snafu. The check is
supposed to be if (!sdkp->ATO). I already have a patch in my q
on your
machine without the need for any hardware .
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "Olaf" == Olaf Hering writes:
Olaf> Does that target code offer what scsi_debug offers, a bunch of
Olaf> stuff listable with 'lsscsi'? The latter can be passed to
Olaf> backstores/pscsi.
Yes.
--
Martin K. Petersen Oracle Linux Engineerin
>>>>> "Sudip" == Sudip Mukherjee writes:
Sudip> we were dereferencing sdkp first and then we were checking for it
Sudip> being NULL.
http://marc.info/?l=linux-kernel&m=142564395705827&w=2
--
Martin K. Petersen Oracle Linux Engineering
--
To un
en if we would want to support a hack like this we'd do
Christoph> it genericly an not in a driver.
Agree completely.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
servation in adapter's sepcific functions.
This needs to be 7 patches and not 1.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
_check_prot(), go ahead and
nab> use it to allow protected fabrics to function with unprotected
nab> devices.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the bod
How do you handle RDPROTECT/WRPROTECT values of 3 if the PI is not
persistent?
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
n be exposed.
nab> This is required for fabric sessions supporting T10-PI metadata to
nab> backend devices that don't have protection enabled.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "un
>>>>> "nab" == Nicholas A Bellinger writes:
>> This patch moves the existing target_execute_cmd() check for
>> cmd->prot_op into it's own function, so it's easier to add future
>> support for WRITE STRIP.
nab> Makes sense. Renamed to
>>>>> "nab" == Nicholas A Bellinger writes:
nab> This patch adds WRITE_STRIP support in target_check_write_prot()
nab> that invokes sbc_dif_verify_write() for checking T10-PI metadata
nab> before submitting the I/O to a backend driver.
With Sagi's sugges
>>>>> "nab" == Nicholas A Bellinger writes:
nab> This patch moves the existing target_complete_ok_work() check for
nab> cmd-> prot_op into it's own function, so it's easier to add future
nab> support for READ INSERT.
Reviewed-by: Martin K. Pete
exchange protection
nab> information, and would like to function with un-protected devices.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majo
acklist. We could have an explicit whitelist as
well. But it begs the question: Why on earth are 3Par not following the
spec? And why don't they just fix their firmware to report the right
thing?
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line &q
which checks have
nab> been calculated based on WRPROTECT/RDPROTECT in
nab> sbc_set_prot_op_checks().
nab> Finally in sbc_check_prot(), if PROTECT is non-zero for a backend
nab> device with DIF disabled, and sess_prot_type is not set go ahead
nab> and return INVALID_CDB_FIELD.
Loo
in 7 patches and rest of the patches(2,3,4 and 5) will
Sumit> remain unchanged.
The other patches looked OK on their own. But it's probably best to
repost the whole series since you'll need a review from at least one
person other than me.
--
Martin K. Petersen Oracle Linux Engi
y failure.
Akinobu> This fixes it by invalidating protection info for the unmapped
Akinobu> region by filling with 0xff pattern. This change also adds
Akinobu> helper function fd_do_prot_fill() in order to reduce code
Akinobu> duplication with existing fd_format_prot().
Reviewe
bounce buffer altogether.
Looks like a nice cleanup to me.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
of 1 is
"DIF Type 1" so DIX should never get enabled.
But I'll take a look...
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The new integrity code did not correctly unregister the profile for SD
disks. Call blk_integrity_unregister() when we release a disk.
Signed-off-by: Martin K. Petersen
Reported-by: Sagi Grimberg
CC: sta...@vger.kernel.org # v3.17+
---
drivers/scsi/sd.c | 1 +
1 file changed, 1 insertion
3aec2f41a8bae introduced a merge error where we would end up check for
sdkp instead of sdkp->ATO. Fix this so we register app tag capability
correctly.
Signed-off-by: Martin K. Petersen
Cc: # v3.17+
---
drivers/scsi/sd_dif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
> read back you will see PI errors (you currently don't see those
Sagi> because your backend drive contains escape values I assume).
Sagi> I'd say the correct fix is to calc PI for the block
Indeed!
Sagi> and "write_same" it...
Well, the ref tag needs to be incremented
NULL as block
>>> layer didn't allocate it for WRITE_SAME.
Sagi> Actually this is a bug. Why didn't the initiator allocate
Sagi> integrity meta-data for WRITE_SAME? Looking at the code it looks
Sagi> like it should.
We don't issue WRITE SAME with PI so there is n
requirement that the device, if formatted with PI,
will generate and write the correct protection information when
WRPROTECT is 0.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
to them either.
What if you have an SSD behind one of them?
Stefan> Hence let's remove the no_report_opcodes and no_write_same
Stefan> blacklist flags so that these commands can be used on
Stefan> respectively capable targets.
I just erred on the side of caution. If you are happy
se by
always allocating 32-byte CDBs. Type 2 is a really rare corner case.
So while I agree we should handle the UA scenario correctly, I'm not
sure I agree with the fix. Why are you messing with Type 2 devices in
the first place? These should really only be used inside disk arrays.
--
then the drive will
Scott> return the PI interleaved with the data -- it's this raw
Scott> pass-through functionality that we need.
Also shouldn't be a problem.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
se to
improve this year's, please also send that to:
lsf...@lists.linux-foundation.org
Thank you on behalf of the program committee:
Storage:
Martin K. Petersen
Jens Axboe
James Bottomley
Filesystems:
Ric Wheeler
Christoph Hellwig
Jaeg
t. But the right way would be to pass the ref tag seed in as part
of the IOCB and let sd or the HBA hardware do the remapping.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
d by
the applications interested in this. It's a lot easier to tweak a few
IOCB fields than it is to rewrite how an application does I/O.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a mess
own tags in userspace is also
Ben> interesting.
However, the app tag is really only good for disk drives. Most array
vendors use it internally. And going forward we're going to use it for
access control instead of opaque storage. So exposing the application
tag space to userland applicat
>>>>> "Dan" == Dan Carpenter writes:
Dan> This patch wasn't applied.
Nope, but it hasn't been forgotten. I have it in my resubmit queue with
a couple of other stable fixes.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this
>>>>> "Darrick" == Darrick J Wong writes:
Darrick> Is there a newer one than this?
Darrick> https://oss.oracle.com/projects/oracleasm/files/sources/
UEK2 git.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line
an incorrect ref tag.
I have some patches in the pipeline that fixes this. They also add
support for protection intervals different from the logical block size.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi&quo
al_ BLOCK LIMITS VPD field was not specified (0).
My only real objection is that UINT_MAX appears to be completely
coincidental. What if the next drive specifies UINT_MAX-1 or $RANDOM?
Lacking a decent heuristic I'd rather just blacklist the offending drive
using the skip_vpd_pages knob we already
d
a sync_nv parameter to scsi_disk's sysfs that could be used to set that
bit when issuing flush_cmnd.
But it would be something we would do manually on a per-device basis and
not something that is automatically keyed off of NV_SUP (SYNC_NV doesn't
require NV_SUP, btw., so that's not even
the only
Akinobu> difference with scsi_debug_unmap_alignment == 0 is the logical
Akinobu> blocks from 0 to scsi_debug_unmap_alignment - 1 cannot be
Akinobu> unmapped. But the difference is not properly handled in the
Akinobu> current code.
Akinobu> So this prohibits such unusual setting.
Acke
701 - 800 of 3475 matches
Mail list logo
