/scsi_device.h
> index 50c2a36..99bde5a 100644
> --- a/include/scsi/scsi_device.h
> +++ b/include/scsi/scsi_device.h
> @@ -175,6 +175,7 @@ struct scsi_device {
> unsigned no_dif:1; /* T10 PI (DIF) should be disabled */
> unsigned broken_fua:1; /* Don't se
spin_lock_bh(&session->back_lock);
> + spin_lock(&session->back_lock);
> __iscsi_put_task(task);
> - spin_unlock_bh(&session->back_lock);
> + spin_unlock(&session->back_lock);
> return NULL;
> }
>
>
Reviewed-by: Lee
k, flags);
> beiscsi_log(phba, KERN_INFO, BEISCSI_LOG_CONFIG,
> "BM_%d : In free_mgmt_sgl_handle,"
> "eh_sgl_free_index=%d\n",
> @@ -1078,7 +1087,7 @@ free_mgmt_sgl_handle(struct beiscsi_hba *phba, struct
> sgl_handle *psg
signed __bitwise__ ieee80211_tx_result;
> +typedef unsigned __bitwise ieee80211_tx_result;
> #define TX_CONTINUE ((__force ieee80211_tx_result) 0u)
> #define TX_DROP ((__force ieee80211_tx_result) 1u)
> #define TX_QUEUED((__force ieee80211_tx_result) 2u)
> @@ -180,7 +180,7 @@ struct ieee80211_tx_data {
> };
>
>
> -typedef unsigned __bitwise__ ieee80211_rx_result;
> +typedef unsigned __bitwise ieee80211_rx_result;
> #define RX_CONTINUE ((__force ieee80211_rx_result) 0u)
> #define RX_DROP_UNUSABLE ((__force ieee80211_rx_result) 1u)
> #define RX_DROP_MONITOR ((__force ieee80211_rx_result) 2u)
>
For iscsi initiator, looks good.
Akced-by: Lee Duncan
--
Lee Duncan
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-Multipath on top of that, most bets are off on your
chances of getting it to reliably work.
I'd like to discuss how we can get this to work in a general way given
the world of systemd that we live in now.
--
Lee Duncan
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe
Acked-by: Lee Duncan
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/01/2016 10:45 PM, Mike Christie wrote:
> On 01/22/2016 01:49 PM, Lee Duncan wrote:
>> From: Hannes Reinecke
>>
>> Some older user-space code might rely on the netmask attribute
>> being present, so we should always display it.
>> This fixes
It turns out that IPv6 doesn't care about netmask, but
instead uses "prefix length" to determine the subnet, but
the iBFT subsystem still just supports netmask.
These two patches enable IPv6 iBFT (iscsi booting)
by adding support for IPv6 prefix and prefix length.
Open-iscsi changes to use these n
he netmask attribute
being present, so we should always display it.
Changes from v1:
- Combined two patches into one
Signed-off-by: Hannes Reinecke
Signed-off-by: Lee Duncan
---
drivers/firmware/iscsi_ibft.c| 4
drivers/scsi/iscsi_boot_sysfs.c | 5 +
include/linux/iscsi_boot_sysfs.
s for other topics:
As one of the maintainers of LIO at SUSE, I'd dearly love to see our
iSCSI targets merged.
I also would love to see multipath work in a sane way, and *with* the
SCSI subsystem, not on top of it, so I'd like to join that discussion.
--
Lee Duncan
--
To unsubscribe
On 02/27/2016 01:54 PM, Nicholas A. Bellinger wrote:
> On Sat, 2016-02-27 at 08:19 -0800, Lee Duncan wrote:
>> [Apologies for the resend.]
>>
>> I would like to attend LSF/MM this year. I would like to discuss
>> problems I've had dealing with LIO targets and the
On 02/29/2016 10:45 AM, Mike Christie wrote:
> On 02/25/2016 12:15 PM, Lee Duncan wrote:
>> From: Hannes Reinecke
>>
>> The iBFT table only specifies a prefix length, not a netmask.
>> And the netmask is pretty much pointless for IPv6.
>> So introduce a new attri
On 02/29/2016 01:04 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Feb 29, 2016 at 1:45 PM, Mike Christie wrote:
>> On 02/25/2016 12:15 PM, Lee Duncan wrote:
>>> From: Hannes Reinecke
>>>
>>> The iBFT table only specifies a prefix length, not a netmask.
>>
On 02/12/2016 09:54 AM, James Bottomley wrote:
> On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote:
>> The scsi_transport_iscsi module already uses the ida_simple
>> routines for managing the target ID, if requested to do
>> so. This change replaces an ever-increasing a
ormation(u8 *buf, int buf_len, u64
> info)
> put_unaligned_be64(info, &ucp[4]);
> } else if ((buf[0] & 0x7f) == 0x70) {
> buf[0] |= 0x80;
> - put_unaligned_be64(info, &buf[3]);
> + put_unaligned_be32((u32)info, &buf[3]);
ly
return "/var/target". Writing to this attribute
changes the loation where the kernel looks for the
target database.
** NOTE/QUESTION: no sanity checks are done on the path passed in,
but it seems like *some* should be done. At least checking that
it's an abosolute path (i
This commit updates the target core ALUA and PR
modules to use the new "dbroot" attribute instead
of assuming the target database is in "/var/target".
---
drivers/target/target_core_alua.c | 6 +++---
drivers/target/target_core_pr.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff
This commit adds the read-write attribute "dbroot", in
the top-level CONFIGFS (core) target directory,
normally /sys/kernel/config/target. This attribute
defaults to "/var/target" but can be changed by
writing a new pathname string to it.
Target modules that care about the target database
root dir
On 04/01/2016 12:58 AM, Johannes Thumshirn wrote:
> On 2016-03-31 20:05, Lee Duncan wrote:
>> This commit updates the target core ALUA and PR
>> modules to use the new "dbroot" attribute instead
>> of assuming the target database is in "/var/target".
>
On 04/01/2016 11:18 AM, Andy Grover wrote:
> On 04/01/2016 11:01 AM, Lee Duncan wrote:
>> On 04/01/2016 12:58 AM, Johannes Thumshirn wrote:
>>> On 2016-03-31 20:05, Lee Duncan wrote:
>>>> This commit updates the target core ALUA and PR
>>>> modules to use
On 04/02/2016 08:36 PM, Nicholas A. Bellinger wrote:
> On Thu, 2016-03-31 at 11:05 -0700, Lee Duncan wrote:
>> These patches make the location of "/var/target" configurable,
>> though it still defauls to "/var/target".
>>
>> This configuration is ac
sdkp->capacity = new_capacity << 3;
> + else if (sector_size == 2048)
> + sdkp->capacity = new_capacity << 2;
> + else if (sector_size == 1024)
> + sdkp->capacity = new_capacity << 1;
> + else
> +
This commit updates the target core ALUA and PR
modules to use the new "dbroot" attribute instead
of assuming the target database is in "/var/target".
Signed-off-by: Lee Duncan
---
drivers/target/target_core_alua.c | 6 +++---
drivers/target/target_core_pr.c | 2 +-
target database.
The first patch creates this configurable value for
the "dbroot", and the second patch modifies users
of this directory to use this new attribute.
Changes from v1:
* Only allow changing target DB root before it
can be used by others
* Validate that new DB root i
lowed when no fabric drivers
are loaded and the supplied value specifies an
existing directory.
Target modules that care about the target database
root directory will be modified to use this
attribute in a future commit.
Signed-off-by: Lee Duncan
---
drivers/target/target_
On 04/13/2016 11:10 PM, Hannes Reinecke wrote:
> On 04/13/2016 10:25 PM, Lee Duncan wrote:
>> This commit adds the read-write attribute "dbroot",
>> in the top-level CONFIGFS (core) target directory,
>> normally /sys/kernel/config/target. This attribute
>>
t before it
can be used by others
* Validate that new DB root is a valid directory
Lee Duncan (2):
target: make target db location configurable
target: use new "dbroot" target attribute
drivers/target/target_core_alua.c | 6 ++--
drivers/target/target_core_configfs.c | 62
This commit updates the target core ALUA and PR
modules to use the new "dbroot" attribute instead
of assuming the target database is in "/var/target".
Signed-off-by: Lee Duncan
Reviewed-by: Hannes Reinecke
---
drivers/target/target_core_alua.c | 6 +++---
drivers/target/ta
lowed when no fabric drivers
are loaded and the supplied value specifies an
existing directory.
Target modules that care about the target database
root directory will be modified to use this
attribute in a future commit.
Signed-off-by: Lee Duncan
---
drivers/target/target_
eh_bus_reset_handler = qla1280_eh_bus_reset,
> .eh_host_reset_handler = qla1280_eh_adapter_reset,
> .bios_param = qla1280_biosparam,
> - .can_queue = 0xf,
> + .can_queue = MAX_OUTSTANDING_COMMANDS,
> .this_id
On 04/14/2016 06:18 PM, Lee Duncan wrote:
> These patches make the location of "/var/target" configurable,
> though it still defauls to "/var/target".
>
> This "target database directory" can only be changed
> after the target_core_mod loads but before
Ping?
We really need to move the target database out of /var/target
On 04/14/2016 06:18 PM, Lee Duncan wrote:
> These patches make the location of "/var/target" configurable,
> though it still defauls to "/var/target".
>
> This "target database direc
CSI_BOOT_FLAG_VALID |
> ISCSI_BOOT_FLAG_FW_BOOT_SEL);
> break;
> case ISCSI_BOOT_TGT_NIC_ASSOC:
> rc = sprintf(str, "0\n");
> diff --git a/include/linux/iscsi_boot_sysfs.h
> b/include/linux/iscsi_boot_sysfs.h
> index 2a8b165..3f273
tests are needed now and in the future may be a good topic for
discussion.
--
Lee Duncan
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/17/2015 03:20 PM, Martin K. Petersen wrote:
>>>>>> "Lee" == Lee Duncan writes:
>
> Lee> Martin: I will be glad to update the patch, creating a modprobe
> Lee> parameter as suggested, if you find this acceptable.
>
> For development use a m
On 12/11/2015 07:31 AM, Ewan Milne wrote:
> On Thu, 2015-12-10 at 13:48 -0800, Lee Duncan wrote:
>> On 11/17/2015 03:20 PM, Martin K. Petersen wrote:
>>>>>>>> "Lee" == Lee Duncan writes:
>>>
>>> Lee> Martin: I will be glad to updat
l not a big ida fan but since the most people seem to be in favor of
> this I guess I'll have to bite the bullet.
>
> I don't see much value in the module parameter since it will require
> customers to tweak their configs and reproduce. Not worth the hassle.
>
Thank you Martin
On 12/17/2015 11:24 AM, Lee Duncan wrote:
> On 12/14/2015 05:55 PM, Martin K. Petersen wrote:
>>>>>>> "Hannes" == Hannes Reinecke writes:
>>
>>>> I'm not opposed to having the module option if others (Martin?) feel
>>>> they nee
ecause the hosts module already has its
own instance and locking mechanisms that aren't easily
changed.
Changes from v1:
* First version used regular ida routines
Reviewed-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
Signed-off-by: Lee Duncan
---
drivers/sc
On 01/05/2016 03:53 PM, Martin K. Petersen wrote:
"Lee" == Lee Duncan writes:
Lee> Do you need me to resubmit this patch now that it's accepted?
Please resend.
Thanks!
Done, submitted against scsi tree, misc branch.
--
Lee Duncan
--
To unsubscribe from this l
From: Hannes Reinecke
Some older user-space code might rely on the netmask attribute
being present, so we should always display it.
This fixes a regression introduced by commit
0b2eb3c4060a16f3ec11a4d6d4c934e7e5d5334f.
Signed-off-by: Hannes Reinecke
Signed-off-by: Lee Duncan
---
drivers
[Resending. Apologies if you get this twice.]
It turns out that IPv6 doesn't care about netmask, but
instead uses "prefix length" to determine the subnet, but
the iBFT subsystem still just supports netmask.
These two patches enable IPv6 iBFT (iscsi booting)
by adding support for IPv6 prefix and p
From: Hannes Reinecke
The iBFT table only specifies a prefix length, not a netmask.
And the netmask is pretty much pointless for IPv6.
So introduce a new attribute 'prefix-len' and display the
netmask attribute only for IPv4 addresses.
Signed-off-by: Hannes Reinecke
Signed-off-by:
and can be reused when the session
is freed.
Note that no maximum is placed on this value, though
user-space currently only seems to use the lower 24-bits.
It seems better to handle this in user space, though,
than to limit the value range for the session ID here.
Signed-off-by: Lee Duncan
On 09/01/2015 01:23 AM, Sagi Grimberg wrote:
> On 8/31/2015 11:28 PM, leeman.dun...@gmail.com wrote:
>> From: Lee Duncan
>>
>> Each Scsi_host instance gets a host number starting
>> at 0, but this is implemented with an atomic integer,
>> and rollover doe
On 09/01/2015 10:49 AM, Sagi Grimberg wrote:
> On 9/1/2015 8:38 PM, ldun...@suse.com wrote:
>> From: Lee Duncan
>>
>> Each Scsi_host instance gets a host number starting
>> at 0, but this is implemented with an atomic integer,
>> and rollover doesn't seem to
s use
Signed-off-by: Lee Duncan
Reviewed-by: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
---
drivers/scsi/hosts.c | 47 ++-
1 file changed, 38 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 8bb173e
On 09/01/2015 11:48 PM, Christoph Hellwig wrote:
> On Tue, Sep 01, 2015 at 05:03:28PM -0700, Lee Duncan wrote:
>> +static int host_get_index(int *index)
>> +{
>> +int error = -ENOMEM;
>> +
>> +do {
>> +if (!ida_pre_get(&host_index_ida,
�z��w���
> ���j:+v���w�j�mzZ+�ݢj"��!tml=
>
I disagree that it is a good idea to give non-root users permanent
access to the reservation commands. This can be used to coopt a disc,
including the root disc.
--
Lee Duncan
--
To unsubscribe from this list: send the line &quo
_host instances to use idr
to manage their instance numbers and to simplify
instance number to pointer lookups.
This also means that host instance numbers will be
reused, when available.
Signed-off-by: Lee Duncan
---
drivers/scsi/hosts.c | 59 +---
1
seem to have uniform calling sequences.
A separate patch sequence follows which will add helper routines
for the ida index functions.
Lee Duncan (1):
Update scsi hosts to use idr for host number mgmt
drivers/scsi/hosts.c | 59 +---
1 file changed
On 09/06/2015 12:32 AM, Sagi Grimberg wrote:
> On 9/5/2015 11:44 PM, Lee Duncan wrote:
>> This is an updated version of a patch I submitted a few days ago.
>>
>> The previous versions of this patch updated the scsi hosts module
>> to use the ida helper routines to all
On 09/06/2015 12:34 AM, Sagi Grimberg wrote:
> On 9/5/2015 11:44 PM, Lee Duncan wrote:
>> Each Scsi_host instance gets a host number starting
>> at 0, but this was implemented with an atomic integer,
>> and rollover wasn't considered. Another problem with
>> this
This simplifies the calling sequence to
acquire and to release an ida-managed index.
Signed-off-by: Lee Duncan
---
drivers/scsi/sd.c | 18 +++---
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 3b2fcb4fada0..0f855e48bc1d
tionally
test where the sd.c changes. I also tested the helper
functions using the hosts.c module, where they worked
fine, but those changes were later reverted in favor of
using idr there instead. (See previous patch series.)
Lee Duncan (6):
Add ida helper routines
SCSI: Update sd driver to use n
This simplifies the calling sequence to
acquire and to release an ida-managed index.
Signed-off-by: Lee Duncan
---
drivers/block/mtip32xx/mtip32xx.c | 22 --
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block
This simplifies the calling sequence to
acquire and to release an ida-managed index.
Note that the ida_destroy() calls here previously
had no locking, so this may close a race condition
when errors occur or when removing a soc.
Signed-off-by: Lee Duncan
---
drivers/base/soc.c | 17
This simplifies the calling sequence to
acquire and to release an ida-managed index.
Signed-off-by: Lee Duncan
---
drivers/block/rsxx/core.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c
index
This simplifies the calling sequence to
acquire and to release an ida-managed index.
Signed-off-by: Lee Duncan
---
drivers/block/nvme-core.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index
Clients of the ida API routinely follow the
same steps to allocate and ida index, as well
as to free said index. These helper routines
should make it a little easier to use these
APIs.
Signed-off-by: Lee Duncan
---
include/linux/idr.h | 42 ++
1 file
Oops. I see the subject is wrong on this patch.
I will wait for comments (if any) then re-submit the sequence.
On 09/06/2015 10:59 AM, Lee Duncan wrote:
> This simplifies the calling sequence to
> acquire and to release an ida-managed index.
>
> Note that the ida_destroy() calls her
On 09/06/2015 08:16 AM, Lee Duncan wrote:
> On 09/06/2015 12:34 AM, Sagi Grimberg wrote:
>> On 9/5/2015 11:44 PM, Lee Duncan wrote:
>>> Each Scsi_host instance gets a host number starting
>>> at 0, but this was implemented with an atomic integer,
>>> and rollove
could
have resulted in duplicate index allocation.
Signed-off-by: Lee Duncan
---
drivers/scsi/ch.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/ch.c b/drivers/scsi/ch.c
index dad959fcf6d8..2edf1f8883f9 100644
--- a/drivers/scsi/ch.c
+++ b/drivers
Signed-off-by: Lee Duncan
---
drivers/block/mtip32xx/mtip32xx.c | 22 --
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block/mtip32xx/mtip32xx.c
index 4a2ef09e6704..ccff4119b554 100644
--- a/drivers/block/mtip32xx
Signed-off-by: Lee Duncan
---
drivers/base/soc.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/base/soc.c b/drivers/base/soc.c
index 39fca01c8fa1..cf70c3246123 100644
--- a/drivers/base/soc.c
+++ b/drivers/base/soc.c
@@ -122,18 +122,7 @@ struct
Signed-off-by: Lee Duncan
---
drivers/block/nvme-core.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index d1d6141920d3..ab13833d4fde 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme
Signed-off-by: Lee Duncan
---
drivers/mmc/core/host.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index 99a9c9011c50..5aa2330f074c 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -40,9
Signed-off-by: Lee Duncan
---
drivers/block/rsxx/core.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c
index d8b2488aaade..dd23a0e85040 100644
--- a/drivers/block/rsxx/core.c
+++ b/drivers/block/rsxx
Signed-off-by: Lee Duncan
---
drivers/gpu/drm/virtio/virtgpu_vq.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c
b/drivers/gpu/drm/virtio/virtgpu_vq.c
index 1698669f4185..380947dad306 100644
--- a/drivers/gpu/drm/virtio
Signed-off-by: Lee Duncan
---
drivers/misc/tifm_core.c | 17 -
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/misc/tifm_core.c b/drivers/misc/tifm_core.c
index a511b2a713b3..46385f828a8f 100644
--- a/drivers/misc/tifm_core.c
+++ b/drivers/misc/tifm_core.c
Signed-off-by: Lee Duncan
---
drivers/scsi/sd.c | 20
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 3b2fcb4fada0..60b2ad918208 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2948,15 +2948,7 @@ static
Signed-off-by: Lee Duncan
---
drivers/mfd/rtsx_pcr.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
index a66540a49079..8ddefb8c5e64 100644
--- a/drivers/mfd/rtsx_pcr.c
+++ b/drivers/mfd/rtsx_pcr.c
@@ -1191,15
Signed-off-by: Lee Duncan
---
drivers/dca/dca-sysfs.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/dca/dca-sysfs.c b/drivers/dca/dca-sysfs.c
index 126cf295b198..8930707df295 100644
--- a/drivers/dca/dca-sysfs.c
+++ b/drivers/dca/dca-sysfs.c
Signed-off-by: Lee Duncan
---
drivers/md/dm.c | 22 +-
1 file changed, 5 insertions(+), 17 deletions(-)
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index f331d888e7f5..53d6895eb13d 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -2202,9 +2202,7 @@ static int
_Host instances to use idr
to manage their instance numbers and to simplify
instance number to pointer lookups.
This also means that host instance numbers will be
reused, when available.
Signed-off-by: Lee Duncan
---
drivers/scsi/hosts.c | 59
1
Signed-off-by: Lee Duncan
---
drivers/memstick/core/memstick.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/memstick/core/memstick.c b/drivers/memstick/core/memstick.c
index a0547dbf9806..8f40a3d5108b 100644
--- a/drivers/memstick/core
Signed-off-by: Lee Duncan
---
drivers/infiniband/core/uverbs_cmd.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/infiniband/core/uverbs_cmd.c
b/drivers/infiniband/core/uverbs_cmd.c
index bbb02ffe87df..1e5b2a66a501 100644
--- a/drivers/infiniband/core
not mark this patch series as "v2" since
the scope of the patch set has grown considerably
since my first submissions.
Summary: There is one patch that adds helper functions, 11
patches that use the new "idr" helper functions, and 5 that
use the new "ida" helper
Signed-off-by: Lee Duncan
---
drivers/scsi/st.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index b37b9b00c4b4..51e1ce721d9f 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -4265,11 +4265,8 @@ static int
:
idr_get_index_in_range
idr_get_index (in range 0,0)
idr_put_index
And for ida:
ida_get_index
ida_put_index
Signed-off-by: Lee Duncan
---
include/linux/idr.h | 102
1 file changed, 102 insertions(+)
diff --git a/include/linux/idr.h b/include/linux/idr.h
Signed-off-by: Lee Duncan
---
drivers/block/mtip32xx/mtip32xx.c | 22 --
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block/mtip32xx/mtip32xx.c
index 4a2ef09e6704..ccff4119b554 100644
--- a/drivers/block/mtip32xx
Signed-off-by: Lee Duncan
---
drivers/base/soc.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/base/soc.c b/drivers/base/soc.c
index 39fca01c8fa1..cf70c3246123 100644
--- a/drivers/base/soc.c
+++ b/drivers/base/soc.c
@@ -122,18 +122,7 @@ struct
Signed-off-by: Lee Duncan
---
drivers/block/nvme-core.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c
index d1d6141920d3..ab13833d4fde 100644
--- a/drivers/block/nvme-core.c
+++ b/drivers/block/nvme
Signed-off-by: Lee Duncan
---
drivers/block/rsxx/core.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c
index d8b2488aaade..dd23a0e85040 100644
--- a/drivers/block/rsxx/core.c
+++ b/drivers/block/rsxx
Signed-off-by: Lee Duncan
---
drivers/scsi/sd.c | 20
1 file changed, 4 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 3b2fcb4fada0..60b2ad918208 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2948,15 +2948,7 @@ static
Signed-off-by: Lee Duncan
---
drivers/dca/dca-sysfs.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/dca/dca-sysfs.c b/drivers/dca/dca-sysfs.c
index 126cf295b198..8930707df295 100644
--- a/drivers/dca/dca-sysfs.c
+++ b/drivers/dca/dca-sysfs.c
Signed-off-by: Lee Duncan
---
drivers/misc/tifm_core.c | 17 -
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/misc/tifm_core.c b/drivers/misc/tifm_core.c
index a511b2a713b3..46385f828a8f 100644
--- a/drivers/misc/tifm_core.c
+++ b/drivers/misc/tifm_core.c
Signed-off-by: Lee Duncan
---
drivers/mfd/rtsx_pcr.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
index a66540a49079..8ddefb8c5e64 100644
--- a/drivers/mfd/rtsx_pcr.c
+++ b/drivers/mfd/rtsx_pcr.c
@@ -1191,15
Signed-off-by: Lee Duncan
---
drivers/gpu/drm/virtio/virtgpu_vq.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c
b/drivers/gpu/drm/virtio/virtgpu_vq.c
index 1698669f4185..380947dad306 100644
--- a/drivers/gpu/drm/virtio
could
have resulted in duplicate index allocation.
Signed-off-by: Lee Duncan
---
drivers/scsi/ch.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/ch.c b/drivers/scsi/ch.c
index dad959fcf6d8..2edf1f8883f9 100644
--- a/drivers/scsi/ch.c
+++ b/drivers
Signed-off-by: Lee Duncan
---
drivers/scsi/st.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index b37b9b00c4b4..51e1ce721d9f 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -4265,11 +4265,8 @@ static int
Signed-off-by: Lee Duncan
---
drivers/md/dm.c | 22 +-
1 file changed, 5 insertions(+), 17 deletions(-)
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index f331d888e7f5..53d6895eb13d 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -2202,9 +2202,7 @@ static int
Signed-off-by: Lee Duncan
---
drivers/memstick/core/memstick.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/memstick/core/memstick.c b/drivers/memstick/core/memstick.c
index a0547dbf9806..8f40a3d5108b 100644
--- a/drivers/memstick/core
Signed-off-by: Lee Duncan
---
drivers/mmc/core/host.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index 99a9c9011c50..5aa2330f074c 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -40,9
Signed-off-by: Lee Duncan
---
drivers/infiniband/core/uverbs_cmd.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/infiniband/core/uverbs_cmd.c
b/drivers/infiniband/core/uverbs_cmd.c
index bbb02ffe87df..1e5b2a66a501 100644
--- a/drivers/infiniband/core
_Host instances to use idr
to manage their instance numbers and to simplify
instance number to pointer lookups.
This also means that host instance numbers will be
reused, when available.
Signed-off-by: Lee Duncan
---
drivers/scsi/hosts.c | 59
1
ons, and 5 that
use the new "ida" helper functions.
Lee Duncan (17):
1. Add ida and idr helper routines.
2. Update scsi hosts to use idr for host number mgmt
3. Update the st driver to use idr helper functions.
4. Update the ch driver to use idr helper functions.
5. Upda
:
idr_get_index_in_range
idr_get_index (in range 0,0)
idr_put_index
And for ida:
ida_get_index
ida_put_index
Signed-off-by: Lee Duncan
---
include/linux/idr.h | 102
1 file changed, 102 insertions(+)
diff --git a/include/linux/idr.h b/include/linux/idr.h
On 09/15/2015 11:05 AM, Mike Snitzer wrote:
> Subject should really be:
> "dm: update to use idr helper functions"
Yes, I grabbed the wrong part of the driver pathname.
Would it be better to resubmit just this patch, or to resubmit the series?
--
To unsubscribe from this list: send the line "unsu
er routines I was adding
in idr.h would not be needed.
If this is correct, I will supply a version 2 patch series that
addresses this issue as well as the two patch-naming issues that were
raised.
--
Lee Duncan
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
1 - 100 of 221 matches
Mail list logo