Re: [PATCH v2 04/10] phy: qcom-ufs-qmp-xx: Discard remove callback for drivers.

2016-10-26 Thread Kishon Vijay Abraham I
On Tuesday 18 October 2016 07:58 PM, Vivek Gautam wrote: > remove() callback does a phy_exit() only and nothing else now. remove callback calls a phy_power_off() ;-) -Kishon > The phy_exit() over the generic phy is called from the phy > consumer, and phy provider driver should not explicitly n

Re: [PATCH v5 02/11] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC

2017-02-26 Thread Kishon Vijay Abraham I
Hi, On Thursday 23 February 2017 12:20 AM, Alim Akhtar wrote: > On Fri, Feb 3, 2017 at 2:49 PM, Alim Akhtar wrote: >> Hi Kishon, >> >> >> On 11/19/2015 07:09 PM, Kishon Vijay Abraham I wrote: >>> >>> Hi, >>> >>> On Tuesday 17 Nove

Re: [PATCH v5 02/11] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC

2017-03-01 Thread Kishon Vijay Abraham I
Hi, On Tuesday 28 February 2017 01:51 PM, Alim Akhtar wrote: > Hi Kishon, > > On 02/28/2017 09:04 AM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Monday 27 February 2017 07:40 PM, Alim Akhtar wrote: >>> Hi Kishon, >>> >>> On 02/2

Re: [PATCH v5 02/11] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC

2017-03-06 Thread Kishon Vijay Abraham I
Hi, On Monday 06 March 2017 05:12 PM, Alim Akhtar wrote: > Hi Kishon > > On 03/01/2017 10:07 AM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Tuesday 28 February 2017 01:51 PM, Alim Akhtar wrote: >>> Hi Kishon, >>> >>> On 02/28/2017 09:04 A

Re: [PATCH v7 2/5] phy: qcom-ufs: add support for 20nm phy

2015-01-21 Thread Kishon Vijay Abraham I
hi, On Thursday 15 January 2015 08:02 PM, Yaniv Gardi wrote: > This change adds a support for a 20nm qcom-ufs phy that is required in > platforms that use ufs-qcom controller. > > Signed-off-by: Yaniv Gardi > > --- > drivers/phy/Makefile| 1 + > drivers/phy/phy-qcom-ufs-i.h

Re: [PATCH 01/10] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC

2015-09-17 Thread Kishon Vijay Abraham I
gwon Jeon > Signed-off-by: Alim Akhtar > Cc: Kishon Vijay Abraham I > --- > .../devicetree/bindings/phy/samsung-phy.txt| 22 ++ > drivers/phy/Kconfig|7 + > drivers/phy/Makefile |1 + > drivers/ph

Re: [RFC PATCH] phy: exynos-ufs: exynos_ufs_phy_calibrate() can be static

2015-10-13 Thread Kishon Vijay Abraham I
Hi, On Tuesday 13 October 2015 05:08 PM, Alim Akhtar wrote: > HI > How I am support to handle this patch? Should I just fix these warnings > in my patch or I just add this as a separate patch on the top of the > series? This series has not been merged yet. So you can fix this patch. Thanks Kisho

Re: [PATCH v4 02/11] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC

2015-10-14 Thread Kishon Vijay Abraham I
eungwon Jeon > Signed-off-by: Alim Akhtar > Cc: Kishon Vijay Abraham I > --- > drivers/phy/Kconfig|7 + > drivers/phy/Makefile |1 + > drivers/phy/phy-exynos-ufs.c | 257 > > drivers/phy/phy

Re: [PATCH v4 02/11] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC

2015-10-14 Thread Kishon Vijay Abraham I
On Wednesday 14 October 2015 09:43 PM, Alim Akhtar wrote: > Hi, > > On Wed, Oct 14, 2015 at 9:31 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Wednesday 14 October 2015 06:25 PM, Alim Akhtar wrote: >>> From: Seungwon Jeon >>> >>> Th

Re: [PATCH v4 11/11] scsi: ufs-exynos: add UFS host support for Exynos SoCs

2015-10-23 Thread Kishon Vijay Abraham I
Hi, On Thursday 15 October 2015 08:38 AM, Alim Akhtar wrote: > +CCing kishon Vijay, > > On 10/14/2015 06:25 PM, Alim Akhtar wrote: >> From: Seungwon Jeon >> >> This patch introduces Exynos UFS host controller driver, >> which mainly handles vendor-specific operations including >> link startup, p

Re: [PATCH v4 11/11] scsi: ufs-exynos: add UFS host support for Exynos SoCs

2015-10-28 Thread Kishon Vijay Abraham I
Hi, On Sunday 25 October 2015 05:34 PM, Alim Akhtar wrote: > Hi Kishon > Thanks again for you review. > > On Fri, Oct 23, 2015 at 8:48 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Thursday 15 October 2015 08:38 AM, Alim Akhtar wrote: >>> +CCing kisho

Re: [PATCH v5 00/11] exynos-ufs: add support for Exynos

2015-11-16 Thread Kishon Vijay Abraham I
Hi Alim, On Monday 16 November 2015 06:31 AM, Alim Akhtar wrote: > Hi Kishon, > > Any more concern on the PHY part of this series? Sorry for the late reply. Yes, I still have concerns. I'll comment on your patch. Thanks Kishon > > Thanks! > > On Mon, Nov 9, 2015 at 10:56 AM, Alim Akhtar wro

Re: [PATCH v5 02/11] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC

2015-11-16 Thread Kishon Vijay Abraham I
gwon Jeon > Signed-off-by: Alim Akhtar > Cc: Kishon Vijay Abraham I > --- > drivers/phy/Kconfig|7 ++ > drivers/phy/Makefile |1 + > drivers/phy/phy-exynos-ufs.c | 241 > > drivers/phy/phy-

Re: [PATCH v5 02/11] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC

2015-11-19 Thread Kishon Vijay Abraham I
Hi, On Tuesday 17 November 2015 01:41 PM, Alim Akhtar wrote: > Hi > Thanks again for looking into this. > > On 11/17/2015 11:46 AM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Monday 09 November 2015 10:56 AM, Alim Akhtar wrote: >>> From: Seungwon Jeon &

Re: [PATCH v2 3/5] ata: Add APM X-Gene SATA driver

2013-11-12 Thread Kishon Vijay Abraham I
ructure for SATA from what I can tell. It seems like I will >>> need to put this all together. I am thinking about porting the USB >>> version over (with changes for SATA) and put it under >>> "./drivers/ata/phy". Any suggestion? >> >> Please have

Re: [PATCH v2 3/5] ata: Add APM X-Gene SATA driver

2013-11-12 Thread Kishon Vijay Abraham I
per layer can call? > > -Loc > > On Tue, Nov 12, 2013 at 9:20 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Wednesday 13 November 2013 04:09 AM, Loc Ho wrote: >>> Hi Arnd, >>> >>> I looked at the PHY generic framework and come across this

Re: [PATCH v2 3/5] ata: Add APM X-Gene SATA driver

2013-11-13 Thread Kishon Vijay Abraham I
ease do not top post :-) Thanks Kishon > > -Loc > > On Tue, Nov 12, 2013 at 9:55 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Wednesday 13 November 2013 11:03 AM, Loc Ho wrote: >>> Hi, >>> >>> If I need to call a function into the PHY d

Re: [PATCH v3 3/4] ata: Add APM X-Gene SoC SATA host controller driver

2013-11-26 Thread Kishon Vijay Abraham I
Hi, On Wednesday 20 November 2013 02:52 AM, Loc Ho wrote: > Hi Kishon, > + +/* Temporary function until the PHY parameter API */ +extern void xgene_ahci_phy_set_pq(struct phy *phy, int chan, int data); +extern void xgene_ahci_phy_set_spd(struct phy *phy, int chan, int gen); >>

Re: [PATCH v3 3/4] ata: Add APM X-Gene SoC SATA host controller driver

2013-11-26 Thread Kishon Vijay Abraham I
On Tuesday 26 November 2013 10:11 PM, Loc Ho wrote: > Hi, > >>> int set_speed(struct *phy, int lane, u64 speed); >> >> it should be phy_set_speed. > [Loc Ho] > But your other functions don't repeat the prefix "phy"? refer include/linux/phy/phy.h.. int phy_init(struct phy *phy); int phy_exit(stru

Re: [PATCH v13 3/3] arm64: Add APM X-Gene SoC AHCI SATA host controller DTS entries

2014-02-24 Thread Kishon Vijay Abraham I
Hi, On Tuesday 25 February 2014 06:44 AM, Loc Ho wrote: > Hi Tejun, > > On Sun, Feb 23, 2014 at 10:54:25PM -0700, Loc Ho wrote: > > Signed-off-by: Loc Ho mailto:l...@apm.com>> > > Signed-off-by: Tuan Phan mailto:tp...@apm.com>> > > Signed-off-by: Suman Tripathi

Re: [PATCH v13 2/3] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-03-06 Thread Kishon Vijay Abraham I
Hi, On Thursday 06 March 2014 04:13 AM, Loc Ho wrote: This patch adds support for the APM X-Gene SoC 15Gbps Multi-purpose PHY. This is the physical layer interface for the corresponding host controller. Currently, only external clock and Gen3 SATA mode are supported. Signed-off-by: Loc Ho Sign

Re: [PATCH v15 3/3] arm64: Add APM X-Gene SoC 15Gbps Multi-purpose PHY DTS entries

2014-03-10 Thread Kishon Vijay Abraham I
/kishon/linux-phy.git tags/for_3.15 Btw you can add my Acked-by: Kishon Vijay Abraham I for this patch. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [PATCH v1 5/8] scsi: ufs: qcom: Expose the reset controller for PHY

2019-01-16 Thread Kishon Vijay Abraham I
On 12/01/19 4:31 AM, Evan Green wrote: > Expose a reset controller that the phy can use to perform its > initialization in a single callback. > > Also, change the use of the phy functions from ufs-qcom such that > phy_poweron actually fires up the phy, and phy_poweroff actually > powers it down

Re: [PATCH v3 6/8] scsi: ufs: qcom: Expose the reset controller for PHY

2019-02-06 Thread Kishon Vijay Abraham I
On 06/02/19 12:29 AM, Evan Green wrote: > Expose a reset controller that the phy will later use to control its > own PHY reset in the UFS controller. This will enable the combining > of PHY init functionality into a single function. > > Signed-off-by: Evan Green I'd like to get ACK from scsi/

Re: [PATCH v3 6/8] scsi: ufs: qcom: Expose the reset controller for PHY

2019-02-06 Thread Kishon Vijay Abraham I
Hi Marc, On 06/02/19 5:24 PM, Marc Gonzalez wrote: > On 06/02/2019 12:42, Kishon Vijay Abraham I wrote: > >> On 06/02/19 12:29 AM, Evan Green wrote: >> >>> Expose a reset controller that the phy will later use to control its >>> own PHY reset in the UFS contro

Re: [PATCH v5 6/7] phy: mediatek: Add UFS M-PHY driver

2019-03-14 Thread Kishon Vijay Abraham I
Hi, On 14/03/19 9:38 AM, Stanley Chu wrote: > Add UFS M-PHY driver on MediaTek chipsets. > > Signed-off-by: Stanley Chu > Reviewed-by: Chunfeng Yun > --- > drivers/phy/mediatek/Kconfig | 11 ++ > drivers/phy/mediatek/Makefile | 1 + > drivers/phy/mediatek/phy-mtk-ufs.c | 239

Re: [PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

2017-08-08 Thread Kishon Vijay Abraham I
Hi, On Friday 04 August 2017 12:18 PM, Vivek Gautam wrote: > Refactoring the qcom-ufs phy and host controller code to move > further towards the generic phy usage. Right now the qcom-ufs exports > a bunch of APIs that are used by the host controller to initialize > the phy. > With this patch serie

Re: [PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

2017-08-08 Thread Kishon Vijay Abraham I
Vivek, On Tuesday 08 August 2017 09:20 PM, Vivek Gautam wrote: > Hi Koshon, > > On 2017-08-08 17:39, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Friday 04 August 2017 12:18 PM, Vivek Gautam wrote: >>> Refactoring the qcom-ufs phy and host controller code to

Re: [PATCH 0/3] scsi: ufs-qcom: Remove all direct calls to qcom-ufs phy

2018-09-24 Thread Kishon Vijay Abraham I
Hi Vivek, On Tuesday 04 September 2018 03:47 PM, Vivek Gautam wrote: > Cleaning up the ufs-qcom host further to remove all direct calls > into qcom-ufs driver. > Only phy-qcom-ufs-qmp-20nm phy handles these direct calls from ufs host > and this phy is not used in any supported qcom platform in cur

Re: [PATCH v4] scsi: ufs: add support of generic PHY and ICE in Qualcomm chips

2014-12-05 Thread Kishon Vijay Abraham I
On Thursday 04 December 2014 09:24 PM, Christoph Hellwig wrote: > On Thu, Nov 27, 2014 at 05:59:58PM +0200, Yaniv Gardi wrote: >> In this change we add support to the generic PHY framework. >> Two UFS phys are implemented: >> qmp-20nm and qmp-28nm. >> >> Also, the files in this change implement t

Re: [PATCH v6 1/4] phy: qcom-ufs: add support for 20nm phy

2015-01-15 Thread Kishon Vijay Abraham I
Hi, On Sunday 11 January 2015 06:08 PM, Yaniv Gardi wrote: > This change adds a support for a 20nm qcom-ufs phy that is required in > platforms that use ufs-qcom controller. > > Signed-off-by: Yaniv Gardi > > --- > drivers/phy/Kconfig | 7 + > drivers/phy/Makefile

Re: [PATCH v2 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

2017-10-18 Thread Kishon Vijay Abraham I
On Thursday 12 October 2017 11:49 AM, Vivek Gautam wrote: > Refactoring the qcom-ufs phy and host controller code to move > further towards the generic phy usage. Right now the qcom-ufs exports > a bunch of APIs that are used by the host controller to initialize > the phy. > With this patch serie