Re: [PATCH] scsi_io_completion cleanup and fix CONDITION MET handling

2018-02-27 Thread Johannes Thumshirn
e SCSI Midlayer: https://www.spinics.net/lists/linux-scsi/m sg105428.html So please don't use it. -- Johannes Thumshirn                                          Storage jthumshi r...@suse.de                                +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix

Re: [PATCH] scsi: sd: Keep disk read-only when re-reading partition

2018-03-02 Thread Johannes Thumshirn
dev/sda > 3. blockdev --getro /dev/sda hi Jeremy, Do you mind wiring up a testcase in blktest [1] for this? Given that you already have a rather trivial reproducer. [1] https://github.com/osandov/ Thanks, Johannes -- Johannes Thumshirn St

Re: [PATCH] scsi: sd: Keep disk read-only when re-reading partition

2018-03-02 Thread Johannes Thumshirn
On Fri, Mar 02, 2018 at 02:11:02PM +, Jeremy Cline wrote: > Sure, I'll take care of it. Thanks a lot. Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfe

Re: [PATCH 5/5] scsi_io_completion: convert BUGs to WARNs

2018-03-09 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 4/5] scsi_io_completion: conditional hints on fastpath

2018-03-09 Thread Johannes Thumshirn
ise? Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint

Re: [PATCH 4/5] scsi_io_completion: conditional hints on fastpath

2018-03-14 Thread Johannes Thumshirn
good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH v2 01/13] qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe

2018-03-15 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 02/13] qla2xxx: Set IIDMA and fcport state before qla_nvme_register_remote()

2018-03-15 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 03/13] qla2xxx: Add changes for devloss timeout in driver

2018-03-15 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 04/13] qla2xxx: Restore ZIO threshold setting

2018-03-15 Thread Johannes Thumshirn
I'd really appreciate a more verbose changelog. No only on this patch, but in general. Anyways, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfe

Re: [PATCH v2 06/13] qla2xxx: Fix n2n_ae flag to prevent dev_loss on PDB change

2018-03-15 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 05/13] qla2xxx: Add FC-NVMe abort processing

2018-03-15 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 07/13] qla2xxx: Return busy if rport going away

2018-03-15 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 08/13] qla2xxx: Remove nvme_done_list

2018-03-15 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 09/13] qla2xxx: Fix retry for PRLI RJT with reason of BUSY

2018-03-15 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 10/13] qla2xxx: Fix FC-NVMe IO abort during driver reset

2018-03-15 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 11/13] qla2xxx: Cleanup code to improve FC-NVMe error handling

2018-03-15 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 13/13] qla2xxx: Update driver version to 10.00.00.06-k

2018-03-15 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 1/5] scsi_io_completion: rename variables and comments

2018-03-16 Thread Johannes Thumshirn
, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)

Re: [PATCH 2/5] scsi_io_completion: add _nz_result helper

2018-03-16 Thread Johannes Thumshirn
be set */ > + blk_stat = BLK_STS_OK; I see this is just copied over but it isn't really intuitive to the reader. OTOH if (!(sshdr.asc == 0x0 && sshdr.ascq == 0x1d) && !(req->rq_flags & RQF_QUIET))

Re: [PATCH 3/5] scsi_io_completion: add _action helper function

2018-03-16 Thread Johannes Thumshirn
Apart from the commit message, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH v2 6/6] scsi_io_completion convert BUGs to WARNs

2018-03-19 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 3/6] scsi_io_completion_nz_result function added

2018-03-19 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] scsi: unexport scsi_host_set_state

2018-03-19 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v4 13/13] qla2xxx: Update driver version to 10.00.00.06-k

2018-03-21 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH 1/2] smartpqi: workaround fw bug for oq deletion

2018-03-22 Thread Johannes Thumshirn
QI > reset that is part of the error recovery path. Please remove the '-' and left align the commit message. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE

Re: [PATCH 1/2] smartpqi: workaround fw bug for oq deletion

2018-03-22 Thread Johannes Thumshirn
On Thu, Mar 22, 2018 at 09:34:17AM +0100, Johannes Thumshirn wrote: > On Wed, Mar 21, 2018 at 01:32:31PM -0500, Don Brace wrote: > > From: Kevin Barnett > > > > - skip deleting PQI operational queues when there is > > an error creating a new queue group. I

Re: [PATCH 1/2] smartpqi: workaround fw bug for oq deletion

2018-03-22 Thread Johannes Thumshirn
On Thu, Mar 22, 2018 at 08:45:33AM -0400, Martin K. Petersen wrote: > > And he already removed the '-' and left aligned the commit message :) Thanks a lot :) -- Johannes Thumshirn Storage jthumsh...@suse.de

[PATCH] scsi: don't look for NULL devices handlers by name

2018-03-23 Thread Johannes Thumshirn
st on NULL names. Signed-off-by: Johannes Thumshirn --- drivers/scsi/scsi_dh.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c index b88b5dbbc444..188f30572aa1 100644 --- a/drivers/scsi/scsi_dh.c +++ b/drivers/scsi/scsi_dh.c @@ -112,6 +

Re: [PATCH v3 5/7] scsi_io_completion_reprep helper added

2018-03-28 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v5 2/7] scsi_io_completion rename variables

2018-03-29 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v5 3/7] scsi_io_completion_nz_result function added

2018-03-29 Thread Johannes Thumshirn
Looks good (as far as I can tell) Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH 00/10] Improve qla2xxx coding style

2019-04-12 Thread Johannes Thumshirn
t once (another > 20 patches will follow at a later time). Please consider these patches for > kernel v5.2. For the whole series, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911

Re: [PATCH] Revert "scsi: fcoe: clear FC_RP_STARTED flags when receiving a LOGO"

2019-04-18 Thread Johannes Thumshirn
This is missing you Signed-off-by -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key

Re: [scsi:misc 301/301] drivers/scsi/fdomain.c:442:12: sparse: sparse: context imbalance in 'fdomain_host_reset' - wrong count at exit

2019-05-01 Thread Johannes Thumshirn
ck, flags); > 92408047 Ondrej Zary 2019-04-29 449 fdomain_reset(fd->base); > 92408047 Ondrej Zary 2019-04-29 450 > spin_lock_irqsave(sh->host_lock, flags); That should be a spin_unlock_irqrestore() here ~^ Otherwise this would end badly. -- Johannes Thumshirn

Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

2019-07-02 Thread Johannes Thumshirn
0min vs. half a minute. > > The problem is still present in last tested git (cloned today in the > morning). > > You can see the previous discussion that lead to these results at > > https://marc.info/?t=15592223071&r=1&w=2 Hi, Can you please check what IO schedule

Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

2019-07-03 Thread Johannes Thumshirn
On Wed, Jul 03, 2019 at 12:36:30AM +0200, Andrea Vai wrote: > On 02/07/19 13:51:17, Johannes Thumshirn wrote: > > On Tue, Jul 02, 2019 at 12:46:45PM +0200, Andrea Vai wrote: > > > Hi, > > > I have a problem writing data to a USB pendrive, and it seems > > > k

Re: [PATCH v4 02/22] sg: remove typedefs, type+formatting cleanup

2019-08-29 Thread Johannes Thumshirn
Highly appreciated, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nürnberg Germany (HRB 247165, AG München) Key

Re: [PATCH v5 00/13] scsi: core: fix uninit-value access of variable sshdr

2019-10-20 Thread Johannes Thumshirn
Let me search for it. Johannes -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nürnberg Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Fe

Re: [PATCH V5 1/9] blk-mq: grab .q_usage_counter when queuing request from plug code path

2019-04-12 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG

Re: [PATCH V5 2/9] blk-mq: move cancel of requeue_work into blk_mq_release

2019-04-12 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG

Re: [PATCH 0/3] libfc: fix potential timer list corruption

2017-05-31 Thread Johannes Thumshirn
o you need to move the 'pending' and 'requested' settings? With an a bit more verbose changelog Acked-by: Johannes Thumshirn for the whole series -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911

Re: [PATCH] Fix few small typos in fcoe.c

2017-06-01 Thread Johannes Thumshirn
On 06/01/2017 02:05 PM, Milan P. Gandhi wrote: > This patch does a cleanup and fixes few small typos in fcoe.c > > Signed-off-by: Milan P. Gandhi > --- Looks good, Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthums

Re: [PATCH] Remove an extra out label in _fcoe_create function

2017-06-01 Thread Johannes Thumshirn
On 06/01/2017 02:08 PM, Milan P. Gandhi wrote: > This patch removes an extra out label in _fcoe_create function > where we return if creation of FCOE interface is failed. > > Signed-off-by: Milan P. Gandhi > --- Thanks, Acked-by: Johannes Thumshirn -- Joh

Re: [PATCH] Eliminate extra 'out_free' label from fcoe_init function

2017-06-01 Thread Johannes Thumshirn
On 06/01/2017 02:11 PM, Milan P. Gandhi wrote: > Simplify the check for return code of fcoe_if_init routine > in fcoe_init function such that we could eliminate need for > extra 'out_free' label. > > Signed-off-by: Milan P. Gandhi > --- Ahm and what happens to the

Re: [PATCH blktests v2 0/3] Add SCSI generic test group

2017-06-07 Thread Johannes Thumshirn
tests if it makes sense to run them on a real > device. Thanks! Yes I wanted to go to it tomorrow and send you a v3, I got stuck in NVMe ;-). Thanks for applying it anyways, I'll send a follow up. Johannes -- Johannes Thumshirn Storag

Re: [PATCH] storvsc: use default I/O timeout handler for FC devices

2017-06-13 Thread Johannes Thumshirn
-by: Long Li > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [ANNOUNCE]: Broadcom (Emulex) FC Target driver - efct

2017-06-13 Thread Johannes Thumshirn
o unnecessary camelCase, etc... The cyclomatic complexity GCC plugin we have in scripts/gcc-plugins could be of help here, though I only have read about it and never really used myself. -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH v2 1/2] libsas: Don't process sas events in static works

2017-06-14 Thread Johannes Thumshirn
gt; > void sas_hae_reset(struct work_struct *work) > { > - struct sas_ha_event *ev = to_sas_ha_event(work); > - struct sas_ha_struct *ha = ev->ha; > - > - clear_bit(HAE_RESET, &ha->pending); > } I don't really get why you need a stubbed out sas_hae_reset().

Re: [PATCH v2 2/2] libsas: Enhance libsas hotplug

2017-06-14 Thread Johannes Thumshirn
e >we use former wait-complete to achieve a sas event atomic process and use > latter to >make a sas discovery sync. > 4. remove disco_mutex in sas_revalidate_domain, since now > sas_revalidate_domain sync >the destruct discovery event execution, it's no n

Re: [PATCH v2 1/2] libsas: Don't process sas events in static works

2017-06-14 Thread Johannes Thumshirn
sas_ha_struct { * their siblings when forming wide ports */ /* LLDD calls these to notify the class of an event. */ - void (*notify_ha_event)(struct sas_ha_struct *, enum ha_event); + int (*notify_ha_event)(

Re: [PATCH v2] storvsc: use default I/O timeout handler for FC devices

2017-06-14 Thread Johannes Thumshirn
return fc_eh_timed_out(scmnd); > +#endif Can you please change the #if IS_ENABLED() to if(IS_ENABLED(CONFIG_SCSI_FC_ATTRS) && scmnd->device->host->transportt == fc_transport_template) That way we have better compiler coverage. Thanks, Johannes -- Johannes Th

[PATCH] scsi: sas: scsi_queue_work can fail, so make callers aware

2017-06-14 Thread Johannes Thumshirn
the caller, which is handy when changing to dynamically allocated work in libsas as well, as discussed here: https://lkml.org/lkml/2017/6/14/121. Signed-off-by: Johannes Thumshirn --- drivers/scsi/libsas/sas_event.c| 36 ++-- drivers/scsi/libsas/sas_inter

Re: [PATCH] scsi: sas: scsi_queue_work can fail, so make callers aware

2017-06-14 Thread Johannes Thumshirn
On 06/14/2017 02:57 PM, John Garry wrote: > On 14/06/2017 12:52, Johannes Thumshirn wrote: >> libsas uses scsi_queue_work() to queue it's internal event >> notifications. scsi_queue_work() can return -EINVAL if the work queue >> doesn't exist and it does call queue_w

Re: [PATCH 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling

2017-06-19 Thread Johannes Thumshirn
> + > + if ((fcport->fw_login_state == DSC_LS_PLOGI_PEND) || > + (fcport->fw_login_state == DSC_LS_PLOGI_COMP) || > + (fcport->fw_login_state == DSC_LS_PRLI_PEND)) > + return rval; Minor nit, superfluous parenthesis. Anyways, Reviewed

Re: [PATCH 2/6] qla2xxx: Add FC-NVMe command handling

2017-06-19 Thread Johannes Thumshirn
s_entry_24xx *)tsk; No need to cast from void* Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer

Re: mptsas crash on expander hot-remove

2017-06-19 Thread Johannes Thumshirn
On Fri, Jun 16, 2017 at 07:57:08PM -0400, Will Simoneau wrote: > Is this is a known / obvious issue, or should I try to bisect it? This is a known issue with SAS (and FC) drivers, although no soulution exists to this point. Johannes -- Johannes Thumsh

Re: [PATCH 3/6] qla2xxx: Add FC-NVMe F/W initialization and transport registration

2017-06-19 Thread Johannes Thumshirn
st_for_each_entry_safe()? > + fcport = rport->fcport; > + ql_log(ql_log_info, fcport->vha, 0x2114, > + "%s: fcport=%p\n", __func__, fcport); > + nvme_fc_unregister_remote

Re: [PATCH 4/6] qla2xxx: Send FC4 type NVMe to the management server

2017-06-19 Thread Johannes Thumshirn
g(ql_dbg_disc, vha, 0x2049, ) > + ql_dbg(ql_dbg_disc, vha, 0x2049, > + "Register NVME FC Type Features > failed.\n"); > + } > + } -- Johannes Thumshirn

Re: [PATCH 5/6] qla2xxx: Use FC-NMVe FC4 type for FDMI registration

2017-06-19 Thread Johannes Thumshirn
bit more of a change log would be highly apprechiated. Other than that, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Im

Re: [PATCH 6/6] qla2xxx: Update Driver version to 10.00.00.00-k

2017-06-19 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 4/6] qla2xxx: Send FC4 type NVMe to the management server

2017-06-21 Thread Johannes Thumshirn
nd I think you forgot to Cc the linux-nvme [1] list on your submission. It would be good to have it on linux-nvme as well as on linux-scsi so Sagi, Christoph and Keith see it as well. Byte, Johannes [1] linux-n...@lists.infradead.org -- Johannes Thumshirn

Re: [PATCH] qla2xxx: don't include

2017-06-21 Thread Johannes Thumshirn
se string. > > Signed-off-by: Johannes Berg > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Ime

Re: [PATCH] lpfc: Fix nvme io stoppage after link bounce

2017-06-22 Thread Johannes Thumshirn
anymore? Thanks, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284

Re: [PATCH] lpfc: fix refcount error on node list

2017-06-22 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 3/6] qla2xxx: Add FC-NVMe F/W initialization and transport registration

2017-06-22 Thread Johannes Thumshirn
ENABLED(CONFIG_NVME_FC)) > +int ql2xnvmeenable = 1; > +#else > +int ql2xnvmeenable; > +#endif > +module_param(ql2xnvmeenable, int, 0644); > +MODULE_PARM_DESC(ql2xnvmeenable, > +"Enables NVME support. " > +"0 - no NVMe. Default is Y&qu

Re: [PATCH v2 4/6] qla2xxx: Send FC4 type NVMe to the management server

2017-06-22 Thread Johannes Thumshirn
On Wed, Jun 21, 2017 at 01:48:44PM -0700, Madhani, Himanshu wrote: Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409

Re: [PATCH v2 5/6] qla2xxx: Use FC-NMVe FC4 type for FDMI registration

2017-06-22 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 1/2] hpsa: limit transfer length to 1MB

2017-06-22 Thread Johannes Thumshirn
bsc#1025461 and our internal Bugzilla IDs How about: The hpsa firmware will bypass the cache for any requests larger than 1MB, so we shoould cap the request size to avoid any performance regressions in kernels later than 4.3 The same applies for Patch 2/2 -- J

[PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-22 Thread Johannes Thumshirn
In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the qpair->qp_lock but do access members of the qpair before having the lock. Re-order the locking sequence to have all read and write access to qpair members under the qpair->qp_lock. Signed-off-by: Johannes Thumshirn --- d

Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-22 Thread Johannes Thumshirn
On Thu, Jun 22, 2017 at 03:19:27PM +0100, John Garry wrote: > On 22/06/2017 14:43, Johannes Thumshirn wrote: > >In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > >qpair->qp_lock but do access members of the qpair before having the lock. > >Re-order the

Re: [PATCH] lpfc: Fix nvme io stoppage after link bounce

2017-06-22 Thread Johannes Thumshirn
> on ndlp state are needed, there is no race. Thanks for the explanation -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smit

Re: [PATCH v2 3/6] qla2xxx: Add FC-NVMe F/W initialization and transport registration

2017-06-22 Thread Johannes Thumshirn
funtions have a semantic that after the registration is done the object can be used and thus assigning private pointer afterwards is an error. Damn I didn't realize this in the nmve-fc review. -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH v2 3/6] qla2xxx: Add FC-NVMe F/W initialization and transport registration

2017-06-22 Thread Johannes Thumshirn
> >`-> blk_mq_dispatch_rq_list() > >`-> nvme_fc_queue_rq() > >`-> nvme_fc_start_fcp_op() > >`-> qla_nvme_post_cmd() > > isn't called from an IRQ context and qla2xxx_get_qpair_sp() internally > > uses mempo

[PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

2017-06-23 Thread Johannes Thumshirn
In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the qpair->qp_lock but do access members of the qpair before having the lock. Re-order the locking sequence to have all read and write access to qpair members under the qpair->qp_lock. Signed-off-by: Johannes Thumshirn --- d

Re: [PATCH] bnx2i: missing error code in bnx2i_ep_connect()

2017-06-23 Thread Johannes Thumshirn
I driver.") > Signed-off-by: Dan Carpenter > Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F

Re: [PATCH v2 1/2] hpsa: limit transfer length to 1MB

2017-06-23 Thread Johannes Thumshirn
is caused from d2be537c3ba3568acd79cd178327b842e60d035e, > which changed max_sectors_kb to 1280k, but the hardware is able to > work fine with it, so the true fix should be from hpsa driver. > > Signed-off-by: Yadan Fan > --- Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH v2 2/2] smartpqi: limit transfer length to 1MB

2017-06-23 Thread Johannes Thumshirn
is caused from d2be537c3ba3568acd79cd178327b842e60d035e, > which changed max_sectors_kb to 1280k, but the hardware is able to > work fine with it, so the true fix should be from smartpqi driver. > > Signed-off-by: Yadan Fan > --- Reviewed-by: Johannes Thu

Re: [PATCH] scsi: aacraid: Don't copy uninitialized stack memory to userspace

2017-06-23 Thread Johannes Thumshirn
3400e64d377 ("scsi: aacraid: Include HBA direct interface") > Fixes: c799d519bf088 ("scsi: aacraid: Retrieve HBA host information ioctl") > Signed-off-by: Seth Forshee > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn

Re: [PATCH] Remove the definition of VLC_SA_RECEIVE_CREDENTIAL

2017-06-26 Thread Johannes Thumshirn
off-by: Bart Van Assche > Cc: Christoph Hellwig > Cc: Hannes Reinecke > Cc: Johannes Thumshirn > --- Thanks Bart, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 6

Re: [PATCH RESEND] scsi: Add STARGET_CREATED_REMOVE state to scsi_target_state

2017-06-28 Thread Johannes Thumshirn
will take the wrong path. The end > result is a panic: Looks good, Reviewed-by: Johannes Thumshirn Although we've been tampering with the target removal code for quite some time now, so I really have the gut feeling we haven't really fixed the root cause yet. I once tried building a regr

Re: [PATCH 01/28] scsi: fix comment in scsi_device_set_state()

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 03/28] ibmvfc: Do not call fc_block_scsi_eh() on host reset

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 02/28] mptfc: Do not call fc_block_scsi_eh() on host reset

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 04/28] fc_fcp: do not call fc_block_scsi_eh() from host reset

2017-06-28 Thread Johannes Thumshirn
Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key

Re: [PATCH 05/28] fnic: do not call host reset from command abort

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 06/28] uas: move eh_bus_reset_handler to eh_device_reset_handler

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 07/28] libsas: move bus_reset_handler() to target_reset_handler()

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 08/28] bfa: move bus reset to target reset

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 09/28] hptiop: Simplify reset handling

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 10/28] fdomain: move bus reset to host reset

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 11/28] scsi: drop bus reset for wd33c93-compatible boards

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 12/28] rtsx: drop bus reset function

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 13/28] qlogicpti: move bus reset to host reset

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 14/28] acornscsi: move bus reset to host reset

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 16/28] qlogicfas: move bus_reset to host_reset

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 15/28] NCR5380: Move bus reset to host reset

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 18/28] ppa: drop duplicate bus_reset handler

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 17/28] imm: drop duplicate bus_reset handler

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH 20/28] nsp32: drop bus reset

2017-06-28 Thread Johannes Thumshirn
Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

<    4   5   6   7   8   9   10   11   12   13   >