On Tue, Mar 06, 2018 at 10:21:30PM -0500, Douglas Gilbert wrote: > ChangeLog: > - add comments to scsi_end_request() noting what its bool return > value means > - change some variable names in scsi_io_completion() > - reword some inline comments; move some comments that seemed to be > separated from the code they referred to
For the commit message, please don't write your changelog as a list of bullet points, but as flowing text. The above changelog as well suggest you did three differnet things, which means three different patches. For the code itself, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
