OFLDCONN_FAILED) ||
> + (qedi_ep->state ==
> + EP_STATE_OFLDCONN_COMPL)),
> + msecs_to_jiffies(timeout_ms));
Maybe:
#define QEDI_OLDCON_STATE(q) ((q)->state == E
"Unable to start tmf thread!\n");
> + rc = -ENODEV;
> + goto free_cid_que;
> + }
> +
> + sprintf(host_buf, "qedi_ofld%d", qedi->shost->host_no);
> + qedi->offload_thread = create_workqueue(host_buf);
&g
nfo,
> + p_buffer);
> + break;
> + }
> }
> +
> + /* Submit Tx buffers here */
> + while ((p_buffer = qed_ooo_get_ready_buffer(p_hwfn,
> +
fcping uses FC-ELS to perform pings. FC ELS is a host as well as rport
service, so allow the rport version of the BSG ioctl() as well as the
host version.
Signed-off-by: Johannes Thumshirn
---
fcping.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a
you do not have strong
> objections, I would like to keep it this way.
No strong objections, I just don't think these lengthy blocks are readable,
but I don't want to do too much bikeshedding about it.
Thanks,
Johannes
--
Johannes Thumshirn
On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote:
> On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote:
> > Hm, still behaves for me like I reported for v2:
> > http://marc.info/?l=linux-scsi&m=147637177902937&w=2
>
> Hi Steffen,
>
&g
; Signed-off-by: Bart Van Assche
> Reviewed-by: Christoph Hellwig
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409
Hellwig
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21
Christoph Hellwig
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham No
by Christoph Hellwig.
>
> Signed-off-by: Bart Van Assche
> Cc: Christoph Hellwig
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH,
On Wed, Oct 26, 2016 at 03:51:33PM -0700, Bart Van Assche wrote:
> Multiple functions test the BLK_MQ_S_STOPPED bit so introduce
> a helper function that performs this test.
>
> Signed-off-by: Bart Van Assche
> Cc: Christoph Hellwig
Looks good,
Reviewed-by: Johannes Thumshirn
that function instead of looking it up a
> second time. These changes avoid that code has to be duplicated
> in the next patch.
>
> Signed-off-by: Bart Van Assche
> Cc: Christoph Hellwig
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
that function instead of looking it up a
> second time. These changes avoid that code has to be duplicated
> in the next patch.
>
> Signed-off-by: Bart Van Assche
> Cc: Christoph Hellwig
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
Ming Lei
> Signed-off-by: Bart Van Assche
> Reviewed-by: Christoph Hellwig
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfelds
y is pci_disable_device() not checking for it?
It does:
1607 void pci_disable_device(struct pci_dev *dev)
1608 {
[...]
1615 dev_WARN_ONCE(&dev->dev, atomic_read(&dev->enable_cnt) <= 0,
1616 "disabling already-disabled device");
[...]
are contexts of a blk-mq queue have been stopped.
>
> Signed-off-by: Bart Van Assche
> Reviewed-by: Hannes Reinecke
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+
an Assche
> Cc: Hannes Reinecke
> Cc: Johannes Thumshirn
> Cc: Sagi Grimberg
> Cc:
> ---
[...]
>
> +static void scsi_remove_device_async(struct scsi_device *sdev)
> +{
> + if (scsi_device_get(sdev) < 0)
Nit: the < 0 could be dropped, scsi_device_get ret
On Thu, Oct 27, 2016 at 08:38:03AM -0700, Bart Van Assche wrote:
> On 10/27/2016 02:46 AM, Johannes Thumshirn wrote:
> > On Wed, Oct 26, 2016 at 11:44:51AM -0700, Bart Van Assche wrote:
> > > +static void scsi_remove_device_async(struct scsi_device *sdev)
> > > +{
>
us' tree
already.
[1] 77f18a871 ("scsi: NCR5380: no longer mark irq probing as __init")
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr.
On Sat, Oct 29, 2016 at 03:53:25PM -0700, Nicholas A. Bellinger wrote:
> Hi Johannes & Zhu,
>
> On Tue, 2016-10-18 at 23:29 -0700, Nicholas A. Bellinger wrote:
> > On Tue, 2016-10-18 at 19:35 +0200, Johannes Thumshirn wrote:
> > > On Tue, Oct 18, 2016 at 09:01:34AM +02
ere bsg_reply is NULL.
> The assignment tries to write to memory at address NULL causing the kernel
> page fault.
>
> Does your suggested change for [PATCH v3 02/16], shuffling the
> job->request_len checks, address above kernel page fault?
This is what I hope at least. I
On Sat, Oct 29, 2016 at 03:53:25PM -0700, Nicholas A. Bellinger wrote:
> Hi Johannes & Zhu,
>
> On Tue, 2016-10-18 at 23:29 -0700, Nicholas A. Bellinger wrote:
> > On Tue, 2016-10-18 at 19:35 +0200, Johannes Thumshirn wrote:
> > > On Tue, Oct 18, 2016 at 09:01:34AM +02
On Thu, Nov 03, 2016 at 08:17:51AM -0700, Christoph Hellwig wrote:
> On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote:
> > On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote:
> > > Hm, still behaves for me like I reported for v2:
> > > http:
2i patches as well (althoug I wrote "for the whole series").
Testing was IIRC booting from the FCoE LUN and the doing a series of fio tests
for about an hour.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de
:
$ cat /sys/class/fc_host/host8/statistics/seconds_since_last_reset
0x10624dd2f1977b4
Take this into account so
/sys/class/fc_host/hostX/statistics/seconds_since_last_reset is sane again.
Fixes: 540eb1eef ('scsi: libfc: fix seconds_since_last_reset calculation')
Signed-off-by: Jo
et is computed. Shouldn't seconds_since_last_reset
> be computed as follows?
>
> fc_stats->seconds_since_last_reset = (jiffies - boot_time) / HZ;
But what happens when jiffies - boot_time becomes negative? Then we
reintroduce the bug again and have 'fcoeadm -s' show weird va
On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote:
> On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wrote:
> > On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote:
> > > Hm, still behaves for me like I reported for v2:
> > > http:
On Tue, Nov 15, 2016 at 03:31:27PM +0100, Steffen Maier wrote:
> Hi Johannes,
>
> On 11/15/2016 12:56 PM, Johannes Thumshirn wrote:
> > On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote:
> > > On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wr
On Tue, Nov 15, 2016 at 02:50:17PM +, Bart Van Assche wrote:
> On Tue, 2016-11-15 at 10:18 +0100, Johannes Thumshirn wrote:
> > On Tue, Nov 08, 2016 at 03:04:43PM +, Bart Van Assche wrote:
> > > I think the above code will miscalculate seconds_since_last_reset
> &
On Tue, Nov 15, 2016 at 03:31:27PM +0100, Steffen Maier wrote:
> Hi Johannes,
>
> On 11/15/2016 12:56 PM, Johannes Thumshirn wrote:
> > On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes Thumshirn wrote:
> > > On Fri, Oct 14, 2016 at 09:38:21AM +0200, Johannes Thumshirn wr
On Tue, Nov 15, 2016 at 04:39:33PM +0100, Johannes Thumshirn wrote:
> On Tue, Nov 15, 2016 at 03:31:27PM +0100, Steffen Maier wrote:
> > Hi Johannes,
> >
> > On 11/15/2016 12:56 PM, Johannes Thumshirn wrote:
> > > On Tue, Oct 25, 2016 at 09:43:14AM +0200, Johannes T
&' makes the code look reasonable, as we check the
> command bit before setting and printing it.
>
> Fixes: a4632aae8b66 ("[SCSI] mvsas: Add new macros and functions")
> Signed-off-by: Arnd Bergmann
> ---
Looks reasonable,
Reviewed-by: Johannes Thumshirn
--
Jo
On Wed, Nov 16, 2016 at 05:58:14PM +0100, Arnd Bergmann wrote:
> On Tuesday, November 15, 2016 4:05:31 PM CET Johannes Thumshirn wrote:
> > On Tue, Nov 15, 2016 at 02:50:17PM +, Bart Van Assche wrote:
> > > On Tue, 2016-11-15 at 10:18 +0100, Johannes Thumshirn wrote:
>
e can remove the function pointer from struct fc_bsg_job as well.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
Reviewed-by: Christoph Hellwig
Acked-by: Tyrel Datwyler
---
drivers/s390/scsi/zfcp_fc.c | 2 +-
drivers/scsi/bfa/bfad_bsg.c | 6 ++--
drivers/scsi/ibm
struct fc_bsg_buffer is just a clone of struct bsg_buffer from bsg-lib,
so use this one instead.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
Reviewed-by: Christoph Hellwig
---
drivers/scsi/lpfc/lpfc_bsg.c | 3 ++-
drivers/scsi/scsi_transport_fc.c | 2 +-
include/scsi
Provide fc_bsg_to_rport() helper that will become handy when we're moving
from struct fc_bsg_job to a plain struct bsg_job. Also move all LLDDs to use
the new helper.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
Acked-by: Tyrel Datwyler
---
drivers/s390/scsi/zfcp
fc_destroy_bsgjob() and bsg_destroy_job() are now 1:1 copies, so use the
later. As bsg_destroy_job() comes from bsg-lib we need to select it in Kconfig
once CONFOG_SCSI_FC_ATTRS is active.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 7
Now that all conversions are done, move the FibreChannel bsg code over to the
bsg library.
This patch is derived from work done by Mike Christie in 2011 [1] but only the
iscsi parts got merged back then.
[1] http://marc.info/?l=linux-scsi&m=131149780921009&w=2
Signed-off-by: Johannes T
fc_bsg_jobdone() and bsg_job_done() are 1:1 copies now so use the bsg-lib one
instead of the FC private implementation.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
Acked-by: Tyrel Datwyler
---
drivers/s390/scsi/zfcp_fc.c | 2 +-
drivers/scsi/bfa/bfad_bsg.c | 4
Change FC drivers to use 'struct bsg_job' from bsg-lib.h instead of 'struct
fc_bsg_job' from scsi_transport_fc.h and remove 'struct fc_bsg_job'.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
Acked-by: Tyrel Datwyler
---
drivers/s390/scsi/zfcp_ex
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use
helper variables bsg_request and bsg_reply. This will be helpfull when
transitioning to bsg-lib.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
drivers/s390/scsi/zfcp_fc.c | 9 +-
drivers/scs
Add bsg_job_put() and bsg_job_get() so don't need to export
bsg_destroy_job() any more.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 17 ++---
drivers/scsi/scsi_transport_fc.c | 4 ++--
include/linux/bsg-lib.h
bsg_softirq_done() and fc_bsg_softirq_done() are copies of each other, so
ditch the fc specific one.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 3 ++-
drivers/scsi/scsi_transport_fc.c | 15 ++-
include/linux/bsg-lib.h
Implement kref backed reference counting instead of rolling our own. This
elimnates the need of the following fields in 'struct fc_bsg_job':
* ref_cnt
* state_flags
* job_lock
bringing us close to unification of 'struct fc_bsg_job' and 'struct bsg_job'.
Sig
Provide fc_bsg_to_shost() helper that will become handy when we're moving from
struct fc_bsg_job to a plain struct bsg_job. Also use this little helper in
the LLDDs.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
Acked-by: Tyrel Datwyler
---
drivers/s390/scsi/zfcp
Don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() as
fc_bsg_jobdone() calls blk_complete_requeust() which raises a soft-IRQ that
ends up in fc_bsg_sofirq_done() and fc_bsg_softirq_done() sets the
FC_RQST_STATE_DONE flag.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Rei
Commit 540eb1eef 'scsi: libfc: fix seconds_since_last_reset calculation'
removed the use of 'struct timespec' from fc_get_host_stats(). This broke the
output of 'fcoeadm -s' after kernel 4.8-rc1.
Fixes: 540eb1eef ('scsi: libfc: fix seconds_since_last_reset ca
Add reference counting to 'struct bsg_job' so we can implement a reuqest
timeout handler for bsg_jobs, which is needed for Fibre Channel.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 7 +--
include/linux/bsg-lib.h | 2 ++
2 files
Unexport bsg_softirq_done() again, we don't need it outside of bsg-lib.c
anymore now that scsi_transport_fc is a pure bsg-lib client.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 3 +--
include/linux/bsg-lib.h | 1 -
2 files changed, 1 inse
bsg_job_done patches as requested by Christoph
* Fixed the hopefully last bisection breaking point
* Fixed kernel panic on s390 with patch 2/15
* Fixed kernel panic on s390 with patch 5/15
* Fixed zfcp_show output on s390 with patch 4/15
Johannes Thumshirn (15):
scsi: Get rid of struct fc_bsg_b
smp_affinity; done
44:
46:
48:
49:
51:
52:
ettrick:~ #
Anything else you want me to look at?
Apart from that, for the whole series:
Tested-by: Johannes Thumshirn
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
; '&&' instead [-Werror=int-in-bool-context]
>
> Using inline functions makes them much more readable and avoids
> the warnings.
>
> Signed-off-by: Arnd Bergmann
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumsh
On Fri, Nov 18, 2016 at 05:22:11AM -0800, Christoph Hellwig wrote:
> On Fri, Nov 18, 2016 at 02:13:12PM +0100, Johannes Thumshirn wrote:
> > This is what /proc/interrupts looks like after booting from the lpfc HBA,
> > with your patches:
> >
> > ettrick:~ # grep lpfc
On Fri, Nov 18, 2016 at 05:22:11AM -0800, Christoph Hellwig wrote:
> On Fri, Nov 18, 2016 at 02:13:12PM +0100, Johannes Thumshirn wrote:
> > This is what /proc/interrupts looks like after booting from the lpfc HBA,
> > with your patches:
> >
> > ettrick:~ # grep lpfc
before the mpt{2,3}sas unification (a.k.a pre-4.4).
Hope that helps.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendör
or PHYs that
> have been set up successfully, anyway).
>
> References: bsc#1010946.
I don't think the SUSE bugzilla tag is of relevance upstream. But for sake of
completeness we could add a
Link: https://bugzilla.suse.com/show_bug.cgi?id=1010946
> Signed-off-by: Martin Wilck
Re
caused by the fact that host device hostX is deleted before the
> SAS transport devices hostX/port-a:b.
>
> This patch fixes this by reverting the order of device deletions.
>
> References: bsc#1010946
> Signed-off-by: Martin Wilck
> ---
With the References
ave a look at it.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
On Mon, Nov 21, 2016 at 04:15:52PM +0100, Johannes Thumshirn wrote:
> On Mon, Nov 21, 2016 at 04:55:29PM +0200, Eyal Ben David wrote:
> > Thanks for your reply,
> >
> > On RHEL system it does not occur.
> >
> > So far I have seen the problem on Ubuntu 16.04 an
On Mon, Nov 21, 2016 at 10:47:20PM -0500, Martin K . Petersen wrote:
> >>>>> "Johannes" == Johannes Thumshirn writes:
>
> Johannes> I don't think the SUSE bugzilla tag is of relevance upstream.
>
> Nope. I'd rather have really comprehensi
ppears to
> fix the issue when applied on top of 4.4. Still looking...
This brings bad memories from commit 2d99b55d3 back to live, but this is
applied on all test kernels I have.
I too will run some bisection as well now that we have an easy reproducer and
my
es a difference.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
0 [lpfc]
> [...] [...] lpfc_do_work+0xd88/0x1970 [lpfc]
> [...] [...] kthread+0x108/0x130
> [...] [...] ret_from_kernel_thread+0x5c/0xbc
> <...>
>
> Cc: sta...@vger.kernel.org # v4.8
> Fixes: 22466da5b4b7 ("lpfc: Fix possible NULL pointer dereference&
and try to hunt it down. It'll be good to
know if anyone of you can reproduce it with the above script as well.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH,
On Thu, Nov 24, 2016 at 01:52:38PM +0300, Dan Carpenter wrote:
> We verified that resp_code is FC_SPP_RESP_ACK earlier so we don't need
> to check again here.
>
> Signed-off-by: Dan Carpenter
>
Looks good,
Acked-by: Johannes Thumshirn
--
*
100
VM:~ # uname -r
4.8.9-60-default+
VM:~ #
Anyways, can you test the patch Ewan found on one of your kernel's that are
known to fail?
Byte,
Johannes
--
Johannes Thumshirn Storage
jthu
On Fri, Nov 25, 2016 at 12:53:17PM +0100, Johannes Thumshirn wrote:
> On Fri, Nov 25, 2016 at 01:20:34PM +0200, Eyal Ben David wrote:
> > Note that sg_mmap_read does not parse the SCSI sense, so the script
> > might fail for other reasons (some SCSI error) and think its a zero
>
On Mon, Nov 28, 2016 at 03:22:37PM +0530, Souptick Joarder wrote:
> In lpfc_new_scsi_buf_s3() and lpfc_new_scsi_buf_s4() pci_pool_alloc
> followed by memset will be replaced by pci_pool_zalloc()
>
> Signed-off-by: Souptick joarder
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
eam bug report.
I was tracing it down to the exact opposite of this KASAN report [1] which came
in over the weekend, so I'll be looking into this one as well now.
[1] http://www.spinics.net/lists/linux-scsi/msg102232.html
Byte,
Johannes
--
_len in the SG driver. I did a lot of debugging (actually I spend the
whole last work week soley on this) but I can't find where it does the actual
use-after-free, so if you have anything to share I'd be glad.
Byte,
Johannes
--
Johannes Thumshirn
On Sat, Dec 03, 2016 at 04:22:39PM +0100, Dmitry Vyukov wrote:
> On Sat, Dec 3, 2016 at 11:38 AM, Johannes Thumshirn
> wrote:
> > On Fri, Dec 02, 2016 at 05:50:39PM +0100, Dmitry Vyukov wrote:
> >> On Fri, Nov 25, 2016 at 8:08 PM, Dmitry Vyukov wrote:
[...]
Hi Dmitry,
&g
On Mon, Dec 05, 2016 at 03:31:43PM +0100, Dmitry Vyukov wrote:
> On Sat, Dec 3, 2016 at 7:19 PM, Johannes Thumshirn wrote:
> > On Sat, Dec 03, 2016 at 04:22:39PM +0100, Dmitry Vyukov wrote:
> >> On Sat, Dec 3, 2016 at 11:38 AM, Johannes Thumshirn
> >> wrote:
> >
On Mon, Dec 05, 2016 at 07:03:39PM +, Al Viro wrote:
> On Mon, Dec 05, 2016 at 04:17:53PM +0100, Johannes Thumshirn wrote:
> > 633 hp = &srp->header;
> > [...]
> > 646 hp->dxferp = (char __user *)buf + cmd_size;
>
> > So the m
On Mon, Nov 28, 2016 at 04:56:26PM +0530, Souptick Joarder wrote:
> Inside mvs_task_prep(), pci_pool_alloc() followed by memset will be
> replaced by pci_pool_zalloc()
>
> Signed-off-by: Souptick joarder
> ---
FWIW,
Reviewed-by: Johannes Thumshirn
--
Joh
On Tue, Dec 06, 2016 at 10:43:57AM +0100, Dmitry Vyukov wrote:
> On Tue, Dec 6, 2016 at 10:32 AM, Johannes Thumshirn
> wrote:
> > On Mon, Dec 05, 2016 at 07:03:39PM +, Al Viro wrote:
> >> On Mon, Dec 05, 2016 at 04:17:53PM +0100, Johannes Thumshirn wrote:
> >> &
for skb_is_nonlinear is within
skb_linearize */
-
+ if (skb_linearize(skb))
+ goto free_skb;
/*
* Frame length checks and setting up the header pointers
* was done in fcoe_rcv already.
@@ -1732,6 +1731,7 @@ static void fcoe_recv_frame(struct sk_buff *skb
d-off-by: Tyrel Datwyler
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jan
;
> Signed-off-by: Tyrel Datwyler
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imend
done = 1;
> }
Is this something you have seen in the wild or just a "better save than sorry"
barrier?
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 740
On Thu, Dec 08, 2016 at 11:01:30AM -0800, James Bottomley wrote:
> On Tue, 2016-08-02 at 01:17 -0400, Martin K. Petersen wrote:
> > > > > > > "Johannes" == Johannes Thumshirn
> > > > > > > writes:
> >
> > Johannes> Check for t
ap
> in 4.10. This one of the last holdouts.
As I already said, the FCoE part looks OK and is tested.
Lee, Chris can you do some testing with the iSCSI part as well, seems like
Chad isn't reachable.
Thanks,
Johannes
--
Johannes Thumshirn
10b to 8b decoding error occurred
DevExch: Device presence has changed
This could indicate a problem with the cabling and/or connectors.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 7
>reply;
uint32_t command_type = bsg_request->msgcode;
unsigned long flags;
I'll send out an official patch soon, thanks for the report.
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de
Set the elsiocb contexts to NULL after freeing as others depend on it.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/lpfc/lpfc_els.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index 236e4e5..7b6bd8e 100644
--- a/drivers
the head file, do it now.
^
header?
>
> Signed-off-by: Hanjun Guo
> ---
Otherwise,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de
Iooss
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/bfa/bfad_bsg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c
index a9a0016..b2e8c0d 100644
--- a/drivers/scsi/bfa/bfad_bsg.c
+++ b/drivers/scsi/bfa/bfad_bsg.
at we live in now.
As this applies to FCoE as well as iSCSI I'd be very interested in this
session as well.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH,
.1':
> qedi_main.c:(.text.__qedi_probe.constprop.1+0x1368): undefined reference to
> `__uio_register_device'
>
> This adds a compile-time dependency.
>
> Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver
> framework.")
>
s' tree?
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key finger
On Tue, Jan 10, 2017 at 04:06:19PM +0100, Christoph Hellwig wrote:
> Simply the boilerplate code needed for bsg nodes a bit.
>
> Signed-off-by: Christoph Hellwig
> ---
that reminds me of posting my SAS bsg-lib patch...
Anyways looks good,
Reviewed-by: Johannes Thumshirn
On Wed, Jan 11, 2017 at 09:45:12AM +0100, Christoph Hellwig wrote:
> On Wed, Jan 11, 2017 at 09:42:44AM +0100, Johannes Thumshirn wrote:
> > On Tue, Jan 10, 2017 at 04:06:19PM +0100, Christoph Hellwig wrote:
> > > Simply the boilerplate code needed for bsg nodes a bit.
> >
validation?
> 6. Whether QEMU can be used to emulate some of the H/W functionality to
> create a test
> platform? (Optional subsystem specific)
Well, something I was thinking about but didn't find enough time to actually
implement is making a xfstestes like test suite written usin
From: Roberto Sassu
Set variables initialized in lpfc_sli4_alloc_resource_identifiers() to NULL
if an error occurred. Otherwise, lpfc_sli4_driver_resource_unset() attempts
to free the memory again.
Signed-off-by: Roberto Sassu
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/lpfc
On Wed, Jan 11, 2017 at 02:26:52PM +0100, Christoph Hellwig wrote:
> Spotted while preparing qla2xxx changes as the symbols exist in both
> drivers (sigh..).
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Joh
M I'd like to whether it is desirable to have NAPI like polling in
more block drivers and how to overcome the currently seen performance issues.
[1] http://lists.infradead.org/pipermail/linux-nvme/2016-October/006975.html
Byte,
Johannes
--
Joh
Convert the SAS transport class over to using bsg-lib instead of doing "raw"
bsg access.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/scsi_transport_sas.c | 41 +++
1 file changed, 16 insertions(+), 25 deletions(-)
diff --git a/dr
can't you?
I'll do some prototyping and tests tomorrow so we have some more ground for
discussion.
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxf
e this if I
> can find volunteers with high-end nvme devices (I only have access
> to client nvme devices.
I have a P3700 but somehow burned the FW. Let me see if I can bring it back to
live.
I also have converted AHCI to the irq_poll interface and will run some tests.
I do also have s
ly in qemu or with real H/W as well?
>
> Note that I ran randrw because I was backed with null_blk, testing
> with a real nvme device, you should either run randread or write, and
> if you do a write, you can't run it multi-threaded (well you can, but
>
> >Did you do testing only in qemu or with real H/W as well?
>
> I tried once. IIRC, I saw the same phenomenons...
JFTR I tried my AHCI irq_poll patch on the Qemu emulation and the read
throughput dropped from ~1GB/s to ~350MB/s. But this can be related to
Qemu's
201 - 300 of 1576 matches
Mail list logo
