RE: [PATCH 2/2] cciss: correct the non-resettable board list

2015-05-19 Thread Don Brace
-Original Message- > From: Don Brace > Sent: Tuesday, May 19, 2015 1:56 PM > To: 'Tomas Henzl'; linux-scsi@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; ax...@kernel.dk > Subject: RE: [PATCH 2/2] cciss: correct the non-resettable board list > > > -

RE: [PATCH] hpsa: dont meddle with hw which isn't ours (cciss)

2015-05-19 Thread Don Brace
> -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Thursday, April 02, 2015 8:26 AM > To: linux-scsi@vger.kernel.org > Cc: Don Brace; Scott Teel; Justin Lindley; Kevin Barnett > Subject: [PATCH] hpsa: dont meddle with hw which isn't our

RE: [patch] hpsa: fix an sprintf() overflow in the reset handler

2015-06-18 Thread Don Brace
> -Original Message- > From: walter harms [mailto:wha...@bfs.de] > Sent: Thursday, June 04, 2015 10:23 AM > To: Dan Carpenter > Cc: Don Brace; James E.J. Bottomley; iss_storage...@hp.com; dl Team ESD > Storage Dev Support; linux-scsi@vger.kernel.org; kernel- > jan

RE: [patch] hpsa: fix an sprintf() overflow in the reset handler

2015-06-18 Thread Don Brace
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, June 04, 2015 9:48 AM > To: Don Brace > Cc: James E.J. Bottomley; iss_storage...@hp.com; dl Team ESD Storage Dev > Support; linux-scsi@vger.kernel.org; kernel-janit...@vger.ke

hpsa static checker issues

2015-06-18 Thread Don Brace
Dan, You had noted three concerns covering: mutex_unlock, decode sense data, and a goto label issue, that were detected during your static checker run. I have patches that address these issues. I am thinking that I need to post these three patches linux-scsi. Is that correct? Thanks, Don

[PATCH 00/11] hpsa updates

2015-07-18 Thread Don Brace
r ids. - Correct rmmod issue - Add in new path_info to show box and bay info - Driver supports mixed mode, RAID and HBA - New offline mode - Bug fix for multi lun devices from Shane Seymour --- Don Brace (7): hpsa: Correct double unlock of mutex hpsa: correct decode sense data

[PATCH 02/11] hpsa: correct decode sense data

2015-07-18 Thread Don Brace
Reported-by: Dan Carpenter Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 1d5f4fd..e9b2073 100644 --- a/drivers/scsi

[PATCH 04/11] hpsa: add PMC to copyright

2015-07-18 Thread Don Brace
need to add PMC to copyright notice and update the Hewlett-Packard copyright notification. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Reviewed-by: Justin Lindley Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |9 +++-- drivers/scsi/hpsa.h |9 +++-- drivers

[PATCH 01/11] hpsa: Correct double unlock of mutex

2015-07-18 Thread Don Brace
Reported-by: Dan Carpenter Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 1dafeb4..1d5f4fd 100644 --- a/drivers

[PATCH 03/11] hpsa: correct static checker warnings on driver init cleanup

2015-07-18 Thread Don Brace
Reported-by: Dan Carpenter Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index e9b2073..6b083af 100644 --- a/drivers/scsi

[PATCH 06/11] hpsa: cleanup update scsi devices

2015-07-18 Thread Don Brace
showing that tables have been updated unnecessarily. Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index f64a2c7

[PATCH 05/11] hpsa: add sysfs entry path_info to show box and bay information

2015-07-18 Thread Don Brace
From: Joe Handzik host no, bus, target, lun, scsi_device_type for hba mode add: box and bay information report if the path is active/inactive Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 122

[PATCH 07/11] hpsa: add in new controllers

2015-07-18 Thread Don Brace
Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index f34978d..20c29e5 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c

[PATCH 08/11] Change how controllers in mixed mode are handled.

2015-07-18 Thread Don Brace
From: Kevin Barnett Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 97 ++- drivers/scsi/hpsa.h |2 - 2 files changed, 11 insertions(+), 88 deletions(-) diff --git a/drivers/scsi

[PATCH 09/11] hpsa: add in new offline mode

2015-07-18 Thread Don Brace
From: Scott Benesh prevent adding volumes that are not available. Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 15 +++ drivers/scsi/hpsa_cmd.h |1 + 2 files changed, 12 insertions

[PATCH 10/11] hpsa: fix issues with multilun devices

2015-07-18 Thread Don Brace
2 target 0. Before the change the changer device is not seen. Suggested-by: shane.seymour Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b

[PATCH 11/11] hpsa: fix rmmod issues

2015-07-18 Thread Don Brace
: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index a3077e9..0f8acfb 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c

RE: [PATCH 3/3] hpsa: Convert DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WR|WO

2015-07-18 Thread Don Brace
ageDev > Cc: linux-...@vger.kernel.org; Greg KH (g...@kroah.com) > Subject: [PATCH 3/3] hpsa: Convert DEVICE_ATTR macro usage to > DEVICE_ATTR_RO|WR|WO > > > Convert DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WR|WO > Changes forced some function names to change. > > Signed-off

RE: [PATCH 2/3] hpsa: Remove unneccessary variable from raid_level_show

2015-07-18 Thread Don Brace
> Cc: Greg KH (g...@kroah.com) > Subject: [PATCH 2/3] hpsa: Remove unneccessary variable from raid_level_show > > > Remove unneccessary variable from raid_level_show > > Signed-off-by: Shane Seymour Signed-off-by: Don brace -- To unsubscribe from this list: send the line &q

Re: [BUG] hpsa: Controller lockup detected: 0x00150028

2015-08-24 Thread Don Brace
On 08/24/2015 05:02 AM, Wouter Depuydt wrote: Wouter Depuydt gmail.com> writes: -Original Message- From: Peter Zijlstra [mailto:peterz infradead.org] Sent: Friday, May 22, 2015 11:40 AM To: Tomas Henzl Cc: Oelke, Mark; don.brace pmcs.com; ISS StorageDev; storagedev pmcs.com; linux

Re: [PATCH] scsi: hpsa: remove unneeded void pointer cast

2016-10-13 Thread Don Brace
izeof(*ioc), GFP_KERNEL); if (!ioc) { status = -ENOMEM; goto cleanup1; Acked-by: Don Brace -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [PATCH V4 2/2] aacraid: remove wildcard for series 9 controllers

2016-10-14 Thread Don Brace
On 09/08/2016 01:25 PM, James Bottomley wrote: On Thu, 2016-09-08 at 18:15 +, Don Brace wrote: -{ 0x9005, 0x028f, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 65 }, /* Adaptec PMC Series 9 */ How are people that load aacraid in their initrd going to boot after this? -- Martin K. Petersen Oracle

RE: [PATCH 3/3] smartpqi: switch to pci_alloc_irq_vectors

2016-10-17 Thread Don Brace
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Monday, October 17, 2016 2:34 AM > To: Christoph Hellwig > Cc: martin.peter...@oracle.com; Don Brace; ax...@kernel.dk; linux- > s...@vger.kernel.org; linux-bl...@vger.kernel.org > Su

RE: [PATCH 3/3] smartpqi: switch to pci_alloc_irq_vectors

2016-10-17 Thread Don Brace
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Monday, October 17, 2016 9:21 AM > To: Don Brace > Cc: Johannes Thumshirn; Christoph Hellwig; martin.peter...@oracle.com; > ax...@kernel.dk; linux-scsi@vger.kernel.org; linux-bl...@vger.kernel

[PATCH 4/4] hpsa: bump driver version

2016-10-26 Thread Don Brace
Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 810c300..0b6eb5a 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c

[PATCH 2/4] hpsa: add generate controller NMI on lockup

2016-10-26 Thread Don Brace
Tell the controller to NMI when the controller deadlocks. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 ++ drivers/scsi/hpsa_cmd.h |1 + 2 files changed, 7 insertions(+) diff --git a/drivers

[PATCH 3/4] hpsa: remove coalescing settings for ioaccel2

2016-10-26 Thread Don Brace
- Setting coalescing has a significant negative impact on low queue-depth performance. - Does not help high queue-depth performance. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |8 ++-- 1 file changed

[PATCH 0/4] hpsa updates

2016-10-26 Thread Don Brace
These patches are based on Linus's tree The changes are: - do not call pci_disable_device on an already disabled device. - add a new lockup condition to lockup handler. - remove coalescing settings for ioaccel2 - update driver version. --- Don Brace (4): hpsa: correct l

[PATCH 1/4] hpsa: correct lockup detector pci_disable_device

2016-10-26 Thread Don Brace
need to check if the device is already disabled first Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index d007ec1..798fb20

RE: [PATCH 1/4] hpsa: correct lockup detector pci_disable_device

2016-10-31 Thread Don Brace
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Thursday, October 27, 2016 10:19 AM > To: Don Brace > Cc: j...@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh > Rajashekhara; h...@infradead.org; Scott Teel; Viswas G; Justin Lindl

RE: [PATCH 2/4] hpsa: add generate controller NMI on lockup

2016-10-31 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, October 27, 2016 4:03 AM > To: Don Brace; j...@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh > Rajashekhara; h...@infradead.org; Scott Teel; Viswas G; Justin Lindley; Scott > Benes

Re: "hpsa: Change SAS transport devices to bus 0." commit breaks hpacucli on old controller firmware

2016-10-31 Thread Don Brace
cussed this with the ssacli developers and they do not look at the bus, but I see "device not added" messages that should not be there. I'll attack your issue from that perspective. Thanks, Don Brace Kernel 4.4.2 Oct 27 15:28:07 hostname kernel: [1.461160] hpsa :06:00.0:

RE: [PATCH 3/3] smartpqi: switch to pci_alloc_irq_vectors

2016-10-31 Thread Don Brace
> -Original Message- > From: Don Brace > Sent: Monday, October 17, 2016 8:45 AM > To: 'Johannes Thumshirn'; Christoph Hellwig > Cc: martin.peter...@oracle.com; ax...@kernel.dk; linux- > s...@vger.kernel.org; linux-bl...@vger.kernel.org > Subject: RE:

RE: [PATCH] hpsa: switch to pci_alloc_irq_vectors

2016-11-09 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Tuesday, November 08, 2016 1:12 AM > To: Martin K. Petersen > Cc: Christoph Hellwig; James Bottomley; linux-scsi@vger.kernel.org; Hannes > Reinecke; Hannes Reinecke; Don Brace > Subject: [P

RE: [PATCH] hpsa: switch to pci_alloc_irq_vectors

2016-11-09 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Wednesday, November 09, 2016 9:45 AM > To: Christoph Hellwig; Don Brace > Cc: Martin K. Petersen; James Bottomley; linux-scsi@vger.kernel.org; Hannes > Reinecke > Subject: Re: [P

RE: [PATCH] hpsa: use pci_alloc_irq_vectors and automatic irq affinity

2016-11-09 Thread Don Brace
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Wednesday, November 09, 2016 12:42 PM > To: Don Brace > Cc: h...@suse.de; linux-scsi@vger.kernel.org > Subject: [PATCH] hpsa: use pci_alloc_irq_vectors and automatic irq affinity > > EXT

[PATCH] hpsa: correct logical resets

2016-11-10 Thread Don Brace
- driver was not calling done in some cases which causes the volume to be offlined. - avoid doing rescan during a reset. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 24 +++- 1 file changed, 23 insertions(+), 1

RE: [PATCH V4 2/2] aacraid: remove wildcard for series 9 controllers

2016-11-11 Thread Don Brace
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Thursday, September 08, 2016 5:38 PM > To: Scott Benesh; James Bottomley; Don Brace; Martin K. Petersen > Cc: Viswas G; Mahesh Rajashekhara; h...@infradead.org; Scott Teel;

RE: [PATCH 2/4] hpsa: add generate controller NMI on lockup

2016-11-11 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, October 27, 2016 4:03 AM > To: Don Brace; j...@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh > Rajashekhara; h...@infradead.org; Scott Teel; Viswas G; Justin Lindley; Scott > Benes

RE: [PATCH] hpsa: correct logical resets

2016-11-15 Thread Don Brace
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Monday, November 14, 2016 5:44 PM > To: Don Brace > Cc: j...@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh > Rajashekhara; Bader Ali-saleh; h...@infradead.org; Scott Teel;

[PATCH V2] hpsa: correct logical resets

2016-11-15 Thread Don Brace
- driver was not calling done in some cases which causes the volume to be offlined. - avoid doing rescan during a reset. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 23 ++- 1 file changed, 22 insertions(+), 1

RE: [PATCH] hpsa: use bus '3' for legacy HBA devices

2016-11-17 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, November 17, 2016 5:16 AM > To: Don Brace > Cc: Martin K. Petersen; Christoph Hellwig; James Bottomley; Johannes > Thumshirn; Jack Suter; linux-scsi@vger.kernel.org; Hannes Reinecke;

RE: [PATCH 1/2] hpsa: cleanup sas_phy structures in sysfs when unloading

2016-11-28 Thread Don Brace
> -Original Message- > From: Martin Wilck [mailto:mwi...@suse.de] > Sent: Monday, November 21, 2016 8:04 AM > To: Don Brace > Cc: dl-esc-Team ESD Storage Dev Support; iss_storage...@hp.com; linux- > s...@vger.kernel.org; jbottom...@odin.com; h...@lst.de; h...@suse.

RE: [PATCH 1/3] hpsa: use correct DID_NO_CONNECT hostbyte

2016-11-28 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, November 18, 2016 1:33 AM > To: Martin K. Petersen > Cc: Christoph Hellwig; James Bottomley; Don Brace; Martin Wilck; linux- > s...@vger.kernel.org; Hannes Reinecke; Hannes Reinecke >

RE: [PATCH 3/3] hpsa: add 'ctlr_num' sysfs attribute

2016-11-28 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, November 18, 2016 1:33 AM > To: Martin K. Petersen > Cc: Christoph Hellwig; James Bottomley; Don Brace; Martin Wilck; linux- > s...@vger.kernel.org; Hannes Reinecke; Hannes Reinecke >

RE: [PATCH 2/3] hpsa: fallback to use legacy REPORT PHYS command

2016-12-01 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, November 18, 2016 1:33 AM > To: Martin K. Petersen > Cc: Christoph Hellwig; James Bottomley; Don Brace; Martin Wilck; linux- > s...@vger.kernel.org; Hannes Reinecke; Hannes Reinecke >

RE: [PATCH 0/2] hpsa: fix rmmod issues

2016-12-01 Thread Don Brace
> -Original Message- > From: Martin Wilck [mailto:mwi...@suse.de] > Sent: Monday, November 21, 2016 8:04 AM > To: Don Brace > Cc: dl-esc-Team ESD Storage Dev Support; iss_storage...@hp.com; linux- > s...@vger.kernel.org; jbottom...@odin.com; h...@lst.de; h...@suse.

RE: [PATCH 0/2] hpsa: fix rmmod issues

2016-12-02 Thread Don Brace
From: Martin Wilck [mwi...@suse.de] Sent: Friday, December 02, 2016 12:58 AM To: Don Brace Cc: dl-esc-Team ESD Storage Dev Support; iss_storage...@hp.com; linux-scsi@vger.kernel.org; James Bottomley; h...@lst.de; h...@suse.de; jthumsh...@suse.com Subject

RE: [PATCHv3] hpsa: fallback to use legacy REPORT PHYS command

2016-12-02 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, December 02, 2016 4:36 AM > To: Martin K. Petersen > Cc: Christoph Hellwig; James Bottomley; Don Brace; linux- > s...@vger.kernel.org; Hannes Reinecke; Hannes Reinecke > Subject: [PATCH

RE: [PATCH 2/4] hpsa: add generate controller NMI on lockup

2016-12-06 Thread Don Brace
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Don Brace > Sent: Friday, November 11, 2016 10:09 AM > To: Hannes Reinecke; j...@linux.vnet.ibm.com; John Hall; Kevin Barnett; > Mahesh Rajashekhara;

RE: [PATCH V4 2/2] aacraid: remove wildcard for series 9 controllers

2016-12-07 Thread Don Brace
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Don Brace > Sent: Friday, November 11, 2016 8:48 AM > To: James Bottomley; Scott Benesh; James Bottomley; Martin K. Petersen > Cc: Viswas G; Mahe

[PATCH] aacraid: remove wildcard for series 9 controllers

2016-12-08 Thread Don Brace
From: Kevin Barnett Depends on smartpqi driver adoption Reviewed-by: Scott Teel Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/aacraid/linit.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index

RE: [PATCH] scsi: hpsa: remove memory allocate failure message

2016-12-09 Thread Don Brace
> -Original Message- > From: kushwah...@samsung.com [mailto:kushwah...@samsung.com] > Sent: Friday, December 09, 2016 5:18 AM > To: Don Brace; jbottom...@odin.com > Cc: linux-scsi@vger.kernel.org; kushwah...@samsung.com; > d.wadha...@samsung.com > Subject: [PATCH] scsi

RE: [PATCH] aacraid: remove wildcard for series 9 controllers

2016-12-09 Thread Don Brace
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Thursday, December 08, 2016 4:10 PM > To: Don Brace > Cc: j...@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh > Rajashekhara; Bader Ali-saleh; h...@infradead.org; Sc

RE: [PATCH v2] scsi: hpsa: remove memory allocate failure message

2016-12-12 Thread Don Brace
> -Original Message- > From: kushwah...@samsung.com [mailto:kushwah...@samsung.com] > Sent: Monday, December 12, 2016 5:04 AM > To: Don Brace; j...@linux.vnet.ibm.com > Cc: linux-scsi@vger.kernel.org; akkushwaha9...@gmail.com; > vidushi.k...@samsung.com > Subject:

RE: [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2

2017-01-13 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, October 27, 2016 4:04 AM > To: Don Brace ; j...@linux.vnet.ibm.com; John > Hall ; Kevin Barnett > ; Mahesh Rajashekhara > ; h...@infradead.org; Scott Teel > ; Viswas G ; Justin

[PATCH V2] hpsa: remove coalescing settings for ioaccel2

2017-01-30 Thread Don Brace
- Setting coalescing has a significant negative impact on low queue-depth performance. - Does not help high queue-depth performance. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Reviewed-by: Hannes Reinecke Signed-off-by: Don Brace --- drivers/scsi/hpsa.c

RE: [PATCH 3/3] cciss: Remove kmalloc cast

2017-02-22 Thread Don Brace
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Tobin C. Harding > Sent: Wednesday, February 22, 2017 12:13 AM > To: Don Brace > Cc: linux-scsi@vger.kernel.org; kernel-janit...@vger.kernel.org;

RE: [PATCH 2/3] cciss: Fix checkpatch OPEN_BRACE

2017-02-22 Thread Don Brace
> -Original Message- > From: Tobin C. Harding [mailto:m...@tobin.cc] > Sent: Wednesday, February 22, 2017 12:13 AM > To: Don Brace > Cc: linux-scsi@vger.kernel.org; kernel-janit...@vger.kernel.org; Tobin C. > Harding > Subject: [PATCH 2/3] cciss: Fix checkpatch OPE

RE: [PATCH 1/3] cciss: Fix checkpatch TRAILING_WHITESPACE

2017-02-22 Thread Don Brace
> -Original Message- > From: Tobin C. Harding [mailto:m...@tobin.cc] > Sent: Wednesday, February 22, 2017 12:13 AM > To: Don Brace > Cc: linux-scsi@vger.kernel.org; kernel-janit...@vger.kernel.org; Tobin C. > Harding > Subject: [PATCH 1/3] cciss: Fix checkpatc

[PATCH] cciss: correct check map error.

2017-02-23 Thread Don Brace
remove device driver failed to check map error messages Reported-by: Johnny Bieren Tested-by: Johnny Bieren Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/block/cciss.c | 32 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a

[PATCH 0/3] hpsa updates

2017-03-06 Thread Don Brace
These patches are based on Linus's tree The changes are: - add in a new offline volume status - limit the number of outstanding rescan operations - do not timeout reset operations --- Don Brace (3): hpsa: update check for logical volume status hpsa: limit outstanding re

[PATCH 3/3] hpsa: do not timeout reset operations

2017-03-06 Thread Don Brace
resets can take longer than DEFAULT_TIMEOUT Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index a36d3a6..30164b7 100644 --- a

[PATCH 2/3] hpsa: limit outstanding rescans

2017-03-06 Thread Don Brace
avoid rescan storms. No need to queue another if one is pending. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 16 +++- drivers/scsi/hpsa.h |1 + 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 1/3] hpsa: update check for logical volume status

2017-03-06 Thread Don Brace
- Add in a new case for volume offline. Resolves internal testing bug for multilun array management. - Return correct status for failed TURs. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 26 +- drivers

RE: [PATCHv2] hpsa: expose enclosures

2017-03-07 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, February 23, 2017 4:55 AM > To: Martin K. Petersen > Cc: Christoph Hellwig ; James Bottomley > ; linux-scsi@vger.kernel.org; > Hannes Reinecke ; Don Brace > ; Hannes Reinecke &

RE: [PATCHv2] hpsa: expose enclosures

2017-03-07 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.com] > Sent: Tuesday, March 07, 2017 9:25 AM > To: Don Brace ; Hannes Reinecke > ; Martin K. Petersen > Cc: Christoph Hellwig ; James Bottomley > ; linux-scsi@vger.kernel.org > Subject: Re: [PATCHv2]

[PATCH 0/7] hpsa driver updates

2016-04-27 Thread Don Brace
cking - enhance hot-plug operations for HBA mode - add a sysfs attribute for sas addresses - bump driver version --- Don Brace (6): hpsa: correct initialization order issue hpsa: add timeouts for driver initiated commands hpsa: correct ioaccel state change operation hpsa: co

[PATCH 1/7] hpsa: correct initialization order issue

2016-04-27 Thread Don Brace
e the call to scsi_scan_host. Reported-by: Piotr Karbowski Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 5be944

[PATCH 3/7] hpsa: add timeouts for driver initiated commands

2016-04-27 Thread Don Brace
faulty drives can cause the driver to hang during a scan operation. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 42 +++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/drivers

[PATCH 4/7] hpsa: correct ioaccel state change operation

2016-04-27 Thread Don Brace
offload_to_be_enabled also needs to be set to 0 during a state change. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index

[PATCH 2/7] hpsa: add sas_address to sysfs device attibute

2016-04-27 Thread Don Brace
From: Joseph T Handzik There have been companies requesting a sysfs entry to obtain the sas address of device. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 25 + 1 file changed, 25 insertions(+) diff --git a

[PATCH 5/7] hpsa: correct ioaccel2 error procecssing.

2016-04-27 Thread Don Brace
set offload_to_be_enabled to 0 when an ioaccel2 error is processed. Before, an ioaccel completion error would turn of ioaccel but a rescan would turn it back on again. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 +++- 1 file

[PATCH 6/7] hpsa: correct handling of HBA device removal

2016-04-27 Thread Don Brace
Need to report HBA device removal faster than the event handler polling interval. Stop I/O to the removed disk and wait for all I/O operations to flush before removing the device. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 89

[PATCH 7/7] hpsa: update driver version

2016-04-27 Thread Don Brace
Reviewed-by: Gerry Morong Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 0d286e4..011fb8e 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -60,7 +60,7

[PATCH 0/2] initial submit of Microsemi smartpqi driver

2016-06-08 Thread Don Brace
This patches are based on Linus's tree - New smartpqi driver - removal of smartpqi PCI IDs from aacraid driver - this patch depends on adoption of smartpqi driver --- Don Brace (2): smartpqi: initial commit of Microsemi smartpqi driver aacraid: remove wildcard for ser

[PATCH V1 2/2] aacraid: remove wildcard for series 9 controllers

2016-06-08 Thread Don Brace
Depends on smartpqi driver adoption Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/aacraid/linit.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 79871f3..d5b26fa 100644

[PATCH V1 0/2] Series short description

2016-06-08 Thread Don Brace
These patches are based on Linus's tree - add smartpqi to kernel.org - remove PCI IDs from aacraid driver - Depends on adoption of smartpqi driver Changes since initial upload - Forgot to give correct ownership to the author. --- Don Brace (1): aacraid: remove wildcard for ser

[PATCH 2/2] aacraid: remove wildcard for series 9 controllers

2016-06-08 Thread Don Brace
Depends on smartpqi driver adoption Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/aacraid/linit.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 79871f3..d5b26fa 100644

[PATCH V2 0/2] initial submit of Microsemi smartpqi driver

2016-06-09 Thread Don Brace
robot issue. --- Don Brace (1): aacraid: remove wildcard for series 9 controllers Kevin Barnett (1): smartpqi: initial commit of Microsemi smartpqi driver drivers/scsi/smartpqi/Kconfig | 50 drivers/scsi/smartpqi/Makefile |3 drivers/scsi/sma

[PATCH V2 2/2] aacraid: remove wildcard for series 9 controllers

2016-06-09 Thread Don Brace
Depends on smartpqi driver adoption Reviewed-by: Kevin Barnett Reviewed-by: Scott Teel Signed-off-by: Don Brace --- 0 files changed diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 79871f3..d5b26fa 100644 --- a/drivers/scsi/aacraid/linit.c +++ b/drivers/scsi

Re: [PATCH for v3.19, v2] Avoid that sd_shutdown() triggers a kernel warning

2015-01-15 Thread Don Brace
kernel module: Tested-by: Don Brace This patch fixed module removal crashes I was seeing with the hpsa driver running on 3.19-rc4 kernel. Ran ~200 insmod/rmmod tests with no issues. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message

[PATCH v2 00/48] hpsa driver updates

2015-01-23 Thread Don Brace
oring - performance enhancements. - removal of command queueing in driver - elimination of race conditions around aborts - change to internal driver workqueues --- Don Brace (12): hpsa: correct endian sparse warnings hpsa: change how SA controllers are reset hpsa: co

[PATCH v2 01/48] hpsa: correct endian sparse warnings

2015-01-23 Thread Don Brace
Correct endiness issues reported by sparse. SA controllers are little endian. This patch ensures endiness correctness. Signed-off-by: Don Brace Reviewed-by: Scott Teel Reviewed-by: Webb Scales --- drivers/scsi/hpsa.c | 275 +++ drivers/scsi

[PATCH v2 11/48] hpsa: propagate hard_reset failures in reset_devices mode

2015-01-23 Thread Don Brace
From: Robert Elliott Return the real reason for kdump_hard_reset failure rather than change them all to -ENODEV. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a

[PATCH v2 10/48] hpsa: remove 0x from queue depth print which is in decimal

2015-01-23 Thread Don Brace
From: Robert Elliott The queue depth printed at startup is in decimal, so shouldn't have a 0x prefix. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 06/48] hpsa: adjust RAID-1, RAID-1ADM, and RAID-6 names

2015-01-23 Thread Don Brace
[] Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 7dfe829..4252b63 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi

[PATCH v2 05/48] hpsa: correct change_queue_depth

2015-01-23 Thread Don Brace
We change drive queue depths to match drive reported queue depths. The name of the SML function was changed from scsi_adjust_queue_depth changed to scsi_change_queue_depth. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 16 +++- 1 file changed, 15

[PATCH v2 13/48] hpsa: downgrade the Waiting for no-op print to dev_info

2015-01-23 Thread Don Brace
From: Robert Elliott There is nothing worrisome about the "Waiting for controller to respond to no-op" print, so use dev_info rather than dev_warn. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1

[PATCH v2 08/48] hpsa: Fix -Wunused-but-set-variable warning

2015-01-23 Thread Don Brace
From: Fabian Frederick Remove unused variable in hpsa_free_cmd_pool. Reviewed-by: Scott Teel Signed-off-by: Fabian Frederick Acked-by: Don Brace Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b

[PATCH v2 02/48] hpsa: fix memory leak in kdump hard reset

2015-01-23 Thread Don Brace
From: Tomas Henzl There is a potential memory leak in hpsa_kdump_hard_reset_controller. Reviewed-by: Don Brace Reviewed-by: Scott Teel Signed-off-by: Tomas Henzl Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 12/48] hpsa: propagate return value from board ID lookup

2015-01-23 Thread Don Brace
: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 92ac76a..85b3d73 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -5812,8 +5812,12 @@ static

[PATCH v2 09/48] hpsa: notice all request_irq errors

2015-01-23 Thread Don Brace
[ 10.711623] scsi host1: Error handler scsi_eh_1 exiting [ 10.739170] hpsa: probe of :02:00.0 failed with error -38 Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 19 ++- 1 file changed, 18 insertions(+), 1

[PATCH v2 07/48] hpsa: rename free_irqs to hpsa_free_irqs

2015-01-23 Thread Don Brace
From: Robert Elliott Change the function names to have hpsa prefix. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 43 ++- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a

[PATCH v2 03/48] hpsa: turn off interrupts when kdump starts

2015-01-23 Thread Don Brace
ard_reset_controller fixes it. At this point we can't know in which state the card is, so using SA5_INTR_OFF + SA5_REPLY_INTR_MASK_OFFSET defines directly, instead of the function the drivers provides, seems to be apropriate. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- d

[PATCH v2 04/48] hpsa: change how SA controllers are reset

2015-01-23 Thread Don Brace
Change how SA controllers are reset by changing PCI power levels. The hpsa driver was finding the PCI_PM_CTRL_STATE_MASK offset then reading/writing a bitmask to change the power state. There are kernel functions that do the same operations. Better to use the kernel functions. Signed-off-by: Don

[PATCH v2 19/48] hpsa: report allocation failures while allocating SG chain blocks

2015-01-23 Thread Don Brace
From: Robert Elliott Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 64d17d1..dc328ce 100644 --- a/drivers

[PATCH v2 22/48] hpsa: reserve some commands for use by driver

2015-01-23 Thread Don Brace
the driver so that we can remove the locks thta protect the queue that we will no longer have. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |7 +-- drivers/scsi/hpsa.h |2 ++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c

[PATCH v2 14/48] hpsa: refactor hpsa_find_board_params() to encapsulate legacy test

2015-01-23 Thread Don Brace
From: Webb Scales Encapsulate the conditional predicate which tests for legacy controllers in a separate function and rework the code comments. Reviewed-by: Scott Teel Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 30 +- 1 file

[PATCH v2 17/48] hpsa: rename hpsa_request_irq to hpsa_request_irqs

2015-01-23 Thread Don Brace
From: Robert Elliott Make the function name more descriptive. We use more than one interrupt. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/scsi

  1   2   3   4   5   6   7   8   9   10   >