if (rq_data_dir() == WRITE) else if() else chain had an extra
"else" since the if() is on a value of 1 bit.
Also with a bidi request rq_data_dir() == WRITE
and blk_bidi_rq() == true.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/sd.c |5 +
d
On Thu, Dec 13 2007 at 20:43 +0200, [EMAIL PROTECTED] wrote:
> From: Mike Christie <[EMAIL PROTECTED]>
>
> The previous patches converted iscsi_tcp to support sg chaining.
> This patch sets the proper flags and sets sg_table size to
> 4096. This allows fs io to be capped at max_sectors, but passth
On Sat, Dec 15 2007 at 2:27 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2007-09-18 at 17:04 +0200, Boaz Harrosh wrote:
>> On Wed, Sep 12 2007 at 10:42 +0300, Russell King <[EMAIL PROTECTED]> wrote:
>>> On Wed, Sep 12, 2007 at 02:55:19AM +0300, Boaz Har
On Mon, Dec 17 2007 at 13:41 +0200, "Filippos Papadopoulos" <[EMAIL PROTECTED]>
wrote:
> On Dec 17, 2007 1:18 PM, Andrew Morton <[EMAIL PROTECTED]> wrote:
>> On Mon, 17 Dec 2007 11:39:47 +0200 "Filippos Papadopoulos" <[EMAIL
>> PROTECTED]> wrote:
>>
>>> Hi,
>>> I have got an INITIO 9100 UW SCSI C
On Mon, Dec 17 2007 at 14:18 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> On Mon, Dec 17 2007 at 13:41 +0200, "Filippos Papadopoulos" <[EMAIL
> PROTECTED]> wrote:
>> On Dec 17, 2007 1:18 PM, Andrew Morton <[EMAIL PROTECTED]> wrote:
>>> On Mon,
On Mon, Dec 17 2007 at 15:05 +0200, Alan Cox <[EMAIL PROTECTED]> wrote:
>> initio doesn't seem to have a maintainer...
>>
>> Are you able to identify any earlier kernel which worked OK?
>>
>> Maybe it's a new device? If you can get the `lspci -vvxx' output
>> for that device we can take a look.
>
On Mon, Dec 17 2007 at 17:03 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Mon, 2007-12-17 at 14:36 +, Alan Cox wrote:
>> On Mon, 17 Dec 2007 16:40:53 +0200
>> Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>>
>>> On Mon, Dec 17 2007 at 15:05
On Mon, Dec 17 2007 at 18:20 +0200, Olivier Galibert <[EMAIL PROTECTED]> wrote:
> On Mon, Dec 17, 2007 at 06:08:59PM +0200, Boaz Harrosh wrote:
>> Below fixes a deadly typo. Might as well be included in 2.6.24
>
> You're sure ? scsi_for_each_sg
Submitted is a patchset for adding support for variable-length, extended, and
vendor specific CDBs. It should now cover the entire range of the
SCSI standard.
They are based on scsi-misc + the submitted bidi patches.
Difference from last time, is at struct request. I did a smallish
hack to save
the same infrastructure used for VARLEN CDB's.
So in effect MAX_COMMAND_SIZE means the maximum size command
scsi-ml supports without specifying a cmd_len by ULD's
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/firewire/fw-sbp2.c |2 +-
drivers/s390/scsi/zfcp_dbf.
varlen_cdb's.
- Note that this patch does not add any size to struct request
since the unsigned cmd_len is split here to 2 ushorts, which
is more then enough.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
block/ll_rw_blk.c |2 ++
include/linux/blkd
tches).
- clean-up some code paths that did not expect commands to be
larger than 16, and change cmd_len members' type to short as
char is not enough.
- Add support for varlen_cdb in scsi_execute.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
Signed-off-by: Benny Halevy &
On Wed, Dec 19 2007 at 10:48 +0200, "Filippos Papadopoulos" <[EMAIL PROTECTED]>
wrote:
> On Dec 17, 2007 2:18 PM, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>> I have found one problem. Please try patch [2] below and report.
>> If it still fails try to enab
On Thu, Dec 20 2007 at 9:22 +0200, Rusty Russell <[EMAIL PROTECTED]> wrote:
> Hi Alan,
>
> Was looking through initio.c to convert it to sg_ring, and noticed this
> code:
>
> initio_build_scb() around 2616:
> sg = &cblk->sglist[0];
> scsi_for_each_sg(cmnd, sglis
On Thu, Dec 20 2007 at 9:58 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote:
> On Thu, Dec 20 2007, Rusty Russell wrote:
>> On Thursday 20 December 2007 18:07:41 FUJITA Tomonori wrote:
>>> On Thu, 20 Dec 2007 16:45:18 +1100
>>>
>>> Rusty Russell <[EMAIL PROTECTED]> wrote:
OK, some fixes since last
Manually doing chained sg lists is not trivial, so add some helpers
to make sure that drivers get it right.
Signed-off-by: Jens Axboe <[EMAIL PROTECTED]>
---
include/linux/scatterlist.h | 125 ---
lib/Makefile|2 +-
lib/scatterlist.c | 281
From: Jens Axboe <[EMAIL PROTECTED]>
Signed-off-by: Jens Axboe <[EMAIL PROTECTED]>
---
drivers/scsi/libsrp.c|2 +-
drivers/scsi/scsi_error.c|4 +-
drivers/scsi/scsi_lib.c | 150 +-
drivers/usb/storage/isd200.c |4 +-
include/sc
From: Jens Axboe <[EMAIL PROTECTED]>
Signed-off-by: Jens Axboe <[EMAIL PROTECTED]>
---
drivers/ide/arm/icside.c |6 +++---
drivers/ide/cris/ide-cris.c |2 +-
drivers/ide/ide-dma.c |8
drivers/ide/ide-io.c |2 +-
drivers/ide/ide-probe.c |6
A small comment in body
On Thu, Dec 20 2007 at 16:00 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> Manually doing chained sg lists is not trivial, so add some helpers
> to make sure that drivers get it right.
>
> Signed-off-by: Jens Axboe <[EMAIL PROTECTED]>
On Thu, Dec 20 2007 at 16:03 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> From: Jens Axboe <[EMAIL PROTECTED]>
>
> Signed-off-by: Jens Axboe <[EMAIL PROTECTED]>
> ---
> drivers/scsi/libsrp.c|2 +-
> drivers/scsi/scsi_error.c|4 +-
&g
On Tue, Dec 18 2007 at 15:33 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> Submitted is a patchset for adding support for variable-length, extended, and
> vendor specific CDBs. It should now cover the entire range of the
> SCSI standard.
>
ping James.
I understand tha
On Sat, Dec 22 2007 at 22:15 +0200, Pete Wyckoff <[EMAIL PROTECTED]> wrote:
> I spent the last couple of days rebasing my working set of kernel
> patches from 2.6.22-rc5 to 2.6.24-rc6. I want to use the BSG
> interface from userspace to submit variable-length bidirectional
> SCSI commands to targe
On Fri, Dec 21 2007 at 4:30 +0200, Benjamin Herrenschmidt <[EMAIL PROTECTED]>
wrote:
> The sense buffer ins scsi_cmnd can nowadays be DMA'ed into directly
> by some low level drivers (that typically happens with USB mass
> storage).
>
> This is a problem on non cache coherent architectures such a
On Sat, Dec 29 2007 at 3:50 +0200, thanatos <[EMAIL PROTECTED]> wrote:
> I got a sata controller ignitio
>
> 00:11.0 SATA controller: Initio Corporation INI-1623 PCI SATA-II
> Controller (rev 02) (prog-if 00 [Vendor specific])
> Subsystem: Initio Corporation INI-1623 PCI SATA-II Control
On Thu, Jan 03 2008 at 10:50 +0200, Rusty Russell <[EMAIL PROTECTED]> wrote:
> This patch simply converts direct uses of ->use_sg and ->request_buffer to
> use the wrapper macros. This removes the assumption that the sg list is
> overloaded on request_buffer, and that there's an explicit use_sg fi
On Thu, Jan 03 2008 at 9:00 +0200, Rusty Russell <[EMAIL PROTECTED]> wrote:
> OK, after wading through many scsi drivers, I decided to change tack and try
> to provide a transition path. This is in two stages:
>
> 1) These two patches. sg_ring used underneath, but if any driver asks for
> scsi
On Thu, Jan 03 2008 at 6:56 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> To remove sense_buffer array in scsi_cmnd structure, this replaces
> sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE in several LLDs.
>
> Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
> ---
> drivers/ata/libata-sc
James
Could you at least put the following patch in scsi-pending
so it can attract some acknowledgment, and retract futile
attempts from people at coding these drivers.
(And also git is better than me in maintaining it synced)
Christoph Hellwig!
I need your Recommended-by: on this. I had my r
On Sat, Jan 05 2008 at 1:02 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Thu, 2007-12-13 at 13:44 +0200, Boaz Harrosh wrote:
>> - If we export scsi_init_io()/scsi_release_buffers() instead of
>> scsi_{alloc,free}_sgtable() from scsi_lib than tgt code is
>&
On Mon, Jan 07 2008 at 8:53 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> On Sun, 23 Dec 2007 13:09:05 +0200
> Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>
>> On Fri, Dec 21 2007 at 4:30 +0200, Benjamin Herrenschmidt <[EMAIL
>> PROTECTED]> wrote:
- Original Message -
*From:* Hans de Goede <[EMAIL PROTECTED]>
*To:* USB Storage list <[EMAIL PROTECTED]>
*CC:* [EMAIL PROTECTED], USB development list
<[EMAIL PROTECTED]>, David Brown
<[EMAIL PROTECTED]>, Guillaume Bedot <[EMAIL PROTECTED]>,
linux-scsi@vger.kernel.org, [EMAIL PROTECTED]
*S
On Thu, Jan 10 2008 at 12:52 +0200, Hans de Goede <[EMAIL PROTECTED]> wrote:
> Boaz Harrosh wrote:
>> - Original Message -
>> *From:* Hans de Goede <[EMAIL PROTECTED]>
>> *To:* USB Storage list <[EMAIL PROTECTED]>
>> *CC:* [EMAIL PROTECTE
On Thu, Jan 10 2008 at 14:33 +0200, Oliver Neukum <[EMAIL PROTECTED]> wrote:
> Hi,
>
> could you explain to me why this code can get away with allocating the
> sense buffer on the stack?
>
> static int sg_io(struct file *file, struct request_queue *q,
> struct gendisk *bd_disk, stru
On Thu, Jan 10 2008 at 15:06 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote:
> On Thu, Jan 10 2008, Boaz Harrosh wrote:
>> On Thu, Jan 10 2008 at 14:33 +0200, Oliver Neukum <[EMAIL PROTECTED]> wrote:
>>> Hi,
>>>
>>> could you explain to me why this
On Thu, Jan 10 2008 at 21:45 +0200, Andre Noll <[EMAIL PROTECTED]> wrote:
> On 20:29, Andi Kleen wrote:
>
>>> Sure, I can do that if James likes the idea. Since not all case
>>> statements need the BKL, we could add it only to those for which it
>>> isn't clear that it is unnecessary.
>>>
>>> And
On Tue, Jan 15 2008 at 11:23 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> This is the second version of
>
> http://marc.info/?l=linux-scsi&m=119933628210006&w=2
>
> I gave up once, but I found that the performance loss is negligible
> (within 1%) by using kmem_cache_alloc instead of mempoo
On Tue, Jan 15 2008 at 17:08 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> On Tue, 15 Jan 2008 15:56:56 +0200
> Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>
>> On Tue, Jan 15 2008 at 11:23 +0200, FUJITA Tomonori <[EMAIL PROTECTED]>
>> wrote:
>>
On Tue, Jan 15 2008 at 17:20 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2008-01-15 at 18:23 +0900, FUJITA Tomonori wrote:
>> This is the second version of
>>
>> http://marc.info/?l=linux-scsi&m=119933628210006&w=2
>>
>> I gave up once, but I found that the performance loss is negli
On Tue, Jan 15 2008 at 17:52 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> I thought, now we had this new shiny code to increase the scatterlist
> table size I'd try it out. It turns out there's a pretty vast block
> conspiracy that prevents us going over 128 entries in a scatterlist.
>
> T
On Tue, Jan 15 2008 at 18:49 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2008-01-15 at 18:09 +0200, Boaz Harrosh wrote:
>> On Tue, Jan 15 2008 at 17:52 +0200, James Bottomley <[EMAIL PROTECTED]>
>> wrote:
>>> I thought, now we had this new sh
On Tue, Jan 15 2008 at 19:35 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> On Tue, Jan 15 2008 at 18:49 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
>> On Tue, 2008-01-15 at 18:09 +0200, Boaz Harrosh wrote:
>>> On Tue, Jan 15 2008 at 17:52 +0200, Jam
On Wed, Jan 16 2008 at 17:09 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Wed, 2008-01-16 at 16:01 +0200, Boaz Harrosh wrote:
>> On Tue, Jan 15 2008 at 19:35 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>>> On Tue, Jan 15 2008 at 18:49 +0200, Jam
On Wed, Jan 16 2008 at 18:11 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> On Wed, Jan 16 2008 at 17:09 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
>> On Wed, 2008-01-16 at 16:01 +0200, Boaz Harrosh wrote:
>>> On Tue, Jan 15 2008 at 19:35 +0200, Boaz Har
removed because it is no longer supported.
Note: SG_ALL can not be used as an allocation size anymore.
FIXME: Important/capable drivers like iscsi have moved away from
SG_ALL to hard coded numbers like 4096. They should reuse
SG_ALL now.
Signed-off-by: Boaz Harrosh <[EM
These drivers used the SG_ALL constant, But actually
meant some other define.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/a100u2w.c |3 +--
drivers/scsi/advansys.c |8 +++-
drivers/scsi/initio.c |2 +-
3 files changed, 5 insertions(+), 8 del
arm-scsi core is not sg-chain ready, so maximum scatterlist supported
is SCSI_MAX_SG_SEGMENTS. Define it so, in core, and let all drivers
use it for the sg_tablesize in host templates.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/arm/acornscsi.c |2 +-
driver
wd33c93 core is not sg-chain ready, so maximum scatterlist supported
is SCSI_MAX_SG_SEGMENTS. Define it so, in core, and let all drivers
use it for the sg_tablesize in host templates.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/a2091.c |2 +-
drivers/scsi
NCR5380 core is not sg-chain ready, so maximum scatterlist supported
is SCSI_MAX_SG_SEGMENTS. Define it so, in core, and let all drivers
use it for the sg_tablesize in host templates.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/NCR5380.h |3 +++
driver
a2xxx/qla_os.c
drivers/scsi/qla4xxx/ql4_def.h
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/atari_scsi.c|8
drivers/scsi/atari_scsi.h|4 ++--
drivers/scsi/eata_pio.c |5 -
drivers/scsi/ibmvscsi/ibmvsc
vers/files:
drivers/firewire/fw-sbp2.c
drivers/ieee1394/sbp2.[ch]
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/firewire/fw-sbp2.c |6 --
drivers/ieee1394/sbp2.c|2 +-
drivers/ieee1394/sbp2.h|4 +++-
3 files changed, 8 insertions(+), 4 deletions(
I have scanned through the scsi tree and checked all places that used
SG_ALL. Those drivers that where not ready for SG_ALL to mean "any size"
where changed to what ever is appropriate for this driver.
Mainly 3 groups.
Those that meant SG_ALL == 255:
[PATCH 1/8] firewire: ieee1394: Move away f
drivers/scsi/in2000.h
drivers/scsi/pcmcia/nsp_cs.c
drivers/scsi/ppa.c
drivers/scsi/tmscsim.c
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/aha152x.c |5 -
drivers/scsi/esp_scsi.c |2 +-
drivers/scsi/esp_scsi.h |3 +++
d
On Thu, Jan 17 2008 at 19:47 +0200, Andrew Vasquez <[EMAIL PROTECTED]> wrote:
> On Thu, 17 Jan 2008, Boaz Harrosh wrote:
>
>> below list of drivers have used SG_ALL as a size to
>> preallocate maximum possible command's sg-count.
>> This is no longe
ivers/scsi/nsp32.h
drivers/scsi/qla1280.c
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/atari_scsi.c|8
drivers/scsi/atari_scsi.h|4 ++--
drivers/scsi/eata_pio.c |5 -
drivers/scsi/ibmvscsi/ibmvscsi.c |8 +-
On Wed, Jan 16 2008 at 6:32 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> This is the third version of:
>
> http://marc.info/?l=linux-scsi&m=120038907123706&w=2
>
> The changes from the second version are:
>
> - Fixed the memory leak bug that Boaz pointed out.
>
> shots->backup_sense_buff
On Tue, Jan 15 2008 at 19:52 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> this patch depends on the sg branch of the block tree
>
> James
>
> ---
> From: James Bottomley <[EMAIL PROTECTED]>
> Date: Tue, 15 Jan 2008 11:11:46 -0600
> Subject: remove use_sg_chaining
>
> With the sg table cod
On Sun, Jan 20 2008 at 21:24 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Sun, 2008-01-20 at 21:18 +0200, Boaz Harrosh wrote:
>> On Tue, Jan 15 2008 at 19:52 +0200, James Bottomley <[EMAIL PROTECTED]>
>> wrote:
>>> this patch depends on the sg br
On Sun, Jan 20 2008 at 21:29 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote:
> On Sun, Jan 20 2008, James Bottomley wrote:
>> On Sun, 2008-01-20 at 21:18 +0200, Boaz Harrosh wrote:
>>> On Tue, Jan 15 2008 at 19:52 +0200, James Bottomley <[EMAIL PROTECTED]>
>>>
On Sun, Jan 20 2008 at 22:59 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Sun, 2008-01-20 at 21:01 +0100, Jens Axboe wrote:
>> On Sun, Jan 20 2008, Jens Axboe wrote:
>>> On Sun, Jan 20 2008, Boaz Harrosh wrote:
>>>> On Sun, Jan 20 2008 at 21:29 +0200,
On Mon, Jan 21 2008 at 11:31 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote:
> On Mon, Jan 21 2008, Boaz Harrosh wrote:
>> On Sun, Jan 20 2008 at 22:59 +0200, James Bottomley <[EMAIL PROTECTED]>
>> wrote:
>>> On Sun, 2008-01-20 at 21:01 +0100, Jens Axboe wrote:
On Tue, Jan 22 2008 at 18:31 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> From: James Bottomley <[EMAIL PROTECTED]>
> Subject: [PATCH 0/3] update bidirectional series to sit on top of sg_table
> Date: Fri, 11 Jan 2008 21:09:00 -0600
>
>> OK, I suppose in the scheme of things, it's my turn t
omonori <[EMAIL PROTECTED]>
Date: Wed, 23 Jan 2008 19:56:04 +0200
Subject: [PATCH] use dynamically allocated sense buffer
This removes static array sense_buffer in scsi_cmnd and uses
dynamically allocated DMA able sense_buffer.
The reason for doing this is that some architectures need c
With gcc 4.1.2 on fedora7 x86_64, cross compiling an i386 kernel i get
the following compilation warning:
CC [M] drivers/scsi/qla2xxx/qla_sup.o
/usr0/export/dev/bharrosh/git/pub/scsi-misc/drivers/scsi/qla2xxx/qla_sup.c: In
function ‘qla2x00_beacon_blink’:
/usr0/export/dev/bharrosh/git/pub/scsi-mi
Greg KH wrote:
> On Mon, Jan 28, 2008 at 09:49:35PM +0100, Jens Axboe wrote:
>> Hi,
>>
>> Running latest -git (head 91525300baf162e83e923b09ca286f9205e21522) and
>> connecting my cf usb storage device yields and endless stream of:
>>
>> Initializing USB Mass Storage driver...
>> scsi6 : SCSI emulat
On Tue, Jan 29 2008 at 16:11 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote:
> On Tue, Jan 29 2008, Boaz Harrosh wrote:
>> On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote:
>>> On Tue, Jan 29 2008, Boaz Harrosh wrote:
>>>> Greg KH
On Tue, Jan 29 2008 at 16:06 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote:
>> On Tue, Jan 29 2008, Boaz Harrosh wrote:
>>> Greg KH wrote:
>>>> On Mon, Jan 28, 2008 at 09
On Tue, Jan 29 2008 at 17:36 +0200, Alan Stern <[EMAIL PROTECTED]> wrote:
> On Tue, 29 Jan 2008, Boaz Harrosh wrote:
>
>> --- a/drivers/usb/storage/transport.c
>> +++ b/drivers/usb/storage/transport.c
>> @@ -462,18 +462,24 @@ static int usb_stor_bulk_transfer
On Tue, Jan 29 2008 at 16:31 +0200, Oliver Neukum <[EMAIL PROTECTED]> wrote:
> Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe:
>> On Tue, Jan 29 2008, Boaz Harrosh wrote:
>>> On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote:
>>
On Tue, Jan 29 2008 at 15:54 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote:
> On Tue, Jan 29 2008, Boaz Harrosh wrote:
>> Greg KH wrote:
>>> On Mon, Jan 28, 2008 at 09:49:35PM +0100, Jens Axboe wrote:
>>>> Hi,
>>>>
>>>> Running lat
On Tue, Jan 29 2008 at 22:24 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2008-01-29 at 21:06 +0100, Jens Axboe wrote:
>>> I will ... but it will cause an explosion in the bidirectional tree
>>> again. I think the bidi updates also fix this. However, give me time
>>> to rebase and
PM +0100, Jens Axboe wrote:
>>>>> On Tue, Jan 29 2008, Jens Axboe wrote:
>>>>>> On Tue, Jan 29 2008, Oliver Neukum wrote:
>>>>>>> Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe:
>>>>>>>> On Tue, Jan 29 2008,
On Tue, Jan 29 2008 at 20:39 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote:
> On Tue, Jan 29 2008, Jens Axboe wrote:
>> On Tue, Jan 29 2008, Oliver Neukum wrote:
>>> Am Dienstag, 29. Januar 2008 15:11:08 schrieb Jens Axboe:
>>>> On Tue, Jan 29 2008, Boaz Harrosh
On Tue, Jan 29 2008 at 18:34 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2008-01-29 at 10:36 -0500, Alan Stern wrote:
>> On Tue, 29 Jan 2008, Boaz Harrosh wrote:
>>
>>> --- a/drivers/usb/storage/transport.c
>>> +++ b/drivers/usb/storage/trans
On Tue, Jan 29 2008 at 21:17 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2008-01-29 at 20:58 +0200, Boaz Harrosh wrote:
>>> Your new code does
>>>
>>> int partial; <- stack uninitialised
>>> sb_stor_bulk_transfer_sglist(..., &par
On Tue, Jan 29 2008 at 20:48 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2008-01-29 at 20:27 +0200, Boaz Harrosh wrote:
>> On Tue, Jan 29 2008 at 18:34 +0200, James Bottomley <[EMAIL PROTECTED]>
>> wrote:
>>> On Tue, 2008-01-29 at 10:36 -0500, A
>>
> Ok this is not in Linus tree is it? Hence I did not have that failure.
>
> Boaz
>
>
actually James bidi tree has a fix for this in the scsi_data_buffer patch.
what you sent is not enough there are other places. look at this patch I
sent to the list.
http://www.spinics.net/lists/linux-scs
On Tue, Jan 29 2008 at 22:13 +0200, Jens Axboe <[EMAIL PROTECTED]> wrote:
> On Tue, Jan 29 2008, Boaz Harrosh wrote:
>>> Ok this is not in Linus tree is it? Hence I did not have that failure.
>>>
>>> Boaz
>>>
>>>
>> actually Jame
On Wed, Jan 30 2008 at 21:47 +0200, Sven Köhler <[EMAIL PROTECTED]> wrote:
> Hi,
>
> so i have upgraded a system to kernel 2.6.24. After that, it failed to
> boot with the usual message telling, that the rootfs on device /dev/sda1
> cannot be mounted (a raid1 run by the controller below).
>
>
On Thu, Jan 31 2008 at 13:07 +0200, Sven Köhler <[EMAIL PROTECTED]> wrote:
>> Yes the gdth driver passed an open hart surgery in kernel 2.6.24. The bad
>> thing
>> about it is that all three of the Coders that did that did not have any HW
>> to work
>> on. One of them is me. We did cry for tester
On Thu, Jan 31 2008 at 17:08 +0200, Mark Glines <[EMAIL PROTECTED]> wrote:
> On Thu, 31 Jan 2008 11:27:39 +0200
> Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>
>> Please check the below patch.
>>
>> one thing that I can see is that the isd200 does an INQUARY tr
On Thu, Jan 31 2008 at 18:39 +0200, Jan Engelhardt <[EMAIL PROTECTED]> wrote:
> Hi,
>
> On Jan 31 2008 14:35, Boaz Harrosh wrote:
>> Thanks, Perhaps someone else then.
>> Anyone with gdth HW that can test patches?
>
> Is bisecting down the existing chain and fin
usb_stor_set_xfer_buf() should report this condition as a negative
resid. Should we also set cmnd->status in the underflow condition?
Then also isd200.c is fixed to only return the type of INQUIRY && SENSE
the upper layer asked for.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
dr
On Thu, Jan 31 2008 at 18:45 +0200, Alan Stern <[EMAIL PROTECTED]> wrote:
> On Thu, 31 Jan 2008, Boaz Harrosh wrote:
>
>>>> Please check the below patch.
>>>>
>>>> one thing that I can see is that the isd200 does an INQUARY transfer
>>>
On Thu, Jan 31 2008 at 19:29 +0200, Ingo Molnar <[EMAIL PROTECTED]> wrote:
> FYI, automated testing found the following build breakage:
>
> drivers/scsi/NCR53C9x.c: In function 'esp_get_dmabufs':
> drivers/scsi/NCR53C9x.c:913: error: 'Scsi_Cmnd' has no member named 'use_sg'
> drivers/scsi/NCR53C9x
Cheers after 1.3 years these can go in.
[PATCH 1/3] iscsi: extended cdb support
The varlen support is not yet in mainline for
block and scsi-ml. But the API for drivers will
not change. All LLD need to do is max_command to
the it's maximum and be ready for bigger commands.
This is what'
On Thu, Jan 31 2008 at 20:00 +0200, Greg KH <[EMAIL PROTECTED]> wrote:
> On Thu, Jan 31, 2008 at 07:19:57PM +0200, Boaz Harrosh wrote:
>> scsi_scan is issuing a 36-byte INQUIRY request to llds. isd200 would
>> volunteer 96 bytes of INQUIRY. This caused an underflow conditi
On Thu, Jan 31 2008 at 19:49 +0200, Alan Stern <[EMAIL PROTECTED]> wrote:
> On Thu, 31 Jan 2008, Boaz Harrosh wrote:
>
>> @@ -228,9 +228,14 @@ void usb_stor_set_xfer_buf(unsigned char *buffer,
>> {
>> unsigned int offset = 0;
>> struct scatterlist *s
u, 3 Jan 2008, James Bottomley wrote:
>>>>> On Thu, 2008-01-03 at 17:40 +0200, Boaz Harrosh wrote:
>>>>>> As recommended by Christoph Hellwig. There is no use
>>>>>> of Fixing these drivers, since there is a much simpler
>>>>>&
nderflow conditions.
Then usb_stor_set_xfer_buf() should report this condition as a negative
resid. Should we also set cmnd->status in the overflow condition?
Then also isd200.c is fixed to only return the type of INQUIRY && SENSE
the upper layer asked for.
Signed-off-by: Boaz Harros
On Thu, Jan 31 2008 at 21:34 +0200, Alan Stern <[EMAIL PROTECTED]> wrote:
> On Thu, 31 Jan 2008, Boaz Harrosh wrote:
>
>> On Thu, Jan 31 2008 at 19:49 +0200, Alan Stern <[EMAIL PROTECTED]> wrote:
>>> On Thu, 31 Jan 2008, Boaz Harrosh wrote:
>>>
>>&g
On Thu, Jan 31 2008 at 21:49 +0200, Matthew Dharm <[EMAIL PROTECTED]> wrote:
> No. No no no.
>
> The ISD200 code was written by the ISD200 developers. I really don't want
> to go mucking about changing what commands actually get send to the ISD200
> parts. We have no idea if the will reliably a
Support for extended CDBs in iscsi.
All we need is to check if command spills over 16 bytes then allocate
an iscsi-extended-header for the leftovers.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/iscsi_tcp.c |2 +-
drivers/scsi/libiscsi.c
iscsi bidi support at the generic libiscsi level
- prepare the additional bidi_read rlength header.
- access the right scsi_in() and/or scsi_out() side of things.
also for resid.
- Handle BIDI underflow overflow from target
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
d
bidi support for iscsi_tcp
- access the right scsi_in() and/or scsi_out() side of things.
also for resid
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/iscsi_tcp.c | 31 +--
1 files changed, 17 insertions(+), 14 deletions(-)
diff -
On Thu, Jan 31 2008 at 22:56 +0200, Alan Stern <[EMAIL PROTECTED]> wrote:
> On Thu, 31 Jan 2008, Boaz Harrosh wrote:
>
>>>> The code in usb_stor_access_xfer_buf() will
>>>> now correctly attempt to transfer according to buflen and what ever is
>>>
On Sun, Feb 03 2008 at 18:01 +0200, Alan Stern <[EMAIL PROTECTED]> wrote:
> Sorry, I understood only about half of what you wrote -- maybe less!
>
> On Sun, 3 Feb 2008, Boaz Harrosh wrote:
>
>> On Thu, Jan 31 2008 at 22:56 +0200, Alan Stern <[EMAIL PROTECTED]&g
On Sun, Feb 03 2008 at 21:23 +0200, Matthew Dharm <[EMAIL PROTECTED]> wrote:
> On Sun, Feb 03, 2008 at 06:28:48PM +0200, Boaz Harrosh wrote:
>> >From 3610cfa93c990bbbafb296134ac01ef6d426eb8d Mon Sep 17 00:00:00 2001
>> From: Boaz Harrosh <[EMAIL PROTECTED]>
>> D
On Mon, Feb 04 2008 at 18:11 +0200, Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Boaz Harrosh wrote:
>> Use of new scsi_eh API for setting sense information into
>> the scsi command.
>>
>> Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
ide REQUEST_SENSE would never
go through. If this is intended then comment and check should
change.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/dpt_i2o.c | 25 +++--
1 files changed, 7 insertions(+), 18 deletions(-)
diff --git a/drivers/scsi/dp
/scsi/scsi_debug.c
drivers/scsi/sym53c8xx_2/sym_glue.c
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
arch/ia64/hp/sim/simscsi.c |8 ++--
drivers/block/cciss_scsi.c |8 +++-
drivers/infiniband/ulp/srp/ib_srp.c |6 +++---
drivers/mes
101 - 200 of 638 matches
Mail list logo
