and device
address in the conventional format.
---
Bjorn Helgaas (3):
megaraid: use dev_printk when possible
megaraid_sas: use dev_printk when possible
megaraid_sas: use dev_printk when possible
drivers/scsi/megaraid.c | 92 -
drivers/scsi/megar
Use dev_printk() when possible to make messages more useful.
Signed-off-by: Bjorn Helgaas
---
drivers/scsi/megaraid/megaraid_sas_base.c | 281 ++---
1 file changed, 139 insertions(+), 142 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers
Use dev_printk() when possible to make messages more useful.
Signed-off-by: Bjorn Helgaas
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 96 ++-
1 file changed, 48 insertions(+), 48 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers
Use dev_printk() when possible to make messages more useful.
Signed-off-by: Bjorn Helgaas
---
drivers/scsi/megaraid.c | 92 ++-
1 file changed, 43 insertions(+), 49 deletions(-)
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index
[+cc linux-pci, linux-kernel, Kashyap, Sumit, Uday, megaraidlinux.pdl]
On Sun, Jul 13, 2014 at 01:35:51AM +, Robin H. Johnson wrote:
> On Sat, Jul 12, 2014 at 11:29:20AM -0600, Bjorn Helgaas wrote:
> > Thanks for the report, Robin.
> >
> > https://bugzilla.kernel.org/
On Wed, Apr 29, 2015 at 12:44 AM, Sumit Saxena
wrote:
>>-Original Message-
>>From: Bjorn Helgaas [mailto:bhelg...@google.com]
>>Sent: Wednesday, April 29, 2015 4:44 AM
>>To: Kashyap Desai; Uday Lingala; Sumit Saxena
>>Cc: megaraidlinux@avagotech.com; Jame
uot; switch, or modifying the BIOS to
skip it). If the Linux driver doesn't rely on the option ROM, you might
even be able to reproduce it by physically removing the option ROM from the
MegaRAID.
Bjorn
On Wed, Apr 29, 2015 at 12:28:32PM -0500, Bjorn Helgaas wrote:
> [+cc linux-pci, l
Use dev_printk() when possible to make messages more useful.
Signed-off-by: Bjorn Helgaas
---
drivers/scsi/megaraid.c | 92 ++-
1 file changed, 43 insertions(+), 49 deletions(-)
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index
megasas_dump_pending_frames() run-on printks into one line each
- Add patch to fix whitespace errors in megasas_dump_pending_frames()
---
Bjorn Helgaas (3):
megaraid : use dev_printk when possible
megaraid_sas : use dev_printk when possible
megaraid_sas : fix whitespace errors
drivers/scsi
Fix whitespace and indentation errors. No code change.
Signed-off-by: Bjorn Helgaas
---
drivers/scsi/megaraid/megaraid_sas_base.c | 28 +---
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers/scsi
Use dev_printk() when possible to make messages more useful.
Signed-off-by: Bjorn Helgaas
---
drivers/scsi/megaraid/megaraid_sas_base.c | 263 +--
drivers/scsi/megaraid/megaraid_sas_fusion.c | 92 +
2 files changed, 177 insertions(+), 178 deletions(-)
diff
On Mon, Jun 1, 2015 at 11:10 AM, Joe Perches wrote:
> On Mon, 2015-06-01 at 10:40 -0500, Bjorn Helgaas wrote:
>> Use dev_printk() when possible to make messages more useful.
> []
>> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
> []
>> @@ -268,7 +
On Mon, Jun 1, 2015 at 11:44 AM, Joe Perches wrote:
> On Mon, 2015-06-01 at 11:40 -0500, Bjorn Helgaas wrote:
>> On Mon, Jun 1, 2015 at 11:10 AM, Joe Perches wrote:
>> > On Mon, 2015-06-01 at 10:40 -0500, Bjorn Helgaas wrote:
>> >> Use dev_printk() when possibl
Use dev_printk() when possible to make messages more useful.
Signed-off-by: Bjorn Helgaas
---
drivers/scsi/megaraid.c | 140 ++-
1 file changed, 66 insertions(+), 74 deletions(-)
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index
-20150601
- Squash megaraid_sas_base.c and megaraid_sas_fusion.c changes into one patch
- Split megasas_dump_pending_frames() run-on printks into one line each
- Add patch to fix whitespace errors in megasas_dump_pending_frames()
---
Bjorn Helgaas (3):
megaraid : use dev_printk when
Fix whitespace and indentation errors. No code change.
Signed-off-by: Bjorn Helgaas
---
drivers/scsi/megaraid/megaraid_sas_base.c | 244 ++---
1 file changed, 118 insertions(+), 126 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers/scsi
Use dev_printk() when possible to make messages more useful.
Signed-off-by: Bjorn Helgaas
---
drivers/scsi/megaraid/megaraid_sas_base.c | 304 +--
drivers/scsi/megaraid/megaraid_sas_fusion.c | 95
2 files changed, 196 insertions(+), 203 deletions(-)
diff
On Wed, Jul 8, 2015 at 5:47 AM, Hannes Reinecke wrote:
> On 07/07/2015 10:52 PM, Bjorn Helgaas wrote:
>> Use dev_printk() when possible to make messages more useful.
>>
>> Signed-off-by: Bjorn Helgaas
>> ---
>> drivers/scsi/mega
On Wed, Jul 15, 2015 at 08:52:13AM -0500, Timothy Pearson wrote:
> On 07/15/2015 01:24 AM, Sreekanth Reddy wrote:
> > On Tue, Jul 14, 2015 at 10:36:58PM -0700, Yinghai Lu wrote:
> >> On Tue, Jul 14, 2015 at 9:49 PM, Sreekanth Reddy
> >> wrote:
> >>> Driver crashes if the BIOS do not set up at leas
On Wed, Jul 15, 2015 at 10:19:56AM +0530, Sreekanth Reddy wrote:
> Driver crashes if the BIOS do not set up at least one
> memory I/O resource. This failure can happen if the device is too
> slow to respond during POST and is missed by the BIOS, but Linux
> then detects the device later in the boot
On Mon, Jan 30, 2017 at 01:15:41PM +0100, Christoph Hellwig wrote:
> Bart reported a problem wіth an out of bounds access in the low-level
> IRQ affinity code, which we root caused to the qla2xxx driver assigning
> all it's MSI-X vectors to the pre and post vectors, and not having any
> left for th
On Thu, Feb 02, 2017 at 07:32:16PM +0100, Christoph Hellwig wrote:
> On Thu, Feb 02, 2017 at 11:36:59AM -0600, Bjorn Helgaas wrote:
> > You didn't say exactly where the out of bounds access was, but I assume
> > it's probably in irq_create_affinity_masks() in this path:
&g
On Fri, Sep 26, 2014 at 10:36 AM, Chen Gang wrote:
> When xenbus_switch_state() fails, it will call xenbus_switch_fatal()
> internally, so need not return any status value, then use 'void' instead
> of 'int' for xenbus_switch_state() and __xenbus_switch_state().
>
> Also need be sure that all call
On Mon, Jun 06, 2016 at 09:32:37AM +0200, Thierry Reding wrote:
> From: Thierry Reding
>
> There is now a common implementation for a match function that will
> always match, so the PCI-specific implementation can be removed.
>
> Signed-off-by: Thierry Reding
Acked-by: B
[+cc linux-pci]
On Wed, May 15, 2013 at 11:26 AM, Joe Lawrence wrote:
> From 9fc1a958ad48718216fbdc19405297dd11d11539 Mon Sep 17 00:00:00 2001
> From: Joe Lawrence
> Date: Tue, 14 May 2013 15:41:17 -0400
> Subject: [PATCH] mpt2sas,mpt3sas: make watchdog instantiated device removal
> safe
>
> Ca
[+cc linux-pci]
On Wed, May 15, 2013 at 11:29 AM, Joe Lawrence wrote:
> From 84ac7a35ebd61e84d4254eae78bb967de17254c2 Mon Sep 17 00:00:00 2001
> From: Joe Lawrence
> Date: Wed, 15 May 2013 12:52:31 -0400
> Subject: [PATCH] mpt2sas,mpt3sas: make watchdog instantiated device removal
> safe
>
> Ca
On Sat, May 25, 2013 at 7:48 AM, Jiang Liu wrote:
> From: Gu Zheng
>
> Use the new pci_alloc_dev(bus) to replace the existing using of
> alloc_pci_dev(void).
> ...
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 26df9c8..d5d18a0 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers
[+cc another email addr for Adam from git logs]
On Wed, Aug 28, 2013 at 9:46 AM, Jiri Kosina wrote:
> On Tue, 27 Aug 2013, Jiri Kosina wrote:
>
>> On Tue, 27 Aug 2013, Jiri Kosina wrote:
>>
>> > Commit d5dea7d95 ("PCI: msi: Disable msi interrupts when we initialize a
>> > pci device") makes MSIs
On Tue, Sep 03, 2013 at 03:35:09PM +0800, Yijing Wang wrote:
> Pcie_capability_xxx() interfaces were introudced to
> simplify code to access PCIe Cap config space. And
> because PCI core saves the PCIe Cap offset in
> set_pcie_port_type() when device is enumerated.
> So we can use pci_is_pcie() ins
On Tue, Sep 03, 2013 at 03:35:10PM +0800, Yijing Wang wrote:
> Pcie_capability_xxx() interfaces were introudced to
s/introudced/introduced/
> simplify code to access PCIe Cap config space. And
> because PCI core saves the PCIe Cap offset in
> set_pcie_port_type() when device is enumerated.
> So w
On Tue, Sep 3, 2013 at 5:34 PM, Bjorn Helgaas wrote:
> On Tue, Sep 03, 2013 at 03:35:09PM +0800, Yijing Wang wrote:
>> Pcie_capability_xxx() interfaces were introudced to
>> simplify code to access PCIe Cap config space. And
>> because PCI core saves the PCIe Cap offset in
Sorry, I said I was going to push this through my PCI tree, but I
forgot all about it. I put it (finally) in my pci/misc branch, and
will merge it during the v3.13 merge window.
On Fri, Jan 4, 2013 at 12:31 PM, Bjorn Helgaas wrote:
> I haven't heard anything, so I'm going to push
On Thu, Sep 05, 2013 at 03:55:25PM +0800, Yijing Wang wrote:
> v1->v2: use pcie_get/set_readrq to simplify code
> a lot suggestd by Bjorn.
>
> Use pcie_get_readrq()/pcie_set_readrq() to simplify
> code.
>
> Signed-off-by: Yijing Wang
> Cc: Jiang Liu
> Cc: Anil Gurumurthy
> Cc: Vijaya Mohan Guv
On Fri, Sep 6, 2013 at 3:51 AM, Jiri Kosina wrote:
> On Wed, 28 Aug 2013, Bjorn Helgaas wrote:
>
>> [+cc another email addr for Adam from git logs]
>
> Thanks. Adam, would you happen to have any possible explanation /
> background?
>
>> >> > Commit d5dea
On Fri, Sep 6, 2013 at 4:47 PM, Bjorn Helgaas wrote:
> On Fri, Sep 6, 2013 at 3:51 AM, Jiri Kosina wrote:
>>> >> > Commit d5dea7d95 ("PCI: msi: Disable msi interrupts when we initialize
>>> >> > a
>>> >> > pci device") makes
On Mon, Jan 26, 2015 at 06:05:22PM +0100, Rafał Miłecki wrote:
> There are few drivers using magic numbers when operating with PCIe
> capabilities and PCI_EXP_DEVCTL_READRQ. Define known values to allow
> cleaning their code a bit.
>
> Signed-off-by: Rafał Miłecki
I applied this whole series, wi
Use the standard #defines for PCIe Link Capability register fields
rather than bare numbers. This also uses the new PCI Express Capability
accessor rather than reading the capability directly.
Signed-off-by: Bjorn Helgaas
CC: Andrew Vasquez
CC: linux-dri...@qlogic.com
CC: "James E.J. Bott
On Tue, Nov 6, 2012 at 3:04 PM, Bjorn Helgaas wrote:
> The ROM address handling in gdth_init_pci() is useless and possibly
> dangerous. This patch removes it.
>
> "pci_resource_start(pdev, 8)" is not well-defined. PCI resources 0-5 are
> standard PCI BARs and 6 is the e
t;Saurav Kashyap" wrote:
>
>>Acked-by: Saurav Kashyap
>>
>>Thanks,
>>~Saurav
>>
>>
>>
>>>Use the standard #defines for PCIe Link Capability register fields
>>>rather than bare numbers. This also uses the new PCI Express Capability
I haven't heard anything, so I'm going to push this through the PCI
tree. Let me know if anybody objects or would like to handle it
differently.
On Mon, Dec 17, 2012 at 12:21 PM, Bjorn Helgaas wrote:
> Ping. I didn't push this through my tree because I didn't want to
;> To: linux-scsi@vger.kernel.org
>> Cc: DL-MPT Fusion Linux; Support; Reddy, Sreekanth; Nandigama,
>> Nagalakshmi; James E.J. Bottomley; Bjorn Helgaas
>> Subject: [PATCH 1/2] mptfusion, mpt2sas, mpt3sas: Don't remove dead IOC
>> PCI device
>>
>> De
On Tue, Mar 5, 2013 at 6:46 PM, Desai, Kashyap wrote:
>
>
>> -Original Message-----
>> From: Bjorn Helgaas [mailto:bhelg...@google.com]
>> Sent: Wednesday, March 06, 2013 4:43 AM
>> To: Desai, Kashyap
>> Cc: Joe Lawrence; linux-scsi@vger.kernel.org; DL
On Thu, Mar 21, 2013 at 6:51 PM, Robert Hancock wrote:
> On 03/20/2013 10:35 PM, Myron Stowe wrote:
>>
>> Sysfs includes entries to memory regions that back a PCI device's BARs.
>> The pci-sysfs entries backing I/O Port BARs can be accessed by userspace,
>> providing direct access to the device's
On Wed, Mar 20, 2013 at 10:35 PM, Myron Stowe wrote:
> With the 0x1b4b vendor ID #define in place, convert hard-coded ID values.
> Also, unify the previous SCSI specific use of this vendor ID to the new
> macro.
>
> Signed-off-by: Myron Stowe
> ---
>
> drivers/ata/ahci.c | 10 +--
On Sat, Apr 6, 2013 at 2:49 AM, James Bottomley
wrote:
> On Thu, 2013-04-04 at 12:06 -0600, Bjorn Helgaas wrote:
>> On Thu, Mar 21, 2013 at 6:51 PM, Robert Hancock wrote:
>> > -Reconsider whether supporting read/write on the resource files for IO port
>> > regions
On Sat, Apr 6, 2013 at 2:44 AM, James Bottomley
wrote:
> On Thu, 2013-04-04 at 12:23 -0600, Bjorn Helgaas wrote:
>> On Wed, Mar 20, 2013 at 10:35 PM, Myron Stowe wrote:
>> > With the 0x1b4b vendor ID #define in place, convert hard-coded ID values.
>> > Also, unify the
-- Forwarded message --
From: Bjorn Helgaas
Date: Mon, Apr 22, 2013 at 5:10 PM
Subject: [PATCH v4 01/22] [SCSI] megaraid_sas: Use correct #define for
MSI-X capability
To: linux-...@vger.kernel.org
Cc: Neela Syam Kolli , Gavin Shan
, "James E.J. Bottomley"
Previous
Hi Jiang,
I object to subject lines like "Correctly do such and such." Nobody
writes code to do things *incorrectly*, so the word "correctly" takes
up space without contributing meaning. In this case, it's at least
debatable whether this is even the "correct" approach; see below.
On Tue, Sep 08
On Tue, Sep 8, 2015 at 11:49 AM, Jiang Liu wrote:
> Hi Bjorn,
> We have used another draft version to fix this issue by changing
> eata driver as below. But that needs to export pcibios_alloc_irq. And
> I'm not sure whether there are other drivers having the same behavior.
> If we think it
On Fri, May 17, 2013 at 3:42 PM, Joe Lawrence wrote:
> On Fri, 17 May 2013 09:29:06 -0600
> Bjorn Helgaas wrote:
>
>> [+cc linux-pci]
>>
>> On Wed, May 15, 2013 at 11:29 AM, Joe Lawrence
>> wrote:
>> > From 84ac7a35ebd61e84d4254eae78bb967de17254
On Wed, Oct 30, 2013 at 4:27 AM, Jiri Kosina wrote:
> Attached is dmesg output leading to timeouts (that are cured by my
> original patch in this thread) and lspci.
I opened https://bugzilla.kernel.org/show_bug.cgi?id=64141 for this
issue and attached your dmesg log and lspci output.
> Please le
On Tue, Nov 5, 2013 at 6:06 AM, Jiri Kosina wrote:
> On Thu, 31 Oct 2013, Bjorn Helgaas wrote:
>
>> > Attached is dmesg output leading to timeouts (that are cured by my
>> > original patch in this thread) and lspci.
>>
>> I opened https://bugzilla.kerne
On Mon, Dec 23, 2013 at 8:13 AM, wrote:
> This patch has fix for LSI Gen-1 MR controller issue which only pop-up on
> few systems and it is not generic.
>
> On few system, MR 1078 MR controller is not working if mmio decoding is off.
> This patch proposed early quirck entry for Device id 0x1000/0
[+cc Myron]
On Tue, Dec 24, 2013 at 1:20 AM, Desai, Kashyap wrote:
>
>
>> -Original Message-----
>> From: Bjorn Helgaas [mailto:bhelg...@google.com]
>> Sent: Monday, December 23, 2013 11:28 PM
>> To: Desai, Kashyap
>> Cc: linux-scsi@vger.kernel.org;
On Wed, Jan 15, 2014 at 02:36:36PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
> Subject: powerpc / eeh_driver: Use global PCI rescan-remove locking
>
> Race conditions are theoretically possible between the PCI device
> addition and removal in the PPC64 PCI error recovery driver an
On Fri, Jan 10, 2014 at 03:20:44PM +0100, Rafael J. Wysocki wrote:
> [Cc: adding linux-scsi for the MPT changes, Ben for powerpc, Matthew for
> platform/x86 and Konrad for Xen]
>
> On Friday, December 06, 2013 02:21:50 AM Rafael J. Wysocki wrote:
>
> [...]
>
> >
> > OK
> >
> > To be a bit mor
On Fri, Jan 17, 2014 at 9:02 AM, Alexander Gordeev wrote:
> This series is against "next" branch in Bjorn's repo:
> git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
>
> Changes from v1 to v2:
> - added a regression fix "ahci: Fix broken fallback to single
> MSI mode" as patch 1/
On Sat, Jan 18, 2014 at 12:15 AM, Alexander Gordeev wrote:
> On Fri, Jan 17, 2014 at 02:00:32PM -0700, Bjorn Helgaas wrote:
>> > As the release is supposedly this weekend, do you prefer
>> > the patches to go to your tree or to individual trees after
>> > the releas
On Sat, Jan 18, 2014 at 09:59:40AM -0500, Tejun Heo wrote:
> On Sat, Jan 18, 2014 at 07:38:55AM -0700, Bjorn Helgaas wrote:
> > On Sat, Jan 18, 2014 at 12:15 AM, Alexander Gordeev
> > wrote:
> > > On Fri, Jan 17, 2014 at 02:00:32PM -0700, Bjorn Helgaas wrote:
&g
On Mon, Feb 24, 2014 at 09:02:00AM +0100, Alexander Gordeev wrote:
> Hello!
>
> This series is against James Bottomley's SCSI tree [1], but it needs
> commit f7fc32c ("PCI/MSI: Add pci_enable_msi_exact() and
> pci_enable_msix_exact()") from from Bjorn Helgaas's PCI tree [2]:
>
> 1. git://git.kern
On Wed, Apr 2, 2014 at 5:49 AM, Alexander Gordeev wrote:
> On Wed, Mar 12, 2014 at 10:04:40PM -0600, Bjorn Helgaas wrote:
>> Hi James,
>>
>> I think Alexander sent these to linux-scsi hoping that you would handle
>> them, but I know it's a hassle because they dep
[+cc Joerg, iommu list]
On Wed, Apr 9, 2014 at 6:19 PM, Davidlohr Bueso wrote:
> On Wed, 2014-04-09 at 16:50 -0700, James Bottomley wrote:
>> On Wed, 2014-04-09 at 16:40 -0700, Davidlohr Bueso wrote:
>> > On Wed, 2014-04-09 at 16:10 -0700, James Bottomley wrote:
>> > > On Wed, 2014-04-09 at 16:08
On Thu, Apr 10, 2014 at 2:46 AM, Woodhouse, David
wrote:
>> > > >> > > > > DMAR:[fault reason 02] Present bit in context entry is clear
>> > > >> > > > > dmar: DRHD: handling fault status reg 602
>> > > >> > > > > dmar: DMAR:[DMA Read] Request device [02:00.0] fault addr
>> > > >> > > > > 7f61e0
[subject changed]
On Thu, Apr 10, 2014 at 2:45 PM, wrote:
> On Wed, Apr 09, 2014 at 11:32:37PM -0700, Davidlohr Bueso wrote:
>> On Wed, 2014-04-09 at 22:03 -0600, Bjorn Helgaas wrote:
>> > [+cc Joerg, iommu list]
>> >
>> > On Wed, Apr 9, 2014 at 6:19 PM, D
On Mon, Apr 14, 2014 at 10:05:24AM +0200, Alexander Gordeev wrote:
> Hello,
>
> This series is against 3.15-rc1.
>
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> n
On Thu, Apr 24, 2014 at 11:51 AM, James Bottomley
wrote:
> On Thu, 2014-04-24 at 11:09 -0600, Bjorn Helgaas wrote:
>> On Mon, Apr 14, 2014 at 10:05:24AM +0200, Alexander Gordeev wrote:
>> > Hello,
>> >
>> > This series is against 3.15-rc1.
>> &g
On Tue, Nov 5, 2013 at 11:44 AM, Bjorn Helgaas wrote:
> On Tue, Nov 5, 2013 at 6:06 AM, Jiri Kosina wrote:
>> On Thu, 31 Oct 2013, Bjorn Helgaas wrote:
>>
>>> > Attached is dmesg output leading to timeouts (that are cured by my
>>> > original patch in t
rse affects from running the pci portion.
>
> Signed-off-by: Keith Busch
> Cc: Nagalakshmi Nandigama
> Cc: Sreekanth Reddy
> Cc: Bjorn Helgaas
> ---
> drivers/message/fusion/mptscsih.c |3 +++
> drivers/pci/pci-driver.c |2 --
> 2 files changed, 3 in
On Thu, Jul 10, 2014 at 12:53 PM, Keith Busch wrote:
> On Thu, 10 Jul 2014, Bjorn Helgaas wrote:
>>
>> [+cc LKML, Greg KH for driver core async shutdown question]
>> On Tue, Jun 24, 2014 at 10:48:57AM -0600, Keith Busch wrote:
>>>
>>> To provide context wh
[+cc Matthew]
On Sat, Jul 12, 2014 at 5:56 AM, Robin H. Johnson wrote:
> TL;DR LSI2208 card faults out and does not bring up drives in Linux. In BIOS
> works fine.
> Driver has no debug interfaces visible in code for early startup.
>
> Hardware: Supermicro SSG-6027R-E1R12T
> http://www.supermicr
On Tue, Jan 02, 2018 at 06:53:52PM +0100, Romain Perier wrote:
> The current PCI pool API are simple macro functions direct expanded to
> the appropriate dma pool functions. The prototypes are almost the same
> and semantically, they are very similar. I propose to use the DMA pool
> API directly an
On Tue, Jan 02, 2018 at 04:17:24PM -0600, Bjorn Helgaas wrote:
> On Tue, Jan 02, 2018 at 06:53:52PM +0100, Romain Perier wrote:
> > The current PCI pool API are simple macro functions direct expanded to
> > the appropriate dma pool functions. The prototypes are almost the same
>
On Sat, Aug 19, 2017 at 01:52:19PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in the type field of a device
> structure, which is const.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal
Applied to pci/misc for v4.14, thanks!
> ---
> drivers/pci/endpoint/pci-epf
[+cc LKML]
On Wed, Sep 26, 2018 at 09:52:34AM +0530, Suganath Prabu S wrote:
> * Driver uses "pci_device_is_present" to check whether
> If Hot unplugged:
> the outstanding IOs with 'DID_NO_CONNECT' before removing the drives
> attached to the HBA.
This sentence needs a verb.
> "DID_NO_CONNECT" s
[+cc LKML]
On Mon, Oct 01, 2018 at 12:57:01PM +0530, Suganath Prabu Subramani wrote:
> On Thu, Sep 27, 2018 at 2:39 AM Bjorn Helgaas wrote:
> > On Wed, Sep 26, 2018 at 09:52:36AM +0530, Suganath Prabu S wrote:
> > > The code for getting shost and IOC is redundant so
> >
On Mon, Oct 01, 2018 at 12:27:28PM +0530, Suganath Prabu Subramani wrote:
> On Fri, Sep 28, 2018 at 12:40 AM Lukas Wunner wrote:
> > On Thu, Sep 27, 2018 at 01:47:46PM -0500, Bjorn Helgaas wrote:
> > > I'm not sure how mpt3sas benefits from adding
> > > mpt3
On Mon, Oct 01, 2018 at 03:40:51PM -0500, Bjorn Helgaas wrote:
> I think the names "pci_device_is_present()" and
> "mpt3sas_base_pci_device_is_available()" contribute to the problem
> because they make promises that can't be kept -- all we can say is
> that
On Mon, Oct 08, 2018 at 12:14:40PM +0530, Suganath Prabu Subramani wrote:
> On Tue, Oct 2, 2018 at 7:34 PM Bjorn Helgaas wrote:
> > On Mon, Oct 01, 2018 at 03:40:51PM -0500, Bjorn Helgaas wrote:
> > > I think the names "pci_device_is_present()" and
> > >
On Sat, Oct 13, 2018 at 05:10:09PM +0200, Christoph Hellwig wrote:
> We plan to enable building the pcmcia core and drivers, and the
> non-prefixed PCMCIA name clashes with some arch headers.
In the followup PCMCIA patch, you capitalized "PCMCIA core".
, and a lot of code does
> not compile without PCI enabled. On other architectures with limited
> PCI support that wasn't as complicated I've left the selection as-is.
Thanks for doing this. It's a great cleanup. I know you have a few
things you're cleaning up, but add my:
Acked-by: Bjorn Helgaas
when you do that.
mpt3sas_wait_for_ioc() to use the do
loop instead of the while. The idea is that each individual patch is
simpler and more obvious because it only contains a single logical
change.
Reviewed-by: Bjorn Helgaas
On Tue, Oct 23, 2018 at 03:51:19PM +0530, Suganath Prabu wrote:
> This is to fix Sync cache and start stop command
> failures with DID_NO_CONNECT during driver unload.
>
> 1) Release drives first from SML, then remove internally
> in driver.
> 2) And allow sync cache and Start stop commands to fi
On Tue, Oct 23, 2018 at 03:51:20PM +0530, Suganath Prabu wrote:
> * If EEDPTagMode field in manufacturing page11 is set,
> unset it. This is needed to fix a hardware bug
> in SAS3/SAS2 cards, So, skipping EEDPTagMode changes
> in Manufacturing page11 for SAS35 controllers.
>
> * Fix driver modifyi
Suganath Prabu wrote:
> V7 Change Set:
> Split some patches into multiple small patches
> as suggested by Bjorn Helgaas
>
> v6 Change Set:
> Incorporated changes as suggested by Andy.
> In Patch 1 converted while loop to do while in
> function mpt3sas_wait_for_ioc_to_opera
gt; not compile without PCI enabled. On other architectures with limited
> PCI support that wasn't as complicated I've left the selection as-is.
>
> Signed-off-by: Christoph Hellwig
> Acked-by: Max Filippov
> Acked-by: Thomas Gleixner
> Acked-by: Bjorn Helgaas
Sounds li
On Fri, Sep 7, 2012 at 9:33 AM, Stephen Hemminger wrote:
> This is a trivial patch to make PCI error handler function
> tables const. Split into pieces so that core changes are first.
I put all four of these on this branch:
http://git.kernel.org/?p=linux/kernel/git/helgaas/pci.git;a=shortlog;h=r
On Fri, Sep 7, 2012 at 4:42 PM, Bjorn Helgaas wrote:
> On Fri, Sep 7, 2012 at 9:33 AM, Stephen Hemminger
> wrote:
>> This is a trivial patch to make PCI error handler function
>> tables const. Split into pieces so that core changes are first.
>
> I put all four of these
On Sat, Sep 15, 2012 at 4:22 AM, Yijing Wang wrote:
> Hi all,
>I encountered a very strange problem when I hot plug a fiber channel
> card(using qla2xxx driver).
> I did the hotplug in arch x86 machine, using pciehp driver for hotplug, this
> platform supports pci hot-plug triggering from bo
On Mon, Sep 17, 2012 at 6:06 AM, Yijing Wang wrote:
> On 2012/9/16 11:30, Bjorn Helgaas wrote:
>> On Sat, Sep 15, 2012 at 4:22 AM, Yijing Wang wrote:
>>> Hi all,
>>>I encountered a very strange problem when I hot plug a fiber channel
>>> card(using qla2x
On Tue, Sep 18, 2012 at 7:50 PM, Yijing Wang wrote:
> On 2012/9/19 1:54, Bjorn Helgaas wrote:
>> On Mon, Sep 17, 2012 at 6:06 AM, Yijing Wang wrote:
>>> On 2012/9/16 11:30, Bjorn Helgaas wrote:
>>>> On Sat, Sep 15, 2012 at 4:22 AM, Yijing Wang wrote:
>>>&
On Thu, Sep 20, 2012 at 6:26 AM, Yijing Wang wrote:
> On 2012/9/20 9:47, Yijing Wang wrote:
We compared the two situations after BIOS initialization, and found Max
Payload Size in DEVCTRL is 256B
if FC card had been installed, if the slot is empty, Max Payload Size is
128B. W
1:34: error: lvalue required as left operand of
> assignment
Here's what I think we should do about the GDT issue. I'll send this
via the usual channels.
commit c6156dd31228e608e0a820d2eed7403fd1fd620b
Author: Bjorn Helgaas
Date: Tue Nov 6 14:19:03 2012 -0700
[SCSI] gdth: R
doubt the delay is needed, but I left it since it seems innocuous.
Signed-off-by: Bjorn Helgaas
---
drivers/scsi/gdth.c | 10 ++
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index 5d72274..3efe4ef 100644
--- a/drivers/scsi/gd
[+cc Guenter, linux-scsi]
On Tue, Nov 11, 2014 at 4:33 PM, Barto wrote:
> Hello everyone,
>
> I notice a bug since kernel 3.17 ( and also with 3.18 branch ), a random
> hang at boot on some PC configurations, I did a "git bisect" and I found
> that the culprit is :
>
> [045065d8a300a37218c548e9a
On Tue, Jun 07, 2016 at 09:44:00AM +0200, Johannes Thumshirn wrote:
> The first patch in this series introduces the following 4 helper functions to
> the PCI core:
>
> * pci_request_mem_regions()
> * pci_request_io_regions()
> * pci_release_mem_regions()
> * pci_release_io_regions()
>
> which enc
On Thu, Apr 13, 2017 at 03:22:06PM -0600, Logan Gunthorpe wrote:
>
>
> On 12/04/17 03:55 PM, Benjamin Herrenschmidt wrote:
> > Look at pcibios_resource_to_bus() and pcibios_bus_to_resource(). They
> > will perform the conversion between the struct resource content (CPU
> > physical address) and t
On Fri, Apr 14, 2017 at 11:30:14AM -0600, Logan Gunthorpe wrote:
> On 14/04/17 05:37 AM, Benjamin Herrenschmidt wrote:
> > I object to designing a subsystem that by design cannot work on whole
> > categories of architectures out there.
>
> Hardly. That's extreme. We'd design a subsystem that works
[-cc Gabriele (invalid email address)]
[+cc Don, esc.storagedev, linux-scsi since hpsa is involved]
Background for newcomers:
Ryan reported a panic on shutdown/reboot [1] on DL360 Gen9. I think
the problem is that the shutdown path clears PCI_COMMAND_MASTER on
the Root Port leading to an h
On Thu, May 24, 2018 at 07:43:05AM -0400, Sinan Kaya wrote:
> On 5/23/2018 6:57 PM, Sinan Kaya wrote:
> >> The crash seems to indicate that the hpsa device attempted a DMA after
> >> we cleared the Root Port's PCI_COMMAND_MASTER, which means
> >> hpsa_shutdown() didn't stop DMA from the device (it
On Wed, May 23, 2018 at 06:57:18PM -0400, Sinan Kaya wrote:
> On 5/23/2018 5:32 PM, Bjorn Helgaas wrote:
> >
> > The crash seems to indicate that the hpsa device attempted a DMA after
> > we cleared the Root Port's PCI_COMMAND_MASTER, which means
> > hpsa_shu
1 - 100 of 110 matches
Mail list logo
