csi/aha1542.c:379:11: error: 'sg_count' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
The only user of these is doing the same check that the assigment
has, so it is actually guaranteed to work. Adding an "else" clause
with a fake initialization sh
register_device_handler'
As a workaround, this adds an extra dependency on CONFIG_SCSI,
so Kconfig can figure out whether built-in is allowed or not.
Signed-off-by: Arnd Bergmann
Fixes: 086b91d052eb ("scsi_dh: integrate into the core SCSI code")
---
drivers/scsi/device_handler/Kconfig | 8
7;value' was declared here
uint32_t value;
^
Unfortunately, I don't see any helpful way to add proper error handling
for this case, and the failure scenario for rd_reg seems rather obscure,
so this bails out and makes the rd_reg accessor set the result to 0x
s
an #ifndef MODULE around the definition to shut up
the warning and clarify for the reader when it is used or not.
Signed-off-by: Arnd Bergmann
---
drivers/scsi/arm/fas216.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas216.c
index de
Here are a bunch of fixes for harmless bugs I found during ARM
randconfig testing. It would be nice to get them mered in 4.6,
but there is no need to have them in 4.5 as no incorrect behavior
results from the current code, and the warnings are all hard
to trigger.
Arnd Bergmann (7):
scsi
This marks the function as __maybe_unused to shut up the
warning and silently drop the function in the object code
when there is no caller.
Signed-off-by: Arnd Bergmann
---
drivers/scsi/arm/acornscsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/arm/aco
:1773:29: warning: 'fdomain_pci_tbl' defined but not used
[-Wunused-variable]
To avoid the warning, this adds another #ifdef around the table
definition.
Signed-off-by: Arnd Bergmann
---
drivers/scsi/fdomain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dr
em
for the different purposes, so we can assign a pointer directly.
Signed-off-by: Arnd Bergmann
---
This has been around for a long while, but did not trigger in
my randconfig testing until now, don't know why.
diff --git a/drivers/target/target_core_user.c
b/drivers/target/target_co
On Wednesday 03 February 2016 11:28:26 Joao Pinto wrote:
>
> Signed-off-by: Joao Pinto
This needs a changelog comment, like every patch.
> @@ -0,0 +1,16 @@
> +* Universal Flash Storage (UFS) DesignWare Host Controller
> +
> +DWC_UFSHC nodes are defined to describe on-chip UFS host controllers.
On Wednesday 03 February 2016 15:01:34 Joao Pinto wrote:
>
> Hi Arnd,
>
> On 2/3/2016 12:54 PM, Arnd Bergmann wrote:
> > On Wednesday 03 February 2016 11:28:26 Joao Pinto wrote:
> >>
> >> Signed-off-by: Joao Pinto
> >
> > This needs a change
On Wednesday 10 February 2016 16:06:13 Joao Pinto wrote:
> This patch has the goal to add support for DesignWare UFS Controller
> specific operations and to add specific platform and pci drivers.
>
> Signed-off-by: Joao Pinto
> Documentation/devicetree/bindings/ufs/ufs-dwc.txt | 17 +
> MAINTAI
On Thursday 18 February 2016 17:20:27 Joao Pinto wrote:
>
> Documentation/devicetree/bindings/ufs/ufs-dwc.txt | 19 +
> MAINTAINERS | 6 +
> drivers/scsi/ufs/Kconfig | 51 +++
> drivers/scsi/ufs/Makefile |
On Saturday 26 September 2015 11:40:00 Viresh Kumar wrote:
> On 25 September 2015 at 15:19, Rafael J. Wysocki wrote:
> > So if you allow something like debugfs to update your structure, how
> > do you make sure there is the proper locking?
>
> Not really sure at all.. Isn't there some debugfs loc
On Sunday 27 September 2015 16:10:48 Rafael J. Wysocki wrote:
> On Saturday, September 26, 2015 09:33:56 PM Arnd Bergmann wrote:
> > On Saturday 26 September 2015 11:40:00 Viresh Kumar wrote:
> > > On 25 September 2015 at 15:19, Rafael J. Wysocki
> > > wrote:
> &
On Thursday 01 October 2015 18:46:34 kbuild test robot wrote:
> [auto build test results on v4.3-rc3 -- if it's inappropriate base, please
> ignore]
>
> config: x86_64-allmodconfig (attached as .config)
> reproduce:
> git checkout 6e153e3bf7c68b019e987c5a0ffadebd9c7d4fbb
> # save
On Thursday 01 October 2015 13:39:28 Alim Akhtar wrote:
> From: Seungwon Jeon
>
> This adds Exynos Universal Flash Storage (UFS) Host Controller DT bindings.
>
> Signed-off-by: Seungwon Jeon
> Signed-off-by: Alim Akhtar
> ---
> .../devicetree/bindings/ufs/ufs-exynos.txt | 93
>
On Thursday 01 October 2015 13:39:29 Alim Akhtar wrote:
> +static int exynos7_ufs_drv_init(struct device *dev, struct exynos_ufs *ufs)
> +{
> + int ret;
> + const char *const clks[] = {
> + "mout_sclk_combo_phy_embedded",
> + "top_sclk_phy_fsys1_26m",
> + };
> +
into dpti_i2o.h.
>
> CC: Arnd Bergmann
> CC: Greg Kroah-Hartman
> Signed-off-by: Gabriel Laskar
>
Acked-by: Arnd Bergmann
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Monday 05 October 2015 13:44:29 Alim Akhtar wrote:
> CCing Rob Herring,
>
> Hi Arnd,
>
> On 10/01/2015 04:59 PM, Arnd Bergmann wrote:
> > On Thursday 01 October 2015 18:46:34 kbuild test robot wrote:
> >> [auto build test results on v4.3-rc3 -- if it's inap
On Monday 05 October 2015 09:11:33 Rob Herring wrote:
> On Mon, Oct 5, 2015 at 4:06 AM, Arnd Bergmann wrote:
> > On Monday 05 October 2015 13:44:29 Alim Akhtar wrote:
> >>
> >> On 10/01/2015 04:59 PM, Arnd Bergmann wrote:
> >> > On Thursday 01 Octobe
ull review for possible further endianess bugs in the same driver.
Signed-off-by: Arnd Bergmann
Fixes: 811ddc057aac ("advansys: use DMA-API for mapping sense buffer")
---
Using wi...@linux.intel.com, as the address listed in MAINTAINERS
failed:
Failed to transport message. Message s
On Wednesday 07 October 2015 10:54:03 Yaniv Gardi wrote:
>
> +/* IOCTL opcode for command - ufs set device read only */
> +#define UFS_IOCTL_BLKROSET BLKROSET
> +
What is this for? Can't you just use the normal BLKROSET definition in user
space?
> +
> + ioctl_data = kzalloc(sizeof(s
On Wednesday 07 October 2015 12:27:54 yga...@codeaurora.org wrote:
>
> >> +
> >> +/*
> >> + * IOCTL opcode for ufs queries has the following opcode after
> >> + * SCSI_IOCTL_GET_PCI
> >> + */
> >> +#define UFS_IOCTL_QUERY 0x5388
> >
> > Use _IOWR() to define that number with
e.c:2134:1: warning: the frame size of 1128 bytes
is larger than 1024 bytes [-Wframe-larger-than=]
In order to avoid a possible kernel stack overflow and to get rid
of the warning, this changes the function to use a dynamic allocation
of the structure using kzalloc.
Signed-off-by: Arnd Bergm
On Thursday 08 October 2015 14:09:24 Yaniv Gardi wrote:
> This patch exposes the ioctl interface for UFS driver via SCSI device
> ioctl interface. As of now UFS driver would provide the ioctl for query
> interface to connected UFS device.
>
> Signed-off-by: Dolev Raviv
> Signed-off-by: Noa Rubens
On Thursday 08 October 2015 15:17:49 John Garry wrote:
> Hi,
>
> For a new driver I am preparing for a SAS controller, I need defintions
> for the SSP command and TMF iu structures. Currently these are defined
> in the following:
> ssp_command_iu, ssp_task_iu: drivers/scsi/aic94xx_sas.h
> ssp_cm
On Sunday 11 October 2015 14:22:12 Yaniv Gardi wrote:
> * @cookie: cookie data
> @@ -5106,6 +5308,10 @@ static struct scsi_host_template
> ufshcd_driver_template = {
> .eh_device_reset_handler = ufshcd_eh_device_reset_handler,
> .eh_host_reset_handler = ufshcd_eh_host_reset_han
On Sunday 11 October 2015 11:02:34 yga...@codeaurora.org wrote:
> >
> > no need for the #ifdef here.
>
> in include\scsi\scsi_host.h
> the hook - compat_ioctl is defined inside #ifdef CONFIG_COMPAT
>
> #ifdef CONFIG_COMPAT
> int (* compat_ioctl)(struct scsi_device *dev, int cmd, void __us
o build on platforms that have neither
VIRT_TO_BUS nor ISA_DMA_API but that do have ISA.
This adds the missing dependency.
Signed-off-by: Arnd Bergmann
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index d2f480b04a52..d4aa6a1a806c 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kcon
On Monday 12 October 2015 23:20:16 John Garry wrote:
> +
> + shost = scsi_host_alloc(&hisi_sas_sht, sizeof(void *));
> + if (!shost)
> + return -ENOMEM;
> +
> + hisi_hba = hisi_sas_hba_alloc(pdev, shost, np);
> + if (!hisi_hba) {
> + rc = -ENOMEM;
On Monday 12 October 2015 23:20:19 John Garry wrote:
> +int hisi_sas_ioremap(struct hisi_hba *hisi_hba)
> +{
> + struct platform_device *pdev = hisi_hba->pdev;
> + struct device *dev = &pdev->dev;
> + struct resource *res;
> +
> + res = platform_get_resource(pdev, IORESOURCE
On Monday 12 October 2015 23:20:17 John Garry wrote:
> + interrupt_count = of_property_count_u32_elems(np, "interrupts");
> + if (interrupt_count < 0)
> + goto err_out;
> +
> + if (of_property_read_u32(np, "#interrupt-cells", &interrupt_cells))
> + goto
n NO_ISA_DMA mode.
Ok
> That means the narrowboard check should be gated by
> CONFIG_ISA_DMA_API ... do we also have to gate free_dma as well?
Yes. A few more as well, as we also don't want to do inb/outb
instructions to a DMA controller that is not there.
I've compile-teste
On Monday 12 October 2015 23:20:24 John Garry wrote:
> @@ -387,6 +392,21 @@ static int hisi_sas_probe(struct platform_device *pdev)
> }
>
> hisi_sas_init_add(hisi_hba);
> +
> + rc = hw_init_v1_hw(hisi_hba);
> + if (rc)
> + goto err_out_ha;
> +
> + r
On Tuesday 13 October 2015 16:49:39 Alim Akhtar wrote:
> >> diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h
> >> new file mode 100644
> >> index 000..58aa714
> >> --- /dev/null
> >> +++ b/drivers/scsi/ufs/ufs-exynos.h
> >> @@ -0,0 +1,463 @@
> >> +/*
> >> + * UFS Host
On Tuesday 13 October 2015 17:06:18 Alim Akhtar wrote:
> > Better rename them to "core", "ref" and "iface", no point requiring to
> > spell out "clk" here.
> >
> >> +ufs,pwr-attr-mode = "FAST";
> >
> > A string is rather unusual here, what are the allowed values? Could you
> > use a boo
On Tuesday 13 October 2015 10:16:55 John Garry wrote:
>
> >
> >> + sha = SHOST_TO_SAS_HA(shost) = &hisi_hba->sha;
> >> + platform_set_drvdata(pdev, sha);
> >> +
> >> + phy_nr = port_nr = HISI_SAS_MAX_PHYS;
> >> +
> >> + arr_phy = devm_kcalloc(dev, phy_nr, sizeof(void *), GF
On Tuesday 13 October 2015 17:47:02 zhangfei wrote:
> On 10/12/2015 11:21 PM, Arnd Bergmann wrote:
> > On Monday 12 October 2015 23:20:19 John Garry wrote:
> >> +int hisi_sas_ioremap(struct hisi_hba *hisi_hba)
> >> +{
> >> + struct platform_device *pdev =
On Tuesday 13 October 2015 13:44:26 John Garry wrote:
> Hello,
>
> Just to be clear, are you saying that you would prefer hisi_sas_probe()
> and struct hisi_sas_driver to be relocated to hisi_sas_v1_hw.c?
Correct.
> I wanted to keep hisi_sas_v1_hw.c containing only code which accesses HW.
>
>
On Wednesday 14 October 2015 16:05:21 John Garry wrote:
>
> OK, we can look at adding the ability to read the SAS HBA address from a
> FW image or EFI variables.
>
The easiest way is usually to have a DT property that gets updated
by the firmware.
Arnd
--
To unsubscribe from this list:
On Thursday 15 October 2015 11:36:53 zhangfei wrote:
> On 10/14/2015 11:18 PM, Arnd Bergmann wrote:
> > On Wednesday 14 October 2015 16:05:21 John Garry wrote:
> >>
> >> OK, we can look at adding the ability to read the SAS HBA address from a
> >> FW imag
On Thursday 15 October 2015 14:09:31 Hannes Reinecke wrote:
> On 10/15/2015 02:06 PM, Hannes Reinecke wrote:
> > On 10/12/2015 05:10 PM, Arnd Bergmann wrote:
> >> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> >> index d2f480b04a52..d4aa6a1a806c 100644
>
On Friday 16 October 2015 13:49:06 Hannes Reinecke wrote:
> On 10/15/2015 05:04 PM, Arnd Bergmann wrote:
> > On Thursday 15 October 2015 14:09:31 Hannes Reinecke wrote:
> >> On 10/15/2015 02:06 PM, Hannes Reinecke wrote:
> >>> On 10/12/2015 05:10 PM, Arnd Bergm
o build on platforms that have neither
VIRT_TO_BUS nor ISA_DMA_API but that do have ISA.
This adds a dependency to only build the driver on ISA based machines
if they also support ISA_DMA_API, or if they EISA or PCI are also
enabled.
Signed-off-by: Arnd Bergmann
diff --git a/drivers/scsi/Kconfi
On Monday 12 October 2015 23:20:25 John Garry wrote:
> @@ -804,6 +818,16 @@ static irqreturn_t int_phyup_v1_hw(int irq_no, void *p)
> phy->identify.target_port_protocols =
> SAS_PROTOCOL_SMP;
>
> + wq = kmalloc(sizeof(*wq), GFP_ATOMIC);
> + if (
On Friday 16 October 2015 14:29:55 John Garry wrote:
>
> It could be considered.
>
> A potential issue I see is with hisi_sas_control_phy() for
> PHY_FUNC_HARD_RESET: this allocates a hisi_sas_wq struct and processes
> the reset in the queue work. When we re-enable the phy for the reset,
> the
On Friday 16 October 2015 06:53:44 James Bottomley wrote:
> >
> > Signed-off-by: Arnd Bergmann
> >
> > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> > index d2f480b04a52..1d8b8257773d 100644
> > --- a/drivers/scsi/Kconfig
> > +++ b
On Monday 19 October 2015 15:11:47 John Garry wrote:
> On 16/10/2015 14:36, Arnd Bergmann wrote:
> > On Friday 16 October 2015 14:29:55 John Garry wrote:
> >>
> >> It could be considered.
> >>
> >> A potential issue I see is with hisi_sas_control_phy()
On Monday 19 October 2015 15:55:47 John Garry wrote:
> > Do you mean these members?
> >
> >> + wq->event = PHYUP;
> >> + wq->hisi_hba = hisi_hba;
> >> + wq->phy_no = phy_no;
> >
> Yes, these are the members I was referring to. However there is also an
> element "data" in hisi_sas
On Thursday 22 October 2015 07:02:14 subha...@codeaurora.org wrote:
> >
> > Required properties:
> > -- compatible: compatible list, contains "jedec,ufs-1.1"
> > +- compatible: compatible list, contains "jedec,ufs-1.1" or
> > + "qcom,msm8994-ufshc" or "qcom,msm8996-
On Friday 30 October 2015 12:58:33 Hannes Reinecke wrote:
> > @@ -1076,7 +1069,7 @@ static int stex_ss_handshake(struct st_hba *hba)
> > h->req_cnt = cpu_to_le16(hba->rq_count+1);
> > h->status_sz = cpu_to_le16(sizeof(struct status_msg));
> > h->status_cnt = cpu_to_le16(hba->sts_c
On Monday 26 October 2015 22:14:58 John Garry wrote:
> + /*
> + * DMA-map SMP request, response buffers
> + */
> + /* req */
> + sg_req = &task->smp_task.smp_req;
> + elem = dma_map_sg(dev, sg_req, 1, DMA_TO_DEVICE);
> + if (!elem)
> + return
On Monday 26 October 2015 22:14:56 John Garry wrote:
> Add abnormal irq handler. This handler is concerned with
> phy down event.
> Also add port formed and port deformed handlers.
>
> Signed-off-by: John Garry
I noticed a couple more coding style issues in this patch than elsewhere, so
here
ut not
> merged or ack-ed by someone from linux-scsi. Until today, I thought
> using "RESEND" would be impolite, but now I will resend the other ones
> as well. Arnd Bergmann is leading this effort and may have more
> insightful comments.
>
I provided a "Reviewed-by
On Monday 02 November 2015 17:03:58 John Garry wrote:
> >
> > Can do. Actually sg_req seems only ever has one element:
> > expander.c, smp_execute_task()
> > sg_init_one(&task->smp_task.smp_req, req, req_size);
> >
> >
> I tried replacing with dma_map_single, but I feel the code is not as
> clean
On Tuesday 03 November 2015 11:42:30 John Garry wrote:
> >
> There seems to be some misunderstanding. Are you suggesting I change
> sas_smp_task?
> ./include/scsi/libsas.h
> struct sas_smp_task {
> struct scatterlist smp_req;
> struct scatterlist smp_resp;
> };
>
Ah, no. I had no
conds, which returns a 64-bit seconds value.
>
> Suggested-by: Arnd Bergmann
> Signed-off-by: Tina Ruchandani
>
For reference
Reviewed-by: Arnd Bergmann
I'm putting this into my y2038 tree so I don't forget it, but I'd hope
that James can apply it into scsi and I&
year 2038.
> This patch uses ktime_get_real_seconds() instead since it provides a
> 64-bit seconds value, which is 2038 safe.
>
> Signed-off-by: Tina Ruchandani
> ---
Reviewed-by: Arnd Bergmann
and picked up into my y2038 tree temporarily until it shows up in scsi.
--
To unsubscribe from
d.
> The patch uses ktime_get_real_seconds() which returns a 64-bit seconds value.
>
> Signed-off-by: Tina Ruchandani
>
Reviewed-by: Arnd Bergmann
and picked up into my y2038 tree for now.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body
On Monday 09 November 2015 08:09:39 Hannes Reinecke wrote:
> On 11/09/2015 02:57 AM, Sinan Kaya wrote:
> > Current code gives up when 32 bit DMA is not supported.
> > This problem has been observed on systems without any
> > memory below 4 gig.
> >
> > This patch tests 64 bit support before bailin
On Monday 09 November 2015 09:07:36 Sinan Kaya wrote:
>
> On 11/9/2015 3:59 AM, Arnd Bergmann wrote:
> > On Monday 09 November 2015 08:09:39 Hannes Reinecke wrote:
> >> On 11/09/2015 02:57 AM, Sinan Kaya wrote:
> >>> Current code gives up when 32 bit DMA is not
On Tuesday 10 November 2015 00:32:16 John Garry wrote:
> }
>
> +static void hisi_sas_init_add(struct hisi_hba *hisi_hba)
> +{
> + int i;
> +
> + for (i = 0; i < hisi_hba->n_phy; i++)
> + memcpy(&hisi_hba->phy[i].dev_sas_addr,
> + hisi_hba->sas_addr,
ibsas framework within the SCSI framework.
>
> The v1 HW supports SSP and SMP, but not STP/SATA.
I have one remaining comment that I now posted, all my previous comments
have been addressed as far as I can tell.
Very nice work!
Reviewed-by: Arnd Bergmann
Note that my comments were mostl
INER: Please request alternate change if preferred.
>
> Signed-off-by: Alison Schofield
>
Reviewed-by: Arnd Bergmann
just the last sentence of the changelog should probably go below the
"---" line as it is irrelevant in the git history if the patch gets
applied. James can pr
On Monday 09 November 2015 18:22:22 Sinan Kaya wrote:
> On 11/9/2015 9:33 AM, Arnd Bergmann wrote:
> > On Monday 09 November 2015 09:07:36 Sinan Kaya wrote:
> >> On 11/9/2015 3:59 AM, Arnd Bergmann wrote:
>
> ioc->dma_mask is 0 and the driver is trying to use 3
On Monday 09 November 2015 22:53:17 Timur Tabi wrote:
> Sinan Kaya wrote:
> >
> > The code says it is using these macros for small integers only which
> > can't overflow. I was trying to get rid of compiler warning and it seems
> > to have disappeared.
>
> I would double-check the assembly code, i
On Tuesday 10 November 2015 11:06:40 Sinan Kaya wrote:
> On 11/10/2015 3:38 AM, Arnd Bergmann wrote:
> > No, as Timur found, the driver is correct and it intentionally
> > sets the 32-bit mask, and that is guaranteed to work on all sane
> > hardware. Don't change th
On Tuesday 10 November 2015 11:00:59 Timur Tabi wrote:
> On 11/10/2015 10:47 AM, Arnd Bergmann wrote:
> > What BenH was worried about here is that the driver sets different masks
> > for streaming and coherent mappings, which is indeed a worry that
> > could hit us on ARM a
On Tuesday 10 November 2015 12:19:33 Sinan Kaya wrote:
> On 11/10/2015 11:47 AM, Arnd Bergmann wrote:
> > On Tuesday 10 November 2015 11:06:40 Sinan Kaya wrote:
> >> On 11/10/2015 3:38 AM, Arnd Bergmann wrote:
> >> > No, as Timur found, the driver is correct and i
On Tuesday 10 November 2015 15:03:59 Timur Tabi wrote:
> On 11/10/2015 01:13 PM, Arnd Bergmann wrote:
> > If the mask is 64-bit by default on ARM64, that is a bug that we need
> > to fix urgently. Can you verify this?
>
> I think the mask is 0 by default, because there&#x
On Tuesday 10 November 2015 15:58:19 Sinan Kaya wrote:
>
> On 11/10/2015 2:56 PM, Arnd Bergmann wrote:
> >> The ACPI IORT table declares whether you enable IOMMU for a particular
> >> >device or not. The placement of IOMMU HW is system specific. The IORT
> >> &
On Tuesday 10 November 2015 15:59:18 Timur Tabi wrote:
> On 11/10/2015 03:54 PM, Arnd Bergmann wrote:
>
> >> In our drivers for 32-bit devices, we have to explicitly set the DMA
> >> mask to 32-bits in order to get any DMA working.
> >
> > Do you
ull review for possible further endianess bugs in the same driver.
Signed-off-by: Arnd Bergmann
Fixes: 811ddc057aac ("advansys: use DMA-API for mapping sense buffer")
Cc: sta...@vger.kernel.org # v4.2+
---
Using wi...@linux.intel.com, as the address listed in MAINTAINERS
failed:
Failed to t
On Monday 09 November 2015 10:56:22 Alim Akhtar wrote:
> +static int ufshcd_hba_enable(struct ufs_hba *hba)
> +{
> + int ret;
> +
> + if (hba->quirks & UFSHCI_QUIRK_BROKEN_HCE) {
> + ufshcd_set_link_off(hba);
> + ufshcd_vops_hce_enable_notify(hba, PRE_CHANGE)
On Monday 09 November 2015 10:56:27 Alim Akhtar wrote:
> From: Seungwon Jeon
>
> This patch introduces Exynos UFS host controller driver,
> which mainly handles vendor-specific operations including
> link startup, power mode change and hibernation/unhibernation.
>
> Signed-off-by: Seungwon Jeon
o build on platforms that have neither
VIRT_TO_BUS nor ISA_DMA_API but that do have ISA.
This adds the missing dependency.
Signed-off-by: Arnd Bergmann
---
This is identical to v1 of the patch. We had gone through several iterations
of this in October before concluding that everything else was more pro
built-in:
drivers/scsi/initio.c:131:29: warning: 'i91u_pci_devices' defined but not used
[-Wunused-variable]
This removes the extraneous table and the warning.
Signed-off-by: Arnd Bergmann
Fixes: 72d39fea901 ("[SCSI] initio: Convert into a real Linux driver and update
to modern sty
t.text+0x8838): undefined reference to `sas_attach_transport'
(.init.text+0x8868): undefined reference to `sas_release_transport
This adds 'select SCSI_SAS_ATTR' in the Kconfig entry, just like we do
for all other drivers using those functions.
Signed-off-by: Arnd Bergmann
Fixe
f distinct pointer
types lacks a cast
This changes the code to use sector_div instead, which always
produces optimal code.
Signed-off-by: Arnd Bergmann
---
Found on the ARM randconfig build today, after I merged Nico's patches
for linux-next
diff --git a/drivers/scsi/scsi_debug.c
native, but
> if we do introduce a new structure & ioctl with u64 timestamps, this
> would change accordingly.
>
> Signed-off-by: Alison Schofield
Reviewed-by: Arnd Bergmann
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Saturday 09 November 2013, Loc Ho wrote:
> Documentation: Add documentation for APM X-Gene SATA DTS binding
>
> Signed-off-by: Loc Ho
> Signed-off-by: Tuan Phan
> Signed-off-by: Suman Tripathi
> ---
> .../devicetree/bindings/ata/apm-xgene.txt | 84
>
Please
On Saturday 09 November 2013, Loc Ho wrote:
> +
> +#undef XGENE_DBG_CSR /* Enable CSR read/write dumping */
> +#ifdef XGENE_DBG_CSR
> +#define XGENE_CSRDBG(fmt, args...) \
> + printk(KERN_INFO "XGENESATA: " fmt "\n", ## args);
> +#else
> +#define XGENE_CSRDBG(fmt, args...)
> +#endif
On Sunday 10 November 2013, Olof Johansson wrote:
>
> > diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
> > index 46518c6..022f9d1 100644
> > --- a/drivers/ata/Makefile
> > +++ b/drivers/ata/Makefile
> > @@ -11,6 +11,8 @@ obj-$(CONFIG_SATA_SIL24) += sata_sil24.o
> > obj-$(CONFIG_SATA
On Monday 11 November 2013, Loc Ho wrote:
> Hi Arnd,
>
> >> ---
> >> .../devicetree/bindings/ata/apm-xgene.txt | 84
> >>
> >
> > Please Cc the devicetree-discuss mailing list for the binding submission.
> [Loc Ho]
> I did cc on the first version. But this email
>
On Tuesday 12 November 2013, Loc Ho wrote:
> Hi Arnd/Olof,
>
> I looked over the phy code for USB and NET. There isn't such PHY
> infrastructure for SATA from what I can tell. It seems like I will
> need to put this all together. I am thinking about porting the USB
> version over (with changes for
neric framework posted by Kishon Vijay Abrahm.
>
> Signed-off-by: Loc Ho
> Signed-off-by: Tuan Phan
> Signed-off-by: Suman Tripathi
> Reviewed-by: Arnd Bergmann
> Reviewed-by: Olof Johansson
Please remove the "Reviewed-by" tags and only add them back after you get
a r
On Thursday 14 November 2013, Loc Ho wrote:
> +- id : PHY ID (0 = first, 1 = second, 2 = third)
> +- #phy-cells : Shall be 0
Hmm, it seems like this would make more sense if you have #phy-cells=<1>
and have the PHY ID in user node as the argument.
> +- CTLE0
On Thursday 14 November 2013, Loc Ho wrote:
> +
> +/* SATA port 4 - 5 force power down VCO */
> +static void xgene_phy_sata45_macro_pdwn_force_vco(struct xgene_ahci_phy_ctx
> + *ctx)
> +{
> + sds_pcie_toggle1to0(ctx->pcie_base, KC_CLKMACRO_CMU_RE
On Friday 15 November 2013, Arnd Bergmann wrote:
> On Thursday 14 November 2013, Loc Ho wrote:
> > +- id : PHY ID (0 = first, 1 = second, 2 = third)
> > +- #phy-cells : Shall be 0
>
> Hmm, it seems like this would make more sense if you have #phy
On Thursday 14 November 2013, Loc Ho wrote:
> +Required properties:
> +- compatible : Shall be "apm,xgene-ahci"
> +- reg : First memory resource shall be the AHCI memory
> + resource.
> + Second memory resource shall be the
On Thursday 14 November 2013, Loc Ho wrote:
>
> +config SATA_XGENE
> + tristate "APM X-Gene 6.0Gbps SATA host controller support"
> + depends on SATA_AHCI_PLATFORM
> + default y if ARM64
> + select SATA_XGENE_PHY
I don't think the "default y" is appropriate here, since there are
On Friday 15 November 2013, Loc Ho wrote:
> >> +- CTLE0: PHY override parameters for channel 0
> >> register REG1
> >> + field CTLE_EQ. First value for Gen1, second value
> >> + for Gen2, and third value for Gen3. Default is
On Friday 15 November 2013, Loc Ho wrote:
> It may be possible from ACPI point of view (hasn't tried yet). But for
> DTS, there is no such firmware.
Why not? Doesn't any boot loader have to initialize the hardware in order
to load a kernel from disk?
> I will make the entry more friendly
> for DT
On Friday 15 November 2013, Loc Ho wrote:
> Hi,
>
> >> It may be possible from ACPI point of view (hasn't tried yet). But for
> >> DTS, there is no such firmware.
> >
> > Why not? Doesn't any boot loader have to initialize the hardware in order
> > to load a kernel from disk?
> [Loc Ho]
> Not nece
On Wednesday 20 November 2013 11:37:05 Mark Rutland wrote:
> > +static void phy_rd(void *addr, u32 *val)
> > +{
> > + *val = readl(addr);
> > +#if defined(XGENE_DBG1_CSR)
> > + pr_debug("SATAPHY CSR RD: 0x%p value: 0x%08x\n", addr, *val);
>
> Can you not use dev_dbg here as you do else
On Wednesday 20 November 2013, Tejun Heo wrote:
> On Tue, Nov 19, 2013 at 04:53:16PM -0700, Loc Ho wrote:
> > This patch adds support for APM X-Gene SoC 6.0Gbps SATA PHY. This is the
> > physical layer interface for the corresponding SATA host controller. This
> > driver uses the new PHY generic fr
On Wednesday 20 November 2013, Tejun Heo wrote:
> On Wed, Nov 20, 2013 at 10:41 AM, Arnd Bergmann wrote:
> > It needs to be in drivers/phy, which is currently being prepared for
> > the next merge window and which contains the generic interface used
> > in this driver.
>
On Wednesday 20 November 2013, Sergei Shtylyov wrote:
> > --- a/arch/arm64/boot/dts/apm-storm.dtsi
> > +++ b/arch/arm64/boot/dts/apm-storm.dtsi
> > @@ -193,5 +193,33 @@
> > reg = <0x0 0x1714 0x0 0x100>;
> > mask = <0x1>;
> > };
> > +
> >
On Thursday 21 November 2013, Loc Ho wrote:
> +SATA host controller nodes are defined to describe on-chip Serial ATA
> +controllers. Each SATA controller (pair of ports) have its own node.
> +
> +Required properties:
> +- compatible : Shall be "apm,xgene-ahci"
> +- reg
On Sunday 24 November 2013, Loc Ho wrote:
>
> > > +struct xgene_ahci_context {
> > > + struct ahci_host_priv hpriv;
> > > + struct device *dev;
> > > + int irq;/* IRQ */
> > > + void __iomem *csr_base; /* CSR base address of IP */
> > > + u64 csr_phys;
101 - 200 of 476 matches
Mail list logo
