On Wednesday 20 November 2013, Sergei Shtylyov wrote:
> > --- a/arch/arm64/boot/dts/apm-storm.dtsi
> > +++ b/arch/arm64/boot/dts/apm-storm.dtsi
> > @@ -193,5 +193,33 @@
> >                       reg = <0x0 0x17000014 0x0 0x100>;
> >                       mask = <0x1>;
> >               };
> > +
> > +             sataphy0: sataphy@1f210000 {
> 
>     The nodes should better be named like "sata-phy@1f210000" to better 
> comply 
> with the "ethernet-phy" name we see in the ePAPR spec.
Well, since the phy can be used for other devices, I'd rather name it just
"phy", or possibly "serdes". The fact that it happens to be used for sata
here should not influence the naming when both the phy driver and the hardware
are completely generic.

        Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to