James, Martin,
noone replied 2 weeks,
could you please pick up this patch?
According to Network guru sendpage must not be called for Slab objects.
Unfortunately this happen in real life, for example when XFS send metadata via
network block device.
Some of such cases -- drbd and ceph -- already ha
>
> Without CONFIG_OF, the of_match_node() helper does not evaluate
> its argument, and the compiler warns about the unused variable:
>
> drivers/scsi/ufs/ufs-hisi.c: In function 'ufs_hisi_probe':
> drivers/scsi/ufs/ufs-hisi.c:673:17: error: unused variable 'dev' [-
> Werror=unused-variable]
>
>
Assalamu Alaikum Wa Rahmatullahi Wa Barakatuh,
hello dear
I came across your contact during my private search. Mrs Aisha Al-
Qaddafi is my name, the only daughter of late Libyan president, am a
single Mother and a Widow with three Children.I have funds the sum of
$27.5 million USD for, investme
Vasily,
> James, Martin, noone replied 2 weeks, could you please pick up this
> patch?
No objections from me wrt. to the change. However, I am awaiting a
review from the iSCSI maintainers Lee and Chris.
--
Martin K. Petersen Oracle Linux Engineering
On 3/4/19, 11:39 AM, "Arnd Bergmann" wrote:
Depending on the target architecture and configuration, both phys_addr_t
and dma_addr_t may be smaller than 'long long', so we get a warning when
printing either of them using the %llx format string:
drivers/scsi/qla2xxx/qla_iocb
Erwan,
> When the HARDWARE_ERROR/0x3e/0x1 case is triggered, the logical volume
> is offlined. When reading the kernel log, the reason why the device
> got offlined isn't reported to the user. This situation makes
> difficult for admins to estimate the root cause of the issue they
> analize.
Felipe,
> The virtio scsi spec defines struct virtio_scsi_ctrl_tmf as a set of
> device-readable records and a single device-writable response entry:
Applied to 5.1/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Cathy,
> genlmsg_multicast_allns now returns the correct statuses when a
> message is sent to a listener. However in the case of adding a
> device we want to wait for the listener otherwise we may miss the
> the device during startup.
Applied to 5.1/scsi-queue, thanks!
--
Martin K. Petersen
Hi Finn,
Please submit this as a formal patch. Thanks!
> Here's an alternative patch, which has the virtue that a simple heuristic
> will work. This patch does not require that other static analysis tools
> will follow gcc's weird rules about hyphens. (I assume they don't but I
> didn't chec
Steve,
> megaraid_sas takes 1+ seconds to load while waiting for firmware:
>
> [2.822603] megaraid_sas :03:00.0: Waiting for FW to come to ready state
> [3.871003] megaraid_sas :03:00.0: FW now in Ready state
>
> This is due to the following loop in megasas_transition_to_ready(), which
>
Bill,
> When trying to display tgt_counters in the debugfs, a panic can result.
>
> There is no null check for qpair after it is assigned in the for-loop.
> Unless vha->hw->queue_pair_map array is completely filled with entries,
> the system will panic dereferencing a null pointer.
Applied t
Arnd,
> Without CONFIG_OF, the of_match_node() helper does not evaluate
> its argument, and the compiler warns about the unused variable:
>
> drivers/scsi/ufs/ufs-hisi.c: In function 'ufs_hisi_probe':
> drivers/scsi/ufs/ufs-hisi.c:673:17: error: unused variable 'dev'
> [-Werror=unused-variable]
James,
> The outer routine lpfc_sli_issue_iocb(), which decomposes into the
> SLI3 (s3) or SLI4 (s4) subroutines takes out the locks. For s3, it
> takes out the hbalock. For s4, it takes out the ring_lock. The lockdep
> check in the s3 and s4 subroutines both check hbalock, which is
> incorrect
James,
> The patch that replaced io channels for hdw_queues now reports the
> following static checker warning:
>
> drivers/scsi/lpfc/lpfc_init.c:11136 lpfc_sli4_hba_unset()
> error: we previously assumed 'phba->pport' could be null (see line 11074)
>
> Resolve by adding a pport NULL check.
Ap
Hannes & Christoph: Please comment on Sreekanth's proposed approach.
> During expander reset handling, the driver invokes kernel function
> scsi_host_find_tag() to obtain outstanding requests associated with
> the scsi host managed by the driver. Driver loops from tag value zero
> to hba queue d
Mike,
Please review!
> Switch to bitmap_zalloc() to show clearly what we are allocating.
> Besides that it returns pointer of bitmap type instead of opaque void *.
>
> Signed-off-by: Andy Shevchenko
> ---
> drivers/target/target_core_user.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 d
Arnd,
> Depending on the target architecture and configuration, both
> phys_addr_t and dma_addr_t may be smaller than 'long long', so we get
> a warning when printing either of them using the %llx format string:
Applied to 5.1/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engine
On Thu, Feb 21, 2019 at 06:23:17PM +0300, Vasily Averin wrote:
> In "XFS over network block device" scenario XFS can create IO requests
> with slab-based XFS metadata. During processing such requests
> tcp_sendpage() can merge skb fragments with neighbour slab objects.
>
> If receiving side is loc
On Mon, Feb 25, 2019 at 09:41:30AM -0800, Lee Duncan wrote:
> From: Lee Duncan
>
> If there is an error queueing an iscsi command in
> iscsi_queuecommand(), for example if the transport fails
> to take the command in sessuin->tt->xmit_task(), then
> the error path can call iscsi_complete_task() w
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/scsi/Kconfig | 63 +--
drivers/scsi/osd/Kconfig | 38 +-
drivers/scsi/pcmcia/Kconfig | 2 +-
drivers/scsi/qedf/Kconfig | 8 +++---
drivers/scsi/smartpq
On 03/04/2019 03:44 AM, Andy Shevchenko wrote:
> Switch to bitmap_zalloc() to show clearly what we are allocating.
> Besides that it returns pointer of bitmap type instead of opaque void *.
>
> Signed-off-by: Andy Shevchenko
> ---
> drivers/target/target_core_user.c | 8 +++-
> 1 file change
Formatting of Kconfig files doesn't look so pretty, so just
take damp cloth and clean it up.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/scsi/Kconfig | 63 +--
drivers/scsi/osd/Kconfig | 38 +-
drivers/
Vasily,
> In "XFS over network block device" scenario XFS can create IO requests
> with slab-based XFS metadata. During processing such requests
> tcp_sendpage() can merge skb fragments with neighbour slab objects.
Applied to 5.1/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Eng
Andy,
> Switch to bitmap_zalloc() to show clearly what we are allocating.
> Besides that it returns pointer of bitmap type instead of opaque void
> *.
Applied to 5.1/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Arnd,
> The newly introduced 'cpu' variable is only used inside of an optional
> block, so we get a warning without CONFIG_SCSI_LPFC_DEBUG_FS:
Applied to 5.1/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Arnd,
> On 32-bit architectures, we see a warning when %ld is used to
> print a size_t:
Applied to 5.1/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> The error handling was unintentionally left out so it introduces a
> Smatch static checker warning:
>
> drivers/scsi/qla2xxx/qla_attr.c:1655 qla2x00_port_speed_store()
> error: uninitialized symbol 'type'.
Applied to 5.1/scsi-queue, thanks!
--
Martin K. Petersen Oracle Lin
John,
> The patchset contains some misc patches for the driver, including:
> - Workaround for acute scenario of SMP/internal IO timeout and reset racing
> - Clear Affiliation for STP target port (from Luo Jiaxing and Xiang Chen)
> - Fix PHY negotiated linkrate value for when PHY down
> - Some in
Somebody please review, need this regression fixed in stable!
> Some devices come online in write protected state and switch to
> read-write once they are ready to process I/O requests. These devices
> broke with commit 20bd1d026aac ("scsi: sd: Keep disk read-only when
> re-reading partition") b
It used to be that "error" was set to -ENODEV at the start of the
function but we shifted some code around an now "error" is set to
zero for most error paths. There is a mix of direct returns and
"goto out" but I changed everything to direct returns for consistency.
Fixes: 56de8357049c ("scsi: lp
This is mostly update of the usual drivers: arcmsr, qla2xxx, lpfc,
hisi_sas, target/iscsi and target/core. Additionally Christoph
refactored gdth as part of the dma changes. The major mid-layer change
this time is the removal of bidi commands and with them the whole of
the osd/exofs driver and fi
31 matches
Mail list logo
