Re: [PATCH v1] mpt3sas: Use driver scsi lookup to track outstanding IOs

2019-02-28 Thread Sreekanth Reddy
On Wed, Feb 27, 2019 at 8:20 PM Martin K. Petersen wrote: > > > Kashyap, > > > Primary drawback of using "blk_mq_tagset_busy_iter" is API is only for > > blk-mq and it is not available for all the kernel with blk-mq > > support. We have seen multiple failures from customer and those > > kernels do

Re: [PATCH] scsi: smartpqi_init: Reporting 'logical unit failure'

2019-02-28 Thread Erwan Velu
Hey, That makes me wonder why the 0x3e / 0x2 isn't handled here aka 3E/02 DZTPROMAEBKVF TIMEOUT ON LOGICAL UNIT Is it possible the controller send to the kernel this kind of message, if so shouldn't we handle it here ? Erwan, Le 27/02/2019 à 17:31, Erwan Velu a écrit : > When this HARDWARE_ER

[PATCH 0/6] hisi_sas: Some misc patches

2019-02-28 Thread John Garry
The patchset contains some misc patches for the driver, including: - Workaround for acute scenario of SMP/internal IO timeout and reset racing - Clear Affiliation for STP target port (from Luo Jiaxing and Xiang Chen) - Fix PHY negotiated linkrate value for when PHY down - Some init reg config chang

[PATCH 6/6] scsi: hisi_sas: Change SERDES_CFG init value to increase reliability of HiLink

2019-02-28 Thread John Garry
From: Xiang Chen With default value of register SERDES_CFG, the link is not stable for some special disks when running IO. According to HW guys' suggestion, need to make the bit10~19 value of register SERDES_CFG the max value to increase the reliability of the HiLink. Signed-off-by: Xiang Chen

[PATCH 1/6] scsi: hisi_sas: Change return variable type in phy_up_v3_hw()

2019-02-28 Thread John Garry
From: Xiang Chen According to the tool fortify, phy_up_v3_hw() returns signed value, while it should return an unsigned value. So change variable "res" from int to irq_return_t. Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 3 ++- 1 file cha

[PATCH 5/6] scsi: hisi_sas: Send HARD RESET to clear the previous affiliation of STP target port

2019-02-28 Thread John Garry
From: Xiang Chen If we exchange SAS expander from one SAS controller to other SAS controller without powering it down, the STP target port will maintain previous affiliation and reject all subsequent connection requests from other STP initiator ports with OPEN_REJECT (STP RESOURCES BUSY). To sol

[PATCH 2/6] scsi: hisi_sas: Fix a timeout race of driver internal and SMP IO

2019-02-28 Thread John Garry
From: Xiang Chen For internal IO and SMP IO, there is a time-out timer for them. In the timer handler, it checks whether IO is done according to the flag task->task_state_lock. There is an issue which may cause system suspended: internal IO or SMP IO is sent, but at that time because of hardware

[PATCH 3/6] scsi: hisi_sas: print PHY RX errors count for later revision of v3 hw

2019-02-28 Thread John Garry
From: Xiaofei Tan The later revision of v3 hw has added an function of interrupt coalesce according to time for PHY RX errors. We set the coalesce time to 1s. Then we print PHY RX errors count when PHY RX errors happen, and don't need to worry that there may be too much log prints. Besides, we u

[PATCH 4/6] scsi: hisi_sas: Set PHY linkrate when disconnected

2019-02-28 Thread John Garry
When the PHY comes down, we currently do not set the negotiated linkrate: root@(none)$ pwd /sys/class/sas_phy/phy-0:0 root@(none)$ more enable 1 root@(none)$ more negotiated_linkrate 12.0 Gbit root@(none)$ echo 0 > enable root@(none)$ more negotiated_linkrate 12.0 Gbit root@(none)$ This patch fixe

[PATCH AUTOSEL 4.19 55/64] Revert "scsi: libfc: Add WARN_ON() when deleting rports"

2019-02-28 Thread Sasha Levin
From: Ross Lagerwall [ Upstream commit d8f6382a7d026989029e2e50c515df954488459b ] This reverts commit bbc0f8bd88abefb0f27998f40a073634a3a2db89. It added a warning whose intent was to check whether the rport was still linked into the peer list. It doesn't work as intended and gives false positiv

[PATCH AUTOSEL 4.20 69/81] Revert "scsi: libfc: Add WARN_ON() when deleting rports"

2019-02-28 Thread Sasha Levin
From: Ross Lagerwall [ Upstream commit d8f6382a7d026989029e2e50c515df954488459b ] This reverts commit bbc0f8bd88abefb0f27998f40a073634a3a2db89. It added a warning whose intent was to check whether the rport was still linked into the peer list. It doesn't work as intended and gives false positiv

Re: [PATCH 1/2] scsi: sd: Use revalidate buffer for VPD pages

2019-02-28 Thread Bart Van Assche
On Wed, 2019-02-27 at 22:57 -0500, Martin K. Petersen wrote: > No point in allocating separate memory for the VPD pages we're > querying. Use the buffer we already allocated. > > Signed-off-by: Martin K. Petersen > --- > drivers/scsi/scsi.c | 1 + > drivers/scsi/sd.c | 48 ++--

RE: [scsi] write same with NDOB (no data-out buffer) support

2019-02-28 Thread Bob Sheffield
Hi Martin, I'm still thinking through this, but I wanted to respond so you know I'm not dropping the dialogue. I understand complications you face trying to support a variety of drive implementations that evolve different capabilities over multiple generations. We face the same issues. In some ca

[PATCH] tcmu: wait for nl reply only if there are listeners or during an add

2019-02-28 Thread Cathy Avery
genlmsg_multicast_allns now returns the correct statuses when a message is sent to a listener. However in the case of adding a device we want to wait for the listener otherwise we may miss the the device during startup. Signed-off-by: Cathy Avery --- drivers/target/target_core_user.c | 11 ++

RE: [PATCH] scsi: smartpqi_init: Reporting 'logical unit failure'

2019-02-28 Thread Elliott, Robert (Persistent Memory)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of > Erwan Velu > Sent: Wednesday, February 27, 2019 10:32 AM > Subject: [PATCH] scsi: smartpqi_init: Reporting 'logical unit failure' > > When this HARDWARE_ERROR/0x

[PATCH v2] scsi: NCR5380: Mark expected switch fall-through

2019-02-28 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: In file included from drivers/scsi/dmx3191d.c:48: drivers/scsi/NCR5380.c: In function ‘NCR5380_information_transfer’: drivers/scsi/NCR5380.c:1933:9:

Re: [PATCH] scsi: mpt3sas: Add missing breaks in switch statements

2019-02-28 Thread Gustavo A. R. Silva
On 2/27/19 8:37 AM, Martin K. Petersen wrote: > > Gustavo, > >> Fix the following warnings by adding the proper missing breaks: >> >> drivers/scsi/mpt3sas/mpt3sas_base.c: In function >> ‘_base_display_OEMs_branding’: >> drivers/scsi/mpt3sas/mpt3sas_base.c:3548:4: warning: this statement may f

Re: [PATCH v2] scsi: NCR5380: Mark expected switch fall-through

2019-02-28 Thread Finn Thain
On Thu, 28 Feb 2019, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > This switch case is already marked. So I think the patch description should state that this patch is actually a workaround for a gcc

Re: [PATCH v2] scsi: NCR5380: Mark expected switch fall-through

2019-02-28 Thread Michael Schmitz
Finn's version looks fine to me. Cheers,     Michael On 1/03/19 2:16 PM, Finn Thain wrote: On Thu, 28 Feb 2019, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This switch case is already marked. So I t

Re: [PATCH v3 6/7] phy: mediatek: Add UFS M-PHY driver

2019-02-28 Thread Chunfeng Yun
Hi, Stanley On Wed, 2019-02-27 at 15:23 +0800, Stanley Chu wrote: > Add UFS M-PHY driver on MediaTek chipsets. > > Signed-off-by: Stanley Chu > --- > drivers/phy/mediatek/Kconfig | 9 ++ > drivers/phy/mediatek/Makefile | 1 + > drivers/phy/mediatek/phy-mtk-ufs.c | 239 +++