Hey,
That makes me wonder why the 0x3e / 0x2 isn't handled here aka
3E/02 DZTPROMAEBKVF TIMEOUT ON LOGICAL UNIT Is it possible the
controller send to the kernel this kind of message, if so shouldn't we
handle it here ? Erwan,
Le 27/02/2019 à 17:31, Erwan Velu a écrit :
> When this HARDWARE_ERROR/0x3e/0x1 case is triggered, the logical volume is
> offlined.
> When reading the kernel log, the cause why the device got offlined isn't
> reported to the user.
> This situation makes difficult for admins to estimate _why_ the volume got
> offlined.
> Reading this part of the code makes clear this is because driver received a
> HARDWARE_ERROR/0x3e/0x1 which is a 'logical unit failure'.
>
> This patch is just about reporting that fact to help admins making a
> relationship between this event and the offlining.
>
> Signed-off-by: Erwan Velu <e.v...@criteo.com>
> ---
> drivers/scsi/smartpqi/smartpqi_init.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c
> b/drivers/scsi/smartpqi/smartpqi_init.c
> index f564af8949e8..89f37d76735c 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -2764,6 +2764,12 @@ static void pqi_process_raid_io_error(struct
> pqi_io_request *io_request)
> sshdr.sense_key == HARDWARE_ERROR &&
> sshdr.asc == 0x3e &&
> sshdr.ascq == 0x1) {
> + struct pqi_ctrl_info *ctrl_info =
> shost_to_hba(scmd->device->host);
> + struct pqi_scsi_dev *device = scmd->device->hostdata;
> +
> + dev_err(&ctrl_info->pci_dev->dev, "received 'logical
> unit failure' from controller for scsi %d:%d:%d:%d\n",
> +
> ctrl_info->scsi_host->host_no, device->bus,
> + device->target,
> device->lun);
> pqi_take_device_offline(scmd->device, "RAID");
> host_byte = DID_NO_CONNECT;
> }
