Re: sd.h: copy error in sd_first_printk() ?

2019-02-13 Thread Dietmar Hahn
Hi Martin, Am Mittwoch, 13. Februar 2019, 04:53:07 CET schrieb Martin K. Petersen: > > Hi Dietmar, > > This didn't cause any real grief since all callers have an sdkp. But > it's definitely a typo on my part. I applied your patch to > 5.1/scsi-queue. > > Your contribution didn't quite follow th

Re: [PATCH] scsi: lpfc: fix calls to dma_set_mask_and_coherent()

2019-02-13 Thread John Garry
On 13/02/2019 03:10, Martin K. Petersen wrote: Ewan, It also appears as if the patches to hptiop, hisi_sas and bfa need to be fixed up. I don't have a test environment for these, although I might be able to modify the test environment for bfa. Martin/James, what about the others? I'm afrai

RE: Request for opinion: ufsutils

2019-02-13 Thread Avri Altman
> > I can see the issue, there is no straightforward way of having "ufs-bsg" > without > a device attached? Right. > > This or any other method of talking with UniPro and MPhy layers when there > is no > device are necessary for us. Do you see some good way of doing this? I don't really know. If

Re: [PATCH 07/12] qla2xxx: Prevent SysFS access when chip is down (fwd)

2019-02-13 Thread Julia Lawall
improve the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Madhani/qla2xxx-Misc-bug-fixes-for-the-driver/20190213-094944 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next :: branch date: 7 hours ago :: commit date: 7 hours ago >> dr

Re: [PATCH v5 1/2] scsi: ufs: Do not disable vccq in UFSHC driver

2019-02-13 Thread Marc Gonzalez
On 11/02/2019 18:23, Mark Brown wrote: > On Mon, Feb 11, 2019 at 02:32:15PM +0100, Marc Gonzalez wrote: > >> Unfortunately, this optimization breaks UFS on systems where vccq >> powers not only the Flash chip, but the host controller as well, >> such as APQ8098 MEDIABOX or MTP8998. >> >> In my o

hello dear

2019-02-13 Thread Mrs Aisha Gaddafi
Assalamu Alaikum Wa Rahmatullahi Wa Barakatuh, hello dear I came across your contact during my private search Mrs Aisha Al-Qaddafi is my name, the only daughter of late Libyan president, am a single Mother and a Widow with three Children.I have funds the sum of $27.5 million USD for investment

Re: [PATCH v5 0/2] Clean up UFSHC driver

2019-02-13 Thread Alim Akhtar
Hi Marc, On 11/02/19 7:01 PM, Marc Gonzalez wrote: > Casting a wide net to get as many eyeballs on the subject as possible. > > I'm splitting this mini series off from the main "UFS on APQ8098/MSM8998" > as it's 1) ufs/scsi specific 2) controversial (to my surprise) > > Please send all your Revi

SCSI regression in 4.19

2019-02-13 Thread Roger Pau Monné
Hello, I'm seeing the following GP on 4.19.20, same box is working fine with 4.14: Initializing Intel(R) Boot Agent GE v1.3.76 PXE 2.1 Build 090 (WfM 2.0) Press Ctrl+S to enter the Setup Menu [0.00] microcode: microcode updated early to revision 0x428, date = 2014 -05-29g initial ramdisk

[PATCH 0/4] scsi: fixup dma_set_mask_and_coherent() calls

2019-02-13 Thread Hannes Reinecke
The recent patchset to use dma_set_mask_and_coherent() introduced a regression where a call to set a 64-bit DMA mask was followed by a call to set a 32-bit DMA mask, leading to I/O errors and data corruption. Patchset is based on a suggestions from Ewan Milne. Hannes Reinecke (4): lpfc: fix cal

[PATCH 1/4] lpfc: fix calls to dma_set_mask_and_coherent()

2019-02-13 Thread Hannes Reinecke
The change to use dma_set_mask_and_coherent() incorrectly made a second call with the 32 bit DMA mask value when the call with the 64 bit DMA mask value succeeded. This resulted in NVMe/FC connections failing due to corrupted data buffers, and various other SCSI/FCP I/O errors. Fixes: f30e1bfd615

[PATCH 2/4] hptiop: fix calls to dma_set_mask_and_coherent()

2019-02-13 Thread Hannes Reinecke
The change to use dma_set_mask_and_coherent() incorrectly made a second call with the 32 bit DMA mask value when the call with the 64 bit DMA mask value succeeded. This resulted in NVMe/FC connections failing due to corrupted data buffers, and various other SCSI/FCP I/O errors. Fixes: 453cd3700ca

[PATCH 3/4] bfa: fix calls to dma_set_mask_and_coherent()

2019-02-13 Thread Hannes Reinecke
The change to use dma_set_mask_and_coherent() incorrectly made a second call with the 32 bit DMA mask value when the call with the 64 bit DMA mask value succeeded. This resulted in FC connections failing due to corrupted data buffers, and various other SCSI/FCP I/O errors. Fixes: a69b080025ea ("s

[PATCH 4/4] hisi_sas: fix calls to dma_set_mask_and_coherent()

2019-02-13 Thread Hannes Reinecke
The change to use dma_set_mask_and_coherent() incorrectly made a second call with the 32 bit DMA mask value when the call with the 64 bit DMA mask value succeeded. This resulted in FC connections failing due to corrupted data buffers, and various other SCSI/FCP I/O errors. Fixes: e4db40e7a1a2 ("s

Re: [PATCH 4/4] hisi_sas: fix calls to dma_set_mask_and_coherent()

2019-02-13 Thread John Garry
On 13/02/2019 11:42, Hannes Reinecke wrote: The change to use dma_set_mask_and_coherent() incorrectly made a second call with the 32 bit DMA mask value when the call with the 64 bit DMA mask value succeeded. This resulted in FC connections failing due to corrupted data buffers, and various other

Re: [PATCH 02/12] qla2xxx: Add First Burst support for FC-NVMe devices

2019-02-13 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Himanshu-Madhani/qla2xxx-Misc-bug-fixes-for-the-driver/20190213-094944 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagn

[PATCH] scsi: qla2xxx: remove redundant null check on pointer sess

2019-02-13 Thread Colin King
From: Colin Ian King The null check on pointer sess and the subsequent call is redundant as sess is null on all the the paths that lead to the out_term2 label. Hence the null check and the call can be removed. Detected by CoverityScan, CID#1420663 ("Logically dead code") Signed-off-by: Colin Ia

[PATCH] scsi: qlogicpti: Use of_node_name_eq for node name comparisons

2019-02-13 Thread Rob Herring
Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. As prom_name is not used for anything else, remove it. Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Rob Herri

Re: Request for opinion: ufsutils

2019-02-13 Thread Pedro Sousa
Hi, On 2/13/2019 9:30 AM, Avri Altman wrote: >> >> I can see the issue, there is no straightforward way of having "ufs-bsg" >> without >> a device attached? > Right. > >> >> This or any other method of talking with UniPro and MPhy layers when there >> is no >> device are necessary for us. Do you

Re: Request for opinion: ufsutils

2019-02-13 Thread Greg KH
On Wed, Feb 13, 2019 at 05:00:51PM +, Pedro Sousa wrote: > Hi, > > On 2/13/2019 9:30 AM, Avri Altman wrote: > >> > >> I can see the issue, there is no straightforward way of having "ufs-bsg" > >> without > >> a device attached? > > Right. > > > >> > >> This or any other method of talking with

Re: [LSF/MM TOPIC] : blktests: status, an expansion plan for the storage stack test framework

2019-02-13 Thread Bart Van Assche
On Wed, 2019-02-06 at 05:21 +, Chaitanya Kulkarni wrote: > For storage track, we would like to propose a session dedicated to blktests. > It is a great > opportunity for the storage developers to gather and have a discussion about:- > > 1. Current status of the blktests framework. > 2. Any ne

Re: Request for opinion: ufsutils

2019-02-13 Thread Pedro Sousa
Hello Greg k-h, On 2/13/2019 5:47 PM, Greg KH wrote: > On Wed, Feb 13, 2019 at 05:00:51PM +, Pedro Sousa wrote: >> Hi, >> >> On 2/13/2019 9:30 AM, Avri Altman wrote: I can see the issue, there is no straightforward way of having "ufs-bsg" without a device attached? >>> Righ

Re: [PATCH] scsi: lpfc: fix calls to dma_set_mask_and_coherent()

2019-02-13 Thread Ewan D. Milne
On Tue, 2019-02-12 at 10:34 -0800, Christoph Hellwig wrote: > On Tue, Feb 12, 2019 at 10:37:45AM -0500, Ewan D. Milne wrote: > > > > It looks like this would introduce a different problem. "error" is set to > > -ENODEV earlier in the two functions so that the various error paths will > > return

Re: [PATCH 0/4] scsi: fixup dma_set_mask_and_coherent() calls

2019-02-13 Thread Ewan D. Milne
On Wed, 2019-02-13 at 12:42 +0100, Hannes Reinecke wrote: > The recent patchset to use dma_set_mask_and_coherent() introduced > a regression where a call to set a 64-bit DMA mask was followed > by a call to set a 32-bit DMA mask, leading to I/O errors and > data corruption. > > Patchset is based o

Re: [LSF/MM TOPIC] : blktests: status, an expansion plan for the storage stack test framework

2019-02-13 Thread Omar Sandoval
On Wed, Feb 13, 2019 at 10:11:14AM -0800, Bart Van Assche wrote: > On Wed, 2019-02-06 at 05:21 +, Chaitanya Kulkarni wrote: > > For storage track, we would like to propose a session dedicated to > > blktests. It is a great > > opportunity for the storage developers to gather and have a discuss

Re: [PATCH 1/4] lpfc: fix calls to dma_set_mask_and_coherent()

2019-02-13 Thread Ewan D. Milne
See below. Also, this patch only fixes 1 of the 2 places, we need to fix lpfc_sli4_pci_mem_setup() also. With the same code applied in both places, the NVMe/FC issue is fixed. I expect the SCSI/FCP tests would pass too, but those take a couple of days. -Ewan On Wed, 2019-02-13 at 12:42 +0100, H

Re: [PATCH 3/4] bfa: fix calls to dma_set_mask_and_coherent()

2019-02-13 Thread Ewan D. Milne
See below. Also see comment re: the patch description. -Ewan On Wed, 2019-02-13 at 12:42 +0100, Hannes Reinecke wrote: > The change to use dma_set_mask_and_coherent() incorrectly made a second > call with the 32 bit DMA mask value when the call with the 64 bit DMA > mask value succeeded. This r

Re: [PATCH 2/4] hptiop: fix calls to dma_set_mask_and_coherent()

2019-02-13 Thread Ewan D. Milne
The patch subject line is incorrect, the driver was changed to call dma_set_mask(), not dma_set_mask_and_coherent(). Also see comments below re: the patch description. The code itself looks fine. -Ewan On Wed, 2019-02-13 at 12:42 +0100, Hannes Reinecke wrote: > The change to use dma_set_mask_and

Re: [PATCH 4/4] hisi_sas: fix calls to dma_set_mask_and_coherent()

2019-02-13 Thread Ewan D. Milne
See comment below re: the patch description. The code itself looks fine. -Ewan On Wed, 2019-02-13 at 12:42 +0100, Hannes Reinecke wrote: > The change to use dma_set_mask_and_coherent() incorrectly made a second > call with the 32 bit DMA mask value when the call with the 64 bit DMA > mask value

Re: [LSF/MM TOPIC] : blktests: status, an expansion plan for the storage stack test framework

2019-02-13 Thread Bart Van Assche
On Wed, 2019-02-13 at 10:43 -0800, Omar Sandoval wrote: > On Wed, Feb 13, 2019 at 10:11:14AM -0800, Bart Van Assche wrote: > > - Is it acceptable that patches get accepted in the blktests repository that > > break the continuous integration tests? If so, why do we even have > > continuous > >

[PATCH v2 04/12] qla2xxx: Check for FW started flag before aborting

2019-02-13 Thread Himanshu Madhani
For FC-NVMe, if the fw_started flag is not set or fcport is deleted, then do not send Abort command Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c in

[PATCH v2 07/12] qla2xxx: Prevent SysFS access when chip is down

2019-02-13 Thread Himanshu Madhani
From: Quinn Tran Prevent user from sending commands through SysFS while FW is not running or reset is in progress. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_attr

[PATCH v2 01/12] qla2xxx: Fix LUN discovery if loop id is not assigned yet by firmware

2019-02-13 Thread Himanshu Madhani
This patch fixes LUN discovery when loop ID is not yet assigned by the firmware during driver load/sg_reset operations. Driver will now search for new loop id before retrying login. Fixes: 48acad099074 ("scsi: qla2xxx: Fix N2N link re-connect") Cc: sta...@vger.kernel.org #4.19 Signed-off-by: Himan

[PATCH v2 00/12] qla2xxx: Misc bug fixes for the driver

2019-02-13 Thread Himanshu Madhani
Hi Martin, This series has misc bug fixes which includes cleanup for FC-NVMe code and added first burst support for FC-NVMe devices. Other patches included in the series adds new SysFS hook for setting port speed and patch to prevent access to SysFS hook whle chip is down. Also added workqueue me

[PATCH v2 05/12] qla2xxx: Prevent multiple ADISC commands per session

2019-02-13 Thread Himanshu Madhani
From: Quinn Tran add check to allow 1 discovery command per session to be sent. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scs

[PATCH v2 08/12] qla2xxx: Add workqueue to delete fcport from bsg sp->free().

2019-02-13 Thread Himanshu Madhani
From: Joe Carnuccio This patch adds workqueue mechanism for deleting fcport via BSG interface. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_bsg.c | 18 +- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_os.c | 11 ++

[PATCH v2 02/12] qla2xxx: Add First Burst support for FC-NVMe devices

2019-02-13 Thread Himanshu Madhani
From: Darren Trapp Add Support for First Burst for FC-NVMe protocol. This feature requires First Burst support in the firmware. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 4 drivers/scsi/qla2xxx/qla_init.c | 6 ++ drivers/scsi/

[PATCH v2 03/12] qla2xxx: Fix unload when NVMe devices are configured

2019-02-13 Thread Himanshu Madhani
This patch fixes driver unload issue when FC-NVMe devices are configured. Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nv

[PATCH v2 10/12] qla2xxx: Fix code indentation for qla27xx_fwdt_entry

2019-02-13 Thread Himanshu Madhani
This patch fixes following checkpatch ERROR ERROR: space prohibited before that ',' (ctx:WxW) No change is functionality due to this patch. Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 46 - 1 file changed, 23 insertions(+), 23

[PATCH v2 06/12] qla2xxx: Add support for setting port speed

2019-02-13 Thread Himanshu Madhani
From: Anil Gurumurthy This patch adds SysFS node 1. There is a new sysfs node port_speed 2. The possible values are 2(Auto neg), 8, 16, 32 3. A value outside of the above defaults to Auto neg 4. Any update to the setting causes a link toggle 5. This feature is currently only for ISP27xx Signed-

[PATCH v2 12/12] qla2xxx: Update driver version to 10.00.00.14-k

2019-02-13 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 537098e8f1c1..0690dac24081 100644 --- a/drivers/scsi/qla2xxx/qla_version.h +++

[PATCH v2 09/12] qla2xxx: Move marker request behind QPair

2019-02-13 Thread Himanshu Madhani
From: Quinn Tran current code hard code marker request to use request and response queue 0. This patch make use of the qpair as the path to access the request/response queues. It allows marker to be place on any hardware queues. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- dr

[PATCH v2 11/12] qla2xxx: Add new FW dump template entry types

2019-02-13 Thread Himanshu Madhani
From: Joe Carnuccio This patch adds new firmware dump template entries for ISP27XX firmware dump. Signed-off-by: Joe Carnuccio Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_tmpl.c | 191 +--- drivers/scsi/qla2xxx/qla_tmpl.h | 26 +- 2 fi

Re: [LSF/MM TOPIC] : blktests: status, an expansion plan for the storage stack test framework

2019-02-13 Thread Omar Sandoval
On Wed, Feb 13, 2019 at 10:54:04AM -0800, Bart Van Assche wrote: > On Wed, 2019-02-13 at 10:43 -0800, Omar Sandoval wrote: > > On Wed, Feb 13, 2019 at 10:11:14AM -0800, Bart Van Assche wrote: > > > - Is it acceptable that patches get accepted in the blktests repository > > > that > > > break the

Re: [LSF/MM TOPIC] : blktests: status, an expansion plan for the storage stack test framework

2019-02-13 Thread Bart Van Assche
On Wed, 2019-02-13 at 11:56 -0800, Omar Sandoval wrote: > On Wed, Feb 13, 2019 at 10:54:04AM -0800, Bart Van Assche wrote: > > What is a build status badge? > > I just added it, see > https://github.com/osandov/blktests/commit/a61aa7fcce0bad9094b0e7646f3a8299c30afa6a > > Anyway, enabling Travis C

Re: [PATCH] scsi: lpfc: fix a handful of indentation issues

2019-02-13 Thread James Smart
On 2/12/2019 7:29 AM, Colin King wrote: From: Colin Ian King There are a handful of statements that are indented incorrectly. Fix these. Signed-off-by: Colin Ian King --- drivers/scsi/lpfc/lpfc_bsg.c | 4 ++-- drivers/scsi/lpfc/lpfc_debugfs.c | 4 ++-- drivers/scsi/lpfc/lpfc_init.c

Re: [PATCH 3/4] bfa: fix calls to dma_set_mask_and_coherent()

2019-02-13 Thread kbuild test robot
Hi Hannes, I love your patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on v5.0-rc4 next-20190212] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/l

[PATCH V2 2/7] mm/gup: Change write parameter to flags in fast walk

2019-02-13 Thread ira . weiny
From: Ira Weiny In order to support more options in the GUP fast walk, change the write parameter to flags throughout the call stack. This patch does not change functionality and passes FOLL_WRITE where write was previously used. Signed-off-by: Ira Weiny --- mm/gup.c | 52

[PATCH V2 4/7] mm/gup: Add FOLL_LONGTERM capability to GUP fast

2019-02-13 Thread ira . weiny
From: Ira Weiny DAX pages were previously unprotected from longterm pins when users called get_user_pages_fast(). Use the new FOLL_LONGTERM flag to check for DEVMAP pages and fall back to regular GUP processing if a DEVMAP page is encountered. Signed-off-by: Ira Weiny --- mm/gup.c | 24 ++

[PATCH V2 5/7] IB/hfi1: Use the new FOLL_LONGTERM flag to get_user_pages_fast()

2019-02-13 Thread ira . weiny
From: Ira Weiny Use the new FOLL_LONGTERM to get_user_pages_fast() to protect against FS DAX pages being mapped. Signed-off-by: Ira Weiny --- drivers/infiniband/hw/hfi1/user_pages.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/user_pages.

[PATCH V2 7/7] IB/mthca: Use the new FOLL_LONGTERM flag to get_user_pages_fast()

2019-02-13 Thread ira . weiny
From: Ira Weiny Use the new FOLL_LONGTERM to get_user_pages_fast() to protect against FS DAX pages being mapped. Signed-off-by: Ira Weiny --- drivers/infiniband/hw/mthca/mthca_memfree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mthca/mthca_memf

[PATCH V2 6/7] IB/qib: Use the new FOLL_LONGTERM flag to get_user_pages_fast()

2019-02-13 Thread ira . weiny
From: Ira Weiny Use the new FOLL_LONGTERM to get_user_pages_fast() to protect against FS DAX pages being mapped. Signed-off-by: Ira Weiny --- drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c

[PATCH V2 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'

2019-02-13 Thread ira . weiny
From: Ira Weiny To facilitate additional options to get_user_pages_fast() change the singular write parameter to be gup_flags. This patch does not change any functionality. New functionality will follow in subsequent patches. Some of the get_user_pages_fast() call sites were unchanged because

[PATCH V2 1/7] mm/gup: Replace get_user_pages_longterm() with FOLL_LONGTERM

2019-02-13 Thread ira . weiny
From: Ira Weiny Rather than have a separate get_user_pages_longterm() call, introduce FOLL_LONGTERM and change the longterm callers to use it. This patch does not change any functionality. FOLL_LONGTERM can only be supported with get_user_pages() as it requires vmas to determine if DAX is in us

[PATCH V2 0/7] Add FOLL_LONGTERM to GUP fast and use it

2019-02-13 Thread ira . weiny
From: Ira Weiny NOTE: This series depends on my clean up patch to remove the write parameter from gup_fast_permitted()[1] HFI1, qib, and mthca, use get_user_pages_fast() due to it performance advantages. These pages can be held for a significant time. But get_user_pages_fast() does not protect

[PATCH v4 0/8] phy: qcom-ufs: Enable regulators to be off in suspend

2019-02-13 Thread Evan Green
The goal with this series is to enable shutting off regulators that power UFS during system suspend. In "the good life" version of this, we'd just disable the regulators in phy_poweroff() and be done with it. Unfortunately, that's not symmetric, as regulators are not enabled during phy_poweron().

[PATCH v4 7/8] phy: qcom: Utilize UFS reset controller

2019-02-13 Thread Evan Green
Move the PHY reset from ufs-qcom into the respective PHYs. This will allow us to merge the two phases of UFS PHY initialization. Signed-off-by: Evan Green --- Changes in v4: - Do reset_control_* unconditionally since null is handled (Stephen). Changes in v3: - Refactored to move reset control

[PATCH v4 8/8] phy: ufs-qcom: Refactor all init steps into phy_poweron

2019-02-13 Thread Evan Green
The phy code was using implicit sequencing between the PHY driver and the UFS driver to implement certain hardware requirements. Specifically, the PHY reset register in the UFS controller needs to be deasserted before serdes start occurs in the PHY. Before this change, the code was doing this by u

[PATCH v4 6/8] scsi: ufs: qcom: Expose the reset controller for PHY

2019-02-13 Thread Evan Green
Expose a reset controller that the phy will later use to control its own PHY reset in the UFS controller. This will enable the combining of PHY init functionality into a single function. Signed-off-by: Evan Green Reviewed-by: Stephen Boyd --- Note: The remaining changes in this series need this

Re: [PATCH v2 06/12] qla2xxx: Add support for setting port speed

2019-02-13 Thread Bart Van Assche
On Wed, 2019-02-13 at 10:53 -0800, Himanshu Madhani wrote: > static ssize_t > +qla2x00_sysfs_set_port_speed(struct file *filp, struct kobject *kobj, > +struct bin_attribute *bin_attr, char *buf, loff_t off, size_t count) > +{ > + struct scsi_qla_host *vha = shost_priv(dev_to_shost(containe

Re: [PATCH v2 08/12] qla2xxx: Add workqueue to delete fcport from bsg sp->free().

2019-02-13 Thread Bart Van Assche
On Wed, 2019-02-13 at 10:53 -0800, Himanshu Madhani wrote: > + ha->free_fcport = create_workqueue("free_fcport"); > + if (!ha->free_fcport) { > + ql_log(ql_log_info, base_vha, 0xee00, > + "Failed to allocate workqueue ha->free_fcport\n"); > + } Above this co

[PATCH -next] scsi: lpfc: Remove set but not used variable 'phys_id'

2019-02-13 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_cpu_affinity_check': drivers/scsi/lpfc/lpfc_init.c:10599:19: warning: variable 'phys_id' set but not used [-Wunused-but-set-variable] It never used since introduction in commit 6a828b0f6192 ("scsi: lp

Re: [PATCH v2 3/3] scsi: ufs: Add HI3670 SoC UFS driver support

2019-02-13 Thread Martin K. Petersen
Manivannan, > Ping on this patch! I don't have any objections except I would like to see an Acked-by: from Wei Li or somebody from hisilicon. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qlogicpti: Use of_node_name_eq for node name comparisons

2019-02-13 Thread Martin K. Petersen
Rob, > - qpti->is_pti = strcmp(qpti->prom_name, "QLGC,isp"); > + qpti->is_pti = !of_node_name_eq(op->dev.of_node, "QLGC,isp"); The apparent polarity inversion made me blink but it appears to be correct (is_pti is set if it's not an isp controller). Makes me wonder if the driver is doing

Re: [PATCH] scsi: lpfc: fix a handful of indentation issues

2019-02-13 Thread Martin K. Petersen
Colin, > There are a handful of statements that are indented incorrectly. Fix > these. Applied to 5.1/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: sd_zbc: Fix sd_zbc_report_zones() buffer allocation

2019-02-13 Thread Martin K. Petersen
Damien, > + buflen = min(queue_max_sectors(disk->queue) << 9, > + roundup((nrz + 1) * 64, 512)); Shouldn't this be queue_max_hw_sectors()? max_sectors is the soft limit for filesystem reads and writes. max_hw_sectors is the per-command maximum data transfer supported by t

Re: [PATCH] scsi: sd_zbc: Fix sd_zbc_report_zones() buffer allocation

2019-02-13 Thread Damien Le Moal
On 2019/02/14 12:22, Martin K. Petersen wrote: > > Damien, > >> +buflen = min(queue_max_sectors(disk->queue) << 9, >> + roundup((nrz + 1) * 64, 512)); > > Shouldn't this be queue_max_hw_sectors()? > > max_sectors is the soft limit for filesystem reads and writes. > > max_hw

HI

2019-02-13 Thread Charles Jacoby
-- I am Charles Jacoby. I'm 49 years old, from the united states but I am currently in Syria for peace keeping mission. I am the commanding officer of the third Battalion soldier regime. Please forgive my manners am not good when it comes to Internet because that is not really my field I ac

[PATCH 3/6] mpt3sas: Irq poll to avoid CPU hard lockups.

2019-02-13 Thread Suganath Prabu
Issue Discription: We have seen cpu lock up issue from fields if system has greater (more than 96) logical cpu count. SAS3.0 controller (Invader series) supports at max 96 msix vector and SAS3.5 product (Ventura) supports at max 128 msix vectors. This may be a generic issue (if PCI device support

[PATCH 0/6] Irq poll to address cpu lockup.

2019-02-13 Thread Suganath Prabu
We have seen cpu lock up issue from fields if system has greater (more than 96) logical cpu count. SAS3.0 controller (Invader series) supports at max 96 msix vector and SAS3.5 product (Ventura) supports at max 128 msix vectors. This may be a generic issue (if PCI device support completion on multi

[PATCH 6/6] mpt3sas: Update mpt3sas driver version to 28.100.00.00

2019-02-13 Thread Suganath Prabu
Updated driver version to 28.100.00.00, which is equivalent to OOB Ph9 Signed-off-by: Suganath Prabu --- drivers/scsi/mpt3sas/mpt3sas_base.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index

[PATCH 1/6] mpt3sas: Fix typo in request_desript_type.

2019-02-13 Thread Suganath Prabu
Fixed typo in request_desript_type. request_desript_type --> request_descript_type. Signed-off-by: Suganath Prabu --- drivers/scsi/mpt3sas/mpt3sas_base.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt

[PATCH 4/6] mpt3sas: Load balance to improve performance and avoid soft lockups.

2019-02-13 Thread Suganath Prabu
Driver uses "reply descriptor post queues" in round robin fashion so that IO's are distributed to all the available reply descriptor post queues equally. With this each reply descriptor post queue load is balanced. This is enabled only if CPUs count to MSI-X vector count ratio is X:1 (where X > 1)

[PATCH 5/6] mpt3sas: Improve the threshold value and introduce module param.

2019-02-13 Thread Suganath Prabu
* Reduce the threshold value to 1/4 of the queue depth. * With this FW can find enough entries to post the Reply Descriptors in the reply descriptor post queue. * With module param, user can play with threshold value, the same irqpoll_weight is used as the budget in processing of reply descriptor p

[PATCH 2/6] mpt3sas: simplify interrupt handler.

2019-02-13 Thread Suganath Prabu
Separate out processing of reply descriptor post queue from _base_interrupt to _base_process_reply_queue. Signed-off-by: Suganath Prabu --- drivers/scsi/mpt3sas/mpt3sas_base.c | 49 + 1 file changed, 33 insertions(+), 16 deletions(-) diff --git a/drivers/scsi

Re: [PATCH] scsi: qla2xxx: remove redundant null check on pointer sess

2019-02-13 Thread Dan Carpenter
On Wed, Feb 13, 2019 at 01:53:35PM +, Colin King wrote: > From: Colin Ian King > > The null check on pointer sess and the subsequent call is redundant > as sess is null on all the the paths that lead to the out_term2 label. > Hence the null check and the call can be removed. > > Detected by

[PATCH v2] scsi: sd_zbc: Fix sd_zbc_report_zones() buffer allocation

2019-02-13 Thread Damien Le Moal
From: Masato Suzuki The function sd_zbc_do_report_zones() issues a REPORT ZONES command with a buffer size calculated based on the number of zones requested by the caller. This value should however not exceed the capabilities of the hardware maximum command size, that is, should not exceed the ma

答复: [PATCH v2 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support

2019-02-13 Thread liwei (CM)
Fine to me. Thanks! Acked-by: Wei Li -邮件原件- 发件人: Manivannan Sadhasivam [mailto:manivannan.sadhasi...@linaro.org] 发送时间: 2019年1月5日 15:29 收件人: vinholika...@gmail.com; j...@linux.vnet.ibm.com; martin.peter...@oracle.com; liwei (CM); robh...@kernel.org 抄送: linux-scsi@vger.kernel.org; linux-k

答复: [PATCH v2 1/3] dt-bindings: ufs: Add HI3670 UFS controller binding

2019-02-13 Thread liwei (CM)
Fine to me. Thanks! Acked-by: Wei Li -邮件原件- 发件人: Manivannan Sadhasivam [mailto:manivannan.sadhasi...@linaro.org] 发送时间: 2019年1月5日 15:29 收件人: vinholika...@gmail.com; j...@linux.vnet.ibm.com; martin.peter...@oracle.com; liwei (CM); robh...@kernel.org 抄送: linux-scsi@vger.kernel.org; linux-k

答复: [PATCH v2 3/3] scsi: ufs: Add HI3670 SoC UFS driver support

2019-02-13 Thread liwei (CM)
Fine to me. Thanks! Acked-by: Wei Li -邮件原件- 发件人: Manivannan Sadhasivam [mailto:manivannan.sadhasi...@linaro.org] 发送时间: 2019年1月5日 15:29 收件人: vinholika...@gmail.com; j...@linux.vnet.ibm.com; martin.peter...@oracle.com; liwei (CM); robh...@kernel.org 抄送: linux-scsi@vger.kernel.org; linux-k

Re: [LSF/MM TOPIC] : blktests: status, an expansion plan for the storage stack test framework

2019-02-13 Thread Chaitanya Kulkarni
On 2/13/19 10:11 AM, Bart Van Assche wrote: > On Wed, 2019-02-06 at 05:21 +, Chaitanya Kulkarni wrote: >> For storage track, we would like to propose a session dedicated to blktests. >> It is a great >> opportunity for the storage developers to gather and have a discussion >> about:- >> >> 1.