Re: DISABLE_CLUSTERING in scsi drivers

2018-11-26 Thread Michael Schmitz
Am 26.11.2018 um 20:50 schrieb Christoph Hellwig: On Thu, Nov 22, 2018 at 10:11:33AM +1300, Michael Schmitz wrote: Christoph, for Atari SCSI, commands can only be merged if the physical addresses of all buffers are contiguous (limitation of the Falcon DMA engine). Documentation/scsi/scsi_mid_

[PATCH 0/3] scsi: ufs-bsg: Add read descriptor

2018-11-26 Thread Avri Altman
UFS Protocol Information Units (UPIU) are UFS packets that travel between the host and the device on the UniPro bus. Our previous series added the capability to send UPIUs to the ufs driver. It does not cover all the possible UPIU types - we are mainly focused on device management, provisioning, te

[PATCH 1/3] bsg: Make job reply size different than SCSI_SENSE_BUFFERSIZE

2018-11-26 Thread Avri Altman
The size of the bsg job reply was set to SCSI_SENSE_BUFFERSIZE back then while it was part of the bsg_command. However, for the scsi transport that uses it, it does not carry the scsi sense information. Rename it to clarify this point, and while at it, make it a little bit larger, so it'll be able

[PATCH 3/3] scsi: ufs-bsg: Allow reading descriptors

2018-11-26 Thread Avri Altman
Add this functionality, now that job->reply is big enough. While at it, fix a typo in ufs_bsg_verify_query_params. Signed-off-by: Avri Altman --- Documentation/scsi/ufs.txt | 8 drivers/scsi/ufs/ufs_bsg.c | 25 +++-- 2 files changed, 23 insertions(+), 10 deletions(-

[PATCH 2/3] scsi: ufs: Allow reading descriptor via raw upiu

2018-11-26 Thread Avri Altman
Allow to read descriptors via raw upiu. This in fact was forbidden just as a precaution, as ufs-bsg actually enforces which functionality is supported. Signed-off-by: Avri Altman --- drivers/scsi/ufs/ufshcd.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git

Re: DISABLE_CLUSTERING in scsi drivers

2018-11-26 Thread Finn Thain
On Mon, 26 Nov 2018, Christoph Hellwig wrote: > On Thu, Nov 22, 2018 at 09:02:13AM +1100, Finn Thain wrote: > > > you in the To list maintain or wrote SCSI drivers that set the > > > DISABLE_CLUSTERING flag, which basically disable merges of any > > > bio segments. We already have the actual max_

Re: Did You Receive My Last Mail?

2018-11-26 Thread Reem Al-Hashimi
Hello, My name is ms. Reem Al-Hashimi. The UAE minister of state for international cooparation. I got your contact from an email database from your country. I have a financial transaction i would like to discuss with you. Please reply to reem2...@daum.net, for more details if you are interested

[no subject]

2018-11-26 Thread Offer
-- -- Guten Tag, Wir sind eine registrierte private Geldverleiher. Wir geben Kredite an Firmen, Einzelpersonen, die ihre finanzielle Status auf der ganzen Welt aktualisieren müssen, mit minimalen jährlichen Zinsen von 2% .reply, wenn nötig. Good Day, We are a registered private money lender. We

[PATCH] scsi: ufs: add fall through annotation

2018-11-26 Thread Tomas Winkler
Add /* fallthrough */ annotation, to eliminate compilation warning: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Tomas Winkler --- drivers/scsi/ufs/ufshcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/uf

Re: [PATCH v2] codafs: Fix build using bare-metal toolchain

2018-11-26 Thread Sam Protsenko
Andy, btw, I'm observing some strange mail thread behavior here. I'm pretty sure you responded to Jan, but he's not in the recipient list in your last mail. If you check Jan's mail (the one you responded to), you can notice new "reply-to" field (or "Mail-Followup-To:", in raw mail). When you respon

Re: [PATCHv3 2/3] scsi: Do not rely on blk-mq for double completions

2018-11-26 Thread Jens Axboe
On 11/21/18 6:12 AM, Christoph Hellwig wrote: > On Mon, Nov 19, 2018 at 08:19:00AM -0700, Keith Busch wrote: >> On Mon, Nov 19, 2018 at 12:58:15AM -0800, Christoph Hellwig wrote: index 5d83a162d03b..c1d5e4e36125 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c

Re: [PATCHv3 2/3] scsi: Do not rely on blk-mq for double completions

2018-11-26 Thread Keith Busch
On Mon, Nov 26, 2018 at 08:32:45AM -0700, Jens Axboe wrote: > On 11/21/18 6:12 AM, Christoph Hellwig wrote: > > On Mon, Nov 19, 2018 at 08:19:00AM -0700, Keith Busch wrote: > >> On Mon, Nov 19, 2018 at 12:58:15AM -0800, Christoph Hellwig wrote: > index 5d83a162d03b..c1d5e4e36125 100644 >

Re: [PATCH 4/4] scsi: hisi_sas: Add support for DIF/DIX feature for v3 hw

2018-11-26 Thread John Garry
On 24/11/2018 17:50, kbuild test robot wrote: Hi Xiang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on next-20181123] [cannot apply to v4.20-rc3] [if your patch is applied to the wrong git tree, please drop us a

RE: [PATCH] scsi: ufs: add fall through annotation

2018-11-26 Thread Avri Altman
> -Original Message- > From: Tomas Winkler > Sent: Monday, November 26, 2018 10:11 AM > To: James E . J . Bottomley ; Martin K . Petersen > ; Vinayak Holikatti > ; Avri Altman > Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; Tomas Winkler > > Subject: [PATCH] scsi: ufs: ad

[PATCHv4 0/3] scsi timeout handling updates

2018-11-26 Thread Keith Busch
The iterative update to the previous version taking into account review comments. Background: The main objective is to remove the generic block layer's lock prefix currently required to transition a request to its completed state by shifting that expense to lower level drivers that actually need

[PATCHv4 2/3] scsi: Do not rely on blk-mq for double completions

2018-11-26 Thread Keith Busch
The scsi timeout error handling had been directly updating the block layer's request state to prevent a error handling and a natural completion from completing the same request twice. Fix this layering violation by having scsi control the fate of its commands with scsi owned flags rather than use b

[PATCHv4 1/3] blk-mq: Return true if request was completed

2018-11-26 Thread Keith Busch
A driver may have internal state to cleanup if we're pretending a request didn't complete. Return 'false' if the command wasn't actually completed due to the timeout error injection, and true otherwise. Signed-off-by: Keith Busch --- block/blk-mq.c | 5 +++-- include/linux/blk-mq.h | 2 +

[PATCHv4 3/3] blk-mq: Simplify request completion state

2018-11-26 Thread Keith Busch
There are no more users relying on blk-mq request states to prevent double completions, so replace the relatively expensive cmpxchg operation with WRITE_ONCE. Signed-off-by: Keith Busch --- block/blk-mq.c | 4 +--- include/linux/blk-mq.h | 14 -- 2 files changed, 1 insertion

Re: [PATCHv4 1/3] blk-mq: Return true if request was completed

2018-11-26 Thread Christoph Hellwig
On Mon, Nov 26, 2018 at 09:54:28AM -0700, Keith Busch wrote: > A driver may have internal state to cleanup if we're pretending a request > didn't complete. Return 'false' if the command wasn't actually completed > due to the timeout error injection, and true otherwise. > > Signed-off-by: Keith Bus

Re: [PATCHv4 3/3] blk-mq: Simplify request completion state

2018-11-26 Thread Christoph Hellwig
On Mon, Nov 26, 2018 at 09:54:30AM -0700, Keith Busch wrote: > There are no more users relying on blk-mq request states to prevent > double completions, so replace the relatively expensive cmpxchg operation > with WRITE_ONCE. > > Signed-off-by: Keith Busch Looks good, Reviewed-by: Christoph Hel

Re: [PATCHv4 2/3] scsi: Do not rely on blk-mq for double completions

2018-11-26 Thread Christoph Hellwig
On Mon, Nov 26, 2018 at 09:54:29AM -0700, Keith Busch wrote: > The scsi timeout error handling had been directly updating the block > layer's request state to prevent a error handling and a natural completion > from completing the same request twice. Fix this layering violation > by having scsi con

Re: remove exofs, the T10 OSD code and block/scsi bidi support V3

2018-11-26 Thread Boaz Harrosh
On 11/11/18 15:32, Christoph Hellwig wrote: > The only real user of the T10 OSD protocol, the pNFS object layout > driver never went to the point of having shipping products, and we > removed it 1.5 years ago. Exofs is just a simple example without > real life users. > You have failed to say wha

Re: [PATCHv4 0/3] scsi timeout handling updates

2018-11-26 Thread Jens Axboe
On 11/26/18 9:54 AM, Keith Busch wrote: > The iterative update to the previous version taking into account review > comments. > > Background: > > The main objective is to remove the generic block layer's lock prefix > currently required to transition a request to its completed state by > shifting

Re: [PATCH] libiscsi: Fix NULL pointer dereference in iscsi_eh_session_reset

2018-11-26 Thread Lee Duncan
On 11/20/18 5:22 PM, fred.her...@oracle.com wrote: > From: Fred Herard > > This commit addresses NULL pointer dereference in iscsi_eh_session_reset. > Reference should not be made to session->leadconn when session->state > is set to ISCSI_STATE_TERMINATE. > > Signed-off-by: Fred Herard > Review

Re: [PATCH] iscsi: Capture iscsi debug messages using tracepoints

2018-11-26 Thread Lee Duncan
On 11/21/18 9:04 AM, fred.her...@oracle.com wrote: > From: Fred Herard > > This commit enhances iscsi initiator modules to capture iscsi debug messages > using linux kernel tracepoint facility: > > https://www.kernel.org/doc/Documentation/trace/tracepoints.txt > > The following tracepoint event

Re: [PATCH] iscsi: Capture iscsi debug messages using tracepoints

2018-11-26 Thread Douglas Gilbert
Lee, See about 3/4 of the way down your patch. Summary: how about generalizing the message logging to tracefs so the whole SCSI subsystem can use it? Doug Gilbert On 2018-11-26 8:01 p.m., Lee Duncan wrote: On 11/21/18 9:04 AM, fred.her...@oracle.com wrote: From: Fred Herard This commit enh

Re: [smartmontools-support] [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-26 Thread Bruce Allen
Dear Linus, Dear Martin, About fifteen years ago, soon after I got interested in SMART and starting working on smartmontools, I wrote some kernel code that added smart data into /sys. (Actually this was around the 2.4 transition so it was under /proc along with lots of other stuff that had nothin

[PATCH] scsi: ufs: Use PTR_ERR_OR_ZERO to replace the open coded version

2018-11-26 Thread Wen Yang
PTR_ERR_OR_ZERO has implemented the same function, so use inlined function instead of open coded equivalent. Signed-off-by: Wen Yang CC: Vinayak Holikatti CC: "James E.J. Bottomley" CC: "Martin K. Petersen" CC: linux-scsi@vger.kernel.org CC: Wen Yang CC: linux-ker...@vger.kernel.org --- driv