On 11/20/18 5:22 PM, fred.her...@oracle.com wrote: > From: Fred Herard <fred.her...@oracle.com> > > This commit addresses NULL pointer dereference in iscsi_eh_session_reset. > Reference should not be made to session->leadconn when session->state > is set to ISCSI_STATE_TERMINATE. > > Signed-off-by: Fred Herard <fred.her...@oracle.com> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > --- > drivers/scsi/libiscsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c > index 088e903..21d2a6d 100644 > --- a/drivers/scsi/libiscsi.c > +++ b/drivers/scsi/libiscsi.c > @@ -2426,8 +2426,8 @@ int iscsi_eh_session_reset(struct scsi_cmnd *sc) > failed: > ISCSI_DBG_EH(session, > "failing session reset: Could not log back into " > - "%s, %s [age %d]\n", session->targetname, > - conn->persistent_address, session->age); > + "%s [age %d]\n", session->targetname, > + session->age); > spin_unlock_bh(&session->frwd_lock); > mutex_unlock(&session->eh_mutex); > return FAILED; >
Reviewed-by: Lee Duncan <ldun...@suse.com>
