The battery in my HP NetRAID-4M died of old age, and the aacraid driver
started oopsing with NULL pointer dereference on startup after that.
Fix it by reordering the init sequence to fill in function pointers
before ioremapping memory, or dev->a_ops.adapter_ioremap pointer will be
NULL.
Other
>a/configure.ac b/configure.ac index 1cce0b25f583..129c2f9d4d4d 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -7,13 +7,13 @@ AM_CONFIG_HEADER(config.h) AC_PROG_CC #
>AC_PROG_CXX AC_PROG_INSTALL
>-
>-# Adding libtools to the build seems to bring in C++ environment -
>AC_PROG_LIBTOOL
>
> # AM
Hi, Bart and Dong
Do you think we need to submit all changed diff including some generated files
by automake?
Such as config.h.in, Makefile.in..., in fact, we only manually did a few
modificaiton on
Some files such as configura.ac,makefile.am.
>
>Hello Doug,
>
>The four patches in this series i
Raghava Aditya Renukunta writes:
> The device hotplug events are processed only after retrieving the updated
> lun information from the fw. Does not make sense to keep them separate.
>
> Merge both the hotplug handling and safw adapter setup code into single
> function.
>
> Signed-off-by: Raghava
On 2018-01-03 04:37 AM, Bean Huo (beanhuo) wrote:
Hi, Bart and Dong
Do you think we need to submit all changed diff including some generated files
by automake?
Such as config.h.in, Makefile.in..., in fact, we only manually did a few
modificaiton on
Some files such as configura.ac,makefile.am.
On Tuesday, December 19, 2017 10:15:07 AM Joe Perches wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
>
> Done with perl script:
>
> $ git grep -w --name-only DEVICE_ATTR | \
> xargs perl -i -e 'local $/; while (<>) {
> s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(\s*S_IRUGO\s*\|
Hi Nikola,
> -Original Message-
> From: Nikola Pajkovsky [mailto:npajkov...@suse.cz]
> Sent: Wednesday, January 3, 2018 2:02 AM
> To: Raghava Aditya Renukunta
>
> Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux-
> s...@vger.kernel.org; Scott Benesh ; Tom
> White ; dl-esc-Aa
> -Original Message-
> From: mr...@math.ut.ee [mailto:mr...@math.ut.ee] On Behalf Of Meelis
> Roos
> Sent: Wednesday, January 3, 2018 1:11 AM
> To: linux-scsi@vger.kernel.org; dl-esc-Aacraid Linux Driver
>
> Subject: [PATCH] aacraid driver oops with dead battery
>
> EXTERNAL EMAIL
>
>
On Wed, 2018-01-03 at 12:16 -0500, Woody Suwalski wrote:
> Starting with a 32-bit 4.15-rcX I have observed a warning in dmesg,
> happening when the system goes to suspend2ram. If it is just a warning
> - could we have it quiet'et down?
(+linux-scsi)
Thank you for having reported this. The comment
On 2017-10-26 02:31 AM, Martin K. Petersen wrote:
Doug,
The sd_setup_read_write_cmnd() function is on the "fast path" for
block system access to SCSI devices (logical units). Rewrite this
function to improve speed and readability.
Please do any optimizations on top of my scsi-work branch whi
On Tue, Jan 02, 2018 at 04:17:24PM -0600, Bjorn Helgaas wrote:
> On Tue, Jan 02, 2018 at 06:53:52PM +0100, Romain Perier wrote:
> > The current PCI pool API are simple macro functions direct expanded to
> > the appropriate dma pool functions. The prototypes are almost the same
> > and semantically,
This patch series contains miscellaneous fixes. The first patch fixes a
bug while the rest improve the code structure and prepare the code for
future enhancements.
This series is intended for 4.16 and is bisectable.
Matthew R. Ochs (3):
cxlflash: Explicitly cache number of interrupts per contex
Convert cxl-specific pointers to generic cookies to facilitate future
enhancements.
Signed-off-by: Uma Krishnan
---
drivers/scsi/cxlflash/common.h| 4 ++--
drivers/scsi/cxlflash/main.c | 38 +++---
drivers/scsi/cxlflash/superpipe.c | 15 +++
In the event of a command failure, cxlflash returns the failure to the
upper layers to process. After processing the error, when the command is
queued again, the private command structure will not be zeroed and the
ioasc could be stale. Per the SISLite specification, the AFU only sets the
ioasc in
From: "Matthew R. Ochs"
The number of interrupts a user requests during a context attach is
presently stored within the CXL work ioctl structure that is nested
alongside the per context metadata. Keeping this data in a structure
that is tied to a particular hardware implementation (CXL) will only
From: "Matthew R. Ochs"
The CXL-specific work structure used to request the number of interrupts
currently resides as a nested member of both the context information and
hardware queue structures. It is used to cache values (specifically the
number of interrupts) required by the CXL layer when st
Adapter context creation can return either NULL or an error pointer.
Updating the check condition to reflect this.
Signed-off-by: Uma Krishnan
---
drivers/scsi/cxlflash/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash
From: "Matthew R. Ochs"
As staging to support future accelerator transports, add a shim layer
such that the underlying services the cxlflash driver requires can be
conditional upon the accelerator infrastructure.
Signed-off-by: Matthew R. Ochs
Signed-off-by: Uma Krishnan
---
drivers/scsi/cxlf
For function dma_unmap_sg(), the parameter should be number of
elements in the scatterlist prior to the mapping, not after the mapping.
Fix this usage.
Cc: Jack Wang
Cc: lindar_...@usish.com
Fixes: dbf9bfe6("[SCSI]pm8001: add SAS/SATA/HBA driver")
Signed-off-by: Xiang Chen
---
drivers/scsi/pm8
For function dma_unmap_sg(), the parameter should be number of
elements in the scatterlist prior to the mapping, not after the mapping.
Fix this usage.
Cc: Artur Paszkiewicz
Cc: Dan Williams
Fixes: d9dcb4ba7("isci: unify isci_host and scic_sds_controller")
Signed-off-by: Xiang Chen
---
driver
According to Documentation/DMA-API.txt, all the parameters of dma_unmap_sg()
must be the same as those and passed in to the scatter/gather mapping API.
But in scsi drivers such as ibmscsi_tgt/iscsi/mvsas/pm8001, the
parameter of dma_unmap_sg() is number of elements after mapping. So fix them.
Par
For function dma_unmap_sg(), the parameter should be number of
elements in the scatterlist prior to the mapping, not after the mapping.
Fix this usage.
Cc: Xiangliang Yu
Cc: Jeff Garzik
Fixes: 0b15fb1fd("[SCSI]mvsas: add support for Task collector mode and fixed
relative
bugs")
Signed-off-by:
For function dma_unmap_sg(), the parameter should be number of
elements in the scatterlist prior to the mapping, not after the mapping.
Fix this usage.
Cc: Bryant G. Ly
Cc: Michael Cyr
Fixes: 88a678bb("ibmscsis: Initial commit of IBM VSCSI Tgt Driver")
Signed-off-by: Xiang Chen
---
drivers/sc
Johannes,
> All in all I'm so much in favour of this cleanup patch (and even would
> apprechiate more of these, especailly getting rid of all those
> camelCase foo we have in the scsi hba drivers).
>
> Let's see how Martin and James deceide about it.
I am thoroughly annoyed by all the legacy whi
Rafael,
> If, for any reason, userland shuts down iscsi transport interfaces
> before proper logouts - like when logging in to LUNs manually, without
> logging out on server shutdown, or when automated scripts can't
> umount/logout from logged LUNs - kernel will hang forever on its
> sd_sync_cach
Andy,
> The function sas_parse_addr() could be easily substituted by hex2bin()
> which is in kernel library code.
Applied to 4.16/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Hi Jeremy,
> When no caching mode information can be found for a disk, use the
> warning log level rather than error. It is common for this to occur
> with cheap USB sticks.
Just because something is common occurrence doesn't mean it's not an
error. What's the rationale behind demoting this to a
James,
> The define names specified 64Bit/128Bit, not 64GBIT/128GBIT.
> Correct the names.
Applied to 4.16/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> localport is being dereferenced to assign lport and then immediately
> afterwards localport is being sanity checked to see if it is null.
> Fix this by only dereferencing localport until after it has been
> null checked.
Applied to 4.16/scsi-queue, thanks!
--
Martin K. Petersen O
Colin,
> Several statements are indented too far, fix these
Applied to 4.16/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Suganath,
> This patch set is initially posted by Hannes Reinecke to enable scsi
> multiqueue for the mpt3sas driver. While the HBA only has a single
> mailbox register for submitting commands, it does have individual
> receive queues per MSI-X interrupt and as such does benefit from
> convertin
Chaitra,
> This patch fixes above two issues by setting of "ATA command pending" flag
> after checking for whether device deleted, invalid device handle, device
> busy with task management. And by setting "ATA command pending" flag to
> false in all of the qcmd failure return paths after sett
Randy,
> Fix kernel-doc warnings in drivers/scsi/ that are related to iscsi
> support interfaces.
>
> Fixes these kernel-doc warnings: (tested by adding these files to a new
> target.rst documentation file: WIP)
Applied to 4.16/scsi-queue, thanks!
> Cc: "Nicholas A. Bellinger"
> Cc: linux-
Raghava,
> This patchset primarily lays the foundation for adding sas transport
> support to the aacraid driver. Being said these patches are mainly
> code refactors, bug fixes and improvements.
Applied to 4.16/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Julia,
> hpsa_show_dev_msg prints other information and a newline after the
> message string, so the message string does not need to include a
> newline explicitly. Done using Coccinelle.
Applied to 4.16/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
On 01/03/2018 08:11 PM, Martin K. Petersen wrote:
>
> Randy,
>
>> Fix kernel-doc warnings in drivers/scsi/ that are related to iscsi
>> support interfaces.
>>
>> Fixes these kernel-doc warnings: (tested by adding these files to a new
>> target.rst documentation file: WIP)
>
> Applied to 4.16/scs
Hi Himanshu!
> This series contains number of improvments in handling of switch
> registration commands in the driver. Switch commands are now submitted
> via IOCB patch asynchronously instead of mailbox interface.
Applied to 4.16/scsi-queue. However, ...
> 17 files changed, 2891 insertions(+)
John,
> At this point we feel that we have a decent solution to the
> long-standing libsas hotplug issues.
>
> Hannes has kindly reviewed the series.
>
> Can you let us know what else you require for acceptance? More
> independent review or testing?
According to my notes, Hannes had some concern
Meelis,
> The battery in my HP NetRAID-4M died of old age, and the aacraid
> driver started oopsing with NULL pointer dereference on startup after
> that.
>
> Fix it by reordering the init sequence to fill in function pointers
> before ioremapping memory, or dev->a_ops.adapter_ioremap pointer wil
Himanshu,
> Use dma_zalloc_coherent and vzalloc instead of dma_alloc_coherent and
> vmalloc respectively, followed by memset 0.
Applied to 4.16/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> Use dma_zalloc_coherent instead of dma_alloc_coherent followed by memset
> 0.
Applied to 4.16/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Hi Martin,
> On Jan 3, 2018, at 9:59 PM, Martin K. Petersen
> wrote:
>
>
> Hi Himanshu!
>
>> This series contains number of improvments in handling of switch
>> registration commands in the driver. Switch commands are now submitted
>> via IOCB patch asynchronously instead of mailbox interfac
Himanshu,
> Use vzalloc instead of vmalloc followed by memset 0.
Applied to 4.16/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> Use dma_zalloc_coherent instead of dma_alloc_coherent followed by
> memset 0.
Applied to 4.16/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> Use dma_zalloc_coherent instead of dma_alloc_coherent followed by memset
> 0.
Does not apply to 4.16/scsi-queue. Please resubmit. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> Use dma_zalloc_coherent instead of dma_alloc_coherent followed by
> memset 0.
Does not apply to 4.16/scsi-queue. Please resubmit. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
On 04/01/18 09:54, Uma Krishnan wrote:
In the event of a command failure, cxlflash returns the failure to the
upper layers to process. After processing the error, when the command is
queued again, the private command structure will not be zeroed and the
ioasc could be stale. Per the SISLite speci
Hello Martin,
On Thu, Jan 04, 2018 at 01:17:52AM -0500, Martin K. Petersen wrote:
>
> Himanshu,
>
> > Use dma_zalloc_coherent instead of dma_alloc_coherent followed by
> > memset 0.
>
> Does not apply to 4.16/scsi-queue. Please resubmit. Thanks!
No problem, I will resend the patch.
scsi: qla4
48 matches
Mail list logo
