On 2018-01-03 04:37 AM, Bean Huo (beanhuo) wrote:
Hi, Bart and Dong Do you think we need to submit all changed diff including some generated files by automake? Such as config.h.in, Makefile.in..., in fact, we only manually did a few modificaiton on Some files such as configura.ac,makefile.am.
Hi, Yes, I only needed the configure.ac and Makefile.am changes from Bart. Anyway, they are in my sg3_utils subversion rev 742 which should appear soon on Hannes' site: https://github.com/hreinecke/sg3_utils Currently it is at rev 741. sgp_dd was also changed to only use pthread_kill() with the older code "#if 0"-ed out just in case it needs to be revisited. The checking macros for pthread_cancel() and pthread_kill() are still in configure.ac . Doug Gilbert
The four patches in this series is what I came up with after having reviewed the sg3_utils configure script. Please consider to apply these patches on the sg3_utils trunk. Thanks, Bart. Bart Van Assche (4): configure.ac: Suppress an autoconf warning configure.ac: Only link with the pthread library if required configure.ac: Avoid code duplication configure.ac, Makefile.am: Use CFLAGS and LIBS instead of os_cflags and os_libs Makefile.in | 3 +- config.h.in | 6 +- configure | 672 +++++++++++++++++++--------------------------------- configure.ac | 83 +++---- doc/Makefile.in | 3 +- include/Makefile.in | 3 +- lib/Makefile.am | 2 +- lib/Makefile.in | 5 +- scripts/Makefile.in | 3 +- src/Makefile.am | 140 ++++++----- src/Makefile.in | 145 ++++++------ 11 files changed, 425 insertions(+), 640 deletions(-) -- 2.15.1
