On Tue, Dec 19, 2017 at 12:02:53PM -0800, Jaegeuk Kim wrote:
> From: Jaegeuk Kim
>
> This patch introduces attribute group to show existing sysfs entries.
>
> Cc: Greg KH
> Signed-off-by: Jaegeuk Kim
> ---
> drivers/scsi/ufs/ufshcd.c | 48
> +++
>
Thanks a lot,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
>
...
> diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
> index 7a54e3083203..79d4dc785e5c 100644
> --- a/sound/soc/omap/mcbsp.c
> +++ b/sound/soc/omap/mcbsp.c
On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
> On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
[]
> > diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
[]
> > @@ -854,7 +854,7 @@ static ssize_t dma_op
On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote:
> On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
> > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> > > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
> []
> > > diff --git a/sound/soc/omap/mcbsp.c b/
On Tue, Dec 19, 2017 at 02:46:44PM -0800, Jaegeuk Kim wrote:
> >From 3368207da5988b8fed4e41e6c0f49a60ac014222 Mon Sep 17 00:00:00 2001
> From: Jaegeuk Kim
> Date: Tue, 26 Sep 2017 20:53:48 -0700
> Subject: [PATCH 2/2] scsi: ufs: introduce sysfs entries exposing UFS health
> info
>
> This patch a
Vous devez mettre à jour maintenant le plus récent ZIMBRA! Mail pour éviter la
fermeture. Une fois votre compte mis à jour, nous rétablirons votre statut
normal.
Mettre à niveau Zimbra maintenant: http://isjkkd-xkshn-dnduek.tripod.com/
Donc,
ZIMBRA Mail services
Hi,
Joe Perches writes:
> drivers/usb/phy/phy-tahvo.c| 2 +-
Acked-by: Felipe Balbi
--
balbi
On Wed, 2017-12-20 at 10:32 +0100, Greg Kroah-Hartman wrote:
> On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote:
> > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
> > > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> > > > Convert DEVICE_ATTR uses to DEVICE_ATTR_
On Wed, Dec 20, 2017 at 01:54:41AM -0800, Joe Perches wrote:
> On Wed, 2017-12-20 at 10:32 +0100, Greg Kroah-Hartman wrote:
> > On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote:
> > > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
> > > > On Tue, Dec 19, 2017 at 10:15:07AM -0800
On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote:
> > > Why you didn't send that patch to the sysfs maintainer is a bit odd... :)
> >
> > So here's an opportunity for you:
> >
> > The sysfs maintainer hasn't added include/linux/sysfs.h to
> > the list of maintained files...
> >
> > D
On Wed, Dec 20, 2017 at 10:32:11AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote:
> > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
> > > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> > > > Convert DEVICE_ATTR uses to DEVIC
On Wed, 20 Dec 2017, Joe Perches wrote:
> On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote:
> > > > Why you didn't send that patch to the sysfs maintainer is a bit odd...
> > > > :)
> > >
> > > So here's an opportunity for you:
> > >
> > > The sysfs maintainer hasn't added include/l
On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
> Name pointer for sp describing each command is assigned with stack
> frame's memory. The stack frame could eventually be re-use, where
> name pointer access can get get garbage. This patch designates
> static memory for name pointer to fi
On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
> From: Quinn Tran
>
> when preocessing iocb in a timeout case, driver was trying to log messages
^^^
processing?
Bart.
On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
> @@ -536,7 +541,7 @@ struct sp_name {
> #define SRB_NVME_CMD 19
> #define SRB_NVME_LS 20
> #define SRB_PRLI_CMD 21
> -
> +#define SRB_CTRL_VP 22
> enum {
Please keep the blank line between the #define block and the enum definition.
On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
> From: Quinn Tran
>
> IRQ name pointer for INTx/MSI was pointing at stale stack frame.
> cat /proc/interrupts will trigger stale mem access. Fix it by
> creating dedicated space for IRQ name.
What stale stack frame are you referring to?
On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
> +#define QLA_ENA_FW_RES_TRACKING(_ha) { \
> + int i; \
> + _ha->base_qpair->fw_res_tracking = 1; \
> + for (i = 0; i < _ha->max_qpairs; i++) { \
> + if (_ha->queue_pair_map[i]) \
> + _ha->queue_pair_ma
On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
> +int qla2xuseresexchforels;
> +module_param(qla2xuseresexchforels, int, 0444);
> +MODULE_PARM_DESC(qla2xuseresexchforels,
> + "Reserve 1/2 of emergency exchanges for ELS.\n"
> + " 0 (default): disabled");
Same q
From: Jakub Kicinski
Date: Tue, 19 Dec 2017 15:46:51 -0800
> On Tue, 19 Dec 2017 16:05:23 +0200, Tomer Tayar wrote:
>> Sorry for the very long patch.
>> The firmware changes are spread all over w/o a good modularity.
>
> Rings false. Significant portion of this patch is just whitespace
> and c
On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
> @@ -1234,8 +1234,6 @@ void qlt_schedule_sess_for_deletion(struct fc_port
> *sess,
> ql_dbg(ql_dbg_tgt, sess->vha, 0xe001,
> "Scheduling sess %p for deletion\n", sess);
>
> - /* use cancel to push work element throug
On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
> @@ -4915,12 +4941,32 @@ static int qlt_24xx_handle_els(struct scsi_qla_host
> *vha,
> }
>
> if (sess != NULL) {
> + bool delete = false;
> spin_lock_irqsave(&tgt->ha
> > Hey Ewan, Yan, Bart,
> >
> > I'm still seeing this issue with 4.15-rc4. Is the issue still outstanding?
> >
> > Steve.
> >
>
> Please apply the following commit from the 4.15/scsi-fixes branch of
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
>
> and advise if it does not fi
From: Jaegeuk Kim
This patch introduces attribute group to show existing sysfs entries.
Cc: Greg Kroah-Hartman
Signed-off-by: Jaegeuk Kim
---
Change log from v1:
- use ATTRIBUTE_GROUPS and sysfs_create_groups()
drivers/scsi/ufs/ufshcd.c | 46 +-
From: Jaegeuk Kim
This patch adds a new sysfs group, namely health, via:
/sys/devices/soc/X.ufshc/health/
This directory contains the below entries, each of which shows an 8-bytes
hex number representing different meanings defined by JEDEC specfication.
Users can simply read these entries t
On Wed, 2017-12-20 at 11:16 -0800, Jaegeuk Kim wrote:
> From: Jaegeuk Kim
Hello Jaegeuk,
For future patch series submissions, please include a cover letter that explains
the purpose of the patch series and please also document the changes between the
different versions of the patch series in the
On 12/20, gre...@linuxfoundation.org wrote:
> On Tue, Dec 19, 2017 at 02:46:44PM -0800, Jaegeuk Kim wrote:
> > >From 3368207da5988b8fed4e41e6c0f49a60ac014222 Mon Sep 17 00:00:00 2001
> > From: Jaegeuk Kim
> > Date: Tue, 26 Sep 2017 20:53:48 -0700
> > Subject: [PATCH 2/2] scsi: ufs: introduce sysfs
On 12/20, Greg KH wrote:
> On Tue, Dec 19, 2017 at 12:02:53PM -0800, Jaegeuk Kim wrote:
> > From: Jaegeuk Kim
> >
> > This patch introduces attribute group to show existing sysfs entries.
> >
> > Cc: Greg KH
> > Signed-off-by: Jaegeuk Kim
> > ---
> > drivers/scsi/ufs/ufshcd.c | 48
> > ++
Hi Bart,
On 12/20, Bart Van Assche wrote:
> On Wed, 2017-12-20 at 11:16 -0800, Jaegeuk Kim wrote:
> > From: Jaegeuk Kim
>
> Hello Jaegeuk,
>
> For future patch series submissions, please include a cover letter that
> explains
> the purpose of the patch series and please also document the chang
Hi Bart,
> On Dec 20, 2017, at 10:25 AM, Bart Van Assche wrote:
>
> On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
>> Name pointer for sp describing each command is assigned with stack
>> frame's memory. The stack frame could eventually be re-use, where
>> name pointer access can ge
> On Dec 20, 2017, at 10:26 AM, Bart Van Assche wrote:
>
> On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
>> From: Quinn Tran
>>
>> when preocessing iocb in a timeout case, driver was trying to log messages
> ^^^
> processing?
>
> Bart.
Will fix in v2 of the s
> On Dec 20, 2017, at 10:29 AM, Bart Van Assche wrote:
>
> On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
>> @@ -536,7 +541,7 @@ struct sp_name {
>> #define SRB_NVME_CMD 19
>> #define SRB_NVME_LS 20
>> #define SRB_PRLI_CMD 21
>> -
>> +#define SRB_CTRL_VP 22
>> enum {
>
> Please kee
> On Dec 20, 2017, at 10:39 AM, Bart Van Assche wrote:
>
> On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
>> From: Quinn Tran
>>
>> IRQ name pointer for INTx/MSI was pointing at stale stack frame.
>> cat /proc/interrupts will trigger stale mem access. Fix it by
>> creating dedicate
> On Dec 20, 2017, at 10:51 AM, Bart Van Assche wrote:
>
> On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
>> +#define QLA_ENA_FW_RES_TRACKING(_ha) { \
>> +int i; \
>> +_ha->base_qpair->fw_res_tracking = 1; \
>> +for (i = 0; i < _ha->max_qpairs; i++) { \
>> +i
Hi Bart,
> On Dec 20, 2017, at 10:53 AM, Bart Van Assche wrote:
>
> On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
>> +int qla2xuseresexchforels;
>> +module_param(qla2xuseresexchforels, int, 0444);
>> +MODULE_PARM_DESC(qla2xuseresexchforels,
>> + "Reserve 1/2 of emergenc
> On Dec 20, 2017, at 10:56 AM, Bart Van Assche wrote:
>
> On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
>> @@ -1234,8 +1234,6 @@ void qlt_schedule_sess_for_deletion(struct fc_port
>> *sess,
>> ql_dbg(ql_dbg_tgt, sess->vha, 0xe001,
>> "Scheduling sess %p for deletion\
This patch adds a new sysfs group, namely health, via:
/sys/devices/soc/X.ufshc/health/
This directory contains the below entries, each of which shows an 8-bytes
hex number representing different meanings defined by JEDEC specfication.
Users can simply read these entries to check how their un
Hi Ewan,
> On Dec 20, 2017, at 12:09 PM, Ewan D. Milne wrote:
>
> On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
>> @@ -4915,12 +4941,32 @@ static int qlt_24xx_handle_els(struct scsi_qla_host
>> *vha,
>> }
>>
>> if (sess != NULL) {
>> +
Two simple fixes: one for sparse warnings that were introduced by the
merge window conversion to blist_flags_t and the other to fix dropped
I/O during reset in aacraid.
The patch is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
The short changelog is:
Ba
On Tue, 2017-12-19 at 10:15 -0800, Joe Perches wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
>
> Done with perl script:
>
> $ git grep -w --name-only DEVICE_ATTR | \
> xargs perl -i -e 'local $/; while (<>) {
> s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(\s*S_IRUGO\s*\|\s*S_IWU
On Tue, 2017-12-19 at 10:15 -0800, Joe Perches wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible.
>
> Done with perl script:
>
> $ git grep -w --name-only DEVICE_ATTR | \
> xargs perl -i -e 'local $/; while (<>) {
> s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IRUGO\s*|\s*0444
On Tue, 2017-12-19 at 10:15 -0800, Joe Perches wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_WO where possible.
>
> Done with perl script:
>
> $ git grep -w --name-only DEVICE_ATTR | \
> xargs perl -i -e 'local $/; while (<>) {
> s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IWUSR\s*|\s*0200
Cathy,
> When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN
> which has zero good_bytes it must be assigned an error. Otherwise the
> I/O will be continuously requeued and will cause a deadlock in the
> case where disks are being hot added and removed. sd_probe_async will
> wait
James,
> Prior patch mixed up what argument in the macro was what, so min
> value was placed as the "default" argument, and the default value
> was placed as the "min" argument. Thus, when the default was applied,
> it looked like the default was smaller than the allowed min.
>
> swap argument po
My editor always try to remove the extra white space at the end of the
line when I make some changes. I'm tired of adjusting them manually.
Can we remove them in mainline?
Signed-off-by: Jason Yan
---
drivers/scsi/scsi.c | 2 +-
drivers/scsi/scsi_lib.c | 20 ++--
drivers
>> For future patch series submissions, please include a cover letter
>> that explains the purpose of the patch series and please also
>> document the changes between the different versions of the patch
>> series in the cover letter.
>
> Yup, I'll be aware of it. Thank you for the advice.
These l
> If, for any reason, userland shuts down iscsi transport interfaces
> before proper logouts - like when logging in to LUNs manually, without
> logging out on server shutdown, or when automated scripts can't
> umount/logout from logged LUNs - kernel will hang forever on its
> sd_sync_cache() logic
Fixes: a3e84f0484ea ("qla2xxx: Fix stale memory access for name pointer")
Signed-off-by: Fengguang Wu
---
qla_gs.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index 7e88e828..54c8dfd 100644
--- a/drivers/scs
Hi Quinn,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on scsi/for-next]
[also build test WARNING on next-20171220]
[cannot apply to v4.15-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
Jason,
On 12/21/17 11:40, Jason Yan wrote:
> My editor always try to remove the extra white space at the end of the
> line when I make some changes. I'm tired of adjusting them manually.
> Can we remove them in mainline?
>
> Signed-off-by: Jason Yan
> ---
> drivers/scsi/scsi.c | 2 +-
>
Hi Quinn,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on scsi/for-next]
[also build test WARNING on next-20171220]
[cannot apply to v4.15-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
From: Christoph Hellwig
Components relying only on the request_queue structure for accessing
block devices (e.g. I/O schedulers) have a limited knowledged of the
device characteristics. In particular, the device capacity cannot be
easily discovered, which for a zoned block device also result in t
This series, formerly titled "scsi-mq support for ZBC disks", implements
support for ZBC disks for system using the scsi-mq I/O path.
The current scsi level support of ZBC disks guarantees write request ordering
using a per-zone write lock which prevents issuing simultaneously multiple
write comma
Avoid directly referencing the next_rq and fifo_list arrays using the
helper functions deadline_next_request() and deadline_fifo_request() to
facilitate changes in the dispatch request selection in
deadline_dispatch_requests() for zoned block devices.
While at it, also remove the unnecessary forwa
Initialize the seq_zones_bitmap, seq_zones_wlock and nr_zones fields of
the disk request queue on disk revalidate. As the seq_zones_bitmap
and seq_zones_wlock allocations are identical, introduce the helper
sd_zbc_alloc_zone_bitmap(). Using this helper, reallocate the bitmaps
whenever the disk capa
Introduce zone write locking to avoid write request reordering with
zoned block devices. This is achieved using a finer selection of the
next request to dispatch:
1) Any non-write request is always allowed to proceed.
2) Any write to a conventional zone is always allowed to proceed.
3) For a write
The block layer now handles zone write locking.
Signed-off-by: Damien Le Moal
Reviewed-by: Christoph Hellwig
Reviewed-by: Martin K. Petersen
---
drivers/scsi/sd.c| 41 +++-
drivers/scsi/sd.h| 11 ---
drivers/scsi/sd_zbc.c| 83
Avoid directly referencing the next_rq and fifo_list arrays using the
helper functions deadline_next_request() and deadline_fifo_request() to
facilitate changes in the dispatch request selection in
__dd_dispatch_request() for zoned block devices.
Signed-off-by: Damien Le Moal
Reviewed-by: Bart Va
Introduce zone write locking to avoid write request reordering with
zoned block devices. This is achieved using a finer selection of the
next request to dispatch:
1) Any non-write request is always allowed to proceed.
2) Any write to a conventional zone is always allowed to proceed.
3) For a write
For function dma_unmap_sg(), the parameter should be number of
elements in the scatterlist prior to the mapping, not after the mapping.
So fix this usage in ibmvscsi_tgt/isci/mvsas/pm8001.
Signed-off-by: Xiang Chen
---
drivers/scsi/ibmvscsi_tgt/libsrp.c | 6 --
drivers/scsi/isci/request.c
60 matches
Mail list logo
