> On Dec 20, 2017, at 10:56 AM, Bart Van Assche <bart.vanass...@wdc.com> wrote:
> 
> On Tue, 2017-12-19 at 22:56 -0800, Himanshu Madhani wrote:
>> @@ -1234,8 +1234,6 @@ void qlt_schedule_sess_for_deletion(struct fc_port 
>> *sess,
>>      ql_dbg(ql_dbg_tgt, sess->vha, 0xe001,
>>          "Scheduling sess %p for deletion\n", sess);
>> 
>> -    /* use cancel to push work element through before re-queue */
>> -    cancel_work_sync(&sess->del_work);
>>      INIT_WORK(&sess->del_work, qla24xx_delete_sess_fn);
>>      queue_work(sess->vha->hw->wq, &sess->del_work);
> 
> Why had this cancel_work_sync() call been introduced in
> qlt_schedule_sess_for_deletion() and why do you think it is safe to remove
> this call? Both questions should have been answered in the patch description.
> 
> Thanks,
> 
> Bart.

I will drop this patch from current series and will update commit message with 
details
as suggested and submit in next series.

Thanks,
- Himanshu

Reply via email to